Re: [Intel-gfx] [PATCH] drm/i915/display: Only fail fastset on PSR2

2023-10-31 Thread Hogander, Jouni
On Tue, 2023-10-31 at 23:21 +, Paz Zcharya wrote: > Currently, i915 fails fastset if both the sink and the source support > any version of PSR and regardless of the configuration setting of the > driver (i.e., i915.enable_psr kernel argument). However, the > implementation of PSR1 enable sequen

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Improve BW management on MST links (rev8)

2023-10-31 Thread Patchwork
== Series Details == Series: drm/i915: Improve BW management on MST links (rev8) URL : https://patchwork.freedesktop.org/series/125490/ State : success == Summary == CI Bug Log - changes from CI_DRM_13814 -> Patchwork_125490v8 Summary -

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for fix DRM_USE_DYNAMIC_DEBUG=y regression (rev5)

2023-10-31 Thread Patchwork
== Series Details == Series: fix DRM_USE_DYNAMIC_DEBUG=y regression (rev5) URL : https://patchwork.freedesktop.org/series/125063/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for fix DRM_USE_DYNAMIC_DEBUG=y regression (rev5)

2023-10-31 Thread Patchwork
== Series Details == Series: fix DRM_USE_DYNAMIC_DEBUG=y regression (rev5) URL : https://patchwork.freedesktop.org/series/125063/ State : warning == Summary == Error: dim checkpatch failed 4929242ff04f test-dyndbg: fixup CLASSMAP usage error 369c6289e760 dyndbg: reword "class unknown, " to "cl

[Intel-gfx] [PATCH v7d 20/23] dyndbg: refactor *dynamic_emit_prefix

2023-10-31 Thread Jim Cromie
Refactor the split of duties between outer & inner fns. The outer fn was previously just an inline unlikely forward to inner, which did all the work. Now, outer handles +t and +l flags itself, and calls inner only when _DPRINTK_FLAGS_INCL_LOOKUP is needed. No functional change. But it does make

[Intel-gfx] [PATCH v7d 22/23] drm-drivers: DRM_CLASSMAP_USE in 2nd batch of drivers, helpers

2023-10-31 Thread Jim Cromie
Add a DRM_CLASSMAP_USE declaration to 2nd batch of helpers and *_drv.c files. For drivers, add the decl just above the module's PARAMs, since it identifies the "inherited" drm.debug param. Note: with CONFIG_DRM_USE_DYNAMIC_DEBUG=y, a module not also declaring DRM_CLASSMAP_USE will have its class'

[Intel-gfx] [PATCH v7d 18/23] dyndbg: reserve flag bit _DPRINTK_FLAGS_PREFIX_CACHED

2023-10-31 Thread Jim Cromie
Reserve bit 7 to remember that a pr-debug callsite is/was: - enabled, with +p - wants a dynamic-prefix, with one+ of module:function:sourcfile - was previously called - was thus saved in the cache. NOT YET. Its unclear whether any cache fetch would be faster than 2-3 field fetches, but theres anot

[Intel-gfx] [PATCH v7d 23/23] drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN

2023-10-31 Thread Jim Cromie
Lots of burn-in testing needed before signing, upstreaming. NOTE: I set default Y to maximize testing by default. Is there a better way to do this ? Signed-off-by: Jim Cromie --- drivers/gpu/drm/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/Kconfi

[Intel-gfx] [PATCH v7d 21/23] drm: use correct ccflags-y spelling

2023-10-31 Thread Jim Cromie
Incorrectly spelled CFLAGS- failed to add -DDYNAMIC_DEBUG_MODULE, which broke builds with: CONFIG_DRM_USE_DYNAMIC_DEBUG=y CONFIG_DYNAMIC_DEBUG_CORE=y CONFIG_DYNAMIC_DEBUG=n Also add subdir-ccflags so that all drivers pick up the addition. Fixes: 84ec67288c10 ("drm_print: wrap drm_*_dbg in dyndbg

[Intel-gfx] [PATCH v7d 19/23] dyndbg: add _DPRINTK_FLAGS_INCL_LOOKUP

2023-10-31 Thread Jim Cromie
dyndbg's dynamic prefixing (by +tmfsl flags) is needlessly expensive. When an enabled (with +p) pr_debug is called, _DPRINTK_FLAGS_INCL_ANY prefix decorations are sprintf'd into stack-mem for every call. This string (or part of it) could be cached once its 1st generated, and retrieved thereafter,

[Intel-gfx] [PATCH v7d 17/23] dyndbg-doc: add classmap info to howto

2023-10-31 Thread Jim Cromie
Add some basic info on classmap usage and api cc: linux-...@vger.kernel.org Signed-off-by: Jim Cromie --- v5- adjustments per Randy Dunlap, me v7b- checkpatch fixes --- .../admin-guide/dynamic-debug-howto.rst | 60 ++- 1 file changed, 59 insertions(+), 1 deletion(-) diff -

[Intel-gfx] [PATCH v7d 16/23] dyndbg-API: promote DYNDBG_CLASSMAP_PARAM to API

2023-10-31 Thread Jim Cromie
move the DYNDBG_CLASSMAP_PARAM macro from test-dynamic-debug.c into the header, and refine it, by distinguishing the 2 use cases: 1.DYNDBG_CLASSMAP_PARAM_REF for DRM, to pass in extern __drm_debug by name. dyndbg keeps bits in it, so drm can still use it as before 2.DYNDBG_CLASSMAP_PARAM

[Intel-gfx] [PATCH v7d 15/23] dyndbg: refactor ddebug_classparam_clamp_input

2023-10-31 Thread Jim Cromie
Extract input validation code, from param_set_dyndbg_module_classes() (the sys-node >handler) to new: ddebug_classparam_clamp_input(kp), call it from former. It takes kernel-param arg, so it can complain about "foo: bad input". Reuse ddparam_clamp_input(kp) in ddebug_sync_classbits(), to validate

[Intel-gfx] [PATCH v7d 14/23] dyndbg-API: fix CONFIG_DRM_USE_DYNAMIC_DEBUG regression

2023-10-31 Thread Jim Cromie
DECLARE_DYNDBG_CLASSMAP() has a design error; its usage fails a basic K&R rule: "define once, refer many times". When DRM_USE_DYNAMIC_DEBUG=y, DECLARE_DYNDBG_CLASSMAP() is used across DRM core & drivers; they all repeat the same classmap-defn args, which must match for the modules to respond toget

[Intel-gfx] [PATCH v7d 12/23] dyndbg: reduce verbose=3 messages in ddebug_add_module

2023-10-31 Thread Jim Cromie
The fn currently says "add-module", then "skipping" if the module has no prdbgs. Just check 1st and return quietly. no functional change Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynami

[Intel-gfx] [PATCH v7d 13/23] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code

2023-10-31 Thread Jim Cromie
Remove the NAMED class types; these 2 classmap types accept class names at the PARAM interface, for example: echo +DRM_UT_CORE,-DRM_UT_KMS > /sys/module/drm/parameters/debug_names The code works, but its only used by test-dynamic-debug, and wasn't asked for by anyone else, so simplify things fo

[Intel-gfx] [PATCH v7d 10/23] dyndbg: tighten ddebug_class_name() 1st arg type

2023-10-31 Thread Jim Cromie
Change function's 1st arg-type, and deref in the caller. The fn doesn't need any other fields in the struct. no functional change. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_d

[Intel-gfx] [PATCH v7d 11/23] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap

2023-10-31 Thread Jim Cromie
old_bits arg is currently a pointer to the input bits, but this could allow inadvertent changes to the input by the fn. Disallow this. And constify new_bits while here. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-

[Intel-gfx] [PATCH v7d 08/23] dyndbg: reduce verbose/debug clutter

2023-10-31 Thread Jim Cromie
currently, for verbose=3, these are logged (blank lines for clarity): dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op='+' dyndbg: flags=0x1 dyndbg: *flagsp=0x1 *maskp=0x dyndbg: parsed: func="" file="" module="" format="

[Intel-gfx] [PATCH v7d 09/23] dyndbg: silence debugs with no-change updates

2023-10-31 Thread Jim Cromie
check for actual changes before announcing them, declutter logs. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index b0e11f6bfaa2..b07aab422604 100644 --- a/lib/dynamic_

[Intel-gfx] [PATCH v7d 07/23] dyndbg: drop NUM_TYPE_ARRAY

2023-10-31 Thread Jim Cromie
ARRAY_SIZE works here, since array decl is complete. no functional change Signed-off-by: Jim Cromie --- include/linux/dynamic_debug.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index b53217e4b711..8116d0a0

[Intel-gfx] [PATCH v7d 04/23] dyndbg: replace classmap list with a vector

2023-10-31 Thread Jim Cromie
Classmaps are stored/linked in a section/array, but are each added to the module's ddebug_table.maps list-head. This is unnecessary; even when ddebug_attach_classmap() is handling the builtin section (with classmaps for multiple builtin modules), its contents are ordered, so a module's possibly mu

[Intel-gfx] [PATCH v7d 06/23] dyndbg: split param_set_dyndbg_classes to module/wrapper fns

2023-10-31 Thread Jim Cromie
rename param_set_dyndbg_classes: add _module_ name & arg, old name is wrapper to new. New arg allows caller to specify that only one module is affected by a prdbgs update. Outer fn preserves kernel_param interface, passing NULL to inner fn. This selectivity will be used later to narrow the scope

[Intel-gfx] [PATCH v7d 05/23] dyndbg: ddebug_apply_class_bitmap - add module arg, select on it

2023-10-31 Thread Jim Cromie
Add query_module param to ddebug_apply_class_bitmap(). This allows its caller to update just one module, or all (as currently). We'll use this later to propagate drm.debug to each USEr as they're modprobed. No functional change. Signed-off-by: Jim Cromie --- after `modprobe i915`, heres the m

[Intel-gfx] [PATCH v7d 03/23] dyndbg: make ddebug_class_param union members same size

2023-10-31 Thread Jim Cromie
struct ddebug_class_param keeps a ref to the state-storage of the param, make both flavors use the same unsigned long under-type. ISTM this is simpler and safer. Signed-off-by: Jim Cromie --- include/linux/dynamic_debug.h | 2 +- lib/dynamic_debug.c | 2 +- 2 files changed, 2 insertion

[Intel-gfx] [PATCH v7d 01/23] test-dyndbg: fixup CLASSMAP usage error

2023-10-31 Thread Jim Cromie
more careful reading of test output reveals: lib/test_dynamic_debug.c:103 [test_dynamic_debug]do_cats =pmf "doing categories\n" lib/test_dynamic_debug.c:105 [test_dynamic_debug]do_cats =p "LOW msg\n" class:MID lib/test_dynamic_debug.c:106 [test_dynamic_debug]do_cats =p "MID msg\n" class:HI lib/t

[Intel-gfx] [PATCH v7d 02/23] dyndbg: reword "class unknown, " to "class:_UNKNOWN_"

2023-10-31 Thread Jim Cromie
This appears in the control-file to report an unknown class-name, which indicates that the class_id is not authorized, and dyndbg will ignore changes to it. Generally, this means that a DYNDBG_CLASSMAP_DEFINE or DYNDBG_CLASSMAP_USE is missing. But the word "unknown" appears in quite a few prdbg f

[Intel-gfx] [PATCH v7d 00/23] fix DRM_USE_DYNAMIC_DEBUG=y regression

2023-10-31 Thread Jim Cromie
hi Jason, DRM-folk (v7d - refreshed onto v6.6, patch-21 squashed into 14) This patchest fixes the chicken-egg initialization problem in the 1st version of ddebug-class-maps, that DRM-CI uncovered. The root-problem was DECLARE_DYNDBG_CLASSMAP, which broke the K&R rule: "define once, refer many".

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Only fail fastset on PSR2

2023-10-31 Thread Patchwork
== Series Details == Series: drm/i915/display: Only fail fastset on PSR2 URL : https://patchwork.freedesktop.org/series/125829/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13823 -> Patchwork_125829v1 Summary --- **

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Only fail fastset on PSR2

2023-10-31 Thread Patchwork
== Series Details == Series: drm/i915/display: Only fail fastset on PSR2 URL : https://patchwork.freedesktop.org/series/125829/ State : warning == Summary == Error: dim checkpatch failed 7cb5d81d8463 drm/i915/display: Only fail fastset on PSR2 -:54: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Bump GLK CDCLK frequency when driving multiple pipes

2023-10-31 Thread Patchwork
== Series Details == Series: drm/i915: Bump GLK CDCLK frequency when driving multiple pipes URL : https://patchwork.freedesktop.org/series/125818/ State : success == Summary == CI Bug Log - changes from CI_DRM_13823 -> Patchwork_125818v1 Su

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/dsi: 2nd attempt to get rid of IOSF GPIO (rev2)

2023-10-31 Thread Patchwork
== Series Details == Series: drm/i915/dsi: 2nd attempt to get rid of IOSF GPIO (rev2) URL : https://patchwork.freedesktop.org/series/125516/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/125516/revisions/2/mbox/ not applied Applying: drm/i915/dsi

[Intel-gfx] [PATCH] drm/i915/display: Only fail fastset on PSR2

2023-10-31 Thread Paz Zcharya
Currently, i915 fails fastset if both the sink and the source support any version of PSR and regardless of the configuration setting of the driver (i.e., i915.enable_psr kernel argument). However, the implementation of PSR1 enable sequence is already seamless and works smoothly with fastset. Accord

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Remove incomplete PVC plumbing

2023-10-31 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Remove incomplete PVC plumbing URL : https://patchwork.freedesktop.org/series/125809/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13823 -> Patchwork_125809v1 ===

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Remove incomplete PVC plumbing

2023-10-31 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Remove incomplete PVC plumbing URL : https://patchwork.freedesktop.org/series/125809/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: use ref_tracker library in i915 (rev2)

2023-10-31 Thread Patchwork
== Series Details == Series: drm/i915: use ref_tracker library in i915 (rev2) URL : https://patchwork.freedesktop.org/series/125770/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13823 -> Patchwork_125770v2 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: use ref_tracker library in i915 (rev2)

2023-10-31 Thread Patchwork
== Series Details == Series: drm/i915: use ref_tracker library in i915 (rev2) URL : https://patchwork.freedesktop.org/series/125770/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: use ref_tracker library in i915 (rev2)

2023-10-31 Thread Patchwork
== Series Details == Series: drm/i915: use ref_tracker library in i915 (rev2) URL : https://patchwork.freedesktop.org/series/125770/ State : warning == Summary == Error: dim checkpatch failed 4b41f0f040fc drm/i915: Replace custom intel runtime_pm tracker with ref_tracker library -:441: WARNIN

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [RESEND,1/3] drm/i915: make some error capture functions static

2023-10-31 Thread Patchwork
== Series Details == Series: series starting with [RESEND,1/3] drm/i915: make some error capture functions static URL : https://patchwork.freedesktop.org/series/125807/ State : success == Summary == CI Bug Log - changes from CI_DRM_13823 -> Patchwork_125807v1 =

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [RESEND,1/3] drm/i915: make some error capture functions static

2023-10-31 Thread Patchwork
== Series Details == Series: series starting with [RESEND,1/3] drm/i915: make some error capture functions static URL : https://patchwork.freedesktop.org/series/125807/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked s

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [RESEND,1/3] drm/i915: make some error capture functions static

2023-10-31 Thread Patchwork
== Series Details == Series: series starting with [RESEND,1/3] drm/i915: make some error capture functions static URL : https://patchwork.freedesktop.org/series/125807/ State : warning == Summary == Error: dim checkpatch failed 9c2c260c4542 drm/i915: make some error capture functions static e

Re: [Intel-gfx] [PATCH] drm/i915: Skip pxp init if gt is wedged

2023-10-31 Thread Teres Alexis, Alan Previn
On Fri, 2023-10-27 at 10:13 +0300, Jani Nikula wrote: > On Thu, 26 Oct 2023, Zhanjun Dong wrote: > alan:snip > I'll note that nobody checks intel_pxp_init() return status, so this > silently skips PXP. > > BR, > Jani. alan:snip > > + if (intel_gt_is_wedged(gt)) > > + return -ENODEV;

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tc: Fix -Wformat-truncation in intel_tc_port_init (rev5)

2023-10-31 Thread Patchwork
== Series Details == Series: drm/i915/tc: Fix -Wformat-truncation in intel_tc_port_init (rev5) URL : https://patchwork.freedesktop.org/series/125576/ State : success == Summary == CI Bug Log - changes from CI_DRM_13823 -> Patchwork_125576v5

Re: [Intel-gfx] [PATCH v2 6/7] drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back

2023-10-31 Thread Hans de Goede
Hi, On 10/31/23 17:07, Hans de Goede wrote: > Hi Andy, > > On 10/24/23 18:11, Andy Shevchenko wrote: >> On Tue, Oct 24, 2023 at 06:57:38PM +0300, Andy Shevchenko wrote: >>> It's a dirty hack in the driver that pokes GPIO registers behind >>> the driver's back. Moreoever it might be problematic as

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid: split out drm_eld.[ch], add some SAD helpers (rev2)

2023-10-31 Thread Patchwork
== Series Details == Series: drm/edid: split out drm_eld.[ch], add some SAD helpers (rev2) URL : https://patchwork.freedesktop.org/series/123384/ State : success == Summary == CI Bug Log - changes from CI_DRM_13823 -> Patchwork_123384v2 Sum

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/edid: split out drm_eld.[ch], add some SAD helpers (rev2)

2023-10-31 Thread Patchwork
== Series Details == Series: drm/edid: split out drm_eld.[ch], add some SAD helpers (rev2) URL : https://patchwork.freedesktop.org/series/123384/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: split out drm_eld.[ch], add some SAD helpers (rev2)

2023-10-31 Thread Patchwork
== Series Details == Series: drm/edid: split out drm_eld.[ch], add some SAD helpers (rev2) URL : https://patchwork.freedesktop.org/series/123384/ State : warning == Summary == Error: dim checkpatch failed b5defeb2a7ad drm/edid: split out drm_eld.h from drm_edid.h Traceback (most recent call la

Re: [Intel-gfx] [PATCH v4 02/30] drm/dp_mst: Fix fractional DSC bpp handling

2023-10-31 Thread Imre Deak
On Mon, Oct 30, 2023 at 05:58:15PM +0200, Imre Deak wrote: Hi Lyude, AMD folks et al, could you ack patches 2-9 in this patchset if they are ok and it's ok to merge them via the i915 tree? Thanks, Imre > From: Ville Syrjälä > > The current code does '(bpp << 4) / 16' in the MST PBN > calculati

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Use dma_fence interfaces instead of i915_sw_fence (rev5)

2023-10-31 Thread Patchwork
== Series Details == Series: drm/i915/display: Use dma_fence interfaces instead of i915_sw_fence (rev5) URL : https://patchwork.freedesktop.org/series/125160/ State : success == Summary == CI Bug Log - changes from CI_DRM_13823 -> Patchwork_125160v5 ===

Re: [Intel-gfx] [PATCH v2 6/7] drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back

2023-10-31 Thread Andy Shevchenko
On Tue, Oct 31, 2023 at 05:07:39PM +0100, Hans de Goede wrote: > On 10/24/23 18:11, Andy Shevchenko wrote: > > On Tue, Oct 24, 2023 at 06:57:38PM +0300, Andy Shevchenko wrote: > >> It's a dirty hack in the driver that pokes GPIO registers behind > >> the driver's back. Moreoever it might be problem

Re: [Intel-gfx] [PATCH RESEND 2/3] drm/i915: move gpu error debugfs to i915_gpu_error.c

2023-10-31 Thread Nirmoy Das
On 10/31/2023 3:18 PM, Jani Nikula wrote: On Tue, 31 Oct 2023, Nirmoy Das wrote: On 10/31/2023 1:45 PM, Jani Nikula wrote: +void i915_gpu_error_debugfs_register(struct drm_i915_private *i915) +{ + struct drm_minor *minor = i915->drm.primary; + + debugfs_create_file("i915_error_st

[Intel-gfx] [PATCH] drm/i915: Bump GLK CDCLK frequency when driving multiple pipes

2023-10-31 Thread Ville Syrjala
From: Ville Syrjälä On GLK CDCLK frequency needs to be at least 2*96 MHz when accessing the audio hardware. Currently we bump the CDCLK frequency up temporarily (if not high enough already) whenever audio hardware is being accessed, and drop it back down afterwards. With a single active pipe thi

Re: [Intel-gfx] [PATCH v2 6/7] drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back

2023-10-31 Thread Hans de Goede
Hi Andy, On 10/24/23 18:11, Andy Shevchenko wrote: > On Tue, Oct 24, 2023 at 06:57:38PM +0300, Andy Shevchenko wrote: >> It's a dirty hack in the driver that pokes GPIO registers behind >> the driver's back. Moreoever it might be problematic as simultaneous >> I/O may hang the system, see the comm

Re: [Intel-gfx] [PATCH 1/4] drm: Fix color LUT rounding

2023-10-31 Thread Ville Syrjälä
On Tue, Oct 31, 2023 at 11:15:35AM +0200, Jani Nikula wrote: > On Fri, 13 Oct 2023, Ville Syrjala wrote: > > entrirely. But perhaps a better idea would be to follow the > > OpenGL int<->float conversion rules, in which case we get > > the following results: > > Do you have a pointer to the rules

Re: [Intel-gfx] [PATCH 0/2] drm/i915: use ref_tracker library in i915

2023-10-31 Thread Andi Shyti
> This patchset replaces custom tracking solution > with ref_tracker library. This is follow-up of the > work from patchset[1]. Core part is already merged > and present in drm-tip. This is actually re-base of [1] > with minor fixes for code introduced later. > > [1]: https://lore.kernel.org/r/202

Re: [Intel-gfx] [PATCH RESEND 2/3] drm/i915: move gpu error debugfs to i915_gpu_error.c

2023-10-31 Thread Jani Nikula
On Tue, 31 Oct 2023, Nirmoy Das wrote: > On 10/31/2023 1:45 PM, Jani Nikula wrote: >> +void i915_gpu_error_debugfs_register(struct drm_i915_private *i915) >> +{ >> +struct drm_minor *minor = i915->drm.primary; >> + >> +debugfs_create_file("i915_error_state", 0644, > > nit: s/0644/S_IRUGO |

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Improve BW management on MST links (rev8)

2023-10-31 Thread Imre Deak
On Mon, Oct 30, 2023 at 11:57:27PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Improve BW management on MST links (rev8) > URL : https://patchwork.freedesktop.org/series/125490/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_13814 -> Patchwork

Re: [Intel-gfx] [PATCH RESEND 3/3] drm/i915: move gpu error sysfs to i915_gpu_error.c

2023-10-31 Thread Nirmoy Das
On 10/31/2023 1:45 PM, Jani Nikula wrote: Hide gpu error specifics in i915_gpu_error.c. This is also cleaner wrt conditional compilation, as i915_gpu_error.c is only built with DRM_I915_CAPTURE_ERROR=y. With this, we can also make i915_first_error_state() static. Signed-off-by: Jani Nikula

Re: [Intel-gfx] [PATCH RESEND 2/3] drm/i915: move gpu error debugfs to i915_gpu_error.c

2023-10-31 Thread Nirmoy Das
On 10/31/2023 1:45 PM, Jani Nikula wrote: Hide gpu error specifics in i915_gpu_error.c. This is also cleaner wrt conditional compilation, as i915_gpu_error.c is only built with DRM_I915_CAPTURE_ERROR=y. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_debugfs.c | 108 +

[Intel-gfx] [PATCH 2/2] drm/i915: Remove xehpsdv support

2023-10-31 Thread Tvrtko Ursulin
From: Tvrtko Ursulin XeHP SDV was a pre-production hardware used to bring up PVC and was not generally available and has since been decided will be supported in the new xe driver and not i915. v2: * Correct historical fact SDV was for PVC, not ATS. (John) Signed-off-by: Tvrtko Ursulin Cc: Joh

[Intel-gfx] [PATCH 1/2] drm/i915: Remove incomplete PVC plumbing

2023-10-31 Thread Tvrtko Ursulin
From: Tvrtko Ursulin PVC support will not be coming to i915 so get rid of its partial enablement and reduce the driver maintenance burden. Signed-off-by: Tvrtko Ursulin Reviewed-by: Andi Shyti Reviewed-by: Andrzej Hajda --- .../gpu/drm/i915/gem/i915_gem_object_types.h | 2 +- drivers/gpu/

Re: [Intel-gfx] [PATCH RESEND 1/3] drm/i915: make some error capture functions static

2023-10-31 Thread Nirmoy Das
On 10/31/2023 1:45 PM, Jani Nikula wrote: Not needed outside of i915_gpu_error.c. Signed-off-by: Jani Nikula Reviewed-by: Nirmoy Das --- drivers/gpu/drm/i915/i915_gpu_error.c | 8 drivers/gpu/drm/i915/i915_gpu_error.h | 5 - 2 files changed, 4 insertions(+), 9 deletions(-)

[Intel-gfx] [PATCH RESEND 2/3] drm/i915: move gpu error debugfs to i915_gpu_error.c

2023-10-31 Thread Jani Nikula
Hide gpu error specifics in i915_gpu_error.c. This is also cleaner wrt conditional compilation, as i915_gpu_error.c is only built with DRM_I915_CAPTURE_ERROR=y. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_debugfs.c | 108 + drivers/gpu/drm/i915/i915_gpu_err

[Intel-gfx] [PATCH RESEND 3/3] drm/i915: move gpu error sysfs to i915_gpu_error.c

2023-10-31 Thread Jani Nikula
Hide gpu error specifics in i915_gpu_error.c. This is also cleaner wrt conditional compilation, as i915_gpu_error.c is only built with DRM_I915_CAPTURE_ERROR=y. With this, we can also make i915_first_error_state() static. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_gpu_error.c | 75

[Intel-gfx] [PATCH RESEND 1/3] drm/i915: make some error capture functions static

2023-10-31 Thread Jani Nikula
Not needed outside of i915_gpu_error.c. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_gpu_error.c | 8 drivers/gpu/drm/i915/i915_gpu_error.h | 5 - 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v6 0/4] Apply Wa_16018031267 / Wa_16018063123

2023-10-31 Thread Andrzej Hajda
On 26.10.2023 20:36, Andrzej Hajda wrote: Hi all, This the series from Jonathan: [PATCH v12 0/4] Apply Wa_16018031267 / Wa_16018063123 taken over by me. This patchset requires IGT changes fixing handling gtt sizes not being power of 2: https://patchwork.freedesktop.org/series/125640/ Changes i

Re: [Intel-gfx] [PATCH 0/3] drm/i915/hdcp: Additional conditions to enable hdcp

2023-10-31 Thread Nautiyal, Ankit K
On 10/26/2023 5:41 PM, Suraj Kandpal wrote: We are seeing a issue when we close the lid of a laptop or dock a monitor hdcp content is not being reenabled automatically this is because when we dock a monitor we end up with a enable and disable connector cycle but if hdcp content is running we ge

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Apply notify_guc to all GTs

2023-10-31 Thread Nirmoy Das
On 10/31/2023 11:57 AM, Nirmoy Das wrote: merged to drm-next Sorry, drm-intel-next not drm-next. Regards, Nirmoy Thanks, Nirmoy On 10/25/2023 3:12 PM, Andrzej Hajda wrote: On 25.10.2023 12:28, Nirmoy Das wrote: Handle platforms with multiple GTs by iterate over all GTs. Add a Fix

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Apply notify_guc to all GTs

2023-10-31 Thread Nirmoy Das
merged to drm-next Thanks, Nirmoy On 10/25/2023 3:12 PM, Andrzej Hajda wrote: On 25.10.2023 12:28, Nirmoy Das wrote: Handle platforms with multiple GTs by iterate over all GTs. Add a Fixes commit so this gets propagated for MTL support. Fixes: 213c43676beb ("drm/i915/mtl: Remove the 'forc

Re: [Intel-gfx] [PATCH v3] drm/i915: Flush WC GGTT only on required platforms

2023-10-31 Thread Nirmoy Das
This is now merged to gt-next Thanks, Nirmoy On 10/18/2023 4:04 PM, Nirmoy Das wrote: On 10/18/2023 3:00 PM, Andi Shyti wrote: Hi Nirmoy, gen8_ggtt_invalidate() is only needed for limited set of platforms where GGTT is mapped as WC. This was added as way to fix WC based GGTT in commit 0

Re: [Intel-gfx] [PATCH v2 6/6] drm/eld: add helpers to modify the SADs of an ELD

2023-10-31 Thread Golani, Mitulkumar Ajitkumar
> -Original Message- > From: Nikula, Jani > Sent: Tuesday, October 31, 2023 3:47 PM > To: dri-de...@lists.freedesktop.org > Cc: intel-gfx@lists.freedesktop.org; Golani, Mitulkumar Ajitkumar > ; Nikula, Jani > > Subject: [PATCH v2 6/6] drm/eld: add helpers to modify the SADs of an ELD >

Re: [Intel-gfx] [v2 1/2] drm/i915/display: Add support for darskscreen detection

2023-10-31 Thread Garg, Nemesa
This is will also be caught as dark screen. Regards, Nemesa > -Original Message- > From: Jani Nikula > Sent: Monday, October 30, 2023 3:50 PM > To: Garg, Nemesa ; intel-gfx@lists.freedesktop.org > Subject: RE: [Intel-gfx] [v2 1/2] drm/i915/display: Add support for > darskscreen > detect

[Intel-gfx] [PATCH v2 4/6] drm/edid: use a temp variable for sads to drop one level of dereferences

2023-10-31 Thread Jani Nikula
Use a temporary variable struct cea_sad *, instead of using struct cea_sad ** directly with the double dereferences. It's arguably easier on the eyes, and drops a set of parenthesis too. Cc: Mitul Golani Reviewed-by: Mitul Golani Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 16 +

[Intel-gfx] [PATCH v2 6/6] drm/eld: add helpers to modify the SADs of an ELD

2023-10-31 Thread Jani Nikula
Occasionally it's necessary for drivers to modify the SADs of an ELD, but it's not so cool to have drivers poke at the ELD buffer directly. Using the helpers to translate between 3-byte SAD and struct cea_sad, add ELD helpers to get/set the SADs from/to an ELD. v2: s/i/sad_index/ (Mitul) Cc: Mit

[Intel-gfx] [PATCH v2 2/6] drm/eld: replace uint8_t with u8

2023-10-31 Thread Jani Nikula
Unify on kernel types. Cc: Mitul Golani Reviewed-by: Chaitanya Kumar Borah Reviewed-by: Mitul Golani Signed-off-by: Jani Nikula --- include/drm/drm_eld.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/drm/drm_eld.h b/include/drm/drm_eld.h index 9bde

[Intel-gfx] [PATCH v2 5/6] drm/edid: add helpers to get/set struct cea_sad from/to 3-byte sad

2023-10-31 Thread Jani Nikula
Add helpers to pack/unpack SADs. Both ways and non-static, as follow-up work needs them. v2: Add include to get the declarations Cc: Mitul Golani Reviewed-by: Mitul Golani Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 34 +- drivers/gpu/drm/dr

[Intel-gfx] [PATCH v2 3/6] drm/edid: include drm_eld.h only where required

2023-10-31 Thread Jani Nikula
Reduce the dependencies on drm_eld.h. Some files might be able to drop the dependency on drm_edid.h too with the direct inclusion of drm_eld.h. Cc: Mitul Golani Reviewed-by: Mitul Golani Signed-off-by: Jani Nikula --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c| 1 + drivers/gpu/drm/

[Intel-gfx] [PATCH v2 1/6] drm/edid: split out drm_eld.h from drm_edid.h

2023-10-31 Thread Jani Nikula
The drm_edid.[ch] files are starting to be a bit crowded, and with plans to add more ELD related functionality, it's perhaps cleanest to split the ELD code out to a header of its own. Include drm_eld.h from drm_edid.h for starters, and leave it to follow-up work to only include drm_eld.h where nee

[Intel-gfx] [PATCH v2 0/6] drm/edid: split out drm_eld.[ch], add some SAD helpers

2023-10-31 Thread Jani Nikula
v2 of https://patchwork.freedesktop.org/series/123384/ Jani Nikula (6): drm/edid: split out drm_eld.h from drm_edid.h drm/eld: replace uint8_t with u8 drm/edid: include drm_eld.h only where required drm/edid: use a temp variable for sads to drop one level of dereferences drm/edid: ad

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Use dma_fence interfaces instead of i915_sw_fence (rev4)

2023-10-31 Thread Patchwork
== Series Details == Series: drm/i915/display: Use dma_fence interfaces instead of i915_sw_fence (rev4) URL : https://patchwork.freedesktop.org/series/125160/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13817 -> Patchwork_125160v4 ===

Re: [Intel-gfx] [PATCH v4] drm/i915/dsb: DSB code refactoring

2023-10-31 Thread Luca Coelho
On Tue, 2023-10-31 at 09:15 +, Manna, Animesh wrote: > > > -Original Message- > > From: Luca Coelho > > Sent: Tuesday, October 31, 2023 1:14 PM > > To: Manna, Animesh ; intel- > > g...@lists.freedesktop.org > > Cc: Nikula, Jani > > Subject: Re: [Intel-gfx] [PATCH v4] drm/i915/dsb: DS

Re: [Intel-gfx] [PATCH v4 01/30] drm/i915/dp_mst: Fix race between connector registration and setup

2023-10-31 Thread Lisovskiy, Stanislav
On Mon, Oct 30, 2023 at 05:58:14PM +0200, Imre Deak wrote: > After drm_connector_init() is called the connector is visible to the > rest of the kernel via the drm_mode_config::connector_list. Make > sure that the DSC AUX device and capabilities are setup by that time. > > Another race condition is

Re: [Intel-gfx] [PATCH 1/4] drm: Fix color LUT rounding

2023-10-31 Thread Jani Nikula
On Fri, 13 Oct 2023, Ville Syrjala wrote: > entrirely. But perhaps a better idea would be to follow the > OpenGL int<->float conversion rules, in which case we get > the following results: Do you have a pointer to the rules handy, I couldn't find it. :( Might also add the reference to the commit

Re: [Intel-gfx] [PATCH v4] drm/i915/dsb: DSB code refactoring

2023-10-31 Thread Manna, Animesh
> -Original Message- > From: Luca Coelho > Sent: Tuesday, October 31, 2023 1:14 PM > To: Manna, Animesh ; intel- > g...@lists.freedesktop.org > Cc: Nikula, Jani > Subject: Re: [Intel-gfx] [PATCH v4] drm/i915/dsb: DSB code refactoring > > On Fri, 2023-10-27 at 17:27 +0530, Animesh Manna

Re: [Intel-gfx] [PATCH 2/3] drm/i915/pmu: add event_to_pmu() helper

2023-10-31 Thread Jani Nikula
On Thu, 26 Oct 2023, Andi Shyti wrote: > On Thu, Oct 26, 2023 at 11:51:02AM +0100, Tvrtko Ursulin wrote: >> Now seriously, I don't mind perf_event, as long as _whole_ i915_pmu.c is >> switched over. At which point I questioned would the churn be worth it. > > I like Jani's patch, of course your gr

Re: [Intel-gfx] [PATCH 2/2] drm/i915/vdsc: Remove old comment about DSC 444 support

2023-10-31 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Ankit > Nautiyal > Sent: Monday, October 16, 2023 10:51 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 2/2] drm/i915/vdsc: Remove old comment about > DSC 444 support > > DSC with YCbCr420 is now supported, so r

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsc: Use helper to calculate range_bpg_offset

2023-10-31 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Ankit > Nautiyal > Sent: Monday, October 16, 2023 10:51 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 1/2] drm/i915/dsc: Use helper to calculate > range_bpg_offset > > We get range_bpg_offset for different bpp

Re: [Intel-gfx] [PATCH v4 25/30] drm/i915/dp_mst: Enable MST DSC decompression for all streams

2023-10-31 Thread Lisovskiy, Stanislav
On Mon, Oct 30, 2023 at 05:58:38PM +0200, Imre Deak wrote: > Enable DSC decompression for all streams. In particular atm if a sink is > connected to a last branch device that is downstream of the first branch > device connected to the source, decompression is not enabled for it. > Similarly it's no

[Intel-gfx] [PATCH v4] drm/i915/display: Use dma_fence interfaces instead of i915_sw_fence

2023-10-31 Thread Jouni Högander
We are preparing for Xe driver. Xe driver doesn't have i915_sw_fence implementation. Lets drop i915_sw_fence usage from display code and use dma_fence interfaces directly. For this purpose stack dma fences from related objects into new plane state. Drm_gem_plane_helper_prepare_fb can be used for f

Re: [Intel-gfx] â Fi.CI.IGT: failure for debugobjects: stop accessing objects after releasing spinlock (rev3)

2023-10-31 Thread Andrzej Hajda
On 27.10.2023 09:26, Patchwork wrote: *Patch Details* *Series:* debugobjects: stop accessing objects after releasing spinlock (rev3) *URL:* https://patchwork.freedesktop.org/series/124185/ *State:*failure *Details:* https://intel-gfx-

Re: [Intel-gfx] [PATCH v4] drm/i915/dsb: DSB code refactoring

2023-10-31 Thread Luca Coelho
On Fri, 2023-10-27 at 17:27 +0530, Animesh Manna wrote: > Refactor DSB implementation to be compatible with Xe driver. > > v1: RFC version. > v2: Make intel_dsb structure opaque from external usage. [Jani] > v3: Rebased on latest. > v4: > - Add boundary check in dsb_buffer_memset(). [Luca] > - Use

Re: [Intel-gfx] [PATCH v3] drm/i915/display: Use dma_fence interfaces instead of i915_sw_fence

2023-10-31 Thread Ville Syrjälä
On Tue, Oct 31, 2023 at 08:53:38AM +0200, Ville Syrjälä wrote: > On Mon, Oct 30, 2023 at 02:09:15PM +0200, Jouni Högander wrote: > > We are preparing for Xe driver. Xe driver doesn't have i915_sw_fence > > implementation. Lets drop i915_sw_fence usage from display code and > > use dma_fence interfa