== Series Details ==
Series: drm/i915: Add new DG2 PCI IDs
URL : https://patchwork.freedesktop.org/series/124937/
State : failure
== Summary ==
Error: make failed
CALLscripts/checksyscalls.sh
DESCEND objtool
INSTALL libsubcmd_headers
CC arch/x86/kernel/early-quirks.o
In file i
== Series Details ==
Series: drm/i915/lnl: Remove watchdog timers for PSR (rev3)
URL : https://patchwork.freedesktop.org/series/124715/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13735_full -> Patchwork_124715v3_full
Sum
On 2023.10.04 15:54:11 +0300, Jani Nikula wrote:
> On Tue, 26 Sep 2023, Jani Nikula wrote:
> > gvt.h has no need to include i915_drv.h once the unused to_gvt() has
> > been removed.
> >
> > Signed-off-by: Jani Nikula
>
> Zhenyu, Zhi, ping?
>
Sorry for late reply, as last week was full holiday
Add new PCI IDs which are recently added.
BSpec: 44477
Signed-off-by: Shekhar Chauhan
---
include/drm/i915_pciids.h | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index 1256770d3827..deb2eb0b4979 100644
--- a/incl
== Series Details ==
Series: drm/i915: Define and use GuC and CTB TLB invalidation routines
URL : https://patchwork.freedesktop.org/series/124932/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13737 -> Patchwork_124932v1
Su
== Series Details ==
Series: drm/i915: Define and use GuC and CTB TLB invalidation routines
URL : https://patchwork.freedesktop.org/series/124932/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: Define and use GuC and CTB TLB invalidation routines
URL : https://patchwork.freedesktop.org/series/124932/
State : warning
== Summary ==
Error: dim checkpatch failed
3f043e9037de drm/i915: Add GuC TLB Invalidation device info flags
dcdab6a3e4e0 drm/i915/
tp
crc32_pclmul ghash_clmulni_intel i2c_i801 mei_me pps_core mei i2c_smbus wmi
<4>[4.392057] CPU: 1 PID: 306 Comm: thermald Not tainted
6.6.0-rc5-next-20231010-next-20231010-gc0a6edb636cb+ #1
<4>[4.392061] Hardware name: System manufacturer System Product
Name/Z170M-PLUS, BIOS
== Series Details ==
Series: Use intel_crtc_destroy state
URL : https://patchwork.freedesktop.org/series/124919/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13737 -> Patchwork_124919v1
Summary
---
**SUCCESS**
No
== Series Details ==
Series: drm/i915: Implement range-based TLB
URL : https://patchwork.freedesktop.org/series/124922/
State : failure
== Summary ==
Error: make failed
CALLscripts/checksyscalls.sh
DESCEND objtool
INSTALL libsubcmd_headers
CC [M] drivers/gpu/drm/i915/i915_vma.o
dr
== Series Details ==
Series: Use intel_crtc_destroy state
URL : https://patchwork.freedesktop.org/series/124919/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+./arch/x86/include/asm/bitops.h:117:1: warnin
== Series Details ==
Series: series starting with [v2,1/1] drm/i915/pxp: Add drm_dbgs for critical
PXP events. (rev2)
URL : https://patchwork.freedesktop.org/series/123656/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13737 -> Patchwork_123656v2
=
== Series Details ==
Series: series starting with [v2,1/1] drm/i915/pxp: Add drm_dbgs for critical
PXP events. (rev2)
URL : https://patchwork.freedesktop.org/series/123656/
State : warning
== Summary ==
Error: dim checkpatch failed
afd41e939c6c drm/i915/pxp: Add drm_dbgs for critical PXP even
Hi Jonathan,
kernel test robot noticed the following build errors:
[auto build test ERROR on drm-tip/drm-tip]
url:
https://github.com/intel-lab-lkp/linux/commits/Jonathan-Cavitt/drm-i915-Use-selective-tlb-invalidations-where-supported/20231011-034501
base: git://anongit.freedesktop.org/drm
== Series Details ==
Series: drm/i915: Define and use GuC and CTB TLB invalidation routines
URL : https://patchwork.freedesktop.org/series/124917/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13737 -> Patchwork_124917v1
Su
== Series Details ==
Series: drm/i915: Define and use GuC and CTB TLB invalidation routines
URL : https://patchwork.freedesktop.org/series/124917/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Add a helper function to the GuC CT buffer that reports the expected
time to process all outstanding requests. As of now, there is no
functionality to check number of requests in the buffer, so the helper
function just reports 2 seconds, or 1ms per request up to the maximum
number of requests the
It is not an error for GuC TLB invalidations to fail when the GT is
wedged or disabled, so do not process a wait failure as one in
guc_send_invalidate_tlb.
Signed-off-by: Fei Yang
Signed-off-by: Jonathan Cavitt
CC: John Harrison
Reviewed-by: Andi Shyti
---
.../gpu/drm/i915/gt/uc/intel_guc_sub
Add device info flags for if GuC TLB Invalidation is enabled.
Signed-off-by: Jonathan Cavitt
Reviewed-by: Andi Shyti
---
drivers/gpu/drm/i915/i915_drv.h | 2 ++
drivers/gpu/drm/i915/intel_device_info.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.
Enable GuC TLB invalidations for MTL. Though more platforms than just
MTL support GuC TLB invalidations, MTL is presently the only platform
that requires it for any purpose, so only enable it there for now to
minimize cross-platform impact.
Signed-off-by: Jonathan Cavitt
Reviewed-by: Andi Shyti
For the gt_tlb live selftest, when operating on the GSC engine,
increase the timeout from 10 ms to 200 ms because the GSC
engine is a bit slower than the rest.
Signed-off-by: Jonathan Cavitt
Reviewed-by: Andi Shyti
---
drivers/gpu/drm/i915/gt/selftest_tlb.c | 11 +--
1 file changed, 9 i
Implement GuC-based TLB invalidations and use them on MTL.
Some complexity in the implementation was introduced early on
and will be required for range-based TLB invalidations.
RFC: https://patchwork.freedesktop.org/series/124922/
v2:
- Add missing supporting patches.
v3:
- Split suspend/resume
From: Prathap Kumar Valsan
The GuC firmware had defined the interface for Translation Look-Aside
Buffer (TLB) invalidation. We should use this interface when
invalidating the engine and GuC TLBs.
Add additional functionality to intel_gt_invalidate_tlb, invalidating
the GuC TLBs and falling back
In case of GT is suspended, don't allow submission of new TLB invalidation
request and cancel all pending requests. The TLB entries will be
invalidated either during GuC reload or on system resume.
Signed-off-by: Fei Yang
Signed-off-by: Jonathan Cavitt
CC: John Harrison
Reviewed-by: Andi Shyti
Hi Jonathan,
kernel test robot noticed the following build errors:
[auto build test ERROR on drm-tip/drm-tip]
url:
https://github.com/intel-lab-lkp/linux/commits/Jonathan-Cavitt/drm-i915-Use-selective-tlb-invalidations-where-supported/20231011-034501
base: git://anongit.freedesktop.org/drm
== Series Details ==
Series: drm/i915/gt: Temporarily force MTL into uncached mode (rev2)
URL : https://patchwork.freedesktop.org/series/124866/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13736 -> Patchwork_124866v2
Summ
== Series Details ==
Series: drm/i915/gt: Temporarily force MTL into uncached mode (rev2)
URL : https://patchwork.freedesktop.org/series/124866/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
On 10/10/2023 15:30, Cavitt, Jonathan wrote:
-Original Message-
From: Harrison, John C
Sent: Tuesday, October 10, 2023 2:51 PM
To: Cavitt, Jonathan ;
intel-gfx@lists.freedesktop.org
Cc: Gupta, saurabhg ; chris.p.wil...@linux.intel.com; Iddamsetty, Aravind
; Yang, Fei ; Shyti, Andi ;
D
== Series Details ==
Series: Add drm_dbg_ratelimited()
URL : https://patchwork.freedesktop.org/series/124894/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13736 -> Patchwork_124894v1
Summary
---
**SUCCESS**
No re
== Series Details ==
Series: Add drm_dbg_ratelimited()
URL : https://patchwork.freedesktop.org/series/124894/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Add drm_dbg_ratelimited()
URL : https://patchwork.freedesktop.org/series/124894/
State : warning
== Summary ==
Error: dim checkpatch failed
b31dca360377 drm/print: Add drm_dbg_ratelimited
f2b0f288ffbb drm/i915: Ratelimit debug log in vm_fault_ttm
-:9: WARNING:COMMI
== Series Details ==
Series: Framework for display parameters (rev2)
URL : https://patchwork.freedesktop.org/series/124645/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13736 -> Patchwork_124645v2
Summary
---
**SUCC
-Original Message-
From: Harrison, John C
Sent: Tuesday, October 10, 2023 2:51 PM
To: Cavitt, Jonathan ;
intel-gfx@lists.freedesktop.org
Cc: Gupta, saurabhg ; chris.p.wil...@linux.intel.com;
Iddamsetty, Aravind ; Yang, Fei
; Shyti, Andi ; Das, Nirmoy
; Krzysztofik, Janusz ;
Roper, Ma
On Mon, Oct 02, 2023 at 10:55:17AM +0200, Joel Granados via B4 Relay wrote:
> Changes in v2:
> - Left the dangling comma in the ctl_table arrays.
> - Link to v1:
> https://lore.kernel.org/r/20230928-jag-sysctl_remove_empty_elem_drivers-v1-0-e59120fca...@samsung.com
Thanks! Pushed onto sysctl-next
== Series Details ==
Series: Framework for display parameters (rev2)
URL : https://patchwork.freedesktop.org/series/124645/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Framework for display parameters (rev2)
URL : https://patchwork.freedesktop.org/series/124645/
State : warning
== Summary ==
Error: dim checkpatch failed
6962346c45e5 drm/i915/display: Add framework to add parameters specific to
display
Traceback (most recent call
On 10/10/2023 08:02, Jonathan Cavitt wrote:
For the gt_tlb live selftest, when operating on the GSC engine,
increase the timeout from 10 ms to 200 ms because the GSC
engine is a bit slower than the rest.
Additionally, increase the default timeout from 10 ms to 20 ms
because msleep < 20ms can sle
== Series Details ==
Series: drm/i915: Store DSC DPCD capabilities in the connector (rev5)
URL : https://patchwork.freedesktop.org/series/124723/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13736 -> Patchwork_124723v5
Sum
-Original Message-
From: Harrison, John C
Sent: Tuesday, October 10, 2023 2:57 PM
To: Cavitt, Jonathan ;
intel-gfx@lists.freedesktop.org
Cc: Gupta, saurabhg ; chris.p.wil...@linux.intel.com;
Iddamsetty, Aravind ; Yang, Fei
; Shyti, Andi ; Das, Nirmoy
; Krzysztofik, Janusz ;
Roper, Ma
On 10/10/2023 08:02, Jonathan Cavitt wrote:
In case of GT is suspended, don't allow submission of new TLB invalidation
request and cancel all pending requests. The TLB entries will be
invalidated either during GuC reload or on system resume.
Signed-off-by: Fei Yang
Signed-off-by: Jonathan Cavit
On 10/10/2023 08:02, Jonathan Cavitt wrote:
From: Prathap Kumar Valsan
The GuC firmware had defined the interface for Translation Look-Aside
Buffer (TLB) invalidation. We should use this interface when
invalidating the engine and GuC TLBs.
Add additional functionality to intel_gt_invalidate_tl
== Series Details ==
Series: drm/i915: Store DSC DPCD capabilities in the connector (rev5)
URL : https://patchwork.freedesktop.org/series/124723/
State : warning
== Summary ==
Error: dim checkpatch failed
a9998de0514d drm/i915/dp: Sanitize DPCD revision check in
intel_dp_get_dsc_sink_cap()
08
== Series Details ==
Series: series starting with [1/2] drm/print: Add drm_dbg_ratelimited (rev2)
URL : https://patchwork.freedesktop.org/series/112925/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13736 -> Patchwork_112925v2
==
== Series Details ==
Series: series starting with [1/2] drm/print: Add drm_dbg_ratelimited (rev2)
URL : https://patchwork.freedesktop.org/series/112925/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: series starting with [1/2] drm/print: Add drm_dbg_ratelimited (rev2)
URL : https://patchwork.freedesktop.org/series/112925/
State : warning
== Summary ==
Error: dim checkpatch failed
ada8428ec944 drm/print: Add drm_dbg_ratelimited
fbced019c190 drm/i915: Ratelimit d
On 10/10/23 08:15, Andi Shyti wrote:
From: Nirmoy Das
Add a function for ratelimitted debug print.
Signed-off-by: Nirmoy Das
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Thomas Zimmermann
Cc: David Airlie
Cc: Daniel Vetter
Reviewed-by: Matthew Auld
Reviewed-by: Andrzej Hajda
Reviewed-by
Hi John,
On Tue, Oct 10, 2023 at 11:25:03AM -0700, John Harrison wrote:
> On 10/10/2023 05:15, Andi Shyti wrote:
> > Hi,
> >
> > I might have picked up the wrong series and missed some reviews
> > and the extra patch from Nirmoy with a real use of the
> > drm_dbg_ratelimited() that John was looki
Hi John,
On Mon, Oct 09, 2023 at 12:57:55PM -0700, John Harrison wrote:
> On 10/9/2023 12:54, Andi Shyti wrote:
> > Hi John,
> >
> > ...
> >
> > > --- a/drivers/gpu/drm/i915/i915_driver.c
> > > +++ b/drivers/gpu/drm/i915/i915_driver.c
> > > @@ -71,6 +71,7 @@
> > > #include "gem/i915_gem_pm.h"
On 10/10/2023 08:02, Jonathan Cavitt wrote:
Add a helper function to the GuC CT buffer that reports the expected
time to process all outstanding requests. As of now, there is no
functionality to check number of requests in the buffer, so the helper
function just reports 2 seconds, or 1ms per req
Ignore this. It's not a security hole: it's just a temporary patch I was
using for rebasing purposes that got smuggled into this series
on accident. It has a bad tag because of some stale gitconfig params
that I've since removed.
-Jonathan Cavitt
-Original Message-
From: Cavitt, Jonatha
== Series Details ==
Series: drm/i915/lnl: Remove watchdog timers for PSR (rev3)
URL : https://patchwork.freedesktop.org/series/124715/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13735 -> Patchwork_124715v3
Summary
-
Implement range-based TLB invalidations on top of GuC-based TLB
invalidations. This is the future plan for GuC-based TLB
invalidations because it helps improve performance over performing
full tlb invalidations all the time.
Jonathan Cavitt (7):
drm/i915: Add GuC TLB Invalidation device info fl
From: Prathap Kumar Valsan
The GuC firmware had defined the interface for Translation Look-Aside
Buffer (TLB) invalidation. We should use this interface when
invalidating the engine and GuC TLBs.
Add additional functionality to intel_gt_invalidate_tlb, invalidating
the GuC TLBs and falling back
From: Prathap Kumar Valsan
This supports selective and full tlb invalidations. When GuC is enabled
the tlb invalidations use guc ct otherwise use mmio interface.
Signed-off-by: Prathap Kumar Valsan
CC: Niranjana Vishwanathapura
CC: Fei Yang
Signed-off-by: Jonathan Cavitt
---
drivers/gpu/drm
For platforms supporting selective tlb invalidations, we don't need to
do a full tlb invalidation. Rather do a range based tlb invalidation for
every unbind of purged vma belongs to an active vm.
Signed-off-by: Prathap Kumar Valsan
Cc: Niranjana Vishwanathapura
Cc: Fei Yang
Signed-off-by: Mauro
For the gt_tlb live selftest, when operating on the GSC engine,
increase the timeout from 10 ms to 200 ms because the GSC
engine is a bit slower than the rest.
Additionally, increase the default timeout from 10 ms to 20 ms
because msleep < 20ms can sleep for up to 20ms.
Signed-off-by: Jonathan Ca
From: Prathap Kumar Valsan
The GuC firmware has defined the interface for selective TLB
invalidation support. This patch adds routines to interface with GuC.
Signed-off-by: Prathap Kumar Valsan
CC: Matthew Brost
---
.../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 2 +
drivers/gpu/drm/i915/g
Enable GuC TLB invalidations for MTL. Though more platforms than just
MTL support GuC TLB invalidations, MTL is presently the only platform
that requires it for any purpose, so only enable it there for now to
minimize cross-platform impact.
Signed-off-by: Jonathan Cavitt
---
drivers/gpu/drm/i91
It is not an error for GuC TLB invalidations to fail when the GT is
wedged or disabled, so do not process a wait failure as one in
guc_send_invalidate_tlb.
Signed-off-by: Fei Yang
Signed-off-by: Jonathan Cavitt
CC: John Harrison
---
.../gpu/drm/i915/gt/uc/intel_guc_submission.c | 18 +
Add a helper function to the GuC CT buffer that reports the expected
time to process all outstanding requests. As of now, there is no
functionality to check number of requests in the buffer, so the helper
function just reports 2 seconds, or 1ms per request up to the maximum
number of requests the
In case of GT is suspended, don't allow submission of new TLB invalidation
request and cancel all pending requests. The TLB entries will be
invalidated either during GuC reload or on system resume.
Signed-off-by: Fei Yang
Signed-off-by: Jonathan Cavitt
CC: John Harrison
---
drivers/gpu/drm/i91
Add device info flags for if GuC TLB Invalidation is enabled.
Signed-off-by: Jonathan Cavitt
---
drivers/gpu/drm/i915/i915_drv.h | 2 ++
drivers/gpu/drm/i915/intel_device_info.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/
On 10/10/2023 09:44, Matt Roper wrote:
On Tue, Oct 10, 2023 at 05:42:28PM +0100, Tvrtko Ursulin wrote:
On 10/10/2023 17:17, Andi Shyti wrote:
Hi Matt,
FIXME: CAT errors are cropping up on MTL. This removes them,
but the real root cause must still be diagnosed.
Do you have a link to specific
From: Prathap Kumar Valsan
This supports selective and full tlb invalidations. When GuC is enabled
the tlb invalidations use guc ct otherwise use mmio interface.
Signed-off-by: Prathap Kumar Valsan
CC: Niranjana Vishwanathapura
CC: Fei Yang
Signed-off-by: Jonathan Cavitt
---
drivers/gpu/drm
On Tue, Oct 10, 2023 at 11:02:09AM +0530, Suraj Kandpal wrote:
> Free hw_crtc_state in verify_crtc_state after we are done using
> this or else it's just a resource leak.
>
> Fixes: 2745bdda2095 ("drm/i915: Stop clobbering old crtc state during state
> check")
> Signed-off-by: Suraj Kandpal
> Re
In case of GT is suspended, don't allow submission of new TLB invalidation
request and cancel all pending requests. The TLB entries will be
invalidated either during GuC reload or on system resume.
Signed-off-by: Fei Yang
Signed-off-by: Jonathan Cavitt
CC: John Harrison
---
drivers/gpu/drm/i91
For platforms supporting selective tlb invalidations, we don't need to
do a full tlb invalidation. Rather do a range based tlb invalidation for
every unbind of purged vma belongs to an active vm.
Signed-off-by: Prathap Kumar Valsan
Cc: Niranjana Vishwanathapura
Cc: Fei Yang
Signed-off-by: Mauro
From: Prathap Kumar Valsan
The GuC firmware has defined the interface for selective TLB
invalidation support. This patch adds routines to interface with GuC.
Signed-off-by: Prathap Kumar Valsan
CC: Matthew Brost
---
.../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 2 +
drivers/gpu/drm/i915/g
Enable GuC TLB invalidations for MTL. Though more platforms than just
MTL support GuC TLB invalidations, MTL is presently the only platform
that requires it for any purpose, so only enable it there for now to
minimize cross-platform impact.
Signed-off-by: Jonathan Cavitt
---
drivers/gpu/drm/i91
From: Prathap Kumar Valsan
The GuC firmware had defined the interface for Translation Look-Aside
Buffer (TLB) invalidation. We should use this interface when
invalidating the engine and GuC TLBs.
Add additional functionality to intel_gt_invalidate_tlb, invalidating
the GuC TLBs and falling back
Add a helper function to the GuC CT buffer that reports the expected
time to process all outstanding requests. As of now, there is no
functionality to check number of requests in the buffer, so the helper
function just reports 2 seconds, or 1ms per request up to the maximum
number of requests the
For the gt_tlb live selftest, when operating on the GSC engine,
increase the timeout from 10 ms to 200 ms because the GSC
engine is a bit slower than the rest.
Additionally, increase the default timeout from 10 ms to 20 ms
because msleep < 20ms can sleep for up to 20ms.
Signed-off-by: Jonathan Ca
It is not an error for GuC TLB invalidations to fail when the GT is
wedged or disabled, so do not process a wait failure as one in
guc_send_invalidate_tlb.
Signed-off-by: Fei Yang
Signed-off-by: Jonathan Cavitt
CC: John Harrison
---
.../gpu/drm/i915/gt/uc/intel_guc_submission.c | 18 +
From: Prathap Kumar Valsan
This supports selective and full tlb invalidations. When GuC is enabled
the tlb invalidations use guc ct otherwise use mmio interface.
Signed-off-by: Prathap Kumar Valsan
CC: Niranjana Vishwanathapura
CC: Fei Yang
Signed-off-by: Jonathan Cavitt
---
drivers/gpu/drm
Add device info flags for if GuC TLB Invalidation is enabled.
Signed-off-by: Jonathan Cavitt
---
drivers/gpu/drm/i915/i915_drv.h | 2 ++
drivers/gpu/drm/i915/intel_device_info.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/
For platforms supporting selective tlb invalidations, we don't need to
do a full tlb invalidation. Rather do a range based tlb invalidation for
every unbind of purged vma belongs to an active vm.
Signed-off-by: Prathap Kumar Valsan
Cc: Niranjana Vishwanathapura
Cc: Fei Yang
Signed-off-by: Mauro
Implement range-based TLB invalidations on top of GuC-based TLB
invalidations. This is the future plan for GuC-based TLB
invalidations because it helps improve performance over performing
full tlb invalidations all the time.
Jonathan Cavitt (7):
drm/i915: Add GuC TLB Invalidation device info fl
On 10/10/2023 07:36, Jonathan Cavitt wrote:
FIXME: CAT errors are cropping up on MTL. This removes them,
but the real root cause must still be diagnosed.
I think 'hides' would be more accurate than 'removes'. At least until we
have a better understanding of the issue.
Also, is there any perfo
Even though there is no leaking of resource here lets
just use the correct method to free crtc_state
Fixes: 8a3b3df39757 ("drm/i915: Clean up variable names in old dpll functions")
Signed-off-by: Suraj Kandpal
---
drivers/gpu/drm/i915/display/intel_dpll.c | 3 ++-
1 file changed, 2 insertions(+)
intel_encoder_current_mode() seems to leak some resource because
it uses kfree instead of intel_crtc_destroy_state let us fix that.
Fixes: de330815677d ("drm/i915: Reuse normal state readout for LVDS/DVO fixed
mode")
Signed-off-by: Suraj Kandpal
---
drivers/gpu/drm/i915/display/intel_display.c
Use intel_crtc_destroy_state to avoid leakage of any resources
instead of the usual kfree
Signed-off-by: Suraj Kandpal
Suraj Kandpal (2):
drm/i915/display: Use intel_crtc_destroy_state instead kfree
drm/i915/display: Use correct method to free crtc_state
drivers/gpu/drm/i915/display/intel_
On 10/9/2023 19:26, Patchwork wrote:
Project List - Patchwork *Patch Details*
*Series:* More print message helper updates
*URL:* https://patchwork.freedesktop.org/series/124853/
*State:*failure
*Details:*
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_124853v1/index.html
== Series Details ==
Series: drm/i915: Remove the module parameter 'fastboot' (rev4)
URL : https://patchwork.freedesktop.org/series/124255/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13733_full -> Patchwork_124255v4_full
On 10/10/2023 05:15, Andi Shyti wrote:
Hi,
I might have picked up the wrong series and missed some reviews
and the extra patch from Nirmoy with a real use of the
drm_dbg_ratelimited() that John was looking for.
Thanks,
Andi
I just found the original post of this from back in January
(https://p
Hi Mauro,
Thanks for review.
On Tuesday, 10 October 2023 15:33:57 CEST Mauro Carvalho Chehab wrote:
> On Mon, 9 Oct 2023 14:27:55 +0200
> Janusz Krzysztofik wrote:
>
> > There was an attempt to parse KTAP reports in the background while a kunit
> > test module is loading. However, since dynam
Hi Kamil,
Thanks for review.
On Tuesday, 10 October 2023 17:59:56 CEST Kamil Konieczny wrote:
> Hi Janusz,
> On 2023-10-09 at 14:27:55 +0200, Janusz Krzysztofik wrote:
> > There was an attempt to parse KTAP reports in the background while a kunit
> > test module is loading. However, since dynami
== Series Details ==
Series: drm/i915/display: Free crtc_state in verify_crtc_state (rev2)
URL : https://patchwork.freedesktop.org/series/124811/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13733_full -> Patchwork_124811v2_full
===
On Tue, Oct 10, 2023 at 05:42:28PM +0100, Tvrtko Ursulin wrote:
>
> On 10/10/2023 17:17, Andi Shyti wrote:
> > Hi Matt,
> >
> > > > > > FIXME: CAT errors are cropping up on MTL. This removes them,
> > > > > > but the real root cause must still be diagnosed.
> > > > >
> > > > > Do you have a lin
Hi Tvrtko,
On 2023-10-10 at 12:07:14 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Instead of asserting just skip trying to print columns when terminal is
> too narrow.
>
> At the same time fix some type confusion to fix calculations going huge.
>
> Signed-off-by: Tvrtko Ursulin
> Cl
Hi Tvrtko,
On 2023-10-10 at 12:07:13 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Padding the percentage bars and table columns with spaces happens quite a
> lot so lets do better than putchar at a time. Have a table of visually
> empty strings and build the required length out of thos
On Tue, Oct 10, 2023 at 06:17:27PM +0200, Andi Shyti wrote:
> Hi Matt,
>
> > > > > FIXME: CAT errors are cropping up on MTL. This removes them,
> > > > > but the real root cause must still be diagnosed.
> > > >
> > > > Do you have a link to specific IGT test(s) that illustrate the CAT
> > > > er
On 10/10/2023 17:17, Andi Shyti wrote:
Hi Matt,
FIXME: CAT errors are cropping up on MTL. This removes them,
but the real root cause must still be diagnosed.
Do you have a link to specific IGT test(s) that illustrate the CAT
errors so that we can ensure that they now appear fixed in CI?
On Fri, Oct 06, 2023 at 04:37:08PM +0300, Imre Deak wrote:
> This patchset moves the DSC DPCD capabilities from the encoder
> (intel_dp) to the connector. This is required since in an MST topology
> each connector has its own version of these capabilities, allowing
> to configure/enable the DSC dec
Hi Tvrtko,
On 2023-10-10 at 12:07:12 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> When I moved the client name to be last, I did not account for the fact
> current code skips showing engine utilisation until at least two sampling
> periods have passed. Consequence of this is that clien
Hi Tvrtko,
On 2023-10-10 at 12:07:11 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Recent refactoring broke the clients header in cases when there are no
> clients displayed. To fix it we need to account the width of the "NAME"
> label.
>
> Signed-off-by: Tvrtko Ursulin
Reviewed-by:
Hi Matt,
> > > > FIXME: CAT errors are cropping up on MTL. This removes them,
> > > > but the real root cause must still be diagnosed.
> > >
> > > Do you have a link to specific IGT test(s) that illustrate the CAT
> > > errors so that we can ensure that they now appear fixed in CI?
> >
> > this
On Tue, Oct 10, 2023 at 05:11:54PM +0200, Andi Shyti wrote:
> Hi Matt,
>
> On Tue, Oct 10, 2023 at 06:58:27AM -0700, Matt Roper wrote:
> > On Mon, Oct 09, 2023 at 04:38:56PM -0700, Jonathan Cavitt wrote:
> > > FIXME: CAT errors are cropping up on MTL. This removes them,
> > > but the real root ca
Hi Janusz,
On 2023-10-09 at 14:27:55 +0200, Janusz Krzysztofik wrote:
> There was an attempt to parse KTAP reports in the background while a kunit
> test module is loading. However, since dynamic sub-subtests can be
> executed only from the main thread, that attempt was not quite successful,
> as
On Tue, Oct 10, 2023 at 1:50 AM Jani Nikula wrote:
>
> On Tue, 10 Oct 2023, Jani Nikula wrote:
> > On Mon, 09 Oct 2023, Nathan Chancellor wrote:
> >> On Sun, Oct 08, 2023 at 12:28:46AM +0900, Masahiro Yamada wrote:
> >>> On Fri, Oct 6, 2023 at 9:35 PM Jani Nikula wrote:
> >>> >
> >>> > The kern
Hi Jonathan,
On Tue, Oct 10, 2023 at 08:02:37AM -0700, Jonathan Cavitt wrote:
> Implement GuC-based TLB invalidations and use them on MTL.
I have to admit that I'm a bit biased on this series. Given this
premise, you can add
Reviewed-by: Andi Shyti
to all the patches.
Nevertheless to get thi
1 - 100 of 175 matches
Mail list logo