[Intel-gfx] ✓ Fi.CI.BAT: success for Apply Wa_16018031267 / Wa_16018063123

2023-09-21 Thread Patchwork
== Series Details == Series: Apply Wa_16018031267 / Wa_16018063123 URL : https://patchwork.freedesktop.org/series/124073/ State : success == Summary == CI Bug Log - changes from CI_DRM_13667 -> Patchwork_124073v1 Summary --- **SUCCES

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Apply Wa_16018031267 / Wa_16018063123

2023-09-21 Thread Patchwork
== Series Details == Series: Apply Wa_16018031267 / Wa_16018063123 URL : https://patchwork.freedesktop.org/series/124073/ State : warning == Summary == Error: dim checkpatch failed f46718b72c16 drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123 -:15: WARNING:BAD_SIGN_OFF: Co-developed

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Apply Wa_16018031267 / Wa_16018063123

2023-09-21 Thread Patchwork
== Series Details == Series: Apply Wa_16018031267 / Wa_16018063123 URL : https://patchwork.freedesktop.org/series/124073/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Suppress 'ignoring reset notification' message

2023-09-21 Thread Patchwork
== Series Details == Series: drm/i915/guc: Suppress 'ignoring reset notification' message URL : https://patchwork.freedesktop.org/series/124072/ State : success == Summary == CI Bug Log - changes from CI_DRM_13667 -> Patchwork_124072v1 Summ

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: remove a static inline that requires including i915_drv.h

2023-09-21 Thread Patchwork
== Series Details == Series: drm/i915/gt: remove a static inline that requires including i915_drv.h URL : https://patchwork.freedesktop.org/series/124069/ State : success == Summary == CI Bug Log - changes from CI_DRM_13667 -> Patchwork_124069v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gt: remove a static inline that requires including i915_drv.h

2023-09-21 Thread Patchwork
== Series Details == Series: drm/i915/gt: remove a static inline that requires including i915_drv.h URL : https://patchwork.freedesktop.org/series/124069/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: remove inlines from i915_gem_execbuffer.c

2023-09-21 Thread Patchwork
== Series Details == Series: drm/i915/gem: remove inlines from i915_gem_execbuffer.c URL : https://patchwork.freedesktop.org/series/124068/ State : success == Summary == CI Bug Log - changes from CI_DRM_13667 -> Patchwork_124068v1 Summary -

Re: [Intel-gfx] [PATCH] drm/i915: Add Wa_18028616096

2023-09-21 Thread Chauhan, Shekhar
Quoting Gustavo Sousa: On 9/22/2023 02:31, Gustavo Sousa wrote: Quoting Shekhar Chauhan (2023-09-21 11:30:28-03:00) Drop UGM per set fragment threshold to 3 BSpec: 54833 Signed-off-by: Shekhar Chauhan --- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 + drivers/gpu/drm/i915/gt/intel_workaroun

[Intel-gfx] [PATCH] drm/i915: Add Wa_18028616096

2023-09-21 Thread Shekhar Chauhan
Drop UGM per set fragment threshold to 3 BSpec: 54833 Signed-off-by: Shekhar Chauhan --- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 + drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h b/drivers/gpu/d

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cx0: prefer forward declarations over includes

2023-09-21 Thread Patchwork
== Series Details == Series: drm/i915/cx0: prefer forward declarations over includes URL : https://patchwork.freedesktop.org/series/124067/ State : success == Summary == CI Bug Log - changes from CI_DRM_13667 -> Patchwork_124067v1 Summary -

[Intel-gfx] ✗ Fi.CI.BAT: failure for Apply Wa_16018031267 / Wa_16018063123 (rev2)

2023-09-21 Thread Patchwork
== Series Details == Series: Apply Wa_16018031267 / Wa_16018063123 (rev2) URL : https://patchwork.freedesktop.org/series/124011/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13667 -> Patchwork_124011v2 Summary --- *

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Apply Wa_16018031267 / Wa_16018063123 (rev2)

2023-09-21 Thread Patchwork
== Series Details == Series: Apply Wa_16018031267 / Wa_16018063123 (rev2) URL : https://patchwork.freedesktop.org/series/124011/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Apply Wa_16018031267 / Wa_16018063123 (rev2)

2023-09-21 Thread Patchwork
== Series Details == Series: Apply Wa_16018031267 / Wa_16018063123 (rev2) URL : https://patchwork.freedesktop.org/series/124011/ State : warning == Summary == Error: dim checkpatch failed 35e1bb3c7113 drm/i915: Enable NULL PTE support for vm scratch -:8: WARNING:TYPO_SPELLING: 'teh' may be mis

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: Remove gtt_offset from stream->oa_buffer.head/.tail (rev3)

2023-09-21 Thread Patchwork
== Series Details == Series: drm/i915/perf: Remove gtt_offset from stream->oa_buffer.head/.tail (rev3) URL : https://patchwork.freedesktop.org/series/123949/ State : success == Summary == CI Bug Log - changes from CI_DRM_13667 -> Patchwork_123949v3

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid/firmware: drop drm_kms_helper.edid_firmware backward compat

2023-09-21 Thread Patchwork
== Series Details == Series: drm/edid/firmware: drop drm_kms_helper.edid_firmware backward compat URL : https://patchwork.freedesktop.org/series/124065/ State : success == Summary == CI Bug Log - changes from CI_DRM_13667 -> Patchwork_124065v1 ==

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/edid/firmware: drop drm_kms_helper.edid_firmware backward compat

2023-09-21 Thread Patchwork
== Series Details == Series: drm/edid/firmware: drop drm_kms_helper.edid_firmware backward compat URL : https://patchwork.freedesktop.org/series/124065/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add Wa_18028616096 (rev3)

2023-09-21 Thread Patchwork
== Series Details == Series: drm/i915: Add Wa_18028616096 (rev3) URL : https://patchwork.freedesktop.org/series/123951/ State : success == Summary == CI Bug Log - changes from CI_DRM_13667 -> Patchwork_123951v3 Summary --- **SUCCESS*

[Intel-gfx] [PATCH v2] drm/i915/uapi: Enable L3 Bank Count Querying

2023-09-21 Thread Jonathan Cavitt
Extend the query ioctl to allow querying the count of the available L3 Banks on a given engine. Testcase: igt@i915_query@query-l3-bank-count Test-with: 20230921220001.3793008-1-jonathan.cav...@intel.com Signed-off-by: Jonathan Cavitt --- uAPI change requested by Compute UMD. Changes to Compute UM

[Intel-gfx] [PATCH 1/1] [CI] Test MTL DMC v2.17

2023-09-21 Thread Gustavo Sousa
NOT TO BE REVIEWED/MERGED. Hardcode DMC path to i915/mtl_dmc_ver2_17.bin for CI purposes. Signed-off-by: Gustavo Sousa --- drivers/gpu/drm/i915/display/intel_dmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i91

[Intel-gfx] [PATCH 0/1] [CI] Test MTL DMC v2.17

2023-09-21 Thread Gustavo Sousa
The following changes since commit 3672ccab9237315db2f3a28a47f8ac1062a5a35e: Merge branch 'mlimonci/fix-merge-requests-ci' into 'main' (2023-09-18 20:19:32 +) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware CI-dmc-mtl_2.17 for you to fetch changes

[Intel-gfx] ✓ Fi.CI.BAT: success for Test MTL DMC v2.16 (rev4)

2023-09-21 Thread Patchwork
== Series Details == Series: Test MTL DMC v2.16 (rev4) URL : https://patchwork.freedesktop.org/series/122986/ State : success == Summary == CI Bug Log - changes from CI_DRM_13666 -> Patchwork_122986v4 Summary --- **SUCCESS** No re

Re: [Intel-gfx] [PATCH] drm/i915: Add Wa_18028616096

2023-09-21 Thread Gustavo Sousa
Quoting Shekhar Chauhan (2023-09-21 11:30:28-03:00) >Drop UGM per set fragment threshold to 3 > >BSpec: 54833 >Signed-off-by: Shekhar Chauhan >--- > drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 + > drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++ > 2 files changed, 4 insertions(+) > >diff --

Re: [Intel-gfx] [PATCH] drm/i915/cx0: prefer forward declarations over includes

2023-09-21 Thread Rodrigo Vivi
On Thu, Sep 21, 2023 at 06:53:25PM +0300, Jani Nikula wrote: > Avoid including the world from headers when forward declarations > suffice. > > Cc: Radhakrishna Sripada > Signed-off-by: Jani Nikula Trusting more your compiler then my eyes, but Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/dr

Re: [Intel-gfx] [PATCH] drm/i915/gem: remove inlines from i915_gem_execbuffer.c

2023-09-21 Thread Rodrigo Vivi
On Thu, Sep 21, 2023 at 07:06:37PM +0300, Jani Nikula wrote: > Just let the compiler decide what's best. Turns out absolutely nothing > changes in the output with the inlines removed. > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi > > --- > > The same should really be done for most

[Intel-gfx] [PATCH 10/11] drm/i915/fdi: Improve FDI BW sharing between pipe B and C

2023-09-21 Thread Imre Deak
At the moment modesetting pipe C on IVB will fail if pipe B uses 4 FDI lanes. Make the BW sharing more dynamic by trying to reduce pipe B's link bpp in this case, until pipe B uses only up to 2 FDI lanes. For this instead of the encoder compute config retry loop - which reduced link bpp only for t

[Intel-gfx] [PATCH 11/11] drm/i915/fdi: Recompute state for affected CRTCs on FDI links

2023-09-21 Thread Imre Deak
Recompute the state of all CRTCs on an FDI link during a modeset that may be affected by the modeset of other CRTCs on the same link. This ensures that each CRTC on the link maximizes its BW use (after another CRTC is disabled). In practice this means recomputing pipe B's config on IVB if pipe C g

[Intel-gfx] [PATCH 06/11] drm/i915: Add helper to modeset a set of pipes

2023-09-21 Thread Imre Deak
Add intel_modeset_pipes_in_mask_early() to modeset a provided set of pipes, used in a follow-up patch. As opposed intel_modeset_all_pipes() which modesets only the active pipes - others don't requiring programming the HW - modeset all enabled pipes in intel_modeset_pipes_in_mask_early() which may

[Intel-gfx] [PATCH 08/11] drm/i915: Factor out a helper to check/compute all the CRTC states

2023-09-21 Thread Imre Deak
Factor out intel_atomic_check_config() to check and compute all the CRTC states. This will be used by a follow up patch to recompute/check the state until required by BW limitations between CRTCs. Reviewed-by: Ville Syrjälä Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_display

[Intel-gfx] [PATCH 09/11] drm/i915: Add helpers for BW management on shared display links

2023-09-21 Thread Imre Deak
At the moment a modeset fails if the config computation of a pipe can't fit its required BW to the available link BW even though the limitation may be resolved by reducing the BW requirement of other pipes. To improve the above this patch adds helper functions checking the overall BW limits after

[Intel-gfx] [PATCH 05/11] drm/i915/dp: Limit the output link bpp in DSC mode

2023-09-21 Thread Imre Deak
Limit the output link bpp in DSC mode to the link_config_limits link.min_bpp_x16 .. max_bpp_x16 range the same way it's done in non-DSC mode. Atm this doesn't make a difference, the link bpp range being 0 .. max pipe bpp, but a follow-up patch will need a way to reduce max link bpp below its curre

[Intel-gfx] [PATCH 04/11] drm/i915/dp: Update the link bpp limits for DSC mode

2023-09-21 Thread Imre Deak
In non-DSC mode the link bpp can be set in 2*3 bpp steps in the pipe bpp range, while in DSC mode it can be set in 1/16 bpp steps to any value up to the maximum pipe bpp. Update the limits accordingly in both modes to prepare for a follow-up patch which may need to reduce the max link bpp value and

[Intel-gfx] [PATCH 07/11] drm/i915: Rename intel_modeset_all_pipes() to intel_modeset_all_pipes_late()

2023-09-21 Thread Imre Deak
Rename intel_modeset_all_pipes() to intel_modeset_all_pipes_late() to clarify when the function can be called (vs. intel_modeset_pipes_in_mask_early()). Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +- drivers/gpu/dr

[Intel-gfx] [PATCH 02/11] drm/i915/dp: Track the pipe and link bpp limits separately

2023-09-21 Thread Imre Deak
A follow-up patch will need to limit the output link bpp both in the non-DSC and DSC configuration, so track the pipe and link bpp limits separately in the link_config_limits struct. Use .4 fixed point format for link bpp matching the 1/16 bpp granularity in DSC mode and for now keep this limit ma

[Intel-gfx] [PATCH 01/11] drm/i915/dp: Factor out helpers to compute the link limits

2023-09-21 Thread Imre Deak
Factor out helpers that DP / DP_MST encoders can use to compute the link rate/lane count and bpp limits. A follow-up patch will call these to recalculate the limits if DSC compression is required. Reviewed-by: Ville Syrjälä Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_dp.c

[Intel-gfx] [PATCH 03/11] drm/i915/dp: Skip computing a non-DSC link config if DSC is needed

2023-09-21 Thread Imre Deak
Computing the non-DSC mode link config is redundant once it's determined that DSC will be needed, so skip computing it. In a follow-up patch this simplifies setting the link limits which are dependent on the DSC vs. non-DSC mode. While at it sanitize the debug print about the MST DSC fallback path

[Intel-gfx] [PATCH 00/11] drm/i915: Improve BW management on FDI links

2023-09-21 Thread Imre Deak
This is the first half of patchset [1] enabling the BW management on FDI links, addressing the review comments and adding R-bs. [1] https://lore.kernel.org/all/20230914192659.757475-1-imre.d...@intel.com Cc: Jani Nikula Cc: Stanislav Lisovskiy Cc: Lyude Paul Cc: Ville Syrjälä Cc: Luca Coelho

[Intel-gfx] ✓ Fi.CI.BAT: success for fdinfo memory stats (rev7)

2023-09-21 Thread Patchwork
== Series Details == Series: fdinfo memory stats (rev7) URL : https://patchwork.freedesktop.org/series/119082/ State : success == Summary == CI Bug Log - changes from CI_DRM_13664 -> Patchwork_119082v7 Summary --- **SUCCESS** No r

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for fdinfo memory stats (rev7)

2023-09-21 Thread Patchwork
== Series Details == Series: fdinfo memory stats (rev7) URL : https://patchwork.freedesktop.org/series/119082/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH v13 1/2] drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123

2023-09-21 Thread Jonathan Cavitt
Apply WABB blit for Wa_16018031267 / Wa_16018063123. Additionally, update the lrc selftest to exercise the new WABB changes. Wa_16018031267 / Wa_16018063123 specifically requires a dummy context to prevent taking vm space away from userspace, so additional functionality was added to allow such a c

[Intel-gfx] [PATCH v13 0/2] Apply Wa_16018031267 / Wa_16018063123

2023-09-21 Thread Jonathan Cavitt
Apply Wa_16018031267 / Wa_16018063123. This necessitates submitting a fastcolor blit as WABB and setting the copy engine arbitration to round-robin mode. v2: - Rename old platform check in second patch to match declaration in first patch. - Refactor second patch name to match first patch. v3:

[Intel-gfx] [PATCH v13 2/2] drm/i915: Set copy engine arbitration for Wa_16018031267 / Wa_16018063123

2023-09-21 Thread Jonathan Cavitt
Set copy engine arbitration into round robin mode for part of Wa_16018031267 / Wa_16018063123 mitigation. Signed-off-by: Nirmoy Das Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/i915/gt/intel_engine_regs.h | 3 +++ drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 + 2 files changed, 8 i

[Intel-gfx] ✓ Fi.CI.BAT: success for MAINTAINERS: Update drm-misc entry to match all drivers

2023-09-21 Thread Patchwork
== Series Details == Series: MAINTAINERS: Update drm-misc entry to match all drivers URL : https://patchwork.freedesktop.org/series/124045/ State : success == Summary == CI Bug Log - changes from CI_DRM_13664 -> Patchwork_124045v1 Summary -

[Intel-gfx] [PATCH] drm/i915/guc: Suppress 'ignoring reset notification' message

2023-09-21 Thread John . C . Harrison
From: John Harrison If an active context has been banned (e.g. Ctrl+C killed) then it is likely to be reset as part of evicting it from the hardware. That results in a 'ignoring context reset notification: banned = 1' message at info level. This confuses/concerns people and makes them thing somet

Re: [Intel-gfx] [Intel-xe] [PATCH v4 2/2] drm/i915/lnl: FBC is supported with per pixel alpha

2023-09-21 Thread Lucas De Marchi
On Thu, Sep 21, 2023 at 08:23:52PM +0300, Ville Syrjälä wrote: On Thu, Sep 21, 2023 at 08:22:23AM -0500, Lucas De Marchi wrote: On Wed, Sep 13, 2023 at 01:38:23PM +0300, Ville Syrjälä wrote: >On Mon, Sep 04, 2023 at 02:55:17PM +0300, Vinod Govindapillai wrote: >> For LNL onwards, FBC can be supp

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Print display info inside driver display initialization (rev2)

2023-09-21 Thread Patchwork
== Series Details == Series: drm/i915/display: Print display info inside driver display initialization (rev2) URL : https://patchwork.freedesktop.org/series/124032/ State : success == Summary == CI Bug Log - changes from CI_DRM_13664 -> Patchwork_124032v2 =

Re: [Intel-gfx] [Intel-xe] [PATCH v4 2/2] drm/i915/lnl: FBC is supported with per pixel alpha

2023-09-21 Thread Ville Syrjälä
On Thu, Sep 21, 2023 at 08:22:23AM -0500, Lucas De Marchi wrote: > On Wed, Sep 13, 2023 at 01:38:23PM +0300, Ville Syrjälä wrote: > >On Mon, Sep 04, 2023 at 02:55:17PM +0300, Vinod Govindapillai wrote: > >> For LNL onwards, FBC can be supported on planes with per > >> pixel alpha > >> > >> Bspec: 6

Re: [Intel-gfx] [PATCH] drm/i915/gt: remove a static inline that requires including i915_drv.h

2023-09-21 Thread Andi Shyti
Hi Jani, On Thu, Sep 21, 2023 at 07:24:56PM +0300, Jani Nikula wrote: > It's actively harmful to add static inlines in headers that require you > to pull in more headers. Remove the include added in commit f1530f912ed8 > ("drm/i915/gt: Apply workaround 22016122933 correctly"). We see that > there'

[Intel-gfx] [PATCH] drm/i915/gt: remove a static inline that requires including i915_drv.h

2023-09-21 Thread Jani Nikula
It's actively harmful to add static inlines in headers that require you to pull in more headers. Remove the include added in commit f1530f912ed8 ("drm/i915/gt: Apply workaround 22016122933 correctly"). We see that there's already an implicit dependency on the i915_drv.h that we need to address too.

[Intel-gfx] [PATCH] drm/i915/gem: remove inlines from i915_gem_execbuffer.c

2023-09-21 Thread Jani Nikula
Just let the compiler decide what's best. Turns out absolutely nothing changes in the output with the inlines removed. Signed-off-by: Jani Nikula --- The same should really be done for most inlines in .c files. *wink wink* --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 20 +---

[Intel-gfx] [PATCH] drm/i915/cx0: prefer forward declarations over includes

2023-09-21 Thread Jani Nikula
Avoid including the world from headers when forward declarations suffice. Cc: Radhakrishna Sripada Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cx0_phy.h | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cx

[Intel-gfx] ✗ Fi.CI.BAT: failure for Panel replay phase1 implementation (rev8)

2023-09-21 Thread Patchwork
== Series Details == Series: Panel replay phase1 implementation (rev8) URL : https://patchwork.freedesktop.org/series/94470/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13663 -> Patchwork_94470v8 Summary --- **FAIL

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/perf: Remove gtt_offset from stream->oa_buffer.head/.tail (rev2)

2023-09-21 Thread Dixit, Ashutosh
On Wed, 20 Sep 2023 20:00:54 -0700, Patchwork wrote: > > Patch Details > > Series: drm/i915/perf: Remove gtt_offset from stream->oa_buffer.head/.tail > (rev2) > URL: https://patchwork.freedesktop.org/series/123949/ > State: failure > Details: > https://intel-gfx-ci.01.org/tree/drm-tip/Pat

[Intel-gfx] [PULL] drm-misc-fixes

2023-09-21 Thread Thomas Zimmermann
Hi Dave and Daniel, this is the PR for drm-misc-fixes for this week. Best regards Thomas drm-misc-fixes-2023-09-21: Short summary of fixes pull: * DRM MM-test fixes * Fbdev Kconfig fixes * ivpu: * IRQ-handling fixes * meson: * Fix memory leak in HDMI EDID code * nouveau: * Corr

[Intel-gfx] [PATCH] drm/edid/firmware: drop drm_kms_helper.edid_firmware backward compat

2023-09-21 Thread Jani Nikula
Since the edid_firmware module parameter was moved from drm_kms_helper.ko to drm.ko in v4.15, we've had a backwards compatibility helper in place, with a DRM_NOTE() suggesting to migrate to drm.edid_firmware. This was added in commit ac6c35a4d8c7 ("drm: add backwards compatibility support for drm_k

Re: [Intel-gfx] [PATCH 2/2] drm/i915/hdcp: Move common message filling function to its own file

2023-09-21 Thread kernel test robot
Hi Suraj, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Suraj-Kandpal/drm-i915-hdcp-Move-checks-for-gsc-health-status/20230921-174353 base: git://anongit.freedesktop.org/drm/drm-tip drm

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Panel replay phase1 implementation (rev8)

2023-09-21 Thread Patchwork
== Series Details == Series: Panel replay phase1 implementation (rev8) URL : https://patchwork.freedesktop.org/series/94470/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Panel replay phase1 implementation (rev8)

2023-09-21 Thread Patchwork
== Series Details == Series: Panel replay phase1 implementation (rev8) URL : https://patchwork.freedesktop.org/series/94470/ State : warning == Summary == Error: dim checkpatch failed 3f24c3c37948 drm/panelreplay: dpcd register definition for panelreplay ee3fadb3d092 drm/i915/psr: Move psr spe

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,01/22] drm/i915/xelpdp: Add XE_LPDP_FEATURES

2023-09-21 Thread Lucas De Marchi
On Wed, Sep 20, 2023 at 10:11:22AM +, Patchwork wrote: == Series Details == Series: series starting with [CI,01/22] drm/i915/xelpdp: Add XE_LPDP_FEATURES URL : https://patchwork.freedesktop.org/series/123938/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13652_full -> Pa

[Intel-gfx] [PULL] drm-intel-fixes

2023-09-21 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2023-09-21: - Prevent error pointer dereference (Dan Carpenter) - Fix PMU busyness values when using GuC mode (Umesh) Thanks, Rodrigo. The following changes since commit ce9ecca0238b140b88f43859b211c9fdfd8e5b70: Linux 6.6-rc2 (2023-09-17 14:40:24

Re: [Intel-gfx] [PATCH v2] drm/i915/irq: Clear GFX_MSTR_IRQ as part of IRQ reset

2023-09-21 Thread Ville Syrjälä
On Thu, Sep 21, 2023 at 11:40:22AM -0300, Gustavo Sousa wrote: > Quoting Ville Syrjälä (2023-09-20 17:29:42-03:00) > >On Wed, Sep 20, 2023 at 05:13:36PM -0300, Gustavo Sousa wrote: > >> Quoting Ville Syrjälä (2023-09-20 17:00:07-03:00) > >> >On Wed, Sep 20, 2023 at 04:53:52PM -0300, Gustavo Sousa w

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Convert fbdev to DRM client (rev2)

2023-09-21 Thread Thomas Zimmermann
Hi Am 21.09.23 um 16:24 schrieb Jani Nikula: On Wed, 13 Sep 2023, Patchwork wrote: == Series Details == Series: drm/i915: Convert fbdev to DRM client (rev2) URL : https://patchwork.freedesktop.org/series/115714/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13627 -> Patch

Re: [Intel-gfx] [PATCH v2] drm/i915/irq: Clear GFX_MSTR_IRQ as part of IRQ reset

2023-09-21 Thread Gustavo Sousa
Quoting Ville Syrjälä (2023-09-20 17:29:42-03:00) >On Wed, Sep 20, 2023 at 05:13:36PM -0300, Gustavo Sousa wrote: >> Quoting Ville Syrjälä (2023-09-20 17:00:07-03:00) >> >On Wed, Sep 20, 2023 at 04:53:52PM -0300, Gustavo Sousa wrote: >> >> Starting with Xe_LP+, GFX_MSTR_IRQ contains status bits tha

[Intel-gfx] [PATCH] drm/i915: Add Wa_18028616096

2023-09-21 Thread Shekhar Chauhan
Drop UGM per set fragment threshold to 3 BSpec: 54833 Signed-off-by: Shekhar Chauhan --- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 + drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h b/drivers/gpu/d

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Convert fbdev to DRM client (rev2)

2023-09-21 Thread Jani Nikula
On Wed, 13 Sep 2023, Patchwork wrote: > == Series Details == > > Series: drm/i915: Convert fbdev to DRM client (rev2) > URL : https://patchwork.freedesktop.org/series/115714/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_13627 -> Patchwork_115714v2 > ==

Re: [Intel-gfx] [PATCH v4 0/2] fbc on any planes

2023-09-21 Thread Lucas De Marchi
On Mon, Sep 04, 2023 at 02:55:15PM +0300, Vinod Govindapillai wrote: FBC can be supported in first three planes in lnl Vinod Govindapillai (2): drm/i915/lnl: possibility to enable FBC on first three planes drm/i915/lnl: FBC is supported with per pixel alpha please don't merge LNL patches bef

Re: [Intel-gfx] [PATCH 6/7] drm/i915: Toggle binder context ready status

2023-09-21 Thread Andi Shyti
Hi Nirmoy, [...] > diff --git a/drivers/gpu/drm/i915/i915_driver.c > b/drivers/gpu/drm/i915/i915_driver.c > index e5d693904123..07e95e9ab504 100644 > --- a/drivers/gpu/drm/i915/i915_driver.c > +++ b/drivers/gpu/drm/i915/i915_driver.c > @@ -817,6 +817,7 @@ int i915_driver_probe(struct pci_dev *pd

Re: [Intel-gfx] [Intel-xe] [PATCH v4 2/2] drm/i915/lnl: FBC is supported with per pixel alpha

2023-09-21 Thread Lucas De Marchi
On Wed, Sep 13, 2023 at 01:38:23PM +0300, Ville Syrjälä wrote: On Mon, Sep 04, 2023 at 02:55:17PM +0300, Vinod Govindapillai wrote: For LNL onwards, FBC can be supported on planes with per pixel alpha Bspec: 69560 Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_fbc.c

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Create a kernel context for GGTT updates

2023-09-21 Thread Andi Shyti
Hi Nirmoy, [...] > > GEM_BUG_ON(!llist_empty(&engine->barrier_tasks)); > > cleanup_status_page(engine); > > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_types.h > > b/drivers/gpu/drm/i915/gt/intel_engine_types.h > > index a7e677598004..a8f527fab0f0 100644 > > --- a/drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Enable GGTT updates with binder in MTL

2023-09-21 Thread Andi Shyti
Hi Nirmoy, On Mon, Sep 18, 2023 at 07:02:57PM +0200, Nirmoy Das wrote: > MTL can hang because of a HW bug while parallel reading/writing > from/to LMEM/GTTMMADR BAR so try to reduce GGTT update > related pci transactions with blitter command as recommended > for Wa_13010847436 and Wa_14019519902.

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Implement GGTT update method with MI_UPDATE_GTT

2023-09-21 Thread Andi Shyti
Hi Nirmoy, On Mon, Sep 18, 2023 at 07:02:55PM +0200, Nirmoy Das wrote: > Implement GGTT update method with blitter command, MI_UPDATE_GTT > and install those handlers if a platform requires that. > > v2: Make sure we hold the GT wakeref and Blitter engine wakeref before > we call mutex_lock/intel

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Implement for_each_sgt_daddr_next

2023-09-21 Thread Andi Shyti
Hi Nirmoy, On Mon, Sep 18, 2023 at 07:02:53PM +0200, Nirmoy Das wrote: > Implement a way to iterate over sgt with pre-initialized > sgt_iter state. > > Signed-off-by: Nirmoy Das > Reviewed-by: Oak Zeng Reviewed-by: Andi Shyti Andi

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Parameterize binder context creation

2023-09-21 Thread Andi Shyti
Hi Nirmoy, On Mon, Sep 18, 2023 at 07:02:54PM +0200, Nirmoy Das wrote: > Add i915_ggtt_require_binder() to indicate that i915 > needs to create binder context which will be used > by subsequent patch to enable i915_address_space vfuncs > that will use GPU commands to update GGTT. > > Signed-off-b

Re: [Intel-gfx] [PATCH 7/8] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp

2023-09-21 Thread Sharma, Swati2
On 21-Sep-23 5:44 PM, Jani Nikula wrote: On Thu, 21 Sep 2023, "Sharma, Swati2" wrote: On 21-Sep-23 1:30 PM, Jani Nikula wrote: On Wed, 13 Sep 2023, Mitul Golani wrote: From: Swati Sharma DSC_Sink_BPP_Precision entry is added to i915_dsc_fec_support_show to depict sink's precision. Also, ne

Re: [Intel-gfx] [PATCH] drm/i915/display/dp: Change DSC vs lower bpp priority

2023-09-21 Thread Jani Nikula
On Wed, 20 Sep 2023, Charlton Lin wrote: > Previously driver would lower bpp before trying DSC. Monitors > capable of acheiving highest mode with either DSC or lower bpp > would have bpp dropped instead of attempting DSC at higher bpp. > > Changed the order in which driver attempts DSC and lower b

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Update RC6 mask for mtl_drpc (rev2)

2023-09-21 Thread Gupta, Anshuman
On 9/21/2023 4:10 PM, Nilawar, Badal wrote: These failures are not related to the changes in patch. pushed to drm-inte-gt-next with some modification in commit log. thanks for patch. Br, Anshuman. Regards, Badal Nilawar *From:*Patchwork *Sent:* 20 September 2023 20:07 *To:* Nilawar, Bad

[Intel-gfx] [PATCH 1/1] [CI] Test MTL DMC v2.16

2023-09-21 Thread Gustavo Sousa
NOT TO BE REVIEWED/MERGED. Hardcode DMC path to i915/mtl_dmc_ver2_17.bin for CI purposes. Signed-off-by: Gustavo Sousa --- drivers/gpu/drm/i915/display/intel_dmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i91

[Intel-gfx] [PATCH 0/1] [CI] Test MTL DMC v2.16

2023-09-21 Thread Gustavo Sousa
The following changes since commit 3672ccab9237315db2f3a28a47f8ac1062a5a35e: Merge branch 'mlimonci/fix-merge-requests-ci' into 'main' (2023-09-18 20:19:32 +) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware CI-dmc-mtl_2.17 for you to fetch changes

Re: [Intel-gfx] [PATCH 7/8] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp

2023-09-21 Thread Jani Nikula
On Thu, 21 Sep 2023, "Sharma, Swati2" wrote: > On 21-Sep-23 1:30 PM, Jani Nikula wrote: >> On Wed, 13 Sep 2023, Mitul Golani >> wrote: >>> From: Swati Sharma >>> >>> DSC_Sink_BPP_Precision entry is added to i915_dsc_fec_support_show >>> to depict sink's precision. >>> Also, new debugfs entry is

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Print display info inside driver display initialization

2023-09-21 Thread Jani Nikula
On Thu, 21 Sep 2023, Balasubramani Vivekanandan wrote: > Separate the printing of display version and feature flags from the main > driver probe to inside the display initialization. This is in alignment > with isolating the display code from the main driver and helps Xe driver > to resuse it. >

Re: [Intel-gfx] [PATCH 7/8] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp

2023-09-21 Thread Sharma, Swati2
On 21-Sep-23 1:30 PM, Jani Nikula wrote: On Wed, 13 Sep 2023, Mitul Golani wrote: From: Swati Sharma DSC_Sink_BPP_Precision entry is added to i915_dsc_fec_support_show to depict sink's precision. Also, new debugfs entry is created to enforce fractional bpp. If Force_DSC_Fractional_BPP_en is s

[Intel-gfx] [PATCH 5/5] drm/i915: Implement fdinfo memory stats printing

2023-09-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use the newly added drm_print_memory_stats helper to show memory utilisation of our objects in drm/driver specific fdinfo output. To collect the stats we walk the per memory regions object lists and accumulate object size into the respective drm_memory_stats categories. Obj

[Intel-gfx] [PATCH 2/5] drm/i915: Record which client owns a VM

2023-09-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin To enable accounting of indirect client memory usage (such as page tables) in the following patch, lets start recording the creator of each PPGTT. Signed-off-by: Tvrtko Ursulin Reviewed-by: Aravind Iddamsetty --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 11

[Intel-gfx] [PATCH 1/5] drm/i915: Add ability for tracking buffer objects per client

2023-09-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In order to show per client memory usage lets add some infrastructure which enables tracking buffer objects owned by clients. We add a per client list protected by a new per client lock and to support delayed destruction (post client exit) we make tracked objects hold refere

[Intel-gfx] [PATCH 4/5] drm/i915: Account ring buffer and context state storage

2023-09-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Account ring buffers and logical context space against the owning client memory usage stats. Signed-off-by: Tvrtko Ursulin Reviewed-by: Aravind Iddamsetty --- drivers/gpu/drm/i915/gt/intel_context.c | 14 ++ drivers/gpu/drm/i915/i915_drm_client.c | 10 +++

[Intel-gfx] [PATCH 3/5] drm/i915: Track page table backing store usage

2023-09-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Account page table backing store against the owning client memory usage stats. Signed-off-by: Tvrtko Ursulin Reviewed-by: Aravind Iddamsetty --- drivers/gpu/drm/i915/gt/intel_gtt.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_gtt

[Intel-gfx] [PATCH v7 0/5] fdinfo memory stats

2023-09-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A short series to enable fdinfo memory stats for i915. I added tracking of most classes of objects (user objects, page tables, context state, ring buffers) which contribute to client's memory footprint and am accouting their memory use along the similar lines as in Rob's msm

[Intel-gfx] [PATCH i-g-t 1/2] tests/i915/drm_fdinfo: Stress test context close versus fdinfo reads

2023-09-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A short smoke tests to exercise fdinfo reads in parallel to contexts getting created and destroyed. Signed-off-by: Tvrtko Ursulin --- tests/intel/drm_fdinfo.c | 68 1 file changed, 68 insertions(+) diff --git a/tests/intel/drm_fdin

[Intel-gfx] [PATCH i-g-t 2/2] tests/i915/drm_fdinfo: Add some memory info tests

2023-09-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A few basic smoke tests to check per client memory info looks legit. Signed-off-by: Tvrtko Ursulin --- tests/intel/drm_fdinfo.c | 201 +++ 1 file changed, 201 insertions(+) diff --git a/tests/intel/drm_fdinfo.c b/tests/intel/drm_fdinfo.

[Intel-gfx] [PATCH i-g-t 0/2] Basic tests for fdinfo client memory

2023-09-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Just some basic tests to check reported values look correct. Tvrtko Ursulin (2): tests/i915/drm_fdinfo: Stress test context close versus fdinfo reads tests/i915/drm_fdinfo: Add some memory info tests tests/intel/drm_fdinfo.c | 269 ++

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915/lnl: FBC is supported with per pixel alpha

2023-09-21 Thread Ville Syrjälä
On Thu, Sep 21, 2023 at 08:34:35AM +, Govindapillai, Vinod wrote: > On Wed, 2023-09-13 at 13:38 +0300, Ville Syrjälä wrote: > > On Mon, Sep 04, 2023 at 02:55:17PM +0300, Vinod Govindapillai wrote: > > > For LNL onwards, FBC can be supported on planes with per > > > pixel alpha > > > > > > Bspe

Re: [Intel-gfx] [PATCH] Revert "drm/i915/mst: Populate connector->ddc"

2023-09-21 Thread Ville Syrjälä
On Thu, Sep 21, 2023 at 12:28:53PM +0530, Karthik B S wrote: > > On 9/19/2023 3:26 PM, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > This reverts commit 959fb1a686528df1b8fb0cc7bec8ff851b1594a5. > > > > Looks like the core MST code might not call i2c_adapter() for us > > in time, and thus

Re: [Intel-gfx] [PATCH 00/10] drm/i915/spi: spi access for discrete graphics

2023-09-21 Thread Mark Brown
On Wed, Sep 20, 2023 at 09:00:08PM +, Winkler, Tomas wrote: > > This sounds like there's some sort of MFD rather than or as well as a flash > > chip, or possibly multiple SPI devices? > Yes, the driver doesn't talk to SPI controller directly it goes via > another layer, so all SPI standard HW

Re: [Intel-gfx] [PATCH v2] MAINTAINERS: Update drm-misc entry to match all drivers

2023-09-21 Thread Thomas Zimmermann
Am 21.09.23 um 12:57 schrieb Maxime Ripard: We've had a number of times when a patch slipped through and we couldn't pick them up either because our MAINTAINERS entry only covers the framework and thus we weren't Cc'd. Let's take another approach where we match everything, and remove all the d

[Intel-gfx] [PATCH v2] MAINTAINERS: Update drm-misc entry to match all drivers

2023-09-21 Thread Maxime Ripard
We've had a number of times when a patch slipped through and we couldn't pick them up either because our MAINTAINERS entry only covers the framework and thus we weren't Cc'd. Let's take another approach where we match everything, and remove all the drivers that are not maintained through drm-misc.

[Intel-gfx] [PATCH v2] drm/i915/display: Print display info inside driver display initialization

2023-09-21 Thread Balasubramani Vivekanandan
Separate the printing of display version and feature flags from the main driver probe to inside the display initialization. This is in alignment with isolating the display code from the main driver and helps Xe driver to resuse it. v2: Replace drm_info_printer with drm_debug_printer (Jani) Signed

Re: [Intel-gfx] [PATCH] drm/i915/gem: Allow users to disable waitboost

2023-09-21 Thread Tvrtko Ursulin
On 20/09/2023 22:56, Vinay Belgaumkar wrote: Provide a bit to disable waitboost while waiting on a gem object. Waitboost results in increased power consumption by requesting RP0 while waiting for the request to complete. Add a bit in the gem_wait() IOCTL where this can be disabled. This is rel

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Create a kernel context for GGTT updates

2023-09-21 Thread Andi Shyti
Hi Nirmoy, [...] > ce = create_kernel_context(engine); > if (IS_ERR(ce)) > return PTR_ERR(ce); > + /* > + * Create a separate pinned context for GGTT update with blitter engine > + * if a platform require such service. MI_UPDATE_GTT works on other > +

Re: [Intel-gfx] [PATCH] drm/i915: add a note about fec_enable with 128b/132b

2023-09-21 Thread Jani Nikula
On Wed, 20 Sep 2023, Ville Syrjälä wrote: > On Wed, Sep 20, 2023 at 02:29:01PM +0300, Jani Nikula wrote: >> Add a note that fec_enable actually means FEC is to be enabled >> explicitly. 128b/132b always has FEC enabled, the driver doesn't need to >> enable it separately, and fec_enable will be fal

Re: [Intel-gfx] [PATCH 1/1] drm/i915/uapi: Enable L3 Bank Count Querying

2023-09-21 Thread Cetnerowski, Adam
+@Hazubski, Filip -Original Message- From: Vivi, Rodrigo Sent: Wednesday, September 20, 2023 4:51 PM To: Cavitt, Jonathan Cc: intel-gfx@lists.freedesktop.org; Dunajski, Bartosz ; Cetnerowski, Adam ; Milczarek, Slawomir ; Mrozek, Michal ; Wright, James C ; Roper, Matthew D Subject:

Re: [Intel-gfx] [PATCH] drm/i915/display: Print display info inside driver display initialization

2023-09-21 Thread Balasubramani Vivekanandan
On 21.09.2023 10:38, Jani Nikula wrote: > On Thu, 21 Sep 2023, Balasubramani Vivekanandan > wrote: > > Separate the printing of display version and feature flags from the main > > driver probe to inside the display initialization. This is in alignment > > with isolating the display code from the

  1   2   >