Re: [Intel-gfx] [PATCH v15 16/23] drm/shmem-helper: Use kref for vmap_use_count

2023-09-02 Thread Dmitry Osipenko
On 8/28/23 13:00, Boris Brezillon wrote: > On Sun, 27 Aug 2023 20:54:42 +0300 > Dmitry Osipenko wrote: > >> Use kref helper for vmap_use_count to make refcounting consistent with >> pages_use_count and pages_pin_count that use kref. This will allow to >> optimize unlocked vmappings by skipping re

Re: [Intel-gfx] [PATCH v15 17/23] drm/shmem-helper: Add and use drm_gem_shmem_resv_assert_held() helper

2023-09-02 Thread Dmitry Osipenko
On 8/29/23 10:29, Boris Brezillon wrote: > On Tue, 29 Aug 2023 05:34:23 +0300 > Dmitry Osipenko wrote: > >> On 8/28/23 13:12, Boris Brezillon wrote: >>> On Sun, 27 Aug 2023 20:54:43 +0300 >>> Dmitry Osipenko wrote: >>> In a preparation of adding drm-shmem memory shrinker, move all reserv

Re: [Intel-gfx] [PATCH v15 02/23] drm/shmem-helper: Use flag for tracking page count bumped by get_pages_sgt()

2023-09-02 Thread Dmitry Osipenko
On 8/28/23 13:55, Boris Brezillon wrote: > On Sun, 27 Aug 2023 20:54:28 +0300 > Dmitry Osipenko wrote: > >> Use separate flag for tracking page count bumped by shmem->sgt to avoid >> imbalanced page counter during of drm_gem_shmem_free() time. It's fragile >> to assume that populated shmem->pages

Re: [Intel-gfx] [PATCH v15 01/23] drm/shmem-helper: Fix UAF in error path when freeing SGT of imported GEM

2023-09-02 Thread Dmitry Osipenko
On 8/28/23 14:16, Boris Brezillon wrote: > On Sun, 27 Aug 2023 20:54:27 +0300 > Dmitry Osipenko wrote: > >> Freeing drm-shmem GEM right after creating it using >> drm_gem_shmem_prime_import_sg_table() frees SGT of the imported dma-buf >> and then dma-buf frees this SGT second time. >> >> The v3d_

[Intel-gfx] [REGRESSION] Panic in gen8_ggtt_insert_entries() with v6.5

2023-09-02 Thread Oleksandr Natalenko
Hello. Since v6.5 kernel the following HW: * Lenovo T460s laptop with Skylake GT2 [HD Graphics 520] (rev 07) * Lenovo T490s laptop with WhiskeyLake-U GT2 [UHD Graphics 620] (rev 02) is affected by the following crash once KDE on either X11 or Wayland is started: i915 :00:02.0: enabling devi

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Apply Wa_16018031267 / Wa_16018063123

2023-09-02 Thread Andi Shyti
Hi Jonathan, > Possible regressions > > • igt@i915_selftest@live@gt_lrc: > > □ bat-dg1-5: PASS -> ABORT > > □ fi-rkl-11600: PASS -> INCOMPLETE > > □ bat-adlm-1: PASS -> ABORT > > □ fi-tgl-1115g4: PASS -> INCOMPLETE > > □ bat-rpls-1: PASS -> ABORT looks improv