Hello Ashutosh Dixit,
The patch 12d4eb20d9d8: "drm/i915/pmu: Use functions common with
sysfs to read actual freq" from Mar 15, 2023, leads to the following
Smatch static checker warning:
drivers/gpu/drm/i915/gt/intel_rps.c:2110 __read_cagf()
error: uninitialized symbol 'freq'.
dr
> From: Alex Williamson
> Sent: Wednesday, March 29, 2023 12:00 AM
>
[...]
> > > > A check. If the device that the _INFIO is invoked is opened via cdev,
> but
> > > there
> > > > are devices in the dev_set that are got via
> VFIO_GROUP_GET_DEVICE_FD,
> > > should
> > > > I fail it or allow it?
>
Hi Christian,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-tip/drm-tip]
url:
https://github.com/intel-lab-lkp/linux/commits/Christian-K-nig/drm-debugfs-rework-debugfs-directory-creation-v2/20230328-223907
base: git://anongit.freedesktop.org/drm/drm-tip drm
> From: Nicolin Chen
> Sent: Tuesday, March 28, 2023 11:55 PM
>
> On Mon, Mar 27, 2023 at 07:23:57PM -0700, Jon Pan-Doh wrote:
> > External email: Use caution opening links or attachments
> >
> >
> > On 2023/3/27 02:40, Yi Liu wrote:
> > > diff --git a/drivers/iommu/iommufd/iommufd_private.h
> b/
> From: Alex Williamson
> Sent: Wednesday, March 29, 2023 5:34 AM
>
> On Mon, 27 Mar 2023 02:40:31 -0700
> Yi Liu wrote:
>
> > Allow the vfio_device file to be in a state where the device FD is
> > opened but the device cannot be used by userspace (i.e. its .open_device()
> > hasn't been called
== Series Details ==
Series: drm/i915: move DSC RC tables to drm_dsc_helper.c (rev4)
URL : https://patchwork.freedesktop.org/series/114473/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12931 -> Patchwork_114473v4
Summary
-
== Series Details ==
Series: drm/i915: move DSC RC tables to drm_dsc_helper.c (rev4)
URL : https://patchwork.freedesktop.org/series/114473/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
+./arch/x86/inclu
On Tue, Mar 28, 2023 at 02:08:47PM +0100, Tvrtko Ursulin wrote:
On 28/03/2023 10:36, Min Li wrote:
Userspace can guess the id value and try to race oa_config object creation
with config remove, resulting in a use-after-free if we dereference the
object after unlocking the metrics_lock. For tha
Next commits are going to add support for additional RC parameter lookup
tables. These tables are going to use different bpp/bpc combinations,
thus it makes little sense to keep the 2d array for RC parameters.
Switch to using the flat array.
Reviewed-by: Jani Nikula
Signed-off-by: Dmitry Baryshko
After cross-checking DSC models (20150914, 20161212, 20210623) change
values in rc_parameters tables to follow config files present inside
the DSC model. Handle two places, where i915 tables diverged from the
model, by patching the rc values in the code.
Note: I left one case uncorrected, 8bpp/10b
Stop using an interim structure rc_parameters for storing calculated
params and then setting drm_dsc_config using that structure. Instead put
calculated params into the struct drm_dsc_config directly.
Reviewed-by: Jani Nikula
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/i915/display/inte
Use new DRM DSC helpers to setup DSI DSC configuration. The
initial_scale_value needs to be adjusted according to the standard, but
this is a separate change.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 61 --
1 file changed, 8 insertions(
The rc_buf_thresh values are common to all DSC implementations. Move
them to the common helper together with the code to propagage them to
the drm_dsc_config.
Reviewed-by: Jani Nikula
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/display/drm_dsc_helper.c | 35 +++
dri
Add a helper setting config values which are typically constant across
operating modes (table E-4 of the standard) and mux_word_size (which is
a const according to 3.5.2).
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/display/drm_dsc_helper.c | 21 +
include/drm/display
Include RC parameters for YCbCr 4:2:2 and 4:2:0 configurations.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/display/drm_dsc_helper.c | 438 +++
include/drm/display/drm_dsc_helper.h | 2 +
2 files changed, 440 insertions(+)
diff --git a/drivers/gpu/drm/display/d
Move DSC RC tables to DRM DSC helper. No additional code changes
and/or cleanups are a part of this commit, it will be cleaned up in the
followup commits.
Reviewed-by: Jani Nikula
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/display/drm_dsc_helper.c | 372 ++
drivers
DSC model contains pre-SCR RC parameters for other bpp/bpc combinations,
include them here for completeness.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/display/drm_dsc_helper.c | 72
1 file changed, 72 insertions(+)
diff --git a/drivers/gpu/drm/display/drm_dsc_
The array of rc_parameters contains a mixture of parameters from DSC 1.1
and DSC 1.2 standards. Split these tow configuration arrays in
preparation to adding more configuration data.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/display/drm_dsc_helper.c | 127 ++
drive
Other platforms (msm) will benefit from sharing the DSC config setup
functions. This series moves parts of static DSC config data from the
i915 driver to the common helpers to be used by other drivers.
Note: the RC parameters were cross-checked against config files found in
DSC model 2021062, 2016
== Series Details ==
Series: drm/i915/hwmon: Use 0 to designate disabled PL1 power limit
URL : https://patchwork.freedesktop.org/series/115749/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12931 -> Patchwork_115749v1
Summa
== Series Details ==
Series: drm/i915/hwmon: Use 0 to designate disabled PL1 power limit
URL : https://patchwork.freedesktop.org/series/115749/
State : warning
== Summary ==
Error: dim checkpatch failed
53e9cd9d9794 drm/i915/hwmon: Use 0 to designate disabled PL1 power limit
-:16: WARNING:COMM
== Series Details ==
Series: drm/i915: Make utility pin asserts more accurate
URL : https://patchwork.freedesktop.org/series/115741/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12931 -> Patchwork_115741v1
Summary
---
== Series Details ==
Series: drm/i915: Make utility pin asserts more accurate
URL : https://patchwork.freedesktop.org/series/115741/
State : warning
== Summary ==
Error: dim checkpatch failed
7920f6c79d29 drm/i915: Make utility pin asserts more accurate
-:12: WARNING:COMMIT_LOG_USE_LINK: Unkno
On ATSM the PL1 limit is disabled at power up. The previous uapi assumed
that the PL1 limit is always enabled and therefore did not have a notion of
a disabled PL1 limit. This results in erroneous PL1 limit values when the
PL1 limit is disabled. For example at power up, the disabled ATSM PL1 limit
== Series Details ==
Series: drm/i915: use ref_tracker library for tracking wakerefs (rev6)
URL : https://patchwork.freedesktop.org/series/100327/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/100327/revisions/6/mbox/ not
applied
Applying: lib/re
== Series Details ==
Series: drm/i915: move DSC RC tables to drm_dsc_helper.c (rev3)
URL : https://patchwork.freedesktop.org/series/114473/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/114473/revisions/3/mbox/ not
applied
Applying: drm/i915/dsc:
== Series Details ==
Series: series starting with [1/5] drm/debugfs: drop debugfs_init() for the
render and accel node v2
URL : https://patchwork.freedesktop.org/series/115729/
State : failure
== Summary ==
Error: make failed
CALLscripts/checksyscalls.sh
DESCEND objtool
INSTALL libs
== Series Details ==
Series: series starting with [1/1] drm/i915: fix race condition UAF in
i915_perf_add_config_ioctl
URL : https://patchwork.freedesktop.org/series/115727/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12931 -> Patchwork_115727v1
== Series Details ==
Series: Add vfio_device cdev for iommufd support (rev10)
URL : https://patchwork.freedesktop.org/series/113696/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/113696/revisions/10/mbox/ not
applied
Applying: vfio: Allocate per
On Tue, Mar 28, 2023 at 04:14:33PM +0530, Kalvala, Haridhar wrote:
>
> On 3/9/2023 8:56 PM, Lionel Landwerlin wrote:
> > By default the indirect state sampler data (border colors) are stored
> > in the same heap as the SAMPLER_STATE structure. For userspace drivers
> > that can be 2 different heap
== Series Details ==
Series: Patch "drm/i915/active: Fix missing debug object activation" has been
added to the 6.2-stable tree
URL : https://patchwork.freedesktop.org/series/115724/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/115724/revisions/
== Series Details ==
Series: Patch "drm/i915/active: Fix missing debug object activation" has been
added to the 6.1-stable tree
URL : https://patchwork.freedesktop.org/series/115723/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/115723/revisions/
Hi all,
Today's linux-next merge of the drm-msm tree got a conflict in:
drivers/gpu/drm/msm/adreno/adreno_gpu.c
between commit:
7fa5047a436b ("drm: Use of_property_present() for testing DT property
presence")
from the drm-misc tree and commit:
9f251f934012 ("drm/msm/adreno: Use OPP for
== Series Details ==
Series: Patch "drm/i915/active: Fix missing debug object activation" has been
added to the 5.15-stable tree
URL : https://patchwork.freedesktop.org/series/115722/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/115722/revisions
== Series Details ==
Series: drm/i915: Flag purely internal commits to not clear
crtc_state->inherited
URL : https://patchwork.freedesktop.org/series/115718/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12931 -> Patchwork_115718v1
== Series Details ==
Series: Patch "drm/i915/active: Fix missing debug object activation" has been
added to the 5.10-stable tree
URL : https://patchwork.freedesktop.org/series/115721/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/115721/revisions
== Series Details ==
Series: drm/i915: Flag purely internal commits to not clear
crtc_state->inherited
URL : https://patchwork.freedesktop.org/series/115718/
State : warning
== Summary ==
Error: dim checkpatch failed
42da1a902c21 drm/i915: Flag purely internal commits to not clear
crtc_state
The following changes since commit bcdcfbcf0a8f24a914b8c163906e6ce93d7f8897:
linux-firmware: Update firmware file for Intel Bluetooth AX101 (2023-03-20
08:34:27 -0400)
are available in the Git repository at:
git://anongit.freedesktop.org/drm/drm-firmware mtl_guc_70.6.4
for you to fetch cha
== Series Details ==
Series: drm/i915: Convert fbdev to DRM client
URL : https://patchwork.freedesktop.org/series/115714/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12931 -> Patchwork_115714v1
Summary
---
**FAILUR
== Series Details ==
Series: drm/i915: Convert fbdev to DRM client
URL : https://patchwork.freedesktop.org/series/115714/
State : warning
== Summary ==
Error: dim checkpatch failed
0eb95c1b5ac4 drm/i915: Move fbdev functions
-:119: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*ifbdev)...)
== Series Details ==
Series: drm/i915: (mostly) PSR related register cleanups
URL : https://patchwork.freedesktop.org/series/115708/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12931 -> Patchwork_115708v1
Summary
---
On Mon, 27 Mar 2023 02:40:31 -0700
Yi Liu wrote:
> Allow the vfio_device file to be in a state where the device FD is
> opened but the device cannot be used by userspace (i.e. its .open_device()
> hasn't been called). This inbetween state is not used when the device
> FD is spawned from the group
== Series Details ==
Series: drm/i915: (mostly) PSR related register cleanups
URL : https://patchwork.freedesktop.org/series/115708/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+./arch/x86/include/asm/bi
== Series Details ==
Series: drm/i915: (mostly) PSR related register cleanups
URL : https://patchwork.freedesktop.org/series/115708/
State : warning
== Summary ==
Error: dim checkpatch failed
ea8054e733df drm/i915: Fix up whitespace in some display chicken registers
9e76c77a8f5c drm/i915: Clea
On Tue, Mar 28, 2023 at 05:36:27PM +0800, Min Li wrote:
> Userspace can guess the id value and try to race oa_config object creation
> with config remove, resulting in a use-after-free if we dereference the
> object after unlocking the metrics_lock. For that reason, unlocking the
> metrics_lock mu
Hi Min,
On Tue, Mar 28, 2023 at 05:36:27PM +0800, Min Li wrote:
> Userspace can guess the id value and try to race oa_config object creation
> with config remove, resulting in a use-after-free if we dereference the
> object after unlocking the metrics_lock. For that reason, unlocking the
> metric
Hi Thomas,
I love your patch! Yet something to improve:
[auto build test ERROR on 6e5f96153989e454041848f66a5227be9bd0bbc3]
url:
https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/drm-i915-Move-fbdev-functions/20230328-191627
base: 6e5f96153989e454041848f66a5227be9bd0bbc3
BTW - I just started catching up with my email, is this waiting on me or was
someone else able to review it?
On Mon, 2023-02-20 at 18:47 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Grab the HDR DPCD refresh timeout (time we need to wait after
> writing the sourc OUI before the HDR DPCD
On Tue, Mar 28, 2023 at 01:09:49PM -0600, Alex Williamson wrote:
> "Just trigger it" is the same in either case. It seems bold to play
> the complexity argument when we already have a function that does 90%
> the correct thing where we can share much of the implementation and
> userspace code wit
On Tue, 28 Mar 2023 13:29:23 -0300
Jason Gunthorpe wrote:
> On Tue, Mar 28, 2023 at 09:18:01AM -0600, Alex Williamson wrote:
>
> > It's a niche case, but I think it needs to be allowed. We'd still
> > report the bdf for those devices, but make use of the invalid/null
> > dev-id.
>
> IDK, it
On Mon, Mar 27, 2023 at 04:29:55PM -0700, Belgaumkar, Vinay wrote:
>
> On 3/26/2023 4:04 AM, Rodrigo Vivi wrote:
> > On Fri, Mar 24, 2023 at 03:49:59PM -0700, Vinay Belgaumkar wrote:
> > > Use the xe_guc_pc test for i915 as well. Validate basic
> > > api for GT freq control. Also test interaction
On Tue, Mar 28, 2023 at 05:01:36PM +, Teres Alexis, Alan Previn wrote:
> On Mon, 2023-03-27 at 17:15 +0100, Tvrtko Ursulin wrote:
> > These two:
> > e6177ec586d1 ("drm/i915/huc: stall media submission until HuC is loaded")
> > b76c14c8fb2a ("drm/i915/huc: better define HuC status getparam possi
On Tue, 28 Mar 2023, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Only the PWM output mode of the utility pin is incompatible
> with DC6/LCPLL disable. Check for that specifically.
>
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/6609
> Signed-off-by: Ville Syrjälä
It's an im
On Mon, 2023-03-27 at 17:15 +0100, Tvrtko Ursulin wrote:
> These two:
> e6177ec586d1 ("drm/i915/huc: stall media submission until HuC is loaded")
> b76c14c8fb2a ("drm/i915/huc: better define HuC status getparam possible
> return values.")
> They do not help here? It is not possible to use or exten
From: Ville Syrjälä
Only the PWM output mode of the utility pin is incompatible
with DC6/LCPLL disable. Check for that specifically.
References: https://gitlab.freedesktop.org/drm/intel/-/issues/6609
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_display_power.c | 6 +
On Tue, Mar 28, 2023 at 09:18:01AM -0600, Alex Williamson wrote:
> It's a niche case, but I think it needs to be allowed. We'd still
> report the bdf for those devices, but make use of the invalid/null
> dev-id.
IDK, it makes the whole implementation much more complicated. Instead
of just copyin
On Mon, 27 Mar 2023, Rodrigo Vivi wrote:
> uncore->lock only protects the forcewake domain itself,
> not the register accesses.
>
> uncore's _fw alternatives are for cases where the domains
> are not needed because we are sure that they are already
> awake.
>
> So the move towards the uncore's _fw
On Tue, 28 Mar 2023 15:45:38 +
"Liu, Yi L" wrote:
> > From: Alex Williamson
> > Sent: Tuesday, March 28, 2023 11:18 PM
> >
> > On Tue, 28 Mar 2023 15:00:42 +
> > "Liu, Yi L" wrote:
> >
> > > > From: Alex Williamson
> > > > Sent: Tuesday, March 28, 2023 10:46 PM
> > > >
> > > > On T
On Mon, 27 Mar 2023, Imre Deak wrote:
> From: Zhang Rui
>
> The SMT siblings value returned by CPUID.1F SMT level EBX differs
> among CPUs on Intel Hybrid platforms like AlderLake and MeteorLake.
> It returns 2 for Pcore CPUs which have SMT siblings and returns 1 for
> Ecore CPUs which do not hav
On Mon, Mar 27, 2023 at 07:23:57PM -0700, Jon Pan-Doh wrote:
> External email: Use caution opening links or attachments
>
>
> On 2023/3/27 02:40, Yi Liu wrote:
> > diff --git a/drivers/iommu/iommufd/iommufd_private.h
> > b/drivers/iommu/iommufd/iommufd_private.h
> > index 2e6e8e217cce..ec2ce3ef1
On Mon, 27 Mar 2023, Rodrigo Vivi wrote:
> On Mon, Mar 27, 2023 at 01:53:30PM +0300, Jani Nikula wrote:
>> Essentially this is a revert of commit d9d54a530a70 ("drm/i915: Put
>> future HW and their uAPIs under STAGING & BROKEN").
>>
>> We currently have no users for this config option. The last o
> From: Alex Williamson
> Sent: Tuesday, March 28, 2023 11:18 PM
>
> On Tue, 28 Mar 2023 15:00:42 +
> "Liu, Yi L" wrote:
>
> > > From: Alex Williamson
> > > Sent: Tuesday, March 28, 2023 10:46 PM
> > >
> > > On Tue, 28 Mar 2023 14:38:12 +
> > > "Liu, Yi L" wrote:
> > >
> > > > > From:
On Mon, 2023-03-27 at 15:34 +0300, Mika Kahola wrote:
> Create a separate file to store registers for PICA chips
> C10 and C20.
>
> v2: Rename file (Jani)
> v3: Use _PICK_EVEN_2RANGES() macro (Lucas)
> Coding style fixed (Lucas)
>
> Signed-off-by: Radhakrishna Sripada
> Signed-off-by: Mika K
== Series Details ==
Series: x86/topology: fix erroneous smp_num_siblings on Intel Hybrid platform
(rev2)
URL : https://patchwork.freedesktop.org/series/115661/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12923_full -> Patchwork_115661v2_full
===
On Tue, 28 Mar 2023, Thomas Zimmermann wrote:
> Replace all code that initializes or releases fbdev emulation
> throughout the driver. Instead initialize the fbdev client by a
> single call to i915_fbdev_setup() after i915 has registered its
> DRM device. Just like in most drivers, i915 fbdev emul
On Tue, 28 Mar 2023, Thomas Zimmermann wrote:
> Initialize i915's fbdev client by giving an instance of struct
> drm_client_funcsi to drm_client_init(). Also clean up with
> drm_client_release().
>
> Doing this in i915 prevents fbdev helpers from initializing and
> releasing the client internally
On Tue, 28 Mar 2023 15:00:42 +
"Liu, Yi L" wrote:
> > From: Alex Williamson
> > Sent: Tuesday, March 28, 2023 10:46 PM
> >
> > On Tue, 28 Mar 2023 14:38:12 +
> > "Liu, Yi L" wrote:
> >
> > > > From: Alex Williamson
> > > > Sent: Tuesday, March 28, 2023 10:26 PM
> > > >
> > > > On T
Track every intel_gt_pm_get() until its corresponding release in
intel_gt_pm_put() by returning a cookie to the caller for acquire that
must be passed by on released. When there is an imbalance, we can see who
either tried to free a stale wakeref, or who forgot to free theirs.
Signed-off-by: Andrz
Beside reusing existing code, the main advantage of ref_tracker is
tracking per instance of wakeref. It allows also to catch double
put.
On the other side we lose information about the first acquire and
the last release, but the advantages outweigh it.
Signed-off-by: Andrzej Hajda
---
drivers/gp
From: Chris Wilson
There may be a disconnect between the GT used by the engine and the GT
used for the VM, requiring us to hold a wakeref on both while the GPU is
active with this request.
Signed-off-by: Chris Wilson
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/gt/intel_context.h
Wakeref has dedicated type. Assumption it will be int
compatible forever is incorrect.
Signed-off-by: Andrzej Hajda
Reviewed-by: Andi Shyti
---
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_
Library can handle allocation failures. To avoid allocation warnings
__GFP_NOWARN has been added everywhere. Moreover GFP_ATOMIC has been
replaced with GFP_NOWAIT in case of stack allocation on tracker free
call.
Signed-off-by: Andrzej Hajda
Reviewed-by: Andi Shyti
---
lib/ref_tracker.c | 5 +++
Similar to stack_(depot|trace)_snprint the patch
adds helper to printing stats to memory buffer.
It will be helpful in case of debugfs.
Signed-off-by: Andrzej Hajda
---
include/linux/ref_tracker.h | 8 +++
lib/ref_tracker.c | 56 ++---
2 fil
To have reliable detection of leaks, caller must be able to check under the same
lock both: tracked counter and the leaks. dir.lock is natural candidate for such
lock and unlocked print helper can be called with this lock taken.
As a bonus we can reuse this helper in ref_tracker_dir_exit.
Signed-o
In case the library is tracking busy subsystem, simply
printing stack for every active reference will spam log
with long, hard to read, redundant stack traces. To improve
readabilty following changes have been made:
- reports are printed per stack_handle - log is more compact,
- added display name
Gently ping for network developers, could you look at ref_tracker patches,
as the ref_tracker library was developed for network.
This is revived patchset improving ref_tracker library and converting
i915 internal tracker to ref_tracker.
The old thread ended without consensus about small kernel all
From: Nirmoy Das
commit e92eb246feb9019b0b137706c934b8891cdfe3c2 upstream.
debug_active_activate() expected ref->count to be zero
which is not true anymore as __i915_active_activate() calls
debug_active_activate() after incrementing the count.
v2: No need to check for "ref->count == 1" as __i91
From: Nirmoy Das
commit e92eb246feb9019b0b137706c934b8891cdfe3c2 upstream.
debug_active_activate() expected ref->count to be zero
which is not true anymore as __i915_active_activate() calls
debug_active_activate() after incrementing the count.
v2: No need to check for "ref->count == 1" as __i91
> From: Alex Williamson
> Sent: Tuesday, March 28, 2023 10:46 PM
>
> On Tue, 28 Mar 2023 14:38:12 +
> "Liu, Yi L" wrote:
>
> > > From: Alex Williamson
> > > Sent: Tuesday, March 28, 2023 10:26 PM
> > >
> > > On Tue, 28 Mar 2023 06:19:06 +
> > > "Tian, Kevin" wrote:
> > >
> > > > > Fro
From: Nirmoy Das
commit e92eb246feb9019b0b137706c934b8891cdfe3c2 upstream.
debug_active_activate() expected ref->count to be zero
which is not true anymore as __i915_active_activate() calls
debug_active_activate() after incrementing the count.
v2: No need to check for "ref->count == 1" as __i91
On Tue, 28 Mar 2023 14:38:12 +
"Liu, Yi L" wrote:
> > From: Alex Williamson
> > Sent: Tuesday, March 28, 2023 10:26 PM
> >
> > On Tue, 28 Mar 2023 06:19:06 +
> > "Tian, Kevin" wrote:
> >
> > > > From: Liu, Yi L
> > > > Sent: Tuesday, March 28, 2023 11:32 AM
> > > >
> > > > > From
> From: Jason Gunthorpe
> Sent: Tuesday, March 28, 2023 8:40 PM
>
> On Mon, Mar 27, 2023 at 02:34:58AM -0700, Yi Liu wrote:
>
> > + devices = kcalloc(count, sizeof(*devices), GFP_KERNEL);
> > + if (!devices) {
> > + ret = -ENOMEM;
> > + goto reset_info_exit;
> > + }
>
> From: Alex Williamson
> Sent: Tuesday, March 28, 2023 10:26 PM
>
> On Tue, 28 Mar 2023 06:19:06 +
> "Tian, Kevin" wrote:
>
> > > From: Liu, Yi L
> > > Sent: Tuesday, March 28, 2023 11:32 AM
> > >
> > > > From: Alex Williamson
> > > > Sent: Tuesday, March 28, 2023 3:26 AM
> > > >
> > > >
We only keept that around for API compatibility with drivers. Clean all
this up and use the per device debugfs directory.
Signed-off-by: Christian König
---
drivers/accel/drm_accel.c | 2 --
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c| 4 ++--
drivers/gpu/drm/amd/amdgp
Instead of the per minor directories only create a single debugfs
directory for the whole device directly when the device is initialized.
For DRM devices each minor gets a symlink to the per device directory
for now until we can be sure that this isn't useful any more in any way.
Accel devices cr
Use managed memory allocation for this. That allows us to not keep
track of all the files any more.
Signed-off-by: Christian König
---
drivers/accel/drm_accel.c | 2 -
drivers/gpu/drm/drm_debugfs.c | 75 +-
drivers/gpu/drm/drm_drv.c | 2 -
drivers/gpu
The mutex was completely pointless in the first place since any
parallel adding of files to this list would result in random
behavior since the list is filled and consumed multiple times.
Completely drop that approach and just create the files directly but
return -ENODEV while opening the file whe
We want to remove per minor debugfs directories. Start by stopping
drivers from adding anything inside of those in the mid layer callback.
v2: drop it for the accel node as well
Signed-off-by: Christian König
---
drivers/accel/drm_accel.c | 3 ---
drivers/gpu/drm/drm_debugfs.c | 2 +-
2 fil
On Tue, 28 Mar 2023 06:19:06 +
"Tian, Kevin" wrote:
> > From: Liu, Yi L
> > Sent: Tuesday, March 28, 2023 11:32 AM
> >
> > > From: Alex Williamson
> > > Sent: Tuesday, March 28, 2023 3:26 AM
> > >
> > > Additionally, VFIO_DEVICE_GET_PCI_HOT_RESET_INFO has a flags arg that
> > > isn't use
On 08/03/2023 15:53, Rob Clark wrote:
From: Rob Clark
Add a new flag to let userspace provide a deadline as a hint for syncobj
and timeline waits. This gives a hint to the driver signaling the
backing fences about how soon userspace needs it to compete work, so it
can addjust GPU frequency a
On 08/03/2023 15:52, Rob Clark wrote:
From: Rob Clark
This consists of simply storing the most recent deadline, and adding an
ioctl to retrieve the deadline. This can be used in conjunction with
the SET_DEADLINE ioctl on a fence fd for testing. Ie. create various
sw_sync fences, merge them
On Tue, 28 Mar 2023 at 16:20, Kandpal, Suraj wrote:
> > -Original Message-
> > From: dri-devel On Behalf Of Jani
> > Nikula
> > Sent: Wednesday, March 8, 2023 5:00 PM
> > To: Kandpal, Suraj ; dri-
> > de...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org
> > Cc: Dmitry Baryshkov ;
> -Original Message-
> From: dri-devel On Behalf Of Jani
> Nikula
> Sent: Wednesday, March 8, 2023 5:00 PM
> To: Kandpal, Suraj ; dri-
> de...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org
> Cc: Dmitry Baryshkov ; Nautiyal, Ankit K
> ; Shankar, Uma ;
> Kandpal, Suraj
> Subject
On 2023/3/27 02:40, Yi Liu wrote:
> diff --git a/drivers/iommu/iommufd/iommufd_private.h
> b/drivers/iommu/iommufd/iommufd_private.h
> index 2e6e8e217cce..ec2ce3ef187d 100644
> --- a/drivers/iommu/iommufd/iommufd_private.h
> +++ b/drivers/iommu/iommufd/iommufd_private.h
> @@ -263,6 +263,8 @@ struc
Userspace can guess the id value and try to race oa_config object creation
with config remove, resulting in a use-after-free if we dereference the
object after unlocking the metrics_lock. For that reason, unlocking the
metrics_lock must be done after we are done dereferencing the object.
Signed-o
On 28/03/2023 10:36, Min Li wrote:
Userspace can guess the id value and try to race oa_config object creation
with config remove, resulting in a use-after-free if we dereference the
object after unlocking the metrics_lock. For that reason, unlocking the
metrics_lock must be done after we are d
From: Tvrtko Ursulin
When numeric display is selected in the interactive mode it is more
descriptive to show client's non-normalized (by number of engines per
class) usage. Rendering of the visual representation (bar) is kept the
same.
Signed-off-by: Tvrtko Ursulin
---
tools/intel_gpu_top.c |
From: Tvrtko Ursulin
So far the width of the PID column was hardcoded to six characters which
is not enough on systems with high uptime, where PID numbers can grow
large, and results in broken line formatting.
Fix it by tracking the largest width for both the pid and name fields and
use them dyn
From: Tvrtko Ursulin
It appears we had an off by one of a kind where we were not using the full
width of the terminal window for the global metrics section.
Signed-off-by: Tvrtko Ursulin
---
tools/intel_gpu_top.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tools/i
From: Tvrtko Ursulin
Just some display formatting and display tweaks and fixes.
Tvrtko Ursulin (3):
intel_gpu_top: Display large pids nicely in interactive mode
intel_gpu_top: Use full console width for global metrics
intel_gpu_top: Show non-normalized client usage in numeric mode
tools/
1 - 100 of 144 matches
Mail list logo
