Re: [Intel-gfx] [PATCH v13 0/6] Enable HDCP2.x via GSC CS

2023-03-22 Thread Shankar, Uma
> -Original Message- > From: Kandpal, Suraj > Sent: Thursday, March 16, 2023 2:59 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nautiyal, Ankit K ; Shankar, Uma > ; Kandpal, Suraj > Subject: [PATCH v13 0/6] Enable HDCP2.x via GSC CS > > These patches enable HDCP2.x on machines MTL an

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/pxp: limit drm-errors or warning on firmware API failures (rev3)

2023-03-22 Thread Patchwork
== Series Details == Series: drm/i915/pxp: limit drm-errors or warning on firmware API failures (rev3) URL : https://patchwork.freedesktop.org/series/113680/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12902 -> Patchwork_113680v3

Re: [Intel-gfx] [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-22 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Wednesday, March 22, 2023 9:43 PM > > On Wed, Mar 22, 2023 at 01:33:09PM +, Liu, Yi L wrote: > > > Thanks. So this new _INFO only reports a limited scope instead of > > the full list of affected devices. Also, it is not static scope since device > > may be ope

[Intel-gfx] ✗ Fi.CI.BAT: failure for Improvements to GuC load failure handling (rev3)

2023-03-22 Thread Patchwork
== Series Details == Series: Improvements to GuC load failure handling (rev3) URL : https://patchwork.freedesktop.org/series/114168/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12902 -> Patchwork_114168v3 Summary ---

[Intel-gfx] [PATCH v4] drm/i915/pxp: limit drm-errors or warning on firmware API failures

2023-03-22 Thread Alan Previn
MESA driver is creating protected context on every driver handle creation to query caps bits for app. So when running CI tests, they are observing hundreds of drm_errors when enabling PXP in .config but using SOC fusing or BIOS configuration that cannot support PXP sessions. The fixes tag referenc

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Improvements to GuC load failure handling (rev3)

2023-03-22 Thread Patchwork
== Series Details == Series: Improvements to GuC load failure handling (rev3) URL : https://patchwork.freedesktop.org/series/114168/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Improvements to GuC load failure handling (rev3)

2023-03-22 Thread Patchwork
== Series Details == Series: Improvements to GuC load failure handling (rev3) URL : https://patchwork.freedesktop.org/series/114168/ State : warning == Summary == Error: dim checkpatch failed b4df7f16c846 drm/i915/guc: Improve GuC load error reporting 2be0fcf3087c drm/i915/guc: Allow for very

Re: [Intel-gfx] [PATCH] [i915] avoid infinite retries in GuC/HuC loading

2023-03-22 Thread Alexandre Oliva
On Mar 22, 2023, Rodrigo Vivi wrote: > On Sun, Mar 12, 2023 at 04:56:23PM -0300, Alexandre Oliva wrote: >> > Since __uc_fw_auto_select is also called from another place, > intel_uc_fw_init_early > out of the intel_uc_fw_fetch infinite loop, That other place is conceptually, sort of, the first i

Re: [Intel-gfx] [PATCH v3] drm/i915/pxp: limit drm-errors or warning on firmware API failures

2023-03-22 Thread Teres Alexis, Alan Previn
On Fri, 2023-03-17 at 13:37 +0200, Tamminen, Eero T wrote: > Hi, > > On 16.3.2023 10.50, Tvrtko Ursulin wrote: > > > [   11.674183] i915 :00:02.0: PXP init-arb-session-15 failed due > > > to BIOS/SOC:0x101a:ERR_PLATFORM_CONFIG > ... > > Alan - is this expected during normal operation on s

Re: [Intel-gfx] [PATCH 1/2] drm/i915: limit double GT reset to pre-MTL

2023-03-22 Thread Andi Shyti
Hi, > On 3/22/2023 12:44 PM, John Harrison wrote: > > On 3/20/2023 14:10, Daniele Ceraolo Spurio wrote: > > > Commit 3db9d590557d ("drm/i915/gt: Reset twice") modified the code to > > > always hit the GDRST register twice when doing a reset, with the > > > reported aim to fix invalid post-reset en

Re: [Intel-gfx] [PATCH] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock

2023-03-22 Thread David E. Box
Hi Bjorn, On Wed, 2023-03-22 at 15:57 -0500, Bjorn Helgaas wrote: > On Wed, Mar 22, 2023 at 03:45:01PM -0500, Bjorn Helgaas wrote: > > Hi David, > > > > On Tue, Mar 21, 2023 at 04:38:49PM -0700, David E. Box wrote: > > > The VMD driver calls pci_enabled_link_state as a callback from > > > pci_bus

Re: [Intel-gfx] [PATCH] drm/i915: Add i915.enable_sagv modparam

2023-03-22 Thread Rodrigo Vivi
On Wed, Mar 22, 2023 at 11:22:56PM +0200, Ville Syrjälä wrote: > On Wed, Mar 22, 2023 at 04:36:09PM -0400, Rodrigo Vivi wrote: > > On Wed, Mar 22, 2023 at 08:12:19PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Currently we have no sane way to forcibly disable SAGV, which > >

Re: [Intel-gfx] [PATCH] drm/i915: Add i915.enable_sagv modparam

2023-03-22 Thread Ville Syrjälä
On Wed, Mar 22, 2023 at 04:36:09PM -0400, Rodrigo Vivi wrote: > On Wed, Mar 22, 2023 at 08:12:19PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Currently we have no sane way to forcibly disable SAGV, which > > makes debugging things a PITA. Manually poking at the pcode > > mailbox

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/guc: Allow for very slow GuC loading

2023-03-22 Thread Ceraolo Spurio, Daniele
On 3/16/2023 3:06 PM, john.c.harri...@intel.com wrote: From: John Harrison A failure to load the GuC is occasionally observed where the GuC log actually showed that the GuC had loaded just fine. The implication being that the load just took ever so slightly longer than the 200ms timeout. Giv

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gsc: implement wa 14015076503

2023-03-22 Thread John Harrison
On 3/22/2023 13:59, Ceraolo Spurio, Daniele wrote: On 3/22/2023 12:44 PM, John Harrison wrote: On 3/20/2023 14:10, Daniele Ceraolo Spurio wrote: The WA states that we need to alert the GSC FW before doing a GSC engine reset and then wait for 200ms. The GuC owns engine reset, so on the i915 si

Re: [Intel-gfx] [PATCH 1/2] drm/i915: limit double GT reset to pre-MTL

2023-03-22 Thread Ceraolo Spurio, Daniele
On 3/22/2023 12:44 PM, John Harrison wrote: On 3/20/2023 14:10, Daniele Ceraolo Spurio wrote: Commit 3db9d590557d ("drm/i915/gt: Reset twice") modified the code to always hit the GDRST register twice when doing a reset, with the reported aim to fix invalid post-reset engine state on some plat

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gsc: implement wa 14015076503

2023-03-22 Thread Ceraolo Spurio, Daniele
On 3/22/2023 12:44 PM, John Harrison wrote: On 3/20/2023 14:10, Daniele Ceraolo Spurio wrote: The WA states that we need to alert the GSC FW before doing a GSC engine reset and then wait for 200ms. The GuC owns engine reset, so on the i915 side we only need to apply this for full GT reset. G

Re: [Intel-gfx] [PATCH] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock

2023-03-22 Thread Bjorn Helgaas
On Wed, Mar 22, 2023 at 03:45:01PM -0500, Bjorn Helgaas wrote: > Hi David, > > On Tue, Mar 21, 2023 at 04:38:49PM -0700, David E. Box wrote: > > The VMD driver calls pci_enabled_link_state as a callback from > > pci_bus_walk. Both will acquire the pci_bus_sem lock leading to a lockdep > > warning.

Re: [Intel-gfx] [PATCH] [i915] avoid infinite retries in GuC/HuC loading

2023-03-22 Thread Rodrigo Vivi
On Sun, Mar 12, 2023 at 04:56:23PM -0300, Alexandre Oliva wrote: > > If two or more suitable entries with the same filename are found in > __uc_fw_auto_select's fw_blobs, and that filename fails to load in the > first attempt and in the retry, when __uc_fw_auto_select is called for > the third tim

Re: [Intel-gfx] [PATCH] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock

2023-03-22 Thread Bjorn Helgaas
Hi David, On Tue, Mar 21, 2023 at 04:38:49PM -0700, David E. Box wrote: > The VMD driver calls pci_enabled_link_state as a callback from > pci_bus_walk. Both will acquire the pci_bus_sem lock leading to a lockdep > warning. Add an argument to pci_enable_link_state to set whether the lock > should

Re: [Intel-gfx] [PATCH] drm/i915: Add i915.enable_sagv modparam

2023-03-22 Thread Rodrigo Vivi
On Wed, Mar 22, 2023 at 08:12:19PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently we have no sane way to forcibly disable SAGV, which > makes debugging things a PITA. Manually poking at the pcode > mailbox with it's various SAGV/QGV/PSF formats is no fun, > and likely to be clobb

[Intel-gfx] ✓ Fi.CI.IGT: success for Correction to QGV related register addresses (rev2)

2023-03-22 Thread Patchwork
== Series Details == Series: Correction to QGV related register addresses (rev2) URL : https://patchwork.freedesktop.org/series/115473/ State : success == Summary == CI Bug Log - changes from CI_DRM_12897_full -> Patchwork_115473v2_full Sum

Re: [Intel-gfx] [Regression] drm/i915: Don't use BAR mappings for ring buffers with LLC alone creates issues in stable kernels

2023-03-22 Thread Philip Müller
On 21.03.23 14:12, Greg Kroah-Hartman wrote: On Tue, Mar 21, 2023 at 07:58:44AM +0700, Philip Müller wrote: On 20.03.23 20:28, Greg Kroah-Hartman wrote: On Sun, Mar 19, 2023 at 10:01:01AM +0700, Philip Müller wrote: Have to correct the affected kernels to these: 4.14.310, 4.19.278, 5.4.237, 5.

Re: [Intel-gfx] [Regression] drm/i915: Don't use BAR mappings for ring buffers with LLC alone creates issues in stable kernels

2023-03-22 Thread Philip Müller
On 20.03.23 20:28, Greg Kroah-Hartman wrote: On Sun, Mar 19, 2023 at 10:01:01AM +0700, Philip Müller wrote: Have to correct the affected kernels to these: 4.14.310, 4.19.278, 5.4.237, 5.10.175 Please don't top-post :( Anyway, should be fixed in the next round of releases in a few days, if not

Re: [Intel-gfx] [PATCH 1/2] drm/i915: limit double GT reset to pre-MTL

2023-03-22 Thread John Harrison
On 3/20/2023 14:10, Daniele Ceraolo Spurio wrote: Commit 3db9d590557d ("drm/i915/gt: Reset twice") modified the code to always hit the GDRST register twice when doing a reset, with the reported aim to fix invalid post-reset engine state on some platforms (Jasperlake being the only one actually me

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gsc: implement wa 14015076503

2023-03-22 Thread John Harrison
On 3/20/2023 14:10, Daniele Ceraolo Spurio wrote: The WA states that we need to alert the GSC FW before doing a GSC engine reset and then wait for 200ms. The GuC owns engine reset, so on the i915 side we only need to apply this for full GT reset. Given that we do full GT resets in the resume pat

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Add i915.enable_sagv modparam

2023-03-22 Thread Patchwork
== Series Details == Series: drm/i915: Add i915.enable_sagv modparam URL : https://patchwork.freedesktop.org/series/115523/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12898 -> Patchwork_115523v1 Summary --- **FAIL

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tc: Fix a few TypeC / MST issues (rev6)

2023-03-22 Thread Imre Deak
On Wed, Mar 22, 2023 at 03:07:44PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/tc: Fix a few TypeC / MST issues (rev6) > URL : https://patchwork.freedesktop.org/series/115270/ > State : success Thanks for the reviews, the patchset is pushed to din. > == Summary == > >

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add OAM support for MTL

2023-03-22 Thread Umesh Nerlige Ramappa
On Wed, Mar 22, 2023 at 09:11:15AM +, Patchwork wrote: Patch Details Series: Add OAM support for MTL URL: [1]https://patchwork.freedesktop.org/series/115469/ State: failure Details: [2]https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115469v1/index.html CI Bug Log - changes

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Add i915.enable_sagv modparam

2023-03-22 Thread Patchwork
== Series Details == Series: drm/i915: Add i915.enable_sagv modparam URL : https://patchwork.freedesktop.org/series/115523/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add i915.enable_sagv modparam

2023-03-22 Thread Patchwork
== Series Details == Series: drm/i915: Add i915.enable_sagv modparam URL : https://patchwork.freedesktop.org/series/115523/ State : warning == Summary == Error: dim checkpatch failed 0c284872ae1b drm/i915: Add i915.enable_sagv modparam -:49: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match

[Intel-gfx] ✓ Fi.CI.IGT: success for High refresh rate PSR fixes (rev5)

2023-03-22 Thread Patchwork
== Series Details == Series: High refresh rate PSR fixes (rev5) URL : https://patchwork.freedesktop.org/series/115109/ State : success == Summary == CI Bug Log - changes from CI_DRM_12897_full -> Patchwork_115109v5_full Summary --- *

[Intel-gfx] [PATCH] drm/i915: Add i915.enable_sagv modparam

2023-03-22 Thread Ville Syrjala
From: Ville Syrjälä Currently we have no sane way to forcibly disable SAGV, which makes debugging things a PITA. Manually poking at the pcode mailbox with it's various SAGV/QGV/PSF formats is no fun, and likely to be clobbered by the driver anyway. Let's add a modparam for this. Signed-off-by:

Re: [Intel-gfx] [PATCH 0/6] drm/i915/dpt: Fix DPT+shmem combo and add i915.enable_dpt modparam

2023-03-22 Thread Ville Syrjälä
On Wed, Mar 22, 2023 at 05:15:56PM +0200, Juha-Pekka Heikkila wrote: > Set look all ok, > > Reviewed-by: Juha-Pekka Heikkila Thanks. > > I guess should start to think about how to write igt tests which would > target directly at dpt so this kind of issues wouldn't get missed. Yeah, I was alr

[Intel-gfx] ✓ Fi.CI.BAT: success for Correction to QGV related register addresses (rev2)

2023-03-22 Thread Patchwork
== Series Details == Series: Correction to QGV related register addresses (rev2) URL : https://patchwork.freedesktop.org/series/115473/ State : success == Summary == CI Bug Log - changes from CI_DRM_12897 -> Patchwork_115473v2 Summary -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Correction to QGV related register addresses (rev2)

2023-03-22 Thread Patchwork
== Series Details == Series: Correction to QGV related register addresses (rev2) URL : https://patchwork.freedesktop.org/series/115473/ State : warning == Summary == Error: dim checkpatch failed fb0563a71e40 drm/i915/reg: fix QGV points register access offsets -:26: WARNING:LONG_LINE: line len

Re: [Intel-gfx] [PATCH 0/6] drm/i915/dpt: Fix DPT+shmem combo and add i915.enable_dpt modparam

2023-03-22 Thread Juha-Pekka Heikkila
Set look all ok, Reviewed-by: Juha-Pekka Heikkila I guess should start to think about how to write igt tests which would target directly at dpt so this kind of issues wouldn't get missed. /Juha-Pekka On 20.3.2023 11.05, Ville Syrjala wrote: From: Ville Syrjälä Avoid the shrinker evicting

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/reg: fix QGV points register access offsets

2023-03-22 Thread Ville Syrjälä
On Wed, Mar 22, 2023 at 04:20:50PM +0200, Vinod Govindapillai wrote: > Wrong offsets are calculated to read QGV point registers. Fix it > to read from the correct registers. > > v2: Avoid magic number and better handling the second bitgroup > > Bspec: 64602 > > Signed-off-by: Vinod Govindapillai

Re: [Intel-gfx] [PATCH v6 05/24] kvm/vfio: Accept vfio device file from userspace

2023-03-22 Thread Xu Yilun
On 2023-03-08 at 05:28:44 -0800, Yi Liu wrote: > This defines KVM_DEV_VFIO_FILE* and make alias with KVM_DEV_VFIO_GROUP*. > Old userspace uses KVM_DEV_VFIO_GROUP* works as well. > > Signed-off-by: Yi Liu > Reviewed-by: Jason Gunthorpe > Tested-by: Terrence Xu > Tested-by: Nicolin Chen > Tested

[Intel-gfx] [PATCH v2 2/2] drm/i915/reg: use the correct register to access SAGV block time

2023-03-22 Thread Vinod Govindapillai
Wrong register address is used to read the SAG block time. Fix the register address according to the bspec. Bspec: 64608 Signed-off-by: Vinod Govindapillai Reviewed-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[Intel-gfx] [PATCH v2 1/2] drm/i915/reg: fix QGV points register access offsets

2023-03-22 Thread Vinod Govindapillai
Wrong offsets are calculated to read QGV point registers. Fix it to read from the correct registers. v2: Avoid magic number and better handling the second bitgroup Bspec: 64602 Signed-off-by: Vinod Govindapillai Reviewed-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/i915_reg.h | 5 +++-- 1

[Intel-gfx] [PATCH v2 0/2] Correction to QGV related register addresses

2023-03-22 Thread Vinod Govindapillai
Wrong offsets are calculated to read QGV points from mem ss. Also a wrong register address is used to get the dagv block time. Fix these two issues. Vinod Govindapillai (2): drm/i915/reg: fix QGV points register access offsets drm/i915/reg: use the correct register to access SAGV block time

Re: [Intel-gfx] [PATCH v1 2/2] drm/i915/reg: use the correct register to access SAGV block time

2023-03-22 Thread Ville Syrjälä
On Wed, Mar 22, 2023 at 03:01:38AM +0200, Vinod Govindapillai wrote: > Wrong register address is used to read the SAG block time. Fix > the register address according to the bspec. > > Bspec: 64608 > > Signed-off-by: Vinod Govindapillai > --- > drivers/gpu/drm/i915/i915_reg.h | 2 +- > 1 file c

[Intel-gfx] ✓ Fi.CI.BAT: success for High refresh rate PSR fixes (rev5)

2023-03-22 Thread Patchwork
== Series Details == Series: High refresh rate PSR fixes (rev5) URL : https://patchwork.freedesktop.org/series/115109/ State : success == Summary == CI Bug Log - changes from CI_DRM_12897 -> Patchwork_115109v5 Summary --- **SUCCESS**

Re: [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/7] drm: remove drm_dev_set_unique

2023-03-22 Thread Christian König
Am 22.03.23 um 12:58 schrieb Jani Nikula: On Thu, 16 Mar 2023, Patchwork wrote: == Series Details == Series: series starting with [1/7] drm: remove drm_dev_set_unique URL : https://patchwork.freedesktop.org/series/115239/ State : failure == Summary == Error: patch https://patchwork.freede

Re: [Intel-gfx] [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-22 Thread Jason Gunthorpe
On Wed, Mar 22, 2023 at 01:33:09PM +, Liu, Yi L wrote: > Thanks. So this new _INFO only reports a limited scope instead of > the full list of affected devices. Also, it is not static scope since device > may be opened just after the _INFO returns. Yes, it would be simplest for qemu to do the

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for High refresh rate PSR fixes (rev5)

2023-03-22 Thread Patchwork
== Series Details == Series: High refresh rate PSR fixes (rev5) URL : https://patchwork.freedesktop.org/series/115109/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:117:1:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for High refresh rate PSR fixes (rev5)

2023-03-22 Thread Patchwork
== Series Details == Series: High refresh rate PSR fixes (rev5) URL : https://patchwork.freedesktop.org/series/115109/ State : warning == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/115109/revisions/5/mbox/ not found

Re: [Intel-gfx] [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-22 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Wednesday, March 22, 2023 8:18 PM > > On Wed, Mar 22, 2023 at 08:17:54AM +, Liu, Yi L wrote: > > > Could you elaborate what is required with _INFO before libvirt can > > use a FD pass? > > Make a new _INFO that returns an array of dev_ids within the cdev's > i

Re: [Intel-gfx] [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-22 Thread Jason Gunthorpe
On Wed, Mar 22, 2023 at 06:36:14AM -0600, Alex Williamson wrote: > On Wed, 22 Mar 2023 09:27:16 -0300 > Jason Gunthorpe wrote: > > > On Tue, Mar 21, 2023 at 04:47:37PM -0600, Alex Williamson wrote: > > > On Tue, 21 Mar 2023 19:20:37 -0300 > > > Jason Gunthorpe wrote: > > > > > > > On Tue, Mar

Re: [Intel-gfx] [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-22 Thread Alex Williamson
On Wed, 22 Mar 2023 09:27:16 -0300 Jason Gunthorpe wrote: > On Tue, Mar 21, 2023 at 04:47:37PM -0600, Alex Williamson wrote: > > On Tue, 21 Mar 2023 19:20:37 -0300 > > Jason Gunthorpe wrote: > > > > > On Tue, Mar 21, 2023 at 03:01:12PM -0600, Alex Williamson wrote: > > > > > > > > Though i

Re: [Intel-gfx] [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-22 Thread Jason Gunthorpe
On Tue, Mar 21, 2023 at 04:47:37PM -0600, Alex Williamson wrote: > On Tue, 21 Mar 2023 19:20:37 -0300 > Jason Gunthorpe wrote: > > > On Tue, Mar 21, 2023 at 03:01:12PM -0600, Alex Williamson wrote: > > > > > > Though it would be nice if qemu didn't need two implementations so Yi > > > > I'd rath

Re: [Intel-gfx] [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-22 Thread Alex Williamson
On Wed, 22 Mar 2023 04:42:16 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Wednesday, March 22, 2023 6:48 AM > > > > On Tue, 21 Mar 2023 19:20:37 -0300 > > Jason Gunthorpe wrote: > > > > > On Tue, Mar 21, 2023 at 03:01:12PM -0600, Alex Williamson wrote: > > > > > > > > Thou

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Communicate display power demands to pcode (rev2)

2023-03-22 Thread Patchwork
== Series Details == Series: drm/i915/display: Communicate display power demands to pcode (rev2) URL : https://patchwork.freedesktop.org/series/115371/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12895 -> Patchwork_115371v2 ===

Re: [Intel-gfx] [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-22 Thread Jason Gunthorpe
On Wed, Mar 22, 2023 at 08:17:54AM +, Liu, Yi L wrote: > Could you elaborate what is required with _INFO before libvirt can > use a FD pass? Make a new _INFO that returns an array of dev_ids within the cdev's iommufd_ctx that are part of the reset group, eg the devset. qemu will call this fo

Re: [Intel-gfx] [PATCH 01/14] drm/i915/tc: Abort DP AUX transfer on a disconnected TC port

2023-03-22 Thread Imre Deak
On Wed, Mar 22, 2023 at 12:19:26PM +0100, Andrzej Hajda wrote: > On 16.03.2023 14:17, Imre Deak wrote: > > On TC ports the 4ms AUX timeout combined with the 5 * 32 retry > > attempts during DPCD accesses adds a 640ms delay to each access if the > > sink is disconnected. This in turn slows down a mo

Re: [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/7] drm: remove drm_dev_set_unique

2023-03-22 Thread Jani Nikula
On Thu, 16 Mar 2023, Patchwork wrote: > == Series Details == > > Series: series starting with [1/7] drm: remove drm_dev_set_unique > URL : https://patchwork.freedesktop.org/series/115239/ > State : failure > > == Summary == > > Error: patch > https://patchwork.freedesktop.org/api/1.0/series/115

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/display: Communicate display power demands to pcode (rev2)

2023-03-22 Thread Patchwork
== Series Details == Series: drm/i915/display: Communicate display power demands to pcode (rev2) URL : https://patchwork.freedesktop.org/series/115371/ State : warning == Summary == Error: git fetch origin failed

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Communicate display power demands to pcode (rev2)

2023-03-22 Thread Patchwork
== Series Details == Series: drm/i915/display: Communicate display power demands to pcode (rev2) URL : https://patchwork.freedesktop.org/series/115371/ State : warning == Summary == Error: dim checkpatch failed c32b9b91ef02 drm/i915/display: Communicate display power demands to pcode -:9: WARN

[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915/display: Communicate display power demands to pcode (rev2)

2023-03-22 Thread Patchwork
== Series Details == Series: drm/i915/display: Communicate display power demands to pcode (rev2) URL : https://patchwork.freedesktop.org/series/115371/ State : warning == Summary == Error: git fetch origin failed

Re: [Intel-gfx] DRM debugfs cleanup take 3

2023-03-22 Thread Stanislaw Gruszka
On Thu, Mar 16, 2023 at 09:20:28AM +0100, Christian König wrote: > Hi guys, > > I've messed up the last send out. Cleanup up some issues reported by people > with the accel drivers (duplicated files) and rebased the result. > > Apart from that the same approach we already discussed previously.

Re: [Intel-gfx] [PATCH 01/14] drm/i915/tc: Abort DP AUX transfer on a disconnected TC port

2023-03-22 Thread Andrzej Hajda
On 16.03.2023 14:17, Imre Deak wrote: On TC ports the 4ms AUX timeout combined with the 5 * 32 retry attempts during DPCD accesses adds a 640ms delay to each access if the sink is disconnected. This in turn slows down a modeset during which the sink is disconnected (for instance a disabling modes

Re: [Intel-gfx] [PATCH 4/7] drm/debugfs: rework debugfs directory creation v2

2023-03-22 Thread Stanislaw Gruszka
On Thu, Mar 16, 2023 at 09:20:32AM +0100, Christian König wrote: > Instead of the per minor directories only create a single debugfs > directory for the whole device directly when the device is initialized. > > For DRM devices each minor gets a symlink to the per device directory > for now until w

[Intel-gfx] [PATCH v5 1/6] drm/i915/psr: Unify pre/post hooks

2023-03-22 Thread Jouni Högander
pre/post hooks are doing things differently. Unify them. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c

[Intel-gfx] [PATCH v5 4/6] drm/i915/psr: Add helpers for block count number handling

2023-03-22 Thread Jouni Högander
Add helpers to make it more clear how PSR2_CTL[Block Count Number] is configured. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers

[Intel-gfx] [PATCH v5 6/6] drm/i915/psr: Implement Display WA #1136

2023-03-22 Thread Jouni Högander
Implement Display WA #1136 for SKL/BXT. Bspec: 21664 Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 17 + drivers/gpu/drm/i915/display/skl_watermark.c | 5 - 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i9

[Intel-gfx] [PATCH v5 5/6] drm/i915/psr: Check that vblank is long enough for psr2

2023-03-22 Thread Jouni Högander
Ensure vblank >= psr2 vblank where Psr2 vblank = PSR2_CTL Block Count Number maximum line count. Bspec: 71580, 49274 v2: Use calculated block count number maximum line count Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 9 + 1 file changed, 9 insertions(+

[Intel-gfx] [PATCH v5 2/6] drm/i915/psr: Modify/fix Wa_16013835468 and prepare for Wa_14015648006

2023-03-22 Thread Jouni Högander
Wa_16013835468 is a separate from Wa_14015648006 and needs to be applied for TGL onwards. Fix this by removing all the references to Wa_14015648006 and apply Wa_16013835468 according to Bspec. Also move workaround into separate function as a preparation for Wa_14015648006 implementation. Apply thi

[Intel-gfx] [PATCH v5 3/6] drm/i915/psr: Implement Wa_14015648006

2023-03-22 Thread Jouni Högander
PSR WM optimization should be disabled based on any wm level being disabled. Also same WA should be applied for ICL as well. Bspec: 71580 v3 - Split patch v2 - set/clear chicken bit in post_plane_update - apply for ICL as well Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/i

[Intel-gfx] [PATCH v5 0/6] High refresh rate PSR fixes

2023-03-22 Thread Jouni Högander
Fix/adjust Wa_16013835468 and implement Wa_14015648006. Implement Wa_1136 and check for vblank being long enough for psr2. v5: - Add missing patch v4: - Keep/fix Wa_16013835468 - Use calculated block count number instead of fixed 12 v3: - apply Wa_16013835468 for icl as well - set/clear chick

[Intel-gfx] [PATCH v4 5/5] drm/i915/psr: Implement Display WA #1136

2023-03-22 Thread Jouni Högander
Implement Display WA #1136 for SKL/BXT. Bspec: 21664 Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 17 + drivers/gpu/drm/i915/display/skl_watermark.c | 5 - 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i9

[Intel-gfx] [PATCH v4 3/5] drm/i915/psr: Add helpers for block count number handling

2023-03-22 Thread Jouni Högander
Add helpers to make it more clear how PSR2_CTL[Block Count Number] is configured. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers

[Intel-gfx] [PATCH v4 4/5] drm/i915/psr: Check that vblank is long enough for psr2

2023-03-22 Thread Jouni Högander
Ensure vblank >= psr2 vblank where Psr2 vblank = PSR2_CTL Block Count Number maximum line count. Bspec: 71580, 49274 v2: Use calculated block count number maximum line count Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 9 + 1 file changed, 9 insertions(+

[Intel-gfx] [PATCH v4 2/5] drm/i915/psr: Implement Wa_14015648006

2023-03-22 Thread Jouni Högander
PSR WM optimization should be disabled based on any wm level being disabled. Also same WA should be applied for ICL as well. Bspec: 71580 v3 - Split patch v2 - set/clear chicken bit in post_plane_update - apply for ICL as well Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/i

[Intel-gfx] [PATCH v4 1/5] drm/i915/psr: Modify/fix Wa_16013835468 and prepare for Wa_14015648006

2023-03-22 Thread Jouni Högander
Wa_16013835468 is a separate from Wa_14015648006 and needs to be applied for TGL onwards. Fix this by removing all the references to Wa_14015648006 and apply Wa_16013835468 according to Bspec. Also move workaround into separate function as a preparation for Wa_14015648006 implementation. Apply thi

[Intel-gfx] [PATCH v4 0/5] High refresh rate PSR fixes

2023-03-22 Thread Jouni Högander
Fix/adjust Wa_16013835468 and implement Wa_14015648006. Implement Wa_1136 and check for vblank being long enough for psr2. v4: - Keep/fix Wa_16013835468 - Use calculated block count number instead of fixed 12 v3: - apply Wa_16013835468 for icl as well - set/clear chicken bit in post plane upda

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tc: Fix a few TypeC / MST issues (rev6)

2023-03-22 Thread Patchwork
== Series Details == Series: drm/i915/tc: Fix a few TypeC / MST issues (rev6) URL : https://patchwork.freedesktop.org/series/115270/ State : success == Summary == CI Bug Log - changes from CI_DRM_12893 -> Patchwork_115270v6 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for Correction to QGV related register addresses

2023-03-22 Thread Patchwork
== Series Details == Series: Correction to QGV related register addresses URL : https://patchwork.freedesktop.org/series/115473/ State : success == Summary == CI Bug Log - changes from CI_DRM_12893_full -> Patchwork_115473v1_full Summary --

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/tc: Fix a few TypeC / MST issues (rev6)

2023-03-22 Thread Patchwork
== Series Details == Series: drm/i915/tc: Fix a few TypeC / MST issues (rev6) URL : https://patchwork.freedesktop.org/series/115270/ State : warning == Summary == Error: git fetch origin failed

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/tc: Fix a few TypeC / MST issues (rev6)

2023-03-22 Thread Patchwork
== Series Details == Series: drm/i915/tc: Fix a few TypeC / MST issues (rev6) URL : https://patchwork.freedesktop.org/series/115270/ State : warning == Summary == Error: git fetch origin failed

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tc: Fix a few TypeC / MST issues (rev6)

2023-03-22 Thread Patchwork
== Series Details == Series: drm/i915/tc: Fix a few TypeC / MST issues (rev6) URL : https://patchwork.freedesktop.org/series/115270/ State : warning == Summary == Error: dim checkpatch failed 396311312b37 drm/i915/tc: Abort DP AUX transfer on a disconnected TC port -:19: WARNING:BAD_REPORTED_B

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Use i915 instead of dev_priv insied the file_priv structure

2023-03-22 Thread Patchwork
== Series Details == Series: drm/i915: Use i915 instead of dev_priv insied the file_priv structure URL : https://patchwork.freedesktop.org/series/115471/ State : success == Summary == CI Bug Log - changes from CI_DRM_12893_full -> Patchwork_115471v1_full ===

[Intel-gfx] ✗ Fi.CI.IGT: failure for Add OAM support for MTL

2023-03-22 Thread Patchwork
== Series Details == Series: Add OAM support for MTL URL : https://patchwork.freedesktop.org/series/115469/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12893_full -> Patchwork_115469v1_full Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Check for unreliable MMIO during forcewake

2023-03-22 Thread Andrzej Hajda
On 21.03.2023 18:09, Andi Shyti wrote: From: Matt Roper Although we now sanitycheck MMIO access during driver load to make sure the MMIO BAR isn't returning all 0x, there have been a few cases where (temporarily?) unreliable MMIO access has happened after GPU resets or power events. We

[Intel-gfx] ✓ Fi.CI.IGT: success for PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock

2023-03-22 Thread Patchwork
== Series Details == Series: PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock URL : https://patchwork.freedesktop.org/series/115466/ State : success == Summary == CI Bug Log - changes from CI_DRM_12893_full -> Patchwork_115466v1_full ===

Re: [Intel-gfx] [PATCH] drm/i915: Use i915 instead of dev_priv insied the file_priv structure

2023-03-22 Thread Andrzej Hajda
On 22.03.2023 01:16, Andi Shyti wrote: In the process of renaming all instances of 'dev_priv' to 'i915', start using 'i915' within the 'drm_i915_file_private' structure. Signed-off-by: Andi Shyti Apparently the last struct member with this name, R.I.P. Reviewed-by: Andrzej Hajda Regards An

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Sanitycheck MMIO access early in driver load

2023-03-22 Thread Andrzej Hajda
On 21.03.2023 23:43, Andi Shyti wrote: Hi Matt, We occasionally see the PCI device in a non-accessible state at the point the driver is loaded. When this happens, all BAR accesses will read back as 0x. Rather than reading registers and misinterpreting their (invalid) values, let's spe

Re: [Intel-gfx] [PATCH v1 2/2] drm/i915/reg: use the correct register to access SAGV block time

2023-03-22 Thread Lisovskiy, Stanislav
On Wed, Mar 22, 2023 at 03:01:38AM +0200, Vinod Govindapillai wrote: > Wrong register address is used to read the SAG block time. Fix > the register address according to the bspec. > > Bspec: 64608 > > Signed-off-by: Vinod Govindapillai > --- > drivers/gpu/drm/i915/i915_reg.h | 2 +- > 1 file c

Re: [Intel-gfx] [PATCH v1 1/2] drm/i915/reg: fix QGV points register access offsets

2023-03-22 Thread Lisovskiy, Stanislav
On Wed, Mar 22, 2023 at 03:01:37AM +0200, Vinod Govindapillai wrote: > Wrong offsets are calculated to read QGV point registers. Fix it > to read from the correct registers. > > Bspec: 64602 > > Signed-off-by: Vinod Govindapillai > --- > drivers/gpu/drm/i915/i915_reg.h | 4 ++-- > 1 file change

Re: [Intel-gfx] [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-22 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Wednesday, March 22, 2023 4:50 AM > > On Tue, Mar 21, 2023 at 02:31:22PM -0600, Alex Williamson wrote: > > > This just seems like nit-picking that the API could have accomplished > > this more concisely. Probably that's true, but I think you've > > identified a g

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Make IRQ reset and postinstall multi-gt aware

2023-03-22 Thread Patchwork
== Series Details == Series: drm/i915: Make IRQ reset and postinstall multi-gt aware URL : https://patchwork.freedesktop.org/series/115465/ State : success == Summary == CI Bug Log - changes from CI_DRM_12890_full -> Patchwork_115465v1_full

[Intel-gfx] ✓ Fi.CI.IGT: success for Report MMIO communication problems more clearly (rev2)

2023-03-22 Thread Patchwork
== Series Details == Series: Report MMIO communication problems more clearly (rev2) URL : https://patchwork.freedesktop.org/series/115421/ State : success == Summary == CI Bug Log - changes from CI_DRM_12890_full -> Patchwork_115421v2_full