[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Fix live_requests for all engines (rev2)

2023-02-27 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Fix live_requests for all engines (rev2) URL : https://patchwork.freedesktop.org/series/114393/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12789_full -> Patchwork_114393v2_full

Re: [Intel-gfx] [PATCH v5 10/19] vfio: Add infrastructure for bind_iommufd from userspace

2023-02-27 Thread Liu, Yi L
> From: Liu, Yi L > Sent: Tuesday, February 28, 2023 10:35 AM > > > From: Jason Gunthorpe > > Sent: Tuesday, February 28, 2023 2:30 AM > > > > On Mon, Feb 27, 2023 at 03:11:26AM -0800, Yi Liu wrote: > > > For the device fd opened from cdev, userspace needs to bind it to an > > > iommufd and atta

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pxp: Add MTL PXP Support (rev6)

2023-02-27 Thread Patchwork
== Series Details == Series: drm/i915/pxp: Add MTL PXP Support (rev6) URL : https://patchwork.freedesktop.org/series/112647/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12789_full -> Patchwork_112647v6_full Summary --

Re: [Intel-gfx] [PATCH v5 18/19] vfio: Compile group optionally

2023-02-27 Thread Liu, Yi L
> From: Liu, Yi L > Sent: Monday, February 27, 2023 7:12 PM > > group code is not needed for vfio device cdev, so with vfio device cdev > introduced, the group infrastructures can be compiled out if only cdev > is needed. > > Signed-off-by: Yi Liu > --- > drivers/vfio/Kconfig | 14 + >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hwmon: Accept writes of value 0 to power1_max_interval

2023-02-27 Thread Patchwork
== Series Details == Series: drm/i915/hwmon: Accept writes of value 0 to power1_max_interval URL : https://patchwork.freedesktop.org/series/114459/ State : success == Summary == CI Bug Log - changes from CI_DRM_12789 -> Patchwork_114459v1 S

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Fix live_requests for all engines (rev2)

2023-02-27 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Fix live_requests for all engines (rev2) URL : https://patchwork.freedesktop.org/series/114393/ State : success == Summary == CI Bug Log - changes from CI_DRM_12789 -> Patchwork_114393v2 Summ

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Fix live_requests for all engines (rev2)

2023-02-27 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Fix live_requests for all engines (rev2) URL : https://patchwork.freedesktop.org/series/114393/ State : warning == Summary == Error: dim checkpatch failed 3342b504f81b drm/i915/selftests: Fix live_requests for all engines -:213: WARNING:AVOID_BU

[Intel-gfx] [PATCH] drm/i915/hwmon: Accept writes of value 0 to power1_max_interval

2023-02-27 Thread Ashutosh Dixit
The value shown by power1_max_interval in millisec is essentially: ((1.x * power(2,y)) * 1000) >> 10 Where x and y are read from a HW register. On ATSM, x and y are 0 on power-up so the value shown is 0. Writes of 0 to power1_max_interval had previously been disallowed to avoid computing i

[Intel-gfx] [Intel-gfx V2] drm/i915/selftests: Fix live_requests for all engines

2023-02-27 Thread Tejas Upadhyay
From: Tvrtko Ursulin After the abandonment of i915->kernel_context and since we have started to create per-gt engine->kernel_context, these tests need to be updated to instantiate the batch buffer VMA in the correct PPGTT for the context used to execute each spinner. v2(Tejas): - Clean commit

Re: [Intel-gfx] [PATCH v5 16/19] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-02-27 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Tuesday, February 28, 2023 3:20 AM > > On Mon, Feb 27, 2023 at 03:11:32AM -0800, Yi Liu wrote: > > This adds ioctl for userspace to bind device cdev fd to iommufd. > > > > VFIO_DEVICE_BIND_IOMMUFD: bind device to an iommufd, hence gain > DMA > >

Re: [Intel-gfx] [PATCH v5 15/19] vfio: Add cdev for vfio_device

2023-02-27 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Tuesday, February 28, 2023 3:06 AM > > On Mon, Feb 27, 2023 at 03:11:31AM -0800, Yi Liu wrote: > > @@ -309,6 +310,13 @@ void vfio_unregister_group_dev(struct > vfio_device *device) > > bool interrupted = false; > > long rc; > > > > + /* > > +* Balance

Re: [Intel-gfx] [PATCH v5 15/19] vfio: Add cdev for vfio_device

2023-02-27 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Tuesday, February 28, 2023 2:56 AM > > On Mon, Feb 27, 2023 at 03:11:31AM -0800, Yi Liu wrote: > > diff --git a/drivers/vfio/Kconfig b/drivers/vfio/Kconfig > > index a8f544629467..169762316513 100644 > > --- a/drivers/vfio/Kconfig > > +++ b/drivers/vfio/Kconfig > >

Re: [Intel-gfx] [PATCH v5 18/19] vfio: Compile group optionally

2023-02-27 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Tuesday, February 28, 2023 3:20 AM > > On Mon, Feb 27, 2023 at 03:11:34AM -0800, Yi Liu wrote: > > > diff --git a/include/linux/vfio.h b/include/linux/vfio.h > > index ce390533cb30..d12384824656 100644 > > --- a/include/linux/vfio.h > > +++ b/include/linux/vfio.h

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pxp: Add MTL PXP Support (rev6)

2023-02-27 Thread Patchwork
== Series Details == Series: drm/i915/pxp: Add MTL PXP Support (rev6) URL : https://patchwork.freedesktop.org/series/112647/ State : success == Summary == CI Bug Log - changes from CI_DRM_12789 -> Patchwork_112647v6 Summary --- **SUC

Re: [Intel-gfx] [PATCH v5 14/19] vfio: Make vfio_device_open() single open for device cdev path

2023-02-27 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Tuesday, February 28, 2023 2:52 AM > > On Mon, Feb 27, 2023 at 03:11:30AM -0800, Yi Liu wrote: > > @@ -535,7 +542,8 @@ static int vfio_device_fops_release(struct inode > *inode, struct file *filep) > > struct vfio_device_file *df = filep->private_data; > >

Re: [Intel-gfx] [PATCH v5 00/19] Add vfio_device cdev for iommufd support

2023-02-27 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Tuesday, February 28, 2023 3:21 AM > > On Mon, Feb 27, 2023 at 03:11:16AM -0800, Yi Liu wrote: > > Existing VFIO provides group-centric user APIs for userspace. Userspace > > opens the /dev/vfio/$group_id first before getting device fd and hence > > getting access

Re: [Intel-gfx] [PATCH v5 11/19] vfio-iommufd: Add detach_ioas support for physical VFIO devices

2023-02-27 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Tuesday, February 28, 2023 2:45 AM > > On Mon, Feb 27, 2023 at 03:11:27AM -0800, Yi Liu wrote: > > diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc.c b/drivers/vfio/fsl- > mc/vfio_fsl_mc.c > > index c89a047a4cd8..d540cf683d93 100644 > > --- a/drivers/vfio/fsl-mc/vfio_f

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/pxp: Add MTL PXP Support (rev6)

2023-02-27 Thread Patchwork
== Series Details == Series: drm/i915/pxp: Add MTL PXP Support (rev6) URL : https://patchwork.freedesktop.org/series/112647/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:1

Re: [Intel-gfx] [PATCH v5 17/19] vfio: Add VFIO_DEVICE_AT[DE]TACH_IOMMUFD_PT

2023-02-27 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Tuesday, February 28, 2023 2:39 AM > > On Mon, Feb 27, 2023 at 03:11:33AM -0800, Yi Liu wrote: > > This adds ioctl for userspace to attach device cdev fd to and detach > > from IOAS/hw_pagetable managed by iommufd. > > > > VFIO_DEVICE_ATTACH_IOMMUFD_PT: attach

[Intel-gfx] ✗ Fi.CI.BAT: failure for Fix error propagation amongst request

2023-02-27 Thread Patchwork
== Series Details == Series: Fix error propagation amongst request URL : https://patchwork.freedesktop.org/series/114451/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12789 -> Patchwork_114451v1 Summary --- **FAILUR

Re: [Intel-gfx] [PATCH v5 10/19] vfio: Add infrastructure for bind_iommufd from userspace

2023-02-27 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Tuesday, February 28, 2023 2:30 AM > > On Mon, Feb 27, 2023 at 03:11:26AM -0800, Yi Liu wrote: > > For the device fd opened from cdev, userspace needs to bind it to an > > iommufd and attach it to IOAS managed by iommufd. With such > operations, > > userspace can se

Re: [Intel-gfx] [PATCH v5 09/19] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-02-27 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Tuesday, February 28, 2023 2:23 AM > > On Mon, Feb 27, 2023 at 03:11:25AM -0800, Yi Liu wrote: > > to indicate kernel to use the device's bound iommufd_ctx for the device > > ownership check. Kernel should loop all the opened devices in the > dev_set, > > and check

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fix error propagation amongst request

2023-02-27 Thread Patchwork
== Series Details == Series: Fix error propagation amongst request URL : https://patchwork.freedesktop.org/series/114451/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:117:

[Intel-gfx] [PATCH v3 0/9] Add OAM support for MTL

2023-02-27 Thread Umesh Nerlige Ramappa
The OAM unit captures OA reports specific to the media engines. Add support to program the OAM unit on media tile on MTL. The OAM unit is selected by passing the class:instance of a media engine to perf parameters. Corresponding UMD changes are posted to the igt-dev repo as part of supporting the

[Intel-gfx] [PATCH v3 5/9] drm/i915/perf: Fail modprobe if i915_perf_init fails on OOM

2023-02-27 Thread Umesh Nerlige Ramappa
i915_perf_init can fail due to OOM. Fail driver init if i915_perf_init fails. v2: (Jani) - Reorder patch in the series Signed-off-by: Umesh Nerlige Ramappa Reviewed-by: Ashutosh Dixit --- drivers/gpu/drm/i915/i915_driver.c | 4 +++- drivers/gpu/drm/i915/i915_perf.c | 8 ++-- drivers/gpu/

[Intel-gfx] [PATCH v3 6/9] drm/i915/perf: Parse 64bit report header formats correctly

2023-02-27 Thread Umesh Nerlige Ramappa
Now that OA formats come in flavor of 64 bit reports, the report header has 64 bit report-id, timestamp, context-id and gpu-ticks fields. When filtering these reports, use the right width for these fields. Note that upper dword of context id is reserved, so squash lower dword only. v2: (Ashutosh)

[Intel-gfx] [PATCH v3 4/9] drm/i915/perf: Group engines into respective OA groups

2023-02-27 Thread Umesh Nerlige Ramappa
Now that we may have multiple OA units in a single GT as well as on separate GTs, create an engine group that maps to a single OA unit. v2: (Jani) - Drop warning on ENOMEM - Reorder patch in the series v3: (Ashutosh) - Remove unused members from perf structs - Update comments - Update engine_supp

[Intel-gfx] [PATCH v3 1/9] drm/i915/perf: Drop wakeref on GuC RC error

2023-02-27 Thread Umesh Nerlige Ramappa
From: Chris Wilson If we fail to adjust the GuC run-control on opening the perf stream, make sure we unwind the wakeref just taken. v2: Retain old goto label names (Ashutosh) Fixes: 01e742746785 ("drm/i915/guc: Support OA when Wa_16011777198 is enabled") Signed-off-by: Chris Wilson Reviewed-by

[Intel-gfx] [PATCH v3 9/9] drm/i915/perf: Add support for OA media units

2023-02-27 Thread Umesh Nerlige Ramappa
MTL introduces additional OA units dedicated to media use cases. Add support for programming these OA units by passing the media engine class and instance parameters. UMD specific changes for GPUvis support: https://patchwork.freedesktop.org/patch/522827/?series=114023 https://patchwork.freedeskto

[Intel-gfx] [PATCH v3 7/9] drm/i915/perf: Handle non-power-of-2 reports

2023-02-27 Thread Umesh Nerlige Ramappa
Some of the newer OA formats are not powers of 2. For those formats, adjust the hw_tail accordingly when checking for new reports. v2: (Ashutosh) - Switch to OA_TAKEN for diff calculation - Use OA_BUFFER_SIZE instead of the vma size - Update comments Signed-off-by: Umesh Nerlige Ramappa --- dri

[Intel-gfx] [PATCH v3 8/9] drm/i915/perf: Add engine class instance parameters to perf

2023-02-27 Thread Umesh Nerlige Ramappa
One or more engines map to a specific OA unit. All reports from these engines are captured in the OA buffer managed by this OA unit. Current i915 OA implementation supports only the OAG unit. OAG primarily caters to render engine, so i915 OA uses render as the default engine in the OA implementati

[Intel-gfx] [PATCH v3 3/9] drm/i915/perf: Validate OA sseu config outside switch

2023-02-27 Thread Umesh Nerlige Ramappa
Once OA supports media engine class:instance, the engine can only be validated outside the switch since class and instance parameters are separate entities. Since OA sseu config depends on engine class:instance, validate OA sseu config outside the switch. v2: (Ashutosh) - Clarify commit message -

[Intel-gfx] [PATCH v3 2/9] drm/i915/perf: Add helper to check supported OA engines

2023-02-27 Thread Umesh Nerlige Ramappa
With an intention to add more engines that are supported by OA, add helper to check for supported OA engines. v2: (Ashutosh) - Update commit message - Drop virtual engine check since we support only one render engine Signed-off-by: Umesh Nerlige Ramappa Reviewed-by: Ashutosh Dixit --- drivers/

[Intel-gfx] [PATCH v6 8/8] drm/i915/pxp: Enable PXP with MTL-GSC-CS

2023-02-27 Thread Alan Previn
Enable PXP with MTL-GSC-CS: add the has_pxp into device info and increase the debugfs teardown timeouts to align with new GSC-CS + firmware specs. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/i915_pci.c | 1 + drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c | 9 - driver

[Intel-gfx] [PATCH v6 6/8] drm/i915/pxp: MTL-KCR interrupt ctrl's are in GT-0

2023-02-27 Thread Alan Previn
Despite KCR subsystem being in the media-tile (close to the GSC-CS), the IRQ controls for it are on GT-0 with other global IRQ controls. Thus, add a helper for KCR hw interrupt enable/disable functions to get the correct gt structure (for uncore) for MTL. In the helper, we get GT-0's handle for un

[Intel-gfx] [PATCH v6 5/8] drm/i915/pxp: Add ARB session creation and cleanup

2023-02-27 Thread Alan Previn
Add MTL's function for ARB session creation using PXP firmware version 4.3 ABI structure format. Also add MTL's function for ARB session invalidation but this reuses PXP firmware version 4.2 ABI structure format. Before checking the return status, look at the GSC-CS-Mem-Header's pending-bit which

[Intel-gfx] [PATCH v6 4/8] drm/i915/pxp: Add GSC-CS backend to send GSC fw messages

2023-02-27 Thread Alan Previn
Add GSC engine based method for sending PXP firmware packets to the GSC firmware for MTL (and future) products. Use the newly added helpers to populate the GSC-CS memory header and send the message packet to the FW by dispatching the GSC_HECI_CMD_PKT instruction on the GSC engine. We use non-priv

[Intel-gfx] [PATCH v6 0/8] drm/i915/pxp: Add MTL PXP Support

2023-02-27 Thread Alan Previn
This series enables PXP on MTL. On ADL/TGL platforms, we rely on the mei driver via the i915-mei PXP component interface to establish a connection to the security firmware via the HECI device interface. That interface is used to create and teardown the PXP ARB session. PXP ARB session is created wh

[Intel-gfx] [PATCH v6 2/8] drm/i915/pxp: Add MTL hw-plumbing enabling for KCR operation

2023-02-27 Thread Alan Previn
Add MTL hw-plumbing enabling for KCR operation under PXP which includes: 1. Updating 'pick-gt' to get the media tile for KCR interrupt handling 2. Adding MTL's KCR registers for PXP operation (init, status-checking, etc.). While doing #2, lets create a separate registers header file for PXP

[Intel-gfx] [PATCH v6 7/8] drm/i915/pxp: On MTL, KCR enabling doesn't wait on tee component

2023-02-27 Thread Alan Previn
On legacy platforms, KCR HW enabling is done at the time the mei component interface is bound. It's also disabled during unbind. However, for MTL onwards, we don't depend on a tee component to start sending GSC-CS firmware messages. Thus, immediately enable (or disable) KCR HW on PXP's init, fini

[Intel-gfx] [PATCH v6 1/8] drm/i915/pxp: Add GSC-CS back-end resource init and cleanup

2023-02-27 Thread Alan Previn
For MTL, the PXP back-end transport uses the GSC engine to submit HECI packets through the HW to the GSC firmware for PXP arb session management. This submission uses a non-priveleged batch buffer, a buffer for the command packet and of course a context targeting the GSC-CS. Thus for MTL, we need

[Intel-gfx] [PATCH v6 3/8] drm/i915/pxp: Add MTL helpers to submit Heci-Cmd-Packet to GSC

2023-02-27 Thread Alan Previn
Add helper functions into a new file for heci-packet-submission. The helpers will handle generating the MTL GSC-CS Memory-Header and submission of the Heci-Cmd-Packet instructions to the engine. NOTE1: These common functions for heci-packet-submission will be used by different i915 callers: 1

[Intel-gfx] [PATCH v3 2/2] drm/i915/gt: Make sure that errors are propagated through request chains

2023-02-27 Thread Andi Shyti
Currently, when we perform operations such as clearing or copying large blocks of memory, we generate multiple requests that are executed in a chain. However, if one of these requests fails, we may not realize it unless it happens to be the last request in the chain. This is because errors are not

[Intel-gfx] [PATCH v3 1/2] drm/i915: Throttle for ringspace prior to taking the timeline mutex

2023-02-27 Thread Andi Shyti
From: Chris Wilson Before taking exclusive ownership of the ring for emitting the request, wait for space in the ring to become available. This allows others to take the timeline->mutex to make forward progresses while userspace is blocked. In particular, this allows regular clients to issue req

[Intel-gfx] [PATCH v3 0/2] Fix error propagation amongst request

2023-02-27 Thread Andi Shyti
Hi, This series of two patches fixes the issue introduced in cf586021642d80 ("drm/i915/gt: Pipelined page migration") where, as reported by Matt, in a chain of requests an error is reported only if happens in the last request. However Chris noticed that without ensuring exclusivity in the locking

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v5,1/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live

2023-02-27 Thread Patchwork
== Series Details == Series: series starting with [v5,1/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live URL : https://patchwork.freedesktop.org/series/114432/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12787_full -> Patchwork_114432v1_full =

Re: [Intel-gfx] [RFC 0/2] Add new CDCLK step for RPL-U

2023-02-27 Thread Matt Roper
On Mon, Jan 30, 2023 at 03:38:04PM +0530, Chaitanya Kumar Borah wrote: > A new step of 480MHz has been added on SKUs that have an RPL-U > device id. This particular step is to support 120Hz panels > more efficiently. > > This patchset adds a new table to include this new CDCLK > step. Details can

Re: [Intel-gfx] [PATCH v4 03/22] drm/i915/mtl: Create separate reg file for PICA registers

2023-02-27 Thread Matt Roper
On Fri, Feb 24, 2023 at 12:13:37PM +0200, Mika Kahola wrote: > Create a separate file to store registers for PICA chips > C10 and C20. > > v2: Rename file (Jani) > > Signed-off-by: Radhakrishna Sripada > Signed-off-by: Mika Kahola > --- > .../gpu/drm/i915/display/intel_cx0_phy_regs.h | 136 +++

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v4,1/2] drm/i915: Use correct huge page manager for MTL

2023-02-27 Thread Patchwork
== Series Details == Series: series starting with [v4,1/2] drm/i915: Use correct huge page manager for MTL URL : https://patchwork.freedesktop.org/series/114428/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12786_full -> Patchwork_114428v1_full ==

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/edid: Fix csync detailed mode parsing

2023-02-27 Thread Patchwork
== Series Details == Series: drm/edid: Fix csync detailed mode parsing URL : https://patchwork.freedesktop.org/series/114424/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12786_full -> Patchwork_114424v1_full Summary -

[Intel-gfx] ✗ Fi.CI.BAT: failure for Fix error propagation amongst requests

2023-02-27 Thread Patchwork
== Series Details == Series: Fix error propagation amongst requests URL : https://patchwork.freedesktop.org/series/11/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12787 -> Patchwork_11v1 Summary --- **FAILU

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fix error propagation amongst requests

2023-02-27 Thread Patchwork
== Series Details == Series: Fix error propagation amongst requests URL : https://patchwork.freedesktop.org/series/11/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:117

Re: [Intel-gfx] [RFC PATCH 1/2] drm/msm/dpu: add dsc helper functions

2023-02-27 Thread Abhinav Kumar
On 2/27/2023 11:25 AM, Dmitry Baryshkov wrote: 27 февраля 2023 г. 19:59:35 GMT+02:00, Abhinav Kumar пишет: On 2/27/2023 4:45 AM, Dmitry Baryshkov wrote: On Mon, 27 Feb 2023 at 01:49, Abhinav Kumar wrote: On 2/26/2023 5:09 AM, Dmitry Baryshkov wrote: On 26/02/2023 02:47, Abhinav Kum

[Intel-gfx] [PATCH v2 1/2] drm/i915: Throttle for ringspace prior to taking the timeline mutex

2023-02-27 Thread Andi Shyti
From: Chris Wilson Before taking exclusive ownership of the ring for emitting the request, wait for space in the ring to become available. This allows others to take the timeline->mutex to make forward progresses while userspace is blocked. In particular, this allows regular clients to issue req

[Intel-gfx] [PATCH v2 2/2] drm/i915/gt: Make sure that errors are propagated through request chains

2023-02-27 Thread Andi Shyti
Currently, when we perform operations such as clearing or copying large blocks of memory, we generate multiple requests that are executed in a chain. However, if one of these requests fails, we may not realize it unless it happens to be the last request in the chain. This is because errors are not

[Intel-gfx] [PATCH v2 0/2] Fix error propagation amongst requests

2023-02-27 Thread Andi Shyti
Hi, This series of two patches fixes the issue introduced in cf586021642d80 ("drm/i915/gt: Pipelined page migration") where, as reported by Matt, in a chain of requests an error is reported only if happens in the last request. However Chris noticed that without ensuring exclusivity in the locking

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/sseu: fix max_subslices array-index-out-of-bounds access (rev3)

2023-02-27 Thread Patchwork
== Series Details == Series: drm/i915/sseu: fix max_subslices array-index-out-of-bounds access (rev3) URL : https://patchwork.freedesktop.org/series/114199/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12787 -> Patchwork_114199v3 ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/sseu: fix max_subslices array-index-out-of-bounds access (rev3)

2023-02-27 Thread Patchwork
== Series Details == Series: drm/i915/sseu: fix max_subslices array-index-out-of-bounds access (rev3) URL : https://patchwork.freedesktop.org/series/114199/ State : warning == Summary == Error: dim checkpatch failed 4fd8113016d7 drm/i915/sseu: fix max_subslices array-index-out-of-bounds access

[Intel-gfx] [PATCH v7 15/15] drm/i915: Add deadline based boost support

2023-02-27 Thread Rob Clark
From: Rob Clark v2: rebase Signed-off-by: Rob Clark --- drivers/gpu/drm/i915/i915_request.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index 7503dcb9043b..44491e7e214c 100644 --- a/drivers

[Intel-gfx] [PATCH v7 00/15] dma-fence: Deadline awareness

2023-02-27 Thread Rob Clark
From: Rob Clark This series adds a deadline hint to fences, so realtime deadlines such as vblank can be communicated to the fence signaller for power/ frequency management decisions. This is partially inspired by a trick i915 does, but implemented via dma-fence for a couple of reasons: 1) To co

Re: [Intel-gfx] [RFC PATCH 1/2] drm/msm/dpu: add dsc helper functions

2023-02-27 Thread Dmitry Baryshkov
27 февраля 2023 г. 19:59:35 GMT+02:00, Abhinav Kumar пишет: > > >On 2/27/2023 4:45 AM, Dmitry Baryshkov wrote: >> On Mon, 27 Feb 2023 at 01:49, Abhinav Kumar >> wrote: >>> >>> >>> >>> On 2/26/2023 5:09 AM, Dmitry Baryshkov wrote: On 26/02/2023 02:47, Abhinav Kumar wrote: > Hi Dmitry

Re: [Intel-gfx] [PATCH v5 00/19] Add vfio_device cdev for iommufd support

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:16AM -0800, Yi Liu wrote: > Existing VFIO provides group-centric user APIs for userspace. Userspace > opens the /dev/vfio/$group_id first before getting device fd and hence > getting access to device. This is not the desired model for iommufd. Per > the conclusion of c

Re: [Intel-gfx] [PATCH v5 13/19] vfio: Add cdev_device_open_cnt to vfio_group

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:29AM -0800, Yi Liu wrote: > for counting the devices that are opened via the cdev path. This count > is increased and decreased by the cdev path. The group path checks it > to achieve exclusion with the cdev path. With this, only one path (group > path or cdev path) wi

Re: [Intel-gfx] [PATCH v5 18/19] vfio: Compile group optionally

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:34AM -0800, Yi Liu wrote: > diff --git a/include/linux/vfio.h b/include/linux/vfio.h > index ce390533cb30..d12384824656 100644 > --- a/include/linux/vfio.h > +++ b/include/linux/vfio.h > @@ -43,7 +43,9 @@ struct vfio_device { >*/ > const struct vfio_migr

Re: [Intel-gfx] [PATCH v5 16/19] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:32AM -0800, Yi Liu wrote: > This adds ioctl for userspace to bind device cdev fd to iommufd. > > VFIO_DEVICE_BIND_IOMMUFD: bind device to an iommufd, hence gain DMA > control provided by the iommufd. open_device >

Re: [Intel-gfx] [PATCH v5 15/19] vfio: Add cdev for vfio_device

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:31AM -0800, Yi Liu wrote: > @@ -309,6 +310,13 @@ void vfio_unregister_group_dev(struct vfio_device > *device) > bool interrupted = false; > long rc; > > + /* > + * Balances vfio_device_add in register path. Putting it as the > + * first ope

Re: [Intel-gfx] [PATCH v5 15/19] vfio: Add cdev for vfio_device

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:31AM -0800, Yi Liu wrote: > diff --git a/drivers/vfio/Kconfig b/drivers/vfio/Kconfig > index a8f544629467..169762316513 100644 > --- a/drivers/vfio/Kconfig > +++ b/drivers/vfio/Kconfig > @@ -12,6 +12,18 @@ menuconfig VFIO > If you don't know what to do here, sa

Re: [Intel-gfx] [PATCH v5 14/19] vfio: Make vfio_device_open() single open for device cdev path

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:30AM -0800, Yi Liu wrote: > @@ -535,7 +542,8 @@ static int vfio_device_fops_release(struct inode *inode, > struct file *filep) > struct vfio_device_file *df = filep->private_data; > struct vfio_device *device = df->device; > > - vfio_device_group_clo

Re: [Intel-gfx] [PATCH v5 08/19] vfio/pci: Update comment around group_fd get in vfio_pci_ioctl_pci_hot_reset()

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:24AM -0800, Yi Liu wrote: > this suits more on what the code does. > > Signed-off-by: Yi Liu > Reviewed-by: Kevin Tian > --- > drivers/vfio/pci/vfio_pci_core.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Jason Gunthorpe Jason

Re: [Intel-gfx] [PATCH v5 07/19] vfio: Block device access via device fd until device is opened

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:23AM -0800, Yi Liu wrote: > Allow the vfio_device file to be in a state where the device FD is > opened but the device cannot be used by userspace (i.e. its .open_device() > hasn't been called). This inbetween state is not used when the device > FD is spawned from the

Re: [Intel-gfx] [PATCH v5 06/19] vfio: Pass struct vfio_device_file * to vfio_device_open/close()

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:22AM -0800, Yi Liu wrote: > This avoids passing too much parameters in multiple functions. > > Signed-off-by: Yi Liu > Reviewed-by: Kevin Tian > --- > drivers/vfio/group.c | 19 +-- > drivers/vfio/vfio.h | 8 > drivers/vfio/vfio_m

Re: [Intel-gfx] [PATCH v5 05/19] kvm/vfio: Accept vfio device file from userspace

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:21AM -0800, Yi Liu wrote: > This defines KVM_DEV_VFIO_FILE* and make alias with KVM_DEV_VFIO_GROUP*. > Old userspace uses KVM_DEV_VFIO_GROUP* works as well. > > Signed-off-by: Yi Liu > --- > Documentation/virt/kvm/devices/vfio.rst | 52 + > i

Re: [Intel-gfx] [PATCH v5 04/19] kvm/vfio: Rename kvm_vfio_group to prepare for accepting vfio device fd

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:20AM -0800, Yi Liu wrote: > Meanwhile, rename related helpers. No functional change is intended. > > Signed-off-by: Yi Liu > Reviewed-by: Kevin Tian > Reviewed-by: Eric Auger > --- > virt/kvm/vfio.c | 115 > 1 file

Re: [Intel-gfx] [PATCH v5 03/19] vfio: Accept vfio device file in the KVM facing kAPI

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:19AM -0800, Yi Liu wrote: > This makes the vfio file kAPIs to accepte vfio device files, also a > preparation for vfio device cdev support. > > For the kvm set with vfio device file, kvm pointer is stored in struct > vfio_device_file, and use kvm_ref_lock to protect k

Re: [Intel-gfx] [PATCH v5 02/19] vfio: Refine vfio file kAPIs for KVM

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:18AM -0800, Yi Liu wrote: > This prepares for making the below kAPIs to accept both group file > and device file instead of only vfio group file. > > bool vfio_file_enforced_coherent(struct file *file); > void vfio_file_set_kvm(struct file *file, struct kvm *kvm);

Re: [Intel-gfx] [PATCH v5 01/19] vfio: Allocate per device file structure

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:17AM -0800, Yi Liu wrote: > This is preparation for adding vfio device cdev support. vfio device > cdev requires: > 1) a per device file memory to store the kvm pointer set by KVM. It will >be propagated to vfio_device:kvm after the device cdev file is bound >t

Re: [Intel-gfx] [PATCH v5 12/19] vfio-iommufd: Add detach_ioas for emulated VFIO devices

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:28AM -0800, Yi Liu wrote: > diff --git a/drivers/vfio/iommufd.c b/drivers/vfio/iommufd.c > index bfaa9876499b..faf2516b0f06 100644 > --- a/drivers/vfio/iommufd.c > +++ b/drivers/vfio/iommufd.c > @@ -165,6 +165,12 @@ int vfio_iommufd_emulated_attach_ioas(struct vfio_dev

Re: [Intel-gfx] [PATCH v5 11/19] vfio-iommufd: Add detach_ioas support for physical VFIO devices

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:27AM -0800, Yi Liu wrote: > diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc.c > b/drivers/vfio/fsl-mc/vfio_fsl_mc.c > index c89a047a4cd8..d540cf683d93 100644 > --- a/drivers/vfio/fsl-mc/vfio_fsl_mc.c > +++ b/drivers/vfio/fsl-mc/vfio_fsl_mc.c > @@ -594,6 +594,7 @@ static

Re: [Intel-gfx] [PATCH v5 17/19] vfio: Add VFIO_DEVICE_AT[DE]TACH_IOMMUFD_PT

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:33AM -0800, Yi Liu wrote: > This adds ioctl for userspace to attach device cdev fd to and detach > from IOAS/hw_pagetable managed by iommufd. > > VFIO_DEVICE_ATTACH_IOMMUFD_PT: attach vfio device to IOAS, hw_pagetable > managed by

Re: [Intel-gfx] [PATCH v5 10/19] vfio: Add infrastructure for bind_iommufd from userspace

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:26AM -0800, Yi Liu wrote: > For the device fd opened from cdev, userspace needs to bind it to an > iommufd and attach it to IOAS managed by iommufd. With such operations, > userspace can set up a secure DMA context and hence access device. > > This changes the existin

Re: [Intel-gfx] [PATCH v5 09/19] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:25AM -0800, Yi Liu wrote: > to indicate kernel to use the device's bound iommufd_ctx for the device > ownership check. Kernel should loop all the opened devices in the dev_set, > and check if they are bound to the same iommufd_ctx. For the devices that > has not been o

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v5,1/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live

2023-02-27 Thread Patchwork
== Series Details == Series: series starting with [v5,1/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live URL : https://patchwork.freedesktop.org/series/114432/ State : success == Summary == CI Bug Log - changes from CI_DRM_12787 -> Patchwork_114432v1 ===

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Communicate display power demands to pcode more accurately (rev2)

2023-02-27 Thread Patchwork
== Series Details == Series: drm/i915/display: Communicate display power demands to pcode more accurately (rev2) URL : https://patchwork.freedesktop.org/series/114401/ State : success == Summary == CI Bug Log - changes from CI_DRM_12779_full -> Patchwork_114401v2_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v5,1/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live

2023-02-27 Thread Patchwork
== Series Details == Series: series starting with [v5,1/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live URL : https://patchwork.freedesktop.org/series/114432/ State : warning == Summary == Error: dim checkpatch failed 8e94821ec3ff drm/i915: Migrate platform-dependent m

Re: [Intel-gfx] [RFC PATCH 1/2] drm/msm/dpu: add dsc helper functions

2023-02-27 Thread Abhinav Kumar
On 2/27/2023 4:45 AM, Dmitry Baryshkov wrote: On Mon, 27 Feb 2023 at 01:49, Abhinav Kumar wrote: On 2/26/2023 5:09 AM, Dmitry Baryshkov wrote: On 26/02/2023 02:47, Abhinav Kumar wrote: Hi Dmitry On 2/25/2023 7:23 AM, Dmitry Baryshkov wrote: On 25/02/2023 02:36, Abhinav Kumar wrote:

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/dmc: allocate dmc structure dynamically

2023-02-27 Thread Jani Nikula
On Fri, 17 Feb 2023, Imre Deak wrote: > On Fri, Feb 17, 2023 at 12:04:14PM +0200, Jani Nikula wrote: >> On Thu, 16 Feb 2023, Imre Deak wrote: >> > On Thu, Feb 16, 2023 at 06:17:39PM +0200, Jani Nikula wrote: >> >> sizeof(struct intel_dmc) > 1024 bytes, allocated on all platforms as >> >> part of

[Intel-gfx] [PATCH v3 4/4] drm/i915/dmc: allocate dmc structure dynamically

2023-02-27 Thread Jani Nikula
sizeof(struct intel_dmc) > 1024 bytes, allocated on all platforms as part of struct drm_i915_private, whether they have DMC or not. Allocate struct intel_dmc dynamically, and hide all the dmc details behind an opaque pointer in intel_dmc.c. Care must be taken to take into account all cases: DMC n

[Intel-gfx] [PATCH v3 3/4] drm/i915/dmc: add i915_to_dmc() and dmc->i915 and use them

2023-02-27 Thread Jani Nikula
Start preparing for dynamically allocated struct intel_dmc by adding i915_to_dmc() and dmc->i915, and using them. Take the future NULL dmc pointer into account already now, and add separate logging for initialization in the DMC debugfs. v2: - Don't reduce debugfs output (Imre) Cc: Imre Deak Sign

[Intel-gfx] [PATCH v3 2/4] drm/i915/dmc: use has_dmc_id_fw() instead of poking dmc->dmc_info directly

2023-02-27 Thread Jani Nikula
This will help in follow-up changes. Cc: Imre Deak Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c index ab4fdedd4

[Intel-gfx] [PATCH v5 2/2] drm/i915: Use correct huge page manager for MTL

2023-02-27 Thread Jonathan Cavitt
MTL currently uses gen8_ppgtt_insert_huge when managing huge pages. This is because MTL reports as not supporting 64K pages, or more accurately, the system that reports whether a platform has 64K pages reports false for MTL. This is only half correct, as the 64K page support reporting system o

[Intel-gfx] [PATCH v5 1/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live

2023-02-27 Thread Jonathan Cavitt
Convert the igt_mock_ppgtt_huge_fill and igt_mock_ppgtt_64K mock selftests into live selftests as their requirements have recently become platform-dependent. Additionally, apply necessary platform dependency checks to these tests. v2: Reorder Signed-off-by: Jonathan Cavitt --- .../gpu/drm/i915/

[Intel-gfx] [PATCH v3 1/4] drm/i915/power: move dc state members to struct i915_power_domains

2023-02-27 Thread Jani Nikula
There's only one reference to the struct intel_dmc members dc_state, target_dc_state, and allowed_dc_mask within intel_dmc.c, begging the question why they are under struct intel_dmc to begin with. Moreover, the only references to i915->display.dmc outside of intel_dmc.c are to these members. The

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live

2023-02-27 Thread Matthew Auld
On 27/02/2023 16:21, Jonathan Cavitt wrote: Convert the igt_mock_ppgtt_huge_fill and igt_mock_ppgtt_64K mock selftests into live selftests as their requirements have recently become platform-dependent. Additionally, apply necessary platform dependency checks to these tests. Signed-off-by: Jonath

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gen12: Update combo PHY init sequence (rev2)

2023-02-27 Thread Matt Roper
On Tue, Feb 21, 2023 at 11:26:58PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/gen12: Update combo PHY init sequence (rev2) > URL : https://patchwork.freedesktop.org/series/114233/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_12768_full -> Pa

Re: [Intel-gfx] [PATCH v2] drm/i915/gen12: Update combo PHY init sequence

2023-02-27 Thread Matt Atwood
On Tue, Feb 21, 2023 at 12:18:36PM -0800, Matt Roper wrote: > The bspec was updated with a minor change to the 'DCC mode select' > setting to be programmed during combo PHY initialization. > > v2: > - Keep the opencoded rmw behavior instead of switching to >intel_de_rmw(). We need to read fr

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,1/2] drm/i915: Use correct huge page manager for MTL

2023-02-27 Thread Patchwork
== Series Details == Series: series starting with [v4,1/2] drm/i915: Use correct huge page manager for MTL URL : https://patchwork.freedesktop.org/series/114428/ State : success == Summary == CI Bug Log - changes from CI_DRM_12786 -> Patchwork_114428v1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v4,1/2] drm/i915: Use correct huge page manager for MTL

2023-02-27 Thread Patchwork
== Series Details == Series: series starting with [v4,1/2] drm/i915: Use correct huge page manager for MTL URL : https://patchwork.freedesktop.org/series/114428/ State : warning == Summary == Error: dim checkpatch failed 39e49179dfa7 drm/i915: Use correct huge page manager for MTL -:6: WARNIN

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid: Fix csync detailed mode parsing

2023-02-27 Thread Patchwork
== Series Details == Series: drm/edid: Fix csync detailed mode parsing URL : https://patchwork.freedesktop.org/series/114424/ State : success == Summary == CI Bug Log - changes from CI_DRM_12786 -> Patchwork_114424v1 Summary --- **SU

[Intel-gfx] [PATCH v4 2/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live

2023-02-27 Thread Jonathan Cavitt
Convert the igt_mock_ppgtt_huge_fill and igt_mock_ppgtt_64K mock selftests into live selftests as their requirements have recently become platform-dependent. Additionally, apply necessary platform dependency checks to these tests. Signed-off-by: Jonathan Cavitt --- .../gpu/drm/i915/gem/selftests

[Intel-gfx] [PATCH v4 1/2] drm/i915: Use correct huge page manager for MTL

2023-02-27 Thread Jonathan Cavitt
MTL currently uses gen8_ppgtt_insert_huge when managing huge pages. This is because MTL reports as not supporting 64K pages, or more accurately, the system that reports whether a platform has 64K pages reports false for MTL. This is only half correct, as the 64K page support reporting system o

  1   2   >