Re: [Intel-gfx] [PATCH v3 00/15] Add vfio_device cdev for iommufd support

2023-02-14 Thread Liu, Yi L
> From: Alex Williamson > Sent: Tuesday, February 14, 2023 11:47 PM > > On Tue, 14 Feb 2023 01:55:17 + > "Liu, Yi L" wrote: > > > > From: Alex Williamson > > > Sent: Tuesday, February 14, 2023 3:47 AM > > > > > > On Mon, 13 Feb 2023 07:13:33 -0800 > > > Yi Liu wrote: > > > > > > > Existin

Re: [Intel-gfx] [PATCH v3 05/15] kvm/vfio: Accept vfio device file from userspace

2023-02-14 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Wednesday, February 15, 2023 7:25 AM > > On Tue, Feb 14, 2023 at 03:26:27PM -0700, Alex Williamson wrote: > > > index 857d6ba349e1..d869913baafd 100644 > > > --- a/virt/kvm/vfio.c > > > +++ b/virt/kvm/vfio.c > > > @@ -286,18 +286,18 @@ static int kvm_vfio_set_file(

Re: [Intel-gfx] [PATCH v3 14/15] vfio: Add ioctls for device cdev using iommufd

2023-02-14 Thread Liu, Yi L
> From: Tian, Kevin > Sent: Wednesday, February 15, 2023 10:05 AM > > > From: Zhao, Yan Y > > Sent: Wednesday, February 15, 2023 7:39 AM > > > > On Mon, Feb 13, 2023 at 07:13:47AM -0800, Yi Liu wrote: > > ... > > > +long vfio_device_ioctl_bind_iommufd(struct vfio_device_file *df, > > > +

Re: [Intel-gfx] [PATCH 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page()

2023-02-14 Thread Zhao Liu
On Tue, Feb 14, 2023 at 08:25:08PM -0800, Ira Weiny wrote: > Date: Tue, 14 Feb 2023 20:25:08 -0800 > From: Ira Weiny > Subject: Re: [PATCH 0/9] drm/i915: Replace kmap_atomic() with > kmap_local_page() > > Zhao Liu wrote: > > From: Zhao Liu > > > > The use of kmap_atomic() is being deprecated i

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: move a Kconfig symbol to unbreak the menu presentation

2023-02-14 Thread Patchwork
== Series Details == Series: drm/i915: move a Kconfig symbol to unbreak the menu presentation URL : https://patchwork.freedesktop.org/series/114037/ State : success == Summary == CI Bug Log - changes from CI_DRM_12741 -> Patchwork_114037v1

Re: [Intel-gfx] [PATCH v3 07/15] vfio: Block device access via device fd until device is opened

2023-02-14 Thread Liu, Yi L
> From: Alex Williamson > Sent: Wednesday, February 15, 2023 6:47 AM > > On Mon, 13 Feb 2023 07:13:40 -0800 > Yi Liu wrote: > > > Allow the vfio_device file to be in a state where the device FD is > > opened but the device cannot be used by userspace (i.e. > its .open_device() > > hasn't been c

Re: [Intel-gfx] [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation

2023-02-14 Thread Christoph Hellwig
On Tue, Feb 14, 2023 at 08:45:33PM -0800, Randy Dunlap wrote: > Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT) > into a list of other symbols that do have a dependency (on DRM_I915) > breaks the driver menu presentation in 'make *config'. > > Relocate the DRM_I915_GVT sy

Re: [Intel-gfx] [PATCH 13/19] arch/riscv: rename internal name __xchg to __arch_xchg

2023-02-14 Thread Palmer Dabbelt
On Thu, 22 Dec 2022 03:46:29 PST (-0800), andrzej.ha...@intel.com wrote: __xchg will be used for non-atomic xchg macro. Signed-off-by: Andrzej Hajda --- arch/riscv/include/asm/atomic.h | 2 +- arch/riscv/include/asm/cmpxchg.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --

[Intel-gfx] [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation

2023-02-14 Thread Randy Dunlap
Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT) into a list of other symbols that do have a dependency (on DRM_I915) breaks the driver menu presentation in 'make *config'. Relocate the DRM_I915_GVT symbol so that it does not cause this problem. Fixes: 8b750bf74418 ("drm/

Re: [Intel-gfx] [PATCH 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page()

2023-02-14 Thread Ira Weiny
Zhao Liu wrote: > From: Zhao Liu > > The use of kmap_atomic() is being deprecated in favor of > kmap_local_page()[1]. Zhao, Was there ever a v2 of this series? I'm not finding it on Lore. Thanks, Ira > > In the following patches, we can convert the calls of kmap_atomic() / > kunmap_atomic()

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable YCbCr420 for VDSC (rev4)

2023-02-14 Thread Patchwork
== Series Details == Series: Enable YCbCr420 for VDSC (rev4) URL : https://patchwork.freedesktop.org/series/113729/ State : success == Summary == CI Bug Log - changes from CI_DRM_12739 -> Patchwork_113729v4 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable YCbCr420 for VDSC (rev4)

2023-02-14 Thread Patchwork
== Series Details == Series: Enable YCbCr420 for VDSC (rev4) URL : https://patchwork.freedesktop.org/series/113729/ State : warning == Summary == Error: dim checkpatch failed 6cdd40baf8cf drm/dp_helper: Add helper to check if the sink supports given format with DSC 04c83ea19cea drm/i915/dp: C

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dg2: Fix platforms without display (rev2)

2023-02-14 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Fix platforms without display (rev2) URL : https://patchwork.freedesktop.org/series/113782/ State : success == Summary == CI Bug Log - changes from CI_DRM_12738_full -> Patchwork_113782v2_full Summ

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: Make backlight setup debugs consistent

2023-02-14 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Make backlight setup debugs consistent URL : https://patchwork.freedesktop.org/series/114012/ State : success == Summary == CI Bug Log - changes from CI_DRM_12738_full -> Patchwork_114012v1_full

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: Don't switch to TPS1 when disabling DP_TP_CTL

2023-02-14 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Don't switch to TPS1 when disabling DP_TP_CTL URL : https://patchwork.freedesktop.org/series/114011/ State : success == Summary == CI Bug Log - changes from CI_DRM_12738_full -> Patchwork_114011v1_full =

[Intel-gfx] [PATCH v10 5/7] drm/i915: Fill in native_420 field

2023-02-14 Thread Suraj Kandpal
Now that we have laid the groundwork for YUV420 Enablement we fill up native_420 field in vdsc_cfg and add appropriate checks wherever required. ---v2 -adding native_422 field as 0 [Vandita] -filling in second_line_bpg_offset, second_line_offset_adj and nsl_bpg_offset in vds_cfg when native_420 is

[Intel-gfx] ✓ Fi.CI.IGT: success for Enable YCbCr420 for VDSC (rev3)

2023-02-14 Thread Patchwork
== Series Details == Series: Enable YCbCr420 for VDSC (rev3) URL : https://patchwork.freedesktop.org/series/113729/ State : success == Summary == CI Bug Log - changes from CI_DRM_12738_full -> Patchwork_113729v3_full Summary --- **SU

Re: [Intel-gfx] [PATCH 3/3] drm/i915/hwmon: Expose power1_max_enable

2023-02-14 Thread Dixit, Ashutosh
On Mon, 13 Feb 2023 22:16:44 -0800, Guenter Roeck wrote: > Hi Guenter, > On 2/13/23 21:33, Ashutosh Dixit wrote: > > On ATSM the PL1 power limit is disabled at power up. The previous uapi > > assumed that the PL1 limit is always enabled and therefore did not have a > > notion of a disabled PL1 li

Re: [Intel-gfx] [PATCH v9 5/7] drm/i915: Fill in native_420 field

2023-02-14 Thread Kandpal, Suraj
> On Tue, 07 Feb 2023, Suraj Kandpal wrote: > > Now that we have laid the groundwork for YUV420 Enablement we fill up > > native_420 field in vdsc_cfg and add appropriate checks wherever > > required. > > > > ---v2 > > -adding native_422 field as 0 [Vandita] -filling in > > second_line_bpg_offset,

[Intel-gfx] ✗ Fi.CI.BAT: failure for Add OAM support for MTL

2023-02-14 Thread Patchwork
== Series Details == Series: Add OAM support for MTL URL : https://patchwork.freedesktop.org/series/114033/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12739 -> Patchwork_114033v1 Summary --- **FAILURE** Serious

Re: [Intel-gfx] [PATCH v3 14/15] vfio: Add ioctls for device cdev using iommufd

2023-02-14 Thread Tian, Kevin
> From: Zhao, Yan Y > Sent: Wednesday, February 15, 2023 7:39 AM > > On Mon, Feb 13, 2023 at 07:13:47AM -0800, Yi Liu wrote: > ... > > +long vfio_device_ioctl_bind_iommufd(struct vfio_device_file *df, > > + unsigned long arg) > > +{ > > + struct vfio_device *device

Re: [Intel-gfx] [PATCH] drm/i915: Don't use stolen memory for ring buffers

2023-02-14 Thread Ceraolo Spurio, Daniele
On 2/14/2023 3:48 PM, john.c.harri...@intel.com wrote: From: John Harrison Direction from hardware is that stolen memory should never be used for ring buffer allocations. There are too many caching pitfalls due to the way stolen memory accesses are routed. So it is safest to just not use it.

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add OAM support for MTL

2023-02-14 Thread Patchwork
== Series Details == Series: Add OAM support for MTL URL : https://patchwork.freedesktop.org/series/114033/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH 9/9] drm/i915/perf: Add support for OA media units

2023-02-14 Thread Umesh Nerlige Ramappa
MTL introduces additional OA units dedicated to media use cases. Add support for programming these OA units. UMD specific changes for GPUvis support: https://patchwork.freedesktop.org/patch/522827/?series=114023 https://patchwork.freedesktop.org/patch/522822/?series=114023 https://patchwork.freede

[Intel-gfx] [PATCH 2/9] drm/i915/perf: Add helper to check supported OA engines

2023-02-14 Thread Umesh Nerlige Ramappa
Add helper to check for supported OA engines. Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_perf.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c index 393a0da8b7c8.

[Intel-gfx] [PATCH 8/9] drm/i915/perf: Add engine class instance parameters to perf

2023-02-14 Thread Umesh Nerlige Ramappa
Current implementation of perf defaults to render to and configures the default OAG unit. Since there are more OA units on newer hardware, allow user to pass engine class and instance to program specific OA units. UMD specific changes for GPUvis support: https://patchwork.freedesktop.org/patch/522

[Intel-gfx] [PATCH 7/9] drm/i915/perf: Handle non-power-of-2 reports

2023-02-14 Thread Umesh Nerlige Ramappa
Some of the newer OA formats are not powers of 2. For those formats, hw_tail is adjusted accordingly when checking for new reports. Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_perf.c | 50 ++-- 1 file changed, 28 insertions(+), 22 deletions(-)

[Intel-gfx] [PATCH 6/9] drm/i915/perf: Parse 64bit report header formats correctly

2023-02-14 Thread Umesh Nerlige Ramappa
Now that OA formats come in flavor of 64 bit reports, the report header has 64 bit report-id, timestamp, context-id and gpu-ticks fields. When filtering these reports, use the right width for these fields. Note that upper dword of context id is reserved, so squash lower dword only. Signed-off-by:

[Intel-gfx] [PATCH 0/9] Add OAM support for MTL

2023-02-14 Thread Umesh Nerlige Ramappa
The OAM unit captures OA reports specific to the media engines. Add support to program the OAM unit on media tile on MTL. The OAM unit is selected by passing the class:instance of a media engine to perf parameters. Corresponding UMD changes are posted to the igt-dev repo as part of supporting the

[Intel-gfx] [PATCH 5/9] drm/i915/perf: Group engines into respective OA groups

2023-02-14 Thread Umesh Nerlige Ramappa
Now that we may have multiple OA units in a single GT as well as on separate GTs, create an engine group that maps to a single OA unit. Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/gt/intel_engine_types.h | 4 + drivers/gpu/drm/i915/gt/intel_sseu.c | 3 +- drivers/gp

[Intel-gfx] [PATCH 3/9] drm/i915/perf: Validate OA sseu config outside switch

2023-02-14 Thread Umesh Nerlige Ramappa
Validate the OA sseu config after all params are parsed. Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_perf.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c inde

[Intel-gfx] [PATCH 4/9] drm/i915/perf: Fail modprobe if i915_perf_init fails

2023-02-14 Thread Umesh Nerlige Ramappa
Check for return value from i915_perf_init and fail driver init if perf init fails. Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_driver.c | 4 +++- drivers/gpu/drm/i915/i915_perf.c | 4 +++- drivers/gpu/drm/i915/i915_perf.h | 2 +- 3 files changed, 7 insertions(+), 3 de

[Intel-gfx] [PATCH 1/9] drm/i915/perf: Drop wakeref on GuC RC error

2023-02-14 Thread Umesh Nerlige Ramappa
From: Chris Wilson If we fail to adjust the GuC run-control on opening the perf stream, make sure we unwind the wakeref just taken. Fixes: 01e742746785 ("drm/i915/guc: Support OA when Wa_16011777198 is enabled") Signed-off-by: Chris Wilson Cc: Vinay Belgaumkar Cc: Ashutosh Dixit --- drivers/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Don't use stolen memory for ring buffers

2023-02-14 Thread Patchwork
== Series Details == Series: drm/i915: Don't use stolen memory for ring buffers URL : https://patchwork.freedesktop.org/series/114030/ State : success == Summary == CI Bug Log - changes from CI_DRM_12739 -> Patchwork_114030v1 Summary --

Re: [Intel-gfx] [PATCH v3 05/15] kvm/vfio: Accept vfio device file from userspace

2023-02-14 Thread Jason Gunthorpe
On Tue, Feb 14, 2023 at 04:42:35PM -0700, Alex Williamson wrote: > A device file opened through a group could be passed through this > interface though, right? Yes, I think so > Do we just chalk that up to user error? Maybe the SPAPR extension > at least needs to be documented as relying on reg

Re: [Intel-gfx] [PATCH v3 14/15] vfio: Add ioctls for device cdev using iommufd

2023-02-14 Thread Yan Zhao
On Mon, Feb 13, 2023 at 07:13:47AM -0800, Yi Liu wrote: ... > +long vfio_device_ioctl_bind_iommufd(struct vfio_device_file *df, > + unsigned long arg) > +{ > + struct vfio_device *device = df->device; > + struct vfio_device_bind_iommufd bind; > + struct i

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Use encoder->devdata more

2023-02-14 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Use encoder->devdata more URL : https://patchwork.freedesktop.org/series/114029/ State : success == Summary == CI Bug Log - changes from CI_DRM_12739 -> Patchwork_114029v1 Su

[Intel-gfx] [PATCH] drm/i915: Don't use stolen memory for ring buffers

2023-02-14 Thread John . C . Harrison
From: John Harrison Direction from hardware is that stolen memory should never be used for ring buffer allocations. There are too many caching pitfalls due to the way stolen memory accesses are routed. So it is safest to just not use it. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt

Re: [Intel-gfx] [PATCH v3 05/15] kvm/vfio: Accept vfio device file from userspace

2023-02-14 Thread Alex Williamson
On Tue, 14 Feb 2023 19:25:19 -0400 Jason Gunthorpe wrote: > On Tue, Feb 14, 2023 at 03:26:27PM -0700, Alex Williamson wrote: > > > index 857d6ba349e1..d869913baafd 100644 > > > --- a/virt/kvm/vfio.c > > > +++ b/virt/kvm/vfio.c > > > @@ -286,18 +286,18 @@ static int kvm_vfio_set_file(struct kvm_de

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pxp: Add MTL PXP Support (rev5)

2023-02-14 Thread Patchwork
== Series Details == Series: drm/i915/pxp: Add MTL PXP Support (rev5) URL : https://patchwork.freedesktop.org/series/112647/ State : success == Summary == CI Bug Log - changes from CI_DRM_12739 -> Patchwork_112647v5 Summary --- **WAR

Re: [Intel-gfx] [PATCH v3 05/15] kvm/vfio: Accept vfio device file from userspace

2023-02-14 Thread Jason Gunthorpe
On Tue, Feb 14, 2023 at 03:26:27PM -0700, Alex Williamson wrote: > > index 857d6ba349e1..d869913baafd 100644 > > --- a/virt/kvm/vfio.c > > +++ b/virt/kvm/vfio.c > > @@ -286,18 +286,18 @@ static int kvm_vfio_set_file(struct kvm_device *dev, > > long attr, > > int32_t fd; > > > > switch (a

[Intel-gfx] [PATCH 2/3] drm/i915: Sanitize child devices later

2023-02-14 Thread Ville Syrjala
From: Ville Syrjälä Currently we sanitize the child device aux_ch/ddc_pin while parsing the ports from VBT. But that won't work when we have duplicate child devices for the same port. Instead let's sanitize just before initializing the encoder, based on which resources were consumed by encoders

[Intel-gfx] [PATCH 3/3] drm/i915: Try to initialize DDI ports for every VBT child device

2023-02-14 Thread Ville Syrjala
From: Ville Syrjälä Try to deal with duplicate child devices for the same DDI port by attempting to initialize each in turn. The first on to succeed will be the one we use. TODO: Still very rough. Should probably just initialize DDIs strictly in child device order, and just filter out the

[Intel-gfx] [PATCH 1/3] drm/i915: Use encoder->devdata more

2023-02-14 Thread Ville Syrjala
From: Ville Syrjälä Switch a lot of the intel_bios_foo() stuff to just accept the devdata (VBT child device info) directly, instead of taking detours via vbt.ports[]. Also unify the function naming scheme. TODO: is intel_bios_encoder_{dp,hdmi}_ too much? Or should we shorten to just intel_bios_

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pxp: Add MTL PXP Support (rev5)

2023-02-14 Thread Patchwork
== Series Details == Series: drm/i915/pxp: Add MTL PXP Support (rev5) URL : https://patchwork.freedesktop.org/series/112647/ State : warning == Summary == Error: dim checkpatch failed 4a495413a6d8 drm/i915/pxp: Add GSC-CS back-end resource init and cleanup Traceback (most recent call last):

Re: [Intel-gfx] [PATCH v3 07/15] vfio: Block device access via device fd until device is opened

2023-02-14 Thread Alex Williamson
On Mon, 13 Feb 2023 07:13:40 -0800 Yi Liu wrote: > Allow the vfio_device file to be in a state where the device FD is > opened but the device cannot be used by userspace (i.e. its .open_device() > hasn't been called). This inbetween state is not used when the device > FD is spawned from the group

Re: [Intel-gfx] [PATCH i-g-t v3 1/1] tests: Exercise remote request vs barrier handling race

2023-02-14 Thread Janusz Krzysztofik
Hi Kamil, Thanks for review. On Tuesday, 14 February 2023 22:20:10 CET Kamil Konieczny wrote: > Hi Janusz, > > On 2023-02-13 at 10:31:32 +0100, Janusz Krzysztofik wrote: > > Users reported oopses on list corruptions when using i915 perf with a > > number of concurrently running graphics applicat

Re: [Intel-gfx] [PATCH v3 05/15] kvm/vfio: Accept vfio device file from userspace

2023-02-14 Thread Alex Williamson
On Mon, 13 Feb 2023 07:13:38 -0800 Yi Liu wrote: > This defines KVM_DEV_VFIO_FILE* and make alias with KVM_DEV_VFIO_GROUP*. > Old userspace uses KVM_DEV_VFIO_GROUP* works as well. > > Signed-off-by: Yi Liu > --- > Documentation/virt/kvm/devices/vfio.rst | 45 - > includ

[Intel-gfx] [PATCH v5 8/8] drm/i915/pxp: Enable PXP with MTL-GSC-CS

2023-02-14 Thread Alan Previn
Enable PXP with MTL-GSC-CS: add the has_pxp into device info and increase the timeouts for new GSC-CS + firmware specs. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/i915_pci.c | 1 + drivers/gpu/drm/i915/pxp/intel_pxp_session.c | 2 +- 2 files changed, 2 insertions(+), 1 dele

[Intel-gfx] [PATCH v5 3/8] drm/i915/pxp: Add MTL helpers to submit Heci-Cmd-Packet to GSC

2023-02-14 Thread Alan Previn
Add helper functions into a new file for heci-packet-submission. The helpers will handle generating the MTL GSC-CS Memory-Header and submission of the Heci-Cmd-Packet instructions to the engine. NOTE1: These common functions for heci-packet-submission will be used by different i915 callers: 1

[Intel-gfx] [PATCH v5 7/8] drm/i915/pxp: On MTL, KCR enabling doesn't wait on tee component

2023-02-14 Thread Alan Previn
On legacy platforms, KCR HW enabling is done at the time the mei component interface is bound. It's also disabled during unbind. However, for MTL onwards, we don't depend on a tee component to start sending GSC-CS firmware messages. Thus, immediately enable (or disable) KCR HW on PXP's init, fini

[Intel-gfx] [PATCH v5 5/8] drm/i915/pxp: Add ARB session creation and cleanup

2023-02-14 Thread Alan Previn
Add MTL's function for ARB session creation using PXP firmware version 4.3 ABI structure format. Also add MTL's function for ARB session invalidation but this reuses PXP firmware version 4.2 ABI structure format. Before checking the return status, look at the GSC-CS-Mem-Header's pending-bit which

[Intel-gfx] [PATCH v5 6/8] drm/i915/pxp: MTL-KCR interrupt ctrl's are in GT-0

2023-02-14 Thread Alan Previn
Despite KCR subsystem being in the media-tile (close to the GSC-CS), the IRQ controls for it are on GT-0 with other global IRQ controls. Thus, add a helper for KCR hw interrupt enable/disable functions to get the correct gt structure (for uncore) for MTL. In the helper, we get GT-0's handle for un

[Intel-gfx] [PATCH v5 4/8] drm/i915/pxp: Add GSC-CS backend to send GSC fw messages

2023-02-14 Thread Alan Previn
Add GSC engine based method for sending PXP firmware packets to the GSC firmware for MTL (and future) products. Use the newly added helpers to populate the GSC-CS memory header and send the message packet to the FW by dispatching the GSC_HECI_CMD_PKT instruction on the GSC engine. We use non-priv

[Intel-gfx] [PATCH v5 1/8] drm/i915/pxp: Add GSC-CS back-end resource init and cleanup

2023-02-14 Thread Alan Previn
For MTL, the PXP back-end transport uses the GSC engine to submit HECI packets through the HW to the GSC firmware for PXP arb session management. This submission uses a non-priveleged batch buffer, a buffer for the command packet and of course a context targeting the GSC-CS. Thus for MTL, we need

[Intel-gfx] [PATCH v5 0/8] drm/i915/pxp: Add MTL PXP Support

2023-02-14 Thread Alan Previn
This series enables PXP on MTL. On ADL/TGL platforms, we rely on the mei driver via the i915-mei PXP component interface to establish a connection to the security firmware via the HECI device interface. That interface is used to create and teardown the PXP ARB session. PXP ARB session is created wh

[Intel-gfx] [PATCH v5 2/8] drm/i915/pxp: Add MTL hw-plumbing enabling for KCR operation

2023-02-14 Thread Alan Previn
Add MTL hw-plumbing enabling for KCR operation under PXP which includes: 1. Updating 'pick-gt' to get the media tile for KCR interrupt handling 2. Adding MTL's KCR registers for PXP operation (init, status-checking, etc.). While doing #2, lets create a separate registers header file for PXP

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/xelpmp: Consider GSI offset when doing MCR lookups

2023-02-14 Thread Matt Roper
On Tue, Feb 14, 2023 at 04:35:26AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/xelpmp: Consider GSI offset when doing MCR lookups > URL : https://patchwork.freedesktop.org/series/113978/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_12734_full

Re: [Intel-gfx] [PATCH i-g-t v3 1/1] tests: Exercise remote request vs barrier handling race

2023-02-14 Thread Kamil Konieczny
Hi Janusz, On 2023-02-13 at 10:31:32 +0100, Janusz Krzysztofik wrote: > Users reported oopses on list corruptions when using i915 perf with a > number of concurrently running graphics applications. That indicates we > are currently missing some important tests for such scenarios. Cover > that ga

Re: [Intel-gfx] [PATCH 2/3] drm/i915/hwmon: Enable PL1 limit when writing limit value to HW

2023-02-14 Thread Rodrigo Vivi
On Tue, Feb 14, 2023 at 12:47:23PM -0800, Dixit, Ashutosh wrote: > On Tue, 14 Feb 2023 06:51:37 -0800, Rodrigo Vivi wrote: > > > > Hi Rodrigo, > > > On Mon, Feb 13, 2023 at 01:00:48PM -0800, Ashutosh Dixit wrote: > > > Previous documentation suggested that the PL1 power limit is always > > > ena

Re: [Intel-gfx] [PATCH 2/3] drm/i915/hwmon: Enable PL1 limit when writing limit value to HW

2023-02-14 Thread Dixit, Ashutosh
On Tue, 14 Feb 2023 06:51:37 -0800, Rodrigo Vivi wrote: > Hi Rodrigo, > On Mon, Feb 13, 2023 at 01:00:48PM -0800, Ashutosh Dixit wrote: > > Previous documentation suggested that the PL1 power limit is always enabled > > in HW. However we now find this not to be the case on some platforms (such >

Re: [Intel-gfx] [PATCH 1/3] drm/i915/hwmon: Replace hwm_field_scale_and_write with hwm_power_max_write

2023-02-14 Thread Rodrigo Vivi
On Tue, Feb 14, 2023 at 12:20:36PM -0800, Dixit, Ashutosh wrote: > On Tue, 14 Feb 2023 06:50:44 -0800, Rodrigo Vivi wrote: > > > > > +static int > > > +hwm_power_max_write(struct hwm_drvdata *ddat, long val) > > +{ > > > + struct i915_hwmon *hwmon = ddat->hwmon; > > > + u32 nval; > > > + > > > + /

Re: [Intel-gfx] [PATCH 1/3] drm/i915/hwmon: Replace hwm_field_scale_and_write with hwm_power_max_write

2023-02-14 Thread Dixit, Ashutosh
On Tue, 14 Feb 2023 06:50:44 -0800, Rodrigo Vivi wrote: > > > +static int > > +hwm_power_max_write(struct hwm_drvdata *ddat, long val) > +{ > > + struct i915_hwmon *hwmon = ddat->hwmon; > > + u32 nval; > > + > > + /* Computation in 64-bits to avoid overflow. Round to nearest. */ > > + nval

Re: [Intel-gfx] [PATCH v2 1/2] drm: Introduce plane SIZE_HINTS property

2023-02-14 Thread Ville Syrjälä
On Tue, Feb 14, 2023 at 02:27:19PM -0500, Harry Wentland wrote: > > > On 2/14/23 05:28, Ville Syrjälä wrote: > > On Tue, Feb 14, 2023 at 10:54:27AM +0100, Jonas Ådahl wrote: > >> On Tue, Feb 14, 2023 at 11:25:56AM +0200, Ville Syrjälä wrote: > >>> On Thu, Feb 09, 2023 at 03:16:23PM +0100, Jonas Å

Re: [Intel-gfx] [PATCH v2 1/2] drm: Introduce plane SIZE_HINTS property

2023-02-14 Thread Harry Wentland
On 2/14/23 05:28, Ville Syrjälä wrote: On Tue, Feb 14, 2023 at 10:54:27AM +0100, Jonas Ådahl wrote: On Tue, Feb 14, 2023 at 11:25:56AM +0200, Ville Syrjälä wrote: On Thu, Feb 09, 2023 at 03:16:23PM +0100, Jonas Ådahl wrote: On Wed, Feb 08, 2023 at 11:10:16PM +0200, Ville Syrjala wrote: Fro

Re: [Intel-gfx] [RFC v2 0/5] Waitboost drm syncobj waits

2023-02-14 Thread Rob Clark
On Tue, Feb 14, 2023 at 11:14 AM Rob Clark wrote: > > On Fri, Feb 10, 2023 at 5:07 AM Tvrtko Ursulin > wrote: > > > > From: Tvrtko Ursulin > > > > In i915 we have this concept of "wait boosting" where we give a priority > > boost > > for instance to fences which are actively waited upon from us

Re: [Intel-gfx] [RFC v2 0/5] Waitboost drm syncobj waits

2023-02-14 Thread Rob Clark
On Fri, Feb 10, 2023 at 5:07 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > In i915 we have this concept of "wait boosting" where we give a priority boost > for instance to fences which are actively waited upon from userspace. This has > it's pros and cons and can certainly be discussed at

Re: [Intel-gfx] [PATCH v4 5/8] drm/i915/pxp: Add ARB session creation and cleanup

2023-02-14 Thread Teres Alexis, Alan Previn
On Thu, 2023-02-09 at 16:42 -0800, Teres Alexis, Alan Previn wrote: > Add MTL's function for ARB session creation using PXP firmware > version 4.3 ABI structure format. > > Also add MTL's function for ARB session invalidation but this > reuses PXP firmware version 4.2 ABI structure format. > > Be

[Intel-gfx] [linux-next:master] BUILD REGRESSION 3ebb0ac55efaf1d0fb1b106f852c114e5021f7eb

2023-02-14 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 3ebb0ac55efaf1d0fb1b106f852c114e5021f7eb Add linux-next specific files for 20230214 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202301300743.bp7dpazv-...@intel.com https

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dg2: Fix platforms without display (rev2)

2023-02-14 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Fix platforms without display (rev2) URL : https://patchwork.freedesktop.org/series/113782/ State : success == Summary == CI Bug Log - changes from CI_DRM_12738 -> Patchwork_113782v2 Summary --

Re: [Intel-gfx] [PATCH v3 00/15] Add vfio_device cdev for iommufd support

2023-02-14 Thread Jason Gunthorpe
On Tue, Feb 14, 2023 at 08:54:19AM -0700, Alex Williamson wrote: > On Tue, 14 Feb 2023 15:15:28 + > "Liu, Yi L" wrote: > > > > From: Jason Gunthorpe > > > Sent: Tuesday, February 14, 2023 7:22 AM > > > > > > On Mon, Feb 13, 2023 at 12:47:19PM -0700, Alex Williamson wrote: > > > > > > > I

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dg2: Fix platforms without display (rev2)

2023-02-14 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Fix platforms without display (rev2) URL : https://patchwork.freedesktop.org/series/113782/ State : warning == Summary == Error: dim checkpatch failed 128c12d5b429 drm/i915: Fix system suspend without fbdev being initialized e6eae74760bb drm/i915: Mov

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Make backlight setup debugs consistent

2023-02-14 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Make backlight setup debugs consistent URL : https://patchwork.freedesktop.org/series/114012/ State : success == Summary == CI Bug Log - changes from CI_DRM_12738 -> Patchwork_114012v1 ==

Re: [Intel-gfx] [PATCH v3 00/15] Add vfio_device cdev for iommufd support

2023-02-14 Thread Alex Williamson
On Tue, 14 Feb 2023 15:15:28 + "Liu, Yi L" wrote: > > From: Jason Gunthorpe > > Sent: Tuesday, February 14, 2023 7:22 AM > > > > On Mon, Feb 13, 2023 at 12:47:19PM -0700, Alex Williamson wrote: > > > > > I think it's too late for v6.3 already, but given this needs at least > > > one more

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Don't switch to TPS1 when disabling DP_TP_CTL

2023-02-14 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Don't switch to TPS1 when disabling DP_TP_CTL URL : https://patchwork.freedesktop.org/series/114011/ State : success == Summary == CI Bug Log - changes from CI_DRM_12738 -> Patchwork_114011v1 ===

[Intel-gfx] ✗ Fi.CI.IGT: failure for DP2.0 SDP CRC16 for 128/132b link layer (rev2)

2023-02-14 Thread Patchwork
== Series Details == Series: DP2.0 SDP CRC16 for 128/132b link layer (rev2) URL : https://patchwork.freedesktop.org/series/113134/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12736_full -> Patchwork_113134v2_full Summary

Re: [Intel-gfx] [PATCH v3 00/15] Add vfio_device cdev for iommufd support

2023-02-14 Thread Alex Williamson
On Tue, 14 Feb 2023 01:55:17 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, February 14, 2023 3:47 AM > > > > On Mon, 13 Feb 2023 07:13:33 -0800 > > Yi Liu wrote: > > > > > Existing VFIO provides group-centric user APIs for userspace. Userspace > > > opens the /dev/vf

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915: Don't switch to TPS1 when disabling DP_TP_CTL

2023-02-14 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Don't switch to TPS1 when disabling DP_TP_CTL URL : https://patchwork.freedesktop.org/series/114011/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked sep

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable YCbCr420 for VDSC (rev3)

2023-02-14 Thread Patchwork
== Series Details == Series: Enable YCbCr420 for VDSC (rev3) URL : https://patchwork.freedesktop.org/series/113729/ State : success == Summary == CI Bug Log - changes from CI_DRM_12738 -> Patchwork_113729v3 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH v3 00/15] Add vfio_device cdev for iommufd support

2023-02-14 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Tuesday, February 14, 2023 7:22 AM > > On Mon, Feb 13, 2023 at 12:47:19PM -0700, Alex Williamson wrote: > > > I think it's too late for v6.3 already, but given this needs at least > > one more spin, let's set expectations of this being v6.4 material. Thanks, > >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable YCbCr420 for VDSC (rev3)

2023-02-14 Thread Patchwork
== Series Details == Series: Enable YCbCr420 for VDSC (rev3) URL : https://patchwork.freedesktop.org/series/113729/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 2/3] drm/i915/hwmon: Enable PL1 limit when writing limit value to HW

2023-02-14 Thread Rodrigo Vivi
On Mon, Feb 13, 2023 at 01:00:48PM -0800, Ashutosh Dixit wrote: > Previous documentation suggested that the PL1 power limit is always enabled > in HW. However we now find this not to be the case on some platforms (such > as ATSM). Therefore enable the PL1 power limit (by setting the enable bit) > w

Re: [Intel-gfx] [PATCH 1/3] drm/i915/hwmon: Replace hwm_field_scale_and_write with hwm_power_max_write

2023-02-14 Thread Rodrigo Vivi
On Mon, Feb 13, 2023 at 01:00:47PM -0800, Ashutosh Dixit wrote: > hwm_field_scale_and_write has a single caller hwm_power_write and is > specific to hwm_power_write but makes it appear that it is a general > function which can have multiple callers. Replace the function with > hwm_power_max_write w

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Communicate display configuration to pcode (rev3)

2023-02-14 Thread Patchwork
== Series Details == Series: drm/i915/display: Communicate display configuration to pcode (rev3) URL : https://patchwork.freedesktop.org/series/102678/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12738 -> Patchwork_102678v3 ===

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915: Move display power initialization during driver probing later

2023-02-14 Thread Jani Nikula
On Tue, 14 Feb 2023, Imre Deak wrote: > On Tue, Feb 14, 2023 at 11:25:04AM +0200, Jani Nikula wrote: >> On Wed, 08 Feb 2023, Imre Deak wrote: >> > Determining whether the display engine is present on a platform happens >> > only in intel_device_info_runtime_init(). Initializing the display power

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: Communicate display configuration to pcode (rev3)

2023-02-14 Thread Patchwork
== Series Details == Series: drm/i915/display: Communicate display configuration to pcode (rev3) URL : https://patchwork.freedesktop.org/series/102678/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915: Move display power initialization during driver probing later

2023-02-14 Thread Imre Deak
On Tue, Feb 14, 2023 at 11:25:04AM +0200, Jani Nikula wrote: > On Wed, 08 Feb 2023, Imre Deak wrote: > > Determining whether the display engine is present on a platform happens > > only in intel_device_info_runtime_init(). Initializing the display power > > functionality depends on this condition,

Re: [Intel-gfx] [PATCH] drm/i915/display: Communicate display configuration to pcode

2023-02-14 Thread Ville Syrjälä
On Tue, Feb 14, 2023 at 12:01:32PM +0200, Stanislav Lisovskiy wrote: > From: Jigar Bhatt > > Display to communicate "display configuration" to Pcode for more accurate > power accounting for DG2. Existing sequence is only sending the voltage > value to the Pcode. Adding new sequence with current c

[Intel-gfx] [PATCH 3/3] drm/i915: Clean up g4x+ sprite TILEOFF programming

2023-02-14 Thread Ville Syrjala
From: Ville Syrjälä We defined the bitmasks for DVSTILEOFF but never used them. Remedy that. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sprite.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers

[Intel-gfx] [PATCH 2/3] drm/i915: Don't hide function calls with side effects

2023-02-14 Thread Ville Syrjala
From: Ville Syrjälä Hiding a function call with side effects inside the variable declaration block is a bit rude. Make it stand out more. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_backlight.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/driver

[Intel-gfx] [PATCH 1/3] drm/i915: Make backlight setup debugs consistent

2023-02-14 Thread Ville Syrjala
From: Ville Syrjälä It's confusing to debug backlight issues when one can't easily even tell what kind of backlight control was selected. Sprinkle uniform debug messages to all the backlight setup functions. Also the one that was already there (ext_pwm) was using drm_info() for some reason. I do

[Intel-gfx] [PATCH 3/3] drm/i915: Fix idle pattern enabling

2023-02-14 Thread Ville Syrjala
From: Ville Syrjälä Currently we are always switching to the idle pattern after the link training, but we don't always wait for the minimum number of idle patterns sent. That doesn't look to be what Bspec asks of us. According to bspec what we should do is switch to idle pattern and wait for it

[Intel-gfx] [PATCH 2/3] drm/i915: Don't send idle pattern after DP2.0 link training

2023-02-14 Thread Ville Syrjala
From: Ville Syrjälä Bspec calls us to select pattern 2 after link training for DP 2.0. Let's do that... by doing nothing because we will be transmitting pattern 2 at the end of the link training already. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp_link_training.c | 4

[Intel-gfx] [PATCH 1/3] drm/i915: Don't switch to TPS1 when disabling DP_TP_CTL

2023-02-14 Thread Ville Syrjala
From: Ville Syrjälä AFAICS Bspec has never asked us to switch to TPS1 when *disabling* DP_TP_CTL. Let's stop doing that in case it confuses something. We do have to switch before we *enable* DP_TP_CTL, but that is already being handled correctly. Signed-off-by: Ville Syrjälä --- drivers/gpu/dr

Re: [Intel-gfx] [PATCH] drm/i915/display/selftest: Add pcode selftest

2023-02-14 Thread Jani Nikula
On Tue, 07 Feb 2023, Swati Sharma wrote: > From: Mohammed Khajapasha > > Include pcode selftest for display to validate QGV points read. > Failure of this selftest indicates a bad firmware rather than regular > display issue. > > Cc: Stanislav Lisovskiy > Cc: Matt Roper > Signed-off-by: Mohamme

Re: [Intel-gfx] [PATCH] drm/i915/display: Add a debugfs entry for fifo underruns

2023-02-14 Thread Jani Nikula
On Wed, 08 Feb 2023, Andi Shyti wrote: > Hi Swati, > > [...] > >> +static void intel_fifo_underrun_inc_count(struct intel_crtc *crtc, >> + bool is_cpu_fifo) > > I'm not a big fan of the true/false parameters in functions. I > actually hate them because it's nev

Re: [Intel-gfx] [PATCH] drm/i915/display: Add a debugfs entry for fifo underruns

2023-02-14 Thread Jani Nikula
On Wed, 08 Feb 2023, Swati Sharma wrote: > From: Mohammed Khajapasha > > Add a debugfs entry i915_fifo_underruns to indicate the count of > fifo underruns for each pipe. > > Cc: Stanislav Lisovskiy > Signed-off-by: Mohammed Khajapasha > Signed-off-by: Swati Sharma > --- > .../drm/i915/display

Re: [Intel-gfx] [PATCH v9 5/7] drm/i915: Fill in native_420 field

2023-02-14 Thread Jani Nikula
On Tue, 07 Feb 2023, Suraj Kandpal wrote: > Now that we have laid the groundwork for YUV420 Enablement > we fill up native_420 field in vdsc_cfg and add appropriate > checks wherever required. > > ---v2 > -adding native_422 field as 0 [Vandita] > -filling in second_line_bpg_offset, second_line_off

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915/display: debugfs entry to control ignore long hpd flag

2023-02-14 Thread Jani Nikula
On Tue, 07 Feb 2023, Vinod Govindapillai wrote: > Knob to control ignoring the long hpds. Set this to true will > start ignoring the long HPDs generated by the displays. Useful > for use cases like CI systems where we dont expect to disconnect > the panels. > > v2: Address patch styling comments (

Re: [Intel-gfx] [PATCH 1/2] drm: Introduce plane SIZE_HINTS property

2023-02-14 Thread Ville Syrjälä
On Tue, Feb 14, 2023 at 01:17:45PM +0200, Pekka Paalanen wrote: > On Tue, 14 Feb 2023 12:27:45 +0200 > Ville Syrjälä wrote: > > > On Tue, Feb 14, 2023 at 11:42:27AM +0200, Pekka Paalanen wrote: > > > On Thu, 9 Feb 2023 13:51:05 +0200 > > > Pekka Paalanen wrote: > > > > > > > Maybe we could re

  1   2   >