Re: [Intel-gfx] [PATCH 1/3] drm/i915/guc: Fix missing ecodes

2023-02-03 Thread Teres Alexis, Alan Previn
Reviewed-by: Alan Previn On Thu, 2023-02-02 at 17:10 -0800, Harrison, John C wrote: > From: John Harrison > > Error captures are tagged with an 'ecode'. This is a pseduo-unique magic > number that is meant to distinguish similar seeming bugs with > different underlying signatures. It is a comb

Re: [Intel-gfx] [PATCH 2/3] drm/i915/guc: Clean up of register capture search

2023-02-03 Thread Teres Alexis, Alan Previn
I see you are inferring that a guc-id of zero can be valid. I am guessing that might have contributed to some lost captures? Thanks for catching this. Reviewed-by: Alan Previn On Thu, 2023-02-02 at 17:10 -0800, john.c.harri...@intel.com wrote: > From: John Harrison > > The comparison in the se

Re: [Intel-gfx] [PATCH v4 2/2] vfio: no need to pass kvm pointer during device open

2023-02-03 Thread Liu, Yi L
> From: Matthew Rosato > Sent: Saturday, February 4, 2023 5:50 AM > > Nothing uses this value during vfio_device_open anymore so it's safe > to remove it. > > Signed-off-by: Matthew Rosato > --- > drivers/vfio/group.c | 2 +- > drivers/vfio/vfio.h | 3 +-- > drivers/vfio/vfio_main.c |

Re: [Intel-gfx] [PATCH v4 1/2] vfio: fix deadlock between group lock and kvm lock

2023-02-03 Thread Liu, Yi L
> From: Matthew Rosato > Sent: Saturday, February 4, 2023 5:50 AM > To: alex.william...@redhat.com; pbonz...@redhat.com; Liu, Yi L > > After 51cdc8bc120e, we have another deadlock scenario between the > kvm->lock and the vfio group_lock with two different codepaths acquiring > the locks in differ

[Intel-gfx] [PATCH] drm/i915/pxp: limit drm-errors or warning on firmware API failures

2023-02-03 Thread Alan Previn
MESA driver is creating protected context on every driver handle creation to query caps bits for app. So when running CI tests, they are observing hundreds of drm_errors when enabling PXP in .config but using SOC fusing or BIOS configuration that cannot support PXP sessions. The fixes tag referenc

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/huc: Add and use HuC oriented print macros (rev2)

2023-02-03 Thread Patchwork
== Series Details == Series: drm/i915/huc: Add and use HuC oriented print macros (rev2) URL : https://patchwork.freedesktop.org/series/113542/ State : success == Summary == CI Bug Log - changes from CI_DRM_12688_full -> Patchwork_113542v2_full ==

Re: [Intel-gfx] [PATCH 2/3] drm/scheduler: Fix elapsed_ns kernel-doc error

2023-02-03 Thread Bagas Sanjaya
On 2/3/23 18:27, Lucas Stach wrote: > Thanks, I've added this to the etnaviv tree. > > Since the commit is only in -next and not a non-rebase tree yet, I > might be tempted to squash the fix into the offending commit. What > would be the right way to credit you for the fix in that case? > On SoB

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dgfx: DGFX uses direct VBT pin mapping

2023-02-03 Thread Patchwork
== Series Details == Series: drm/i915/dgfx: DGFX uses direct VBT pin mapping URL : https://patchwork.freedesktop.org/series/113677/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12692 -> Patchwork_113677v1 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/dgfx: DGFX uses direct VBT pin mapping

2023-02-03 Thread Lucas De Marchi
On Fri, Feb 03, 2023 at 03:20:20PM -0800, Clint Taylor wrote: DDC pin mapping for DGFX cards uses direct VBT pin mapping Cc: Lucas De Marchi Cc: Matt Roper Signed-off-by: Clint Taylor Reviewed-by: Lucas De Marchi Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_bios.c | 5 +++-- 1

[Intel-gfx] [PATCH] drm/i915/dgfx: DGFX uses direct VBT pin mapping

2023-02-03 Thread Clint Taylor
DDC pin mapping for DGFX cards uses direct VBT pin mapping Cc: Lucas De Marchi Cc: Matt Roper Signed-off-by: Clint Taylor --- drivers/gpu/drm/i915/display/intel_bios.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix memory leaks in scatterlist (rev2)

2023-02-03 Thread Patchwork
== Series Details == Series: drm/i915: Fix memory leaks in scatterlist (rev2) URL : https://patchwork.freedesktop.org/series/113576/ State : success == Summary == CI Bug Log - changes from CI_DRM_12692 -> Patchwork_113576v2 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for vfio: fix deadlock between group lock and kvm lock (rev8)

2023-02-03 Thread Patchwork
== Series Details == Series: vfio: fix deadlock between group lock and kvm lock (rev8) URL : https://patchwork.freedesktop.org/series/113535/ State : success == Summary == CI Bug Log - changes from CI_DRM_12692 -> Patchwork_113535v8 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for vfio: fix deadlock between group lock and kvm lock (rev8)

2023-02-03 Thread Patchwork
== Series Details == Series: vfio: fix deadlock between group lock and kvm lock (rev8) URL : https://patchwork.freedesktop.org/series/113535/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +./arch/x86/inc

[Intel-gfx] [PATCH v4 2/2] vfio: no need to pass kvm pointer during device open

2023-02-03 Thread Matthew Rosato
Nothing uses this value during vfio_device_open anymore so it's safe to remove it. Signed-off-by: Matthew Rosato --- drivers/vfio/group.c | 2 +- drivers/vfio/vfio.h | 3 +-- drivers/vfio/vfio_main.c | 7 +++ 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/vfi

[Intel-gfx] [PATCH v4 1/2] vfio: fix deadlock between group lock and kvm lock

2023-02-03 Thread Matthew Rosato
After 51cdc8bc120e, we have another deadlock scenario between the kvm->lock and the vfio group_lock with two different codepaths acquiring the locks in different order. Specifically in vfio_open_device, vfio holds the vfio group_lock when issuing device->ops->open_device but some drivers (like vfi

[Intel-gfx] [PATCH v4 0/2] vfio: fix deadlock between group lock and kvm lock

2023-02-03 Thread Matthew Rosato
Hi Alex, Here is the latest group_lock vs kvm lock deadlock fix + a non-fix follow-on to remove the kvm argument from vfio_device_open and vfio_device_first_open. Changes from v3: * Remove device->group->kvm reference in vfio_main by passing the kvm in (Kevin) * Slight re-organization to make i

Re: [Intel-gfx] [PATCH v3] vfio: fix deadlock between group lock and kvm lock

2023-02-03 Thread Alex Williamson
On Fri, 3 Feb 2023 16:19:10 -0500 Matthew Rosato wrote: > > @@ -350,32 +350,25 @@ void vfio_device_get_kvm_safe(struct vfio_device > > *device) > > > > lockdep_assert_held(&device->dev_set->lock); > > > > - spin_lock(&device->group->kvm_ref_lock); > > - if (!device->group->kvm) > > -

Re: [Intel-gfx] [PATCH v3] vfio: fix deadlock between group lock and kvm lock

2023-02-03 Thread Matthew Rosato
On 2/3/23 3:35 PM, Alex Williamson wrote: > On Fri, 3 Feb 2023 12:29:01 -0500 > Matthew Rosato wrote: ... > I'd probably go back to making this: > > void _vfio_device_get_kvm_safe(struct vfio_device *device, struct kvm *kvm); > > so the vfio_main function would handle setting and clearing > de

[Intel-gfx] ✗ Fi.CI.BUILD: failure for vfio: fix deadlock between group lock and kvm lock (rev7)

2023-02-03 Thread Patchwork
== Series Details == Series: vfio: fix deadlock between group lock and kvm lock (rev7) URL : https://patchwork.freedesktop.org/series/113535/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/113535/revisions/7/mbox/ not applied Applying: vfio: fix d

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 0/2] tests/i915/perf: Add stress / race exercises

2023-02-03 Thread Janusz Krzysztofik
Hi Umesh, Thanks for taking a look. On Friday, 3 February 2023 20:21:38 CET Umesh Nerlige Ramappa wrote: > On Tue, Jan 31, 2023 at 10:17:29AM +0100, Janusz Krzysztofik wrote: > >Users reported oopses on list corruptions when using i915 perf with a > >number of concurrently running graphics applic

Re: [Intel-gfx] [PATCH v3] vfio: fix deadlock between group lock and kvm lock

2023-02-03 Thread Alex Williamson
On Fri, 3 Feb 2023 12:29:01 -0500 Matthew Rosato wrote: > On 2/3/23 10:19 AM, Alex Williamson wrote: > > On Fri, 3 Feb 2023 14:54:44 + > > "Liu, Yi L" wrote: > > > >>> From: Alex Williamson > >>> Sent: Friday, February 3, 2023 9:50 PM > >>> > >>> On Fri, 3 Feb 2023 13:32:09 + > >>> "

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Avoid redundant pointer validity check

2023-02-03 Thread Patchwork
== Series Details == Series: drm/i915/gt: Avoid redundant pointer validity check URL : https://patchwork.freedesktop.org/series/113670/ State : success == Summary == CI Bug Log - changes from CI_DRM_12692 -> Patchwork_113670v1 Summary -

Re: [Intel-gfx] [RFC 1/3] drm/i915/power: move dc state members to struct i915_power_domains

2023-02-03 Thread Imre Deak
On Thu, Feb 02, 2023 at 10:47:46PM +0200, Jani Nikula wrote: > There's only one reference to the struct intel_dmc members dc_state, > target_dc_state, and allowed_dc_mask within intel_dmc.c, begging the > question why they are under struct intel_dmc to begin with. > > Moreover, the only references

[Intel-gfx] [PATCH] drm/i915/gt: Avoid redundant pointer validity check

2023-02-03 Thread Deepak R Varma
The macro definition of gen6_for_all_pdes() expands to a for loop such that it breaks when the page table is null. Hence there is no need to again test validity of the page table entry pointers in the pde list. This change is identified using itnull.cocci semantic patch. Signed-off-by: Deepak R Va

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 0/2] tests/i915/perf: Add stress / race exercises

2023-02-03 Thread Umesh Nerlige Ramappa
On Tue, Jan 31, 2023 at 10:17:29AM +0100, Janusz Krzysztofik wrote: Users reported oopses on list corruptions when using i915 perf with a number of concurrently running graphics applications. That indicates we are currently missing some important tests for such scenarios. Cover that gap. Any

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move fd_install after last use of fence

2023-02-03 Thread Patchwork
== Series Details == Series: drm/i915: Move fd_install after last use of fence URL : https://patchwork.freedesktop.org/series/113660/ State : success == Summary == CI Bug Log - changes from CI_DRM_12691 -> Patchwork_113660v1 Summary ---

[Intel-gfx] ✗ Fi.CI.BUILD: failure for vfio: fix deadlock between group lock and kvm lock (rev6)

2023-02-03 Thread Patchwork
== Series Details == Series: vfio: fix deadlock between group lock and kvm lock (rev6) URL : https://patchwork.freedesktop.org/series/113535/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/113535/revisions/6/mbox/ not applied Applying: vfio: fix d

Re: [Intel-gfx] [PATCH] drm/i915: Make sure dsm_size has correct granularity

2023-02-03 Thread Das, Nirmoy
Hi Lucas, On 2/3/2023 7:56 PM, Lucas De Marchi wrote: On Thu, Feb 02, 2023 at 07:02:43PM +0100, Nirmoy Das wrote: DSM granularity is 1MB so make sure we stick to that. I think we need to be a bit more verbose here, because in future we may need to refer to this commit if/when things change (e

Re: [Intel-gfx] [PATCH] drm/i915: Make sure dsm_size has correct granularity

2023-02-03 Thread Lucas De Marchi
On Thu, Feb 02, 2023 at 07:02:43PM +0100, Nirmoy Das wrote: DSM granularity is 1MB so make sure we stick to that. I think we need to be a bit more verbose here, because in future we may need to refer to this commit if/when things change (e.g. the granularity or the additional size needed on top

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix GEN8_MISCCPCTL

2023-02-03 Thread Matt Roper
On Fri, Feb 03, 2023 at 10:03:49AM -0800, Lucas De Marchi wrote: > On Thu, Feb 02, 2023 at 05:12:10PM -0800, Matt Roper wrote: > > On Thu, Feb 02, 2023 at 04:57:08PM -0800, Lucas De Marchi wrote: > > > Register 0x9424 is not replicated on any platform, so it shouldn't be > > > declared with REG_MCR

Re: [Intel-gfx] [PATCH] drm/i915: Move fd_install after last use of fence

2023-02-03 Thread Rob Clark
On Fri, Feb 3, 2023 at 8:49 AM Rob Clark wrote: > > From: Rob Clark > > Because eb_composite_fence_create() drops the fence_array reference > after creation of the sync_file, only the sync_file holds a ref to the > fence. But fd_install() makes that reference visable to userspace, so > it must b

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hwmon: Enable PL1 power limit (rev4)

2023-02-03 Thread Patchwork
== Series Details == Series: drm/i915/hwmon: Enable PL1 power limit (rev4) URL : https://patchwork.freedesktop.org/series/113578/ State : success == Summary == CI Bug Log - changes from CI_DRM_12691 -> Patchwork_113578v4 Summary ---

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix GEN8_MISCCPCTL

2023-02-03 Thread Lucas De Marchi
On Thu, Feb 02, 2023 at 05:12:10PM -0800, Matt Roper wrote: On Thu, Feb 02, 2023 at 04:57:08PM -0800, Lucas De Marchi wrote: Register 0x9424 is not replicated on any platform, so it shouldn't be declared with REG_MCR(). Declaring it with _MMIO() is basically duplicate of the GEN7 version, so jus

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/hwmon: Enable PL1 power limit (rev4)

2023-02-03 Thread Patchwork
== Series Details == Series: drm/i915/hwmon: Enable PL1 power limit (rev4) URL : https://patchwork.freedesktop.org/series/113578/ State : warning == Summary == Error: dim checkpatch failed e3e7fd1a9441 drm/i915/hwmon: Enable PL1 power limit -:16: WARNING:BAD_FIXES_TAG: Please use correct Fixes

Re: [Intel-gfx] [PATCH 4/6] drm/i915/guc: More debug print updates - GuC selftests

2023-02-03 Thread John Harrison
On 2/3/2023 01:54, Michal Wajdeczko wrote: On 03.02.2023 01:11, john.c.harri...@intel.com wrote: From: John Harrison Update a bunch more debug prints to use the new GT based scheme. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/selftest_guc.c | 35 ++- ..

Re: [Intel-gfx] [PATCH 1/6] drm/i915/guc: More debug print updates - UC firmware

2023-02-03 Thread John Harrison
On 2/3/2023 01:39, Michal Wajdeczko wrote: On 03.02.2023 01:11, john.c.harri...@intel.com wrote: From: John Harrison Update a bunch more debug prints to use the new GT based scheme. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_uc.c| 42 drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH v3] vfio: fix deadlock between group lock and kvm lock

2023-02-03 Thread Matthew Rosato
On 2/3/23 10:19 AM, Alex Williamson wrote: > On Fri, 3 Feb 2023 14:54:44 + > "Liu, Yi L" wrote: > >>> From: Alex Williamson >>> Sent: Friday, February 3, 2023 9:50 PM >>> >>> On Fri, 3 Feb 2023 13:32:09 + >>> "Liu, Yi L" wrote: >>> > From: Tian, Kevin > Sent: Friday, Februar

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Initialize the obj flags for shmem objects

2023-02-03 Thread Patchwork
== Series Details == Series: drm/i915: Initialize the obj flags for shmem objects URL : https://patchwork.freedesktop.org/series/113650/ State : success == Summary == CI Bug Log - changes from CI_DRM_12691 -> Patchwork_113650v1 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Initialize the obj flags for shmem objects

2023-02-03 Thread Patchwork
== Series Details == Series: drm/i915: Initialize the obj flags for shmem objects URL : https://patchwork.freedesktop.org/series/113650/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH] drm/i915: Move fd_install after last use of fence

2023-02-03 Thread Rob Clark
From: Rob Clark Because eb_composite_fence_create() drops the fence_array reference after creation of the sync_file, only the sync_file holds a ref to the fence. But fd_install() makes that reference visable to userspace, so it must be the last thing we do with the fence. Signed-off-by: Rob Cla

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/dsc: Add debugfs entry to validate DSC output formats

2023-02-03 Thread Patchwork
== Series Details == Series: drm/i915/dsc: Add debugfs entry to validate DSC output formats URL : https://patchwork.freedesktop.org/series/113649/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool CC [M] drivers/gpu/drm/i915/display/intel_

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 8/8] gputop: Basic vendor agnostic GPU top tool

2023-02-03 Thread Kamil Konieczny
Hi Tvrtko, On 2023-01-31 at 11:32:37 +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Rudimentary vendor agnostic example of how lib_igt_drm_clients can be used > to display a sorted by card and usage list of processes using GPUs. > > Borrows a bit of code from intel_gpu_top but for now

[Intel-gfx] ✓ Fi.CI.IGT: success for More error capture improvements

2023-02-03 Thread Patchwork
== Series Details == Series: More error capture improvements URL : https://patchwork.freedesktop.org/series/113628/ State : success == Summary == CI Bug Log - changes from CI_DRM_12687_full -> Patchwork_113628v1_full Summary --- **SU

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: add guard page to ggtt->error_capture (rev3)

2023-02-03 Thread Patchwork
== Series Details == Series: drm/i915: add guard page to ggtt->error_capture (rev3) URL : https://patchwork.freedesktop.org/series/113560/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12691 -> Patchwork_113560v3 Summary --

[Intel-gfx] [PATCH] drm/i915/hwmon: Enable PL1 power limit

2023-02-03 Thread Ashutosh Dixit
Previous documentation suggested that PL1 power limit is always enabled. However we now find this not to be the case on some platforms (such as ATSM). Therefore enable PL1 power limit during hwmon initialization. Bspec: 51864 v2: Add Bspec reference (Gwan-gyeong) v3: Add Fixes tag Fixes: 99f55ef

[Intel-gfx] ✓ Fi.CI.BAT: success for Initialize the obj flags for shmem objects

2023-02-03 Thread Patchwork
== Series Details == Series: Initialize the obj flags for shmem objects URL : https://patchwork.freedesktop.org/series/113645/ State : success == Summary == CI Bug Log - changes from CI_DRM_12691 -> Patchwork_113645v1 Summary --- **S

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Initialize the obj flags for shmem objects

2023-02-03 Thread Patchwork
== Series Details == Series: Initialize the obj flags for shmem objects URL : https://patchwork.freedesktop.org/series/113645/ State : warning == Summary == Error: dim checkpatch failed 9dbb5c9985ab Initialize the obj flags for shmem objects -:11: WARNING:BAD_FIXES_TAG: Please use correct Fixe

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Fix GEN8_MISCCPCTL

2023-02-03 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Fix GEN8_MISCCPCTL URL : https://patchwork.freedesktop.org/series/113626/ State : success == Summary == CI Bug Log - changes from CI_DRM_12687_full -> Patchwork_113626v1_full

Re: [Intel-gfx] [PATCH v3] vfio: fix deadlock between group lock and kvm lock

2023-02-03 Thread Alex Williamson
On Fri, 3 Feb 2023 14:54:44 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Friday, February 3, 2023 9:50 PM > > > > On Fri, 3 Feb 2023 13:32:09 + > > "Liu, Yi L" wrote: > > > > > > From: Tian, Kevin > > > > Sent: Friday, February 3, 2023 10:00 AM > > > > > > > > > From:

Re: [Intel-gfx] [PATCH v3 00/19] fix DRM_USE_DYNAMIC_DEBUG regression

2023-02-03 Thread Stanislaw Gruszka
On Fri, Feb 03, 2023 at 11:34:02AM +0200, Jani Nikula wrote: > On Wed, 25 Jan 2023, Jim Cromie wrote: > > Hi everyone, > > > > In v6.1 DRM_USE_DYNAMIC_DEBUG=y has a regression enabling drm.debug in > > drivers at modprobe. > > I realize we haven't actually addressed the regression in any way yet,

Re: [Intel-gfx] [PATCH v3] vfio: fix deadlock between group lock and kvm lock

2023-02-03 Thread Liu, Yi L
> From: Alex Williamson > Sent: Friday, February 3, 2023 9:50 PM > > On Fri, 3 Feb 2023 13:32:09 + > "Liu, Yi L" wrote: > > > > From: Tian, Kevin > > > Sent: Friday, February 3, 2023 10:00 AM > > > > > > > From: Alex Williamson > > > > Sent: Friday, February 3, 2023 7:13 AM > > > > > > >

Re: [Intel-gfx] [PATCH v3] vfio: fix deadlock between group lock and kvm lock

2023-02-03 Thread Liu, Yi L
> From: Matthew Rosato > Sent: Friday, February 3, 2023 10:26 PM > > On 2/3/23 3:58 AM, Liu, Yi L wrote: > > Hi Matthew, > > > ... > >> * Can't pass group->kvm to vfio_device_open, as it references the value > >> outside of new lock. Pass device->kvm to minimize changes in this > >> fix (Ale

Re: [Intel-gfx] [PATCH v2] drm/i915: Initialize the obj flags for shmem objects

2023-02-03 Thread Andrzej Hajda
On 03.02.2023 14:52, Aravind Iddamsetty wrote: Obj flags for shmem objects is not being set correctly. Fixes in setting BO_ALLOC_USER flag which applies to shmem objs as well. Fixes: 13d29c823738 ("drm/i915/ehl: unconditionally flush the pages on acquire") Cc: # v5.15+ v2: Add fixes tag (Tvrtk

Re: [Intel-gfx] [PATCH v3] vfio: fix deadlock between group lock and kvm lock

2023-02-03 Thread Matthew Rosato
On 2/3/23 3:58 AM, Liu, Yi L wrote: > Hi Matthew, > ... >> * Can't pass group->kvm to vfio_device_open, as it references the value >> outside of new lock. Pass device->kvm to minimize changes in this >> fix (Alex, Yi) ... >> @@ -361,7 +420,6 @@ static int vfio_device_first_open(struct vfio_de

Re: [Intel-gfx] [PATCH v3] vfio: fix deadlock between group lock and kvm lock

2023-02-03 Thread Alex Williamson
On Fri, 3 Feb 2023 13:32:09 + "Liu, Yi L" wrote: > > From: Tian, Kevin > > Sent: Friday, February 3, 2023 10:00 AM > > > > > From: Alex Williamson > > > Sent: Friday, February 3, 2023 7:13 AM > > > > > > On Thu, 2 Feb 2023 23:04:10 + > > > "Tian, Kevin" wrote: > > > > > > > > From

[Intel-gfx] [PATCH v2] drm/i915: Initialize the obj flags for shmem objects

2023-02-03 Thread Aravind Iddamsetty
Obj flags for shmem objects is not being set correctly. Fixes in setting BO_ALLOC_USER flag which applies to shmem objs as well. Fixes: 13d29c823738 ("drm/i915/ehl: unconditionally flush the pages on acquire") Cc: # v5.15+ v2: Add fixes tag (Tvrtko, Matt A) Cc: Matthew Auld Cc: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH v3] vfio: fix deadlock between group lock and kvm lock

2023-02-03 Thread Liu, Yi L
> From: Tian, Kevin > Sent: Friday, February 3, 2023 10:00 AM > > > From: Alex Williamson > > Sent: Friday, February 3, 2023 7:13 AM > > > > On Thu, 2 Feb 2023 23:04:10 + > > "Tian, Kevin" wrote: > > > > > > From: Alex Williamson > > > > Sent: Friday, February 3, 2023 3:42 AM > > > > > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/huc: Add and use HuC oriented print macros (rev2)

2023-02-03 Thread Patchwork
== Series Details == Series: drm/i915/huc: Add and use HuC oriented print macros (rev2) URL : https://patchwork.freedesktop.org/series/113542/ State : success == Summary == CI Bug Log - changes from CI_DRM_12688 -> Patchwork_113542v2 Summar

[Intel-gfx] [PATCH] drm/i915/dsc: Add debugfs entry to validate DSC output formats

2023-02-03 Thread Swati Sharma
DSC_Output_Format_Sink_Support entry is added to i915_dsc_fec_support_show to depict if sink supports DSC output formats (RGB/YCbCr420/YCbCr444). Also, new debugfs entry is created to enforce output format. This is required because of our driver policy. For ex. if a mode is supported in both RGB an

Re: [Intel-gfx] [PATCH v2 06/17] drm/display/dp_mst: Sanitize payload iteration in drm_dp_mst_dump_topology()

2023-02-03 Thread Imre Deak
On Fri, Feb 03, 2023 at 02:22:44PM +0200, Ville Syrjälä wrote: > On Tue, Jan 31, 2023 at 05:05:37PM +0200, Imre Deak wrote: > > Simplify the loop iterating the payloads by using a helper to get a > > payload by its VCPI (keeping the list VCPI sorted). This also removes > > the assumption that the b

[Intel-gfx] [PATCH v2] drm/i915: add guard page to ggtt->error_capture

2023-02-03 Thread Andrzej Hajda
Write-combining memory allows speculative reads by CPU. ggtt->error_capture is WC mapped to CPU, so CPU/MMU can try to prefetch memory beyond the error_capture, ie it tries to read memory pointed by next PTE in GGTT. If this PTE points to invalid address DMAR errors will occur. This behavior was ob

Re: [Intel-gfx] [PATCH] Initialize the obj flags for shmem objects

2023-02-03 Thread Iddamsetty, Aravind
On 03-02-2023 17:40, Tvrtko Ursulin wrote: > > > On 03/02/2023 11:57, Aravind Iddamsetty wrote: >> Obj flags for shmem objects is not being set correctly. >> >> Cc: Matthew Auld >> Signed-off-by: Aravind Iddamsetty > > Could even be: > > Fixes: 13d29c823738 ("drm/i915/ehl: unconditionally

Re: [Intel-gfx] [PATCH] Initialize the obj flags for shmem objects

2023-02-03 Thread Iddamsetty, Aravind
On 03-02-2023 17:42, Matthew Auld wrote: > On 03/02/2023 11:57, Aravind Iddamsetty wrote: >> Obj flags for shmem objects is not being set correctly. >> >> Cc: Matthew Auld >> Signed-off-by: Aravind Iddamsetty > > Subject should have "drm/i915:" prefix. My bad missed that. > > This is also a

[Intel-gfx] ✓ Fi.CI.BAT: success for More error capture improvements

2023-02-03 Thread Patchwork
== Series Details == Series: More error capture improvements URL : https://patchwork.freedesktop.org/series/113628/ State : success == Summary == CI Bug Log - changes from CI_DRM_12687 -> Patchwork_113628v1 Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix GEN8_MISCCPCTL

2023-02-03 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Fix GEN8_MISCCPCTL URL : https://patchwork.freedesktop.org/series/113626/ State : success == Summary == CI Bug Log - changes from CI_DRM_12687 -> Patchwork_113626v1 Summary -

[Intel-gfx] ✗ Fi.CI.BAT: failure for More drm_dbg to guc_dbg changes

2023-02-03 Thread Patchwork
== Series Details == Series: More drm_dbg to guc_dbg changes URL : https://patchwork.freedesktop.org/series/113624/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12687 -> Patchwork_113624v1 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH v2 06/17] drm/display/dp_mst: Sanitize payload iteration in drm_dp_mst_dump_topology()

2023-02-03 Thread Ville Syrjälä
On Tue, Jan 31, 2023 at 05:05:37PM +0200, Imre Deak wrote: > Simplify the loop iterating the payloads by using a helper to get a > payload by its VCPI (keeping the list VCPI sorted). This also removes > the assumption that the biggest VCPI matches the number of payloads > (even though this holds no

Re: [Intel-gfx] [PATCH] Initialize the obj flags for shmem objects

2023-02-03 Thread Matthew Auld
On 03/02/2023 12:10, Tvrtko Ursulin wrote: On 03/02/2023 11:57, Aravind Iddamsetty wrote: Obj flags for shmem objects is not being set correctly. Cc: Matthew Auld Signed-off-by: Aravind Iddamsetty Could even be: Fixes: 13d29c823738 ("drm/i915/ehl: unconditionally flush the pages on acqu

Re: [Intel-gfx] [PATCH] Initialize the obj flags for shmem objects

2023-02-03 Thread Matthew Auld
On 03/02/2023 11:57, Aravind Iddamsetty wrote: Obj flags for shmem objects is not being set correctly. Cc: Matthew Auld Signed-off-by: Aravind Iddamsetty Subject should have "drm/i915:" prefix. This is also a bug fix due to not setting BO_ALLOC_USER (the other flags don't seem to matter fo

Re: [Intel-gfx] [PATCH] Initialize the obj flags for shmem objects

2023-02-03 Thread Tvrtko Ursulin
On 03/02/2023 11:57, Aravind Iddamsetty wrote: Obj flags for shmem objects is not being set correctly. Cc: Matthew Auld Signed-off-by: Aravind Iddamsetty Could even be: Fixes: 13d29c823738 ("drm/i915/ehl: unconditionally flush the pages on acquire") Cc: # v5.15+ ? Regards, Tvrtko -

Re: [Intel-gfx] [PATCH 05/13] drm/i915/dsb: Dump the DSB command buffer when DSB fails

2023-02-03 Thread Ville Syrjälä
On Thu, Feb 02, 2023 at 05:09:05PM +, Manna, Animesh wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf Of Ville > > Syrjala > > Sent: Wednesday, January 18, 2023 10:01 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [Intel-gfx] [PATCH 05/13] drm/i915/dsb: Dump t

[Intel-gfx] [PATCH] Initialize the obj flags for shmem objects

2023-02-03 Thread Aravind Iddamsetty
Obj flags for shmem objects is not being set correctly. Cc: Matthew Auld Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915

Re: [Intel-gfx] [PATCH] drm/i915/fbdev: Implement wrappers for callbacks used by fbcon

2023-02-03 Thread Thomas Zimmermann
Hi Am 03.02.23 um 12:09 schrieb Hogander, Jouni: On Fri, 2023-02-03 at 12:42 +0200, Ville Syrjälä wrote: On Fri, Feb 03, 2023 at 07:21:27AM +, Hogander, Jouni wrote: On Tue, 2023-01-24 at 13:27 +0100, Thomas Zimmermann wrote: Hi Am 24.01.23 um 10:10 schrieb Jouni Högander: After disconn

Re: [Intel-gfx] [PATCH v4] drm/i915/fbdev: Implement fb_dirty for intel custom fb helper

2023-02-03 Thread Ville Syrjälä
On Mon, Jan 23, 2023 at 09:44:37AM +0200, Jouni Högander wrote: > After disconnecting damage worker from update logic it's left to fbdev > emulation implementation to have fb_dirty function. Currently intel > fbdev doesn't have it. This is causing problems to features (PSR, FBC, > DRRS) relying on

[Intel-gfx] [PATCH i-g-t 3/3] intel_gpu_top: Add CSV output format

2023-02-03 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add CSV output mode. Signed-off-by: Tvrtko Ursulin Cc: Caleb Callaway --- man/intel_gpu_top.rst | 3 ++ tools/intel_gpu_top.c | 78 +-- 2 files changed, 78 insertions(+), 3 deletions(-) diff --git a/man/intel_gpu_top.rst b/man/int

[Intel-gfx] [PATCH i-g-t 3/3] intel_gpu_top: Add CSV output format

2023-02-03 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add CSV output mode. Signed-off-by: Tvrtko Ursulin Cc: Caleb Callaway --- man/intel_gpu_top.rst | 3 ++ tools/intel_gpu_top.c | 78 +-- 2 files changed, 78 insertions(+), 3 deletions(-) diff --git a/man/intel_gpu_top.rst b/man/int

Re: [Intel-gfx] [PATCH 2/3] drm/scheduler: Fix elapsed_ns kernel-doc error

2023-02-03 Thread Lucas Stach
Am Freitag, dem 03.02.2023 um 17:02 +0700 schrieb Bagas Sanjaya: > Stephen Rothwell reported htmldocs warnings: > > include/drm/gpu_scheduler.h:232: warning: Incorrect use of kernel-doc format: > * @elapsed_ns > include/drm/gpu_scheduler.h:238: warning: Function parameter or member > 'e

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 3/3] intel_gpu_top: Add CVS output format

2023-02-03 Thread Tvrtko Ursulin
On 03/02/2023 11:22, Ville Syrjälä wrote: On Fri, Feb 03, 2023 at 11:16:36AM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Add CVS output mode. Should that be csv? Lol at least I was consistent.. facepalm. Regards, Tvrtko Signed-off-by: Tvrtko Ursulin Cc: Caleb Callaway ---

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 3/3] intel_gpu_top: Add CVS output format

2023-02-03 Thread Ville Syrjälä
On Fri, Feb 03, 2023 at 11:16:36AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Add CVS output mode. Should that be csv? > > Signed-off-by: Tvrtko Ursulin > Cc: Caleb Callaway > --- > man/intel_gpu_top.rst | 3 ++ > tools/intel_gpu_top.c | 78

[Intel-gfx] [PATCH i-g-t 1/3] intel_gpu_top: Do not repeat header lines in non-interactive output

2023-02-03 Thread Tvrtko Ursulin
From: Tvrtko Ursulin If output is redirected to a file, or a pipe, lets not repeat the headers because that can usually mean user is trying to parse the data later and so repeated headers are a hindrance. Signed-off-by: Tvrtko Ursulin Cc: Caleb Callaway --- tools/intel_gpu_top.c | 19

[Intel-gfx] [PATCH i-g-t 3/3] intel_gpu_top: Add CVS output format

2023-02-03 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add CVS output mode. Signed-off-by: Tvrtko Ursulin Cc: Caleb Callaway --- man/intel_gpu_top.rst | 3 ++ tools/intel_gpu_top.c | 78 +-- 2 files changed, 78 insertions(+), 3 deletions(-) diff --git a/man/intel_gpu_top.rst b/man/int

[Intel-gfx] [PATCH i-g-t 2/3] intel_gpu_top: Rename STDOUT to TEXT

2023-02-03 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Internal cleanup only - the name text is more accurate given the output can also go to a file. Signed-off-by: Tvrtko Ursulin Cc: Caleb Callaway --- tools/intel_gpu_top.c | 54 +-- 1 file changed, 26 insertions(+), 28 deletions(-) d

[Intel-gfx] [PATCH i-g-t 0/3] More intel_gpu_top improvements

2023-02-03 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Suggestion was received to omit repeating header lines when outputting to a file and also to add the CVS mode for easy parsing. We have JSON but I guess CVS can definitely be easier for some use cases. Tvrtko Ursulin (3): intel_gpu_top: Do not repeat header lines in non-in

Re: [Intel-gfx] [PATCH] drm/i915/fbdev: Implement wrappers for callbacks used by fbcon

2023-02-03 Thread Hogander, Jouni
On Fri, 2023-02-03 at 12:42 +0200, Ville Syrjälä wrote: > On Fri, Feb 03, 2023 at 07:21:27AM +, Hogander, Jouni wrote: > > On Tue, 2023-01-24 at 13:27 +0100, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 24.01.23 um 10:10 schrieb Jouni Högander: > > > > After disconnecting damage worker fro

Re: [Intel-gfx] [PATCH 11/13] drm/i915/dsb: Write each legacy LUT entry twice with DSB

2023-02-03 Thread Ville Syrjälä
On Thu, Feb 02, 2023 at 07:05:27PM +, Manna, Animesh wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf Of Ville > > Syrjala > > Sent: Wednesday, January 18, 2023 10:01 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [Intel-gfx] [PATCH 11/13] drm/i915/dsb: Write

Re: [Intel-gfx] [PATCH 09/13] drm/i915/dsb: Don't use DSB to load the LUTs during full modeset

2023-02-03 Thread Ville Syrjälä
On Fri, Feb 03, 2023 at 10:04:17AM +, Manna, Animesh wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf Of Ville > > Syrjala > > Sent: Wednesday, January 18, 2023 10:01 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [Intel-gfx] [PATCH 09/13] drm/i915/dsb: Don't

Re: [Intel-gfx] [PATCH] drm/i915/fbdev: Implement wrappers for callbacks used by fbcon

2023-02-03 Thread Ville Syrjälä
On Fri, Feb 03, 2023 at 07:21:27AM +, Hogander, Jouni wrote: > On Tue, 2023-01-24 at 13:27 +0100, Thomas Zimmermann wrote: > > Hi > > > > Am 24.01.23 um 10:10 schrieb Jouni Högander: > > > After disconnecting damage worker from update logic our dirty > > > callback > > > is not called on fbcon

Re: [Intel-gfx] [PATCH 5/5] drm/i915/dmc: check incoming dmc id validity

2023-02-03 Thread Jani Nikula
On Thu, 02 Feb 2023, Imre Deak wrote: > On Thu, Feb 02, 2023 at 02:04:52PM +0200, Jani Nikula wrote: >> Add validity checks for the dmc ids computed from pipe parameters in >> intel_dmc_enable_pipe() and intel_dmc_disable_pipe(). It's slightly >> difficult for humans and static analyzers alike to

[Intel-gfx] ✗ Fi.CI.BUILD: failure for htmldocs fixes for next-20230203

2023-02-03 Thread Patchwork
== Series Details == Series: htmldocs fixes for next-20230203 URL : https://patchwork.freedesktop.org/series/113640/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/113640/revisions/1/mbox/ not applied Applying: drm/i915/doc: Escape wildcard in

Re: [Intel-gfx] [PATCH 09/13] drm/i915/dsb: Don't use DSB to load the LUTs during full modeset

2023-02-03 Thread Manna, Animesh
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, January 18, 2023 10:01 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 09/13] drm/i915/dsb: Don't use DSB to load the > LUTs during full modeset > > From: Ville Syrjälä > > Us

[Intel-gfx] [PATCH 3/3] media: v4l2-core: Describe privacy_led field of v4l2_subdev

2023-02-03 Thread Bagas Sanjaya
Stephen Rothwell reported htmldocs warning: include/media/v4l2-subdev.h:1088: warning: Function parameter or member 'privacy_led' not described in 'v4l2_subdev' Describe privacy_led field to fix the warning. Link: https://lore.kernel.org/linux-next/20230203135303.32da1...@canb.auug.org.au/ Fix

[Intel-gfx] [PATCH 0/3] htmldocs fixes for next-20230203

2023-02-03 Thread Bagas Sanjaya
Here are small htmldocs fixes for htmldocs warnings that are recently reported for next-20230203. Each patch can be applied separately by respective maintainers. Bagas Sanjaya (3): drm/i915/doc: Escape wildcard in method names drm/scheduler: Fix elapsed_ns kernel-doc error media: v4l2-core

[Intel-gfx] [PATCH 2/3] drm/scheduler: Fix elapsed_ns kernel-doc error

2023-02-03 Thread Bagas Sanjaya
Stephen Rothwell reported htmldocs warnings: include/drm/gpu_scheduler.h:232: warning: Incorrect use of kernel-doc format: * @elapsed_ns include/drm/gpu_scheduler.h:238: warning: Function parameter or member 'elapsed_ns' not described in 'drm_sched_entity' Fix the error by appending mi

[Intel-gfx] [PATCH 1/3] drm/i915/doc: Escape wildcard in method names

2023-02-03 Thread Bagas Sanjaya
Stephen Rothwell reported htmldocs warnings: Documentation/gpu/i915:64: drivers/gpu/drm/i915/gt/intel_workarounds.c:32: WARNING: Inline emphasis start-string without end-string. Documentation/gpu/i915:64: drivers/gpu/drm/i915/gt/intel_workarounds.c:57: WARNING: Inline emphasis start-string witho

Re: [Intel-gfx] [PATCH 6/6] drm/i915/guc: More debug print updates - GuC logging

2023-02-03 Thread Michal Wajdeczko
On 03.02.2023 01:11, john.c.harri...@intel.com wrote: > From: John Harrison > > Update a bunch more debug prints to use the new GT based scheme. > > Signed-off-by: John Harrison > --- > drivers/gpu/drm/i915/gt/intel_gt_print.h | 3 +++ > drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 3

Re: [Intel-gfx] [PATCH 08/13] drm/i915/dsb: Skip DSB command buffer setup if we have no LUTs

2023-02-03 Thread Manna, Animesh
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, January 18, 2023 10:01 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 08/13] drm/i915/dsb: Skip DSB command buffer > setup if we have no LUTs > > From: Ville Syrjälä > > If w

Re: [Intel-gfx] [PATCH 5/6] drm/i915/guc: More debug print updates - GuC SLPC

2023-02-03 Thread Michal Wajdeczko
On 03.02.2023 01:11, john.c.harri...@intel.com wrote: > From: John Harrison > > Update a bunch more debug prints to use the new GT based scheme. > > Signed-off-by: John Harrison > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_rc.c | 8 +-- > drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 60

Re: [Intel-gfx] [PATCH 4/6] drm/i915/guc: More debug print updates - GuC selftests

2023-02-03 Thread Michal Wajdeczko
On 03.02.2023 01:11, john.c.harri...@intel.com wrote: > From: John Harrison > > Update a bunch more debug prints to use the new GT based scheme. > > Signed-off-by: John Harrison > --- > drivers/gpu/drm/i915/gt/uc/selftest_guc.c | 35 ++- > .../drm/i915/gt/uc/selftest_guc

Re: [Intel-gfx] [PATCH 01/13] drm/i915/dsb: Define more DSB registers

2023-02-03 Thread Manna, Animesh
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, January 18, 2023 10:00 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 01/13] drm/i915/dsb: Define more DSB registers > > From: Ville Syrjälä > > Add definitions for more DSB

Re: [Intel-gfx] [PATCH 02/13] drm/i915/dsb: Pimp debug/error prints

2023-02-03 Thread Manna, Animesh
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, January 18, 2023 10:00 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 02/13] drm/i915/dsb: Pimp debug/error prints > > From: Ville Syrjälä > > Print the crtc/DSB id informati

  1   2   >