Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2022-12-28 Thread Matthew Brost
On Fri, Dec 23, 2022 at 09:42:58AM -0800, Rob Clark wrote: > On Thu, Dec 22, 2022 at 2:29 PM Matthew Brost wrote: > > > > In XE, the new Intel GPU driver, a choice has made to have a 1 to 1 > > mapping between a drm_gpu_scheduler and drm_sched_entity. At first this > > seems a bit odd but let us e

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dmc: Use unversioned firmware paths

2022-12-28 Thread Gustavo Sousa
On Wed, Dec 28, 2022 at 07:04:46PM -0300, Vivi, Rodrigo wrote: > On Wed, 2022-12-28 at 19:00 -0300, Gustavo Sousa wrote: > > On Fri, Dec 23, 2022 at 10:36:05AM -0500, Rodrigo Vivi wrote: > > > On Fri, Dec 23, 2022 at 08:51:59AM -0300, Gustavo Sousa wrote: > > > > On Thu, Dec 22, 2022 at 04:52:21PM

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dmc: Use unversioned firmware paths

2022-12-28 Thread Vivi, Rodrigo
On Wed, 2022-12-28 at 19:00 -0300, Gustavo Sousa wrote: > On Fri, Dec 23, 2022 at 10:36:05AM -0500, Rodrigo Vivi wrote: > > On Fri, Dec 23, 2022 at 08:51:59AM -0300, Gustavo Sousa wrote: > > > On Thu, Dec 22, 2022 at 04:52:21PM -0800, Lucas De Marchi wrote: > > > > On Thu, Dec 22, 2022 at 07:12:08P

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dmc: Use unversioned firmware paths

2022-12-28 Thread Gustavo Sousa
On Fri, Dec 23, 2022 at 10:36:05AM -0500, Rodrigo Vivi wrote: > On Fri, Dec 23, 2022 at 08:51:59AM -0300, Gustavo Sousa wrote: > > On Thu, Dec 22, 2022 at 04:52:21PM -0800, Lucas De Marchi wrote: > > > On Thu, Dec 22, 2022 at 07:12:08PM -0300, Gustavo Sousa wrote: > > > > On Wed, Dec 21, 2022 at 04

[Intel-gfx] ✓ Fi.CI.IGT: success for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-12-28 Thread Patchwork
== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/112279/ State : success == Summary == CI Bug Log - changes from CI_DRM_12528_full -> Patchwork_1122

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-12-28 Thread Patchwork
== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/112279/ State : success == Summary == CI Bug Log - changes from CI_DRM_12528 -> Patchwork_112279v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-12-28 Thread Patchwork
== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/112279/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode use

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-12-28 Thread Patchwork
== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/112279/ State : warning == Summary == Error: dim checkpatch failed 580bc7c6ee10 drm/i915/gem: Typec

[Intel-gfx] [PATCH v16 5/6] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

2022-12-28 Thread Gwan-gyeong Mun
The ttm_bo_init_reserved() functions returns -ENOSPC if the size is too big to add vma. The direct function that returns -ENOSPC is drm_mm_insert_node_in_range(). To handle the same error as other code returning -E2BIG when the size is too large, it converts return value to -E2BIG. Cc: Chris Wilso

[Intel-gfx] [PATCH v16 6/6] drm/i915: Remove truncation warning for large objects

2022-12-28 Thread Gwan-gyeong Mun
From: Chris Wilson Having addressed the issues surrounding incorrect types for local variables and potential integer truncation in using the scatterlist API, we have closed all the loop holes we had previously identified with dangerously large object creation. As such, we can eliminate the warnin

[Intel-gfx] [PATCH v16 3/6] drm/i915: Check for integer truncation on the configuration of ttm place

2022-12-28 Thread Gwan-gyeong Mun
There is an impedance mismatch between the first/last valid page frame number of ttm place in unsigned and our memory/page accounting in unsigned long. As the object size is under the control of userspace, we have to be prudent and catch the conversion errors. To catch the implicit truncation as we

[Intel-gfx] [PATCH v16 4/6] drm/i915: Check if the size is too big while creating shmem file

2022-12-28 Thread Gwan-gyeong Mun
The __shmem_file_setup() function returns -EINVAL if size is greater than MAX_LFS_FILESIZE. To handle the same error as other code that returns -E2BIG when the size is too large, it add a code that returns -E2BIG when the size is larger than the size that can be handled. v4: If BITS_PER_LONG is 32

[Intel-gfx] [PATCH v16 2/6] drm/i915: Check for integer truncation on scatterlist creation

2022-12-28 Thread Gwan-gyeong Mun
From: Chris Wilson There is an impedance mismatch between the scatterlist API using unsigned int and our memory/page accounting in unsigned long. That is we may try to create a scatterlist for a large object that overflows returning a small table into which we try to fit very many pages. As the o

[Intel-gfx] [PATCH v16 1/6] drm/i915/gem: Typecheck page lookups

2022-12-28 Thread Gwan-gyeong Mun
From: Chris Wilson We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead of a more suitable long. Be pedantic and add integer typechecking to the lookup so that we can be sure that we are safe. A

[Intel-gfx] [PATCH v16 0/6] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-12-28 Thread Gwan-gyeong Mun
This patch series fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation, etc. We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead o

Re: [Intel-gfx] [PATCH v15 0/6] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-12-28 Thread Rodrigo Vivi
On Wed, Dec 28, 2022 at 04:25:27PM +0200, Gwan-gyeong Mun wrote: > This patch series fixes integer overflow or integer truncation issues in > page lookups, ttm place configuration and scatterlist creation, etc. > We need to check that we avoid integer overflows when looking up a page, > and so fix

[Intel-gfx] ✓ Fi.CI.IGT: success for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-12-28 Thread Patchwork
== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/112270/ State : success == Summary == CI Bug Log - changes from CI_DRM_12528_full -> Patchwork_1122

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-12-28 Thread Patchwork
== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/112270/ State : success == Summary == CI Bug Log - changes from CI_DRM_12528 -> Patchwork_112270v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-12-28 Thread Patchwork
== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/112270/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode use

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-12-28 Thread Patchwork
== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/112270/ State : warning == Summary == Error: dim checkpatch failed 3f25c303c308 drm/i915/gem: Typec

[Intel-gfx] [PATCH v15 6/6] drm/i915: Remove truncation warning for large objects

2022-12-28 Thread Gwan-gyeong Mun
From: Chris Wilson Having addressed the issues surrounding incorrect types for local variables and potential integer truncation in using the scatterlist API, we have closed all the loop holes we had previously identified with dangerously large object creation. As such, we can eliminate the warnin

[Intel-gfx] [PATCH v15 5/6] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

2022-12-28 Thread Gwan-gyeong Mun
The ttm_bo_init_reserved() functions returns -ENOSPC if the size is too big to add vma. The direct function that returns -ENOSPC is drm_mm_insert_node_in_range(). To handle the same error as other code returning -E2BIG when the size is too large, it converts return value to -E2BIG. Cc: Chris Wils

[Intel-gfx] [PATCH v15 4/6] drm/i915: Check if the size is too big while creating shmem file

2022-12-28 Thread Gwan-gyeong Mun
The __shmem_file_setup() function returns -EINVAL if size is greater than MAX_LFS_FILESIZE. To handle the same error as other code that returns -E2BIG when the size is too large, it add a code that returns -E2BIG when the size is larger than the size that can be handled. v4: If BITS_PER_LONG is 32

[Intel-gfx] [PATCH v15 3/6] drm/i915: Check for integer truncation on the configuration of ttm place

2022-12-28 Thread Gwan-gyeong Mun
There is an impedance mismatch between the first/last valid page frame number of ttm place in unsigned and our memory/page accounting in unsigned long. As the object size is under the control of userspace, we have to be prudent and catch the conversion errors. To catch the implicit truncation as we

[Intel-gfx] [PATCH v15 0/6] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-12-28 Thread Gwan-gyeong Mun
This patch series fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation, etc. We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead o

[Intel-gfx] [PATCH v15 2/6] drm/i915: Check for integer truncation on scatterlist creation

2022-12-28 Thread Gwan-gyeong Mun
From: Chris Wilson There is an impedance mismatch between the scatterlist API using unsigned int and our memory/page accounting in unsigned long. That is we may try to create a scatterlist for a large object that overflows returning a small table into which we try to fit very many pages. As the o

[Intel-gfx] [PATCH v15 1/6] drm/i915/gem: Typecheck page lookups

2022-12-28 Thread Gwan-gyeong Mun
From: Chris Wilson We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead of a more suitable long. Be pedantic and add integer typechecking to the lookup so that we can be sure that we are safe. A

[Intel-gfx] ✗ Fi.CI.BAT: failure for ] Revert "perf/core: Avoid removing shared pmu_context on unregister"

2022-12-28 Thread Patchwork
== Series Details == Series: ] Revert "perf/core: Avoid removing shared pmu_context on unregister" URL : https://patchwork.freedesktop.org/series/112265/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12528 -> Patchwork_112265v1 =

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for ] Revert "perf/core: Avoid removing shared pmu_context on unregister"

2022-12-28 Thread Patchwork
== Series Details == Series: ] Revert "perf/core: Avoid removing shared pmu_context on unregister" URL : https://patchwork.freedesktop.org/series/112265/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2

Re: [Intel-gfx] [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2022-12-28 Thread Rodrigo Vivi
On Tue, Dec 27, 2022 at 11:36:13PM +0530, Deepak R Varma wrote: > On Tue, Dec 27, 2022 at 12:13:56PM -0500, Rodrigo Vivi wrote: > > On Tue, Dec 27, 2022 at 01:30:53PM +0530, Deepak R Varma wrote: > > > Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() > > > function adds the overhe

Re: [Intel-gfx] [[topic/core-for-CI]] Revert "perf/core: Avoid removing shared pmu_context on unregister"

2022-12-28 Thread Rodrigo Vivi
On Wed, Dec 28, 2022 at 05:47:12AM -0500, Rodrigo Vivi wrote: > There's a complete rewrite of the core context handling in > v6.2-rc1. find_pmu_context function used in this commit doesn't > exist anymore. Also, let's first trust the upstream component, > then work with them to get the issue solved

[Intel-gfx] [[topic/core-for-CI]] Revert "perf/core: Avoid removing shared pmu_context on unregister"

2022-12-28 Thread Rodrigo Vivi
There's a complete rewrite of the core context handling in v6.2-rc1. find_pmu_context function used in this commit doesn't exist anymore. Also, let's first trust the upstream component, then work with them to get the issue solved if still present, re-introduce this patch with the old function only

Re: [Intel-gfx] [PATCH v2] drm/i915: dell wyse 3040 shutdown fix

2022-12-28 Thread Jani Nikula
On Tue, 27 Dec 2022, Alexey Lukyachuk wrote: > On Tue, 27 Dec 2022 11:39:25 -0500 > Rodrigo Vivi wrote: > >> On Sun, Dec 25, 2022 at 09:55:08PM +0300, Alexey Lukyanchuk wrote: >> > dell wyse 3040 doesn't peform poweroff properly, but instead remains in >> > turned power on state. >> >> okay, th

Re: [Intel-gfx] [PATCH 26/27] KVM: x86/mmu: Add page-track API to query if a gfn is valid

2022-12-28 Thread Yan Zhao
On Fri, Dec 23, 2022 at 12:57:38AM +, Sean Christopherson wrote: > Add a page-track API to query if a gfn is "valid", i.e. is backed by a > memslot and is visible to the guest. This is one more step toward > removing KVM internal details from the page-track APIs. > > Add a FIXME to call out t