Re: [Intel-gfx] [PATCH 19/27] KVM: x86/mmu: Use page-track notifiers iff there are external users

2022-12-27 Thread Yan Zhao
On Fri, Dec 23, 2022 at 12:57:31AM +, Sean Christopherson wrote: > Disable the page-track notifier code at compile time if there are no > external users, i.e. if CONFIG_KVM_EXTERNAL_WRITE_TRACKING=n. KVM itself > now hooks emulated writes directly instead of relying on the page-track > mechani

Re: [Intel-gfx] [PATCH 03/27] drm/i915/gvt: Incorporate KVM memslot info into check for 2MiB GTT entry

2022-12-27 Thread Yan Zhao
On Fri, Dec 23, 2022 at 12:57:15AM +, Sean Christopherson wrote: > Honor KVM's max allowed page size when determining whether or not a 2MiB > GTT shadow page can be created for the guest. Querying KVM's max allowed > size is somewhat odd as there's no strict requirement that KVM's memslots > a

Re: [Intel-gfx] [PATCH v4 5/7] drm/i915/hdcp: Fill wired_cmd_in structures at a single place

2022-12-27 Thread Kandpal, Suraj
> > On Thu, 22 Dec 2022, Suraj Kandpal wrote: > > Need to fill wired cmd in structures at a single place as they remain > > same for both gsc and mei. > > It's probably a good idea to have them in a single place, but there's really > no > reason for that place to be part of i915 at all. > > No

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gvt: KVM: KVMGT fixes and page-track cleanups (rev2)

2022-12-27 Thread Patchwork
== Series Details == Series: drm/i915/gvt: KVM: KVMGT fixes and page-track cleanups (rev2) URL : https://patchwork.freedesktop.org/series/112196/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/112196/revisions/2/mbox/ not applied Applying: drm/i91

Re: [Intel-gfx] [PATCH 09/27] drm/i915/gvt: Protect gfn hash table with dedicated mutex

2022-12-27 Thread Yan Zhao
On Fri, Dec 23, 2022 at 12:57:21AM +, Sean Christopherson wrote: > Add and use a new mutex, gfn_lock, to protect accesses to the hash table > used to track which gfns are write-protected when shadowing the guest's > GTT. This fixes a bug where kvmgt_page_track_write(), which doesn't hold > kvm

Re: [Intel-gfx] [PATCH v4 6/7] drm/i915/mtl: Add function to send command to GSC CS

2022-12-27 Thread Teres Alexis, Alan Previn
I've send offline email to clear up session cleanup behavior for hdcp (maybe its a PXP-only thing). But still wanna pursue a bit more on below portion: On Fri, 2022-12-23 at 09:07 +, Kandpal, Suraj wrote: > > > > > > > + memset(cmd, 0, obj->base.size); > > > > Alan: question: how often is

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2022-12-27 Thread Patchwork
== Series Details == Series: drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes URL : https://patchwork.freedesktop.org/series/112249/ State : success == Summary == CI Bug Log - changes from CI_DRM_12526_full -> Patchwork_112249v1_full ===

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Check source height is > 0

2022-12-27 Thread Patchwork
== Series Details == Series: drm/i915/display: Check source height is > 0 URL : https://patchwork.freedesktop.org/series/112237/ State : success == Summary == CI Bug Log - changes from CI_DRM_12526_full -> Patchwork_112237v1_full Summary --

[Intel-gfx] ✗ Fi.CI.BAT: failure for convert i915_active.count from atomic_t to refcount_t

2022-12-27 Thread Patchwork
== Series Details == Series: convert i915_active.count from atomic_t to refcount_t URL : https://patchwork.freedesktop.org/series/112246/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12526 -> Patchwork_112246v1 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for convert i915_active.count from atomic_t to refcount_t

2022-12-27 Thread Patchwork
== Series Details == Series: convert i915_active.count from atomic_t to refcount_t URL : https://patchwork.freedesktop.org/series/112246/ State : warning == Summary == Error: dim checkpatch failed f3d75205bec5 drm/i915: convert i915_active.count from atomic_t to refcount_t -:60: WARNING:AVOID_

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2022-12-27 Thread Patchwork
== Series Details == Series: drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes URL : https://patchwork.freedesktop.org/series/112249/ State : success == Summary == CI Bug Log - changes from CI_DRM_12526 -> Patchwork_112249v1 Sum

Re: [Intel-gfx] [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2022-12-27 Thread Deepak R Varma
On Tue, Dec 27, 2022 at 12:13:56PM -0500, Rodrigo Vivi wrote: > On Tue, Dec 27, 2022 at 01:30:53PM +0530, Deepak R Varma wrote: > > Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() > > function adds the overhead of introducing a proxy file operation > > functions to wrap the origi

Re: [Intel-gfx] [PATCH] drm/i915/display: Check source height is > 0

2022-12-27 Thread Teres Alexis, Alan Previn
Is there a better place for this check higher up the intel specific atomic-check? (so the check won't be skl specific - i notice that intel_adjusted_rate is also called by ilk_foo as well and non-backend-specific functions). Else, perhaps intel_adjusted_rate should add a check + WARN? (if we are

Re: [Intel-gfx] [PATCH v2] drm/i915: dell wyse 3040 shutdown fix

2022-12-27 Thread Alexey Lukyachuk
On Tue, 27 Dec 2022 11:39:25 -0500 Rodrigo Vivi wrote: > On Sun, Dec 25, 2022 at 09:55:08PM +0300, Alexey Lukyanchuk wrote: > > dell wyse 3040 doesn't peform poweroff properly, but instead remains in > > turned power on state. > > okay, the motivation is explained in the commit msg.. > > > Add

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Avoid full proxy f_ops for DRRS debug attributes

2022-12-27 Thread Patchwork
== Series Details == Series: drm/i915/display: Avoid full proxy f_ops for DRRS debug attributes URL : https://patchwork.freedesktop.org/series/112248/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12526 -> Patchwork_112248v1

Re: [Intel-gfx] [PATCH v4 5/7] drm/i915/hdcp: Fill wired_cmd_in structures at a single place

2022-12-27 Thread Teres Alexis, Alan Previn
Just my 2 cents (im not hdcp expert but understand a little on the GSC vs MEI): IIRC, HW architecture wise, MEI and GSC-CS (command streamer) are both merely transport protocols to a backend-service. The backend-service here being HDCP-subsystem within the security firmware (one of several backe

Re: [Intel-gfx] [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2022-12-27 Thread Rodrigo Vivi
On Tue, Dec 27, 2022 at 01:30:53PM +0530, Deepak R Varma wrote: > Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() > function adds the overhead of introducing a proxy file operation > functions to wrap the original read/write inside file removal protection > functions. This adds s

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: convert i915_active.count from atomic_t to refcount_t

2022-12-27 Thread Patchwork
== Series Details == Series: drm/i915: convert i915_active.count from atomic_t to refcount_t URL : https://patchwork.freedesktop.org/series/112247/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool CC [M] drivers/gpu/drm/i915/i915_active.o

Re: [Intel-gfx] [PATCH v4 5/7] drm/i915/hdcp: Fill wired_cmd_in structures at a single place

2022-12-27 Thread Jani Nikula
On Thu, 22 Dec 2022, Suraj Kandpal wrote: > Need to fill wired cmd in structures at a single place as they remain > same for both gsc and mei. It's probably a good idea to have them in a single place, but there's really no reason for that place to be part of i915 at all. None of the functions ar

Re: [Intel-gfx] [PATCH v2] drm/i915: dell wyse 3040 shutdown fix

2022-12-27 Thread Rodrigo Vivi
On Sun, Dec 25, 2022 at 09:55:08PM +0300, Alexey Lukyanchuk wrote: > dell wyse 3040 doesn't peform poweroff properly, but instead remains in > turned power on state. okay, the motivation is explained in the commit msg.. > Additional mutex_lock and > intel_crtc_wait_for_next_vblank > feature 6.

Re: [Intel-gfx] [PATCH] drm/i915/gt: Retry RING_HEAD reset until it sticks

2022-12-27 Thread Jani Nikula
On Fri, 23 Dec 2022, Tvrtko Ursulin wrote: > On 23/12/2022 12:18, Andi Shyti wrote: >> From: Chris Wilson >> >> On Haswell, in particular, we see an issue where resets fails because >> the engine resumes from an incorrect RING_HEAD. Since the RING_HEAD >> doesn't point to the remaining requests

Re: [Intel-gfx] [PATCH v6] drm: Optimise for continuous memory allocation

2022-12-27 Thread Dan Carpenter
Hi xinhui, https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/xinhui-pan/drm-Optimise-for-continuous-memory-allocation/20221218-145922 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lo

[Intel-gfx] [PATCH v2 1/2] drm/i915: convert i915_active.count from atomic_t to refcount_t

2022-12-27 Thread Deepak R Varma
The refcount_* APIs are designed to address known issues with the atomic_t APIs for reference counting. They provide following distinct advantages: - protect the reference counters from overflow/underflow - avoid use-after-free errors - provide improved memory ordering guarantee schemes

[Intel-gfx] [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2022-12-27 Thread Deepak R Varma
Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() function adds the overhead of introducing a proxy file operation functions to wrap the original read/write inside file removal protection functions. This adds significant overhead in terms of introducing and managing the proxy facto

[Intel-gfx] [PATCH] drm/i915/display: Avoid full proxy f_ops for DRRS debug attributes

2022-12-27 Thread Deepak R Varma
Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() function adds the overhead of introducing a proxy file operation functions to wrap the original read/write inside file removal protection functions. This adds significant overhead in terms of introducing and managing the proxy facto

[Intel-gfx] [PATCH v2 2/2] drm/i915/selftests: Convert atomic_* API calls for i915_active.count refcount_*

2022-12-27 Thread Deepak R Varma
Handle the struct i915_active member variable count transition from atomic_t type to refcount_t type for selftest use cases. Transition the atomic_*() API calls to their equivalent refcount_*() API calls. Reported-by: kernel test robot Signed-off-by: Deepak R Varma --- Please note: 1. Propose

[Intel-gfx] [PATCH] drm/i915: convert i915_active.count from atomic_t to refcount_t

2022-12-27 Thread Deepak R Varma
The refcount_* APIs are designed to address known issues with the atomic_t APIs for reference counting. They provide following distinct advantages: - protect the reference counters from overflow/underflow - avoid use-after-free errors - provide improved memory ordering guarantee schemes

[Intel-gfx] [PATCH v2 0/2] convert i915_active.count from atomic_t to refcount_t

2022-12-27 Thread Deepak R Varma
Transition the reference count member variable count of struct i915_active from atomic_t type to refcount_t type. This proposal is based on issues identified using the atomic_as_refcounter.cocci Coccinelle semantic patch script. Patch 1/2: proposes to convert the base implementation of variable co

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Check source height is > 0

2022-12-27 Thread Patchwork
== Series Details == Series: drm/i915/display: Check source height is > 0 URL : https://patchwork.freedesktop.org/series/112237/ State : success == Summary == CI Bug Log - changes from CI_DRM_12526 -> Patchwork_112237v1 Summary --- *

Re: [Intel-gfx] [PATCH] drm/i915/dsi: fix MIPI_BKLT_EN_1 native GPIO index

2022-12-27 Thread Jani Nikula
On Tue, 20 Dec 2022, Ville Syrjälä wrote: > On Tue, Dec 20, 2022 at 04:01:05PM +0200, Jani Nikula wrote: >> Due to copy-paste fail, MIPI_BKLT_EN_1 would always use PPS index 1, >> never 0. Fix the sloppiest commit in recent memory. >> >> Fixes: f087cfe6fcff ("drm/i915/dsi: add support for ICL+ na