Re: [Intel-gfx] [PATCH 1/2] drm/i915: Allow error capture without a request

2022-12-16 Thread John Harrison
On 12/12/2022 17:52, Umesh Nerlige Ramappa wrote: On Tue, Nov 29, 2022 at 01:12:52PM -0800, john.c.harri...@intel.com wrote: From: John Harrison There was a report of error captures occurring without any hung context being indicated despite the capture being initiated by a 'hung context not

Re: [Intel-gfx] [PATCH 1/3] drm/display/dp_mst: Fix down/up message handling after sink disconnect

2022-12-16 Thread Jani Nikula
On Fri, 16 Dec 2022, Imre Deak wrote: > On Fri, Dec 16, 2022 at 06:10:39PM +0200, Jani Nikula wrote: >> On Fri, 16 Dec 2022, Imre Deak wrote: >> > On Wed, Dec 14, 2022 at 04:41:42PM -0500, Lyude Paul wrote: >> >> For the whole series: >> >> >> >> Reviewed-by: Lyude Paul >> > >> > Thanks for the

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display/vlv: use intel_de_rmw if possible

2022-12-16 Thread Patchwork
== Series Details == Series: drm/i915/display/vlv: use intel_de_rmw if possible URL : https://patchwork.freedesktop.org/series/112001/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12511_full -> Patchwork_112001v1_full Summ

Re: [Intel-gfx] [PATCH] drm/i915: Use helper func to find out map type

2022-12-16 Thread Das, Nirmoy
On 12/16/2022 4:59 PM, Andrzej Hajda wrote: On 16.12.2022 16:43, Matthew Auld wrote: On 16/12/2022 15:27, Nirmoy Das wrote: Use i915_coherent_map_type() function to find out map_type of the shmem obj. Signed-off-by: Nirmoy Das ---   drivers/gpu/drm/i915/gt/shmem_utils.c | 7 +--   1 file

Re: [Intel-gfx] [PATCH 1/3] drm/display/dp_mst: Fix down/up message handling after sink disconnect

2022-12-16 Thread Imre Deak
On Fri, Dec 16, 2022 at 06:10:39PM +0200, Jani Nikula wrote: > On Fri, 16 Dec 2022, Imre Deak wrote: > > On Wed, Dec 14, 2022 at 04:41:42PM -0500, Lyude Paul wrote: > >> For the whole series: > >> > >> Reviewed-by: Lyude Paul > > > > Thanks for the review, pushed it to drm-misc-next. > > Hmm, w

Re: [Intel-gfx] [PATCH 1/3] drm/display/dp_mst: Fix down/up message handling after sink disconnect

2022-12-16 Thread Jani Nikula
On Fri, 16 Dec 2022, Imre Deak wrote: > On Wed, Dec 14, 2022 at 04:41:42PM -0500, Lyude Paul wrote: >> For the whole series: >> >> Reviewed-by: Lyude Paul > > Thanks for the review, pushed it to drm-misc-next. Hmm, with the drm-misc *not* cherry-picking patches from drm-misc-next to drm-misc-fi

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: ratelimit errors in display engine irq (rev2)

2022-12-16 Thread Patchwork
== Series Details == Series: drm/i915: ratelimit errors in display engine irq (rev2) URL : https://patchwork.freedesktop.org/series/111951/ State : success == Summary == CI Bug Log - changes from CI_DRM_12511_full -> Patchwork_111951v2_full

[Intel-gfx] [PATCH v6 12/12] drm/i915/panel: move panel fixed EDID to struct intel_panel

2022-12-16 Thread Jani Nikula
It's a bit confusing to have two cached EDIDs in struct intel_connector with slightly different purposes. Make the distinction a bit clearer by moving the EDID cached for eDP and LVDS panels at connector init time to struct intel_panel, and name it fixed_edid. That's what it is, a fixed EDID for th

[Intel-gfx] [PATCH v6 10/12] drm/i915/bios: convert intel_bios_init_panel() to drm_edid

2022-12-16 Thread Jani Nikula
Try to use struct drm_edid where possible, even if having to fall back to looking into struct edid down low via drm_edid_raw(). v2: Rebase Cc: Imre Deak Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bios.c | 23 --- drivers/gpu/drm/i91

[Intel-gfx] [PATCH v6 11/12] drm/i915/opregion: convert intel_opregion_get_edid() to struct drm_edid

2022-12-16 Thread Jani Nikula
Simplify validation and use by converting to drm_edid. Cc: Imre Deak Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp.c | 10 ++- drivers/gpu/drm/i915/display/intel_opregion.c | 29 +++ drivers/gpu/drm/i915/display/intel_opregion.

[Intel-gfx] [PATCH v6 09/12] drm/i915/edid: convert DP, HDMI and LVDS to drm_edid

2022-12-16 Thread Jani Nikula
Convert all the connectors that use cached connector edid and detect_edid to drm_edid. Since drm_get_edid() calls drm_connector_update_edid_property() while drm_edid_read*() do not, we need to call drm_edid_connector_update() separately, in part due to the EDID caching behaviour in HDMI and DP. Es

[Intel-gfx] [PATCH v6 03/12] drm/edid: rename struct drm_display_info *display to *info

2022-12-16 Thread Jani Nikula
Rename the local variable to info for consistency. Cc: Imre Deak Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index d3ce559e0dfa..f

[Intel-gfx] [PATCH v6 07/12] drm/edid: add separate drm_edid_connector_add_modes()

2022-12-16 Thread Jani Nikula
The original goal with drm_edid_connector_update() was to have a single call for updating the connector and adding probed modes, in this order, but that turned out to be problematic. Drivers that need to update the connector in the .detect() callback would end up updating the probed modes as well.

[Intel-gfx] [PATCH v6 08/12] drm/edid: remove redundant _drm_connector_update_edid_property()

2022-12-16 Thread Jani Nikula
Realize that drm_edid_connector_update() and _drm_connector_update_edid_property() are now the same thing. Drop the latter. Cc: Imre Deak Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) dif

[Intel-gfx] [PATCH v6 05/12] drm/edid: move EDID BPC quirk application to update_display_info()

2022-12-16 Thread Jani Nikula
The BPC quirks are closer to home in update_display_info(). Cc: Imre Deak Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/dr

[Intel-gfx] [PATCH v6 06/12] drm/edid: refactor _drm_edid_connector_update() and rename

2022-12-16 Thread Jani Nikula
By moving update_display_info() out of _drm_edid_connector_update() we make the function purely about adding modes. Rename accordingly. Cc: Imre Deak Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 25 - 1 file changed, 12 insertions(+), 13

[Intel-gfx] [PATCH v6 04/12] drm/edid: merge ELD handling to update_display_info()

2022-12-16 Thread Jani Nikula
Simplify display info update by merging ELD handling as well as clearing of the data in update_display_info(). Cc: Imre Deak Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --

[Intel-gfx] [PATCH v6 02/12] drm/edid: stop passing quirks around

2022-12-16 Thread Jani Nikula
Now that quirks are stored in display info, we can just look them up using the connector instead of having to pass them around. Cc: Imre Deak Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 34 +++--- 1 file changed, 15 insertions(+), 1

[Intel-gfx] [PATCH v6 01/12] drm/edid: store quirks in display info

2022-12-16 Thread Jani Nikula
Although the quirks are internal to EDID parsing, it'll be helpful to store them in display info to avoid having to pass them around. This will also help separate adding probed modes (which needs the quirks) from updating display info. Cc: Imre Deak Cc: Ville Syrjälä Signed-off-by: Jani Nikula

[Intel-gfx] [PATCH v6 00/12] drm/edid, drm/i915: further drm_edid work, finally switch i915 over

2022-12-16 Thread Jani Nikula
The drm_edid handling still needed some plumbing in drm_edid.c before we could convert i915 over to use it. Specifically drm_edid_connector_update() needed to be split to two, with separate drm_edid_connector_add_modes(). This is better explained in patch 7 commit message. With that in patches 1-8

Re: [Intel-gfx] [PATCH] drm/i915: Use helper func to find out map type

2022-12-16 Thread Andrzej Hajda
On 16.12.2022 16:43, Matthew Auld wrote: On 16/12/2022 15:27, Nirmoy Das wrote: Use i915_coherent_map_type() function to find out map_type of the shmem obj. Signed-off-by: Nirmoy Das ---   drivers/gpu/drm/i915/gt/shmem_utils.c | 7 +--   1 file changed, 5 insertions(+), 2 deletions(-) diff

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dsb: DSB fixes/cleanups

2022-12-16 Thread Patchwork
== Series Details == Series: drm/i915/dsb: DSB fixes/cleanups URL : https://patchwork.freedesktop.org/series/111997/ State : success == Summary == CI Bug Log - changes from CI_DRM_12511_full -> Patchwork_111997v1_full Summary --- **S

Re: [Intel-gfx] [PATCH] drm/i915: Use helper func to find out map type

2022-12-16 Thread Matthew Auld
On 16/12/2022 15:27, Nirmoy Das wrote: Use i915_coherent_map_type() function to find out map_type of the shmem obj. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gt/shmem_utils.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/shmem_uti

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mtl: Add initial gt workarounds

2022-12-16 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add initial gt workarounds URL : https://patchwork.freedesktop.org/series/111994/ State : success == Summary == CI Bug Log - changes from CI_DRM_12511_full -> Patchwork_111994v1_full Summary --

[Intel-gfx] [PATCH] drm/i915: Use helper func to find out map type

2022-12-16 Thread Nirmoy Das
Use i915_coherent_map_type() function to find out map_type of the shmem obj. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gt/shmem_utils.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/shmem_utils.c b/drivers/gpu/drm/i915/gt/shmem_utils

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hwmon: Display clamped PL1 limit (rev2)

2022-12-16 Thread Patchwork
== Series Details == Series: drm/i915/hwmon: Display clamped PL1 limit (rev2) URL : https://patchwork.freedesktop.org/series/111981/ State : success == Summary == CI Bug Log - changes from CI_DRM_12511_full -> Patchwork_111981v2_full Summar

Re: [Intel-gfx] [PATCH 1/3] drm/display/dp_mst: Fix down/up message handling after sink disconnect

2022-12-16 Thread Imre Deak
On Wed, Dec 14, 2022 at 04:41:42PM -0500, Lyude Paul wrote: > For the whole series: > > Reviewed-by: Lyude Paul Thanks for the review, pushed it to drm-misc-next. > Thanks! > > On Wed, 2022-12-14 at 20:42 +0200, Imre Deak wrote: > > If the sink gets disconnected during receiving a multi-packet

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/dp_mst: log when pulling CRTCs into atomic state

2022-12-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dp_mst: log when pulling CRTCs into atomic state URL : https://patchwork.freedesktop.org/series/111967/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12510_full -> Patchwork_111967v1_full ===

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display/fdi: use intel_de_rmw if possible

2022-12-16 Thread Patchwork
== Series Details == Series: drm/i915/display/fdi: use intel_de_rmw if possible URL : https://patchwork.freedesktop.org/series/111964/ State : success == Summary == CI Bug Log - changes from CI_DRM_12510_full -> Patchwork_111964v1_full Summ

[Intel-gfx] ✓ Fi.CI.IGT: success for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-12-16 Thread Patchwork
== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/111963/ State : success == Summary == CI Bug Log - changes from CI_DRM_12510_full -> Patchwork_1119

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp: wait on timeout before retry include sw delay (rev8)

2022-12-16 Thread Patchwork
== Series Details == Series: drm/i915/dp: wait on timeout before retry include sw delay (rev8) URL : https://patchwork.freedesktop.org/series/111303/ State : success == Summary == CI Bug Log - changes from CI_DRM_12510_full -> Patchwork_111303v8_full ===

[Intel-gfx] [PATCH v2] drm/i915: improve the catch-all evict to handle lock contention

2022-12-16 Thread Matthew Auld
The catch-all evict can fail due to object lock contention, since it only goes as far as trylocking the object, due to us already holding the vm->mutex. Doing a full object lock here can deadlock, since the vm->mutex is always our inner lock. Add another execbuf pass which drops the vm->mutex and t

Re: [Intel-gfx] [PATCH] drm/i915/display/vlv: use intel_de_rmw if possible

2022-12-16 Thread Jani Nikula
On Fri, 16 Dec 2022, Andrzej Hajda wrote: > The helper makes the code more compact and readable. > > Signed-off-by: Andrzej Hajda [snip] > @@ -649,23 +611,18 @@ static void intel_dsi_port_enable(struct intel_encoder > *encoder, > enum port port; > > if (intel_dsi->dual_link == DS

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/vlv: use intel_de_rmw if possible

2022-12-16 Thread Patchwork
== Series Details == Series: drm/i915/display/vlv: use intel_de_rmw if possible URL : https://patchwork.freedesktop.org/series/112001/ State : success == Summary == CI Bug Log - changes from CI_DRM_12511 -> Patchwork_112001v1 Summary --

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove __maybe_unused from used

2022-12-16 Thread Patchwork
== Series Details == Series: drm/i915: Remove __maybe_unused from used URL : https://patchwork.freedesktop.org/series/111945/ State : success == Summary == CI Bug Log - changes from CI_DRM_12506_full -> Patchwork_111945v1_full Summary -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/vlv: use intel_de_rmw if possible

2022-12-16 Thread Patchwork
== Series Details == Series: drm/i915/display/vlv: use intel_de_rmw if possible URL : https://patchwork.freedesktop.org/series/112001/ State : warning == Summary == Error: dim checkpatch failed f050618851c7 drm/i915/display/vlv: use intel_de_rmw if possible -:48: WARNING:LINE_SPACING: Missing

[Intel-gfx] [PATCH] drm/i915/display/vlv: use intel_de_rmw if possible

2022-12-16 Thread Andrzej Hajda
The helper makes the code more compact and readable. Signed-off-by: Andrzej Hajda --- Hi all, Here is another set of refactoring read/modify/write registers. I have split it to smaller chunks to make the review and patch preparation process less painful - cocci script do the most importan work,

Re: [Intel-gfx] [PATCH v4] drm/i915/mtl: Initial display workarounds

2022-12-16 Thread Tvrtko Ursulin
On 13/12/2022 21:53, Matt Roper wrote: On Tue, Dec 13, 2022 at 11:45:37AM +, Tvrtko Ursulin wrote: On 09/12/2022 22:49, Matt Roper wrote: On Fri, Dec 09, 2022 at 02:05:43PM -0800, Matt Atwood wrote: From: Jouni Högander This patch introduces initial workarounds for mtl platform v2: s

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/display/dp_mst: Fix down/up message handling after sink disconnect

2022-12-16 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/display/dp_mst: Fix down/up message handling after sink disconnect URL : https://patchwork.freedesktop.org/series/111943/ State : success == Summary == CI Bug Log - changes from CI_DRM_12506_full -> Patchwork_111943v1_full ==