[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix VLV/CHV HDMI/DP audio enable

== Series Details == Series: drm/i915: Fix VLV/CHV HDMI/DP audio enable URL : https://patchwork.freedesktop.org/series/111749/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12478_full -> Patchwork_111749v1_full Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v11,1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915

== Series Details == Series: series starting with [v11,1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915 URL : https://patchwork.freedesktop.org/series/111760/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12479 -> Patchwork_111760v1 ==

Re: [Intel-gfx] [PATCH v2 2/6] drm/i915/gsc: Skip the version check when fetching the GSC FW

On Mon, 2022-12-05 at 17:19 -0800, Ceraolo Spurio, Daniele wrote: > The current exectation from the FW side is that the driver will query > the GSC FW version after the FW is loaded, similarly to what the mei > driver does on DG2. However, we're discussing with the FW team if there > is a way to e

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v11,1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915

== Series Details == Series: series starting with [v11,1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915 URL : https://patchwork.freedesktop.org/series/111760/ State : warning == Summary == Error: dim checkpatch failed 5234a61c73e9 drm/i915/pxp: Promote pxp subsystem to top-level

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: fix TLB invalidation for Gen12.50 video and compute engines

== Series Details == Series: series starting with [1/2] drm/i915: fix TLB invalidation for Gen12.50 video and compute engines URL : https://patchwork.freedesktop.org/series/111744/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12478_full -> Patchwork_111744v1_full ===

[Intel-gfx] [PATCH v11 1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915

Starting with MTL, there will be two GT-tiles, a render and media tile. PXP as a service for supporting workloads with protected contexts and protected buffers can be subscribed by process workloads on any tile. However, depending on the platform, only one of the tiles is used for control events pe

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915/uc: Introduce GSC FW

On Mon, 2022-12-05 at 17:19 -0800, Ceraolo Spurio, Daniele wrote: > On MTL the GSC FW needs to be loaded on the media GT by the graphics > driver. We're going to treat it like a new uc_fw, so add the initial > defs and init/fini functions for it. > > Similarly to the other FWs, the GSC FW path can

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: switch to intel_de_* register accessors (rev2)

== Series Details == Series: drm/i915/display: switch to intel_de_* register accessors (rev2) URL : https://patchwork.freedesktop.org/series/111281/ State : success == Summary == CI Bug Log - changes from CI_DRM_12478_full -> Patchwork_111281v2_full

Re: [Intel-gfx] [PATCH v3] drm/i915/mtl: Initial display workarounds

On Wed, Dec 07, 2022 at 04:01:31PM -0800, Matt Atwood wrote: > From: Jouni Högander > > This patch introduces initial workarounds for mtl platform > > v2: switch IS_MTL_DISPLAY_STEP to use IS_METEORLAKE from testing display > ver. (Tvrtko) > > v3: clerical issues, extend 16015201720 to mtl. >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Initial display workarounds (rev2)

== Series Details == Series: drm/i915/mtl: Initial display workarounds (rev2) URL : https://patchwork.freedesktop.org/series/111592/ State : success == Summary == CI Bug Log - changes from CI_DRM_12478 -> Patchwork_111592v2 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mtl: Initial display workarounds (rev2)

== Series Details == Series: drm/i915/mtl: Initial display workarounds (rev2) URL : https://patchwork.freedesktop.org/series/111592/ State : warning == Summary == Error: dim checkpatch failed c61271d2a119 drm/i915/mtl: Initial display workarounds -:154: CHECK:MACRO_ARG_REUSE: Macro argument re

[Intel-gfx] [PATCH v3] drm/i915/mtl: Initial display workarounds

From: Jouni Högander This patch introduces initial workarounds for mtl platform v2: switch IS_MTL_DISPLAY_STEP to use IS_METEORLAKE from testing display ver. (Tvrtko) v3: clerical issues, extend 16015201720 to mtl. Bspec: 66624 Signed-off-by: Matt Atwood Signed-off-by: Jouni Högander --- d

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix VLV/CHV HDMI/DP audio enable

== Series Details == Series: drm/i915: Fix VLV/CHV HDMI/DP audio enable URL : https://patchwork.freedesktop.org/series/111749/ State : success == Summary == CI Bug Log - changes from CI_DRM_12478 -> Patchwork_111749v1 Summary --- **S

[Intel-gfx] [PATCH] drm/i915: Fix VLV/CHV HDMI/DP audio enable

From: Ville Syrjälä Despite what I claimed in commit c3c5dc1d9224 ("drm/i915/audio: Do the vblank waits") the vblank interrupts are in fact not enabled yet when we do the audio enable sequence on VLV/CHV (all other platforms are fine). Reorder the enable sequence on VLV/CHV to match that of the

Re: [Intel-gfx] [PATCH v9 1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915

On Wed, 2022-12-07 at 13:46 +, Tvrtko Ursulin wrote: > [Side note - your email client somehow manages to make a mess of line wraps > so after a few replies it is super hard to follow the quote. Don't know > how/what/why but I don't have this problem on the mailing list with other > folks so

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/vrr: VRR fixes (rev2)

== Series Details == Series: drm/i915/vrr: VRR fixes (rev2) URL : https://patchwork.freedesktop.org/series/111585/ State : success == Summary == CI Bug Log - changes from CI_DRM_12477_full -> Patchwork_111585v2_full Summary --- **SUC

Re: [Intel-gfx] [Patch v2] drm/i915/mtl: Initial display workarounds

On Fri, Dec 02, 2022 at 11:00:29AM -0800, Matt Roper wrote: > On Fri, Dec 02, 2022 at 08:51:43AM -0800, Matt Atwood wrote: > > From: Jouni Högander > > > > This patch introduces initial workarounds for mtl platform > > It looks like this patch is only dealing with workarounds from past > platfor

Re: [Intel-gfx] [PATCH 2/4] drm/i915/vrr: Fix guardband/vblank exit length calculation for adl+

On Wed, Dec 07, 2022 at 01:05:15PM -0800, Navare, Manasi wrote: > On Wed, Dec 07, 2022 at 05:10:54PM +0200, Ville Syrjälä wrote: > > On Mon, Dec 05, 2022 at 12:34:25PM -0800, Navare, Manasi wrote: > > > On Fri, Dec 02, 2022 at 03:44:10PM +0200, Ville Syrjala wrote: > > > > From: Ville Syrjälä > >

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix documentation for intel_uncore_forcewake_put__locked

== Series Details == Series: drm/i915: Fix documentation for intel_uncore_forcewake_put__locked URL : https://patchwork.freedesktop.org/series/111735/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12477_full -> Patchwork_111735v1_full ==

Re: [Intel-gfx] [PATCH 2/4] drm/i915/vrr: Fix guardband/vblank exit length calculation for adl+

On Wed, Dec 07, 2022 at 05:10:54PM +0200, Ville Syrjälä wrote: > On Mon, Dec 05, 2022 at 12:34:25PM -0800, Navare, Manasi wrote: > > On Fri, Dec 02, 2022 at 03:44:10PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > We are miscalculating both the guardband value, and the resulti

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: fix TLB invalidation for Gen12.50 video and compute engines

== Series Details == Series: series starting with [1/2] drm/i915: fix TLB invalidation for Gen12.50 video and compute engines URL : https://patchwork.freedesktop.org/series/111744/ State : success == Summary == CI Bug Log - changes from CI_DRM_12478 -> Patchwork_111744v1 =

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: switch to intel_de_* register accessors (rev2)

== Series Details == Series: drm/i915/display: switch to intel_de_* register accessors (rev2) URL : https://patchwork.freedesktop.org/series/111281/ State : success == Summary == CI Bug Log - changes from CI_DRM_12478 -> Patchwork_111281v2

[Intel-gfx] ✓ Fi.CI.IGT: success for Align DDI_BUF_CTL Active timeouts with Bspec updates (rev5)

== Series Details == Series: Align DDI_BUF_CTL Active timeouts with Bspec updates (rev5) URL : https://patchwork.freedesktop.org/series/111373/ State : success == Summary == CI Bug Log - changes from CI_DRM_12477_full -> Patchwork_111373v5_full =

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/migrate: fix corner case in CCS aux copying

== Series Details == Series: drm/i915/migrate: fix corner case in CCS aux copying URL : https://patchwork.freedesktop.org/series/111730/ State : success == Summary == CI Bug Log - changes from CI_DRM_12477_full -> Patchwork_111730v1_full Su

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915/guc: Add unaligned wc memcpy for copying GuC Log

On Wed, 2022-12-07 at 10:17 +, Tvrtko Ursulin wrote: > Right, Fixes: and cc stable 5.18+ then (for ADL-P), *if* the upstream > logger tool actually works and we expect to asks users to use it. Righ, in that case, will skip the fixes tag since the logger is completely broken today upstream a

Re: [Intel-gfx] [PATCH 3/4] drm/i915/mtl: Define new PTE encode for MTL

On Wed, Dec 07, 2022 at 12:56:44PM +0530, Iddamsetty, Aravind wrote: > > > On 07-12-2022 05:09, Matt Roper wrote: > > On Tue, Dec 06, 2022 at 01:07:28PM +0530, Aravind Iddamsetty wrote: > >> Add a separate PTE encode function for MTL. The number of PAT registers > >> have increased to 16 on MTL.

[Intel-gfx] [PATCH 2/2] drm/i915: cleanup TLB invalidation code

Whole register/bit selection logic has been moved to separate helper. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/gt/intel_gt.c | 136 +++-- 1 file changed, 51 insertions(+), 85 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i91

[Intel-gfx] [PATCH 1/2] drm/i915: fix TLB invalidation for Gen12.50 video and compute engines

In case of Gen12.50 video and compute engines, TLB_INV registers are masked - to modify one bit, corresponding bit in upper half of the register must be enabled, otherwise nothing happens. Fixes: 77fa9efc16a9 ("drm/i915/xehp: Create separate reg definitions for new MCR registers") Signed-off-by:

Re: [Intel-gfx] [PATCH v2 5/5] drm/i915/guc: Move guc_log_relay_chan debugfs path to uc

On Tue, 06 Dec 2022 01:21:00 -0800, Alan Previn wrote: > > All other GuC Relay Logging debugfs handles including recent > additions are under the 'i915/gt/uc/path' so let's also move > 'guc_log_relay_chan' to its proper home. > > Signed-off-by: Alan Previn > --- > drivers/gpu/drm/i915/gt/uc/intel

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915/backlight: drop DISPLAY_MMIO_BASE() use from backlight registers

On Wed, 07 Dec 2022, Rodrigo Vivi wrote: > On Wed, Dec 07, 2022 at 11:34:43AM +0200, Jani Nikula wrote: >> None of the remaining backlight registers that use DISPLAY_MMIO_BASE() >> are used on VLV/CHV, which are the only platforms that have non-zero >> base. Just drop the DISPLAY_MMIO_BASE() use,

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/vrr: VRR fixes (rev2)

== Series Details == Series: drm/i915/vrr: VRR fixes (rev2) URL : https://patchwork.freedesktop.org/series/111585/ State : success == Summary == CI Bug Log - changes from CI_DRM_12477 -> Patchwork_111585v2 Summary --- **SUCCESS**

[Intel-gfx] [PATCH v2 10/11] drm/i915/snps: switch to intel_de_* register accessors in display code

Avoid direct uncore use in display code. Cc: Maarten Lankhorst Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_snps_phy.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_snps_phy.c b/drivers/gpu/drm/i915/d

[Intel-gfx] [PATCH v2 11/11] drm/i915/tc: switch to intel_de_* register accessors in display code

Avoid direct uncore use in display code. Cc: Maarten Lankhorst Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_tc.c | 55 - 1 file changed, 18 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/d

[Intel-gfx] [PATCH v2 09/11] drm/i915/wm: switch to intel_de_* register accessors in display code

Avoid direct uncore use in display code. Cc: Maarten Lankhorst Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/skl_watermark.c | 42 +--- 1 file changed, 18 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/drm/i

[Intel-gfx] [PATCH v2 08/11] drm/i915/gmbus: switch to intel_de_* register accessors in display code

Avoid direct uncore use in display code. Cc: Maarten Lankhorst Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_gmbus.c | 46 -- 1 file changed, 17 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i91

[Intel-gfx] [PATCH v2 07/11] drm/i915/dp-aux: switch to intel_de_* register accessors in display code

Avoid direct uncore use in display code. Cc: Maarten Lankhorst Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp_aux.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i9

[Intel-gfx] [PATCH v2 06/11] drm/i915/dmc: switch to intel_de_* register accessors in display code

Avoid direct uncore use in display code. Cc: Maarten Lankhorst Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dmc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c i

[Intel-gfx] [PATCH v2 05/11] drm/i915/power: switch to intel_de_* register accessors in display code

Avoid direct uncore use in display code. Cc: Maarten Lankhorst Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH v2 04/11] drm/i915/crt: switch to intel_de_* register accessors in display code

Avoid direct uncore use in display code. Cc: Maarten Lankhorst Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_crt.c | 42 +++- 1 file changed, 19 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_crt.c b/drivers/gpu/drm/i915/

[Intel-gfx] [PATCH v2 03/11] drm/i915/crt: drop a bunch of unnecessary register variables

There's no need to save the register offsets. Drop the variables. Cc: Maarten Lankhorst Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_crt.c | 39 +--- 1 file changed, 15 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_crt.c

[Intel-gfx] [PATCH v2 02/11] drm/i915/de: return the old register value from intel_de_rmw()

A similar thing was added in intel_uncore_rmw(). Make it available for display too. Cc: Maarten Lankhorst Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_de.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_de.h b/dri

[Intel-gfx] [PATCH v2 01/11] drm/i915/de: Add more macros to remove all direct calls to uncore

From: Maarten Lankhorst Add more de helpers to be able to avoid direct calls to uncore. v3 by Jani: - drop intel_de_write_samevalue/intel_de_rewrite_fw altogether v2 by Jani: - drop pcode stuff for now - rename intel_de_write_samevalue -> intel_de_rewrite_fw Signed-off-by: Maarten Lankhorst S

[Intel-gfx] [PATCH v2 00/11] drm/i915/display: switch to intel_de_* register accessors

v2 of https://patchwork.freedesktop.org/series/111281/ Drop the dubious intel_de_rewrite_fw() thing. Jani Nikula (10): drm/i915/de: return the old register value from intel_de_rmw() drm/i915/crt: drop a bunch of unnecessary register variables drm/i915/crt: switch to intel_de_* register acce

Re: [Intel-gfx] [PATCH] drm/i915/fbc: drop uncore locking around i8xx/i965 fbc nuke

On Wed, 07 Dec 2022, Ville Syrjälä wrote: > On Mon, Dec 05, 2022 at 02:29:18PM +0200, Jani Nikula wrote: >> The locking should not be needed after commits de5bd083d247 >> ("drm/i915/fbc: Skip nuke when flip is pending") and 7cfd1a18c5f9 >> ("drm/i915: Remove remaining locks from i9xx plane udpates

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/vrr: VRR fixes (rev2)

== Series Details == Series: drm/i915/vrr: VRR fixes (rev2) URL : https://patchwork.freedesktop.org/series/111585/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:117:1: warn

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Rename GuC log relay debugfs descriptively

On Tue, 06 Dec 2022 01:20:59 -0800, Alan Previn wrote: > > GuC log relay debugfs name for the control handle vs the actual relay > channel are vague. Fix them so it's obvious from the name. No real objection to anything here, just a couple of questions. > > Signed-off-by: Alan Previn > --- > dr

[Intel-gfx] [PATCH i-g-t v3 1/2] lib/dmabuf_sync_file: move common stuff into lib

So we can use this across different tests. v2 - Add docs for everything (Petri) - Add missing copyright and fix headers slightly (Kamil) v3: - Just return true/false, for the has() family of functions, instead of tripping up an assert() (Kamil) Signed-off-by: Matthew Auld Cc: Kamil Kon

[Intel-gfx] [PATCH i-g-t v3 2/2] tests/i915/gem_exec_balancer: exercise dmabuf import

With parallel submission it should be easy to get a fence array as the output fence. Try importing this into dma-buf reservation object, to see if anything explodes. v2: (Kamil) - Use ifdef __linux__ for linux headers - Add igt_describe() for new test References: https://gitlab.freedesktop.org/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix documentation for intel_uncore_forcewake_put__locked

== Series Details == Series: drm/i915: Fix documentation for intel_uncore_forcewake_put__locked URL : https://patchwork.freedesktop.org/series/111735/ State : success == Summary == CI Bug Log - changes from CI_DRM_12477 -> Patchwork_111735v1

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915/guc: Provide debugfs for log relay sub-buf info

On Tue, 06 Dec 2022 01:20:58 -0800, Alan Previn wrote: > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.c > b/drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.c > index ddfbe334689f..27756640338e 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.c > +++ b/drivers/gpu

Re: [Intel-gfx] [PATCH] drm/i915/gsc: GSC firmware loading

On 12/7/2022 2:16 AM, Teres Alexis, Alan Previn wrote: Diffed the patches and reviewed the changes -- i.e. the use of the worker for the gsc fw loading cmd submission. All looks good - just a few nits below. Reviewed-by: Alan Previn On Mon, 2022-12-05 at 21:15 -0800, Ceraolo Spurio, Daniel

Re: [Intel-gfx] [PATCH v7 2/3] drm/i915/hwmon: Add helper function to obtain energy values

On Wed, 07 Dec 2022 03:21:03 -0800, Riana Tauro wrote: > > Add an interface to obtain hwmon energy values. The function returns > per-gt energy if gt level energy is available else returns the package > level energy if there is a single gt. > This is used by selftests to verify power consumption >

[Intel-gfx] ✓ Fi.CI.BAT: success for Align DDI_BUF_CTL Active timeouts with Bspec updates (rev5)

== Series Details == Series: Align DDI_BUF_CTL Active timeouts with Bspec updates (rev5) URL : https://patchwork.freedesktop.org/series/111373/ State : success == Summary == CI Bug Log - changes from CI_DRM_12477 -> Patchwork_111373v5 Summa

[Intel-gfx] [PATCH] drm/i915: Fix documentation for intel_uncore_forcewake_put__locked

intel_uncore_forcewake_put__locked() is used to release a reference. Fixes: a6111f7b6604 ("drm/i915: Reduce locking in execlist command submission") Signed-off-by: Miaoqian Lin --- drivers/gpu/drm/i915/intel_uncore.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

Re: [Intel-gfx] [PATCH] drm/i915: Fix documentation for intel_uncore_forcewake_put__locked

On Wed, Dec 07, 2022 at 03:29:09PM +0400, Miaoqian Lin wrote: > intel_uncore_forcewake_put__locked() is used to release a reference. > > Fixes: a6111f7b6604 ("drm/i915: Reduce locking in execlist command > submission") > Signed-off-by: Miaoqian Lin Reviewed-by: Rodrigo Vivi and will push this

Re: [Intel-gfx] [PATCH] drm/i915: Remove CONFIG_PM dependency from RC6.

On Wed, Dec 07, 2022 at 02:35:37PM +, Paul Cercueil wrote: > Hi Rodrigo, > > Le mercredi 30 novembre 2022 à 13:37 +, Vivi, Rodrigo a écrit : > > On Wed, 2022-11-30 at 11:47 +, Tvrtko Ursulin wrote: > > > > > > On 30/11/2022 02:29, Rodrigo Vivi wrote: > > > > RC6 is a sleep state that

Re: [Intel-gfx] [PATCH v2 26/26] drm/i915/gt: Remove #ifdef guards for PM related functions

On Tue, Nov 29, 2022 at 07:19:42PM +, Paul Cercueil wrote: > Instead of defining two versions of intel_sysfs_rc6_init(), one for each > value of CONFIG_PM, add a check on !IS_ENABLED(CONFIG_PM) early in the > function. This will allow the compiler to automatically drop the dead > code when CONF

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915/backlight: drop DISPLAY_MMIO_BASE() use from backlight registers

On Wed, Dec 07, 2022 at 11:34:43AM +0200, Jani Nikula wrote: > None of the remaining backlight registers that use DISPLAY_MMIO_BASE() > are used on VLV/CHV, which are the only platforms that have non-zero > base. Just drop the DISPLAY_MMIO_BASE() use, reducing the implicit > dev_priv references. W

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/migrate: fix corner case in CCS aux copying

== Series Details == Series: drm/i915/migrate: fix corner case in CCS aux copying URL : https://patchwork.freedesktop.org/series/111730/ State : success == Summary == CI Bug Log - changes from CI_DRM_12477 -> Patchwork_111730v1 Summary

Re: [Intel-gfx] [PATCH 2/4] drm/i915/vrr: Fix guardband/vblank exit length calculation for adl+

On Mon, Dec 05, 2022 at 12:34:25PM -0800, Navare, Manasi wrote: > On Fri, Dec 02, 2022 at 03:44:10PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We are miscalculating both the guardband value, and the resulting > > vblank exit length on adl+. This means that our start of vblank >

Re: [Intel-gfx] [PATCH 1/4] drm/i915/vrr: Make registers latch in a consitent place on icl/tgl

On Mon, Dec 05, 2022 at 12:13:09PM -0800, Navare, Manasi wrote: > On Fri, Dec 02, 2022 at 03:44:09PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Account for the framestart delay when calculating the "pipeline full" > > value for icl/tgl vrr. This puts the start of vblank (ie. wher

[Intel-gfx] ✗ Fi.CI.BAT: failure for Add hwmon support for dgfx selftests (rev7)

== Series Details == Series: Add hwmon support for dgfx selftests (rev7) URL : https://patchwork.freedesktop.org/series/109850/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12477 -> Patchwork_109850v7 Summary --- **

Re: [Intel-gfx] [PATCH] drm/i915/fbc: drop uncore locking around i8xx/i965 fbc nuke

On Mon, Dec 05, 2022 at 02:29:18PM +0200, Jani Nikula wrote: > The locking should not be needed after commits de5bd083d247 > ("drm/i915/fbc: Skip nuke when flip is pending") and 7cfd1a18c5f9 > ("drm/i915: Remove remaining locks from i9xx plane udpates"). > > Cc: Ville Syrjälä > Signed-off-by: Jan

[Intel-gfx] [PATCH v3 1/2] drm/i915/ddi: Align timeout for DDI_BUF_CTL active with Bspec

For Gen12+ wait for 1ms for Combo Phy and 3ms for TC Phy for DDI_BUF_CTL to be active for TC phy. (Bspec:49190) v2: Minor refactoring for better readability. v3: Rebased and retained the order of checking platforms. (Imre) Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dd

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add hwmon support for dgfx selftests (rev7)

== Series Details == Series: Add hwmon support for dgfx selftests (rev7) URL : https://patchwork.freedesktop.org/series/109850/ State : warning == Summary == Error: dim checkpatch failed f832a593c3b4 drm/i915/selftests: Rename librapl library to libpower Traceback (most recent call last): Fi

Re: [Intel-gfx] [PATCH] drm/i915: Remove CONFIG_PM dependency from RC6.

Hi Rodrigo, Le mercredi 30 novembre 2022 à 13:37 +, Vivi, Rodrigo a écrit : > On Wed, 2022-11-30 at 11:47 +, Tvrtko Ursulin wrote: > > > > On 30/11/2022 02:29, Rodrigo Vivi wrote: > > > RC6 is a sleep state that doesn't depend on the cpu sleep, > > > or any of the APM or ACPI or anything

[Intel-gfx] [PATCH] drm/i915/migrate: fix corner case in CCS aux copying

In the case of lmem -> lmem transfers, which is currently only possible with small-bar systems, we need to ensure we copy the CCS aux state as-is, rather than nuke it. This should fix some nasty visual corruption sometimes seen on DG2 small-bar systems, when also using DG2_RC_CCS_CC for the surface

Re: [Intel-gfx] [PATCH v9 1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915

[Side note - your email client somehow manages to make a mess of line wraps so after a few replies it is super hard to follow the quote. Don't know how/what/why but I don't have this problem on the mailing list with other folks so at least I *think* it is something about your client or it's c

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc: ensure CSB FIFOs after GuC reset do not have odd entries

On 07.12.2022 01:43, Patchwork wrote: *Patch Details* *Series:* drm/i915/guc: ensure CSB FIFOs after GuC reset do not have odd entries *URL:* https://patchwork.freedesktop.org/series/111697/ *State:*failure *Details:* https://intel-gf

Re: [Intel-gfx] [PATCH v9 1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915

On Wed, 2022-12-07 at 10:10 +, Tvrtko Ursulin wrote: > On 06/12/2022 18:26, Teres Alexis, Alan Previn wrote: > > > > > > On Tue, 2022-12-06 at 10:04 +, Tvrtko Ursulin wrote: > > > On 06/12/2022 00:03, Alan Previn wrote: > > > > > > Alan: [snip] > > > > > > > > > > > -struct intel_

Re: [Intel-gfx] [PATCH i-g-t] tests/i915/gem_ctx_persistence: adjust timeout according to engines

On 07/12/2022 11:47, Andrzej Hajda wrote: With introduction of long running compute context preemption timeouts in some engines (rcs and ccs) can be quite big (by default 7.5s). Keeping spinner timeout to at least twice bigger than engines preemption timeout should allow to finish the test with

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/backlight: drop implict dev_priv etc. (rev2)

== Series Details == Series: drm/i915/backlight: drop implict dev_priv etc. (rev2) URL : https://patchwork.freedesktop.org/series/111628/ State : success == Summary == CI Bug Log - changes from CI_DRM_12476_full -> Patchwork_111628v2_full S

Re: [Intel-gfx] [PATCH i-g-t v2 1/2] lib/dmabuf_sync_file: move common stuff into lib

Hi Matt, On 2022-12-05 at 17:11:44 +, Matthew Auld wrote: > On 05/12/2022 16:31, Kamil Konieczny wrote: > > Hi Matt, > > > > after re-reading I have few more nits. > > > > On 2022-12-02 at 12:02:41 +, Matthew Auld wrote: > > > So we can use this across different tests. > > > > > > v2 >

[Intel-gfx] [PATCH i-g-t] tests/i915/gem_ctx_persistence: adjust timeout according to engines

With introduction of long running compute context preemption timeouts in some engines (rcs and ccs) can be quite big (by default 7.5s). Keeping spinner timeout to at least twice bigger than engines preemption timeout should allow to finish the test without -ETIME error. Closes: https://gitlab.free

[Intel-gfx] [PATCH v7 3/3] drm/i915/selftests: Add hwmon support in libpower for dgfx

From: Tilak Tangudu hwmon provides an interface to read energy values for discrete graphics. add hwmon support to the existing libpower library so that it can verify power consumption values in different selftests. Changed prototype of libpower_get_energy_uJ v2: add per-gt hwmon support (Ashuto

[Intel-gfx] [PATCH v7 2/3] drm/i915/hwmon: Add helper function to obtain energy values

Add an interface to obtain hwmon energy values. The function returns per-gt energy if gt level energy is available else returns the package level energy if there is a single gt. This is used by selftests to verify power consumption v2 : use i915_hwmon prefix (Anshuman) v3 : re-use is_visible funct

[Intel-gfx] [PATCH v7 1/3] drm/i915/selftests: Rename librapl library to libpower

Rename librapl files to libpower and replace librapl with libpower prefix. No functional changes v2: update commit message (Anshuman) Signed-off-by: Riana Tauro Reviewed-by: Anshuman Gupta Reviewed-by: Ashutosh Dixit --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm

[Intel-gfx] [PATCH v7 0/3] Add hwmon support for dgfx selftests

Rename librapl library to libpower. Add hwmon support in libpower for dgfx. Use libpower in selftests. Rev2 : Update commit message Rev3 : Remove redundant code Rev4 : Add hwmon per-gt support Rev5 : No functional changes. Change author for last patch Rev6 : re-order libpower library patch

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/backlight: drop implict dev_priv etc. (rev2)

== Series Details == Series: drm/i915/backlight: drop implict dev_priv etc. (rev2) URL : https://patchwork.freedesktop.org/series/111628/ State : success == Summary == CI Bug Log - changes from CI_DRM_12476 -> Patchwork_111628v2 Summary ---

Re: [Intel-gfx] [PATCH 04/13] drm/i915: Clean up various indexed LUT registers

> > > -Original Message- > > From: Intel-gfx On Behalf Of > > Nautiyal, Ankit K > > Sent: Thursday, December 1, 2022 11:16 AM > > To: Ville Syrjala ; > > intel-gfx@lists.freedesktop.org > > Subject: Re: [Intel-gfx] [PATCH 04/13] drm/i915: Clean up various > > indexed LUT registers > > >

Re: [Intel-gfx] [PATCH 12/13] drm/i915: Use ilk_lut_write*() for all ilk+ gamma modes

> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, November 23, 2022 8:57 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 12/13] drm/i915: Use ilk_lut_write*() for all > ilk+ gamma > modes > > From: Ville Syrjälä > > We coul

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915/guc: Add unaligned wc memcpy for copying GuC Log

On 07/12/2022 09:20, Teres Alexis, Alan Previn wrote: On Tue, 2022-12-06 at 21:35 +, Teres Alexis, Alan Previn wrote: On Tue, 2022-12-06 at 10:14 +, Tvrtko Ursulin wrote: On 06/12/2022 09:20, Alan Previn wrote: Add usage of unaligned wc mempy in read_update_log_buffer as newer form

Re: [Intel-gfx] [PATCH] drm/i915/gsc: GSC firmware loading

Diffed the patches and reviewed the changes -- i.e. the use of the worker for the gsc fw loading cmd submission. All looks good - just a few nits below. Reviewed-by: Alan Previn On Mon, 2022-12-05 at 21:15 -0800, Ceraolo Spurio, Daniele wrote: > GSC FW is loaded by submitting a dedicated comman

Re: [Intel-gfx] [PATCH v9 1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915

On 06/12/2022 18:26, Teres Alexis, Alan Previn wrote: On Tue, 2022-12-06 at 10:04 +, Tvrtko Ursulin wrote: On 06/12/2022 00:03, Alan Previn wrote: Alan: [snip] -struct intel_gt *pxp_to_gt(const struct intel_pxp *pxp) +bool intel_pxp_is_supported(const struct intel_pxp *pxp)

Re: [Intel-gfx] [RFC 0/2] drm/connector: connector iterator with filtering

On Tue, 29 Nov 2022, Laurent Pinchart wrote: > Hi Jani, > > On Tue, Nov 29, 2022 at 11:29:45AM +0200, Jani Nikula wrote: >> On Fri, 25 Nov 2022, Harry Wentland wrote: >> > On 10/5/22 06:51, Jani Nikula wrote: >> >> Currently i915 assumes all drm_connectors it encounters are embedded in >> >> inte

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/backlight: drop implict dev_priv etc. (rev2)

== Series Details == Series: drm/i915/backlight: drop implict dev_priv etc. (rev2) URL : https://patchwork.freedesktop.org/series/111628/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/a

Re: [Intel-gfx] [PATCH 11/13] Revert "drm/i915: Disable DSB usage for now"

> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, November 23, 2022 8:57 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 11/13] Revert "drm/i915: Disable DSB usage for > now" > > From: Ville Syrjälä > > This reverts commit

Re: [Intel-gfx] [PATCH 10/13] drm/i915: Disable DSB usage specifically for LUTs

> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, November 23, 2022 8:57 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 10/13] drm/i915: Disable DSB usage specifically > for LUTs > > From: Ville Syrjälä > > The DSB has pro

Re: [Intel-gfx] [PATCH 09/13] drm/i915: Make DSB lower level

> -Original Message- > From: Intel-gfx On Behalf Of > Nautiyal, > Ankit K > Sent: Thursday, December 1, 2022 11:52 AM > To: Ville Syrjala ; > intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 09/13] drm/i915: Make DSB lower level > > Patch looks good to me. > > There

Re: [Intel-gfx] [PATCH 1/5] drm/i915/backlight: use VLV_DISPLAY_BASE for VLV/CHV backlight registers

On Mon, 05 Dec 2022, Rodrigo Vivi wrote: > On Mon, Dec 05, 2022 at 04:17:16PM +0200, Jani Nikula wrote: >> On Mon, 05 Dec 2022, Jani Nikula wrote: >> > Since the VLV/CHV backlight registers are only used on VLV/CHV, there's >> > no need to dynamically look up DISPLAY_MMIO_BASE(). We know it's >>

[Intel-gfx] [PATCH v2 5/5] drm/i915/backlight: convert DRM_DEBUG_KMS() to drm_dbg_kms()

Fix the final straggler. Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/display/intel_backlight.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_backlight.c b/drivers/gpu/drm/i915/display/intel_backlight

[Intel-gfx] [PATCH v2 4/5] drm/i915/backlight: drop drm_device local variables in favor of i915

Prefer only having struct drm_i915_private *i915 around. Drop the drm_device *dev locals. Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi # v1 --- .../gpu/drm/i915/display/intel_backlight.c| 22 +-- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers

[Intel-gfx] [PATCH v2 3/5] drm/i915/backlight: mass rename dev_priv to i915

With the implicit dev_priv usage gone, we can rename dev_priv to i915 throughout. Do some drive-by whitespace cleanups while at it. Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi # v1 --- .../gpu/drm/i915/display/intel_backlight.c| 517 +- 1 file changed, 248 insertion

[Intel-gfx] [PATCH v2 2/5] drm/i915/backlight: drop DISPLAY_MMIO_BASE() use from backlight registers

None of the remaining backlight registers that use DISPLAY_MMIO_BASE() are used on VLV/CHV, which are the only platforms that have non-zero base. Just drop the DISPLAY_MMIO_BASE() use, reducing the implicit dev_priv references. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_ba

[Intel-gfx] [PATCH v2 1/5] drm/i915/backlight: use VLV_DISPLAY_BASE for VLV/CHV backlight registers

Since the VLV/CHV backlight registers are only used on VLV/CHV, there's no need to dynamically look up DISPLAY_MMIO_BASE(). We know it's VLV_DISPLAY_BASE. Use it statically, reducing the implicit dev_priv references. Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi --- .../drm/i915/display/

[Intel-gfx] [PATCH v2 0/5] drm/i915/backlight: drop implict dev_priv etc.

v2 of https://patchwork.freedesktop.org/series/111628/ replacing patch 2 with a much simpler approach of completely dropping the DISPLAY_MMIO_BASE() and dev_priv usage. Jani Nikula (5): drm/i915/backlight: use VLV_DISPLAY_BASE for VLV/CHV backlight registers drm/i915/backlight: drop DISPLA

Re: [Intel-gfx] [PATCH 08/13] drm/i915: Move the DSB setup/cleaup into the color code

> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, November 23, 2022 8:57 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 08/13] drm/i915: Move the DSB setup/cleaup into > the > color code > > From: Ville Syrjälä > > Since t

[Intel-gfx] ✗ Fi.CI.IGT: failure for Add hwmon support for dgfx selftests (rev6)

== Series Details == Series: Add hwmon support for dgfx selftests (rev6) URL : https://patchwork.freedesktop.org/series/109850/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12476_full -> Patchwork_109850v6_full Summary ---

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915/guc: Add unaligned wc memcpy for copying GuC Log

On Tue, 2022-12-06 at 21:35 +, Teres Alexis, Alan Previn wrote: > On Tue, 2022-12-06 at 10:14 +, Tvrtko Ursulin wrote: > > On 06/12/2022 09:20, Alan Previn wrote: > > > Add usage of unaligned wc mempy in read_update_log_buffer > > > as newer formats of GuC debug-log-events are no longer >

Re: [Intel-gfx] [PATCH 07/13] drm/i915: Move the DSB->mmio fallback into the LUT code

> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, November 23, 2022 8:57 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 07/13] drm/i915: Move the DSB->mmio fallback into > the > LUT code > > From: Ville Syrjälä > > The use

  1   2   >