[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/mtl: Initial display workarounds

2022-12-02 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Initial display workarounds URL : https://patchwork.freedesktop.org/series/111592/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12463_full -> Patchwork_111592v1_full Summary -

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hwmon: Silence "mailbox access failed" warning in snb_pcode_read

2022-12-02 Thread Patchwork
== Series Details == Series: drm/i915/hwmon: Silence "mailbox access failed" warning in snb_pcode_read URL : https://patchwork.freedesktop.org/series/111599/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12463 -> Patchwork_111599v1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/hwmon: Silence "mailbox access failed" warning in snb_pcode_read

2022-12-02 Thread Patchwork
== Series Details == Series: drm/i915/hwmon: Silence "mailbox access failed" warning in snb_pcode_read URL : https://patchwork.freedesktop.org/series/111599/ State : warning == Summary == Error: dim checkpatch failed 941c63ebf808 drm/i915/hwmon: Silence "mailbox access failed" warning in snb

[Intel-gfx] [PATCH] drm/i915/hwmon: Silence "mailbox access failed" warning in snb_pcode_read

2022-12-02 Thread Ashutosh Dixit
hwm_pcode_read_i1 is called during i915 load. This results in the following warning from snb_pcode_read because POWER_SETUP_SUBCOMMAND_READ_I1 is unsupported on DG1/DG2. [drm:snb_pcode_read [i915]] warning: pcode (read from mbox 47c) \ mailbox access failed for snb_

[Intel-gfx] ✗ Fi.CI.IGT: failure for add guard padding around i915_vma (rev7)

2022-12-02 Thread Patchwork
== Series Details == Series: add guard padding around i915_vma (rev7) URL : https://patchwork.freedesktop.org/series/110720/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12462_full -> Patchwork_110720v7_full Summary --

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: enable GuC GGTT invalidation from the start (rev2)

2022-12-02 Thread Patchwork
== Series Details == Series: drm/i915/guc: enable GuC GGTT invalidation from the start (rev2) URL : https://patchwork.freedesktop.org/series/110772/ State : success == Summary == CI Bug Log - changes from CI_DRM_12463 -> Patchwork_110772v2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/guc: enable GuC GGTT invalidation from the start (rev2)

2022-12-02 Thread Patchwork
== Series Details == Series: drm/i915/guc: enable GuC GGTT invalidation from the start (rev2) URL : https://patchwork.freedesktop.org/series/110772/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [RFC 0/7] drm/i915/pxp: Create a backend abstraction layer for pxp-tee-link

2022-12-02 Thread Teres Alexis, Alan Previn
++Rodrigo, Daniele, Jani. Hey folks - any concerns with this approach? i915->pxp--->[feature functions] |---> [tee-backends-folder] |--->mei-pxp transport functions (legacy) |--->gsccs transport functions (mtl+) tee backend folder basi

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v8,1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915

2022-12-02 Thread Patchwork
== Series Details == Series: series starting with [v8,1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915 URL : https://patchwork.freedesktop.org/series/111598/ State : success == Summary == CI Bug Log - changes from CI_DRM_12463 -> Patchwork_111598v1 ===

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v8,1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915

2022-12-02 Thread Patchwork
== Series Details == Series: series starting with [v8,1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915 URL : https://patchwork.freedesktop.org/series/111598/ State : warning == Summary == Error: dim checkpatch failed bdc87ed76da1 drm/i915/pxp: Promote pxp subsystem to top-level o

[Intel-gfx] [PATCH v8 1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915

2022-12-02 Thread Alan Previn
Starting with MTL, there will be two GT-tiles, a render and media tile. PXP as a service for supporting workloads with protected contexts and protected buffers can be subscribed by process workloads on any tile. However, depending on the platform, only one of the tiles is used for control events pe

[Intel-gfx] ✗ Fi.CI.IGT: failure for Handle BPC for HDMI2.1 PCON without DSC1.2 sink and other fixes (rev8)

2022-12-02 Thread Patchwork
== Series Details == Series: Handle BPC for HDMI2.1 PCON without DSC1.2 sink and other fixes (rev8) URL : https://patchwork.freedesktop.org/series/107550/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12462_full -> Patchwork_107550v8_full ==

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Check full IP version when applying hw steering semaphore

2022-12-02 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Check full IP version when applying hw steering semaphore URL : https://patchwork.freedesktop.org/series/111595/ State : success == Summary == CI Bug Log - changes from CI_DRM_12463 -> Patchwork_111595v1 ===

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Check full IP version when applying hw steering semaphore

2022-12-02 Thread Rodrigo Vivi
On Fri, Dec 02, 2022 at 02:35:28PM -0800, Matt Roper wrote: > When determining whether the platform has a hardware-level steering > semaphore (i.e., MTL and beyond), we need to use GRAPHICS_VER_FULL() to > compare the full version rather than just the major version number > returned by GRAPHICS_VER

[Intel-gfx] [PATCH] drm/i915/mtl: Check full IP version when applying hw steering semaphore

2022-12-02 Thread Matt Roper
When determining whether the platform has a hardware-level steering semaphore (i.e., MTL and beyond), we need to use GRAPHICS_VER_FULL() to compare the full version rather than just the major version number returned by GRAPHICS_VER(). Reported-by: kernel test robot Fixes: 3100240bf846 ("drm/i915/

Re: [Intel-gfx] [PATCH v5 3/3] drm/i915/selftests: Add hwmon support in libpower for dgfx

2022-12-02 Thread Dixit, Ashutosh
On Tue, 29 Nov 2022 21:34:27 -0800, Riana Tauro wrote: > > diff --git a/drivers/gpu/drm/i915/selftests/libpower.c > b/drivers/gpu/drm/i915/selftests/libpower.c > index c66e993c5f85..3d4d2dc74a54 100644 > --- a/drivers/gpu/drm/i915/selftests/libpower.c > +++ b/drivers/gpu/drm/i915/selftests/libpowe

Re: [Intel-gfx] [PATCH v5 1/3] drm/i915/selftests: Rename librapl library to libpower

2022-12-02 Thread Dixit, Ashutosh
On Tue, 29 Nov 2022 21:34:25 -0800, Riana Tauro wrote: > > Rename librapl files to libpower and replace librapl > with libpower prefix. No functional changes > > v2: update commit message (Anshuman) > > Signed-off-by: Riana Tauro > Reviewed-by: Anshuman Gupta Reviewed-by: Ashutosh Dixit

Re: [Intel-gfx] [PATCH v5 2/3] drm/i915/hwmon: Add helper function to obtain energy values

2022-12-02 Thread Dixit, Ashutosh
On Tue, 29 Nov 2022 21:34:26 -0800, Riana Tauro wrote: > Hi Riana, Mostly looks good but I have a little nit below. > diff --git a/drivers/gpu/drm/i915/i915_hwmon.c > b/drivers/gpu/drm/i915/i915_hwmon.c > index c588a17f97e9..57d4e96d5c72 100644 > --- a/drivers/gpu/drm/i915/i915_hwmon.c > +++ b/

Re: [Intel-gfx] [PATCH v7 1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915

2022-12-02 Thread Vivi, Rodrigo
On Fri, 2022-12-02 at 19:21 +, Teres Alexis, Alan Previn wrote: > > > On Fri, 2022-12-02 at 11:22 -0500, Vivi, Rodrigo wrote: > > On Thu, Dec 01, 2022 at 05:14:07PM -0800, Alan Previn wrote: > > > Starting with MTL, there will be two GT-tiles, a render and media > > > tile. PXP as a service f

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Add GuC CT specific debug print wrappers

2022-12-02 Thread John Harrison
On 12/1/2022 04:01, Tvrtko Ursulin wrote: On 01/12/2022 11:56, Michal Wajdeczko wrote: On 01.12.2022 01:41, John Harrison wrote: On 11/23/2022 12:45, Michal Wajdeczko wrote: On 23.11.2022 02:25, John Harrison wrote: On 11/22/2022 09:54, Michal Wajdeczko wrote: On 18.11.2022 02:58, john.c.har

Re: [Intel-gfx] [PATCH v7 1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915

2022-12-02 Thread Teres Alexis, Alan Previn
On Fri, 2022-12-02 at 11:22 -0500, Vivi, Rodrigo wrote: > On Thu, Dec 01, 2022 at 05:14:07PM -0800, Alan Previn wrote: > > Starting with MTL, there will be two GT-tiles, a render and media > > tile. PXP as a service for supporting workloads with protected > > contexts and protected buffers can be

Re: [Intel-gfx] [Patch v2] drm/i915/mtl: Initial display workarounds

2022-12-02 Thread Matt Roper
On Fri, Dec 02, 2022 at 08:51:43AM -0800, Matt Atwood wrote: > From: Jouni Högander > > This patch introduces initial workarounds for mtl platform It looks like this patch is only dealing with workarounds from past platforms that carry forward to [some] MTL steppings. I assume the new MTL-only

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v7,1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915

2022-12-02 Thread Patchwork
== Series Details == Series: series starting with [v7,1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915 URL : https://patchwork.freedesktop.org/series/111569/ State : success == Summary == CI Bug Log - changes from CI_DRM_12461_full -> Patchwork_111569v1_full =

Re: [Intel-gfx] [PATCH] drm/i915/guc: enable GuC GGTT invalidation from the start

2022-12-02 Thread John Harrison
On 11/10/2022 09:58, Daniele Ceraolo Spurio wrote: Invalidating the GuC TLBs while GuC is not loaded does not have negative consequences, so if we're starting the driver with GuC enabled we can use the GGTT invalidation function from the get-go, iinstead of switching to it when we initialize the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Initial display workarounds

2022-12-02 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Initial display workarounds URL : https://patchwork.freedesktop.org/series/111592/ State : success == Summary == CI Bug Log - changes from CI_DRM_12463 -> Patchwork_111592v1 Summary --- **SU

Re: [Intel-gfx] [PATCH 1/3] drm/i915: place selftest preparation on a separate function

2022-12-02 Thread kernel test robot
Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm-tip/drm-tip drm/drm-next drm-misc/drm-misc-next linus/master v6.1-rc7 next-20221202] [If your patch is applied to the

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mtl: Initial display workarounds

2022-12-02 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Initial display workarounds URL : https://patchwork.freedesktop.org/series/111592/ State : warning == Summary == Error: dim checkpatch failed 8b2d9fc49c57 drm/i915/mtl: Initial display workarounds -:125: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__

[Intel-gfx] [Patch v2] drm/i915/mtl: Initial display workarounds

2022-12-02 Thread Matt Atwood
From: Jouni Högander This patch introduces initial workarounds for mtl platform v2: switch IS_MTL_DISPLAY_STEP to use IS_METEORLAKE from testing display ver. (Tvrtko) Bspec: 66624 Signed-off-by: Matt Atwood Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_fbc.c | 4 +++

Re: [Intel-gfx] [PATCH v7 1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915

2022-12-02 Thread Rodrigo Vivi
On Thu, Dec 01, 2022 at 05:14:07PM -0800, Alan Previn wrote: > Starting with MTL, there will be two GT-tiles, a render and media > tile. PXP as a service for supporting workloads with protected > contexts and protected buffers can be subscribed by process > workloads on any tile. However, depending

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/vrr: VRR fixes

2022-12-02 Thread Patchwork
== Series Details == Series: drm/i915/vrr: VRR fixes URL : https://patchwork.freedesktop.org/series/111585/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12462 -> Patchwork_111585v1 Summary --- **FAILURE** Serious

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/vrr: VRR fixes

2022-12-02 Thread Patchwork
== Series Details == Series: drm/i915/vrr: VRR fixes URL : https://patchwork.freedesktop.org/series/111585/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:117:1: warning: un

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/mtl: Add hardware-level lock for steering

2022-12-02 Thread Balasubramani Vivekanandan
On 28.11.2022 15:30, Matt Roper wrote: > Starting with MTL, the driver needs to not only protect the steering > control register from simultaneous software accesses, but also protect > against races with hardware/firmware agents. The hardware provides a > dedicated locking mechanism to support thi

[Intel-gfx] ✓ Fi.CI.BAT: success for add guard padding around i915_vma (rev7)

2022-12-02 Thread Patchwork
== Series Details == Series: add guard padding around i915_vma (rev7) URL : https://patchwork.freedesktop.org/series/110720/ State : success == Summary == CI Bug Log - changes from CI_DRM_12462 -> Patchwork_110720v7 Summary --- **SUC

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gen12: Apply recommended L3 hashing mask

2022-12-02 Thread Patchwork
== Series Details == Series: drm/i915/gen12: Apply recommended L3 hashing mask URL : https://patchwork.freedesktop.org/series/111562/ State : success == Summary == CI Bug Log - changes from CI_DRM_12461_full -> Patchwork_111562v1_full Summa

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for add guard padding around i915_vma (rev7)

2022-12-02 Thread Patchwork
== Series Details == Series: add guard padding around i915_vma (rev7) URL : https://patchwork.freedesktop.org/series/110720/ State : warning == Summary == Error: dim checkpatch failed c2fb33553511 drm/i915: Limit the display memory alignment to 32 bit instead of 64 33310e629b69 drm/i915: Wrap

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for add guard padding around i915_vma (rev7)

2022-12-02 Thread Patchwork
== Series Details == Series: add guard padding around i915_vma (rev7) URL : https://patchwork.freedesktop.org/series/110720/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v6,1/3] drm/i915/migrate: Account for the reserved_space

2022-12-02 Thread Patchwork
== Series Details == Series: series starting with [v6,1/3] drm/i915/migrate: Account for the reserved_space URL : https://patchwork.freedesktop.org/series/111583/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12462 -> Patchwork_111583v1 ===

[Intel-gfx] [PATCH 4/4] drm/i915/vrr: Be more careful with the bits in TRANS_VRR_CTL

2022-12-02 Thread Ville Syrjala
From: Ville Syrjälä On mtl (at least) clearing the guardband bits in the same write as the enable bit gets cleared seems to cause an immediate FIFO underrun. Thus is seems that we need to first clear just the enable bit, then wait for the VRR live status to indicate the transcoder has exited VRR

[Intel-gfx] [PATCH 3/4] drm/i915/vrr: Reorder transcoder vs. vrr enable/disable

2022-12-02 Thread Ville Syrjala
From: Ville Syrjälä On mtl it looks like disabling VRR after the transcoder has been disabled can cause the pipe/transcoder to get stuck when re-enabled in non-vrr mode. Reversing the order seems to help. Bspec is extremely confused about the VRR enable/disable sequence anyway, and this now more

[Intel-gfx] [PATCH 2/4] drm/i915/vrr: Fix guardband/vblank exit length calculation for adl+

2022-12-02 Thread Ville Syrjala
From: Ville Syrjälä We are miscalculating both the guardband value, and the resulting vblank exit length on adl+. This means that our start of vblank (double buffered register latch point) is incorrect, and we also think that it's not where it actually is (hence vblank evasion/etc. may not work p

[Intel-gfx] [PATCH 1/4] drm/i915/vrr: Make registers latch in a consitent place on icl/tgl

2022-12-02 Thread Ville Syrjala
From: Ville Syrjälä Account for the framestart delay when calculating the "pipeline full" value for icl/tgl vrr. This puts the start of vblank (ie. where the double bufferd registers get latched) to a consistent place regardless of what framestart delay value is used. framestart delay does not ch

[Intel-gfx] [PATCH 0/4] drm/i915/vrr: VRR fixes

2022-12-02 Thread Ville Syrjala
From: Ville Syrjälä Fix a bunch of VRR problems: - inconsistent register latch point on icl/tgl - bogus guardband/vblank exit length calculations on adl+ - adjustments to the vrr enable/disable seqeuence to avoid pipe/transcoder getting stuck on mtl when switching from vrr mode to non-vrr mod

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v6,1/3] drm/i915/migrate: Account for the reserved_space

2022-12-02 Thread Patchwork
== Series Details == Series: series starting with [v6,1/3] drm/i915/migrate: Account for the reserved_space URL : https://patchwork.freedesktop.org/series/111583/ State : warning == Summary == Error: dim checkpatch failed 475d93799f92 drm/i915/migrate: Account for the reserved_space e9b2c66ac

Re: [Intel-gfx] [PATCH] drm/i915: fix exiting context timeout calculation

2022-12-02 Thread Tvrtko Ursulin
On 02/12/2022 12:19, Andrzej Hajda wrote: On 02.12.2022 10:14, Tvrtko Ursulin wrote: On 01/12/2022 16:36, Andrzej Hajda wrote: On 01.12.2022 11:28, Tvrtko Ursulin wrote: On 01/12/2022 00:22, John Harrison wrote: On 11/29/2022 00:43, Tvrtko Ursulin wrote: On 28/11/2022 16:52, Andrzej Hajd

Re: [Intel-gfx] [PATCH v6 3/5] drm/i915: Introduce guard pages to i915_vma

2022-12-02 Thread Tvrtko Ursulin
On 02/12/2022 11:11, Andi Shyti wrote: Hi Tvrtko, On Fri, Dec 02, 2022 at 10:20:11AM +, Tvrtko Ursulin wrote: On 01/12/2022 20:39, Andi Shyti wrote: From: Chris Wilson Introduce the concept of padding the i915_vma with guard pages before and after. The major consequence is that all or

[Intel-gfx] [PATCH v6 2/3] drm/i915/selftests: use live_subtests for live_migrate

2022-12-02 Thread Matthew Auld
Probably a good idea to do an igt_flush_test() at the end of each subtest, just to be sure the previous work has been flushed and doesn't somehow interfere with the current subtest. Signed-off-by: Matthew Auld Cc: Chris Wilson Cc: Andi Shyti Cc: Andrzej Hajda Cc: Nirmoy Das --- drivers/gpu/d

[Intel-gfx] [PATCH v6 3/3] drm/i915/selftests: exercise emit_pte() with nearly full ring

2022-12-02 Thread Matthew Auld
Simple regression test to check that we don't trample the rq->reserved_space when returning from emit_pte(), if the ring is nearly full. v2: Make spinner_kill() static v3: Reduce the ring size further, which should mean we need to execute less noops; hopefully this appeases bsw. Also add some

[Intel-gfx] [PATCH v6 1/3] drm/i915/migrate: Account for the reserved_space

2022-12-02 Thread Matthew Auld
From: Chris Wilson If the ring is nearly full when calling into emit_pte(), we might incorrectly trample the reserved_space when constructing the packet to emit the PTEs. This then triggers the GEM_BUG_ON(rq->reserved_space > ring->space) when later submitting the request, since the request itsel

Re: [Intel-gfx] [PATCH] drm/i915: fix exiting context timeout calculation

2022-12-02 Thread Andrzej Hajda
On 02.12.2022 10:14, Tvrtko Ursulin wrote: On 01/12/2022 16:36, Andrzej Hajda wrote: On 01.12.2022 11:28, Tvrtko Ursulin wrote: On 01/12/2022 00:22, John Harrison wrote: On 11/29/2022 00:43, Tvrtko Ursulin wrote: On 28/11/2022 16:52, Andrzej Hajda wrote: In case context is exiting preem

[Intel-gfx] [PATCH i-g-t v2 1/2] lib/dmabuf_sync_file: move common stuff into lib

2022-12-02 Thread Matthew Auld
So we can use this across different tests. v2 - Add docs for everything (Petri) - Add missing copyright and fix headers slightly (Kamil) Signed-off-by: Matthew Auld Cc: Kamil Konieczny Cc: Petri Latvala Cc: Andrzej Hajda Cc: Nirmoy Das --- .../igt-gpu-tools/igt-gpu-tools-docs.xml |

[Intel-gfx] [PATCH i-g-t v2 2/2] tests/i915/gem_exec_balancer: exercise dmabuf import

2022-12-02 Thread Matthew Auld
With parallel submission it should be easy to get a fence array as the output fence. Try importing this into dma-buf reservation object, to see if anything explodes. v2: (Kamil) - Use ifdef __linux__ for linux headers - Add igt_describe() for new test References: https://gitlab.freedesktop.org/

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/uc: Fix double free bug

2022-12-02 Thread Patchwork
== Series Details == Series: drm/i915/uc: Fix double free bug URL : https://patchwork.freedesktop.org/series/111545/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12460_full -> Patchwork_111545v1_full Summary --- **F

[Intel-gfx] ✓ Fi.CI.BAT: success for Handle BPC for HDMI2.1 PCON without DSC1.2 sink and other fixes (rev8)

2022-12-02 Thread Patchwork
== Series Details == Series: Handle BPC for HDMI2.1 PCON without DSC1.2 sink and other fixes (rev8) URL : https://patchwork.freedesktop.org/series/107550/ State : success == Summary == CI Bug Log - changes from CI_DRM_12462 -> Patchwork_107550v8

Re: [Intel-gfx] [PATCH v6 3/5] drm/i915: Introduce guard pages to i915_vma

2022-12-02 Thread Andi Shyti
Hi Tvrtko, On Fri, Dec 02, 2022 at 10:20:11AM +, Tvrtko Ursulin wrote: > > On 01/12/2022 20:39, Andi Shyti wrote: > > From: Chris Wilson > > > > Introduce the concept of padding the i915_vma with guard pages before > > and after. The major consequence is that all ordinary uses of i915_vma >

Re: [Intel-gfx] [PATCH i-g-t 1/2] lib/dmabuf_sync_file: move common stuff into lib

2022-12-02 Thread Kamil Konieczny
Hi Matthew, On 2022-12-01 at 16:49:43 +, Matthew Auld wrote: > So we can use this across different tests. > > Signed-off-by: Matthew Auld > Cc: Kamil Konieczny > Cc: Andrzej Hajda > Cc: Nirmoy Das > --- > lib/dmabuf_sync_file.c | 138 +++ > lib/dmabu

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v5,1/3] drm/i915/migrate: Account for the reserved_space

2022-12-02 Thread Patchwork
== Series Details == Series: series starting with [v5,1/3] drm/i915/migrate: Account for the reserved_space URL : https://patchwork.freedesktop.org/series/111577/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12462 -> Patchwork_111577v1 ===

Re: [Intel-gfx] [PATCH v6 3/5] drm/i915: Introduce guard pages to i915_vma

2022-12-02 Thread Tvrtko Ursulin
On 01/12/2022 20:39, Andi Shyti wrote: From: Chris Wilson Introduce the concept of padding the i915_vma with guard pages before and after. The major consequence is that all ordinary uses of i915_vma must use i915_vma_offset/i915_vma_size and not i915_vma.node.start/size directly, as the drm_m

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v5,1/3] drm/i915/migrate: Account for the reserved_space

2022-12-02 Thread Patchwork
== Series Details == Series: series starting with [v5,1/3] drm/i915/migrate: Account for the reserved_space URL : https://patchwork.freedesktop.org/series/111577/ State : warning == Summary == Error: dim checkpatch failed 977e2603928c drm/i915/migrate: Account for the reserved_space -:36: WAR

[Intel-gfx] [PATCH v5 13/14] drm/i915/dp: Fix FRL BW check for HDMI2.1 DFP

2022-12-02 Thread Ankit Nautiyal
During FRL bandwidth check for downstream HDMI2.1 sink, the min BPC supported is incorrectly taken for DP, and the check does not consider ybcr420 only modes. This patch fixes the bandwidth calculation similar to the TMDS case, by taking min 8Bpc and considering Ycbcr420 only modes. v2: Rebase S

[Intel-gfx] [PATCH v5 14/14] drm/i915/dp: Add a wrapper to check frl/tmds downstream constraints

2022-12-02 Thread Ankit Nautiyal
Add a wrapper function to check dp_downstream clock/bandwidth constraints. Based on whether the sink supports FRL/TMDS the wrapper calls the appropriate FRL/TMDS functions. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 51 +++-- 1 file changed, 2

[Intel-gfx] [PATCH v5 12/14] drm/i915/dp: Handle BPP where HDMI2.1 DFP doesn't support DSC

2022-12-02 Thread Ankit Nautiyal
Currently we use the highest input BPC supported by DP sink while using DSC.In cases where PCON with HDMI2.1 as branch device, if PCON supports DSC but HDMI2.1 sink does not supports DSC, The PCON tries to use same input BPC that is used between Source and the PCON without DSC, which might not work

[Intel-gfx] [PATCH v5 10/14] drm/i915/display: Add helper function to check if sink_format is 420

2022-12-02 Thread Ankit Nautiyal
Add an inline helper function to check if the sink_format is set to YCBCR420 format. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_display_types.h | 6 ++ drivers/gpu/drm/i915/display/intel_dp.c| 4 ++-- drivers/gpu/drm/i915/display/intel_hdmi.c |

[Intel-gfx] [PATCH v5 11/14] drm/i915/dp: Avoid DSC with output_format YCBCR420

2022-12-02 Thread Ankit Nautiyal
Currently, DSC with YCBCR420 is not supported. Return -EINVAL when trying with DSC with output_format as YCBCR420. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/

[Intel-gfx] [PATCH v1 09/14] drm/i915/dp: Check if mode can be supported with dsc compressed bpp

2022-12-02 Thread Ankit Nautiyal
Use compressed bpp to calculate mode_rate during dp_mode_valid. Check if this can be supported with max lane count and link rate combination. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/dri

[Intel-gfx] [PATCH v1 08/14] drm/i915/dp: Consider output_format while computing dsc bpp for mode_valid

2022-12-02 Thread Ankit Nautiyal
During modevalid step, the pipe bpp is computed assuming RGB output format. When checking with DSC, consider the output_format and compute the input bpp for DSC appropriately. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 32 +++-- 1 file changed

[Intel-gfx] [PATCH v1 07/14] drm/i915/dp: Rearrange check for illegal mode and comments in mode_valid

2022-12-02 Thread Ankit Nautiyal
Check for MODE_H_ILLEGAL before calculating max rates, lanes etc. Move comments about compressed bpp U6.4 format closer to where it is used. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[Intel-gfx] [PATCH v2 05/14] drm/i915/dp: Compute output format with/without DSC

2022-12-02 Thread Ankit Nautiyal
Currently we compute the output format first and later try DSC if the bandwidth without compression is not sufficient for that output format. Since we do not support DSC with YCbCr420 format, this creates problem for YCbCr420 only modes, that can be still be set if DFP has color conversion and DSC

[Intel-gfx] [PATCH v5 06/14] drm/i915/display: Use sink_format instead of ycbcr420_output flag

2022-12-02 Thread Ankit Nautiyal
Start passing the sink_format, to all functions that take a bool ycbcr420_output as parameter. This will make the functions generic, and will serve as a slight step towards 4:2:2 support later. Suggested-by: Ville Syrj_l_ Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c

[Intel-gfx] [PATCH v7 04/14] drm/i915/dp: Replace intel_dp.dfp members with the new crtc_state sink_format

2022-12-02 Thread Ankit Nautiyal
The decision to use DFP output format conversion capabilities should be during compute_config phase. This patch uses the members of intel_dp->dfp to only store the format conversion capabilities of the DP device and uses the crtc_state sink_format member, to program the protocol-converter for colo

[Intel-gfx] [PATCH v2 03/14] drm/i915/dp: Add Scaler constraint for YCbCr420 output

2022-12-02 Thread Ankit Nautiyal
For YCbCr420 output, scaler is required for downsampling. Scaler can be used only when source size smaller than 5120x4096. So go for native YCbCr420 only if there are no scaler constraints. v2: Corrected max-width based on Display Version. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/

[Intel-gfx] [PATCH v5 02/14] drm/i915/display: Add new member in intel_dp to store ycbcr420 passthrough cap

2022-12-02 Thread Ankit Nautiyal
New member to store the YCBCR20 Pass through capability of the DP sink. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_display_types.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/inte

[Intel-gfx] [PATCH v6 01/14] drm/i915/display: Add new member to configure PCON color conversion

2022-12-02 Thread Ankit Nautiyal
The decision to use DFP output format conversion capabilities should be during compute_config phase. This patch adds new member to crtc_state to represent the final output_format to the sink. In case of a DFP this can be different than the output_format, as per the format conversion done via the P

[Intel-gfx] [PATCH v8 00/14] Handle BPC for HDMI2.1 PCON without DSC1.2 sink and other fixes

2022-12-02 Thread Ankit Nautiyal
This series fixes issues faced when an HDMI2.1 sink that does not support DSC is connected via HDMI2.1PCON. It also includes other minor HDMI2.1 PCON fixes/refactoring. Patch 1-2 Have minor fixes/cleanups. Patch 3-6 Pull the decision making to use DFP conversion capabilities for every mode during

[Intel-gfx] [PATCH v5 3/3] drm/i915/selftests: exercise emit_pte() with nearly full ring

2022-12-02 Thread Matthew Auld
Simple regression test to check that we don't trample the rq->reserved_space when returning from emit_pte(), if the ring is nearly full. v2: Make spinner_kill() static v3: Reduce the ring size further, which should mean we need to execute less noops; hopefully this appeases bsw. Also add some

[Intel-gfx] [PATCH v5 2/3] drm/i915/selftests: use live_subtests for live_migrate

2022-12-02 Thread Matthew Auld
Probably a good idea to do an igt_flush_test() at the end of each subtest, just to be sure the previous work has been flushed and doesn't somehow interfere with the current subtest. Signed-off-by: Matthew Auld Cc: Chris Wilson Cc: Andi Shyti Cc: Andrzej Hajda Cc: Nirmoy Das --- drivers/gpu/d

[Intel-gfx] [PATCH v5 1/3] drm/i915/migrate: Account for the reserved_space

2022-12-02 Thread Matthew Auld
From: Chris Wilson If the ring is nearly full when calling into emit_pte(), we might incorrectly trample the reserved_space when constructing the packet to emit the PTEs. This then triggers the GEM_BUG_ON(rq->reserved_space > ring->space) when later submitting the request, since the request itsel

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/2] lib/dmabuf_sync_file: move common stuff into lib

2022-12-02 Thread Petri Latvala
On Thu, Dec 01, 2022 at 04:49:43PM +, Matthew Auld wrote: > So we can use this across different tests. > > Signed-off-by: Matthew Auld > Cc: Kamil Konieczny > Cc: Andrzej Hajda > Cc: Nirmoy Das > --- > lib/dmabuf_sync_file.c | 138 +++ > lib/dmabuf_sy

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Optimise for continuous memory allocation (rev3)

2022-12-02 Thread Patchwork
== Series Details == Series: drm: Optimise for continuous memory allocation (rev3) URL : https://patchwork.freedesktop.org/series/111542/ State : success == Summary == CI Bug Log - changes from CI_DRM_12460_full -> Patchwork_111542v3_full S

Re: [Intel-gfx] [PATCH 0/2] drm/i915: Remove frontbuffer tracking from gem.

2022-12-02 Thread Tvrtko Ursulin
On 01/12/2022 22:03, Zanoni, Paulo R wrote: Hi I was given a link to https://patchwork.freedesktop.org/series/111494/ but can't seem to find it on the mailing list, so I'll reply here. On Thu, 2022-08-25 at 08:46 +0200, Maarten Lankhorst wrote: Frontbuffer tracking in gem is used in old driv

Re: [Intel-gfx] [PATCH] drm/i915: fix exiting context timeout calculation

2022-12-02 Thread Tvrtko Ursulin
On 01/12/2022 16:36, Andrzej Hajda wrote: On 01.12.2022 11:28, Tvrtko Ursulin wrote: On 01/12/2022 00:22, John Harrison wrote: On 11/29/2022 00:43, Tvrtko Ursulin wrote: On 28/11/2022 16:52, Andrzej Hajda wrote: In case context is exiting preempt_timeout_ms is used for timeout, but since i

Re: [Intel-gfx] [PATCH 2/2] drm/i915/mtl: Add initial gt workarounds

2022-12-02 Thread Tvrtko Ursulin
On 01/12/2022 23:23, Matt Roper wrote: On Thu, Dec 01, 2022 at 09:23:07AM -0800, Lucas De Marchi wrote: On Thu, Dec 01, 2022 at 01:15:35PM +, Tvrtko Ursulin wrote: On 30/11/2022 23:17, Matt Atwood wrote: From: Matt Roper This patch introduces initial workarounds for mtl platform Bspe