On Sun, Oct 09, 2022 at 11:58:18PM -0700, Niranjana Vishwanathapura wrote:
Add support for handling out fence for vm_bind call.
v2: Reset vma->vm_bind_fence.syncobj to NULL at the end
of vm_bind call.
Signed-off-by: Niranjana Vishwanathapura
Signed-off-by: Andi Shyti
---
drivers/gpu/drm/i9
On Tue, Oct 11, 2022 at 06:41:23PM +0100, Matthew Auld wrote:
On 11/10/2022 17:27, Matthew Auld wrote:
On 10/10/2022 07:58, Niranjana Vishwanathapura wrote:
Each VM creates a root_obj and shares it with all of its private objects
to use it as dma_resv object. This has a performance advantage as
== Series Details ==
Series: Enable YCbCr420 for VDSC (rev5)
URL : https://patchwork.freedesktop.org/series/108824/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12242 -> Patchwork_108824v5
Summary
---
**SUCCESS**
== Series Details ==
Series: Enable YCbCr420 for VDSC (rev5)
URL : https://patchwork.freedesktop.org/series/108824/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Enable YCbCr420 for VDSC (rev5)
URL : https://patchwork.freedesktop.org/series/108824/
State : warning
== Summary ==
Error: dim checkpatch failed
bcb8bdb7258e drm/i915/dp: Check if DSC supports the given output_format
5faeb60f4e44 drm/i915: Adding the new registers
== Series Details ==
Series: series starting with [1/2] drm/i915/display: Do both crawl and squash
when changing cdclk
URL : https://patchwork.freedesktop.org/series/109694/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12242_full -> Patchwork_109694v1_full
==
> -Original Message-
> From: Auld, Matthew
> Sent: Wednesday, October 12, 2022 3:19 PM
> To: Gupta, Anshuman ; intel-
> g...@lists.freedesktop.org
> Cc: joonas.lahti...@linux.intel.com; tvrtko.ursu...@linux.intel.com; Vivi,
> Rodrigo
> Subject: Re: [PATCH] drm/i915/dgfx: Temporary hamme
> -Original Message-
> From: Vivi, Rodrigo
> Sent: Wednesday, October 12, 2022 8:31 PM
> To: Joonas Lahtinen
> Cc: Gupta, Anshuman ; intel-
> g...@lists.freedesktop.org; tvrtko.ursu...@linux.intel.com; Auld, Matthew
>
> Subject: Re: [PATCH] drm/i915/dgfx: Temporary hammer to keep auto
== Series Details ==
Series: drm/i915: Fix CFI violations in gt_sysfs (rev3)
URL : https://patchwork.freedesktop.org/series/108917/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12242_full -> Patchwork_108917v3_full
Summary
== Series Details ==
Series: drm/i915/huc: bump timeout for delayed load and reduce print verbosity
(rev3)
URL : https://patchwork.freedesktop.org/series/109455/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12242_full -> Patchwork_109455v3_full
==
== Series Details ==
Series: series starting with [1/2] drm/i915/display: Do both crawl and squash
when changing cdclk
URL : https://patchwork.freedesktop.org/series/109694/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12242 -> Patchwork_109694v1
On 10/13/2022 3:28 PM, Dixit, Ashutosh wrote:
On Thu, 13 Oct 2022 08:55:24 -0700, Vinay Belgaumkar wrote:
Hi Vinay,
GuC will set the min/max frequencies to theoretical max on
ATS-M. This will break kernel ABI, so limit min/max frequency
to RP0(platform max) instead.
Isn't what we are calling
== Series Details ==
Series: i915: Extend Wa_1607297627 to Alderlake-P (rev2)
URL : https://patchwork.freedesktop.org/series/109678/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12242_full -> Patchwork_109678v2_full
Summar
From: Ville Syrjälä
For MTL, changing cdclk from between certain frequencies has
both squash and crawl. Use the current cdclk config and
the new(desired) cdclk config to construtc a mid cdclk config.
Set the cdclk twice:
- Current cdclk -> mid cdclk
- mid cdclk -> desired cdclk
v2: Add check in
As per bSpec MTL has 38.4 MHz Reference clock.
MTL does support squasher like DG2 but only for lower
frequencies. Change the has_cdclk_squasher()
helper to reflect this.
v2: Revert to using bxt_get_cdclk()
BSpec: 65243
Cc: Radhakrishna Sripada
Signed-off-by: Anusha Srivatsa
---
drivers/gpu/drm
== Series Details ==
Series: drm/i915/ttm: Fix access_memory null pointer exception
URL : https://patchwork.freedesktop.org/series/109677/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12242_full -> Patchwork_109677v1_full
== Series Details ==
Series: drm/i915: Fix CFI violations in gt_sysfs (rev3)
URL : https://patchwork.freedesktop.org/series/108917/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12242 -> Patchwork_108917v3
Summary
---
On Thu, 13 Oct 2022 08:55:24 -0700, Vinay Belgaumkar wrote:
>
Hi Vinay,
> GuC will set the min/max frequencies to theoretical max on
> ATS-M. This will break kernel ABI, so limit min/max frequency
> to RP0(platform max) instead.
Isn't what we are calling "theoretical max" or "RPmax" really just
== Series Details ==
Series: drm/i915: Fix CFI violations in gt_sysfs (rev3)
URL : https://patchwork.freedesktop.org/series/108917/
State : warning
== Summary ==
Error: dim checkpatch failed
26024ab54a1b drm/i915: Fix CFI violations in gt_sysfs
-:123: CHECK:LINE_SPACING: Please use a blank lin
== Series Details ==
Series: drm/i915/huc: bump timeout for delayed load and reduce print verbosity
(rev3)
URL : https://patchwork.freedesktop.org/series/109455/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12242 -> Patchwork_109455v3
== Series Details ==
Series: drm/1915/guc: enable engine reset on CAT
URL : https://patchwork.freedesktop.org/series/109675/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12242_full -> Patchwork_109675v1_full
Summary
--
On 10/5/2022 9:38 PM, Alan Previn wrote:
Make intel_pxp_is_enabled implicitly find the PXP-owning-GT.
PXP feature support is a device-config flag. In preparation for MTL
PXP control-context shall reside on of the two GT's.
That said, update intel_pxp_is_enabled to take in i915 as its input
and
When booting with CONFIG_CFI_CLANG, there are numerous violations when
accessing the files under
/sys/devices/pci:00/:00:02.0/drm/card0/gt/gt0:
$ cd /sys/devices/pci:00/:00:02.0/drm/card0/gt/gt0
$ grep . *
id:0
punit_req_freq_mhz:350
rc6_enable:1
rc6_residency_ms:21493
== Series Details ==
Series: i915: Extend Wa_1607297627 to Alderlake-P (rev2)
URL : https://patchwork.freedesktop.org/series/109678/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12242 -> Patchwork_109678v2
Summary
---
== Series Details ==
Series: drm/i915/slpc: Use platform limits for min/max frequency (rev2)
URL : https://patchwork.freedesktop.org/series/109632/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12242_full -> Patchwork_109632v2_full
=
On 10/5/2022 9:38 PM, Alan Previn wrote:
In preparation for future MTL-PXP feature support, PXP control
context should only valid on the correct gt tile. Depending on the
device-info this mat not necessarily be the root GT tile and
depends on which tile owns the VEBOX and KCR.
PXP is still a
Hi All,
Yesterday I got a new Lenovo ThinkPad X1 yoga gen 7 laptop, since I plan
to make this my new day to day laptop I have copied over the entire
rootfs, /home, etc. from my current laptop to avoid having to tweak
everything to my liking again.
This meant I had an initramfs generated for the o
We're observing sporadic HuC delayed load timeouts in CI, due to mei_pxp
binding completing later than we expected. HuC is still loaded when the
bind occurs, but in the meantime i915 has started allowing submission to
the VCS engines even if HuC is not there.
In most of the cases I've observed, the
== Series Details ==
Series: i915: Extend Wa_1607297627 to Alderlake-P
URL : https://patchwork.freedesktop.org/series/109678/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12242 -> Patchwork_109678v1
Summary
---
**FA
== Series Details ==
Series: drm/i915/ttm: Fix access_memory null pointer exception
URL : https://patchwork.freedesktop.org/series/109677/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12242 -> Patchwork_109677v1
Summary
--
On Thu, Oct 13, 2022 at 09:41:21PM +0300, Ville Syrjälä wrote:
> On Tue, Oct 11, 2022 at 04:49:35PM +0300, Jani Nikula wrote:
> > For normal connector detect, there's really no point in trying dual mode
> > detect if the connector is disconnected. We can simplify the detect
> > sequence by skipping
== Series Details ==
Series: drm/i915: Add HWMON support (rev9)
URL : https://patchwork.freedesktop.org/series/104278/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12242_full -> Patchwork_104278v9_full
Summary
---
*
== Series Details ==
Series: drm/1915/guc: enable engine reset on CAT
URL : https://patchwork.freedesktop.org/series/109675/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12242 -> Patchwork_109675v1
Summary
---
**SUC
== Series Details ==
Series: drm/i915/slpc: Use platform limits for min/max frequency (rev2)
URL : https://patchwork.freedesktop.org/series/109632/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12242 -> Patchwork_109632v2
S
On Tue, Oct 11, 2022 at 04:49:35PM +0300, Jani Nikula wrote:
> For normal connector detect, there's really no point in trying dual mode
> detect if the connector is disconnected. We can simplify the detect
> sequence by skipping it. Since intel_hdmi_dp_dual_mode_detect() is only
> called when EDID
missed the "drm/" in the subject 😛
On Thu, 2022-10-13 at 11:14 -0700, José Roberto de Souza wrote:
> BSpec: 54369
> Signed-off-by: José Roberto de Souza
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/d
BSpec: 54369
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c
b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index b8eb20a155f0d..e1d5df3a5756e 1
== Series Details ==
Series: drm/1915/guc: enable engine reset on CAT
URL : https://patchwork.freedesktop.org/series/109675/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
i915_ttm_to_gem can return a NULL pointer, which is
dereferenced in i915_ttm_access_memory without first
checking if it is NULL. Inspecting
i915_ttm_io_mem_reserve, it appears the correct
behavior in this case is to return -EINVAL.
Fixes: 26b15eb0 ("drm/i915/ttm: implement access_memory")
Signed-
== Series Details ==
Series: drm/i915/slpc: Use platform limits for min/max frequency (rev2)
URL : https://patchwork.freedesktop.org/series/109632/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: Add HWMON support (rev9)
URL : https://patchwork.freedesktop.org/series/104278/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12242 -> Patchwork_104278v9
Summary
---
**SUCCESS**
== Series Details ==
Series: drm/i915: refactor 915_vma_move_to_active
URL : https://patchwork.freedesktop.org/series/109668/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12242_full -> Patchwork_109668v1_full
Summary
-
On 10/13/2022 9:25 PM, Vinay Belgaumkar wrote:
GuC will set the min/max frequencies to theoretical max on
ATS-M. This will break kernel ABI, so limit min/max frequency
to RP0(platform max) instead.
Also modify the SLPC selftest to update the min frequency
when we have a server part so that we
On Wed, Oct 12, 2022 at 04:46:07PM -0700, Dixit, Ashutosh wrote:
On Wed, 12 Oct 2022 15:27:27 -0700, Umesh Nerlige Ramappa wrote:
+static u32 oa_context_image_offset(struct intel_context *ce, u32 reg)
+{
+ u32 offset, len = (ce->engine->context_size - PAGE_SIZE) / 4;
+ u32 *state =
== Series Details ==
Series: drm/i915: Add HWMON support (rev9)
URL : https://patchwork.freedesktop.org/series/104278/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: Add HWMON support (rev9)
URL : https://patchwork.freedesktop.org/series/104278/
State : warning
== Summary ==
Error: dim checkpatch failed
2ef44d6cc455 drm/i915/hwmon: Add HWMON infrastructure
Traceback (most recent call last):
File "scripts/spdxcheck.p
In case of catastrophic errors GuC is able to initate engine
reset immediately, instead of waiting for timeout.
Signed-off-by: Andrzej Hajda
---
Hi all,
I am new in the subject, so please be polite if this is mistake.
Tests shows that it allows to save about 7 seconds on the machine
(Raptor Lake
On 10/13/2022 8:14 AM, Das, Nirmoy wrote:
On 10/12/2022 8:26 PM, Vinay Belgaumkar wrote:
GuC will set the min/max frequencies to theoretical max on
ATS-M. This will break kernel ABI, so limit min/max frequency
to RP0(platform max) instead.
Also modify the SLPC selftest to update the min freq
GuC will set the min/max frequencies to theoretical max on
ATS-M. This will break kernel ABI, so limit min/max frequency
to RP0(platform max) instead.
Also modify the SLPC selftest to update the min frequency
when we have a server part so that we can iterate between
platform min and max.
v2: Chec
On Mon, 03 Oct 2022 14:32:36 -0700, Andi Shyti wrote:
>
Hi Andi,
> > diff --git a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon
> > b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon
> > index f9d6d3b08bba..19b9fe3ef237 100644
> > --- a/Documentation/ABI/testing/sysfs-driver-int
On Mon, 03 Oct 2022 14:13:10 -0700, Andi Shyti wrote:
>
Hi Andi,
> [...]
>
> > > diff --git a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon
> > > b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon
> > > index 16e697b1db3d..7525db243d74 100644
> > > --- a/Documentation/ABI/testin
On Fri, 30 Sep 2022 09:52:28 -0700, Rodrigo Vivi wrote:
>
Hi Rodrigo,
> On Tue, Sep 27, 2022 at 11:20:17AM +0530, Badal Nilawar wrote:
> > From: Dale B Stimson
> >
> > Use i915 HWMON to display device level energy input.
> >
> > v2: Updated the date and kernel version in feature description
> >
On Mon, 03 Oct 2022 14:05:14 -0700, Andi Shyti wrote:
>
> Hi Badal,
>
> [...]
>
> > hwm_get_preregistration_info(struct drm_i915_private *i915)
> > {
> > struct i915_hwmon *hwmon = i915->hwmon;
> > + struct intel_uncore *uncore = &i915->uncore;
> > + intel_wakeref_t wakeref;
> > + u32 v
On Wed, 21 Sep 2022 05:02:48 -0700, Gupta, Anshuman wrote:
>
> > diff --git a/drivers/gpu/drm/i915/intel_mchbar_regs.h
> > b/drivers/gpu/drm/i915/intel_mchbar_regs.h
> > index b74df11977c6..1014d0b7cc16 100644
> > --- a/drivers/gpu/drm/i915/intel_mchbar_regs.h
> > +++ b/drivers/gpu/drm/i915/intel_
On Mon, 03 Oct 2022 13:56:05 -0700, Andi Shyti wrote:
Hi Andi,
Badal is out for a bit so I am posting this version of the patches.
>
> Hi Badal,
>
> [...]
>
> > static void
> > hwm_get_preregistration_info(struct drm_i915_private *i915)
> > {
> > + struct i915_hwmon *hwmon = i915->hwmon;
>
From: Riana Tauro
Use i915 HWMON subsystem to display current input voltage.
v2:
- Updated date and kernel version in feature description
- Fixed review comments (Ashutosh)
v3: Use macro HWMON_CHANNEL_INFO to define hwmon channel (Guenter)
v4:
- Fixed review comments (Ashutosh)
- Use hwm
This series adds the HWMON support for DGFX
Test-with: 20221013151400.2086268-1-ashutosh.di...@intel.com
v2:
- Reorganized series. Created first patch as infrastructure patch
followed by feature patches. (Ashutosh)
- Fixed review comments (Jani)
- Fixed review comments (Ashutosh)
v3:
From: Dale B Stimson
Extend hwmon power/energy for XEHPSDV especially per gt level energy
usage.
v2: Update to latest HWMON spec (Ashutosh)
v3: Fix review comments (Ashutosh)
v4: Fix review comments (Anshuman)
v5: s/hwmon_device_register_with_info/
devm_hwmon_device_register_with_info/ (Ashu
Expose power1_max_interval, that is the tau corresponding to PL1, as a
custom hwmon attribute. Some bit manipulation is needed because of the
format of PKG_PWR_LIM_1_TIME in
GT0_PACKAGE_RAPL_LIMIT register (1.x * power(2,y)).
v2: Update date and kernel version in Documentation (Badal)
v3: Cleaned
Expose the card reactive critical (I1) power. I1 is exposed as
power1_crit in microwatts (typically for client products) or as
curr1_crit in milliamperes (typically for server).
v2: Add curr1_crit functionality (Ashutosh)
v3: Use HWMON_CHANNEL_INFO to define power1_crit, curr1_crit (Badal)
v4: Use
From: Dale B Stimson
Use i915 HWMON to display device level energy input.
v2: Updated the date and kernel version in feature description
v3:
- Cleaned up hwm_energy function and removed unused function
i915_hwmon_energy_status_get (Ashutosh)
v4: KernelVersion: 6.2, Date: February 2023 in d
From: Dale B Stimson
The i915 HWMON module will be used to expose voltage, power and energy
values for dGfx. Here we set up i915 hwmon infrastructure including i915
hwmon registration, basic data structures and functions.
v2:
- Create HWMON infra patch (Ashutosh)
- Fixed review comments (Jan
From: Dale B Stimson
Use i915 HWMON to display/modify dGfx power PL1 limit and TDP setting.
v2:
- Fix review comments (Ashutosh)
- Do not restore power1_max upon module unload/load sequence
because on production systems modules are always loaded
and not unloaded/reloaded (Ashutosh)
On 10/13/2022 4:34 AM, Tauro, Riana wrote:
On 10/12/2022 11:56 PM, Vinay Belgaumkar wrote:
GuC will set the min/max frequencies to theoretical max on
ATS-M. This will break kernel ABI, so limit min/max frequency
to RP0(platform max) instead.
Also modify the SLPC selftest to update the min f
> -Original Message-
> From: Dixit, Ashutosh
> Sent: Wednesday, October 12, 2022 8:49 PM
> To: Auld, Matthew
> Cc: Gupta, Anshuman ; intel-
> g...@lists.freedesktop.org; Vivi, Rodrigo
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/dgfx: Temporary hammer to keep
> autosuspend control 'on'
On 10/12/2022 8:26 PM, Vinay Belgaumkar wrote:
GuC will set the min/max frequencies to theoretical max on
ATS-M. This will break kernel ABI, so limit min/max frequency
to RP0(platform max) instead.
Also modify the SLPC selftest to update the min frequency
when we have a server part so that we
== Series Details ==
Series: drm/i915: refactor 915_vma_move_to_active
URL : https://patchwork.freedesktop.org/series/109668/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12242 -> Patchwork_109668v1
Summary
---
**SU
== Series Details ==
Series: drm: Analog TV Improvements (rev4)
URL : https://patchwork.freedesktop.org/series/107892/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/107892/revisions/4/mbox/ not
applied
Applying: drm/tests: Add Kunit Helpers
Apply
On 13/10/2022 14:30, Andrzej Hajda wrote:
Since almost all calls to i915_vma_move_to_active are prepended with
i915_request_await_object, let's put it into i915_vma_move_to_active.
The patch should not introduce functional changes.
I know I am late to the party but perhaps one alternative app
Since almost all calls to i915_vma_move_to_active are prepended with
i915_request_await_object, let's put it into i915_vma_move_to_active.
The patch should not introduce functional changes.
Signed-off-by: Andrzej Hajda
---
.../i915/gem/selftests/i915_gem_client_blt.c | 4 +---
.../i915/gem/sel
Many calls to i915_vma_move_to_active are surrounded by vma lock
and/or there are multiple local helpers for it in particular tests.
Let's replace it by common helper.
The patch should not introduce functional changes.
Signed-off-by: Andrzej Hajda
---
.../i915/gem/selftests/i915_gem_client_blt.c
This patchset refactors code related to i915_vma_move_to_active.
I hope 1st patch is quite straightforward.
For the 2nd, I am not sure where to put the helper, any better proposition
welcome.
Regards
Andrzej
Andrzej Hajda (2):
drm/i915: add wait and lock to i915_vma_move_to_active
drm/i915/s
== Series Details ==
Series: series starting with [1/2] drm/print: Add drm_dbg_ratelimited
URL : https://patchwork.freedesktop.org/series/109653/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12241_full -> Patchwork_109653v1_full
===
From: Mateusz Kwiatkowski
Add support for the following composite output modes (all of them are
somewhat more obscure than the previously defined ones):
- NTSC_443 - NTSC-style signal with the chroma subcarrier shifted to
4.43361875 MHz (the PAL subcarrier frequency). Never used for
broadcas
Now that the core can deal fine with analog TV modes, let's convert the vc4
VEC driver to leverage those new features.
We've added some backward compatibility to support the old TV mode property
and translate it into the new TV norm property. We're also making use of
the new analog TV atomic_check
Now that the core can deal fine with analog TV modes, let's convert the
sun4i TV driver to leverage those new features.
Acked-by: Noralf Trønnes
Signed-off-by: Maxime Ripard
---
Changes in v5:
- Removed the count variable in get_modes
- Removed spurious vc4 change
---
drivers/gpu/drm/sun4i/sun
From: Mateusz Kwiatkowski
The VEC can accept pretty much any relatively reasonable mode, but still
has a bunch of constraints to meet.
Let's create an atomic_check() implementation that will make sure we
don't end up accepting a non-functional mode.
Acked-by: Noralf Trønnes
Signed-off-by: Mate
The framework will get the drm_display_mode from the drm_cmdline_mode it
got by parsing the video command line argument by calling
drm_connector_pick_cmdline_mode().
The heavy lifting will then be done by the drm_mode_create_from_cmdline_mode()
function.
In the case of the named modes though, the
The analog TV connector drivers share some atomic_check logic, and the new
TV standard property have created some boilerplate that can be be shared
across drivers too.
Let's create an atomic_check helper for those use cases.
Reviewed-by: Noralf Trønnes
Signed-off-by: Maxime Ripard
---
drivers/
Now that we can easily extend the named modes list, let's add a few more
analog TV modes that were used in the wild, and some unit tests to make
sure it works as intended.
Signed-off-by: Maxime Ripard
---
Changes in v5:
- Switched to KUNIT_ASSERT_NOT_NULL
---
drivers/gpu/drm/drm_modes.c
The drm_tv_create_properties() function will create a bunch of properties,
but it's up to each and every driver using that function to properly reset
the state of these properties leading to inconsistent behaviours.
Let's create a helper that will take care of it.
Reviewed-by: Noralf Trønnes
Sig
The analog TV properties created by the drm_mode_create_tv_properties() are
not properly initialised at reset. Let's switch our implementation to call
drm_atomic_helper_connector_tv_reset().
Reviewed-by: Noralf Trønnes
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/vc4/vc4_vec.c | 8 +++-
Our new tv mode option allows to specify the TV mode from a property.
However, it can still be useful, for example to avoid any boot time
artifact, to set that property directly from the kernel command line.
Let's add some code to allow it, and some unit tests to exercise that code.
Signed-off-by
As part of the command line parsing rework coming in the next patches,
we'll need to lookup drm_connector_tv_mode values by their name, already
defined in drm_tv_mode_enum_list.
In order to avoid any code duplication, let's do a function that will
perform a lookup of a TV mode name and return its
We'll need to get the pixel clock to generate proper display modes for
all the current named modes. Let's add it to struct drm_cmdline_mode and
fill it when parsing the named mode.
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/drm_modes.c | 9 ++---
include/drm/drm_connector.h | 7 +++
The current named mode parsing relies only the mode name, and doesn't allow
to specify any other parameter.
Let's convert that string list to an array of a custom structure that will
hold the name and some additional parameters in the future.
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/drm
The current code to deal with named modes will only set the mode name, and
then it's up to drivers to try to match that name to whatever mode or
configuration they see fit.
The plan is to remove that need and move the named mode handling out of
drivers and into the core, and only rely on modes and
The current construction of the named mode parsing doesn't allow to extend
it easily. Let's move it to a separate function so we can add more
parameters and modes.
In order for the tests to still pass, some extra checks are needed, so
it's not a 1:1 move.
Signed-off-by: Maxime Ripard
---
Change
drm_mode_create_tv_properties(), among other things, will create the
"mode" property that stores the analog TV mode that connector is
supposed to output.
However, that property is getting deprecated, so let's rename that
function to mention it's deprecated. We'll introduce a new variant of
that fu
Multiple drivers (meson, vc4, sun4i) define analog TV 525-lines and
625-lines modes in their drivers.
Since those modes are fairly standard, and that we'll need to use them
in more places in the future, it makes sense to move their definition
into the core framework.
However, analog display usual
The drm_create_tv_properties() will create the TV mode property
unconditionally.
However, since we'll gradually phase it out, let's register it only if we
have a list passed as an argument. This will make the transition easier.
Acked-by: Noralf Trønnes
Signed-off-by: Maxime Ripard
---
drivers/
drm_connector_pick_cmdline_mode() is in charge of finding a proper
drm_display_mode from the definition we got in the video= command line
argument.
Let's add some unit tests to make sure we're not getting any regressions
there.
Signed-off-by: Maxime Ripard
---
Changes in v5:
- Removed useless (
The TV mode property has been around for a while now to select and get the
current TV mode output on an analog TV connector.
Despite that property name being generic, its content isn't and has been
driver-specific which makes it hard to build any generic behaviour on top
of it, both in kernel and
As the number of kunit tests in KMS grows further, we start to have
multiple test suites that, for example, need to register a mock DRM
driver to interact with the KMS function they are supposed to test.
Let's add a file meant to provide those kind of helpers to avoid
duplication.
Signed-off-by:
Hi,
Here's a series aiming at improving the command line named modes support,
and more importantly how we deal with all the analog TV variants.
The named modes support were initially introduced to allow to specify the
analog TV mode to be used.
However, this was causing multiple issues:
* The
The current tv_mode has driver-specific values that don't allow to
easily share code using it, either at the userspace or kernel level.
Since we're going to introduce a new, generic, property that fit the
same purpose, let's rename this one to legacy_tv_mode to make it
obvious we should move away
Hi Dave, Daniel,
Not sure if there is time for one more pull during the merge window, but
in case there is here it is. Only one which affects platforms outside
force_probe and that is the fix for DPT PTE corruption after resume. The
rest are all DG2 specific.
Regards,
Tvrtko
drm-intel-next-fixe
Hi Dave and Daniel,
this is the weekly PR for drm-misc-fixes.
Best regards
Thomas
drm-misc-fixes-2022-10-13:
Short summary of fixes pull:
* vc4: HDMI fixes
The following changes since commit cc62d98bd56d45de4531844ca23913a15136c05b:
Revert "drm: bridge: analogix/dp: add panel prepare/unprep
On Thu, Oct 13, 2022 at 05:29:39PM +0530, Nautiyal, Ankit K wrote:
>
> On 10/13/2022 4:00 PM, Ville Syrjälä wrote:
> > On Thu, Oct 13, 2022 at 10:41:24AM +0530, Ankit Nautiyal wrote:
> >> Defeature Display Interlace support.
> >> Support for Interlace modes is removed from Gen 12 onwards.
> >> For
On 10/13/2022 4:00 PM, Ville Syrjälä wrote:
On Thu, Oct 13, 2022 at 10:41:24AM +0530, Ankit Nautiyal wrote:
Defeature Display Interlace support.
Support for Interlace modes is removed from Gen 12 onwards.
For DP we do not support interlace modes (except for very old
platforms).
Yes we do. Spe
1 - 100 of 116 matches
Mail list logo
