Re: [Intel-gfx] [PATCH 1/2] drm/i915: Do the DRIVER_ATOMIC feature disable later

2022-10-10 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Saturday, October 8, 2022 2:41 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 1/2] drm/i915: Do the DRIVER_ATOMIC feature > disable later > > From: Ville Syrjälä > > Currently we do the D

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Handle BPC for HDMI2.1 PCON without DSC1.2 sink and other fixes (rev3)

2022-10-10 Thread Patchwork
== Series Details == Series: Handle BPC for HDMI2.1 PCON without DSC1.2 sink and other fixes (rev3) URL : https://patchwork.freedesktop.org/series/107550/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./a

[Intel-gfx] [PATCH v3 1/8] drm/i915/dp: Reset frl trained flag before restarting FRL training

2022-10-10 Thread Ankit Nautiyal
For cases where DP has HDMI2.1 sink and FRL Link issues are detected, reset the flag to state FRL trained status before restarting FRL training. Fixes: 9488a030ac91 ("drm/i915: Add support for enabling link status and recovery") Cc: Swati Sharma Cc: Ankit Nautiyal Cc: Uma Shankar (v2) Cc: Jani

[Intel-gfx] [PATCH v3 3/8] drm/i915/display: Add new member to configure PCON color conversion

2022-10-10 Thread Ankit Nautiyal
The decision to use DFP output format conversion capabilities should be during compute_config phase. This patch adds new member to crtc_state to represent the final output_format to the sink. In case of a DFP this can be different than the output_format, as per the format conversion done via the P

[Intel-gfx] [PATCH v3 6/8] drm/i915/dp: Replace intel_dp.dfp members with the new crtc_state sink_format

2022-10-10 Thread Ankit Nautiyal
The decision to use DFP output format conversion capabilities should be during compute_config phase. This patch uses the members of intel_dp->dfp to only store the format conversion capabilities of the DP device and uses the crtc_state sink_format member, to program the protocol-converter for colo

[Intel-gfx] [PATCH v3 4/8] drm/i915/display: Add new member in intel_dp to store ycbcr420 passthrough cap

2022-10-10 Thread Ankit Nautiyal
New member to store the YCBCR20 Pass through capability of the DP sink. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_display_types.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/inte

[Intel-gfx] [PATCH v3 5/8] drm/i915/dp: Use sink_format in dp_is_ycbcr420

2022-10-10 Thread Ankit Nautiyal
Use the new crtc_state member sink_format to check if DP DFP will use YCBCR420. The earlier intel_dp->dfp members are not required as decision to use color format conversion by the PCON is computed and stored in crtc_state. Also drop the intel_dp argument in the helper function. Signed-off-by: Ank

[Intel-gfx] [PATCH v3 8/8] drm/i915/dp: Fix FRL BW check for HDMI2.1 DFP

2022-10-10 Thread Ankit Nautiyal
During FRL bandwidth check for downstream HDMI2.1 sink, the min BPC supported is incorrectly taken for DP, and the check does not consider ybcr420 only modes. This patch fixes the bandwidth calculation similar to the TMDS case, by taking min 8Bpc and considering Ycbcr420 only modes. Signed-off-by

[Intel-gfx] [PATCH v3 7/8] drm/i915/dp: Handle BPP where HDMI2.1 DFP doesn't support DSC

2022-10-10 Thread Ankit Nautiyal
Currently we use the highest input BPC supported by DP sink while using DSC.In cases where PCON with HDMI2.1 as branch device, if PCON supports DSC but HDMI2.1 sink does not supports DSC, The PCON tries to use same input BPC that is used between Source and the PCON without DSC, which might not work

[Intel-gfx] [PATCH v3 2/8] drm/i915/dp: Remove whitespace at the end of function.

2022-10-10 Thread Ankit Nautiyal
Remove extraline left after intel_dp_configure_protocol_converter. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 9133d4c65437..3

[Intel-gfx] [PATCH v3 0/8] Handle BPC for HDMI2.1 PCON without DSC1.2 sink and other fixes

2022-10-10 Thread Ankit Nautiyal
This series fixes issues faced when an HDMI2.1 sink that does not support DSC is connected via HDMI2.1PCON. It also includes other minor HDMI2.1 PCON fixes/refactoring. Patch 1-2 Have minor fixes/cleanups. Patch 3-6 Pull the decision making to use DFP conversion capabilities for every mode during

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Use graphics ver, rel info for media on old platforms

2022-10-10 Thread Patchwork
== Series Details == Series: drm/i915: Use graphics ver, rel info for media on old platforms URL : https://patchwork.freedesktop.org/series/109561/ State : success == Summary == CI Bug Log - changes from CI_DRM_12231_full -> Patchwork_109561v1_full =

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: Warn if not in RC6 when GT is parked

2022-10-10 Thread Dixit, Ashutosh
On Mon, 10 Oct 2022 20:29:23 -0700, Ashutosh Dixit wrote: > > Some i915 modules implicitly assume that there is no user, kernel or > firmware activity after GT is parked. For example, PMU calculations are > incorrect if GT is not in RC6 when GT is parked (outside of the GT > wakeref). Therefore che

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Add DC5 counter and DMC debugfs entries for MTL (rev2)

2022-10-10 Thread Patchwork
== Series Details == Series: drm/i915/display: Add DC5 counter and DMC debugfs entries for MTL (rev2) URL : https://patchwork.freedesktop.org/series/109488/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12231_full -> Patchwork_109488v2_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for Firm up gt park/unpark

2022-10-10 Thread Patchwork
== Series Details == Series: Firm up gt park/unpark URL : https://patchwork.freedesktop.org/series/109563/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12231 -> Patchwork_109563v1 Summary --- **FAILURE** Serious

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Firm up gt park/unpark

2022-10-10 Thread Patchwork
== Series Details == Series: Firm up gt park/unpark URL : https://patchwork.freedesktop.org/series/109563/ State : warning == Summary == Error: dim checkpatch failed 965f7dcab4c4 drm/i915/gt: Don't do display work on platforms without display bced71f23cb7 drm/i915/gt: Warn if not in RC6 when G

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/huc: bump timeout for delayed load and reduce print verbosity (rev2)

2022-10-10 Thread Patchwork
== Series Details == Series: drm/i915/huc: bump timeout for delayed load and reduce print verbosity (rev2) URL : https://patchwork.freedesktop.org/series/109455/ State : success == Summary == CI Bug Log - changes from CI_DRM_12231_full -> Patchwork_109455v2_full ==

[Intel-gfx] [PATCH 2/2] drm/i915/gt: Warn if not in RC6 when GT is parked

2022-10-10 Thread Ashutosh Dixit
Some i915 modules implicitly assume that there is no user, kernel or firmware activity after GT is parked. For example, PMU calculations are incorrect if GT is not in RC6 when GT is parked (outside of the GT wakeref). Therefore check and warn if GT is not in RC6 at the time of parking the GT. Bug:

[Intel-gfx] [PATCH 1/2] drm/i915/gt: Don't do display work on platforms without display

2022-10-10 Thread Ashutosh Dixit
Do display work only on platforms with display. This avoids holding the runtime PM wakeref for an additional 100+ ms after GT has been parked. Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/7025 Signed-off-by: Ashutosh Dixit --- drivers/gpu/drm/i915/gt/intel_gt_pm.c | 36 +++-

[Intel-gfx] [PATCH 0/2] Firm up gt park/unpark

2022-10-10 Thread Ashutosh Dixit
A couple of patches to firm up gt park/unpark. Ashutosh Dixit (2): drm/i915/gt: Don't do display work on platforms without display drm/i915/gt: Warn if not in RC6 when GT is parked drivers/gpu/drm/i915/gt/intel_gt_pm.c | 42 +-- drivers/gpu/drm/i915/gt/intel_rc6.c |

Re: [Intel-gfx] [PATCH v3 07/17] drm/i915/vm_bind: Add support to handle object evictions

2022-10-10 Thread Niranjana Vishwanathapura
On Mon, Oct 10, 2022 at 05:43:47PM -0700, Niranjana Vishwanathapura wrote: On Mon, Oct 10, 2022 at 06:15:02PM +0100, Matthew Auld wrote: On 10/10/2022 17:11, Niranjana Vishwanathapura wrote: On Mon, Oct 10, 2022 at 02:30:49PM +0100, Matthew Auld wrote: On 10/10/2022 07:58, Niranjana Vishwanath

Re: [Intel-gfx] [PATCH v3 07/17] drm/i915/vm_bind: Add support to handle object evictions

2022-10-10 Thread Niranjana Vishwanathapura
On Mon, Oct 10, 2022 at 06:15:02PM +0100, Matthew Auld wrote: On 10/10/2022 17:11, Niranjana Vishwanathapura wrote: On Mon, Oct 10, 2022 at 02:30:49PM +0100, Matthew Auld wrote: On 10/10/2022 07:58, Niranjana Vishwanathapura wrote: Support eviction by maintaining a list of evicted persistent v

Re: [Intel-gfx] [PATCH v3 16/16] drm/i915/perf: Enable OA for DG2

2022-10-10 Thread Dixit, Ashutosh
On Mon, 10 Oct 2022 11:14:34 -0700, Umesh Nerlige Ramappa wrote: > > OA was disabled for DG2 as support was missing. Enable it back now. Reviewed-by: Ashutosh Dixit > Signed-off-by: Umesh Nerlige Ramappa > --- > drivers/gpu/drm/i915/i915_perf.c | 6 -- > 1 file changed, 6 deletions(-) > >

Re: [Intel-gfx] [PATCH v3 15/16] drm/i915/perf: complete programming whitelisting for XEHPSDV

2022-10-10 Thread Dixit, Ashutosh
On Mon, 10 Oct 2022 11:14:33 -0700, Umesh Nerlige Ramappa wrote: > > From: Lionel Landwerlin > > We have an additional register to select which slices contribute to > OAG/OAG counter increments. > > Signed-off-by: Lionel Landwerlin > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/i915_d

Re: [Intel-gfx] [PATCH v3 04/16] drm/i915/perf: Determine gen12 oa ctx offset at runtime

2022-10-10 Thread Dixit, Ashutosh
On Mon, 10 Oct 2022 11:14:22 -0700, Umesh Nerlige Ramappa wrote: Hi Umesh, > diff --git a/drivers/gpu/drm/i915/i915_perf.c > b/drivers/gpu/drm/i915/i915_perf.c > index cd57b5836386..b292aa39633e 100644 > --- a/drivers/gpu/drm/i915/i915_perf.c > +++ b/drivers/gpu/drm/i915/i915_perf.c > @@ -1358,6

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use graphics ver, rel info for media on old platforms

2022-10-10 Thread Patchwork
== Series Details == Series: drm/i915: Use graphics ver, rel info for media on old platforms URL : https://patchwork.freedesktop.org/series/109561/ State : success == Summary == CI Bug Log - changes from CI_DRM_12231 -> Patchwork_109561v1 S

Re: [Intel-gfx] [PATCH 1/5] drm/i915/mtl: Add Support for C10, C20 PHY Message Bus

2022-10-10 Thread Lucas De Marchi
On Thu, Sep 29, 2022 at 04:17:43PM +0300, Mika Kahola wrote: From: Radhakrishna Sripada XELPDP has C10 and C20 phys from Synopsys to drive displays. Each phy has a dedicated PIPE 5.2 Message bus for configuration. This message bus is used to configure the phy internal registers. Bspec: 64599,

[Intel-gfx] [PATCH] drm/i915: Use graphics ver, rel info for media on old platforms

2022-10-10 Thread Radhakrishna Sripada
Platforms prior to MTL do not have a separate media and graphics version. On platforms where GMD id is not supported, reuse the graphics ip version, release info for media. The rest of the IP graphics, display versions would be copied during driver creation. While at it warn if GMD is not used fo

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Add missing vfio_unregister_group_dev() call

2022-10-10 Thread Tian, Kevin
> From: Alex Williamson > Sent: Friday, October 7, 2022 2:31 AM > > On Thu, 6 Oct 2022 08:37:09 -0300 > Jason Gunthorpe wrote: > > > On Wed, Oct 05, 2022 at 04:03:56PM -0600, Alex Williamson wrote: > > > We can't have a .remove callback that does nothing, this breaks > > > removing the device w

Re: [Intel-gfx] [PATCH v2] drm/i915/huc: bump timeout for delayed load and reduce print verbosity

2022-10-10 Thread Ceraolo Spurio, Daniele
On 10/10/2022 3:50 PM, John Harrison wrote: On 10/10/2022 11:48, Daniele Ceraolo Spurio wrote: We're observing sporadic HuC delayed load timeouts in CI, due to mei_pxp binding completing later than we expected. HuC is still loaded when the bind occurs, but in the meantime i915 has started all

Re: [Intel-gfx] [PATCH v2] drm/i915/huc: bump timeout for delayed load and reduce print verbosity

2022-10-10 Thread John Harrison
On 10/10/2022 11:48, Daniele Ceraolo Spurio wrote: We're observing sporadic HuC delayed load timeouts in CI, due to mei_pxp binding completing later than we expected. HuC is still loaded when the bind occurs, but in the meantime i915 has started allowing submission to the VCS engines even if HuC

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add DG2 OA support (rev5)

2022-10-10 Thread Patchwork
== Series Details == Series: Add DG2 OA support (rev5) URL : https://patchwork.freedesktop.org/series/107584/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add DG2 OA support (rev5)

2022-10-10 Thread Patchwork
== Series Details == Series: Add DG2 OA support (rev5) URL : https://patchwork.freedesktop.org/series/107584/ State : warning == Summary == Error: dim checkpatch failed e7d2ddc2181d drm/i915/perf: Fix OA filtering logic for GuC mode 1d70790b1303 drm/i915/perf: Add 32-bit OAG and OAR formats fo

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/pps: Add get_pps_idx() hook as part of pps_get_register() cleanup

2022-10-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/pps: Add get_pps_idx() hook as part of pps_get_register() cleanup URL : https://patchwork.freedesktop.org/series/109547/ State : success == Summary == CI Bug Log - changes from CI_DRM_12230_full -> Patchwork_109547v1_full ==

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Add DC5 counter and DMC debugfs entries for MTL (rev2)

2022-10-10 Thread Patchwork
== Series Details == Series: drm/i915/display: Add DC5 counter and DMC debugfs entries for MTL (rev2) URL : https://patchwork.freedesktop.org/series/109488/ State : success == Summary == CI Bug Log - changes from CI_DRM_12231 -> Patchwork_109488v2 ==

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/huc: bump timeout for delayed load and reduce print verbosity (rev2)

2022-10-10 Thread Patchwork
== Series Details == Series: drm/i915/huc: bump timeout for delayed load and reduce print verbosity (rev2) URL : https://patchwork.freedesktop.org/series/109455/ State : success == Summary == CI Bug Log - changes from CI_DRM_12231 -> Patchwork_109455v2

[Intel-gfx] [PATCH] drm/i915/display: Add DC5 counter and DMC debugfs entries for MTL

2022-10-10 Thread Anusha Srivatsa
MTL and dgfx use the same DC5 counter. While at it, this patch also adds the corresponding debugfs entries. Some cleanup wrt dc3co register which makes the code more readable. Driver loads all firmware that it finds in the firmware binary but platform doesn't *need* all of them. Cleaning the prev

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Improve anti-pre-emption w/a for compute workloads (rev8)

2022-10-10 Thread John Harrison
On 10/6/2022 15:20, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* Improve anti-pre-emption w/a for compute workloads (rev8) *URL:* https://patchwork.freedesktop.org/series/100428/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_1

Re: [Intel-gfx] [PATCH 3/7] drm/i915/uc: use different ggtt pin offsets for uc loads

2022-10-10 Thread John Harrison
On 9/30/2022 16:42, Ceraolo Spurio, Daniele wrote: On 9/30/2022 4:24 PM, John Harrison wrote: On 9/22/2022 15:11, Daniele Ceraolo Spurio wrote: Our current FW loading process is the same for all FWs: - Pin FW to GGTT at the start of the ggtt->uc_fw node - Load the FW - Unpin This worked becau

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pxp: Prepare intel_pxp entry points for MTL (rev2)

2022-10-10 Thread Teres Alexis, Alan Previn
I dont believe either of these failures are related to my changes as ICL and SKL doesn't support PXP and after re- looking at the change to "intel_pxp_is_enabled", I am confident it remains consistent with prior code in that it would return FALSE for any HW without PXP support after it checks "px

[Intel-gfx] [PATCH v2] drm/i915/huc: bump timeout for delayed load and reduce print verbosity

2022-10-10 Thread Daniele Ceraolo Spurio
We're observing sporadic HuC delayed load timeouts in CI, due to mei_pxp binding completing later than we expected. HuC is still loaded when the bind occurs, but in the meantime i915 has started allowing submission to the VCS engines even if HuC is not there. In most of the cases I've observed, the

[Intel-gfx] [PATCH v3 07/16] drm/i915/perf: Move gt-specific data from i915->perf to gt->perf

2022-10-10 Thread Umesh Nerlige Ramappa
Make perf part of gt as the OAG buffer is specific to a gt. The refactor eventually simplifies programming the right OA buffer and the right HW registers when supporting multiple gts. Signed-off-by: Umesh Nerlige Ramappa Reviewed-by: Lionel Landwerlin Reviewed-by: Ashutosh Dixit --- drivers/gp

[Intel-gfx] [PATCH v3 15/16] drm/i915/perf: complete programming whitelisting for XEHPSDV

2022-10-10 Thread Umesh Nerlige Ramappa
From: Lionel Landwerlin We have an additional register to select which slices contribute to OAG/OAG counter increments. Signed-off-by: Lionel Landwerlin Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/i915_pci.c | 1 + drivers/gpu

[Intel-gfx] [PATCH v3 08/16] drm/i915/perf: Replace gt->perf.lock with stream->lock for file ops

2022-10-10 Thread Umesh Nerlige Ramappa
With multi-gt, user can access multiple OA buffers concurrently. Use stream->lock instead of gt->perf.lock to serialize file operations. Signed-off-by: Umesh Nerlige Ramappa Reviewed-by: Ashutosh Dixit --- drivers/gpu/drm/i915/i915_perf.c | 31 -- drivers/gpu/drm/i

[Intel-gfx] [PATCH v3 06/16] drm/i915/perf: Simply use stream->ctx

2022-10-10 Thread Umesh Nerlige Ramappa
Earlier code used exclusive_stream to check for user passed context. Simplify this by accessing stream->ctx. Signed-off-by: Umesh Nerlige Ramappa Reviewed-by: Lionel Landwerlin --- drivers/gpu/drm/i915/i915_perf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/g

[Intel-gfx] [PATCH v3 05/16] drm/i915/perf: Enable bytes per clock reporting in OA

2022-10-10 Thread Umesh Nerlige Ramappa
XEHPSDV and DG2 provide a way to configure bytes per clock vs commands per clock reporting. Enable bytes per clock setting on enabling OA. Bspec: 51762 Bspec: 52201 v2: - Fix commit msg (Ashutosh) - Fix checkpatch issues v3: - s/commands/bytes/ in code comment and commmit msg Signed-off-by: Ume

[Intel-gfx] [PATCH v3 13/16] drm/i915/perf: Save/restore EU flex counters across reset

2022-10-10 Thread Umesh Nerlige Ramappa
If a drm client is killed, then hw contexts used by the client are reset immediately. This reset clears the EU flex counter configuration. If an OA use case is running in parallel, it would start seeing zeroed eu counter values following the reset even if the drm client is restarted. Save/restore t

[Intel-gfx] [PATCH v3 04/16] drm/i915/perf: Determine gen12 oa ctx offset at runtime

2022-10-10 Thread Umesh Nerlige Ramappa
Some SKUs of same gen12 platform may have different oactxctrl offsets. For gen12, determine oactxctrl offsets at runtime. v2: (Lionel) - Move MI definitions to intel_gpu_commands.h - Ensure __find_reg_in_lri does read past context image size v3: (Ashutosh) - Drop unnecessary use of double undersc

[Intel-gfx] [PATCH v3 02/16] drm/i915/perf: Add 32-bit OAG and OAR formats for DG2

2022-10-10 Thread Umesh Nerlige Ramappa
Add new OA formats for DG2. v2: - Update commit title (Ashutosh) - Coding style fixes (Lionel) - 64 bit OA formats need UMD changes in GPUvis, drop for now and send in a separate series with UMD changes v3: - Update commit message to drop 64 bit related description Signed-off-by: Umesh Nerlige

[Intel-gfx] [PATCH v3 14/16] drm/i915/guc: Support OA when Wa_16011777198 is enabled

2022-10-10 Thread Umesh Nerlige Ramappa
From: Vinay Belgaumkar On DG2, a w/a resets RCS/CCS before it goes into RC6. This breaks OA since OA does not expect engine resets during its use. Fix it by disabling RC6. v2: (Ashutosh) - Bring back slpc_unset_param helper - Update commit msg - Use with_intel_runtime_pm helper for set/unset v3

[Intel-gfx] [PATCH v3 16/16] drm/i915/perf: Enable OA for DG2

2022-10-10 Thread Umesh Nerlige Ramappa
OA was disabled for DG2 as support was missing. Enable it back now. Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_perf.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c index c9ab7eaa15ea..cb3c67abb

[Intel-gfx] [PATCH v3 12/16] drm/i915/perf: Apply Wa_18013179988

2022-10-10 Thread Umesh Nerlige Ramappa
OA reports in the OA buffer contain an OA timestamp field that helps user calculate delta between 2 OA reports. The calculation relies on the CS timestamp frequency to convert the timestamp value to nanoseconds. The CS timestamp frequency is a function of the CTC_SHIFT value in RPM_CONFIG0. In DG2

[Intel-gfx] [PATCH v3 11/16] drm/i915/perf: Add Wa_1508761755:dg2

2022-10-10 Thread Umesh Nerlige Ramappa
Disable Clock gating in EU when gathering the events so that EU events are not lost. v2: Fix checkpatch issues Signed-off-by: Umesh Nerlige Ramappa Reviewed-by: Ashutosh Dixit --- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 + drivers/gpu/drm/i915/i915_perf.c| 23 +

[Intel-gfx] [PATCH v3 01/16] drm/i915/perf: Fix OA filtering logic for GuC mode

2022-10-10 Thread Umesh Nerlige Ramappa
With GuC mode of submission, GuC is in control of defining the context id field that is part of the OA reports. To filter reports, UMD and KMD must know what sw context id was chosen by GuC. There is not interface between KMD and GuC to determine this, so read the upper-dword of EXECLIST_STATUS to

[Intel-gfx] [PATCH v3 03/16] drm/i915/perf: Fix noa wait predication for DG2

2022-10-10 Thread Umesh Nerlige Ramappa
Predication for batch buffer commands changed in XEHPSDV. MI_BATCH_BUFFER_START predicates based on MI_SET_PREDICATE_RESULT register. The MI_SET_PREDICATE_RESULT register can only be modified with MI_SET_PREDICATE command. When configured, the MI_SET_PREDICATE command sets MI_SET_PREDICATE_RESULT b

[Intel-gfx] [PATCH v3 09/16] drm/i915/perf: Use gt-specific ggtt for OA and noa-wait buffers

2022-10-10 Thread Umesh Nerlige Ramappa
User passes uabi engine class and instance to the perf OA interface. Use gt corresponding to the engine to pin the buffers to the right ggtt. Signed-off-by: Umesh Nerlige Ramappa Reviewed-by: Lionel Landwerlin --- drivers/gpu/drm/i915/i915_perf.c | 21 +++-- 1 file changed, 19 i

[Intel-gfx] [PATCH v3 10/16] drm/i915/perf: Store a pointer to oa_format in oa_buffer

2022-10-10 Thread Umesh Nerlige Ramappa
DG2 introduces OA reports with 64 bit report header fields. Perf OA would need more information about the OA format in order to process such reports. Store all OA format info in oa_buffer instead of just the size and format-id. v2: Drop format_size variable (Ashutosh) Signed-off-by: Umesh Nerlige

[Intel-gfx] [PATCH v3 00/16] Add DG2 OA support

2022-10-10 Thread Umesh Nerlige Ramappa
Add OA format support for DG2 and various fixes for DG2. This series has 2 uapi changes listed below: 1) drm/i915/perf: Add OAG and OAR formats for DG2 DG2 has new OA formats defined that can be selected by the user. The UMD changes that are consumed by GPUvis are: https://patchwork.freedesktop.

Re: [Intel-gfx] [PATCH v3 07/17] drm/i915/vm_bind: Add support to handle object evictions

2022-10-10 Thread Matthew Auld
On 10/10/2022 17:11, Niranjana Vishwanathapura wrote: On Mon, Oct 10, 2022 at 02:30:49PM +0100, Matthew Auld wrote: On 10/10/2022 07:58, Niranjana Vishwanathapura wrote: Support eviction by maintaining a list of evicted persistent vmas for rebinding during next submission. Ensure the list do no

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/slpc: Update the frequency debugfs

2022-10-10 Thread Rodrigo Vivi
On Thu, Oct 06, 2022 at 05:24:34PM -0400, Rodrigo Vivi wrote: > On Wed, Oct 05, 2022 at 08:59:43AM -0700, Vinay Belgaumkar wrote: > > Read the values stored in the SLPC structures. Remove the > > fields that are no longer valid (like RPS interrupts) as > > well. > > > > v2: Move all functionality

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/pps: Add get_pps_idx() hook as part of pps_get_register() cleanup

2022-10-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/pps: Add get_pps_idx() hook as part of pps_get_register() cleanup URL : https://patchwork.freedesktop.org/series/109547/ State : success == Summary == CI Bug Log - changes from CI_DRM_12230 -> Patchwork_109547v1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/pps: Add get_pps_idx() hook as part of pps_get_register() cleanup

2022-10-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/pps: Add get_pps_idx() hook as part of pps_get_register() cleanup URL : https://patchwork.freedesktop.org/series/109547/ State : warning == Summary == Error: dim checkpatch failed 25167c11f19e drm/i915/pps: Add get_pps_idx() hoo

Re: [Intel-gfx] [PATCH v3 07/17] drm/i915/vm_bind: Add support to handle object evictions

2022-10-10 Thread Niranjana Vishwanathapura
On Mon, Oct 10, 2022 at 02:30:49PM +0100, Matthew Auld wrote: On 10/10/2022 07:58, Niranjana Vishwanathapura wrote: Support eviction by maintaining a list of evicted persistent vmas for rebinding during next submission. Ensure the list do not include persistent vmas that are being purged. v2: R

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pps: Enable 2nd pps for dual EDP scenario

2022-10-10 Thread Manna, Animesh
> -Original Message- > From: Nikula, Jani > Sent: Tuesday, October 4, 2022 1:19 PM > To: Manna, Animesh ; intel- > g...@lists.freedesktop.org > Cc: Manna, Animesh ; Ville Syrjälä > ; Shankar, Uma > Subject: Re: [PATCH 2/2] drm/i915/pps: Enable 2nd pps for dual EDP scenario > > On Tue,

[Intel-gfx] [PATCH 2/2] drm/i915/pps: Enable 2nd pps for dual EDP scenario

2022-10-10 Thread Animesh Manna
>From display gen12 onwards to support dual EDP two instances of pps added. Currently backlight controller and pps instance can be mapped together for a specific panel. Currently dual PPS support is broken. This patch fixes it and enables for display 12+. v1: Iniital revision. v2: Called intel_bio

[Intel-gfx] [PATCH 1/2] drm/i915/pps: Add get_pps_idx() hook as part of pps_get_register() cleanup

2022-10-10 Thread Animesh Manna
Simplified pps_get_register() which use get_pps_idx() hook to derive the pps instance and get_pps_idx() will be initialized at pps_init(). v1: Initial version. Got r-b from Jani. Cc: Jani Nikula Cc: Ville Syrjälä Cc: Uma Shankar Signed-off-by: Animesh Manna --- .../gpu/drm/i915/display/intel

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry (rev5)

2022-10-10 Thread Patchwork
== Series Details == Series: drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry (rev5) URL : https://patchwork.freedesktop.org/series/108732/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12230 -> Patchwork_108732v5 S

Re: [Intel-gfx] [PATCH v3 1/4] drm/i915/display: remove drm_device aliases

2022-10-10 Thread Jani Nikula
On Mon, 10 Oct 2022, Andi Shyti wrote: > On Thu, Oct 06, 2022 at 10:48:44PM +0200, Andrzej Hajda wrote: >> drm_device pointers are unwelcome. >> >> Signed-off-by: Andrzej Hajda > > Acked-by: Andi Shyti > > To me both versions were good... > > Jani, Ville, could you please check on this patch?

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry (rev5)

2022-10-10 Thread Patchwork
== Series Details == Series: drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry (rev5) URL : https://patchwork.freedesktop.org/series/108732/ State : warning == Summary == Error: dim checkpatch failed 179c557abab8 drm/i915/gvt: fix double free bug in split_2MB_gtt_entry -:58: CHECK:PAREN

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/2] drm/i915/display: fix randconfig build (rev2)

2022-10-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display: fix randconfig build (rev2) URL : https://patchwork.freedesktop.org/series/109542/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/109542/revisions/2/mbox/ not applied Applyi

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gvt: remove unneeded semicolon

2022-10-10 Thread Patchwork
== Series Details == Series: drm/i915/gvt: remove unneeded semicolon URL : https://patchwork.freedesktop.org/series/109543/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/109543/revisions/1/mbox/ not applied Applying: drm/i915/gvt: remove unneeded

Re: [Intel-gfx] [PATCH v3 1/4] drm/i915/display: remove drm_device aliases

2022-10-10 Thread Andi Shyti
On Thu, Oct 06, 2022 at 10:48:44PM +0200, Andrzej Hajda wrote: > drm_device pointers are unwelcome. > > Signed-off-by: Andrzej Hajda Acked-by: Andi Shyti To me both versions were good... Jani, Ville, could you please check on this patch? Andi > --- > drivers/gpu/drm/i915/display/icl_dsi.c

[Intel-gfx] [PATCH v3] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

2022-10-10 Thread Zheng Wang
If intel_gvt_dma_map_guest_page failed, it will call ppgtt_invalidate_spt, which will finally free the spt. But the caller does not notice that, it will free spt again in error path. Fix this by spliting invalidate and free in ppgtt_invalidate_spt. Only free spt when in good case. Reported-by: Zh

Re: [Intel-gfx] [PATCH 1/2] drm/i915/display: fix randconfig build

2022-10-10 Thread Jiri Slaby
On 04. 10. 22, 12:52, Jani Nikula wrote: On Tue, 04 Oct 2022, "Jiri Slaby (SUSE)" wrote: When DRM_I915=y and BACKLIGHT_CLASS_DEVICE=m, the build fails: ld: drivers/gpu/drm/i915/display/intel_backlight.o: in function `intel_backlight_device_register': intel_backlight.c:(.text+0x5587): undefined

[Intel-gfx] [PATCH v2] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

2022-10-10 Thread Zheng Wang
If intel_gvt_dma_map_guest_page failed, it will call ppgtt_invalidate_spt, which will finally free the spt. But the caller does not notice that, it will free spt again in error path. Fix this by spliting invalidate and free in ppgtt_invalidate_spt. Only free spt when in good case. Reported-by: Zh

Re: [Intel-gfx] Regression on 5.19.12, display flickering on Framework laptop

2022-10-10 Thread David Matthew Mattli
Thorsten Leemhuis writes:> On 03.10.22 19:48, Ville Syrjälä wrote:>> On Mon, Oct 03, 2022 at 08:45:18PM +0300, Ville Syrjälä wrote:>>> On Sat, Oct 01, 2022 at 12:07:39PM +0200, Thorsten Leemhuis wrote: On 30.09.22 14:26, Jerry Ling wrote:>> looks like someone has done it:> https://

[Intel-gfx] [PATCH -next] drm/i915/gvt: remove unneeded semicolon

2022-10-10 Thread Yang Li
Remove the redundant semicolon Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2333 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/i915/gvt/vgpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/vgpu.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 1/2] drm/i915/display: fix randconfig build

2022-10-10 Thread Jiri Slaby (SUSE)
When DRM_I915=y and BACKLIGHT_CLASS_DEVICE=m, the build fails: ld: drivers/gpu/drm/i915/display/intel_backlight.o: in function `intel_backlight_device_register': intel_backlight.c:(.text+0x5587): undefined reference to `backlight_device_get_by_name' ld: drivers/gpu/drm/i915/display/intel_backlig

[Intel-gfx] [PATCH 2/2] drm/i915: remove circ_buf.h includes

2022-10-10 Thread Jiri Slaby (SUSE)
The last user of macros from that include was removed in 2018 by the commit below. Fixes: 6cc42152b02b ("drm/i915: Remove support for legacy debugfs crc interface") Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: intel-gfx@lists

Re: [Intel-gfx] [PATCH v3 07/17] drm/i915/vm_bind: Add support to handle object evictions

2022-10-10 Thread Matthew Auld
On 10/10/2022 07:58, Niranjana Vishwanathapura wrote: Support eviction by maintaining a list of evicted persistent vmas for rebinding during next submission. Ensure the list do not include persistent vmas that are being purged. v2: Remove unused I915_VMA_PURGED definition. v3: Properly handle __

[Intel-gfx] ✗ Fi.CI.IGT: failure for Provision to ignore long HPDs in CI systems (rev2)

2022-10-10 Thread Patchwork
== Series Details == Series: Provision to ignore long HPDs in CI systems (rev2) URL : https://patchwork.freedesktop.org/series/109475/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12227_full -> Patchwork_109475v2_full Summ

Re: [Intel-gfx] [PATCH v4 00/30] drm: Analog TV Improvements

2022-10-10 Thread Maxime Ripard
On Sat, Oct 01, 2022 at 03:12:06PM +0200, Noralf Trønnes wrote: > > > Den 29.09.2022 18.30, skrev Maxime Ripard: > > Hi, > > > > Here's a series aiming at improving the command line named modes support, > > and more importantly how we deal with all the analog TV variants. > > > > The named mode

Re: [Intel-gfx] (subset) [PATCH v4 25/30] drm/vc4: vec: Fix definition of PAL-M mode

2022-10-10 Thread Maxime Ripard
On Thu, 29 Sep 2022 18:31:19 +0200, Maxime Ripard wrote: > From: Mateusz Kwiatkowski > > PAL-M is a Brazilian analog TV standard that uses a PAL-style chroma > subcarrier at 3.575611[888111] MHz on top of 525-line (480i60) timings. > This commit makes the driver actually use the proper VEC preset

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/display: ignore long HPDs based on a flag

2022-10-10 Thread Govindapillai, Vinod
On Mon, 2022-10-10 at 14:08 +0200, Andrzej Hajda wrote: > On 10.10.2022 10:34, Vinod Govindapillai wrote: > > Some panels generate long HPD events even while connected to > > the port. This cause some unexpected CI execution issues. A > > new flag is added to track if such spurious long HPDs can be

Re: [Intel-gfx] (subset) [PATCH v4 13/30] drm/modes: parse_cmdline: Add support for named modes containing dashes

2022-10-10 Thread Maxime Ripard
On Thu, 29 Sep 2022 18:31:07 +0200, Maxime Ripard wrote: > From: Geert Uytterhoeven > > It is fairly common for named video modes to contain dashes (e.g. > "tt-mid" on Atari, "dblntsc-ff" on Amiga). Currently such mode names > are not recognized, as the dash is considered to be a separator betwe

Re: [Intel-gfx] (subset) [PATCH v4 12/30] drm/modes: Only consider bpp and refresh before options

2022-10-10 Thread Maxime Ripard
On Thu, 29 Sep 2022 18:31:06 +0200, Maxime Ripard wrote: > Some video= options might have a value that contains a dash. However, the > command line parsing mode considers all dashes as the separator between the > mode and the bpp count. > > Let's rework the parsing code a bit to only consider a da

Re: [Intel-gfx] (subset) [PATCH v4 06/30] drm/atomic: Add TV subconnector property to get/set_property

2022-10-10 Thread Maxime Ripard
On Thu, 29 Sep 2022 18:31:00 +0200, Maxime Ripard wrote: > The subconnector property was created by drm_mode_create_tv_properties(), > but wasn't exposed to the userspace through the generic > atomic_get/set_property implementation, and wasn't stored in any generic > state structure. > > Let's sol

Re: [Intel-gfx] (subset) [PATCH v4 05/30] drm/connector: Rename subconnector state variable

2022-10-10 Thread Maxime Ripard
On Thu, 29 Sep 2022 18:30:59 +0200, Maxime Ripard wrote: > There is two TV subconnector related properties registered by > drm_mode_create_tv_properties(): subconnector and select subconnector. > > While the select subconnector property is stored in the kernel by the > drm_tv_connector_state struc

Re: [Intel-gfx] (subset) [PATCH v4 04/30] drm/atomic-helper: Rename drm_atomic_helper_connector_tv_reset to avoid ambiguity

2022-10-10 Thread Maxime Ripard
On Thu, 29 Sep 2022 18:30:58 +0200, Maxime Ripard wrote: > We currently have two sets of TV properties. > > The first one is there to deal with analog TV properties, creating > properties such as the TV mode, subconnectors, saturation, hue and so on. > It's created by calling the drm_mode_create_t

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/display: debugfs entry to control ignore long hpd flag

2022-10-10 Thread Andrzej Hajda
On 10.10.2022 10:34, Vinod Govindapillai wrote: Knob to control ignoring the long hpds. Set this to true will start ignoring the long HPDs generated by the displays. Useful for use cases like CI systems where we dont expect to disconnect the panels. v2: Address patch styling comments (Jani Nikul

Re: [Intel-gfx] (subset) [PATCH v4 02/30] drm/tests: Order Kunit tests in Makefile

2022-10-10 Thread Maxime Ripard
On Thu, 29 Sep 2022 18:30:56 +0200, Maxime Ripard wrote: > Since we've recently added a ton of tests, the list starts to be a bit > of a mess and creates unneeded conflicts. > > Let's order it alphabetically. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/display: ignore long HPDs based on a flag

2022-10-10 Thread Andrzej Hajda
On 10.10.2022 10:34, Vinod Govindapillai wrote: Some panels generate long HPD events even while connected to the port. This cause some unexpected CI execution issues. A new flag is added to track if such spurious long HPDs can be ignored and are not processed further if the flag is set. v2: Addr

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Enable atomic by default on ctg/elk

2022-10-10 Thread Jani Nikula
On Sat, 08 Oct 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > The watermark code for ctg/elk has been atomic ready for a long time > so let's just flip the switch now that some of the last CxSR issues > have been sorted out (which granted was a problem for vlv/chv as well > despite them alr

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Do the DRIVER_ATOMIC feature disable later

2022-10-10 Thread Jani Nikula
On Sat, 08 Oct 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently we do the DRIVER_ATOMIC disable as almost the > first thing during pci probe. That involves the use of > DISPLAY_VER() which is perhaps a bit sketchy now that we > may need to read that out from the hardware itself. > L

Re: [Intel-gfx] [PATCH i-g-t] tests/i915/module_load: fix resize-bar on DG1

2022-10-10 Thread Das, Nirmoy
On 10/10/2022 12:48 PM, Matthew Auld wrote: DG1, as expected only has a fixed sized bar, so attempting to force the BAR size should fail. Update the test to account for such devices, and perform a skip, instead of failing. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6458 Signed-o

[Intel-gfx] [PATCH i-g-t] tests/i915/module_load: fix resize-bar on DG1

2022-10-10 Thread Matthew Auld
DG1, as expected only has a fixed sized bar, so attempting to force the BAR size should fail. Update the test to account for such devices, and perform a skip, instead of failing. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6458 Signed-off-by: Matthew Auld Cc: Nirmoy Das --- tests/

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/vm_bind: Add VM_BIND functionality (rev6)

2022-10-10 Thread Patchwork
== Series Details == Series: drm/i915/vm_bind: Add VM_BIND functionality (rev6) URL : https://patchwork.freedesktop.org/series/105879/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12227_full -> Patchwork_105879v6_full Summ

[Intel-gfx] ✓ Fi.CI.BAT: success for Provision to ignore long HPDs in CI systems (rev2)

2022-10-10 Thread Patchwork
== Series Details == Series: Provision to ignore long HPDs in CI systems (rev2) URL : https://patchwork.freedesktop.org/series/109475/ State : success == Summary == CI Bug Log - changes from CI_DRM_12227 -> Patchwork_109475v2 Summary --

Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Provision to ignore long HPDs in CI systems (rev2)

2022-10-10 Thread Govindapillai, Vinod
When tried locally, dim sparse were ok! --- Sparse version: 0.6.4 (Ubuntu: 0.6.4-2) Commit: drm/i915/display: ignore long HPDs based on a flag Okay! Commit: drm/i915/display: debugfs entry to control ignore long hpd flag Okay! --- BR vinod On Mon, 2022-10-10 at 08:52 +, Patchwork wrote:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Provision to ignore long HPDs in CI systems (rev2)

2022-10-10 Thread Patchwork
== Series Details == Series: Provision to ignore long HPDs in CI systems (rev2) URL : https://patchwork.freedesktop.org/series/109475/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

  1   2   >