[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix CFI violations in gt_sysfs

2022-09-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix CFI violations in gt_sysfs URL : https://patchwork.freedesktop.org/series/108917/ State : success == Summary == CI Bug Log - changes from CI_DRM_12168_full -> Patchwork_108917v1_full Summary --

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: Don't use port enum as register offset (rev3)

2022-09-22 Thread Patchwork
== Series Details == Series: drm/i915/display: Don't use port enum as register offset (rev3) URL : https://patchwork.freedesktop.org/series/108833/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH v2 0/1] Add PXP firmware respose on ARB failure

2022-09-22 Thread Alan Previn
Add PXP firmware respose on ARB failure Changes: v1: Fix checkpatch warning Signed-off-by: Alan Previn Alan Previn (1): drm/i915/pxp: Add firmware status when ARB session fails drivers/gpu/drm/i915/pxp/intel_pxp_session.c | 1 + drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 3 +++ 2 fil

[Intel-gfx] [PATCH v2 1/1] drm/i915/pxp: Add firmware status when ARB session fails

2022-09-22 Thread Alan Previn
Add firmware status using a drm_warn when ARB session fails or else a drm_dbg when the ARB session register slot bit did get set. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp_session.c | 1 + drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 3 +++ 2 files changed, 4 insertions

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Mark FBC B gone if pipe B is gone

2022-09-22 Thread Luca Coelho
On Thu, 2022-09-22 at 14:57 +0300, Ville Syrjälä wrote: > On Thu, Sep 22, 2022 at 02:37:35PM +0300, Luca Coelho wrote: > > On Thu, 2022-09-22 at 12:36 +0300, Ville Syrjälä wrote: > > > On Thu, Sep 22, 2022 at 11:51:16AM +0300, Jani Nikula wrote: > > > > On Thu, 22 Sep 2022, Ville Syrjälä > > > >

Re: [Intel-gfx] [PATCH v2] drm/i915/psr: Fix PSR_IMR/IIR field handling

2022-09-22 Thread Hogander, Jouni
On Thu, 2022-09-22 at 13:08 +, Souza, Jose wrote: > On Thu, 2022-09-22 at 10:59 +0300, Jouni Högander wrote: > > Current PSR code is supposed to use TRANSCODER_EDP to force 0 shift > > for > > bits in PSR_IMR/IIR registers: > > > > /* > >  * gen12+ has registers relative to transcoder and one

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix TC port PLLs after readout (rev4)

2022-09-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix TC port PLLs after readout (rev4) URL : https://patchwork.freedesktop.org/series/108847/ State : success == Summary == CI Bug Log - changes from CI_DRM_12168_full -> Patchwork_108847v4_full Summary

[Intel-gfx] [PATCH v3 1/1] drm/i915/guc: Delay disabling guc_id scheduling for better hysteresis

2022-09-22 Thread Alan Previn
From: Matthew Brost Add a delay, configurable via debugfs (default 34ms), to disable scheduling of a context after the pin count goes to zero. Disable scheduling is a costly operation as it requires synchronizing with the GuC. So the idea is that a delay allows the user to resubmit something befo

[Intel-gfx] [PATCH v3 0/1] Delay disabling GuC scheduling of an idle context

2022-09-22 Thread Alan Previn
This series adds a delay before disabling scheduling of the guc-context when a context has become idle to avoid costly re-registration that may occur immediately after. The 2nd patch should explain it quite well. The origin of this series was posted by Matthew Brost back in Oct 2021 (https://patch

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix TypeC mode initialization during system resume

2022-09-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix TypeC mode initialization during system resume URL : https://patchwork.freedesktop.org/series/108914/ State : success == Summary == CI Bug Log - changes from CI_DRM_12168_full -> Patchwork_108914v1_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Move hotplug inversion logic into separate helper (rev2)

2022-09-22 Thread Patchwork
== Series Details == Series: drm/i915: Move hotplug inversion logic into separate helper (rev2) URL : https://patchwork.freedesktop.org/series/108742/ State : success == Summary == CI Bug Log - changes from CI_DRM_12168_full -> Patchwork_108742v2_full ==

Re: [Intel-gfx] [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval

2022-09-22 Thread Dixit, Ashutosh
On Thu, 22 Sep 2022 19:51:45 -0700, Dixit, Ashutosh wrote: > > On Thu, 22 Sep 2022 00:13:00 -0700, Gupta, Anshuman wrote: > > > > Hi Anshuman, > > > > +static ssize_t > > > +hwm_power1_max_interval_store(struct device *dev, > > > + struct device_attribute *attr, > > > +

Re: [Intel-gfx] [PATCH 1/1] drm/i915/guc/slpc: Add SLPC selftest live_slpc_power

2022-09-22 Thread Belgaumkar, Vinay
On 9/22/2022 7:32 AM, Riana Tauro wrote: A fundamental assumption is that at lower frequencies, not only do we run slower, but we save power compared to higher frequencies. live_slpc_power checks if running at low frequency saves power Signed-off-by: Riana Tauro --- drivers/gpu/drm/i915/gt/

[Intel-gfx] ✓ Fi.CI.BAT: success for Add PXP firmware respose on ARB failure

2022-09-22 Thread Patchwork
== Series Details == Series: Add PXP firmware respose on ARB failure URL : https://patchwork.freedesktop.org/series/108929/ State : success == Summary == CI Bug Log - changes from CI_DRM_12169 -> Patchwork_108929v1 Summary --- **SUCC

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add PXP firmware respose on ARB failure

2022-09-22 Thread Patchwork
== Series Details == Series: Add PXP firmware respose on ARB failure URL : https://patchwork.freedesktop.org/series/108929/ State : warning == Summary == Error: dim checkpatch failed f4915d5d33c2 drm/i915/pxp: Add firmware status when ARB session fails -:33: WARNING:LONG_LINE: line length of 1

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/1] drm/i915/pxp: Add firmware status when ARB session fails

2022-09-22 Thread Patchwork
== Series Details == Series: series starting with [1/1] drm/i915/pxp: Add firmware status when ARB session fails URL : https://patchwork.freedesktop.org/series/108928/ State : success == Summary == CI Bug Log - changes from CI_DRM_12169 -> Patchwork_108928v1 ==

Re: [Intel-gfx] [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval

2022-09-22 Thread Dixit, Ashutosh
On Thu, 22 Sep 2022 00:13:00 -0700, Gupta, Anshuman wrote: > Hi Anshuman, > > +static ssize_t > > +hwm_power1_max_interval_store(struct device *dev, > > + struct device_attribute *attr, > > + const char *buf, size_t count) > > +{ > > + struct hwm_

Re: [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2022-09-22 Thread Dixit, Ashutosh
On Thu, 22 Sep 2022 00:08:46 -0700, Gupta, Anshuman wrote: > Hi Anshuman, > On 9/21/2022 8:23 PM, Nilawar, Badal wrote: > > > > On 21-09-2022 17:15, Gupta, Anshuman wrote: > >> > >>> +static int > >>> +hwm_power_read(struct hwm_drvdata *ddat, u32 attr, int chan, long *val) > >>> +{ > >>> +    str

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: prepare for uC loading on MTL

2022-09-22 Thread Patchwork
== Series Details == Series: drm/i915: prepare for uC loading on MTL URL : https://patchwork.freedesktop.org/series/108925/ State : success == Summary == CI Bug Log - changes from CI_DRM_12168 -> Patchwork_108925v1 Summary --- **SUCC

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: prepare for uC loading on MTL

2022-09-22 Thread Patchwork
== Series Details == Series: drm/i915: prepare for uC loading on MTL URL : https://patchwork.freedesktop.org/series/108925/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: prepare for uC loading on MTL

2022-09-22 Thread Patchwork
== Series Details == Series: drm/i915: prepare for uC loading on MTL URL : https://patchwork.freedesktop.org/series/108925/ State : warning == Summary == Error: dim checkpatch failed c6f416737aa1 drm/i915/huc: only load HuC on GTs that have VCS engines 946fd3c4cb17 drm/i915/uc: fetch uc firmwa

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove unused function parameter (rev2)

2022-09-22 Thread Patchwork
== Series Details == Series: drm/i915: Remove unused function parameter (rev2) URL : https://patchwork.freedesktop.org/series/108863/ State : success == Summary == CI Bug Log - changes from CI_DRM_12168 -> Patchwork_108863v2 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Remove unused function parameter (rev2)

2022-09-22 Thread Patchwork
== Series Details == Series: drm/i915: Remove unused function parameter (rev2) URL : https://patchwork.freedesktop.org/series/108863/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for DG2 fix for CCS starvation

2022-09-22 Thread Patchwork
== Series Details == Series: DG2 fix for CCS starvation URL : https://patchwork.freedesktop.org/series/108919/ State : success == Summary == CI Bug Log - changes from CI_DRM_12168 -> Patchwork_108919v1 Summary --- **SUCCESS** No r

[Intel-gfx] [PATCH 0/1] Add PXP firmware respose on ARB failure

2022-09-22 Thread Alan Previn
Add PXP firmware respose on ARB failure Signed-off-by: Alan Previn Alan Previn (1): drm/i915/pxp: Add firmware status when ARB session fails drivers/gpu/drm/i915/pxp/intel_pxp_session.c | 1 + drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 2 ++ 2 files changed, 3 insertions(+) base-commit

[Intel-gfx] [PATCH 1/1] drm/i915/pxp: Add firmware status when ARB session fails

2022-09-22 Thread Alan Previn
Add firmware status using a drm_warn when ARB session fails or else a drm_dbg when the ARB session register slot bit did get set. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp_session.c | 1 + drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 2 ++ 2 files changed, 3 insertions(

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for DG2 fix for CCS starvation

2022-09-22 Thread Patchwork
== Series Details == Series: DG2 fix for CCS starvation URL : https://patchwork.freedesktop.org/series/108919/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix CFI violations in gt_sysfs

2022-09-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix CFI violations in gt_sysfs URL : https://patchwork.freedesktop.org/series/108917/ State : success == Summary == CI Bug Log - changes from CI_DRM_12168 -> Patchwork_108917v1 Summary --- **SUC

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix CFI violations in gt_sysfs

2022-09-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix CFI violations in gt_sysfs URL : https://patchwork.freedesktop.org/series/108917/ State : warning == Summary == Error: dim checkpatch failed 8f1e51a50839 drm/i915: Fix CFI violations in gt_sysfs -:76: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped c

[Intel-gfx] [PATCH 1/1] drm/i915/pxp: Add firmware status when ARB session fails

2022-09-22 Thread Alan Previn
Add firmware status using a drm_warn when ARB session fails or else a drm_dbg when the ARB session register slot bit did get set. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp_session.c | 1 + drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 2 ++ 2 files changed, 3 insertions(

[Intel-gfx] (no subject)

2022-09-22 Thread Alan Previn
Subject: [PATCH 0/1] Add PXP firmware respose on ARB failure Add PXP firmware respose on ARB failure Signed-off-by: Alan Previn Alan Previn (1): drm/i915/pxp: Add firmware status when ARB session fails drivers/gpu/drm/i915/pxp/intel_pxp_session.c | 1 + drivers/gpu/drm/i915/pxp/intel_pxp_te

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix TC port PLLs after readout (rev4)

2022-09-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix TC port PLLs after readout (rev4) URL : https://patchwork.freedesktop.org/series/108847/ State : success == Summary == CI Bug Log - changes from CI_DRM_12168 -> Patchwork_108847v4 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix TC port PLLs after readout (rev4)

2022-09-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix TC port PLLs after readout (rev4) URL : https://patchwork.freedesktop.org/series/108847/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bit

[Intel-gfx] ✓ Fi.CI.IGT: success for Add SLPC selftest live_slpc_power

2022-09-22 Thread Patchwork
== Series Details == Series: Add SLPC selftest live_slpc_power URL : https://patchwork.freedesktop.org/series/108900/ State : success == Summary == CI Bug Log - changes from CI_DRM_12167_full -> Patchwork_108900v1_full Summary --- **

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix TypeC mode initialization during system resume

2022-09-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix TypeC mode initialization during system resume URL : https://patchwork.freedesktop.org/series/108914/ State : success == Summary == CI Bug Log - changes from CI_DRM_12168 -> Patchwork_108914v1 Summ

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move hotplug inversion logic into separate helper (rev2)

2022-09-22 Thread Patchwork
== Series Details == Series: drm/i915: Move hotplug inversion logic into separate helper (rev2) URL : https://patchwork.freedesktop.org/series/108742/ State : success == Summary == CI Bug Log - changes from CI_DRM_12168 -> Patchwork_108742v2

[Intel-gfx] [PATCH 4/7] drm/i915/guc: Add GuC deprivilege feature to MTL

2022-09-22 Thread Daniele Ceraolo Spurio
From: Stuart Summers MTL supports GuC deprivilege. Add the feature flag to this platform. Signed-off-by: Stuart Summers Cc: Radhakrishna Sripada Cc: John Harrison Cc: Alan Previn --- drivers/gpu/drm/i915/i915_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/i91

[Intel-gfx] [PATCH 7/7] drm/i915/guc: handle interrupts from media GuC

2022-09-22 Thread Daniele Ceraolo Spurio
The render and media GuCs share the same interrupt enable register, so we can no longer disable interrupts when we disable communication for one of the GuCs as this would impact the other GuC. Instead, we keep the interrupts always enabled in HW and use a variable in the GuC structure to determine

[Intel-gfx] [PATCH 3/7] drm/i915/uc: use different ggtt pin offsets for uc loads

2022-09-22 Thread Daniele Ceraolo Spurio
Our current FW loading process is the same for all FWs: - Pin FW to GGTT at the start of the ggtt->uc_fw node - Load the FW - Unpin This worked because we didn't have a case where 2 FWs would be loaded on the same GGTT at the same time. On MTL, however, this can happend if both GTs are reset at t

[Intel-gfx] [PATCH 6/7] drm/i915/guc: define media GT GuC send regs

2022-09-22 Thread Daniele Ceraolo Spurio
The media GT shares the G-unit with the root GT, so a second set of communication registers is required for the media GuC. Signed-off-by: Daniele Ceraolo Spurio Cc: John Harrison Cc: Alan Previn --- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 14 ++ drivers/gpu/drm/i915/gt/uc/inte

[Intel-gfx] [PATCH 5/7] drm/i915/mtl: Handle wopcm per-GT and limit calculations.

2022-09-22 Thread Daniele Ceraolo Spurio
From: Aravind Iddamsetty With MTL standalone media architecture the wopcm layout has changed with separate partitioning in WOPCM for GCD/GT GuC and SA Media GuC. The size of WOPCM is 4MB with lower 2MB for SA Media and upper 2MB for GCD/GT. +=+===> ++ <== WOPCM TOP

[Intel-gfx] [PATCH 2/7] drm/i915/uc: fetch uc firmwares for each GT

2022-09-22 Thread Daniele Ceraolo Spurio
The FW binaries are independently loaded on each GT. On MTL, the memory is shared so we could potentially re-use a single allocation, but on discrete multi-gt platforms we are going to need independent copies, so it is easier to do the same on MTL as well, given that the amount of duplicated memory

[Intel-gfx] [PATCH 1/7] drm/i915/huc: only load HuC on GTs that have VCS engines

2022-09-22 Thread Daniele Ceraolo Spurio
On MTL the primary GT doesn't have any media capabilities, so no video engines and no HuC. We must therefore skip the HuC fetch and load on that specific case. Given that other multi-GT platforms might have HuC on the primary GT, we can't just check for that and it is easier to instead check for th

[Intel-gfx] [PATCH 0/7] drm/i915: prepare for uC loading on MTL

2022-09-22 Thread Daniele Ceraolo Spurio
The introduction of the media GT brings a few changes for GuC/HuC. The main difference between the 2 GTs is that only the media one has the HuC, while both have the GuC. Also, the fact that both GTs use the same G-unit and GGTT means we now have parallel interrupt/communication paths. Lastly, WOPCM

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix double word in comments

2022-09-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix double word in comments URL : https://patchwork.freedesktop.org/series/108886/ State : success == Summary == CI Bug Log - changes from CI_DRM_12167_full -> Patchwork_108886v1_full Summary ---

Re: [Intel-gfx] [PATCH 1/1] drm/i915/guc: Enable compute scheduling on DG2

2022-09-22 Thread Umesh Nerlige Ramappa
On Thu, Sep 22, 2022 at 01:12:09PM -0700, john.c.harri...@intel.com wrote: From: John Harrison DG2 has issues. To work around one of these the GuC must schedule apps in an exclusive manner across both RCS and CCS. That is, if a context from app X is running on RCS then all CCS engines must sit

[Intel-gfx] [PATCH] drm/i915: Remove unused function parameter

2022-09-22 Thread Niranjana Vishwanathapura
The function parameter 'exclude' in funciton i915_sw_fence_await_reservation() is not used. Remove it. Reviewed-by: Tvrtko Ursulin Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 5 ++--- drivers/gpu/drm/i915/gem/i915_gem_clflush.c | 2 +-

Re: [Intel-gfx] [PATCH v2 08/33] drm/connector: Rename drm_mode_create_tv_properties

2022-09-22 Thread Lyude Paul
For nouveau: Reviewed-by: Lyude Paul On Thu, 2022-09-22 at 16:25 +0200, Maxime Ripard wrote: > drm_mode_create_tv_properties(), among other things, will create the > "mode" property that stores the analog TV mode that connector is > supposed to output. > > However, that property is getting depr

Re: [Intel-gfx] [PATCH v2 06/33] drm/connector: Rename legacy TV property

2022-09-22 Thread Lyude Paul
nouveau changes: Reviewed-by: Lyude Paul On Thu, 2022-09-22 at 16:25 +0200, Maxime Ripard wrote: > The current tv_mode has driver-specific values that don't allow to > easily share code using it, either at the userspace or kernel level. > > Since we're going to introduce a new, generic, propert

[Intel-gfx] [PATCH 0/1] DG2 fix for CCS starvation

2022-09-22 Thread John . C . Harrison
From: John Harrison Enable CCS/RCS arbitration scheduling in GuC to prevent CCS starvation on DG2. Signed-off-by: John Harrison John Harrison (1): drm/i915/guc: Enable compute scheduling on DG2 .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 1 + drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_a

[Intel-gfx] [PATCH 1/1] drm/i915/guc: Enable compute scheduling on DG2

2022-09-22 Thread John . C . Harrison
From: John Harrison DG2 has issues. To work around one of these the GuC must schedule apps in an exclusive manner across both RCS and CCS. That is, if a context from app X is running on RCS then all CCS engines must sit idle even if there are contexts from apps Y, Z, ... waiting to run. A certain

Re: [Intel-gfx] [bug report] drm/i915/guc: Implement multi-lrc submission

2022-09-22 Thread John Harrison
On 9/22/2022 07:26, Dan Carpenter wrote: Hello Matthew Brost, The patch 6b540bf6f143: "drm/i915/guc: Implement multi-lrc submission" from Oct 14, 2021, leads to the following Smatch static checker warning: drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:752 __guc_add_request()

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Stop requiring PLL index == PLL ID

2022-09-22 Thread Ville Syrjälä
On Thu, Sep 22, 2022 at 06:46:30PM +0300, Jani Nikula wrote: > On Wed, 21 Sep 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > There's no good reason to keep around this PLL index == PLL ID > > footgun. Get rid of it. > > > > Both i915->shared_dplls[] and state->shared_dpll[] are indexe

[Intel-gfx] [PATCH] drm/i915: Fix CFI violations in gt_sysfs

2022-09-22 Thread Nathan Chancellor
When booting with clang's kernel control flow integrity series [1], there are numerous violations when accessing the files under /sys/devices/pci:00/:00:02.0/drm/card0/gt/gt0: $ cd /sys/devices/pci:00/:00:02.0/drm/card0/gt/gt0 $ grep . * id:0 punit_req_freq_mhz:350 rc6_e

[Intel-gfx] ✗ Fi.CI.IGT: failure for iommu: Remove iova cpu hotplugging flushing

2022-09-22 Thread Patchwork
== Series Details == Series: iommu: Remove iova cpu hotplugging flushing URL : https://patchwork.freedesktop.org/series/108880/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12166_full -> Patchwork_108880v1_full Summary ---

[Intel-gfx] [PATCH v2 3/4] drm/i915: Pimp DPLL ref/unref debugs

2022-09-22 Thread Ville Syrjala
From: Ville Syrjälä We currently have a debug message in intel_reference_shared_dpll() but no counterpart in intel_unreference_shared_dpll(). Add one. Switch to the [CRTC:...] notation for the pipe name while at it. v2: Use drm_dbg_kms() instead of drm_dbg() (Jani) Signed-off-by: Ville Syrjälä

[Intel-gfx] [PATCH v2 2/4] drm/i915: Don't bail early from intel_dp_initial_fastset_check()

2022-09-22 Thread Ville Syrjala
From: Ville Syrjälä Do all the checks in intel_dp_initial_fastset_check() instead of bailing out on the first condition that triggers. This makes for better debug logs since we see all the reasons why the full modeset computation is forced. Also avoid the risk of someone accidentally adding a c

[Intel-gfx] [PATCH v2 1/4] drm/i915: Force DPLL calculation for TC ports after readout

2022-09-22 Thread Ville Syrjala
From: Ville Syrjälä We always allocate two DPLLs (TC and TBT) for TC ports. This is because we can't know ahead of time wherher we need to put the PHY into DP-Alt or TBT mode. However during readout we can obviously only read out the state of the DPLL that the port is actually using. Thus the st

[Intel-gfx] ✓ Fi.CI.BAT: success for Add SLPC selftest live_slpc_power

2022-09-22 Thread Patchwork
== Series Details == Series: Add SLPC selftest live_slpc_power URL : https://patchwork.freedesktop.org/series/108900/ State : success == Summary == CI Bug Log - changes from CI_DRM_12167 -> Patchwork_108900v1 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH v4 00/15] Tidy up vfio_device life cycle

2022-09-22 Thread Alex Williamson
On Wed, 21 Sep 2022 18:43:46 +0800 Kevin Tian wrote: > The idea is to let vfio core manage the vfio_device life cycle instead > of duplicating the logic cross drivers. Besides cleaner code in driver > side this also allows adding struct device to vfio_device as the first > step toward adding cdev

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add SLPC selftest live_slpc_power

2022-09-22 Thread Patchwork
== Series Details == Series: Add SLPC selftest live_slpc_power URL : https://patchwork.freedesktop.org/series/108900/ State : warning == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/108900/revisions/1/mbox/ not found

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Don't use port enum as register offset

2022-09-22 Thread Balasubramani Vivekanandan
On 21.09.2022 21:12, Ville Syrjälä wrote: > On Wed, Sep 21, 2022 at 10:52:59PM +0530, Balasubramani Vivekanandan wrote: > > Display DDI ports are enumerated as PORT_A,PORT_B... . The enums are > > also used as an index to access the DDI_BUF_CTL register for the port. > > > > With the introduction

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm: Analog TV Improvements (rev2)

2022-09-22 Thread Patchwork
== Series Details == Series: drm: Analog TV Improvements (rev2) URL : https://patchwork.freedesktop.org/series/107892/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/107892/revisions/2/mbox/ not applied Applying: drm/tests: Order Kunit tests in Ma

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Improve debug print in vm_fault_ttm

2022-09-22 Thread Patchwork
== Series Details == Series: drm/i915: Improve debug print in vm_fault_ttm URL : https://patchwork.freedesktop.org/series/108887/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/ge

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix double word in comments

2022-09-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix double word in comments URL : https://patchwork.freedesktop.org/series/108886/ State : success == Summary == CI Bug Log - changes from CI_DRM_12167 -> Patchwork_108886v1 Summary --- **SUCCES

[Intel-gfx] [PATCH] drm/i915: Fix TypeC mode initialization during system resume

2022-09-22 Thread Imre Deak
During system resume DP MST requires AUX to be working already before the HW state readout of the given encoder. Since AUX requires the encoder/PHY TypeC mode to be initialized, which atm only happens during HW state readout, these AUX transfers can change the TypeC mode incorrectly (disconnecting

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix double word in comments

2022-09-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix double word in comments URL : https://patchwork.freedesktop.org/series/108886/ State : warning == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/108886/revisions/1/mbox/ not found

[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915: Fix double word in comments

2022-09-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix double word in comments URL : https://patchwork.freedesktop.org/series/108886/ State : warning == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/108886/revisions/1/mbox/ not found

[Intel-gfx] [PATCH v2] drm/i915: Move hotplug inversion logic into separate helper

2022-09-22 Thread Gustavo Sousa
Use *_hpd_invert() helpers whenever possible to isolate logic specific to hotplug inversion from common HPD setup logic to improve readability and maintainability of the source code. While we only define dg1_hpd_invert() here, future platforms are likely to have different hotplug inversion needs,

Re: [Intel-gfx] [RFC v4 03/14] drm/i915/vm_bind: Expose i915_gem_object_max_page_size()

2022-09-22 Thread Niranjana Vishwanathapura
On Thu, Sep 22, 2022 at 05:18:28PM +0100, Matthew Auld wrote: On 22/09/2022 09:09, Tvrtko Ursulin wrote: On 21/09/2022 19:00, Niranjana Vishwanathapura wrote: On Wed, Sep 21, 2022 at 10:13:12AM +0100, Tvrtko Ursulin wrote: On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: Expose i915_ge

Re: [Intel-gfx] [PATCH] drm/i915: Improve debug print in vm_fault_ttm

2022-09-22 Thread Matthew Auld
On 22/09/2022 13:09, Nirmoy Das wrote: Print the error code returned by __i915_ttm_migrate() for better debuggability. References: https://gitlab.freedesktop.org/drm/intel/-/issues/6889 Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +- 1 file changed, 1 insertion(

Re: [Intel-gfx] [PATCH] drm/i915: Improve debug print in vm_fault_ttm

2022-09-22 Thread kernel test robot
Hi Nirmoy, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Nirmoy-Das/drm-i915-Improve-debug-print-in-vm_fault_ttm/20220922-201041 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip

Re: [Intel-gfx] [RFC v4 03/14] drm/i915/vm_bind: Expose i915_gem_object_max_page_size()

2022-09-22 Thread Matthew Auld
On 22/09/2022 09:09, Tvrtko Ursulin wrote: On 21/09/2022 19:00, Niranjana Vishwanathapura wrote: On Wed, Sep 21, 2022 at 10:13:12AM +0100, Tvrtko Ursulin wrote: On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: Expose i915_gem_object_max_page_size() function non-static which will be used

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Decouple I915_NUM_PLLS from PLL IDs

2022-09-22 Thread Ville Syrjälä
On Thu, Sep 22, 2022 at 06:55:37PM +0300, Jani Nikula wrote: > On Wed, 21 Sep 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Stop assuming the size of PLL ID based bitmask is restricted > > to I915_NUM_PLLS bits. This is the last thing coupling the > > two things together and thus art

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: enable local stolen memory

2022-09-22 Thread Iddamsetty, Aravind
On 22-09-2022 19:26, Lucas De Marchi wrote: > On Wed, Sep 21, 2022 at 12:00:38PM +0530, Iddamsetty, Aravind wrote: >> replying here for earlier comments too. >> >> On 21-09-2022 01:35, Lucas De Marchi wrote: >>> On Tue, Sep 20, 2022 at 01:31:49AM -0700, Lucas De Marchi wrote: On Tue, Sep 20

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Decouple I915_NUM_PLLS from PLL IDs

2022-09-22 Thread Jani Nikula
On Wed, 21 Sep 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Stop assuming the size of PLL ID based bitmask is restricted > to I915_NUM_PLLS bits. This is the last thing coupling the > two things together and thus artificially limiting PLL IDs. > > We could just pass any arbitrary (large e

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Stop requiring PLL index == PLL ID

2022-09-22 Thread Jani Nikula
On Wed, 21 Sep 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > There's no good reason to keep around this PLL index == PLL ID > footgun. Get rid of it. > > Both i915->shared_dplls[] and state->shared_dpll[] are indexed > by the same thing now, which is just the index we get at > initializati

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Pimp DPLL ref/unref debugs

2022-09-22 Thread Ville Syrjälä
On Thu, Sep 22, 2022 at 02:57:45PM +0300, Jani Nikula wrote: > On Thu, 22 Sep 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We currently have a debug message in intel_reference_shared_dpll() > > but no counterpart in intel_unreference_shared_dpll(). Add one. > > > > Switch to the [CR

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Nuke intel_get_shared_dpll_id()

2022-09-22 Thread Jani Nikula
On Wed, 21 Sep 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Each PLL knows its own ID so intel_get_shared_dpll_id() is > pointless. Get rid of it. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 4 ++-- > drivers/gpu/

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Always initialize dpll.lock

2022-09-22 Thread Jani Nikula
On Wed, 21 Sep 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Initialize the dll.lock mutex whether or not we manage to > initialize the rest of the dpll mgr. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 3 ++- > 1 f

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Force DPLL calculation for TC ports after readout

2022-09-22 Thread Ville Syrjälä
On Thu, Sep 22, 2022 at 02:56:53PM +0300, Jani Nikula wrote: > On Thu, 22 Sep 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We always allocate two DPLLs (TC and TBT) for TC ports. This > > is because we can't know ahead of time wherher we need to put > > the PHY into DP-Alt or TBT mo

[Intel-gfx] ✓ Fi.CI.BAT: success for iommu: Remove iova cpu hotplugging flushing

2022-09-22 Thread Patchwork
== Series Details == Series: iommu: Remove iova cpu hotplugging flushing URL : https://patchwork.freedesktop.org/series/108880/ State : success == Summary == CI Bug Log - changes from CI_DRM_12166 -> Patchwork_108880v1 Summary --- **

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Improvements to stolen memory setup (rev3)

2022-09-22 Thread Vudum, Lakshminarayana
Filed a new issue and reported the results. https://gitlab.freedesktop.org/drm/intel/-/issues/6898 Lakshmi. -Original Message- From: De Marchi, Lucas Sent: Thursday, September 22, 2022 6:55 AM To: intel-gfx@lists.freedesktop.org Cc: Vudum, Lakshminarayana Subject: Re: ✗ Fi.CI.IGT: fail

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Improvements to stolen memory setup (rev3)

2022-09-22 Thread Patchwork
== Series Details == Series: drm/i915: Improvements to stolen memory setup (rev3) URL : https://patchwork.freedesktop.org/series/108620/ State : success == Summary == CI Bug Log - changes from CI_DRM_12146_full -> Patchwork_108620v3_full Su

[Intel-gfx] [PATCH 0/1] Add SLPC selftest live_slpc_power

2022-09-22 Thread Riana Tauro
live_slpc_power tests if running at low frequency saves power Riana Tauro (1): drm/i915/guc/slpc: Add SLPC selftest live_slpc_power drivers/gpu/drm/i915/gt/selftest_slpc.c | 116 ++-- 1 file changed, 107 insertions(+), 9 deletions(-) -- 2.25.1

[Intel-gfx] [PATCH 1/1] drm/i915/guc/slpc: Add SLPC selftest live_slpc_power

2022-09-22 Thread Riana Tauro
A fundamental assumption is that at lower frequencies, not only do we run slower, but we save power compared to higher frequencies. live_slpc_power checks if running at low frequency saves power Signed-off-by: Riana Tauro --- drivers/gpu/drm/i915/gt/selftest_slpc.c | 116 ++--

Re: [Intel-gfx] [PATCH v2 00/33] drm: Analog TV Improvements

2022-09-22 Thread Maxime Ripard
Hi, On Thu, Sep 22, 2022 at 04:25:17PM +0200, Maxime Ripard wrote: > Here's a series aiming at improving the command line named modes support, > and more importantly how we deal with all the analog TV variants. > > The named modes support were initially introduced to allow to specify the > analog

[Intel-gfx] [PATCH v2 32/33] drm/vc4: vec: Add support for more analog TV standards

2022-09-22 Thread Maxime Ripard
From: Mateusz Kwiatkowski Add support for the following composite output modes (all of them are somewhat more obscure than the previously defined ones): - NTSC_443 - NTSC-style signal with the chroma subcarrier shifted to 4.43361875 MHz (the PAL subcarrier frequency). Never used for broadcas

[Intel-gfx] [PATCH v2 33/33] drm/sun4i: tv: Convert to the new TV mode property

2022-09-22 Thread Maxime Ripard
Now that the core can deal fine with analog TV modes, let's convert the sun4i TV driver to leverage those new features. Signed-off-by: Maxime Ripard diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c index 74ff5ad6a8b9..833742cee745 100644 --- a/drivers/gpu/drm/sun4

[Intel-gfx] [PATCH v2 31/33] drm/vc4: vec: Convert to the new TV mode property

2022-09-22 Thread Maxime Ripard
Now that the core can deal fine with analog TV modes, let's convert the vc4 VEC driver to leverage those new features. We've added some backward compatibility to support the old TV mode property and translate it into the new TV norm property. Signed-off-by: Maxime Ripard diff --git a/drivers/gp

[Intel-gfx] [PATCH v2 28/33] drm/vc4: vec: Fix definition of PAL-M mode

2022-09-22 Thread Maxime Ripard
From: Mateusz Kwiatkowski PAL-M is a Brazilian analog TV standard that uses a PAL-style chroma subcarrier at 3.575611[888111] MHz on top of 525-line (480i60) timings. This commit makes the driver actually use the proper VEC preset for this mode instead of just changing PAL subcarrier frequency.

[Intel-gfx] [PATCH v2 29/33] drm/vc4: vec: Use TV Reset implementation

2022-09-22 Thread Maxime Ripard
The analog TV properties created by the drm_mode_create_tv_properties() are not properly initialised at reset. Let's switch our implementation to call drm_atomic_helper_connector_tv_reset(). Reviewed-by: Noralf Trønnes Signed-off-by: Maxime Ripard diff --git a/drivers/gpu/drm/vc4/vc4_vec.c b/dr

[Intel-gfx] [PATCH v2 30/33] drm/vc4: vec: Check for VEC output constraints

2022-09-22 Thread Maxime Ripard
From: Mateusz Kwiatkowski The VEC can accept pretty much any relatively reasonable mode, but still has a bunch of constraints to meet. Let's create an atomic_check() implementation that will make sure we don't end up accepting a non-functional mode. Signed-off-by: Mateusz Kwiatkowski Signed-of

[Intel-gfx] [PATCH v2 27/33] drm/atomic-helper: Add an analog TV atomic_check implementation

2022-09-22 Thread Maxime Ripard
The analog TV connector drivers share some atomic_check logic, and the new TV standard property have created a bunch of new constraints that needs to be shared across drivers too. Let's create an atomic_check helper for those use cases. Reviewed-by: Noralf Trønnes Signed-off-by: Maxime Ripard

[Intel-gfx] [PATCH v2 26/33] drm/atomic-helper: Add a TV properties reset helper

2022-09-22 Thread Maxime Ripard
The drm_tv_create_properties() function will create a bunch of properties, but it's up to each and every driver using that function to properly reset the state of these properties leading to inconsistent behaviours. Let's create a helper that will take care of it. Reviewed-by: Noralf Trønnes Sig

[Intel-gfx] [PATCH v2 25/33] drm/modes: Introduce more named modes

2022-09-22 Thread Maxime Ripard
Now that we can easily extend the named modes list, let's add a few more analog TV modes that were used in the wild, and some unit tests to make sure it works as intended. Signed-off-by: Maxime Ripard diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index 1ca1f82dfd12..6f31

[Intel-gfx] [PATCH v2 23/33] drm/modes: Introduce the tv_mode property as a command-line option

2022-09-22 Thread Maxime Ripard
Our new tv mode option allows to specify the TV mode from a property. However, it can still be useful, for example to avoid any boot time artifact, to set that property directly from the kernel command line. Let's add some code to allow it, and some unit tests to exercise that code. Signed-off-by

[Intel-gfx] [PATCH v2 22/33] drm/connector: Add a function to lookup a TV mode by its name

2022-09-22 Thread Maxime Ripard
As part of the command line parsing rework coming in the next patches, we'll need to lookup drm_connector_tv_mode values by their name, already defined in drm_tv_mode_enum_list. In order to avoid any code duplication, let's do a function that will perform a lookup of a TV mode name and return its

[Intel-gfx] [PATCH v2 24/33] drm/modes: Properly generate a drm_display_mode from a named mode

2022-09-22 Thread Maxime Ripard
The framework will get the drm_display_mode from the drm_cmdline_mode it got by parsing the video command line argument by calling drm_connector_pick_cmdline_mode(). The heavy lifting will then be done by the drm_mode_create_from_cmdline_mode() function. In the case of the named modes though, the

[Intel-gfx] [PATCH v2 21/33] drm/connector: Add pixel clock to cmdline mode

2022-09-22 Thread Maxime Ripard
We'll need to get the pixel clock to generate proper display modes for all the current named modes. Let's add it to struct drm_cmdline_mode and fill it when parsing the named mode. Signed-off-by: Maxime Ripard diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index 5d8b6a0d9

  1   2   >