Re: [Intel-gfx] [PATCH v2 7/9] drm/i915/dp: Replace intel_dp.dfp members with the new crtc_state dp_dfp members

2022-09-12 Thread Nautiyal, Ankit K
On 9/13/2022 12:26 AM, Ville Syrjälä wrote: On Thu, Sep 01, 2022 at 11:30:59AM +0530, Ankit Nautiyal wrote: The decision to use DFP output format conversion capabilities should be during compute_config phase. This patch uses the members of intel_dp->dfp to only store the format conversion cap

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp: use drm_dp_phy_name() for logging

2022-09-12 Thread Patchwork
== Series Details == Series: drm/i915/dp: use drm_dp_phy_name() for logging URL : https://patchwork.freedesktop.org/series/108436/ State : success == Summary == CI Bug Log - changes from CI_DRM_12123_full -> Patchwork_108436v1_full Summary

Re: [Intel-gfx] [PATCH v2 4/9] drm/i915/display: Add new members to configure PCON color conversion

2022-09-12 Thread Nautiyal, Ankit K
On 9/13/2022 12:25 AM, Ville Syrjälä wrote: On Thu, Sep 01, 2022 at 11:30:56AM +0530, Ankit Nautiyal wrote: The decision to use DFP output format conversion capabilities should be during compute_config phase. This patch adds new members to crtc_state to help configure the DFP output related c

[Intel-gfx] ✓ Fi.CI.BAT: success for linux-next: manual merge of the drm-intel tree with the drm tree (rev2)

2022-09-12 Thread Patchwork
== Series Details == Series: linux-next: manual merge of the drm-intel tree with the drm tree (rev2) URL : https://patchwork.freedesktop.org/series/88033/ State : success == Summary == CI Bug Log - changes from CI_DRM_12124 -> Patchwork_88033v2 =

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for linux-next: manual merge of the drm-intel tree with the drm tree (rev2)

2022-09-12 Thread Patchwork
== Series Details == Series: linux-next: manual merge of the drm-intel tree with the drm tree (rev2) URL : https://patchwork.freedesktop.org/series/88033/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2

Re: [Intel-gfx] [PATCH 01/19] drm/i915/perf: Fix OA filtering logic for GuC mode

2022-09-12 Thread Dixit, Ashutosh
On Fri, 09 Sep 2022 16:47:36 -0700, Dixit, Ashutosh wrote: > > On Tue, 23 Aug 2022 13:41:37 -0700, Umesh Nerlige Ramappa wrote: > > > > Hi Umesh, > > > With GuC mode of submission, GuC is in control of defining the context id > > field > > that is part of the OA reports. To filter reports, UMD and

[Intel-gfx] ✓ Fi.CI.BAT: success for Fix 'remove log size module parameters'

2022-09-12 Thread Patchwork
== Series Details == Series: Fix 'remove log size module parameters' URL : https://patchwork.freedesktop.org/series/108466/ State : success == Summary == CI Bug Log - changes from CI_DRM_12124 -> Patchwork_108466v1 Summary --- **SUCC

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: HuC loading for DG2 (rev5)

2022-09-12 Thread Patchwork
== Series Details == Series: drm/i915: HuC loading for DG2 (rev5) URL : https://patchwork.freedesktop.org/series/107477/ State : success == Summary == CI Bug Log - changes from CI_DRM_12124 -> Patchwork_107477v5 Summary --- **SUCCESS

[Intel-gfx] linux-next: manual merge of the drm-intel tree with the drm tree

2022-09-12 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/i915_drv.h between commit: 3bb6a44251b4 ("drm/i915: Rename ggtt_view as gtt_view") from the drm tree and commit: 5fd5cc73e449 ("drm/i915: split out i915_gem.c declarations to i915_gem.h") fro

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: HuC loading for DG2 (rev5)

2022-09-12 Thread Patchwork
== Series Details == Series: drm/i915: HuC loading for DG2 (rev5) URL : https://patchwork.freedesktop.org/series/107477/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: HuC loading for DG2 (rev5)

2022-09-12 Thread Patchwork
== Series Details == Series: drm/i915: HuC loading for DG2 (rev5) URL : https://patchwork.freedesktop.org/series/107477/ State : warning == Summary == Error: dim checkpatch failed 302eb2e32f35 mei: add support to GSC extended header 2a95a5b83cba mei: bus: enable sending gsc commands c7f29caead

[Intel-gfx] ✓ Fi.CI.BAT: success for Fix bug in version reduced firmware update

2022-09-12 Thread Patchwork
== Series Details == Series: Fix bug in version reduced firmware update URL : https://patchwork.freedesktop.org/series/108461/ State : success == Summary == CI Bug Log - changes from CI_DRM_12124 -> Patchwork_108461v1 Summary --- **S

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix display problems after resume

2022-09-12 Thread Patchwork
== Series Details == Series: drm/i915: Fix display problems after resume URL : https://patchwork.freedesktop.org/series/108432/ State : success == Summary == CI Bug Log - changes from CI_DRM_12123_full -> Patchwork_108432v1_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: header cleanups (rev2)

2022-09-12 Thread Patchwork
== Series Details == Series: drm/i915: header cleanups (rev2) URL : https://patchwork.freedesktop.org/series/93777/ State : success == Summary == CI Bug Log - changes from CI_DRM_12124 -> Patchwork_93777v2 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: header cleanups (rev2)

2022-09-12 Thread Patchwork
== Series Details == Series: drm/i915: header cleanups (rev2) URL : https://patchwork.freedesktop.org/series/93777/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: header cleanups (rev2)

2022-09-12 Thread Patchwork
== Series Details == Series: drm/i915: header cleanups (rev2) URL : https://patchwork.freedesktop.org/series/93777/ State : warning == Summary == Error: dim checkpatch failed 5507d6540b9e drm/i915/gmbus: move GPIO enum to gmbus 855c0fd1a265 drm/i915: reduce includes in intel_connector.h 9be9ae

[Intel-gfx] [PATCH 0/1] Fix 'remove log size module parameters'

2022-09-12 Thread John . C . Harrison
From: John Harrison The patch 'remove log size module parameters' broke loading the kernel when not compiling for debug. Fix it. Signed-off-by: John Harrison John Harrison (1): drm/i915/guc: Fix release build bug in 'remove log size module parameters' drivers/gpu/drm/i915/gt/uc/intel_

[Intel-gfx] [PATCH 1/1] drm/i915/guc: Fix release build bug in 'remove log size module parameters'

2022-09-12 Thread John . C . Harrison
From: John Harrison A patch was merged to remove the GuC log size override module parameters. That patch was broken and caused kernel error messages on boot in non CONFIG_DEBUG_GUC|GEM builds: [ 12.085121] i915 :00:02.0: [drm] *ERROR* Zero GuC log crash dump size! [ 12.092035] i915 :0

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Copy engine fuses future-proofing

2022-09-12 Thread Patchwork
== Series Details == Series: drm/i915: Copy engine fuses future-proofing URL : https://patchwork.freedesktop.org/series/108444/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12124 -> Patchwork_108444v1 Summary --- **

[Intel-gfx] ✓ Fi.CI.IGT: success for DGFX mmap with rpm (rev4)

2022-09-12 Thread Patchwork
== Series Details == Series: DGFX mmap with rpm (rev4) URL : https://patchwork.freedesktop.org/series/107400/ State : success == Summary == CI Bug Log - changes from CI_DRM_12123_full -> Patchwork_107400v4_full Summary --- **SUCCESS*

[Intel-gfx] [PATCH v5 15/15] HAX: drm/i915: force INTEL_MEI_GSC and INTEL_MEI_PXP on for CI

2022-09-12 Thread Daniele Ceraolo Spurio
Both are required for HuC loading. Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/Kconfig.debug | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug index e7fd3e76f8a2..a6576ffbc4dc 100644 --- a/drivers/gpu

[Intel-gfx] [PATCH v5 13/15] drm/i915/huc: better define HuC status getparam possible return values.

2022-09-12 Thread Daniele Ceraolo Spurio
The current HuC status getparam return values are a bit confusing in regards to what happens in some scenarios. In particular, most of the error cases cause the ioctl to return an error, but a couple of them, INIT_FAIL and LOAD_FAIL, are not explicitly handled and neither is their expected return v

[Intel-gfx] [PATCH v5 03/15] mei: adjust extended header kdocs

2022-09-12 Thread Daniele Ceraolo Spurio
From: Tomas Winkler Fix kdoc for struct mei_ext_hdr and mei_ext_begin(). Signed-off-by: Tomas Winkler Signed-off-by: Daniele Ceraolo Spurio Cc: Greg Kroah-Hartman --- V4: New in the series V5: Rebase drivers/misc/mei/hw.h | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff -

[Intel-gfx] [PATCH v5 14/15] drm/i915/huc: define gsc-compatible HuC fw for DG2

2022-09-12 Thread Daniele Ceraolo Spurio
The fw name is different and we need to record the fact that the blob is gsc-loaded, so add a new macro to help. Note: A-step DG2 G10 does not support HuC loading via GSC and would require a separate firmware to be loaded the legacy way, but that's not a production stepping so we're not going to b

[Intel-gfx] [PATCH v5 01/15] mei: add support to GSC extended header

2022-09-12 Thread Daniele Ceraolo Spurio
From: Tomas Winkler GSC extend header is of variable size and data is provided in a sgl list inside the header and not in the data buffers, need to enable the path. Signed-off-by: Tomas Winkler Signed-off-by: Daniele Ceraolo Spurio Cc: Vitaly Lubart Cc: Greg Kroah-Hartman --- V2-3: Rebase V4

[Intel-gfx] [PATCH v5 08/15] drm/i915/pxp: implement function for sending tee stream command

2022-09-12 Thread Daniele Ceraolo Spurio
From: Vitaly Lubart Command to be sent via the stream interface are written to a local memory page, whose address is then provided to the GSC. The interface supports providing a full sg with multiple pages for both input and output messages, but since for now we only aim to support short and sync

[Intel-gfx] [PATCH v5 11/15] drm/i915/huc: track delayed HuC load with a fence

2022-09-12 Thread Daniele Ceraolo Spurio
Given that HuC load is delayed on DG2, this patch adds support for a fence that can be used to wait for load completion. No waiters are added in this patch (they're coming up in the next one), to keep the focus of the patch on the tracking logic. The full HuC loading flow on boot DG2 is as follows

[Intel-gfx] [PATCH v5 12/15] drm/i915/huc: stall media submission until HuC is loaded

2022-09-12 Thread Daniele Ceraolo Spurio
Wait on the fence to be signalled to avoid the submissions finding HuC not yet loaded. Signed-off-by: Daniele Ceraolo Spurio Cc: Tony Ye Reviewed-by: Alan Previn Acked-by: Tony Ye --- drivers/gpu/drm/i915/gt/uc/intel_huc.h | 6 ++ drivers/gpu/drm/i915/i915_request.c| 24 +

[Intel-gfx] [PATCH v5 10/15] drm/i915/dg2: setup HuC loading via GSC

2022-09-12 Thread Daniele Ceraolo Spurio
The GSC will perform both the load and the authentication, so we just need to check the auth bit after the GSC has replied. Since we require the PXP module to load the HuC, the earliest we can trigger the load is during the pxp_bind operation. Note that GSC-loaded HuC survives GT reset, so we need

[Intel-gfx] [PATCH v5 04/15] mei: bus: extend bus API to support command streamer API

2022-09-12 Thread Daniele Ceraolo Spurio
From: Vitaly Lubart Add mei bus API for sending gsc commands: mei_cldev_send_gsc_command() The GSC commands are originated in the graphics stack and are in form of SGL DMA buffers. The GSC commands are synchronous, the response is received in the same call on the out sg list buffers. The functio

[Intel-gfx] [PATCH v5 07/15] drm/i915/pxp: load the pxp module when we have a gsc-loaded huc

2022-09-12 Thread Daniele Ceraolo Spurio
The mei_pxp module is required to send the command to load authenticate the HuC to the GSC even if pxp is not in use for protected content management. Signed-off-by: Daniele Ceraolo Spurio Cc: Alan Previn Reviewed-by: Alan Previn --- drivers/gpu/drm/i915/Makefile| 10 +++--- dr

[Intel-gfx] [PATCH v5 06/15] mei: pxp: support matching with a gfx discrete card

2022-09-12 Thread Daniele Ceraolo Spurio
From: Tomas Winkler With on-boards graphics card, both i915 and MEI are in the same device hierarchy with the same parent, while for discrete gfx card the MEI is its child device. Adjust the match function for that scenario by matching MEI parent device with i915. Signed-off-by: Tomas Winkler S

[Intel-gfx] [PATCH v5 05/15] mei: pxp: add command streamer API to the PXP driver

2022-09-12 Thread Daniele Ceraolo Spurio
From: Vitaly Lubart The discrete graphics card with GSC firmware using command streamer API hence it requires to enhance pxp module with the new gsc_command() handler. The handler is implemented via mei_pxp_gsc_command() which is just a thin wrapper around mei_cldev_send_gsc_command() Signed-of

[Intel-gfx] [PATCH v5 02/15] mei: bus: enable sending gsc commands

2022-09-12 Thread Daniele Ceraolo Spurio
From: Tomas Winkler GSC command is and extended header containing a scatter gather list and without a data buffer. Using MEI_CL_IO_SGL flag, the caller send the GSC command as a data and the function internally moves it to the extended header. Signed-off-by: Tomas Winkler Signed-off-by: Daniele

[Intel-gfx] [PATCH v5 09/15] drm/i915/pxp: add huc authentication and loading command

2022-09-12 Thread Daniele Ceraolo Spurio
From: Tomas Winkler Add support for loading HuC via a pxp stream command. V4: 1. Remove unnecessary include in intel_pxp_huc.h (Jani) 2. Adjust copyright year to 2022 Signed-off-by: Tomas Winkler Signed-off-by: Vitaly Lubart Signed-off-by: Daniele Ceraolo Spurio Cc: Alan Previn Reviewed-by:

[Intel-gfx] [PATCH v5 00/15] drm/i915: HuC loading for DG2

2022-09-12 Thread Daniele Ceraolo Spurio
On DG2, HuC loading is performed by the GSC, via a PXP command. The load operation itself is relatively simple (just send a message to the GSC with the physical address of the HuC in LMEM), but there are timing changes that requires special attention. In particular, to send a PXP command we need to

Re: [Intel-gfx] [CI 1/2] drm/i915/uc: Support for version reduced and multiple firmware files

2022-09-12 Thread Ceraolo Spurio, Daniele
On 9/12/2022 5:23 PM, Lucas De Marchi wrote: On Tue, Sep 06, 2022 at 04:01:46PM -0700, Daniele Ceraolo Spurio wrote: @@ -184,49 +247,94 @@ __uc_fw_auto_select(struct drm_i915_private *i915, struct intel_uc_fw *uc_fw) fw_count = blobs_all[uc_fw->type].count; for (i = 0; i < fw_count

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: fix repeated words in comments (rev4)

2022-09-12 Thread Patchwork
== Series Details == Series: drm/i915: fix repeated words in comments (rev4) URL : https://patchwork.freedesktop.org/series/107885/ State : success == Summary == CI Bug Log - changes from CI_DRM_12124 -> Patchwork_107885v4 Summary ---

Re: [Intel-gfx] [CI 1/2] drm/i915/uc: Support for version reduced and multiple firmware files

2022-09-12 Thread Lucas De Marchi
On Tue, Sep 06, 2022 at 04:01:46PM -0700, Daniele Ceraolo Spurio wrote: @@ -184,49 +247,94 @@ __uc_fw_auto_select(struct drm_i915_private *i915, struct intel_uc_fw *uc_fw) fw_count = blobs_all[uc_fw->type].count; for (i = 0; i < fw_count && p <= fw_blobs[i].p; i++) { -

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Use GEN12 RPSTAT register

2022-09-12 Thread Dixit, Ashutosh
On Mon, 12 Sep 2022 04:29:38 -0700, Nilawar, Badal wrote: > > >> diff --git a/drivers/gpu/drm/i915/i915_pmu.c > >> b/drivers/gpu/drm/i915/i915_pmu.c > >> index 958b37123bf1..a24704ec2c18 100644 > >> --- a/drivers/gpu/drm/i915/i915_pmu.c > >> +++ b/drivers/gpu/drm/i915/i915_pmu.c > >> @@ -371,7 +37

[Intel-gfx] [PATCH 1/1] drm/i915/uc: Fix issues with overriding firmware files

2022-09-12 Thread John . C . Harrison
From: John Harrison The earlier update to support reduced versioning of firmware files introduced an issue with the firmware override module parameter. If an invalid file was specified then an infinite loop could occur trying to find a backup firmware. The fix is that if an explicit override has

[Intel-gfx] [PATCH 0/1] Fix bug in version reduced firmware update

2022-09-12 Thread John . C . Harrison
From: John Harrison The earlier patch to support firmware files with reduced versioning introduced an issue with the firmware override module parameter. So fix that. Signed-off-by: John Harrison John Harrison (1): drm/i915/uc: Fix issues with overriding firmware files drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 6/7] drm/i915/guc: Make GuC log sizes runtime configurable

2022-09-12 Thread John Harrison
On 9/12/2022 00:12, Joonas Lahtinen wrote: Quoting Joonas Lahtinen (2022-08-26 09:23:08) Quoting John Harrison (2022-08-25 19:31:39) On 8/25/2022 00:15, Joonas Lahtinen wrote: Quoting John Harrison (2022-08-24 21:45:09) We also don't want to tie the GuC logging buffer size to the DRM debuggin

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Some house cleaning

2022-09-12 Thread Patchwork
== Series Details == Series: drm/i915: Some house cleaning URL : https://patchwork.freedesktop.org/series/108426/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12123_full -> Patchwork_108426v1_full Summary --- **FAIL

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: use drm_dp_phy_name() for logging

2022-09-12 Thread Patchwork
== Series Details == Series: drm/i915/dp: use drm_dp_phy_name() for logging URL : https://patchwork.freedesktop.org/series/108436/ State : success == Summary == CI Bug Log - changes from CI_DRM_12123 -> Patchwork_108436v1 Summary ---

Re: [Intel-gfx] [PATCH v6 17/57] dyndbg: validate class FOO by checking with module

2022-09-12 Thread jim . cromie
On Mon, Sep 12, 2022 at 2:17 PM Jason Baron wrote: > > > > On 9/9/22 16:44, jim.cro...@gmail.com wrote: > > On Wed, Sep 7, 2022 at 12:19 PM Jason Baron wrote: > >> > >> > >> > >> On 9/4/22 17:40, Jim Cromie wrote: > >>> Add module-to-class validation: > >>> > >>> #> echo class DRM_UT_KMS +p > /

Re: [Intel-gfx] [PATCH v1 1/1] drm/i915: Skip applying copy engine fuses

2022-09-12 Thread Lucas De Marchi
On Mon, Sep 12, 2022 at 10:12:57PM +0200, Andi Shyti wrote: Hi Lucas, On Mon, Sep 12, 2022 at 11:12:47AM -0700, Lucas De Marchi wrote: On Mon, Sep 12, 2022 at 06:59:53PM +0200, Andi Shyti wrote: > Hi Lucas, > > On Mon, Sep 12, 2022 at 09:19:38AM -0700, Lucas De Marchi wrote: > > Support for rea

Re: [Intel-gfx] [PATCH v7 2/9] drm: POC drm on dyndbg - use in core, 2 helpers, 3 drivers.

2022-09-12 Thread jim . cromie
On Mon, Sep 12, 2022 at 4:29 AM Jani Nikula wrote: > > On Sun, 11 Sep 2022, Jim Cromie wrote: > > Use DECLARE_DYNDBG_CLASSMAP across DRM: > > > > - in .c files, since macro defines/initializes a record > > > > - in drivers, $mod_{drv,drm,param}.c > >ie where param setup is done, since a cla

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix display problems after resume

2022-09-12 Thread Patchwork
== Series Details == Series: drm/i915: Fix display problems after resume URL : https://patchwork.freedesktop.org/series/108432/ State : success == Summary == CI Bug Log - changes from CI_DRM_12123 -> Patchwork_108432v1 Summary --- **

Re: [Intel-gfx] [PATCH v1 1/1] drm/i915: Skip applying copy engine fuses

2022-09-12 Thread Andi Shyti
Hi Lucas, On Mon, Sep 12, 2022 at 11:12:47AM -0700, Lucas De Marchi wrote: > On Mon, Sep 12, 2022 at 06:59:53PM +0200, Andi Shyti wrote: > > Hi Lucas, > > > > On Mon, Sep 12, 2022 at 09:19:38AM -0700, Lucas De Marchi wrote: > > > Support for reading the fuses to check what are the Link Copy engin

[Intel-gfx] ✓ Fi.CI.BAT: success for DGFX mmap with rpm (rev4)

2022-09-12 Thread Patchwork
== Series Details == Series: DGFX mmap with rpm (rev4) URL : https://patchwork.freedesktop.org/series/107400/ State : success == Summary == CI Bug Log - changes from CI_DRM_12123 -> Patchwork_107400v4 Summary --- **SUCCESS** No re

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for DGFX mmap with rpm (rev4)

2022-09-12 Thread Patchwork
== Series Details == Series: DGFX mmap with rpm (rev4) URL : https://patchwork.freedesktop.org/series/107400/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [RESEND] drm/i915/dp: use drm_dp_phy_name() for logging

2022-09-12 Thread Andrzej Hajda
On 12.09.2022 15:23, Jani Nikula wrote: Drop the local intel_dp_phy_name() function, and replace with drm_dp_phy_name(). This lets us drop a number of local buffers. v2: Rebase Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä # v1 Signed-off-by: Jani Nikula Reviewed-by: Andrzej Hajda Regards

Re: [Intel-gfx] [PATCH v2 7/9] drm/i915/dp: Replace intel_dp.dfp members with the new crtc_state dp_dfp members

2022-09-12 Thread Ville Syrjälä
On Thu, Sep 01, 2022 at 11:30:59AM +0530, Ankit Nautiyal wrote: > The decision to use DFP output format conversion capabilities should be > during compute_config phase. > > This patch uses the members of intel_dp->dfp to only store the > format conversion capabilities of the DP device and uses the

Re: [Intel-gfx] [PATCH v2 4/9] drm/i915/display: Add new members to configure PCON color conversion

2022-09-12 Thread Ville Syrjälä
On Thu, Sep 01, 2022 at 11:30:56AM +0530, Ankit Nautiyal wrote: > The decision to use DFP output format conversion capabilities should be > during compute_config phase. > > This patch adds new members to crtc_state to help configure the DFP > output related conversions. Also adds a member to intel

Re: [Intel-gfx] [PATCH v1 1/1] drm/i915: Skip applying copy engine fuses

2022-09-12 Thread Andrzej Hajda
On 12.09.2022 18:19, Lucas De Marchi wrote: Support for reading the fuses to check what are the Link Copy engines was added in commit ad5f74f34201 ("drm/i915/pvc: read fuses for link copy engines"). However they were added unconditionally because the FUSE3 register is present since graphics versi

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/ipc: ipc and sub-struct refactoring, take 2

2022-09-12 Thread Patchwork
== Series Details == Series: drm/i915/ipc: ipc and sub-struct refactoring, take 2 URL : https://patchwork.freedesktop.org/series/108428/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12123 -> Patchwork_108428v1 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/ipc: ipc and sub-struct refactoring, take 2

2022-09-12 Thread Patchwork
== Series Details == Series: drm/i915/ipc: ipc and sub-struct refactoring, take 2 URL : https://patchwork.freedesktop.org/series/108428/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Some house cleaning

2022-09-12 Thread Patchwork
== Series Details == Series: drm/i915: Some house cleaning URL : https://patchwork.freedesktop.org/series/108426/ State : success == Summary == CI Bug Log - changes from CI_DRM_12123 -> Patchwork_108426v1 Summary --- **SUCCESS** N

Re: [Intel-gfx] [PATCH v1 1/1] drm/i915: Skip applying copy engine fuses

2022-09-12 Thread Lucas De Marchi
On Mon, Sep 12, 2022 at 06:59:53PM +0200, Andi Shyti wrote: Hi Lucas, On Mon, Sep 12, 2022 at 09:19:38AM -0700, Lucas De Marchi wrote: Support for reading the fuses to check what are the Link Copy engines was added in commit ad5f74f34201 ("drm/i915/pvc: read fuses for link copy engines"). Howev

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Some house cleaning

2022-09-12 Thread Patchwork
== Series Details == Series: drm/i915: Some house cleaning URL : https://patchwork.freedesktop.org/series/108426/ State : warning == Summary == Error: dim checkpatch failed bb92496cbf75 drm/i915: Drop pointless middle man variable 24106901ef3f drm/i915: Clean up transcoder_to_stream_enc_status

Re: [Intel-gfx] [PATCH 13/15] drm/i915: Don't init eDP if we can't find a fixed mode

2022-09-12 Thread Ville Syrjälä
On Mon, Sep 12, 2022 at 03:02:36PM +0300, Jani Nikula wrote: > On Mon, 12 Sep 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > In the unlikely case of not finding a fixed mode don't register > > the eDP connector. I think there are some places where we'd oops > > if we didn't have a fix

Re: [Intel-gfx] [PATCH v3 19/37] drm/i915: stop using kernel-doc markups for something else

2022-09-12 Thread Matt Roper
On Mon, Sep 12, 2022 at 06:47:56PM +0200, Mauro Carvalho Chehab wrote: > Hi Matt, > > Em Mon, 12 Sep 2022 08:09:57 -0700 > Matt Roper escreveu: > > > > --- a/drivers/gpu/drm/i915/gt/intel_context_types.h > > > +++ b/drivers/gpu/drm/i915/gt/intel_context_types.h > > > > Several of the comments

Re: [Intel-gfx] [PATCH 0/6] i915: CAGF and RC6 changes for MTL

2022-09-12 Thread Andi Shyti
Hi Badal, On Mon, Sep 12, 2022 at 05:42:57PM +0530, Nilawar, Badal wrote: > I added Cc: in individual patches. So I thought it will pick automatically. > But anyway I have to fix some of the comments. So I will fix those and > resend the series. I will Cc relevant people. yes... it depends on you

Re: [Intel-gfx] [PATCH 0/6] i915: CAGF and RC6 changes for MTL

2022-09-12 Thread Andi Shyti
Hi Jani, On Mon, Sep 12, 2022 at 03:07:01PM +0300, Jani Nikula wrote: > On Mon, 12 Sep 2022, Andi Shyti wrote: > > Hi Badal, > > > > you haven't Cc'ed anyone here... Please do CC the people > > interested in the patches and dri-devel mailing list. > > > > If you don't mind, could you please resen

Re: [Intel-gfx] [PATCH v1 1/1] drm/i915: Skip applying copy engine fuses

2022-09-12 Thread Andi Shyti
Hi Lucas, On Mon, Sep 12, 2022 at 09:19:38AM -0700, Lucas De Marchi wrote: > Support for reading the fuses to check what are the Link Copy engines > was added in commit ad5f74f34201 ("drm/i915/pvc: read fuses for link > copy engines"). However they were added unconditionally because the > FUSE3 re

[Intel-gfx] [PATCH 12/15] drm/i915/reg: move masked field helpers to i915_reg_defs.h

2022-09-12 Thread Jani Nikula
This is a more logical place for generic helpers. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 13 - drivers/gpu/drm/i915/i915_reg_defs.h | 13 + 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/dr

[Intel-gfx] [PATCH 09/15] drm/i915/display: reduce includes in intel_hdmi.h

2022-09-12 Thread Jani Nikula
Only include what's needed. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_hdmi.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.h b/drivers/gpu/drm/i915/display/intel_hdmi.h index 93f65a917c36..774dda2376ed

[Intel-gfx] [PATCH 15/15] drm/i915: stop including i915_irq.h from i915_trace.h

2022-09-12 Thread Jani Nikula
Turns out most of the files that need i915_reg.h get it implicitly via {display/intel_de.h, gt/intel_context.h} -> i915_trace.h -> i915_irq.h -> i915_reg.h. Since i915_trace.h doesn't actually need i915_irq.h, makes sense to drop it, but that requires adding quite a few new includes all over the pl

[Intel-gfx] [PATCH 08/15] drm/i915/display: reduce the includes in intel_dvo_dev.h

2022-09-12 Thread Jani Nikula
Only include what's needed. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dvo_dev.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dvo_dev.h b/drivers/gpu/drm/i915/display/intel_dvo_dev.h index d96c3cc46e50..f44

[Intel-gfx] [PATCH 14/15] drm/i915: split out intel_display_reg_defs.h

2022-09-12 Thread Jani Nikula
Split out the display register helper macros to a separate file. For now, include it from i915_reg.h, but note that there are already files that don't need i915_reg.h, such as intel_audio.c. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/icl_dsi_regs.h | 2 +- .../gpu/drm/i915/di

[Intel-gfx] [PATCH 13/15] drm/i915/reg: move pick even and pick to reg defs

2022-09-12 Thread Jani Nikula
This is a more logical place for generic helpers. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 15 --- drivers/gpu/drm/i915/i915_reg_defs.h | 15 +++ 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 06/15] drm/i915/dpio: move dpio_channel and dpio_phy enums to intel_dpio_phy.h

2022-09-12 Thread Jani Nikula
Reduce the size of intel_display.h by moving out the dpio_channel and dpio_phy enums. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.h| 11 --- .../gpu/drm/i915/display/intel_display_power_well.h | 2 +- drivers/gpu/drm/i915/display/intel_dpio_phy.h

[Intel-gfx] [PATCH 10/15] drm/i915/display: reduce includes in g4x_dp.h includes

2022-09-12 Thread Jani Nikula
Only include what's needed. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/g4x_dp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/g4x_dp.h b/drivers/gpu/drm/i915/display/g4x_dp.h index e1f50263a725..a38b3e1e01d3 100644 --- a/driver

[Intel-gfx] [PATCH 03/15] drm/i915: reduce includes in intel_fifo_underrun.h

2022-09-12 Thread Jani Nikula
Only include what's needed. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_fifo_underrun.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fifo_underrun.h b/drivers/gpu/drm/i915/display/intel_fifo_underrun.h index e04f2

[Intel-gfx] [PATCH 07/15] drm/i915: reduce includes in intel_display_power.h

2022-09-12 Thread Jani Nikula
Only include what's needed. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_power.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h index 7136e

[Intel-gfx] [PATCH 11/15] drm/i915/irq: make gen2_irq_init()/gen2_irq_reset() static

2022-09-12 Thread Jani Nikula
The gen2 irq functions aren't used outside of i915_irq.h. Make them static, and remove the useless macro wrappers. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_irq.c | 10 +- drivers/gpu/drm/i915/i915_irq.h | 9 - 2 files changed, 5 insertions(+), 14 deletions(-) di

[Intel-gfx] [PATCH 04/15] drm/i915: un-inline icl_hdr_plane_mask() to simplify includes

2022-09-12 Thread Jani Nikula
This lets us drop the heavy intel_display.h include from intel_sprite.h. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_sprite.h| 9 + drivers/gpu/drm/i915/display/skl_universal_plane.c | 5 + drivers/gpu/drm/i915/display/skl_universal_plane.h | 1 + 3 file

[Intel-gfx] [PATCH 02/15] drm/i915: reduce includes in intel_connector.h

2022-09-12 Thread Jani Nikula
Only include what's needed. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_connector.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_connector.h b/drivers/gpu/drm/i915/display/intel_connector.h index 661a37a3c6d8..c7589

[Intel-gfx] [PATCH 05/15] drm/i915/dpio: un-inline the vlv phy/channel mapping functions

2022-09-12 Thread Jani Nikula
Simplify the heavy intel_display_types.h header. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 1 + .../drm/i915/display/intel_display_types.h| 45 --- drivers/gpu/drm/i915/display/intel_dpio_phy.c | 42 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH 01/15] drm/i915/gmbus: move GPIO enum to gmbus

2022-09-12 Thread Jani Nikula
The GPIO enum is only used in intel_gmbus.c, hide it there. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.h | 18 -- drivers/gpu/drm/i915/display/intel_gmbus.c | 20 +++- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git

[Intel-gfx] [PATCH 00/15] drm/i915: header cleanups

2022-09-12 Thread Jani Nikula
Some header cleanups to reduce our interdependencies. Here are some stats for i915, and part of the reason I keep doing this and nagging about casual addition of includes, especially in headers. We currently have 348 .c files and 353 .h files. 28% (98/353) of the header files, when modified, caus

Re: [Intel-gfx] [PATCH] drm/i915: Fix display problems after resume

2022-09-12 Thread Ville Syrjälä
On Mon, Sep 12, 2022 at 02:48:54PM +0200, Thomas Hellström wrote: > On Mon, 2022-09-12 at 15:43 +0300, Ville Syrjälä wrote: > > On Mon, Sep 12, 2022 at 02:19:57PM +0200, Thomas Hellström wrote: > > > Commit 39a2bd34c933 ("drm/i915: Use the vma resource as argument > > > for gtt > > > binding / unbi

Re: [Intel-gfx] [PATCH v3 19/37] drm/i915: stop using kernel-doc markups for something else

2022-09-12 Thread Mauro Carvalho Chehab
Hi Matt, Em Mon, 12 Sep 2022 08:09:57 -0700 Matt Roper escreveu: > > --- a/drivers/gpu/drm/i915/gt/intel_context_types.h > > +++ b/drivers/gpu/drm/i915/gt/intel_context_types.h > > Several of the comments in this file do appear to be kerneldoc (in fact > kerneldoc that was specifically reques

Re: [Intel-gfx] [PATCH 2/7] drm/i915/hwmon: Add HWMON current voltage support

2022-09-12 Thread Dixit, Ashutosh
On Mon, 12 Sep 2022 07:09:28 -0700, Gupta, Anshuman wrote: > > > +static int > > +hwm_in_read(struct hwm_drvdata *ddat, u32 attr, long *val) { > > + struct i915_hwmon *hwmon = ddat->hwmon; > > + intel_wakeref_t wakeref; > > + u32 reg_value; > > + > > + switch (attr) { > > + case hwmon_in_

[Intel-gfx] [PATCH v1 0/1] drm/i915: Copy engine fuses future-proofing

2022-09-12 Thread Lucas De Marchi
: 088771790e5d121c70c358468abbebb4710eb02f change-id: 20220912-copy-engine-526db816b088 Best regards, -- Lucas De Marchi

[Intel-gfx] [PATCH v1 1/1] drm/i915: Skip applying copy engine fuses

2022-09-12 Thread Lucas De Marchi
Support for reading the fuses to check what are the Link Copy engines was added in commit ad5f74f34201 ("drm/i915/pvc: read fuses for link copy engines"). However they were added unconditionally because the FUSE3 register is present since graphics version 10. However the bitfield with meml3 fuses

Re: [Intel-gfx] [PATCH v2 0/2] drm/i915: Media fuses future-proofing

2022-09-12 Thread Lucas De Marchi
On Fri, Sep 09, 2022 at 04:18:14PM -0700, Lucas De Marchi wrote: Update fuse handling for media to future-proof it. Signed-off-by: Lucas De Marchi Thanks Matt Roper and Andrzej for the review. Applied. Lucas De Marchi

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/gt: Extract function to apply media fuses

2022-09-12 Thread Lucas De Marchi
On Mon, Sep 12, 2022 at 10:56:16AM +0200, Andrzej Hajda wrote: On 10.09.2022 01:18, Lucas De Marchi wrote: Just like is done for compute and copy engines, extract a function to handle media engines. While at it, be consistent on using or not the uncore/gt/info variable aliases. Reviewed-by: Mat

Re: [Intel-gfx] [PATCH v3 19/37] drm/i915: stop using kernel-doc markups for something else

2022-09-12 Thread Matt Roper
On Fri, Sep 09, 2022 at 09:34:26AM +0200, Mauro Carvalho Chehab wrote: > There are some occurrences of "/**" that aren't actually part of > a kernel-doc markup. Replace them by "/*", in order to make easier > to identify what i915 files contain kernel-doc markups. > > Reviewed-by: Rodrigo Vivi >

Re: [Intel-gfx] [PATCH v4 05/15] mei: pxp: add command streamer API to the PXP driver

2022-09-12 Thread Greg Kroah-Hartman
On Mon, Sep 12, 2022 at 09:59:45AM +, Winkler, Tomas wrote: > > > > On Fri, Sep 09, 2022 at 06:38:33AM +, Winkler, Tomas wrote: > > > > > > > > On Thu, Sep 08, 2022 at 05:16:02PM -0700, Daniele Ceraolo Spurio wrote: > > > > > +static ssize_t mei_pxp_gsc_command(struct device *dev, u8 > > >

Re: [Intel-gfx] [PATCH 2/7] drm/i915/hwmon: Add HWMON current voltage support

2022-09-12 Thread Gupta, Anshuman
> -Original Message- > From: Nilawar, Badal > Sent: Thursday, August 25, 2022 6:51 PM > To: intel-gfx@lists.freedesktop.org > Cc: Dixit, Ashutosh ; Tauro, Riana > ; Gupta, Anshuman ; > Ewins, Jon ; linux-hw...@vger.kernel.org > Subject: [PATCH 2/7] drm/i915/hwmon: Add HWMON current volt

Re: [Intel-gfx] [PULL] drm-intel-fixes

2022-09-12 Thread Vivi, Rodrigo
On Sun, 2022-09-11 at 19:22 +0200, Jason A. Donenfeld wrote: > Hi Rodrigo, > > On Thu, Sep 08, 2022 at 09:59:54AM -0400, Rodrigo Vivi wrote: > > Hi Dave and Daniel, > > > > A few fixes, but most targeting stable. > > > > [...] > > > > Ville Syrjälä (2): > >   drm/i915: Implement WaEdpLinkRa

[Intel-gfx] NULL pointer dereference in i915 in i915_gem_do_execbuffer, eb_lookup_vmas

2022-09-12 Thread Maxim Mikityanskiy
Hi all, I experience periodic crashes on HP Elite Dragonfly G2 (i7-1165G7) which, I believe, are related to a bug in the i915 driver. I collected a stacktrace and a kdump on 5.19.8 compiled with KASAN. This time the screen was frozen, but I could SSH into the machine. Sometimes a kernel panic happ

Re: [Intel-gfx] [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes

2022-09-12 Thread kFYatek
Hi Maxime, W dniu 9.09.2022 o 16:00, Maxime Ripard pisze: > On Wed, Sep 07, 2022 at 11:31:21PM +0200, Mateusz Kwiatkowski wrote: >> The "canonical" modelines (at least for vc4's VEC, see the notes below): >> >> - (vfp==4, vsync==6, vbp==39) for 576i >> - (vfp==7, vsync==6, vbp==32) for 480i >> - (

Re: [Intel-gfx] [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.

2022-09-12 Thread Zheng Hacker
Hi Greg, I got it, Greg. Mid-Autumn Festival is coming and I will have a couple of days off. I'll see what I can do after holiday :) Regards, Zheng Wang 在 2022年9月8日星期四,Greg KH 写道: > On Thu, Sep 08, 2022 at 05:09:40PM +0800, Zheng Hacker wrote: > > Hi Zhenyu, > > > > This issue has been open

Re: [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.

2022-09-12 Thread Zheng Hacker
>From 18fc95d6a73f0af7e8947a1cb01a3a39f2e61c00 Mon Sep 17 00:00:00 2001 From: xmzyshypnc <1002992...@qq.com> Date: Sun, 4 Sep 2022 20:20:56 +0800 Subject: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry. There is a double-free security bug in split_2MB_gtt_entry. Here is a callin

Re: [Intel-gfx] [PATCH v2 37/41] drm/sun4i: tv: Remove useless function

2022-09-12 Thread Jernej Škrabec
Dne ponedeljek, 29. avgust 2022 ob 15:11:51 CEST je Maxime Ripard napisal(a): > The drm_connector_to_sun4i_tv() function isn't used anywhere in the driver, > so let's remove it. > > Signed-off-by: Maxime Ripard Acked-by: Jernej Skrabec Best regards, Jernej

Re: [Intel-gfx] [PATCH v2 32/41] drm/vc4: vec: Convert to the new TV mode property

2022-09-12 Thread Mateusz Kwiatkowski
Hi Maxime, W dniu 08.09.2022 o 13:23, Maxime Ripard pisze: > Hi Noralf, > > On Tue, Aug 30, 2022 at 09:01:08PM +0200, Noralf Trønnes wrote: >>> +static const struct drm_prop_enum_list tv_mode_names[] = { >> >> Maybe call it legacy_tv_mode_enums? >> >>> >>> +    { VC4_VEC_TV_MODE_NTSC, "NTSC", }, >

Re: [Intel-gfx] [PATCH v6 17/57] dyndbg: validate class FOO by checking with module

2022-09-12 Thread Jason Baron
On 9/4/22 17:40, Jim Cromie wrote: > Add module-to-class validation: > > #> echo class DRM_UT_KMS +p > /proc/dynamic_debug/control > > If a query has "class FOO", then ddebug_find_valid_class(), called > from ddebug_change(), requires that FOO is known to module X, > otherwize the query is s

  1   2   >