> -Original Message-
> From: Ville Syrjälä
> Sent: Wednesday, August 24, 2022 5:48 PM
> To: Murthy, Arun R
> Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma
> Subject: Re: [PATCHv3] drm/i915: Support Async Flip on Linear buffers
>
> On Wed, Aug 24, 2022 at 03:02:33AM +, Murthy, Ar
On Thu, 25 Aug 2022 06:21:18 -0700, Badal Nilawar wrote:
>
> From: Dale B Stimson
>
> Extend hwmon power/energy for XEHPSDV especially per gt level energy
> usage.
A couple of very minor nits below which need to be fixed. But otherwise
this patch is:
Reviewed-by: Ashutosh Dixit
> diff --git a/
On Thu, 25 Aug 2022 06:21:15 -0700, Badal Nilawar wrote:
>
> From: Dale B Stimson
>
> Use i915 HWMON to display device level energy input.
>
> v2:
> - Updated the date and kernel version in feature description
A few things to delete below but since no other changes this is:
Reviewed-by: Ashuto
On Thu, 25 Aug 2022 06:21:14 -0700, Badal Nilawar wrote:
>
> diff --git a/drivers/gpu/drm/i915/i915_hwmon.c
> b/drivers/gpu/drm/i915/i915_hwmon.c
> index 2192d0fd4c66..922463da65bf 100644
> --- a/drivers/gpu/drm/i915/i915_hwmon.c
> +++ b/drivers/gpu/drm/i915/i915_hwmon.c
> @@ -13,8 +13,22 @@
> #i
== Series Details ==
Series: drm/i915/bios: Copy the whole MIPI sequence block (rev2)
URL : https://patchwork.freedesktop.org/series/107896/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12046 -> Patchwork_107896v2
Summary
== Series Details ==
Series: drm/i915/selftests: allow misaligned_pin test work with unmappable
memory
URL : https://patchwork.freedesktop.org/series/107760/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12025_full -> Patchwork_107760v1_full
==
== Series Details ==
Series: drm/i915/selftests: do not try misaligned_pin test on unmappable memory
URL : https://patchwork.freedesktop.org/series/107758/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12025_full -> Patchwork_107758v1_full
=
== Series Details ==
Series: drm/kms: Stop registering multiple /sys/class/backlight devs for a
single display
URL : https://patchwork.freedesktop.org/series/107755/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12025_full -> Patchwork_107755v1_full
==
== Series Details ==
Series: i915: Add "standalone media" support for MTL (rev2)
URL : https://patchwork.freedesktop.org/series/107908/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12044 -> Patchwork_107908v2
Summary
-
== Series Details ==
Series: i915: Add "standalone media" support for MTL (rev2)
URL : https://patchwork.freedesktop.org/series/107908/
State : warning
== Summary ==
Error: dim checkpatch failed
b89acd14d33e drm/i915: Move locking and unclaimed check into
mmio_debug_{suspend, resume}
f45cffb3
We're going to introduce an additional intel_gt for MTL's media unit
soon. Let's provide a bit more multi-GT initialization framework in
preparation for that. The initialization will pull the list of GTs for
a platform from the device info structure. Although necessary for the
immediate MTL medi
== Series Details ==
Series: i915: Add "standalone media" support for MTL
URL : https://patchwork.freedesktop.org/series/107908/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12044 -> Patchwork_107908v1
Summary
---
*
== Series Details ==
Series: i915: Add "standalone media" support for MTL
URL : https://patchwork.freedesktop.org/series/107908/
State : warning
== Summary ==
Error: dim checkpatch failed
2d07e36f0a4f drm/i915: Move locking and unclaimed check into
mmio_debug_{suspend, resume}
943c8e30fc24 dr
== Series Details ==
Series: drm/i915/display: Fix warning callstack for imbalance wakeref (rev6)
URL : https://patchwork.freedesktop.org/series/107211/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12044 -> Patchwork_107211v6
==
== Series Details ==
Series: drm/i915: Add HWMON support (rev5)
URL : https://patchwork.freedesktop.org/series/104278/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12024_full -> Patchwork_104278v5_full
Summary
---
*
== Series Details ==
Series: drm/i915/bios: Copy the whole MIPI sequence block
URL : https://patchwork.freedesktop.org/series/107896/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12044 -> Patchwork_107896v1
Summary
---
== Series Details ==
Series: Add DP MST DSC support to i915 (rev10)
URL : https://patchwork.freedesktop.org/series/101492/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12044 -> Patchwork_101492v10
Summary
---
**SUCC
== Series Details ==
Series: Add DP MST DSC support to i915 (rev10)
URL : https://patchwork.freedesktop.org/series/101492/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+./arch/x86/include/asm/bitops.h:117
== Series Details ==
Series: Add DP MST DSC support to i915 (rev10)
URL : https://patchwork.freedesktop.org/series/101492/
State : warning
== Summary ==
Error: dim checkpatch failed
ded7d35c7112 drm: Add missing DP DSC extended capability definitions.
e15a191fd540 drm/i915: Fix intel_dp_mst_co
== Series Details ==
Series: drm: Analog TV Improvements
URL : https://patchwork.freedesktop.org/series/107892/
State : failure
== Summary ==
Error: make failed
CALLscripts/checksyscalls.sh
CALLscripts/atomic/check-atomics.sh
DESCEND objtool
CHK include/generated/compile.h
== Series Details ==
Series: drm/i915: add display sub-struct to drm_i915_private (rev3)
URL : https://patchwork.freedesktop.org/series/107170/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12044 -> Patchwork_107170v3
Summa
== Series Details ==
Series: drm/i915: add display sub-struct to drm_i915_private (rev3)
URL : https://patchwork.freedesktop.org/series/107170/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: add display sub-struct to drm_i915_private (rev3)
URL : https://patchwork.freedesktop.org/series/107170/
State : warning
== Summary ==
Error: dim checkpatch failed
b9427de47e84 drm/i915: move and group hdcp under display.hdcp
38c5ef38c07f drm/i915: move a
== Series Details ==
Series: Move all drivers to a common dma-buf locking convention
URL : https://patchwork.freedesktop.org/series/107884/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12044 -> Patchwork_107884v1
Summary
-
== Series Details ==
Series: DGFX mmap with rpm (rev2)
URL : https://patchwork.freedesktop.org/series/107400/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12024_full -> Patchwork_107400v2_full
Summary
---
**SUCCESS*
== Series Details ==
Series: Move all drivers to a common dma-buf locking convention
URL : https://patchwork.freedesktop.org/series/107884/
State : warning
== Summary ==
Error: dim checkpatch failed
95c5249c37bb dma-buf: Add _unlocked postfix to function names
-:770: CHECK:OPEN_ENDED_LINE: Lin
When we hook up interrupts (in the next patch), interrupts for the media
GT are still processed as part of the primary GT's interrupt flow. As
such, we should share the same IRQ lock with the primary GT. Let's
convert gt->irq_lock into a pointer and just point the media GT's
instance at the same
Top-level handling of standalone media interrupts will be processed as
part of the primary GT's interrupt handler (since primary and media GTs
share an MMIO space, unlike remote tile setups). When we get down to
the point of handling engine interrupts, we need to take care to lookup
VCS and VECS e
Xe_LPM+ platforms have "standalone media." I.e., the media unit is
designed as an additional GT with its own engine list, GuC, forcewake,
etc. Let's allow platforms to include media GTs in their device info.
Cc: Aravind Iddamsetty
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i915/Makefile
Moving the locking for MMIO debug (and the final check for unclaimed
accesses when resuming debug after a userspace-initiated forcewake) will
make it simpler to completely skip MMIO debug handling on uncores that
don't support it in future patches.
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i
The common early GT init is needed for initialization of all GT types
(root/primary, remote tile, standalone media). Since standalone media
(coming in the next patch) will be implemented in a separate file,
rename and expose the function for use.
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i9
The original intent of intel_uncore_mmio_debug as described in commit
0a9b26306d6a ("drm/i915: split out uncore_mmio_debug") was to be a
singleton structure that could be shared between multiple GTs' uncore
objects in a multi-tile system. Somehow we went off track and
started allocating separate i
We're going to introduce an additional intel_gt for MTL's media unit
soon. Let's provide a bit more multi-GT initialization framework in
preparation for that. The initialization will pull the list of GTs for
a platform from the device info structure. Although necessary for the
immediate MTL medi
We're slowly transitioning the init-time kzalloc's of the driver over to
DRM-managed allocations; let's make sure the uncore objects allocated
for non-root GTs are thus allocated.
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_gt.c | 6 ++
1 file changed, 2 insertions(+), 4 dele
Starting with MTL, media functionality has moved into a new, second GT
at the hardware level. This new GT, referred to as "standalone media"
in the spec, has its own GuC, power management/forcewake, etc. The
general non-engine GT registers for standalone media start at 0x38,
but otherwise use
On Thu, 25 Aug 2022 06:21:13 -0700, Badal Nilawar wrote:
>
> From: Riana Tauro
>
> Use i915 HWMON subsystem to display current input voltage.
A couple of suggestions to improve comments in this patch below and after
addressing those this patch is:
Reviewed-by: Ashutosh Dixit
> diff --git a/dri
== Series Details ==
Series: drm/i915: fix repeated words in comments (rev3)
URL : https://patchwork.freedesktop.org/series/107885/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12044 -> Patchwork_107885v3
Summary
---
On Thu, 25 Aug 2022 06:21:12 -0700, Badal Nilawar wrote:
>
A couple of minor observations below but otherwise this patch is:
Reviewed-by: Ashutosh Dixit
> diff --git a/drivers/gpu/drm/i915/i915_hwmon.c
> b/drivers/gpu/drm/i915/i915_hwmon.c
> new file mode 100644
> index ..103dd543a
== Series Details ==
Series: drm/i915: fix repeated words in comments (rev3)
URL : https://patchwork.freedesktop.org/series/107885/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
== Series Details ==
Series: i915/display: fix repeated words in comments
URL : https://patchwork.freedesktop.org/series/107887/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12044 -> Patchwork_107887v1
Summary
---
*
Hi Imre,
> -Original Message-
> From: Deak, Imre
> Sent: 29 August 2022 20:16
> To: Golani, Mitulkumar Ajitkumar
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for
> imbalance wakeref
>
> On Mon, Aug 29, 2022 at 09:45:53A
== Series Details ==
Series: i915/gvt: fix repeated words in comments
URL : https://patchwork.freedesktop.org/series/107883/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12044 -> Patchwork_107883v1
Summary
---
**SUC
While executing i915_selftest, wakeref imbalance warning is seen
with i915_selftest failure.
Currently when Driver is suspended, while doing unregister
it is taking wakeref without resuming the device.
This patch is resuming the device, if driver is already suspended
and doing unregister process.
On Fri, Aug 26, 2022 at 02:02:33PM -0700, Matt Roper wrote:
> This reverts commit ca6920811aa5428270dd78af0a7a36b10119065a.
>
> The intent of Wa_14015141709 was to inform us that userspace can no
> longer control object-level preemption as it has on past platforms
> (i.e., by twiddling register bi
On Fri, Aug 26, 2022 at 02:27:18PM -0700, Matt Roper wrote:
> On client DG2 platforms, optimal performance is achieved with the
> hardware's default "age based" thread execution setting. However on
> ATS-M, switching this to "round robin after dependencies" provides
> better performance. We'll ad
== Series Details ==
Series: drm/i915/ttm: Abort suspend on i915_ttm_backup failure
URL : https://patchwork.freedesktop.org/series/107877/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12041 -> Patchwork_107877v1
Summary
--
== Series Details ==
Series: drm/edid: Range descriptor stuff (rev2)
URL : https://patchwork.freedesktop.org/series/107824/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12041 -> Patchwork_107824v2
Summary
---
**SUCC
On Mon, Aug 29, 2022 at 09:45:53AM +0300, Golani, Mitulkumar Ajitkumar wrote:
> Hi Imre,
>
> > [...]
> > Still not sure what's going. Both i915_pci_probe() and
> > i915_pci_remove()->i915_driver_remove() is called with a runtime PM
> > reference - taken at local_pci_probe() and pci_device_remove()
Hi Stan,
I wonder if it is better if you reorder the 3 and 4 patches in this - move this
4/4 before the 3rd
one and modify the 3rd one accordingly.
Also, instead of getting rid of limits, keep limits and populate the limits
according to dsc or
normal dp_mst. What do you think?
BR
vinod
On Mo
== Series Details ==
Series: drm/edid: Range descriptor stuff (rev2)
URL : https://patchwork.freedesktop.org/series/107824/
State : warning
== Summary ==
Error: dim checkpatch failed
8832b89186e8 drm/edid: Handle EDID 1.4 range descriptor h/vfreq offsets
c2a4eb80d064 drm/edid: Clarify why we o
Reviewed-by: Vinod Govindapillai
On Mon, 2022-08-29 at 12:58 +0300, Stanislav Lisovskiy wrote:
> We currently always exit that bpp loop because drm_dp_atomic_find_vcpi_slots
> doesn't care if we actually can fit those or not.
> I think that wasn't the initial intention here, especially when
> we
On Tue, 23 Aug 2022, Jilin Yuan wrote:
> Delete the redundant word 'other'.
> Delete the redundant word 'the'.
> Delete the redundant word 'will'.
>
> Signed-off-by: Jilin Yuan
Doesn't apply because some of the hunks were already fixed by other
commits.
BR,
Jani.
> ---
> drivers/gpu/drm/i
On Tue, 23 Aug 2022, wangjianli wrote:
> Delete the redundant word 'the'.
>
> Signed-off-by: wangjianli
Already fixed by commit 78f48aa6f50b ("drm/i915/irq: Fix a "the the"
typo").
What is this sudden influx of patches fixing repeated words everywhere?
BR,
Jani.
> ---
> drivers/gpu/drm/i91
On Tue, 23 Aug 2022, Umesh Nerlige Ramappa
wrote:
> DG2 introduces 64 bit counters and OA reports that have 64 bit values
> for fields in the report header - report_id, timestamp, context_id and
> gpu ticks. i915 uses report_id, timestamp and context_id to check for
> valid reports.
>
> In some D
From: Ville Syrjälä
Turns out the MIPI sequence block version number and
new block size fields are considered part of the block
header and are not included in the reported new block size
field itself. Bump up the block size appropriately so that
we'll copy over the last five bytes of the block as
On Tue, Aug 23, 2022 at 11:01:28AM +0200, Maarten Lankhorst wrote:
> Signed-off-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/i915/display/intel_bw.c | 8 ++--
> drivers/gpu/drm/i915/display/intel_crt.c | 33 +++--
> drivers/gpu/drm/i915/display/intel_de.h | 47 +
We are using almost same code to loop through bpps while calling
drm_dp_atomic_find_vcpi_slots - lets remove this duplication by
introducing a new function intel_dp_mst_find_vcpi_slots_for_bpp
v2: Fix pbn_div calculation - shouldn't matter if its DSC or not.
Signed-off-by: Stanislav Lisovskiy
--
On Mon, 29 Aug 2022, Jani Nikula wrote:
> On Tue, 23 Aug 2022, Maarten Lankhorst
> wrote:
>
> Commit message!
>
> I think this is doing a bit too much at once. The straightforward
> conversions are fine I think, but adding new de helpers and using them
> here along with everything else is a bit
On Tue, 23 Aug 2022, Maarten Lankhorst
wrote:
> This will allow us not to use uncore from display code directly any more.
Mmh, a bit tedious but I guess this is what we'll need to do. See also
ee421bb4cb95 ("drm/i915/pcode: Extend pcode functions for multiple
gt's").
Reviewed-by: Jani Nikula
On Tue, 23 Aug 2022, Maarten Lankhorst
wrote:
Commit message!
I think this is doing a bit too much at once. The straightforward
conversions are fine I think, but adding new de helpers and using them
here along with everything else is a bit much.
BR,
Jani.
> Signed-off-by: Maarten Lankhorst
On Tue, 23 Aug 2022, Maarten Lankhorst
wrote:
Commit message!
> Signed-off-by: Maarten Lankhorst
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_bios.c | 25 ---
> 1 file changed, 13 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/i91
On Tue, 23 Aug 2022, Maarten Lankhorst
wrote:
> Use the intel_de macro's instead of referencing uncore directly.
>
> Signed-off-by: Maarten Lankhorst
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_tc.c | 55 -
> 1 file changed, 18 insertions(+), 3
As part of the command line parsing rework coming in the next patches,
we'll need to lookup drm_connector_tv_mode values by their name, already
defined in drm_tv_mode_enum_list.
In order to avoid any code duplication, let's do a function that will
perform a lookup of a TV mode name and return its
From: Mateusz Kwiatkowski
Change the mode_set function pointer logic to declarative config0,
config1 and custom_freq fields, to make TV mode setting logic more
concise and uniform.
Signed-off-by: Mateusz Kwiatkowski
Signed-off-by: Maxime Ripard
diff --git a/drivers/gpu/drm/vc4/vc4_vec.c b/dri
The mode_valid implementation is pretty much a nop, let's remove it.
Signed-off-by: Maxime Ripard
Reviewed-by: Jernej Skrabec
diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c
index 94883abe0dfd..53152d77c392 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tv.c
+++ b/dri
The analog TV connector drivers share some atomic_check logic, and the new
TV standard property have created a bunch of new constraints that needs to
be shared across drivers too.
Let's create an atomic_check helper for those use cases.
Signed-off-by: Maxime Ripard
diff --git a/drivers/gpu/drm/
Our destroy implementation is just calling the generic helper, so let's
just remove our function and directly use the helper.
Signed-off-by: Maxime Ripard
Reviewed-by: Jernej Skrabec
diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c
index 52bbba8f19dc..6d7e1d51569
Our new tv mode option allows to specify the TV mode from a property.
However, it can still be useful, for example to avoid any boot time
artifact, to set that property directly from the kernel command line.
Let's add some code to allow it, and some unit tests to exercise that code.
Signed-off-by
The mode_fixup hooks are deprecated, and the behaviour we implement is the
default one anyway. Let's remove it.
Signed-off-by: Maxime Ripard
diff --git a/drivers/gpu/drm/vc4/vc4_vec.c b/drivers/gpu/drm/vc4/vc4_vec.c
index d5140fe0be4f..d521ffd8d75c 100644
--- a/drivers/gpu/drm/vc4/vc4_vec.c
+++
Our mode_set implementation can be merged into our atomic_enable
implementation to simplify things, so let's do this.
Signed-off-by: Maxime Ripard
diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c
index f7aad995ab5b..3944da9a3c34 100644
--- a/drivers/gpu/drm/sun4i/
The framework will get the drm_display_mode from the drm_cmdline_mode it
got by parsing the video command line argument by calling
drm_connector_pick_cmdline_mode().
The heavy lifting will then be done by the drm_mode_create_from_cmdline_mode()
function.
In the case of the named modes though, the
The other error labels in sun4i_tv_bind() are named after the task they
perform (err_disable_clk to call clk_disable_unprepare for example).
However, the err_cleanup_connector is named after the calling site
(drm_connector_init failing) and will actually cleanup the encoder. Let's
rename it to err
Now that the core can deal fine with analog TV modes, let's convert the
sun4i TV driver to leverage those new features.
Signed-off-by: Maxime Ripard
diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c
index 74ff5ad6a8b9..10c0d727d700 100644
--- a/drivers/gpu/drm/sun4
From: Mateusz Kwiatkowski
Let's remove the superfluous tv_mode field, which was redundant with the
mode field in struct drm_tv_connector_state.
Signed-off-by: Mateusz Kwiatkowski
Signed-off-by: Maxime Ripard
diff --git a/drivers/gpu/drm/vc4/vc4_vec.c b/drivers/gpu/drm/vc4/vc4_vec.c
index 9a37
The drm_connector_to_sun4i_tv() function isn't used anywhere in the driver,
so let's remove it.
Signed-off-by: Maxime Ripard
diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c
index 3944da9a3c34..52bbba8f19dc 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tv.c
+++ b/drive
The sun4i TV driver still uses legacy enable and disable hook
implementation. Let's convert to the atomic variants.
Signed-off-by: Maxime Ripard
diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c
index 53152d77c392..f7aad995ab5b 100644
--- a/drivers/gpu/drm/sun4i/su
From: Mateusz Kwiatkowski
This commit fixes vertical timings of the VEC (composite output) modes
to accurately represent the 525-line ("NTSC") and 625-line ("PAL") ITU-R
standards.
Previous timings were actually defined as 502 and 601 lines, resulting
in non-standard 62.69 Hz and 52 Hz signals b
The current code to deal with named modes will only set the mode name, and
then it's up to drivers to try to match that name to whatever mode or
configuration they see fit.
The plan is to remove that need and move the named mode handling out of
drivers and into the core, and only rely on modes and
Now that the core has a definition for the 525 and 625 lines analog TV
modes, let's switch to it for vc4.
Signed-off-by: Maxime Ripard
diff --git a/drivers/gpu/drm/vc4/vc4_vec.c b/drivers/gpu/drm/vc4/vc4_vec.c
index d1d40b69279e..63e4e617e321 100644
--- a/drivers/gpu/drm/vc4/vc4_vec.c
+++ b/driv
The VC4 VEC driver still uses legacy enable and disable hook
implementation. Let's convert to the atomic variants.
Signed-off-by: Maxime Ripard
diff --git a/drivers/gpu/drm/vc4/vc4_vec.c b/drivers/gpu/drm/vc4/vc4_vec.c
index d521ffd8d75c..72eee0cbb615 100644
--- a/drivers/gpu/drm/vc4/vc4_vec.c
+
The current named mode parsing relies only the mode name, and doesn't allow
to specify any other parameter.
Let's convert that string list to an array of a custom structure that will
hold the name and some additional parameters in the future.
Signed-off-by: Maxime Ripard
diff --git a/drivers/gp
The drm_tv_create_properties() function will create a bunch of properties,
but it's up to each and every driver using that function to properly reset
the state of these properties leading to inconsistent behaviours.
Let's create a helper that will take care of it.
Signed-off-by: Maxime Ripard
d
From: Mateusz Kwiatkowski
PAL-M is a Brazilian analog TV standard that uses a PAL-style chroma
subcarrier at 3.575611[888111] MHz on top of 525-line (480i60) timings.
This commit makes the driver actually use the proper VEC preset for this
mode instead of just changing PAL subcarrier frequency.
The reset line is deasserted at bind, and asserted if we ever encounter an
error there. However, it's never asserted in unbind which will lead to a
resource unbalance.
Signed-off-by: Maxime Ripard
Reviewed-by: Jernej Skrabec
diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/
From: Mateusz Kwiatkowski
Add support for the following composite output modes (all of them are
somewhat more obscure than the previously defined ones):
- NTSC_443 - NTSC-style signal with the chroma subcarrier shifted to
4.43361875 MHz (the PAL subcarrier frequency). Never used for
broadcas
Now that the core can deal fine with analog TV modes, let's convert the vc4
VEC driver to leverage those new features.
We've added some backward compatibility to support the old TV mode property
and translate it into the new TV norm property.
Signed-off-by: Maxime Ripard
diff --git a/drivers/gp
We'll need to get the pixel clock to generate proper display modes for
all the current named modes. Let's add it to struct drm_cmdline_mode and
fill it when parsing the named mode.
Signed-off-by: Maxime Ripard
diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
index 5e898699b
The analog TV properties created by the drm_mode_create_tv_properties() are
not properly initialised at reset. Let's switch our implementation to call
drm_atomic_helper_connector_tv_reset().
Signed-off-by: Maxime Ripard
diff --git a/drivers/gpu/drm/vc4/vc4_vec.c b/drivers/gpu/drm/vc4/vc4_vec.c
i
Now that we can easily extend the named modes list, let's add a few more
analog TV modes that were used in the wild, and some unit tests to make
sure it works as intended.
Signed-off-by: Maxime Ripard
diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
index 065dbfbd815e..7d76
Hi Dave & Daniel -
drm-intel-next-2022-08-29:
drm/i915 feature pull for v6.1:
Features and functionality:
- Early Meteorlake (MTL) enabling (José, Radhakrishna, Clint, Imre, Vandita,
Ville, Jani)
- Support more HDMI pixel clock frequencies on DG2 (Clint)
- Sanity check PCI BARs (Piotr Piórkows
Multiple drivers (meson, vc4, sun4i) define analog TV 525-lines and
625-lines modes in their drivers.
Since those modes are fairly standard, and that we'll need to use them
in more places in the future, it makes sense to move their definition
into the core framework.
However, analog display usual
As the number of kunit tests in KMS grows further, we start to have
multiple test suites that, for example, need to register a mock DRM
driver to interact with the KMS function they are supposed to test.
Let's add a file meant to provide those kind of helpers to avoid
duplication.
Signed-off-by:
The current tv_mode has driver-specific values that don't allow to
easily share code using it, either at the userspace or kernel level.
Since we're going to introduce a new, generic, property that fit the
same purpose, let's rename this one to legacy_tv_mode to make it
obvious we should move away
There is two TV subconnector related properties registered by
drm_mode_create_tv_properties(): subconnector and select subconnector.
While the select subconnector property is stored in the kernel by the
drm_tv_connector_state structure, the subconnector property isn't stored
anywhere.
Worse, the
Some video= options might have a value that contains a dash. However, the
command line parsing mode considers all dashes as the separator between the
mode and the bpp count.
Let's rework the parsing code a bit to only consider a dash as the bpp
separator if it before a comma, the options separator
drm_mode_create_tv_properties(), among other things, will create the
"mode" property that stores the analog TV mode that connector is
supposed to output.
However, that property is getting deprecated, so let's rename that
function to mention it's deprecated. We'll introduce a new variant of
that fu
The drm_create_tv_properties() will create the TV mode property
unconditionally.
However, since we'll gradually phase it out, let's register it only if we
have a list passed as an argument. This will make the transition easier.
Signed-off-by: Maxime Ripard
Acked-by: Noralf Trønnes
diff --git a
The subconnector property was created by drm_mode_create_tv_properties(),
but wasn't exposed to the userspace through the generic
atomic_get/set_property implementation, and wasn't stored in any generic
state structure.
Let's solve this.
Signed-off-by: Maxime Ripard
Reviewed-by: Noralf Trønnes
We currently have two sets of TV properties.
The first one is there to deal with analog TV properties, creating
properties such as the TV mode, subconnectors, saturation, hue and so on.
It's created by calling the drm_mode_create_tv_properties() function.
The second one is there to deal with prop
From: Geert Uytterhoeven
It is fairly common for named video modes to contain dashes (e.g.
"tt-mid" on Atari, "dblntsc-ff" on Amiga). Currently such mode names
are not recognized, as the dash is considered to be a separator between
mode name and bpp.
Fix this by skipping any dashes that are not
1 - 100 of 168 matches
Mail list logo
