[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/gt: Add dedicated function for non-ctx register tuning settings

2022-08-12 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Add dedicated function for non-ctx register tuning settings URL : https://patchwork.freedesktop.org/series/107224/ State : success == Summary == CI Bug Log - changes from CI_DRM_11986_full -> Patchwork_107224v1_full

[Intel-gfx] [PATCH v6 8/8] drm/i915: Remove truncation warning for large objects

2022-08-12 Thread Gwan-gyeong Mun
From: Chris Wilson Having addressed the issues surrounding incorrect types for local variables and potential integer truncation in using the scatterlist API, we have closed all the loop holes we had previously identified with dangerously large object creation. As such, we can eliminate the warnin

[Intel-gfx] [PATCH v6 7/8] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

2022-08-12 Thread Gwan-gyeong Mun
The ttm_bo_init_reserved() functions returns -ENOSPC if the size is too big to add vma. The direct function that returns -ENOSPC is drm_mm_insert_node_in_range(). To handle the same error as other code returning -E2BIG when the size is too large, it converts return value to -E2BIG. Signed-off-by:

[Intel-gfx] [PATCH v6 5/8] drm/i915: Check for integer truncation on the configuration of ttm place

2022-08-12 Thread Gwan-gyeong Mun
There is an impedance mismatch between the first/last valid page frame number of ttm place in unsigned and our memory/page accounting in unsigned long. As the object size is under the control of userspace, we have to be prudent and catch the conversion errors. To catch the implicit truncation as we

[Intel-gfx] [PATCH v6 6/8] drm/i915: Check if the size is too big while creating shmem file

2022-08-12 Thread Gwan-gyeong Mun
The __shmem_file_setup() function returns -EINVAL if size is greater than MAX_LFS_FILESIZE. To handle the same error as other code that returns -E2BIG when the size is too large, it add a code that returns -E2BIG when the size is larger than the size that can be handled. v4: If BITS_PER_LONG is 32

[Intel-gfx] [PATCH v6 1/8] overflow: Move and add few utility macros into overflow

2022-08-12 Thread Gwan-gyeong Mun
It moves overflows_type utility macro into overflow header from i915_utils header. The overflows_type can be used to catch the truncation between data types. And it adds safe_conversion() macro which performs a type conversion (cast) of an source value into a new variable, checking that the destina

[Intel-gfx] [PATCH v6 4/8] drm/i915: Check for integer truncation on scatterlist creation

2022-08-12 Thread Gwan-gyeong Mun
From: Chris Wilson There is an impedance mismatch between the scatterlist API using unsigned int and our memory/page accounting in unsigned long. That is we may try to create a scatterlist for a large object that overflows returning a small table into which we try to fit very many pages. As the o

[Intel-gfx] [PATCH v6 0/8] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-08-12 Thread Gwan-gyeong Mun
This patch series fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation, etc. We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead o

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gt: Add dedicated function for non-ctx register tuning settings

2022-08-12 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Add dedicated function for non-ctx register tuning settings URL : https://patchwork.freedesktop.org/series/107224/ State : success == Summary == CI Bug Log - changes from CI_DRM_11986 -> Patchwork_107224v1 ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/gt: Add dedicated function for non-ctx register tuning settings

2022-08-12 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Add dedicated function for non-ctx register tuning settings URL : https://patchwork.freedesktop.org/series/107224/ State : warning == Summary == Error: dim checkpatch failed e2e3d2199931 drm/i915/gt: Add dedicated function f

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v6,1/6] drm/ttm: Add new callbacks to ttm res mgr

2022-08-12 Thread Patchwork
== Series Details == Series: series starting with [v6,1/6] drm/ttm: Add new callbacks to ttm res mgr URL : https://patchwork.freedesktop.org/series/107213/ State : success == Summary == CI Bug Log - changes from CI_DRM_11986_full -> Patchwork_107213v1_full =

[Intel-gfx] [PATCH 2/2] drm/i915/dg2: Add additional tuning settings

2022-08-12 Thread Matt Roper
Some additional MMIO tuning settings have appeared in the bspec's performance tuning guide section. One of the tuning settings here is also documented as formal workaround Wa_22012654132 for some steppings of DG2. However the tuning setting applies to all DG2 variants and steppings, making it a s

[Intel-gfx] [PATCH 1/2] drm/i915/gt: Add dedicated function for non-ctx register tuning settings

2022-08-12 Thread Matt Roper
The bspec performance tuning section gives recommended settings that the driver should program for various MMIO registers. Although these settings aren't "workarounds" we use the workaround infrastructure to do this programming to make sure it is handled at the appropriate places and doesn't confl

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Fix warning callstack for imbalance wakeref

2022-08-12 Thread Patchwork
== Series Details == Series: drm/i915/display: Fix warning callstack for imbalance wakeref URL : https://patchwork.freedesktop.org/series/107211/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11986_full -> Patchwork_107211v1_full ===

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add HWMON support (rev3)

2022-08-12 Thread Patchwork
== Series Details == Series: drm/i915: Add HWMON support (rev3) URL : https://patchwork.freedesktop.org/series/104278/ State : success == Summary == CI Bug Log - changes from CI_DRM_11986 -> Patchwork_104278v3 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Add HWMON support (rev3)

2022-08-12 Thread Patchwork
== Series Details == Series: drm/i915: Add HWMON support (rev3) URL : https://patchwork.freedesktop.org/series/104278/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add HWMON support (rev3)

2022-08-12 Thread Patchwork
== Series Details == Series: drm/i915: Add HWMON support (rev3) URL : https://patchwork.freedesktop.org/series/104278/ State : warning == Summary == Error: dim checkpatch failed 1de65e10c7ff drm/i915/hwmon: Add HWMON infrastructure Traceback (most recent call last): File "scripts/spdxcheck.p

Re: [Intel-gfx] [PATCH 7/7] drm/i915/hwmon: Extend power/energy for XEHPSDV

2022-08-12 Thread Guenter Roeck
On 8/12/22 10:37, Badal Nilawar wrote: From: Dale B Stimson Extend hwmon power/energy for XEHPSDV especially per gt level energy usage. v2: Update to latest HWMON spec (Ashutosh) Signed-off-by: Ashutosh Dixit Signed-off-by: Dale B Stimson Signed-off-by: Badal Nilawar Acked-by: Guenter Ro

Re: [Intel-gfx] [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval

2022-08-12 Thread Guenter Roeck
On 8/12/22 10:37, Badal Nilawar wrote: From: Ashutosh Dixit Expose power1_max_interval, that is the tau corresponding to PL1. Some bit manipulation is needed because of the format of PKG_PWR_LIM_1_TIME in GT0_PACKAGE_RAPL_LIMIT register (1.x * power(2,y)). v2: Update date and kernel version in

Re: [Intel-gfx] [PATCH 5/7] drm/i915/hwmon: Expose card reactive critical power

2022-08-12 Thread Guenter Roeck
On 8/12/22 10:37, Badal Nilawar wrote: From: Ashutosh Dixit Expose the card reactive critical (I1) power. I1 is exposed as power1_crit in microwatts (typically for client products) or as curr1_crit in milliamperes (typically for server). v2: Add curr1_crit functionality (Ashutosh) v3: - Use

Re: [Intel-gfx] [PATCH 4/7] drm/i915/hwmon: Show device level energy usage

2022-08-12 Thread Guenter Roeck
On 8/12/22 10:37, Badal Nilawar wrote: From: Dale B Stimson Use i915 HWMON to display device level energy input. v2: - Updated the date and kernel version in feature description Signed-off-by: Dale B Stimson Signed-off-by: Ashutosh Dixit Signed-off-by: Riana Tauro Signed-off-by: Badal N

Re: [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2022-08-12 Thread Guenter Roeck
On 8/12/22 10:37, Badal Nilawar wrote: From: Dale B Stimson Use i915 HWMON to display/modify dGfx power PL1 limit and TDP setting. v2: - Fix review comments (Ashutosh) - Do not restore power1_max upon module unload/load sequence because on production systems modules are always loade

Re: [Intel-gfx] [PATCH 2/7] drm/i915/hwmon: Add HWMON current voltage support

2022-08-12 Thread Guenter Roeck
On 8/12/22 10:37, Badal Nilawar wrote: From: Riana Tauro Use i915 HWMON subsystem to display current input voltage. v2: - Updated date and kernel version in feature description - Fixed review comments (Ashutosh) v3: Use macro HWMON_CHANNEL_INFO to define hwmon channel (Guenter) v4: -

Re: [Intel-gfx] [PATCH 1/7] drm/i915/hwmon: Add HWMON infrastructure

2022-08-12 Thread Guenter Roeck
On 8/12/22 10:37, Badal Nilawar wrote: From: Dale B Stimson The i915 HWMON module will be used to expose voltage, power and energy values for dGfx. Here we set up i915 hwmon infrastructure including i915 hwmon registration, basic data structures and functions. v2: - Create HWMON infra patch

[Intel-gfx] [PATCH 5/7] drm/i915/hwmon: Expose card reactive critical power

2022-08-12 Thread Badal Nilawar
From: Ashutosh Dixit Expose the card reactive critical (I1) power. I1 is exposed as power1_crit in microwatts (typically for client products) or as curr1_crit in milliamperes (typically for server). v2: Add curr1_crit functionality (Ashutosh) v3: - Use HWMON_CHANNEL_INFO to define power1_crit,

[Intel-gfx] [PATCH 7/7] drm/i915/hwmon: Extend power/energy for XEHPSDV

2022-08-12 Thread Badal Nilawar
From: Dale B Stimson Extend hwmon power/energy for XEHPSDV especially per gt level energy usage. v2: Update to latest HWMON spec (Ashutosh) Signed-off-by: Ashutosh Dixit Signed-off-by: Dale B Stimson Signed-off-by: Badal Nilawar --- .../ABI/testing/sysfs-driver-intel-i915-hwmon | 7 +- dr

[Intel-gfx] [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval

2022-08-12 Thread Badal Nilawar
From: Ashutosh Dixit Expose power1_max_interval, that is the tau corresponding to PL1. Some bit manipulation is needed because of the format of PKG_PWR_LIM_1_TIME in GT0_PACKAGE_RAPL_LIMIT register (1.x * power(2,y)). v2: Update date and kernel version in Documentation (Badal) Signed-off-by: As

[Intel-gfx] [PATCH 4/7] drm/i915/hwmon: Show device level energy usage

2022-08-12 Thread Badal Nilawar
From: Dale B Stimson Use i915 HWMON to display device level energy input. v2: - Updated the date and kernel version in feature description Signed-off-by: Dale B Stimson Signed-off-by: Ashutosh Dixit Signed-off-by: Riana Tauro Signed-off-by: Badal Nilawar --- .../ABI/testing/sysfs-driver-

[Intel-gfx] [PATCH 1/7] drm/i915/hwmon: Add HWMON infrastructure

2022-08-12 Thread Badal Nilawar
From: Dale B Stimson The i915 HWMON module will be used to expose voltage, power and energy values for dGfx. Here we set up i915 hwmon infrastructure including i915 hwmon registration, basic data structures and functions. v2: - Create HWMON infra patch (Ashutosh) - Fixed review comments (Jan

[Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2022-08-12 Thread Badal Nilawar
From: Dale B Stimson Use i915 HWMON to display/modify dGfx power PL1 limit and TDP setting. v2: - Fix review comments (Ashutosh) - Do not restore power1_max upon module unload/load sequence because on production systems modules are always loaded and not unloaded/reloaded (Ashutosh)

[Intel-gfx] [PATCH 2/7] drm/i915/hwmon: Add HWMON current voltage support

2022-08-12 Thread Badal Nilawar
From: Riana Tauro Use i915 HWMON subsystem to display current input voltage. v2: - Updated date and kernel version in feature description - Fixed review comments (Ashutosh) v3: Use macro HWMON_CHANNEL_INFO to define hwmon channel (Guenter) v4: - Fixed review comments (Ashutosh) - Use hwm

[Intel-gfx] [PATCH 0/7] drm/i915: Add HWMON support

2022-08-12 Thread Badal Nilawar
This series adds the HWMON support for DGFX v2: - Reorganized series. Created first patch as infrastructure patch followed by feature patches. (Ashutosh) - Fixed review comments (Jani) - Fixed review comments (Ashutosh) v3: - Fixed review comments from Guenter - Exposed energy infer

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v5,1/2] drm/i915/edid: convert DP, HDMI and LVDS to drm_edid (rev2)

2022-08-12 Thread Patchwork
== Series Details == Series: series starting with [v5,1/2] drm/i915/edid: convert DP, HDMI and LVDS to drm_edid (rev2) URL : https://patchwork.freedesktop.org/series/107056/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11986_full -> Patchwork_107056v2_full ==

Re: [Intel-gfx] [PATCH] drm/i915/guc: clear stalled request after a reset

2022-08-12 Thread Ceraolo Spurio, Daniele
On 8/12/2022 12:29 AM, Tvrtko Ursulin wrote: On 11/08/2022 22:08, Daniele Ceraolo Spurio wrote: If the GuC CTs are full and we need to stall the request submission while waiting for space, we save the stalled request and where the stall occurred; when the CTs have space again we pick up the

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v6,1/6] drm/ttm: Add new callbacks to ttm res mgr

2022-08-12 Thread Patchwork
== Series Details == Series: series starting with [v6,1/6] drm/ttm: Add new callbacks to ttm res mgr URL : https://patchwork.freedesktop.org/series/107213/ State : success == Summary == CI Bug Log - changes from CI_DRM_11986 -> Patchwork_107213v1 ===

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v6,1/6] drm/ttm: Add new callbacks to ttm res mgr

2022-08-12 Thread Patchwork
== Series Details == Series: series starting with [v6,1/6] drm/ttm: Add new callbacks to ttm res mgr URL : https://patchwork.freedesktop.org/series/107213/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Fix warning callstack for imbalance wakeref

2022-08-12 Thread Patchwork
== Series Details == Series: drm/i915/display: Fix warning callstack for imbalance wakeref URL : https://patchwork.freedesktop.org/series/107211/ State : success == Summary == CI Bug Log - changes from CI_DRM_11986 -> Patchwork_107211v1 Sum

[Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref

2022-08-12 Thread Mitul Golani
While executing i915_selftest, wakeref imbalance warning is seen with i915_selftest failure. When device is already suspended, wakeref is acquired by disable_rpm_wakeref_asserts and rpm ownership is transferred back to core. During this case wakeref_count will not be zero. Once driver is unregiste

Re: [Intel-gfx] [Linaro-mm-sig] [PATCH v2 3/5] dma-buf: Move all dma-bufs to dynamic locking specification

2022-08-12 Thread Christian König
Am 10.08.22 um 20:53 schrieb Dmitry Osipenko: On 8/10/22 21:25, Christian König wrote: Am 10.08.22 um 19:49 schrieb Dmitry Osipenko: On 8/10/22 14:30, Christian König wrote: Am 25.07.22 um 17:18 schrieb Dmitry Osipenko: This patch moves the non-dynamic dma-buf users over to the dynamic loc

[Intel-gfx] [PATCH i-g-t v2 2/3] tests/gem_exec_fence: Exclude 0 from use in store batches

2022-08-12 Thread Janusz Krzysztofik
When i = 0, condition out[i] == i will be true even if a batch supposed to store i in out[i] fails. Don't use i = 0 in batches that store values in out[i]. v2: still check for out[0] == 0 (Chris) Signed-off-by: Janusz Krzysztofik Cc: Chris Wilson Cc: Mauro Carvalho Chehab --- tests/i915/gem_

[Intel-gfx] [PATCH i-g-t 1/3] tests/gem_exec_fence: Fix wrong engine checked for store_dword capability

2022-08-12 Thread Janusz Krzysztofik
Commit ed7c8cfb67e3 ("tests/i915/gem_exec_fence: Add __for_each_physical_engine to utilize all engines."), while replacing depraciated for_each_physical_engine(e, fd) loop with __for_each_physical_engine(fd, e2) and gem_can_store_dword() inside that loop with gem_class_can_store_dword(), didn't swi

[Intel-gfx] [PATCH i-g-t v3 3/3] tests/gem_exec_fence: Restore pre-hang checks in *await-hang scenarios

2022-08-12 Thread Janusz Krzysztofik
Commit c8f6aaf32d83 "tests/gem_exec_fence: Check stored values only for valid workloads" resolved an issue, observed in *await-hang scenarios, where a fence exposed by an invalid spin batch was signaled asynchronously to pending checks for depended test batches still waiting for that fence. Those c

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v5,1/2] drm/i915/edid: convert DP, HDMI and LVDS to drm_edid (rev2)

2022-08-12 Thread Patchwork
== Series Details == Series: series starting with [v5,1/2] drm/i915/edid: convert DP, HDMI and LVDS to drm_edid (rev2) URL : https://patchwork.freedesktop.org/series/107056/ State : success == Summary == CI Bug Log - changes from CI_DRM_11986 -> Patchwork_107056v2

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v5,1/2] drm/i915/edid: convert DP, HDMI and LVDS to drm_edid (rev2)

2022-08-12 Thread Patchwork
== Series Details == Series: series starting with [v5,1/2] drm/i915/edid: convert DP, HDMI and LVDS to drm_edid (rev2) URL : https://patchwork.freedesktop.org/series/107056/ State : warning == Summary == Error: dim checkpatch failed b6dceb3a09ca drm/i915/edid: convert DP, HDMI and LVDS to drm

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: clear stalled request after a reset

2022-08-12 Thread Patchwork
== Series Details == Series: drm/i915/guc: clear stalled request after a reset URL : https://patchwork.freedesktop.org/series/107181/ State : success == Summary == CI Bug Log - changes from CI_DRM_11985_full -> Patchwork_107181v1_full Summa

Re: [Intel-gfx] [PATCH] drm/i915/guc: clear stalled request after a reset

2022-08-12 Thread Tvrtko Ursulin
On 11/08/2022 22:08, Daniele Ceraolo Spurio wrote: If the GuC CTs are full and we need to stall the request submission while waiting for space, we save the stalled request and where the stall occurred; when the CTs have space again we pick up the request submission from where we left off. How

Re: [Intel-gfx] [PATCH] drm/i915/tc: Fix PHY ownership programming in HDMI legacy mode

2022-08-12 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Tuesday, July 26, 2022 4:43 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH] drm/i915/tc: Fix PHY ownership programming in > HDMI legacy mode > > Make sure the TypeC PHY ownership flag is not ge

Re: [Intel-gfx] [PATCH v3 2/3] drm/amdgpu_dm: Rely on split out luminance calculation function

2022-08-12 Thread Jani Nikula
On Thu, 11 Aug 2022, "Deucher, Alexander" wrote: > [Public] > >> -Original Message- >> From: amd-gfx On Behalf Of Jani >> Nikula >> Sent: Thursday, August 4, 2022 5:55 AM >> To: Jouni Högander ; dri- >> de...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; amd- >> g...@lists.freed

Re: [Intel-gfx] [PATCH 12/39] drm/i915: move and split audio under display.audio and display.funcs

2022-08-12 Thread Jani Nikula
On Fri, 12 Aug 2022, "Murthy, Arun R" wrote: >> -Original Message- >> From: Intel-gfx On Behalf Of Jani >> Nikula >> Sent: Thursday, August 11, 2022 8:37 PM >> To: intel-gfx@lists.freedesktop.org >> Cc: Nikula, Jani ; De Marchi, Lucas >> >> Subject: [Intel-gfx] [PATCH 12/39] drm/i915: mo

Re: [Intel-gfx] [PATCH 11/39] drm/i915: move dmc to display.dmc

2022-08-12 Thread Jani Nikula
On Fri, 12 Aug 2022, "Murthy, Arun R" wrote: >> -Original Message- >> From: Intel-gfx On Behalf Of Jani >> Nikula >> Sent: Thursday, August 11, 2022 8:37 PM >> To: intel-gfx@lists.freedesktop.org >> Cc: Nikula, Jani ; De Marchi, Lucas >> >> Subject: [Intel-gfx] [PATCH 11/39] drm/i915: mo