Re: [Intel-gfx] [PATCH v6 4/4] drm/i915/fbdev: do not create fbdev if HPD is suspended

> -Original Message- > From: Hajda, Andrzej > Sent: Friday, July 22, 2022 6:22 PM > To: Jani Nikula ; Ville Syrjälä > ; Murthy, Arun R > Cc: Hajda, Andrzej ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Tvrtko Ursulin ; Daniel Vetter > ; intel-gfx@lists.freedesktop.org; dri- > de...@lists.freede

Re: [Intel-gfx] [RFC 02/10] drm/i915/vm_bind: Bind and unbind mappings

On Mon, Jul 18, 2022 at 11:55:41AM +0100, Tvrtko Ursulin wrote: On 01/07/2022 23:50, Niranjana Vishwanathapura wrote: Bind and unbind the mappings upon VM_BIND and VM_UNBIND calls. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Prathap Kumar Valsan --- drivers/gpu/drm/i915/Makefile

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Cleanup intel_phy_is_combo() (rev3)

== Series Details == Series: drm/i915/display: Cleanup intel_phy_is_combo() (rev3) URL : https://patchwork.freedesktop.org/series/106450/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11935_full -> Patchwork_106450v3_full S

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Cleanup intel_phy_is_combo() (rev3)

== Series Details == Series: drm/i915/display: Cleanup intel_phy_is_combo() (rev3) URL : https://patchwork.freedesktop.org/series/106450/ State : success == Summary == CI Bug Log - changes from CI_DRM_11935 -> Patchwork_106450v3 Summary ---

Re: [Intel-gfx] [PATCH v3] drm/i915/dg2: Add performance workaround 18019455067

I think you may have missed Lucas' reply to your v3: https://lists.freedesktop.org/archives/intel-gfx/2022-June/300712.html Also, here's the reply to v2 that he's referring to: https://lists.freedesktop.org/archives/intel-gfx/2022-June/300646.html I.e., he wants this to be called from a new 'tu

[Intel-gfx] [PATCH] drm/i915/display: Cleanup intel_phy_is_combo()

Cleanup the intel_phy_is_combo to accommodate for cases where combo phy is not available. v2: retain comment that explains DG2 returning false from intel_phy_is_combo() (Arun) Cc: Arun R Murthy Cc: Matt Roper Signed-off-by: Anusha Srivatsa Reviewed-by: Matt Roper Reviewed-by: Arun R Murthy -

Re: [Intel-gfx] [PATCH v4 00/10] cover-letter: Update vfio_pin/unpin_pages API

On Fri, 22 Jul 2022 19:02:46 -0700 Nicolin Chen wrote: > This is a preparatory series for IOMMUFD v2 patches. It prepares for > replacing vfio_iommu_type1 implementations of vfio_pin/unpin_pages() > with IOMMUFD version. > > There's a gap between these two versions: the vfio_iommu_type1 version

Re: [Intel-gfx] [PATCH] drm/i915/display: Cleanup intel_phy_is_combo()

On Mon, Jul 25, 2022 at 09:45:57AM -0700, Srivatsa, Anusha wrote: > > > > -Original Message- > > From: Roper, Matthew D > > Sent: Thursday, July 21, 2022 1:50 PM > > To: Srivatsa, Anusha > > Cc: intel-gfx@lists.freedesktop.org; Murthy, Arun R > > > > Subject: Re: [PATCH] drm/i915/displ

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Sanitycheck PCI BARs

== Series Details == Series: Sanitycheck PCI BARs URL : https://patchwork.freedesktop.org/series/106686/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/compile.h LD [M

[Intel-gfx] [PATCH 2/2] drm/i915: Sanitycheck PCI BARs

From: Piotr Piórkowski For proper operation of i915 we need usable PCI GTTMMADDR BAR 0 (1 for GEN2). In most cases we also need usable PCI GFXMEM BAR 2. Let's add functions to check if BARs are set, and that it have a size greater than 0. In case GTTMMADDR BAR, let's validate at the beginning of

[Intel-gfx] [PATCH 1/2] drm/i915: Use of BARs names instead of numbers

From: Piotr Piórkowski At the moment, when we refer to some PCI BAR we use the number of this BAR in the code. The meaning of BARs between different platforms may be different. Therefore, in order to organize the code, let's start using defined names instead of numbers. Signed-off-by: Piotr Piór

[Intel-gfx] [PATCH 0/2] Sanitycheck PCI BARs

From: Piotr Piórkowski When initializing the i915, we want to be sure that the PCI BARs have been properly initialized. As part of this series, I have prepared two patches, one that introduces BARs names to use in code instead of numbers, and another that adds function to validate BARs before use

Re: [Intel-gfx] [PATCH] drm/i915: Pass drm_i915_private struct instead of gt for gen11_gu_misc_irq_handler/ack()

@Ursulin, Tvrtko Is this wat you had in mind? Anusha > -Original Message- > From: Srivatsa, Anusha > Sent: Thursday, July 21, 2022 3:51 PM > To: intel-gfx@lists.freedesktop.org > Cc: Srivatsa, Anusha ; Ursulin, Tvrtko > ; Roper, Matthew D > > Subject: [PATCH] drm/i915: Pass drm_i915_pri

Re: [Intel-gfx] [PATCH] drm/i915/guc: Check for ct enabled while waiting for response

On Fri, 15 Jul 2022 14:13:13 -0700, Zhanjun Dong wrote: > > -static int wait_for_ct_request_update(struct ct_request *req, u32 *status) > +static int wait_for_ct_request_update(struct intel_guc_ct *ct, struct > ct_request *req, u32 *status) > { > int err; > + bool ct_enabled; > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: stop using swiotlb (rev4)

== Series Details == Series: drm/i915: stop using swiotlb (rev4) URL : https://patchwork.freedesktop.org/series/106589/ State : success == Summary == CI Bug Log - changes from CI_DRM_11935_full -> Patchwork_106589v4_full Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/display: Cleanup intel_phy_is_combo()

> -Original Message- > From: Roper, Matthew D > Sent: Thursday, July 21, 2022 1:50 PM > To: Srivatsa, Anusha > Cc: intel-gfx@lists.freedesktop.org; Murthy, Arun R > > Subject: Re: [PATCH] drm/i915/display: Cleanup intel_phy_is_combo() > > On Thu, Jul 21, 2022 at 01:17:54PM -0700, Anu

Re: [Intel-gfx] [CI v4 12/13] drm/i915/ttm: disallow CPU fallback mode for ccs pages

On 25/07/2022 16:09, Matthew Auld wrote: Hi, On 25/07/2022 15:55, Tvrtko Ursulin wrote: Hi Matt, On 29/06/2022 18:43, Matthew Auld wrote: Falling back to memcpy/memset shouldn't be allowed if we know we have CCS state to manage using the blitter. Otherwise we are potentially leaving the au

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: stop using swiotlb (rev4)

== Series Details == Series: drm/i915: stop using swiotlb (rev4) URL : https://patchwork.freedesktop.org/series/106589/ State : success == Summary == CI Bug Log - changes from CI_DRM_11935 -> Patchwork_106589v4 Summary --- **SUCCESS*

Re: [Intel-gfx] [CI v4 12/13] drm/i915/ttm: disallow CPU fallback mode for ccs pages

Hi, On 25/07/2022 15:55, Tvrtko Ursulin wrote: Hi Matt, On 29/06/2022 18:43, Matthew Auld wrote: Falling back to memcpy/memset shouldn't be allowed if we know we have CCS state to manage using the blitter. Otherwise we are potentially leaving the aux CCS state in an unknown state, which smell

Re: [Intel-gfx] [CI v4 12/13] drm/i915/ttm: disallow CPU fallback mode for ccs pages

Hi Matt, On 29/06/2022 18:43, Matthew Auld wrote: Falling back to memcpy/memset shouldn't be allowed if we know we have CCS state to manage using the blitter. Otherwise we are potentially leaving the aux CCS state in an unknown state, which smells like an info leak. Fixes: 48760ffe923a ("drm/

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: stop using swiotlb (rev4)

== Series Details == Series: drm/i915: stop using swiotlb (rev4) URL : https://patchwork.freedesktop.org/series/106589/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: stop using swiotlb (rev4)

== Series Details == Series: drm/i915: stop using swiotlb (rev4) URL : https://patchwork.freedesktop.org/series/106589/ State : warning == Summary == Error: dim checkpatch failed e8b51ebb32db drm/i915: stop using swiotlb -:147: WARNING:LINE_SPACING: Missing a blank line after declarations #147

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: stop using swiotlb (rev3)

On 25/07/2022 15:13, Robert Beckett wrote: On 25/07/2022 09:23, Tvrtko Ursulin wrote: On 22/07/2022 20:21, Robert Beckett wrote: On 22/07/2022 19:05, Patchwork wrote: *Patch Details* *Series:*    drm/i915: stop using swiotlb (rev3) *URL:*    https://patchwork.freedesktop.org/series/106589/

[Intel-gfx] [PATCH v4] drm/i915: stop using swiotlb

Calling swiotlb functions directly is nowadays considered harmful. See https://lore.kernel.org/intel-gfx/20220711082614.ga29...@lst.de/ Replace swiotlb_max_segment() calls with dma_max_mapping_size(). In i915_gem_object_get_pages_internal() no longer consider max_segment only if CONFIG_SWIOTLB is

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: stop using swiotlb (rev3)

On 25/07/2022 09:23, Tvrtko Ursulin wrote: On 22/07/2022 20:21, Robert Beckett wrote: On 22/07/2022 19:05, Patchwork wrote: *Patch Details* *Series:*    drm/i915: stop using swiotlb (rev3) *URL:*    https://patchwork.freedesktop.org/series/106589/

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/6] drm/ttm: Add new callbacks to ttm res mgr

== Series Details == Series: series starting with [v2,1/6] drm/ttm: Add new callbacks to ttm res mgr URL : https://patchwork.freedesktop.org/series/106662/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11935 -> Patchwork_106662v1 ===

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/6] drm/ttm: Add new callbacks to ttm res mgr

== Series Details == Series: series starting with [v2,1/6] drm/ttm: Add new callbacks to ttm res mgr URL : https://patchwork.freedesktop.org/series/106662/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.IGT: failure for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation (rev10)

== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation (rev10) URL : https://patchwork.freedesktop.org/series/104704/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11935_full -> Patchw

Re: [Intel-gfx] [PATCH v5 7/7] drm/i915: Remove truncation warning for large objects

On 25.07.2022 11:25, Gwan-gyeong Mun wrote: From: Chris Wilson Having addressed the issues surrounding incorrect types for local variables and potential integer truncation in using the scatterlist API, we have closed all the loop holes we had previously identified with dangerously large object

Re: [Intel-gfx] [PATCH v5 6/7] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

On 25.07.2022 11:25, Gwan-gyeong Mun wrote: The ttm_bo_init_reserved() functions returns -ENOSPC if the size is too big to add vma. The direct function that returns -ENOSPC is drm_mm_insert_node_in_range(). To handle the same error as other code returning -E2BIG when the size is too large, it co

Re: [Intel-gfx] [PATCH v5 5/7] drm/i915: Check if the size is too big while creating shmem file

On 25.07.2022 11:25, Gwan-gyeong Mun wrote: The __shmem_file_setup() function returns -EINVAL if size is greater than MAX_LFS_FILESIZE. To handle the same error as other code that returns -E2BIG when the size is too large, it add a code that returns -E2BIG when the size is larger than the size th

Re: [Intel-gfx] [PATCH v5 4/7] drm/i915: Check for integer truncation on the configuration of ttm place

On 25.07.2022 11:25, Gwan-gyeong Mun wrote: There is an impedance mismatch between the first/last valid page frame number of ttm place in unsigned and our memory/page accounting in unsigned long. As the object size is under the control of userspace, we have to be prudent and catch the conversion

Re: [Intel-gfx] [PATCH v5 3/7] drm/i915: Check for integer truncation on scatterlist creation

On 25.07.2022 11:25, Gwan-gyeong Mun wrote: From: Chris Wilson There is an impedance mismatch between the scatterlist API using unsigned int and our memory/page accounting in unsigned long. That is we may try to create a scatterlist for a large object that overflows returning a small table into

Re: [Intel-gfx] [PATCH v5 2/7] drm/i915/gem: Typecheck page lookups

On 25.07.2022 11:25, Gwan-gyeong Mun wrote: From: Chris Wilson We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead of a more suitable long. Be pedantic and add integer typechecking to the loo

Re: [Intel-gfx] [PATCH v5 1/7] drm: Move and add a few utility macros into drm util header

On 25.07.2022 11:25, Gwan-gyeong Mun wrote: It moves overflows_type utility macro into drm util header from i915_utils header. The overflows_type can be used to catch the truncation between data types. And it adds safe_conversion() macro which performs a type conversion (cast) of an source value

Re: [Intel-gfx] [PATCH 10/12] drm/i915/guc: Support larger contexts on newer hardware

On 22/07/2022 20:32, John Harrison wrote: On 7/19/2022 02:56, Tvrtko Ursulin wrote: On 19/07/2022 01:13, John Harrison wrote: On 7/18/2022 05:35, Tvrtko Ursulin wrote: On 13/07/2022 00:31, john.c.harri...@intel.com wrote: From: Matthew Brost The GuC needs a copy of a golden context for i

Re: [Intel-gfx] [PATCH v4 00/10] cover-letter: Update vfio_pin/unpin_pages API

> -Original Message- > From: intel-gvt-dev On > Behalf Of Nicolin Chen > > This is a preparatory series for IOMMUFD v2 patches. It prepares for > replacing vfio_iommu_type1 implementations of vfio_pin/unpin_pages() > with IOMMUFD version. > > There's a gap between these two versions: the

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation (rev10)

== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation (rev10) URL : https://patchwork.freedesktop.org/series/104704/ State : success == Summary == CI Bug Log - changes from CI_DRM_11935 -> Patchwork_1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation (rev10)

== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation (rev10) URL : https://patchwork.freedesktop.org/series/104704/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast

[Intel-gfx] [PATCH v5 5/7] drm/i915: Check if the size is too big while creating shmem file

The __shmem_file_setup() function returns -EINVAL if size is greater than MAX_LFS_FILESIZE. To handle the same error as other code that returns -E2BIG when the size is too large, it add a code that returns -E2BIG when the size is larger than the size that can be handled. v4: If BITS_PER_LONG is 32

[Intel-gfx] [PATCH v5 4/7] drm/i915: Check for integer truncation on the configuration of ttm place

There is an impedance mismatch between the first/last valid page frame number of ttm place in unsigned and our memory/page accounting in unsigned long. As the object size is under the control of userspace, we have to be prudent and catch the conversion errors. To catch the implicit truncation as we

[Intel-gfx] [PATCH v5 3/7] drm/i915: Check for integer truncation on scatterlist creation

From: Chris Wilson There is an impedance mismatch between the scatterlist API using unsigned int and our memory/page accounting in unsigned long. That is we may try to create a scatterlist for a large object that overflows returning a small table into which we try to fit very many pages. As the o

[Intel-gfx] [PATCH v5 7/7] drm/i915: Remove truncation warning for large objects

From: Chris Wilson Having addressed the issues surrounding incorrect types for local variables and potential integer truncation in using the scatterlist API, we have closed all the loop holes we had previously identified with dangerously large object creation. As such, we can eliminate the warnin

[Intel-gfx] [PATCH v5 2/7] drm/i915/gem: Typecheck page lookups

From: Chris Wilson We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead of a more suitable long. Be pedantic and add integer typechecking to the lookup so that we can be sure that we are safe. A

[Intel-gfx] [PATCH v5 6/7] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

The ttm_bo_init_reserved() functions returns -ENOSPC if the size is too big to add vma. The direct function that returns -ENOSPC is drm_mm_insert_node_in_range(). To handle the same error as other code returning -E2BIG when the size is too large, it converts return value to -E2BIG. Signed-off-by:

[Intel-gfx] [PATCH v5 1/7] drm: Move and add a few utility macros into drm util header

It moves overflows_type utility macro into drm util header from i915_utils header. The overflows_type can be used to catch the truncation between data types. And it adds safe_conversion() macro which performs a type conversion (cast) of an source value into a new variable, checking that the destina

[Intel-gfx] [PATCH v5 0/7] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

This patch series fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation, etc. We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead o

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: stop using swiotlb (rev3)

On 22/07/2022 20:21, Robert Beckett wrote: On 22/07/2022 19:05, Patchwork wrote: *Patch Details* *Series:*    drm/i915: stop using swiotlb (rev3) *URL:*    https://patchwork.freedesktop.org/series/106589/ *State:*    failure *Details:* http