Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

Hi Ashutosh, On Fri, Apr 29, 2022 at 12:56:24PM -0700, Ashutosh Dixit wrote: > Each gt contains an independent instance of pcode. Extend pcode functions > to interface with pcode on different gt's. To avoid creating dependency of > display functionality on intel_gt, pcode function interfaces are e

Re: [Intel-gfx] [PATCH v2 07/25] drm/edid: convert drm_edid_connector_update() to drm_edid fully

On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 95 ++ 1 file changed, 46 insertions(+), 49 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/g

Re: [Intel-gfx] [PATCH v2 06/25] drm/edid: propagate drm_edid to drm_edid_to_eld()

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/driv

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/edid: introduce struct drm_edid (rev3)

== Series Details == Series: drm/edid: introduce struct drm_edid (rev3) URL : https://patchwork.freedesktop.org/series/103665/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11626_full -> Patchwork_103665v3_full Summary

Re: [Intel-gfx] [PATCH v2 03/25] drm/edid: add struct drm_edid container

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: Introduce new opaque type struct drm_edid to encapsulate the EDID data and the size allocated for it. The contents will be private to drm_edid.c. There are a number of reasons for adding a container aro

Re: [Intel-gfx] [PATCH 16/16] drm/i915: Drop display.has_fpga_db from device info

Quoting Souza, Jose (2022-05-09 17:19:28) > On Mon, 2022-05-09 at 15:38 +0300, Joonas Lahtinen wrote: > > Quoting José Roberto de Souza (2022-05-07 16:28:50) > > > No need to have this parameter in intel_device_info struct > > > as this feature is supported by Broadwell, Haswell all platforms with

Re: [Intel-gfx] [PATCH v2 04/25] drm/edid: start propagating drm_edid to lower levels

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. This is a clunky start, but a start nonetheless. We'll eventually convert all of the EDID parsing to struct drm_edid. Initially, we'll just create the struct

Re: [Intel-gfx] [PATCH v2 05/25] drm/edid: keep propagating drm_edid to display info

On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Use drm_edid_legacy_init() Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 48 +++--- 1 file changed, 29 insertions(+), 19 deletions(-) diff --git a/driver

Re: [Intel-gfx] [PATCH 03/25] drm/edid: add struct drm_edid container

LGTM. Reviewed-by: Ankit Nautiyal On 5/6/2022 3:40 PM, Jani Nikula wrote: Introduce new opaque type struct drm_edid to encapsulate the EDID data and the size allocated for it. The contents will be private to drm_edid.c. There are a number of reasons for adding a container around struct edid:

Re: [Intel-gfx] [PATCH 05/25] drm/edid: keep propagating drm_edid to display info

On 5/6/2022 3:46 PM, Jani Nikula wrote: On Fri, 06 May 2022, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. I seem to have copy-pasted a TAB in some of the commit messages, in a way that does not show up in git log. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edi

Re: [Intel-gfx] [PATCH v2 07/12] drm/i915/gvt: Use intel_engine_mask_t for ring mask

On Thu, May 05, 2022 at 02:38:07PM -0700, Matt Roper wrote: When i915 adds additional PVC blitter instances (in an upcoming patch), the definition of VECS0 will change from bit(10) to bit(18), causing GVT's R_ALL mask to overflow the u16 storage that's currently used. Let's replace the u16 with a

Re: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs

Hi Ashutosh, On Fri, Apr 29, 2022 at 12:56:27PM -0700, Ashutosh Dixit wrote: > All kmalloc'd kobjects need a kobject_put() to free memory. For example in > previous code, kobj_gt_release() never gets called. The requirement of > kobject_put() now results in a slightly different code organization.

Re: [Intel-gfx] [PATCH] drm/i915/gt: Fix memory leaks in per-gt sysfs

Hi Ashutosh, On Wed, Apr 27, 2022 at 01:38:33PM -0700, Ashutosh Dixit wrote: > All kmalloc'd kobjects need a kobject_put() to free memory. For example in > previous code, kobj_gt_release() never gets called. The requirement of > kobject_put() now results in a slightly different code organization.

[Intel-gfx] ✓ Fi.CI.IGT: success for Prune unsupported modes as per HDMI2.1 spec

== Series Details == Series: Prune unsupported modes as per HDMI2.1 spec URL : https://patchwork.freedesktop.org/series/103741/ State : success == Summary == CI Bug Log - changes from CI_DRM_11626_full -> Patchwork_103741v1_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fbdev: disable HPD before framebuffer unregistration (rev3)

== Series Details == Series: drm/i915/fbdev: disable HPD before framebuffer unregistration (rev3) URL : https://patchwork.freedesktop.org/series/103738/ State : success == Summary == CI Bug Log - changes from CI_DRM_11626 -> Patchwork_103738v3 ==

Re: [Intel-gfx] [RFC v2 1/2] drm/doc/rfc: VM_BIND feature design document

On Wed, Apr 27, 2022 at 08:41:35AM -0700, Niranjana Vishwanathapura wrote: On Wed, Apr 20, 2022 at 03:45:25PM -0700, Niranjana Vishwanathapura wrote: On Thu, Mar 31, 2022 at 10:28:48AM +0200, Daniel Vetter wrote: Adding a pile of people who've expressed interest in vm_bind for their drivers. A

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fbdev: disable HPD before framebuffer unregistration (rev2)

== Series Details == Series: drm/i915/fbdev: disable HPD before framebuffer unregistration (rev2) URL : https://patchwork.freedesktop.org/series/103738/ State : success == Summary == CI Bug Log - changes from CI_DRM_11626 -> Patchwork_103738v2 ==

[Intel-gfx] ✗ Fi.CI.IGT: failure for Fixes for selective fetch area calculation (rev2)

== Series Details == Series: Fixes for selective fetch area calculation (rev2) URL : https://patchwork.freedesktop.org/series/103659/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11626_full -> Patchwork_103659v2_full Summa

[Intel-gfx] ✓ Fi.CI.BAT: success for Update GuC relay logging debugfs

== Series Details == Series: Update GuC relay logging debugfs URL : https://patchwork.freedesktop.org/series/103767/ State : success == Summary == CI Bug Log - changes from CI_DRM_11626 -> Patchwork_103767v1 Summary --- **WARNING**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Update GuC relay logging debugfs

== Series Details == Series: Update GuC relay logging debugfs URL : https://patchwork.freedesktop.org/series/103767/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [Intel-gfx 6/6] drm/i915/guc: Move guc_log_relay_chan debugfs path to uc

All other GuC Relay Logging debugfs handles including recent additions are under the 'i915/gt/uc/path' so let's also move 'guc_log_relay_chan' to its proper home. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/gt/uc/intel_guc.h| 2 ++ drivers/gpu/drm/i915/gt/uc/intel_guc_log.c|

[Intel-gfx] [Intel-gfx 5/6] drm/i915/guc: Rename GuC log relay debugfs descriptively

GuC log relay debugfs name for the control handle vs the actual relay channel are vague. Fix them so it's obvious from the name. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/gt/uc/intel_guc_log.c| 2 +- .../drm/i915/gt/uc/intel_guc_log_debugfs.c| 22 +-- 2 files c

[Intel-gfx] [Intel-gfx 4/6] drm/i915/guc: Provide debugfs for log relay sub-buf info

In order to provide alignment between IGT intel_guc_logger tool and i915 kernel's guc log relay channels without requiring updating both repositories everytime a sizing change is made, provide that info via debugfs files. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/gt/uc/intel_guc_log.c

[Intel-gfx] [Intel-gfx 0/6] Update GuC relay logging debugfs

This series 1. Fixes a bug introduced in GuC Error Capture that was sharing the memmap of the multi-region GuC logging buffer. 1. Adds support for unaligned wc memcpy during the copying of logs to relay channel. 2. Renames the debugfs file for controlling GuC relay logging

[Intel-gfx] [Intel-gfx 1/6] drm/i915/guc: Fix GuC relay log debugfs failing open

When GuC-Error-Capture was introduced, we created buf_in_use as a way to identify if relay logging had started. It is meant to replace the previous method where a mmap of the GuC log buffer was the indicator but not since GuC Error Capture shares that mapping throughout operation. However, that me

[Intel-gfx] [Intel-gfx 3/6] drm/i915/guc: Add a helper for log buffer size

Add a helper to get GuC log buffer size. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 49 -- 1 file changed, 27 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c

[Intel-gfx] [Intel-gfx 2/6] drm/i915/guc: Add unaligned wc memcpy for copying GuC Log

Add usage of unaligned wc mempy in read_update_log_buffer as newer formats of GuC debug-log-events are no longer guaranteed to be exactly 4-dwords long per event. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions

Re: [Intel-gfx] [PATCH v6 0/4] Let userspace know when snd-hda-intel needs i915

On Mon, May 09, 2022 at 06:23:35PM +0200, Mauro Carvalho Chehab wrote: > Currently, kernel/module annotates module dependencies when > request_symbol is used, but it doesn't cover more complex inter-driver > dependencies that are subsystem and/or driver-specific. > At this pount v5.18-rc7 is out

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Refactor slpc shared data access to use iosys_map (rev2)

== Series Details == Series: drm/i915/guc: Refactor slpc shared data access to use iosys_map (rev2) URL : https://patchwork.freedesktop.org/series/101430/ State : success == Summary == CI Bug Log - changes from CI_DRM_11626 -> Patchwork_101430v2

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Let userspace know when snd-hda-intel needs i915

== Series Details == Series: Let userspace know when snd-hda-intel needs i915 URL : https://patchwork.freedesktop.org/series/103760/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/103760/revisions/1/mbox/ not applied Applying: module: drop prototy

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid: introduce struct drm_edid (rev3)

== Series Details == Series: drm/edid: introduce struct drm_edid (rev3) URL : https://patchwork.freedesktop.org/series/103665/ State : success == Summary == CI Bug Log - changes from CI_DRM_11626 -> Patchwork_103665v3 Summary --- **S

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/edid: introduce struct drm_edid (rev3)

== Series Details == Series: drm/edid: introduce struct drm_edid (rev3) URL : https://patchwork.freedesktop.org/series/103665/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +./drivers/gpu/drm/amd/amdgpu/

[Intel-gfx] ✓ Fi.CI.BAT: success for Prune unsupported modes as per HDMI2.1 spec

== Series Details == Series: Prune unsupported modes as per HDMI2.1 spec URL : https://patchwork.freedesktop.org/series/103741/ State : success == Summary == CI Bug Log - changes from CI_DRM_11626 -> Patchwork_103741v1 Summary --- **

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/fbdev: disable HPD before framebuffer unregistration

== Series Details == Series: drm/i915/fbdev: disable HPD before framebuffer unregistration URL : https://patchwork.freedesktop.org/series/103738/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11626 -> Patchwork_103738v1 Sum

[Intel-gfx] ✓ Fi.CI.BAT: success for Expose max and current bpc via debugfs (rev7)

== Series Details == Series: Expose max and current bpc via debugfs (rev7) URL : https://patchwork.freedesktop.org/series/102502/ State : success == Summary == CI Bug Log - changes from CI_DRM_11626 -> Patchwork_102502v7 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Expose max and current bpc via debugfs (rev7)

== Series Details == Series: Expose max and current bpc via debugfs (rev7) URL : https://patchwork.freedesktop.org/series/102502/ State : warning == Summary == Error: dim checkpatch failed dd718ee48d2d drm/debug: Expose connector's max supported bpc via debugfs -:21: WARNING:BAD_SIGN_OFF: 'Rev

Re: [Intel-gfx] [PATCH v5 1/2] module: update dependencies at try_module_get()

Em Thu, 5 May 2022 23:35:29 +0200 Andi Shyti escreveu: > Hi Mauro, > > [...] > > > +static int ref_module_dependency(struct module *mod, struct module *this) > > +{ > > + int ret; > > + > > + if (!this || !this->name) > > + return -EINVAL; > > + > > + if (mod == this) > > +

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixes for selective fetch area calculation (rev2)

== Series Details == Series: Fixes for selective fetch area calculation (rev2) URL : https://patchwork.freedesktop.org/series/103659/ State : success == Summary == CI Bug Log - changes from CI_DRM_11626 -> Patchwork_103659v2 Summary ---

[Intel-gfx] [PATCH v6 3/4] module: set holders when symbol_get() is used

Some Kernel modules use symbol_get() or symbol_request() in order to bind into other drivers. That's the case, for instance, of media dvb drivers that hook the frontend drivers via I2C using dvb_attach() macro. When such bindings happen, one needs first to unload/unbind the driver that got the sym

[Intel-gfx] [PATCH v6 4/4] ALSA: hda - identify when audio is provided by a video driver

On some devices, the hda driver needs to hook into a video driver, in order to be able to properly access the audio hardware and/or the power management function. That's the case of several snd_hda_intel devices that depends on i915 driver. Ensure that a proper reference between the snd-hda drive

[Intel-gfx] [PATCH v6 2/4] module: update dependencies at try_module_get()

Sometimes, device drivers are bound into each other via try_module_get(), making such references invisible when looking at /proc/modules or lsmod. Add a function to allow setting up module references for such cases, and call it when try_module_get() is used. Reviewed-by: Dan Williams Reviewed-by

[Intel-gfx] [PATCH v6 1/4] module: drop prototype for non-existing __symbol_get_gpl()

There's no such function, and __symbol_get() is already declared as GPL. So, this is likely a left-over. Signed-off-by: Mauro Carvalho Chehab --- See [PATCH v6 0/4] at: https://lore.kernel.org/all/cover.1652113087.git.mche...@kernel.org/ include/linux/module.h | 1 - 1 file changed, 1 deletio

[Intel-gfx] [PATCH v6 0/4] Let userspace know when snd-hda-intel needs i915

Currently, kernel/module annotates module dependencies when request_symbol is used, but it doesn't cover more complex inter-driver dependencies that are subsystem and/or driver-specific. That's because module_try_get() and symbol_get() doesn't try to setup the module owner. In the case of hdmi so

[Intel-gfx] [PATCH 1/1] drm/i915/guc: Convert slpc to iosys_map

From: Siva Mullati Convert slpc shared data to use iosys_map rather than plain pointer and save it in the intel_guc_slpc struct. This will help with in read and update slpc shared data after the slpc init by abstracting the IO vs system memory. Signed-off-by: Siva Mullati --- drivers/gpu/drm/i

[Intel-gfx] [PATCH 0/1] drm/i915/guc: Refactor slpc shared data access to use iosys_map

From: Siva Mullati Ver2: remove accessing drm_cflush for io memory This is continuation to the original patch series to use iosys map APIs to use slpc shared data commands and descriptors. https://patchwork.freedesktop.org/series/99711/ Siva Mullati (1): drm/i915/guc: Convert slpc to iosys_ma

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/display: Implement seamless mode switch

Hello Jose, Thanks much for the patch. I tested it on chrome system and the patch works. Adding my Tested-by. Tested-by: Vidya Srinivas Regards Vidya > -Original Message- > From: Souza, Jose > Sent: Tuesday, May 3, 2022 2:11 AM > To: intel-gfx@lists.freedesktop.org > Cc: Srinivas, Vidy

Re: [Intel-gfx] [PATCH 01/16] drm/i915: Drop has_llc from device info

On Mon, 2022-05-09 at 15:52 +0100, Matthew Auld wrote: > On Mon, 9 May 2022 at 15:05, Souza, Jose wrote: > > > > On Mon, 2022-05-09 at 12:09 +0100, Matthew Auld wrote: > > > On Sat, 7 May 2022 at 14:29, José Roberto de Souza > > > wrote: > > > > > > > > This feature is supported in graphics ve

Re: [Intel-gfx] [PATCH 01/16] drm/i915: Drop has_llc from device info

On Mon, 9 May 2022 at 15:05, Souza, Jose wrote: > > On Mon, 2022-05-09 at 12:09 +0100, Matthew Auld wrote: > > On Sat, 7 May 2022 at 14:29, José Roberto de Souza > > wrote: > > > > > > This feature is supported in graphics version 6 and newer in all > > > integrated GPUs not including VLC and CH

Re: [Intel-gfx] [PATCH CI 5/7] drm/i915: Drop has_ddi from device info

On Mon, 2022-05-09 at 15:27 +0100, Tvrtko Ursulin wrote: > On 09/05/2022 15:01, Souza, Jose wrote: > > On Mon, 2022-05-09 at 14:32 +0100, Tvrtko Ursulin wrote: > > > On 05/05/2022 20:35, José Roberto de Souza wrote: > > > > No need to have this parameter in intel_device_info struct > > > > as all p

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Refactor CT access to use iosys_map (rev5)

== Series Details == Series: drm/i915/guc: Refactor CT access to use iosys_map (rev5) URL : https://patchwork.freedesktop.org/series/101148/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11625_full -> Patchwork_101148v5_full

Re: [Intel-gfx] [PATCH CI 5/7] drm/i915: Drop has_ddi from device info

On 09/05/2022 15:01, Souza, Jose wrote: On Mon, 2022-05-09 at 14:32 +0100, Tvrtko Ursulin wrote: On 05/05/2022 20:35, José Roberto de Souza wrote: No need to have this parameter in intel_device_info struct as all platforms with display version 9 or newer, haswell or broadwell supports it. As

Re: [Intel-gfx] [PATCH CI 5/7] drm/i915: Drop has_ddi from device info

On Mon, 2022-05-09 at 17:05 +0300, Jani Nikula wrote: > On Mon, 09 May 2022, Tvrtko Ursulin wrote: > > On 05/05/2022 20:35, José Roberto de Souza wrote: > > > No need to have this parameter in intel_device_info struct > > > as all platforms with display version 9 or newer, haswell or broadwell > >

Re: [Intel-gfx] [PATCH 16/16] drm/i915: Drop display.has_fpga_db from device info

On Mon, 2022-05-09 at 15:38 +0300, Joonas Lahtinen wrote: > Quoting José Roberto de Souza (2022-05-07 16:28:50) > > No need to have this parameter in intel_device_info struct > > as this feature is supported by Broadwell, Haswell all platforms with > > display version 9 or newer. > > This is oppos

Re: [Intel-gfx] [PATCH 5/5] drm/i915/sseu: Disassociate internal subslice mask representation from uapi

On 07/05/2022 00:34, Matt Roper wrote: On Thu, Apr 28, 2022 at 01:18:42PM +0100, Tvrtko Ursulin wrote: Hi, On 28/04/2022 00:07, Matt Roper wrote: Rather than storing subslice masks internally as u8[] (inside the sseu structure) and u32 (everywhere else), let's move over to using an intel_ss

Re: [Intel-gfx] [PATCH CI 5/7] drm/i915: Drop has_ddi from device info

On Mon, 09 May 2022, Tvrtko Ursulin wrote: > On 05/05/2022 20:35, José Roberto de Souza wrote: >> No need to have this parameter in intel_device_info struct >> as all platforms with display version 9 or newer, haswell or broadwell >> supports it. >> >> As a side effect of the of removal this flag

Re: [Intel-gfx] [PATCH 01/16] drm/i915: Drop has_llc from device info

On Mon, 2022-05-09 at 12:09 +0100, Matthew Auld wrote: > On Sat, 7 May 2022 at 14:29, José Roberto de Souza > wrote: > > > > This feature is supported in graphics version 6 and newer in all > > integrated GPUs not including VLC and CHV, so we can drop this flag > > for a not so complicated macro

Re: [Intel-gfx] [PATCH CI 5/7] drm/i915: Drop has_ddi from device info

On Mon, 2022-05-09 at 14:32 +0100, Tvrtko Ursulin wrote: > On 05/05/2022 20:35, José Roberto de Souza wrote: > > No need to have this parameter in intel_device_info struct > > as all platforms with display version 9 or newer, haswell or broadwell > > supports it. > > > > As a side effect of the of

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Ensure damage clip area is within pipe area

On Mon, 2022-05-09 at 10:24 +0300, Jouni Högander wrote: > Current update area calculation is not handling situation where > e.g. cursor plane is fully or partially outside pipe area. > > Fix this by checking damage area against pipe_src area using > drm_rect_intersect. > > v2: Set x1 and x2 in d

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/psr: Use full update In case of area calculation fails

On Mon, 2022-05-09 at 10:24 +0300, Jouni Högander wrote: > Currently we have some corner cases where area calculation fails. For > these sel fetch area calculation ends up having update area as y1 = 0, > y2 = 4. Instead of these values safer option is full update. > > One of such for example is b

Re: [Intel-gfx] [PATCH CI 5/7] drm/i915: Drop has_ddi from device info

On 05/05/2022 20:35, José Roberto de Souza wrote: No need to have this parameter in intel_device_info struct as all platforms with display version 9 or newer, haswell or broadwell supports it. As a side effect of the of removal this flag, it will not be printed in dmesg during driver load anym

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Enable THP on Icelake and beyond

On 09/05/2022 11:49, Matthew Auld wrote: On 29/04/2022 11:04, Tvrtko Ursulin wrote: From: Tvrtko Ursulin We have a statement from HW designers that the GPU read regression when using 2M pages was fixed from Icelake onwards, which was also confirmed by bencharking Eero did last year: """ Whe

Re: [Intel-gfx] [PATCH 16/16] drm/i915: Drop display.has_fpga_db from device info

Quoting José Roberto de Souza (2022-05-07 16:28:50) > No need to have this parameter in intel_device_info struct > as this feature is supported by Broadwell, Haswell all platforms with > display version 9 or newer. This is opposite of the direction we want to move to. We want to embrace the has_x

[Intel-gfx] [PATCH v2 25/25] drm/edid: convert version_greater() to drm_edid

We'll need to propagate drm_edid everywhere. Also make version_greater() a function for type safety. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/

[Intel-gfx] [PATCH v2 24/25] drm/displayid: convert to drm_edid

We'll need to propagate drm_edid everywhere. v2: Rebase Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_displayid.c | 16 drivers/gpu/drm/drm_edid.c | 17 ++--- include/drm/drm_displayid.h | 6 +++--- include/drm/drm_edid.h | 6 -- 4 files

[Intel-gfx] [PATCH v2 23/25] drm/edid: add drm_edid helper for drm_update_tile_info()

We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index d857d

[Intel-gfx] [PATCH v2 22/25] drm/edid: convert drm_edid_iter_begin() to drm_edid

We'll need to propagate drm_edid everywhere. v2: Rebase Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index bd14010ed1c5..d857d1d74c82

[Intel-gfx] [PATCH v2 21/25] drm/edid: convert cea_db_iter_edid_begin() to drm_edid

We'll need to propagate drm_edid everywhere. v2: Handle NULL drm_edid Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index f072cfba9dd9.

[Intel-gfx] [PATCH v2 20/25] drm/edid: add drm_edid helper for drm_detect_monitor_audio()

We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 37 ++--- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/dr

[Intel-gfx] [PATCH v2 19/25] drm/edid: add drm_edid helper for drm_detect_hdmi_monitor()

We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/dr

[Intel-gfx] [PATCH v2 16/25] drm/edid: convert drm_for_each_detailed_block() to drm_edid

We'll need to propagate drm_edid everywhere. v2: Fix checkpatch warning on superfluous parens Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers

[Intel-gfx] [PATCH v2 18/25] drm/edid: add drm_edid helper for drm_edid_to_speaker_allocation()

We'll need to propagate drm_edid everywhere.' v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/d

[Intel-gfx] [PATCH v2 15/25] drm/edid: convert get_monitor_name() to drm_edid

We'll need to propagate drm_edid everywhere. v2: Drop incorrect NULL name check (Dan Carpenter) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/dr

[Intel-gfx] [PATCH v2 17/25] drm/edid: add drm_edid helper for drm_edid_to_sad()

We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/d

[Intel-gfx] [PATCH v2 14/25] drm/edid: convert mode_in_range() and drm_monitor_supports_rb() to drm_edid

We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index bea8f33c58ad..364949e146a9 100644

[Intel-gfx] [PATCH v2 13/25] drm/edid: convert drm_mode_std() and children to drm_edid

We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 52 -- 1 file changed, 27 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 51d918c66a26..bea8f33c

[Intel-gfx] [PATCH v2 12/25] drm/edid: convert drm_cvt_modes_for_range() to drm_edid

We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 037102a4d0b5..51d918c66a26 100644 --- a/drivers/gp

[Intel-gfx] [PATCH v2 08/25] drm/edid: convert struct detailed_mode_closure to drm_edid

We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index f54699422bca..c2887012add0 100644

[Intel-gfx] [PATCH v2 11/25] drm/edid: convert drm_gtf_modes_for_range() to drm_edid

We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 5d8744a7b62e..037102a4d0b5 100644 --- a/drivers/gpu/

[Intel-gfx] [PATCH v2 10/25] drm/edid: convert drm_dmt_modes_for_range() to drm_edid

We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 8acdb08a8571..5d8744a7b62e 100644 --- a/drivers/gpu/

[Intel-gfx] [PATCH v2 09/25] drm/edid: convert drm_mode_detailed() to drm_edid

We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index c2887012add0..8acdb08a8571 100644 --- a/drivers/gpu/drm

[Intel-gfx] [PATCH v2 07/25] drm/edid: convert drm_edid_connector_update() to drm_edid fully

We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 95 ++ 1 file changed, 46 insertions(+), 49 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index e4fdf742645b..f5469942

[Intel-gfx] [PATCH v2 06/25] drm/edid: propagate drm_edid to drm_edid_to_eld()

We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 96e3f9327044..e4fdf742645b 100644 --- a/

[Intel-gfx] [PATCH v2 05/25] drm/edid: keep propagating drm_edid to display info

We'll need to propagate drm_edid everywhere. v2: Use drm_edid_legacy_init() Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 48 +++--- 1 file changed, 29 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edi

[Intel-gfx] [PATCH v2 04/25] drm/edid: start propagating drm_edid to lower levels

We'll need to propagate drm_edid everywhere. This is a clunky start, but a start nonetheless. We'll eventually convert all of the EDID parsing to struct drm_edid. Initially, we'll just create the struct drm_edid in stack. This will be the compat layer for legacy struct edid code. In the future, we

[Intel-gfx] [PATCH v2 03/25] drm/edid: add struct drm_edid container

Introduce new opaque type struct drm_edid to encapsulate the EDID data and the size allocated for it. The contents will be private to drm_edid.c. There are a number of reasons for adding a container around struct edid: * struct edid is a raw blob pointer to data that usually originates outside

[Intel-gfx] [PATCH v2 02/25] drm/edid: convert drm_for_each_detailed_block() to edid iter

We have an iterator for this, use it. It does include the base block, but its tag is 0 and will be skipped. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c

[Intel-gfx] [PATCH v2 01/25] drm/edid: use else-if in CTA extension parsing

Only one of the conditions can be true. Suggested-by: Ville Syrjälä Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c inde

[Intel-gfx] [PATCH v2 00/25] drm/edid: introduce struct drm_edid

v2 of [1] with some NULL deref bugs and checkpatch/sparse warnings fixed. BR, Jani. [1] https://patchwork.freedesktop.org/series/103665/ Jani Nikula (25): drm/edid: use else-if in CTA extension parsing drm/edid: convert drm_for_each_detailed_block() to edid iter drm/edid: add struct drm_ed

Re: [Intel-gfx] [PATCH 01/16] drm/i915: Drop has_llc from device info

On Sat, 7 May 2022 at 14:29, José Roberto de Souza wrote: > > This feature is supported in graphics version 6 and newer in all > integrated GPUs not including VLC and CHV, so we can drop this flag > for a not so complicated macro check. s/VLC/VLV/ ? There are also some gen9/10 platforms that onl

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Enable THP on Icelake and beyond

On 29/04/2022 11:04, Tvrtko Ursulin wrote: From: Tvrtko Ursulin We have a statement from HW designers that the GPU read regression when using 2M pages was fixed from Icelake onwards, which was also confirmed by bencharking Eero did last year: """ When IOMMU is disabled, enabling THP causes fol

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Refactor CT access to use iosys_map (rev5)

== Series Details == Series: drm/i915/guc: Refactor CT access to use iosys_map (rev5) URL : https://patchwork.freedesktop.org/series/101148/ State : success == Summary == CI Bug Log - changes from CI_DRM_11625 -> Patchwork_101148v5 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/guc: Refactor CT access to use iosys_map (rev5)

== Series Details == Series: drm/i915/guc: Refactor CT access to use iosys_map (rev5) URL : https://patchwork.freedesktop.org/series/101148/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH 2/2] drm/i915/hdmi: Prune unsupported modes as per HDMI2.1 spec

As per Sec 7.8.1 of HDMI2.1 spec, sources that support modes: 4K100, 4K120, 8K50, 8K60 must support these modes in at least one of the below formats: i) uncompressed FRL, 420 format and min of 10 bpc, or ii) compressed FRL, 444 format and min of 10 bpc. Since FRL and DSC are not supported natively

[Intel-gfx] [PATCH 0/2] Prune unsupported modes as per HDMI2.1 spec

Modes like 4K100, 4K120, 8K50, 8K60 need FRL and/or DSC from source. Since FRL and DSC are not currently supported natively by intel platforms (are supported only via DP-HDMI2.1 PCONs), these modes must be pruned as per spec. Currently these modes are not getting pruned as we check the TMDS clock,

[Intel-gfx] [PATCH 1/2] drm/edid: Fix minimum bpc supported with DSC1.2 for HDMI sink

HF-VSDB/SCDB has bits to advertise support for 16, 12 and 10 bpc. If none of the bits are set, the minimum bpc supported with DSC is 8. This patch corrects the min bpc supported to be 8, instead of 0. Fixes: 76ee7b905678 ("drm/edid: Parse DSC1.2 cap fields from HFVSDB block") Cc: Ankit Nautiyal

Re: [Intel-gfx] [5.18 regression] drm/i915 BYT rendering broken due to "Remove short-term pins from execbuf, v6"

On 08/05/2022 15:38, Hans de Goede wrote: Hi All, When running a 5.18-rc4 (and -rc5) kernel on a Chuwi Hi 8, which is a Bay Trail based tablet with 2G RAM and a 1200x1920 DSI panel. I noticed that gnome-shell was misrendering. Many UI elements were missing (they were all black) and at the gdm

Re: [Intel-gfx] [PATCH v5 2/2] ALSA: hda - identify when audio is provided by a video driver

On Sat, 30 Apr 2022 22:04:55 +0200, Mauro Carvalho Chehab wrote: > > On some devices, the hda driver needs to hook into a video driver, > in order to be able to properly access the audio hardware and/or > the power management function. > > That's the case of several snd_hda_intel devices that dep

[Intel-gfx] [PATCH] drm/i915/fbdev: disable HPD before framebuffer unregistration

In case framebuffer setup is deferred it will happen in HPD worker. Then on driver removal we should assure it will not happen after drm_fb_helper_unregister_fbi, otherwise we risk UAF. The patch should fix following GPF: [272.634530] general protection fault, probably for non-canonical address 0

Re: [Intel-gfx] [PATCH 1/2] drm/i915/psr: Use full update In case of area calculation fails

On Fri, 2022-05-06 at 18:40 +, Souza, Jose wrote: > On Fri, 2022-05-06 at 18:28 +, Hogander, Jouni wrote: > > On Fri, 2022-05-06 at 15:29 +, Souza, Jose wrote: > > > On Fri, 2022-05-06 at 08:48 +0300, Jouni Högander wrote: > > > > Currently we have some corner cases where area calculati

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Ensure damage clip area is within pipe area

On Fri, 2022-05-06 at 15:43 +, Souza, Jose wrote: > On Fri, 2022-05-06 at 08:48 +0300, Jouni Högander wrote: > > Current update area calculation is not handling situation where > > e.g. cursor plane is fully or partially outside pipe area. > > > > Fix this by checking damage area against pipe_

  1   2   >