[Intel-gfx] [PATCH 2/2] drm/i915: Ensure damage clip area is within pipe area

Current update area calculation is not handling situation where e.g. cursor plane is fully or partially outside pipe area. Fix this by checking damage area against pipe_src area using drm_rect_intersect. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5440 Cc: José Roberto de Souza Cc:

[Intel-gfx] [PATCH 1/2] drm/i915/psr: Use full update In case of area calculation fails

Currently we have some corner cases where area calculation fails. For these sel fetch are calculation ends up having update area as y1 = 0, y2 = 4. Instead of these values safer option is full update. Cc: José Roberto de Souza Cc: Mika Kahola Tested-by: Mark Pearson Signed-off-by: Jouni Högand

[Intel-gfx] [PATCH 0/2] Fixes for selective fetch area calculation

Currently selective fetch area calculation ends up as bogus area in following cases: 1. Updated plane is partially or fully outside pipe area 2. Big fb with only part of memory area used for plane These end up as y1 = 0, y2 = 4 or y2 being outside pipe area. This patch set addresses these by ensu

[Intel-gfx] [PATCH] drm/i915/guc/rc: Use i915_probe_error instead of drm_error

To avoid false positives in error injection cases. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_rc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_rc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_rc.c index e

[Intel-gfx] ✗ Fi.CI.IGT: failure for Make the rest of the VFIO driver interface use vfio_device (rev5)

== Series Details == Series: Make the rest of the VFIO driver interface use vfio_device (rev5) URL : https://patchwork.freedesktop.org/series/102606/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11613_full -> Patchwork_102606v5_full ===

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Fix build error without CONFIG_PM

== Series Details == Series: drm/i915/gt: Fix build error without CONFIG_PM URL : https://patchwork.freedesktop.org/series/103654/ State : success == Summary == CI Bug Log - changes from CI_DRM_11614 -> Patchwork_103654v1 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for i915: Introduce Ponte Vecchio (rev3)

== Series Details == Series: i915: Introduce Ponte Vecchio (rev3) URL : https://patchwork.freedesktop.org/series/103443/ State : success == Summary == CI Bug Log - changes from CI_DRM_11613_full -> Patchwork_103443v3_full Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for ttm for internal (rev2)

== Series Details == Series: ttm for internal (rev2) URL : https://patchwork.freedesktop.org/series/103492/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11614 -> Patchwork_103492v2 Summary --- **FAILURE** Serious

[Intel-gfx] ✓ Fi.CI.BAT: success for Make the rest of the VFIO driver interface use vfio_device (rev5)

== Series Details == Series: Make the rest of the VFIO driver interface use vfio_device (rev5) URL : https://patchwork.freedesktop.org/series/102606/ State : success == Summary == CI Bug Log - changes from CI_DRM_11613 -> Patchwork_102606v5

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Make the rest of the VFIO driver interface use vfio_device (rev5)

== Series Details == Series: Make the rest of the VFIO driver interface use vfio_device (rev5) URL : https://patchwork.freedesktop.org/series/102606/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +./incl

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Make the rest of the VFIO driver interface use vfio_device (rev5)

== Series Details == Series: Make the rest of the VFIO driver interface use vfio_device (rev5) URL : https://patchwork.freedesktop.org/series/102606/ State : warning == Summary == Error: dim checkpatch failed 843eb2b14576 vfio: Make vfio_(un)register_notifier accept a vfio_device -:229: CHECK:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Eliminate PIPECONF RMWs from .color_commit() (rev3)

== Series Details == Series: drm/i915: Eliminate PIPECONF RMWs from .color_commit() (rev3) URL : https://patchwork.freedesktop.org/series/102666/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11613 -> Patchwork_102666v3 Sum

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Eliminate PIPECONF RMWs from .color_commit() (rev3)

== Series Details == Series: drm/i915: Eliminate PIPECONF RMWs from .color_commit() (rev3) URL : https://patchwork.freedesktop.org/series/102666/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: Introduce Ponte Vecchio (rev3)

== Series Details == Series: i915: Introduce Ponte Vecchio (rev3) URL : https://patchwork.freedesktop.org/series/103443/ State : success == Summary == CI Bug Log - changes from CI_DRM_11613 -> Patchwork_103443v3 Summary --- **SUCCESS

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/7] drm/i915: Drop has_gt_uc from device info

== Series Details == Series: series starting with [CI,1/7] drm/i915: Drop has_gt_uc from device info URL : https://patchwork.freedesktop.org/series/103629/ State : success == Summary == CI Bug Log - changes from CI_DRM_11612_full -> Patchwork_103629v1_full =

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915: Introduce Ponte Vecchio (rev3)

== Series Details == Series: i915: Introduce Ponte Vecchio (rev3) URL : https://patchwork.freedesktop.org/series/103443/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915: Introduce Ponte Vecchio (rev3)

== Series Details == Series: i915: Introduce Ponte Vecchio (rev3) URL : https://patchwork.freedesktop.org/series/103443/ State : warning == Summary == Error: dim checkpatch failed d831d43de27e drm/i915/uncore: Reorganize and document shadow and forcewake tables -:82: CHECK:MACRO_ARG_REUSE: Ma

[Intel-gfx] ✗ Fi.CI.BAT: failure for i915: Introduce Ponte Vecchio (rev2)

== Series Details == Series: i915: Introduce Ponte Vecchio (rev2) URL : https://patchwork.freedesktop.org/series/103443/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11612 -> Patchwork_103443v2 Summary --- **FAILURE

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915: Introduce Ponte Vecchio (rev2)

== Series Details == Series: i915: Introduce Ponte Vecchio (rev2) URL : https://patchwork.freedesktop.org/series/103443/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915: Introduce Ponte Vecchio (rev2)

== Series Details == Series: i915: Introduce Ponte Vecchio (rev2) URL : https://patchwork.freedesktop.org/series/103443/ State : warning == Summary == Error: dim checkpatch failed 3ff8d05befaf drm/i915/uncore: Reorganize and document shadow and forcewake tables -:82: CHECK:MACRO_ARG_REUSE: Ma

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Eliminate PIPECONF RMWs from .color_commit() (rev2)

== Series Details == Series: drm/i915: Eliminate PIPECONF RMWs from .color_commit() (rev2) URL : https://patchwork.freedesktop.org/series/102666/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11612 -> Patchwork_102666v2 Sum

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/fbdev: unregister framebuffer after disabling hpd (rev3)

== Series Details == Series: drm/i915/fbdev: unregister framebuffer after disabling hpd (rev3) URL : https://patchwork.freedesktop.org/series/103621/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11611_full -> Patchwork_103621v3_full ===

[Intel-gfx] [PATCH v2 06/12] drm/i915/pvc: Reduce stack usage in reset selftest with extra blitter engine

From: John Harrison PVC adds extra blitter engines (in the following patch). The reset selftest has a local array on the stack which is sized by the number of engines. The increase pushes the size of this array to the point where it trips the 'stack too large' compile warning. This patch takes th

[Intel-gfx] [PATCH v2 08/12] drm/i915/pvc: Engine definitions for new copy engines

This patch adds the basic definitions needed to support new copy engines. Also updating the cmd_info to accommodate new engines, as the engine id's of legacy engines have been changed. v2: - Add _BCS(n) definition, similar to other engines. (Tvrtko) - Add I915_MAX_BCS definition, similar to oth

[Intel-gfx] [PATCH v2 11/12] drm/i915/pvc: skip all copy engines from aux table invalidate

From: Lucas De Marchi As we have more copy engines now, mask all of them from aux table invalidate. v2 (MattR): - Use I915_MAX_BCS to determine mask rather than hardcoding BCS8. (Prathap) Cc: Prathap Kumar Valsan Signed-off-by: Lucas De Marchi Signed-off-by: Matt Roper Reviewed-by: José

[Intel-gfx] [PATCH v2 12/12] drm/i915/pvc: read fuses for link copy engines

From: Lucas De Marchi The new Link Copy engines in PVC may be fused off according to the mslice_mask. Each bit of the MEML3_EN_MASK we read from the GEN10_MIRROR_FUSE3 register disables a pair of link copy engines. v2 (Tvrtko): - Minor cosmetic changes: s/u8/unsigned long/, use instance local

[Intel-gfx] [PATCH v2 10/12] drm/i915/pvc: Reset support for new copy engines

Add the reset support for new copy engines in PVC. Bspec: 52549 Original-author: CQ Tang Signed-off-by: Matt Roper Reviewed-by: José Roberto de Souza Reviewed-by: Stuart Summers --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 8 + drivers/gpu/drm/i915/gt/intel_gt_regs.h | 44 +++

[Intel-gfx] [PATCH v2 01/12] drm/i915/uncore: Reorganize and document shadow and forcewake tables

Let's reorganize some of the forcewake/shadow handling in intel_uncore.c and consolidate the cargo-cult comments on each table into more general comments that apply to all tables. We'll probably move forcewake handling to its own dedicated file in the near future and further enhance this with true

[Intel-gfx] [PATCH v2 05/12] drm/i915/pvc: Remove additional 3D flags from PIPE_CONTROL

From: Stuart Summers Although we already strip 3D-specific flags from PIPE_CONTROL instructions when submitting to a compute engine, there are some additional flags that need to be removed when the platform as a whole lacks a 3D pipeline. Add those restrictions here. Bspec: 47112 Signed-off-by:

[Intel-gfx] [PATCH v2 09/12] drm/i915/pvc: Interrupt support for new copy engines

Add the interrupt handler support for new copy engines. Bspec: 54030 Original-author: CQ Tang Signed-off-by: Matt Roper Reviewed-by: Stuart Summers --- drivers/gpu/drm/i915/gt/intel_gt_irq.c | 16 drivers/gpu/drm/i915/gt/intel_gt_regs.h | 4 2 files changed, 20 insertion

[Intel-gfx] [PATCH v2 00/12] i915: Introduce Ponte Vecchio

Ponte Vecchio (PVC) is a new GPU based on the Xe_HPC architecture. As a compute-focused platform, PVC has compute engines and enhanced copy engines, but no render engine (there is no geometry pipeline) and no display. This is just a handful of early enablement patches, including some initial supp

[Intel-gfx] [PATCH v2 04/12] drm/i915/pvc: Read correct RP_STATE_CAP register

The SoC registers, including RP_STATE_CAP, have moved to a new location in GTTMMADR on Ponte Vecchio. We need to update the register offset accordingly. Cc: Rodrigo Vivi Signed-off-by: Matt Roper Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/gt/intel_rps.c | 4 +++- drivers/gpu/drm/i915/

[Intel-gfx] [PATCH v2 03/12] drm/i915/pvc: Define MOCS table for PVC

From: Ayaz A Siddiqui v2 (MattR): - Clarify comment above RING_CMD_CCTL programming. - Remove bspec reference from field definition. (Lucas) - Add WARN if we try to use a (presumably uninitialized) wb_index of 0. On most platforms 0 is an invalid MOCS entry and even on the ones where it

[Intel-gfx] [PATCH v2 07/12] drm/i915/gvt: Use intel_engine_mask_t for ring mask

When i915 adds additional PVC blitter instances (in an upcoming patch), the definition of VECS0 will change from bit(10) to bit(18), causing GVT's R_ALL mask to overflow the u16 storage that's currently used. Let's replace the u16 with an intel_engine_mask_t to ensure we avoid this. Cc: Tvrtko Urs

[Intel-gfx] [PATCH v2 02/12] drm/i915/pvc: Add forcewake support

Add PVC's forcewake ranges. v2: - Drop replicated comment completely; move general cleanup of the documentation to a separate patch. Bspec: 67609 Cc: Daniele Ceraolo Spurio Cc: Stuart Summers Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/intel_uncore.c | 142 +++

Re: [Intel-gfx] [PATCH v5 1/2] module: update dependencies at try_module_get()

Hi Mauro, [...] > +static int ref_module_dependency(struct module *mod, struct module *this) > +{ > + int ret; > + > + if (!this || !this->name) > + return -EINVAL; > + > + if (mod == this) > + return 0; > + > + mutex_lock(&module_mutex); > + > + ret =

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Eliminate PIPECONF RMWs from .color_commit() (rev2)

== Series Details == Series: drm/i915: Eliminate PIPECONF RMWs from .color_commit() (rev2) URL : https://patchwork.freedesktop.org/series/102666/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/7] drm/i915: Drop has_gt_uc from device info

== Series Details == Series: series starting with [CI,1/7] drm/i915: Drop has_gt_uc from device info URL : https://patchwork.freedesktop.org/series/103629/ State : success == Summary == CI Bug Log - changes from CI_DRM_11612 -> Patchwork_103629v1 ===

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/7] drm/i915: Drop has_gt_uc from device info

== Series Details == Series: series starting with [CI,1/7] drm/i915: Drop has_gt_uc from device info URL : https://patchwork.freedesktop.org/series/103629/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/7] drm/i915: Drop has_gt_uc from device info

== Series Details == Series: series starting with [CI,1/7] drm/i915: Drop has_gt_uc from device info URL : https://patchwork.freedesktop.org/series/103629/ State : warning == Summary == Error: dim checkpatch failed 56f051d52ffd drm/i915: Drop has_gt_uc from device info a717cf4a929c drm/i915: D

Re: [Intel-gfx] [PATCH 07/11] drm/i915/pvc: Engines definitions for new copy engines

On Tue, May 03, 2022 at 09:05:43AM +0100, Tvrtko Ursulin wrote: > > On 02/05/2022 17:34, Matt Roper wrote: > > This patch adds the basic definitions needed to support > > new copy engines. Also updating the cmd_info to accommodate > > new engines, as the engine id's of legacy engines have been > >

Re: [Intel-gfx] [v2,3/4] drm/i915/huc: Prepare for GSC-loaded HuC

Because i reviewed this already and the only new change is the relocation of the function "huc_is_authenticated()" from Patch 1 to this patch while maintaining the same logic as rev-1, thus: Acked-by: Alan Previn On Wed, 2022-05-04 at 13:48 -0700, Daniele Ceraolo Spurio wrote: > HuC loading via

Re: [Intel-gfx] [v2, 1/4] drm/i915/huc: drop intel_huc_is_authenticated

Reviewed-by: Alan Previn On Wed, 2022-05-04 at 13:48 -0700, Daniele Ceraolo Spurio wrote: > The fuction name is confusing, because it doesn't check the actual auth > status in HW but the SW status. Given that there is only one user (the > huc_auth function itself), just get rid of it and use the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fbdev: unregister framebuffer after disabling hpd (rev3)

== Series Details == Series: drm/i915/fbdev: unregister framebuffer after disabling hpd (rev3) URL : https://patchwork.freedesktop.org/series/103621/ State : success == Summary == CI Bug Log - changes from CI_DRM_11611 -> Patchwork_103621v3

[Intel-gfx] [PATCH CI 7/7] drm/i915: Drop has_psr from device info

No need to have this parameter in intel_device_info struct as all platforms with display version 9 or newer has this feature. As a side effect of the of removal this flag, it will not be printed in dmesg during driver load anymore and developers will have to rely on to check the macro and compare

[Intel-gfx] [PATCH CI 5/7] drm/i915: Drop has_ddi from device info

No need to have this parameter in intel_device_info struct as all platforms with display version 9 or newer, haswell or broadwell supports it. As a side effect of the of removal this flag, it will not be printed in dmesg during driver load anymore and developers will have to rely on to check the m

[Intel-gfx] [PATCH CI 6/7] drm/i915: Drop has_dp_mst from device info

No need to have this parameter in intel_device_info struct as the requirement to support it is the DDI support. As a side effect of the of removal this flag, it will not be printed in dmesg during driver load anymore and developers will have to rely on to check the macro and compare with platform

[Intel-gfx] [PATCH CI 4/7] drm/i915: Drop has_logical_ring_elsq from device info

No need to have this parameter in intel_device_info struct as all platforms with graphics version 11 or newer has this feature. As a side effect of the of removal this flag, it will not be printed in dmesg during driver load anymore and developers will have to rely on to check the macro and compar

[Intel-gfx] [PATCH CI 2/7] drm/i915: Drop has_rc6 from device info

No need to have this parameter in intel_device_info struct as all platforms with graphics version 6 or newer have software support for this feature. As a side effect of the of removal this flag, it will not be printed in dmesg during driver load anymore and developers will have to rely on to check

[Intel-gfx] [PATCH CI 3/7] drm/i915: Drop has_reset_engine from device info

No need to have this parameter in intel_device_info struct as all platforms with graphics version 7 or newer can reset engines. As a side effect of the of removal this flag, it will not be printed in dmesg during driver load anymore and developers will have to rely on to check the macro and compar

[Intel-gfx] [PATCH CI 1/7] drm/i915: Drop has_gt_uc from device info

No need to have this parameter in intel_device_info struct as all platforms with graphics version 9 or newer has graphics microcontroller. As a side effect of the of removal this flag, it will not be printed in dmesg during driver load anymore and developers will have to rely on to check the macro

Re: [Intel-gfx] [PATCH] drm/i915: Support Async Flip on Linear buffers

On Thu, May 05, 2022 at 04:09:18PM +, Murthy, Arun R wrote: > > > Can I have your Reviewed-by for this patch? > > > > You didn't find the GTT alignment restriction yet which to me syas you > > didn't > > really look hard enough. > I checked in the BSpec and also clarified with the hardware te

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dmc: Load DMC on DG2 (rev3)

== Series Details == Series: drm/i915/dmc: Load DMC on DG2 (rev3) URL : https://patchwork.freedesktop.org/series/103625/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11611 -> Patchwork_103625v3 Summary --- **FAILURE

Re: [Intel-gfx] [PATCH v3 0/7] Make the rest of the VFIO driver interface use vfio_device

On Wed, 4 May 2022 14:49:26 -0300 Jason Gunthorpe wrote: > On Mon, May 02, 2022 at 02:31:30PM -0300, Jason Gunthorpe wrote: > > Prior series have transformed other parts of VFIO from working on struct > > device or struct vfio_group into working directly on struct > > vfio_device. Based on that w

Re: [Intel-gfx] [PATCH 1/2] drm/i915/fbdev: print error in case drm_fb_helper_initial_config fails

Hi Jani, On 05.05.2022 20:37, Jani Nikula wrote: On Wed, 04 May 2022, Andrzej Hajda wrote: On some configurations drm_fb_helper_initial_config sometimes fails. Logging error value should help debugging such issues. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/display/intel_fbdev.c

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Support programming the EU priority in the GuC descriptor

On 5/4/2022 16:46, Daniele Ceraolo Spurio wrote: From: Matthew Brost In GuC submission mode the EU priority must be updated by the GuC rather than the driver as the GuC owns the programming of the context descriptor. Given that the GuC code uses the GuC priorities, we can't use a generic funct

Re: [Intel-gfx] [PATCH 1/2] drm/i915/fbdev: print error in case drm_fb_helper_initial_config fails

On Wed, 04 May 2022, Andrzej Hajda wrote: > On some configurations drm_fb_helper_initial_config sometimes fails. > Logging error value should help debugging such issues. > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/i915/display/intel_fbdev.c | 11 --- > 1 file changed, 8 inse

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use non-blocking H2G for waitboost

On 5/5/2022 10:21, Belgaumkar, Vinay wrote: On 5/5/2022 5:13 AM, Tvrtko Ursulin wrote: On 05/05/2022 06:40, Vinay Belgaumkar wrote: SLPC min/max frequency updates require H2G calls. We are seeing timeouts when GuC channel is backed up and it is unable to respond in a timely fashion causing warn

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/fbdev: unregister framebuffer after disabling hpd (rev2)

== Series Details == Series: drm/i915/fbdev: unregister framebuffer after disabling hpd (rev2) URL : https://patchwork.freedesktop.org/series/103621/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11610_full -> Patchwork_103621v2_full ===

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Load DMC on DG2 (rev2)

== Series Details == Series: drm/i915/dmc: Load DMC on DG2 (rev2) URL : https://patchwork.freedesktop.org/series/103625/ State : success == Summary == CI Bug Log - changes from CI_DRM_11610 -> Patchwork_103625v2 Summary --- **SUCCESS

[Intel-gfx] [PATCH] drm/i915/dmc: Load DMC on DG2

Add Support for DC states on Dg2. v2: Add dc9 as the max supported DC states and disable DC5. v3: set max_dc to 0. (Imre) v4: Add FIXME (Rodrigo) Cc: Imre Deak Cc: Rodrigo Vivi Signed-off-by: Anusha Srivatsa Reviewed-by: Rodrigo Vivi (v1) --- drivers/gpu/drm/i915/display/intel_display_power.c

[Intel-gfx] [PATCH 0/1] DG2 DMC Support

While DG2 supports DC5 and DC9, some of the tests in fast-feedback blew up DG2 when the tests forced transition from dc5->dc9 on suspend and dc9->dc5 on resume. Some local experiments performed with Rodrigo on a RIL system showed promising results when dc5 was completely diabled and i915 took only

Re: [Intel-gfx] [PATCH v2 00/20] drm/edid: CEA data block iterators, and more

On Thu, 05 May 2022, Ville Syrjälä wrote: > On Tue, May 03, 2022 at 12:23:45PM +0300, Jani Nikula wrote: >> I've kind of lost track of the version numbers on some of the iterator >> patches, but this is the next version (or mostly a resend) of >> [1]. There's an additional rename patch for SCDS. >

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use non-blocking H2G for waitboost

On 5/5/2022 5:13 AM, Tvrtko Ursulin wrote: On 05/05/2022 06:40, Vinay Belgaumkar wrote: SLPC min/max frequency updates require H2G calls. We are seeing timeouts when GuC channel is backed up and it is unable to respond in a timely fashion causing warnings and affecting CI. Is it the "Unable

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Load DMC on DG2

On Thu, 2022-05-05 at 09:58 -0700, Anusha Srivatsa wrote: > Add Support for DC states on Dg2. > > v2: Add dc9 as the max supported DC states and disable DC5. > v3: set max_dc to 0. (Imre) > > Cc: Imre Deak > Cc: Rodrigo Vivi > Signed-off-by: Anusha Srivatsa > Reviewed-by: Rodrigo Vivi (v1) > -

[Intel-gfx] [PATCH] drm/i915/dmc: Load DMC on DG2

Add Support for DC states on Dg2. v2: Add dc9 as the max supported DC states and disable DC5. v3: set max_dc to 0. (Imre) Cc: Imre Deak Cc: Rodrigo Vivi Signed-off-by: Anusha Srivatsa Reviewed-by: Rodrigo Vivi (v1) --- drivers/gpu/drm/i915/display/intel_display_power.c | 4 +++- drivers/gpu/

[Intel-gfx] [PATCH 0/1] DG2 DMC Support

While DG2 supports DC5 and DC9, some of the tests in fast-feedback blew up DG2 when the tests forced transition from dc5->dc9 on suspend and dc9->dc5 on resume. Some local experiments performed with Rodrigo on a RIL system showed promising results when dc5 was completely diabled and i915 took only

[Intel-gfx] [PATCH 0/1] DG2 DMC Support

While DG2 supports DC5 and DC9, some of the tests in fast-feedback blew up DG2 when the tests forced transition from dc5->dc9 on suspend and dc9->dc5 on resume. Some local experiments performed with Rodrigo on a RIL system showed promising results when dc5 was completely diabled and i915 took only

[Intel-gfx] [PATCH] drm/i915/dmc: Load DMC on DG2

Add Support for DC states on Dg2. v2: Add dc9 as the max supported DC states and disable DC5. v3: set max_dc to 0. (Imre) Cc: Imre Deak Cc: Rodrigo Vivi Signed-off-by: Anusha Srivatsa Reviewed-by: Rodrigo Vivi (v1) --- drivers/gpu/drm/i915/display/intel_display_power.c | 4 +++- drivers/gpu/

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/fbdev: unregister framebuffer after disabling hpd

== Series Details == Series: drm/i915/fbdev: unregister framebuffer after disabling hpd URL : https://patchwork.freedesktop.org/series/103621/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11610_full -> Patchwork_103621v1_full ==

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fbdev: unregister framebuffer after disabling hpd (rev2)

== Series Details == Series: drm/i915/fbdev: unregister framebuffer after disabling hpd (rev2) URL : https://patchwork.freedesktop.org/series/103621/ State : success == Summary == CI Bug Log - changes from CI_DRM_11610 -> Patchwork_103621v2

Re: [Intel-gfx] [PATCH] drm/i915: Support Async Flip on Linear buffers

> > Can I have your Reviewed-by for this patch? > > You didn't find the GTT alignment restriction yet which to me syas you didn't > really look hard enough. I checked in the BSpec and also clarified with the hardware team on this. > > And you haven't answered what the actual use case for this is.

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for unexpected l3bank/mslice config

On Thu, May 05, 2022 at 12:02:45PM +0100, Tvrtko Ursulin wrote: > > On 04/05/2022 19:17, Matt Roper wrote: > > On Wed, May 04, 2022 at 06:59:32PM +0100, Tvrtko Ursulin wrote: > > > > > > On 04/05/2022 17:48, Matt Roper wrote: > > > > On Wed, May 04, 2022 at 01:07:14PM +0100, Tvrtko Ursulin wrote:

Re: [Intel-gfx] [PATCH 01/12] drm/i915: Drop IPC from display 13 and newer

On Thu, 2022-05-05 at 00:33 +0300, Ville Syrjälä wrote: > On Wed, May 04, 2022 at 12:07:45PM -0700, José Roberto de Souza wrote: > > This feature is supported from display 9 to display 12 and was > > incorrectly being applied to DG2 and Alderlake-P. > > They just renamed the register to ARB_HP_CTL

[Intel-gfx] [PULL] drm-misc-fixes

drm-misc-fixes-2022-05-05: drm-misc-fixes for v5.18-rc6: - Small fix for hot-unplugging fb devices. - Kconfig fix for it6505. The following changes since commit dc3ae06c5f2170d879ff58696f629d8c3868aec3: drm/sun4i: Remove obsolete references to PHYS_OFFSET (2022-04-26 14:39:56 +0200) are availa

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for unexpected l3bank/mslice config

== Series Details == Series: series starting with [CI,1/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for unexpected l3bank/mslice config URL : https://patchwork.freedesktop.org/series/103610/ State : success == Summary == CI Bug Log - changes from CI_DRM_11610_full -> Patchwork_103610v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fbdev: unregister framebuffer after disabling hpd

== Series Details == Series: drm/i915/fbdev: unregister framebuffer after disabling hpd URL : https://patchwork.freedesktop.org/series/103621/ State : success == Summary == CI Bug Log - changes from CI_DRM_11610 -> Patchwork_103621v1 Summar

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/edid: CEA data block iterators, and more (rev4)

== Series Details == Series: drm/edid: CEA data block iterators, and more (rev4) URL : https://patchwork.freedesktop.org/series/102703/ State : success == Summary == CI Bug Log - changes from CI_DRM_11610_full -> Patchwork_102703v4_full Sum

Re: [Intel-gfx] [PATCH 01/12] drm/i915: Drop IPC from display 13 and newer

On Thu, May 05, 2022 at 02:00:50PM +, Souza, Jose wrote: > On Thu, 2022-05-05 at 13:45 +0300, Jani Nikula wrote: > > - has_rc6p - complicated > > Matt Ropper suggested to use IS_GRAPHICS_VER(i915, 6, 7) so it will become > even less complicated. That won't really simplify it. The simplest fo

[Intel-gfx] [PATCH] drm/i915/fbdev: unregister framebuffer after disabling hpd

Deferred framebuffer can be registered in hpd worker. So drm_fb_helper_unregister_fbi should be called after hpd is stopped. Otherwise we risk UAF after module removal. The patch should fix following GPF: [272.634530] general protection fault, probably for non-canonical address 0x6b6b6b6b6b6b6b6

Re: [Intel-gfx] [PATCH v3] drm/edid: detect color formats and CTA revision in all CTA extensions

On Thu, May 05, 2022 at 01:52:42PM +0300, Jani Nikula wrote: > Convert drm_find_cea_extension() to EDID block iterator in color format > and CTA revision detection. Detect them in all CTA extensions. > > Also parse CTA Data Blocks in DisplayID even if there's no CTA EDID > extension. > > v2: > -

Re: [Intel-gfx] [PATCH] drm/i915: Support Async Flip on Linear buffers

On Thu, May 05, 2022 at 06:33:46AM +, Murthy, Arun R wrote: > > > There is that GTT alignment restriction that should be mentioned > > > somewhere. Can't quite remember where it was, maybe in PLANE_SURF. > > > > > I checked the BSpec, and don't find anything as such specific for Async > > flip

Re: [Intel-gfx] [PATCH 01/12] drm/i915: Drop IPC from display 13 and newer

On Thu, 2022-05-05 at 13:45 +0300, Jani Nikula wrote: > On Wed, 04 May 2022, José Roberto de Souza wrote: > > This feature is supported from display 9 to display 12 and was > > incorrectly being applied to DG2 and Alderlake-P. > > > > While at is also taking the oportunity to drop it from > > int

Re: [Intel-gfx] [PATCH v7 6/7] drm/i915/gt: Create per-tile RPS sysfs interfaces

Hi Tvrtko, [...] > > +static ssize_t act_freq_mhz_show(struct device *dev, > > +struct device_attribute *attr, char *buff) > > +{ > > + u32 actual_freq = sysfs_gt_attribute_r_max_func(dev, attr, > > + __act_freq_mhz_show)

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for unexpected l3bank/mslice config

== Series Details == Series: series starting with [CI,1/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for unexpected l3bank/mslice config URL : https://patchwork.freedesktop.org/series/103610/ State : success == Summary == CI Bug Log - changes from CI_DRM_11610 -> Patchwork_103610v1 ==

Re: [Intel-gfx] [PATCH v7 6/7] drm/i915/gt: Create per-tile RPS sysfs interfaces

Hi Andi, On 18/03/2022 23:39, Andi Shyti wrote: Now tiles have their own sysfs interfaces under the gt/ directory. Because RPS is a property that can be configured on a tile basis, then each tile should have its own interface The new sysfs structure will have a similar layout for the 4 tile c

[Intel-gfx] [PULL] drm-misc-next

Hi Dave, Daniel, Here's this week drm-misc-next PR Maxime drm-misc-next-2022-05-05: drm-misc-next for 5.19: UAPI Changes: Cross-subsystem Changes: Core Changes: - Add DRM-managed mutex initialisation - edid: Doc improvements - fbdev: deferred io improvements - format-helper: consolida

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid: CEA data block iterators, and more (rev4)

== Series Details == Series: drm/edid: CEA data block iterators, and more (rev4) URL : https://patchwork.freedesktop.org/series/102703/ State : success == Summary == CI Bug Log - changes from CI_DRM_11610 -> Patchwork_102703v4 Summary -

Re: [Intel-gfx] [PATCH] drm/i915: Change semantics of context isolation reporting to UM

On Wed, May 04, 2022 at 11:12:26AM -0700, Matt Roper wrote: > On Wed, May 04, 2022 at 06:42:37PM +0200, Daniel Vetter wrote: > > On Wed, May 04, 2022 at 07:59:27AM -0700, Matt Roper wrote: > > > On Wed, May 04, 2022 at 02:24:07PM +0200, Daniel Vetter wrote: > > > > On Fri, 29 Apr 2022 at 17:11, Adr

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: CEA data block iterators, and more (rev4)

== Series Details == Series: drm/edid: CEA data block iterators, and more (rev4) URL : https://patchwork.freedesktop.org/series/102703/ State : warning == Summary == Error: dim checkpatch failed fe31b8863c44 drm/edid: reset display info in drm_add_edid_modes() for NULL edid 39c77f38058d drm/ed

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use non-blocking H2G for waitboost

On 05/05/2022 06:40, Vinay Belgaumkar wrote: SLPC min/max frequency updates require H2G calls. We are seeing timeouts when GuC channel is backed up and it is unable to respond in a timely fashion causing warnings and affecting CI. Is it the "Unable to force min freq" error? Do you have a link

Re: [Intel-gfx] [PATCH 3/3] drm/i915/display: stop using BUG()

On Thu, 05 May 2022, Tvrtko Ursulin wrote: > On 04/05/2022 19:37, Jani Nikula wrote: >> Avoid bringing the entire machine down even if there's a bug that >> shouldn't happen, but won't corrupt the system either. Log them loudly >> and limp on. >> >> Cc: Tvrtko Ursulin >> Signed-off-by: Jani Niku

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc/slpc: Use non-blocking H2G for waitboost

== Series Details == Series: drm/i915/guc/slpc: Use non-blocking H2G for waitboost URL : https://patchwork.freedesktop.org/series/103598/ State : success == Summary == CI Bug Log - changes from CI_DRM_11607_full -> Patchwork_103598v1_full S

Re: [Intel-gfx] [PATCH 3/3] drm/i915/display: stop using BUG()

On 04/05/2022 19:37, Jani Nikula wrote: Avoid bringing the entire machine down even if there's a bug that shouldn't happen, but won't corrupt the system either. Log them loudly and limp on. Cc: Tvrtko Ursulin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_ddi.c | 11

Re: [Intel-gfx] [PATCH 1/3] drm/i915: remove unused GEM_DEBUG_DECL() and GEM_DEBUG_BUG_ON()

On 04/05/2022 19:37, Jani Nikula wrote: There are already too many choices here, take away the unused ones. Cc: Tvrtko Ursulin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_gem.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.h b/drivers/gp

Re: [Intel-gfx] [PATCH 2/3] drm/i915: remove single-use GEM_DEBUG_EXEC()

On 04/05/2022 19:37, Jani Nikula wrote: Reduce the magic of what's going on in GEM_DEBUG_EXEC() by expanding it inline and being explicit about it. It's as single use case anyway, so the macro feels overkill. Cc: Tvrtko Ursulin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/intel_r

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for unexpected l3bank/mslice config

On 04/05/2022 19:17, Matt Roper wrote: On Wed, May 04, 2022 at 06:59:32PM +0100, Tvrtko Ursulin wrote: On 04/05/2022 17:48, Matt Roper wrote: On Wed, May 04, 2022 at 01:07:14PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin DRM_DEBUG_WARN_ON should only be used when we are certain CI i

[Intel-gfx] [CI 1/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for unexpected l3bank/mslice config

From: Tvrtko Ursulin DRM_DEBUG_WARN_ON should only be used when we are certain CI is guaranteed to exercise a certain code path, so in case of values coming from MMIO reads we cannot be sure CI will have all the possible SKUs and parts. Use drm_warn instead and move logging to init phase while a

[Intel-gfx] [CI 2/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for ring unexpectedly not idle

From: Tvrtko Ursulin DRM_DEBUG_WARN_ON should only be used when we are certain CI is guaranteed to exercise a certain code path, so in case of values coming from MMIO reads we cannot be sure CI will have all the possible SKUs and parts, or that it will catch all possible error conditions. Use drm

Re: [Intel-gfx] [PATCH v2 18/20] drm/edid: detect color formats and CTA revision in all CTA extensions

On Thu, 05 May 2022, Ville Syrjälä wrote: > On Tue, May 03, 2022 at 12:24:03PM +0300, Jani Nikula wrote: >> Convert drm_find_cea_extension() to EDID block iterator in color format >> and CTA revision detection. Detect them in all CTA extensions. >> >> Also parse CTA Data Blocks in DisplayID even

  1   2   >