Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Media freq factor and per-gt enhancements/fixes (rev4)

2022-04-29 Thread Vudum, Lakshminarayana
Re-reported and few comments below. -Original Message- From: Dixit, Ashutosh Sent: Friday, April 29, 2022 5:45 PM To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana Subject: Re: ✗ Fi.CI.IGT: failure for drm/i915: Media freq factor and per-gt enhancements/fixes (rev4) On Fri,

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Media freq factor and per-gt enhancements/fixes (rev4)

2022-04-29 Thread Dixit, Ashutosh
On Fri, 29 Apr 2022 16:38:35 -0700, Patchwork wrote: > > Possible regressions > > * igt@gem_eio@in-flight-suspend: > > * shard-skl: PASS -> INCOMPLETE This failure in unrelated. > > * {igt@i915_pm_disag_freq@media-freq@gt0} (NEW): > > * shard-iclb: NOTRUN -> SKIP > > * shard-tglb: NOTRUN -> SK

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Add MMIO range restrictions

2022-04-29 Thread Srivatsa, Anusha
> -Original Message- > From: De Marchi, Lucas > Sent: Friday, April 29, 2022 1:50 PM > To: Srivatsa, Anusha > Cc: intel-gfx@lists.freedesktop.org; sta...@vger.kernel.org > Subject: Re: [PATCH] drm/i915/dmc: Add MMIO range restrictions > > On Fri, Apr 29, 2022 at 01:39:03PM -0700, Anus

Re: [Intel-gfx] [PATCH v2 0/7] Make the rest of the VFIO driver interface use vfio_device

2022-04-29 Thread Alex Williamson
On Fri, 29 Apr 2022 14:31:49 -0300 Jason Gunthorpe wrote: > On Thu, Apr 21, 2022 at 01:28:31PM -0300, Jason Gunthorpe wrote: > > Prior series have transformed other parts of VFIO from working on struct > > device or struct vfio_group into working directly on struct > > vfio_device. Based on that

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for i915: Turn on compute engine support (rev4)

2022-04-29 Thread Matt Roper
On Thu, Apr 28, 2022 at 06:18:41AM +, Patchwork wrote: > == Series Details == > > Series: i915: Turn on compute engine support (rev4) > URL : https://patchwork.freedesktop.org/series/103011/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_11550_full -> Patchwork_10

Re: [Intel-gfx] [PATCH v2 0/4] i915: Turn on compute engine support

2022-04-29 Thread Jordan Justen
I did some light testing with our anvil (Vulkan) and iris (OpenGL) Mesa drivers after applying these patches on top of drm-tip tagged intel/CI_DRM_11574. All the unit tests that I tried passed. I also ran the gl_manhattan31 benchmark which used the compute engine for iris compute shader ops. Serie

Re: [Intel-gfx] [PATCH 1/3] drm/i915/display: Do not schedule DRRS work thread when it is not active

2022-04-29 Thread Souza, Jose
On Fri, 2022-04-29 at 19:00 +0300, Ville Syrjälä wrote: > On Thu, Apr 28, 2022 at 02:10:56PM -0700, José Roberto de Souza wrote: > > Frontbuffer updates were scheduling the execution of DRRS work thread > > even if DRRS is not active. > > There was no issues with it because intel_drrs_downclock_wor

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Media freq factor and per-gt enhancements/fixes (rev4)

2022-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev4) URL : https://patchwork.freedesktop.org/series/102665/ State : success == Summary == CI Bug Log - changes from CI_DRM_11583 -> Patchwork_102665v4

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Add MMIO range restrictions

2022-04-29 Thread Lucas De Marchi
On Fri, Apr 29, 2022 at 01:39:03PM -0700, Anusha Srivatsa wrote: -Original Message- From: De Marchi, Lucas Sent: Tuesday, April 26, 2022 10:42 PM To: Srivatsa, Anusha Cc: intel-gfx@lists.freedesktop.org; sta...@vger.kernel.org Subject: Re: [PATCH] drm/i915/dmc: Add MMIO range restric

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Add MMIO range restrictions

2022-04-29 Thread Srivatsa, Anusha
> -Original Message- > From: De Marchi, Lucas > Sent: Tuesday, April 26, 2022 10:42 PM > To: Srivatsa, Anusha > Cc: intel-gfx@lists.freedesktop.org; sta...@vger.kernel.org > Subject: Re: [PATCH] drm/i915/dmc: Add MMIO range restrictions > > On Tue, Apr 26, 2022 at 05:35:09PM -0700, An

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Media freq factor and per-gt enhancements/fixes (rev4)

2022-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev4) URL : https://patchwork.freedesktop.org/series/102665/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Media freq factor and per-gt enhancements/fixes (rev4)

2022-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev4) URL : https://patchwork.freedesktop.org/series/102665/ State : warning == Summary == Error: dim checkpatch failed 720f593ecbb4 drm/i915: Introduce has_media_ratio_mode 3c55d72952c7 drm/i915/gt: Add me

Re: [Intel-gfx] [PATCH v2 7/7] vfio: Remove calls to vfio_group_add_container_user()

2022-04-29 Thread Alex Williamson
On Thu, 21 Apr 2022 13:28:38 -0300 Jason Gunthorpe wrote: > When the open_device() op is called the container_users is incremented and > held incremented until close_device(). Thus, so long as drivers call > functions within their open_device()/close_device() region they do not > need to worry ab

[Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-04-29 Thread Ashutosh Dixit
Each gt contains an independent instance of pcode. Extend pcode functions to interface with pcode on different gt's. To avoid creating dependency of display functionality on intel_gt, pcode function interfaces are exposed in terms of uncore rather than intel_gt. Callers have been converted to pass

[Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs

2022-04-29 Thread Ashutosh Dixit
All kmalloc'd kobjects need a kobject_put() to free memory. For example in previous code, kobj_gt_release() never gets called. The requirement of kobject_put() now results in a slightly different code organization. v2: s/gtn/gt/ (Andi) Cc: Andi Shyti Cc: Andrzej Hajda Fixes: b770bcfae9ad ("drm/

[Intel-gfx] [PATCH 8/8] drm/i915/gt: Expose default value for media_freq_factor in per-gt sysfs

2022-04-29 Thread Ashutosh Dixit
Add the following sysfs file to gt/gtN/.defaults: * media_freq_factor Cc: Joonas Lahtinen Signed-off-by: Ashutosh Dixit Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 18 ++ drivers/gpu/drm/i915/gt/intel_gt_types.h| 1 + drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH 2/8] drm/i915/gt: Add media freq factor to per-gt sysfs

2022-04-29 Thread Ashutosh Dixit
Expose new sysfs to program and retrieve media freq factor. Factor values of 0 (dynamic), 0.5 and 1.0 are supported via a u8.8 fixed point representation (corresponding to integer values of 0, 128 and 256 respectively). Media freq factor is converted to media_ratio_mode for GuC. It is programmed i

[Intel-gfx] [PATCH 4/8] drm/i915/pcode: Add a couple of pcode helpers

2022-04-29 Thread Ashutosh Dixit
From: Dale B Stimson Some dGfx pcode commands take additional sub-commands and parameters. Add a couple of helpers to help formatting these commands to improve code readability. v2: Fixed commit author (Rodrigo) v3: Function rename and convert to new uncore interface for pcode functions Remo

[Intel-gfx] [PATCH 5/8] drm/i915/gt: Add media RP0/RPn to per-gt sysfs

2022-04-29 Thread Ashutosh Dixit
From: Dale B Stimson Retrieve RP0 and RPn freq for media IP from PCODE and display in per-gt sysfs. This patch adds the following files to gt/gtN sysfs: * media_RP0_freq_mhz * media_RPn_freq_mhz v2: Fixed commit author (Rodrigo) v3: Convert to new uncore interface for pcode functions v4: Adapt t

[Intel-gfx] [PATCH 1/8] drm/i915: Introduce has_media_ratio_mode

2022-04-29 Thread Ashutosh Dixit
Media ratio mode (the ability for media IP to work at a different frequency from the GT) is available for a subset of dGfx platforms supporting GuC/SLPC. Introduce 'has_media_ratio_mode' flag in intel_device_info to identify these platforms and set it for XEHPSDV and DG2/ATS-M. Signed-off-by: Ashu

[Intel-gfx] [PATCH 7/8] drm/i915/gt: Expose per-gt RPS defaults in sysfs

2022-04-29 Thread Ashutosh Dixit
Create a gt/gtN/.defaults directory (similar to engine//.defaults) to expose default parameter values for each gt in sysfs. Populate the .defaults directory with RPS parameter default values in order to allow userspace to revert to default values when needed. This patch adds the following sysfs fi

[Intel-gfx] [PATCH v4 0/8] drm/i915: Media freq factor and per-gt enhancements/fixes

2022-04-29 Thread Ashutosh Dixit
Some recent Intel dGfx platforms allow media IP to work at a different frequency from the base GT. This patch series exposes sysfs controls for this functionality in the new per-gt sysfs. Some enhancements and fixes to previous per-gt functionality are also included to complete the new functionalit

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ttm for stolen region (rev6)

2022-04-29 Thread Patchwork
== Series Details == Series: drm/i915: ttm for stolen region (rev6) URL : https://patchwork.freedesktop.org/series/102540/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11582 -> Patchwork_102540v6 Summary --- **FAILU

[Intel-gfx] ✗ Fi.CI.IGT: failure for Handle predicate programming

2022-04-29 Thread Patchwork
== Series Details == Series: Handle predicate programming URL : https://patchwork.freedesktop.org/series/103084/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11550_full -> Patchwork_103084v1_full Summary --- **FAILU

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: ttm for stolen region (rev6)

2022-04-29 Thread Patchwork
== Series Details == Series: drm/i915: ttm for stolen region (rev6) URL : https://patchwork.freedesktop.org/series/102540/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [3/4] drm/i915/huc: Prepare for GSC-loaded HuC

2022-04-29 Thread Teres Alexis, Alan Previn
Reviewed-by: Alan Previn On Tue, 2022-04-26 at 17:26 -0700, Daniele Ceraolo Spurio wrote: > HuC loading via GSC is performed via a PXP command sent through the mei > modules, so we need both MEI_GSC and MEI_PXP to be available. Given that > the GSC will do both the transfer and the authenticatio

[Intel-gfx] ✗ Fi.CI.BAT: failure for lrc selftest fixes (rev5)

2022-04-29 Thread Patchwork
== Series Details == Series: lrc selftest fixes (rev5) URL : https://patchwork.freedesktop.org/series/101353/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11582 -> Patchwork_101353v5 Summary --- **FAILURE** Serio

Re: [Intel-gfx] [2/4] drm/i915/huc: Add fetch support for gsc-loaded HuC binary

2022-04-29 Thread Teres Alexis, Alan Previn
minor nit: not sure if its worth mentioning in commit msg that "loaded_via_gsc" is zero-init-ed as fw_def macros we havent added fw_defs for gsc-loaded-huc-bins which explains why "loaded_via_gsc" not getting set anywhere in this series. Reviewed-by: Alan Previn On Tue, 2022-04-26 at 17:26 -070

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: move tons of power well initializers to rodata

2022-04-29 Thread Patchwork
== Series Details == Series: drm/i915: move tons of power well initializers to rodata URL : https://patchwork.freedesktop.org/series/103340/ State : success == Summary == CI Bug Log - changes from CI_DRM_11582_full -> Patchwork_103340v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for Handle predicate programming

2022-04-29 Thread Patchwork
== Series Details == Series: Handle predicate programming URL : https://patchwork.freedesktop.org/series/103084/ State : success == Summary == CI Bug Log - changes from CI_DRM_11550 -> Patchwork_103084v1 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Change semantics of context isolation reporting to UM (rev2)

2022-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Change semantics of context isolation reporting to UM (rev2) URL : https://patchwork.freedesktop.org/series/103343/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11582 -> Patchwork_103343v2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for lrc selftest fixes (rev5)

2022-04-29 Thread Patchwork
== Series Details == Series: lrc selftest fixes (rev5) URL : https://patchwork.freedesktop.org/series/101353/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/gt/intel_engine_stats.h:2

Re: [Intel-gfx] [PATCH] drm/i915: move tons of power well initializers to rodata

2022-04-29 Thread Imre Deak
On Fri, Apr 29, 2022 at 05:21:40PM +0300, Jani Nikula wrote: > Using compound literals for initialization can be tricky. Lacking a > const qualifier, they won't end up in rodata, which is probably not > expected or intended. Add const to move a whopping 136 initializers to > rodata. > > Compare: >

[Intel-gfx] [PATCH v3 4/4] drm/i915/selftest: Clear the output buffers before GPU writes

2022-04-29 Thread Ramalingam C
From: Chris Wilson When testing whether we can get the GPU to leak information about non-privileged state, we first need to ensure that the output buffer is set to a known value as the HW may opt to skip the write into memory for a non-privileged read of a sensitive register. We chose POISON_INUS

[Intel-gfx] [PATCH v3 3/4] drm/i915/selftest: Always cancel semaphore on error

2022-04-29 Thread Ramalingam C
From: Chris Wilson Ensure that we always signal the semaphore when timing out, so that if it happens to be stuck waiting for the semaphore we will quickly recover without having to wait for a reset. Reported-by: CQ Tang Signed-off-by: Chris Wilson Cc: CQ Tang cc: Joonas Lahtinen Signed-off-b

[Intel-gfx] [PATCH v3 2/4] drm/i915/selftests: Check for incomplete LRI from the context image

2022-04-29 Thread Ramalingam C
From: Chris Wilson In order to keep the context image parser simple, we assume that all commands follow a similar format. A few, especially not MI commands on the render engines, have fixed lengths not encoded in a length field. This caused us to incorrectly skip over 3D state commands, and start

[Intel-gfx] [PATCH v3 1/4] drm/i915/gt: Explicitly clear BB_OFFSET for new contexts

2022-04-29 Thread Ramalingam C
From: Chris Wilson Even though the initial protocontext we load onto HW has the register cleared, by the time we save it into the default image, BB_OFFSET has had the enable bit set. Reclear BB_OFFSET for each new context. Testcase: igt/i915_selftests/gt_lrc v2: Extend it for gen8. Signed-of

[Intel-gfx] [PATCH v3 0/4] lrc selftest fixes

2022-04-29 Thread Ramalingam C
Few bug fixes for lrc selftest. v3: Extending the first patch for gen8 Chris Wilson (4): drm/i915/gt: Explicitly clear BB_OFFSET for new contexts drm/i915/selftests: Check for incomplete LRI from the context image drm/i915/selftest: Always cancel semaphore on error drm/i915/selftest: Cl

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: remove unnecessary spin_lock_irq

2022-04-29 Thread Patchwork
== Series Details == Series: drm/i915: remove unnecessary spin_lock_irq URL : https://patchwork.freedesktop.org/series/103344/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11582 -> Patchwork_103344v1 Summary --- **F

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Change semantics of context isolation reporting to UM (rev2)

2022-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Change semantics of context isolation reporting to UM (rev2) URL : https://patchwork.freedesktop.org/series/103343/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Handle predicate programming

2022-04-29 Thread Ramalingam C
On 2022-04-25 at 16:44:14 +, Patchwork wrote: > == Series Details == > > Series: Handle predicate programming > URL : https://patchwork.freedesktop.org/series/103084/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_11550 -> Patchwork_103084v1 >

[Intel-gfx] [PATCH] drm/i915: remove unnecessary spin_lock_irq

2022-04-29 Thread Zhenneng Li
This code will not be called by interrupt handler, so change it to spin_lock. Signed-off-by: Zhenneng Li --- drivers/gpu/drm/i915/i915_scheduler.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_scheduler.c b/drivers/gpu/drm/i915/i915_scheduler.

[Intel-gfx] [PATCH] drm/i915: Change semantics of context isolation reporting to UM

2022-04-29 Thread Adrian Larumbe
I915_PARAM_HAS_CONTEXT_ISOLATION was already being used as a boolean by both Iris and Vulkan , and stood for the guarantee that, when creating a new context, all state set by it will not leak to any other context. However the actual return value was a bitmask where every bit stood for an initialis

[Intel-gfx] [PATCH] drm/i915: Change semantics of context isolation reporting to UM

2022-04-29 Thread Adrian Larumbe
I915_PARAM_HAS_CONTEXT_ISOLATION was already being used as a boolean by both Iris and Vulkan , and stood for the guarantee that, when creating a new context, all state set by it will not leak to any other context. However the actual return value was a bitmask where every bit stood for an initialis

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: move tons of power well initializers to rodata

2022-04-29 Thread Patchwork
== Series Details == Series: drm/i915: move tons of power well initializers to rodata URL : https://patchwork.freedesktop.org/series/103340/ State : success == Summary == CI Bug Log - changes from CI_DRM_11582 -> Patchwork_103340v1 Summary

Re: [Intel-gfx] [PATCH 1/3] drm/i915/display: Do not schedule DRRS work thread when it is not active

2022-04-29 Thread Ville Syrjälä
On Thu, Apr 28, 2022 at 02:10:56PM -0700, José Roberto de Souza wrote: > Frontbuffer updates were scheduling the execution of DRRS work thread > even if DRRS is not active. > There was no issues with it because intel_drrs_downclock_work() checks > if DRRS is active but there is no reason to keep sc

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix assert in i915_ggtt_pin

2022-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Fix assert in i915_ggtt_pin URL : https://patchwork.freedesktop.org/series/103339/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11582 -> Patchwork_103339v1 Summary --- **FAILUR

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: move tons of power well initializers to rodata

2022-04-29 Thread Patchwork
== Series Details == Series: drm/i915: move tons of power well initializers to rodata URL : https://patchwork.freedesktop.org/series/103340/ State : warning == Summary == Error: dim checkpatch failed 82d7c7816f0f drm/i915: move tons of power well initializers to rodata -:16: WARNING:COMMIT_LOG

Re: [Intel-gfx] [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Lucas De Marchi
On Fri, Apr 29, 2022 at 11:23:51AM +0100, Mauro Carvalho Chehab wrote: Em Fri, 29 Apr 2022 12:10:07 +0200 Greg KH escreveu: On Fri, Apr 29, 2022 at 10:15:03AM +0100, Mauro Carvalho Chehab wrote: > HI Greg, > > Em Fri, 29 Apr 2022 10:30:33 +0200 > Greg KH escreveu: > > > On Fri, Apr 29, 2022 a

Re: [Intel-gfx] [PATCH 3/9] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-04-29 Thread Dixit, Ashutosh
On Fri, 29 Apr 2022 05:58:21 -0700, Rodrigo Vivi wrote: > > > @@ -1251,7 +1251,7 @@ static int i915_drm_resume(struct drm_device *dev) > > > > disable_rpm_wakeref_asserts(&dev_priv->runtime_pm); > > > > - ret = intel_pcode_init(dev_priv); > > + ret = intel_gt_pcode_init(dev_priv); > > I did

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: remove superfluous string helper include (rev3)

2022-04-29 Thread Patchwork
== Series Details == Series: drm/i915: remove superfluous string helper include (rev3) URL : https://patchwork.freedesktop.org/series/103086/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11581 -> Patchwork_103086v3 Summary

Re: [Intel-gfx] [V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-04-29 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of > Bhanuprakash Modem > Sent: Monday, April 11, 2022 3:21 PM > To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; amd- > g...@lists.freedesktop.org; jani.nik...@linux.intel.com; > ville.syrj...@linux.intel.com; harry.

Re: [Intel-gfx] [V2 1/3] drm/debug: Expose connector's max supported bpc via debugfs

2022-04-29 Thread Murthy, Arun R
> +static int output_bpc_show(struct seq_file *m, void *data) { Can we have a meaningful name instead of 'm' ? Upon changing this parameter name, you can have my Reviewed-By: Arun R Murthy Thanks and Regards, Arun R Murthy

[Intel-gfx] [PATCH] drm/i915: move tons of power well initializers to rodata

2022-04-29 Thread Jani Nikula
Using compound literals for initialization can be tricky. Lacking a const qualifier, they won't end up in rodata, which is probably not expected or intended. Add const to move a whopping 136 initializers to rodata. Compare: $ objdump --syms drivers/gpu/drm/i915/display/intel_display_power_map.o |

[Intel-gfx] [CI] drm/i915: Fix assert in i915_ggtt_pin

2022-04-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use lockdep_assert_not_held to simplify and correct the code. Otherwise false positive are hit if lock state is uknown like after a previous taint. Signed-off-by: Tvrtko Ursulin Reported-by: Ville Syrjälä Reviewed-by: Ville Syrjälä --- It's not pretty but it fired again a

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Enable THP on Icelake and beyond

2022-04-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Enable THP on Icelake and beyond URL : https://patchwork.freedesktop.org/series/103330/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11580 -> Patchwork_103330v1 =

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gt: Clear SET_PREDICATE_RESULT prior to executing the ring

2022-04-29 Thread Matthew Auld
On Mon, 25 Apr 2022 at 16:22, Ramalingam C wrote: > > From: Chris Wilson > > Userspace may leave predication enabled upon return from the batch > buffer, which has the consequent of preventing all operation from the > ring from being executed, including all the synchronisation, coherency > contro

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Enable THP on Icelake and beyond

2022-04-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Enable THP on Icelake and beyond URL : https://patchwork.freedesktop.org/series/103330/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 3/9] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-04-29 Thread Rodrigo Vivi
On Thu, Apr 28, 2022 at 05:39:37PM -0700, Ashutosh Dixit wrote: > Each gt contains an independent instance of pcode. Extend pcode functions > to interface with pcode on different gt's. To avoid creating dependency of > display functionality on intel_gt, new pcode function interfaces are > exposed i

Re: [Intel-gfx] [PATCH 9/9] drm/i915/gt: Expose default value for media_freq_factor in per-gt sysfs

2022-04-29 Thread Rodrigo Vivi
On Thu, Apr 28, 2022 at 05:39:43PM -0700, Ashutosh Dixit wrote: > Add the following sysfs file to gt/gtN/.defaults: > * media_freq_factor > > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Signed-off-by: Ashutosh Dixit Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c

Re: [Intel-gfx] [PATCH 8/9] drm/i915/gt: Expose per-gt RPS defaults in sysfs

2022-04-29 Thread Rodrigo Vivi
On Thu, Apr 28, 2022 at 05:39:42PM -0700, Ashutosh Dixit wrote: > Create a gt/gtN/.defaults directory (similar to > engine//.defaults) to expose default parameter values for each > gt in sysfs. Populate the .defaults directory with RPS parameter default > values in order to allow userspace to rever

Re: [Intel-gfx] [PATCH 2/3] drm/i915/selftests: Skip poisoning SET_PREDICATE_RESULT on dg2

2022-04-29 Thread Matthew Auld
On Mon, 25 Apr 2022 at 16:22, Ramalingam C wrote: > > From: Chris Wilson > > When predication is enabled all commands baring a few (such as MI_BB_END) > are nop'ed. If we accidentally enable predication while poisoning the > context, not only is the rest of the poisoning skipped (thus disabling >

Re: [Intel-gfx] [PATCH 1/3] drm/i915/xehpsdv/dg1/tgl: Fix issue with LRI relative addressing

2022-04-29 Thread Matthew Auld
On Mon, 25 Apr 2022 at 16:22, Ramalingam C wrote: > > From: Akeem G Abodunrin > > When bit 19 of MI_LOAD_REGISTER_IMM instruction opcode is set on tgl+ > devices, HW does not care about certain register address offsets, but > instead check the following for valid address ranges on specific engine

Re: [Intel-gfx] [PATCH 1/2] drm/edid: fix kernel-doc parameter name mismatches

2022-04-29 Thread Jani Nikula
On Tue, 26 Apr 2022, Jani Nikula wrote: > Fix the below drm/edid kernel-doc warnings: > > drivers/gpu/drm/drm_edid.c:1589: warning: Function parameter or member > '_edid' not described in 'drm_edid_header_is_valid' > drivers/gpu/drm/drm_edid.c:1589: warning: Excess function parameter > 'raw_edid

Re: [Intel-gfx] [PULL] gvt-next-2022-04-29

2022-04-29 Thread Jani Nikula
On Thu, 28 Apr 2022, "Wang, Zhi A" wrote: > Hi folks: > > Here is the pull of gvt-next which fixes the compilation error and warnings > for the the GVT-g refactor patches: > > - Fix a compiling warning of non-static function only having one caller. > - Fix a potential NULL pointer reference in th

Re: [Intel-gfx] [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Greg KH
On Fri, Apr 29, 2022 at 11:23:51AM +0100, Mauro Carvalho Chehab wrote: > Em Fri, 29 Apr 2022 12:10:07 +0200 > Greg KH escreveu: > > > On Fri, Apr 29, 2022 at 10:15:03AM +0100, Mauro Carvalho Chehab wrote: > > > HI Greg, > > > > > > Em Fri, 29 Apr 2022 10:30:33 +0200 > > > Greg KH escreveu: > >

Re: [Intel-gfx] [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Mauro Carvalho Chehab
Em Fri, 29 Apr 2022 12:10:07 +0200 Greg KH escreveu: > On Fri, Apr 29, 2022 at 10:15:03AM +0100, Mauro Carvalho Chehab wrote: > > HI Greg, > > > > Em Fri, 29 Apr 2022 10:30:33 +0200 > > Greg KH escreveu: > > > > > On Fri, Apr 29, 2022 at 09:07:57AM +0100, Mauro Carvalho Chehab wrote: > > >

Re: [Intel-gfx] [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Greg KH
On Fri, Apr 29, 2022 at 10:15:03AM +0100, Mauro Carvalho Chehab wrote: > HI Greg, > > Em Fri, 29 Apr 2022 10:30:33 +0200 > Greg KH escreveu: > > > On Fri, Apr 29, 2022 at 09:07:57AM +0100, Mauro Carvalho Chehab wrote: > > > Hi Daniel, > > > > > > Em Fri, 29 Apr 2022 09:54:10 +0200 > > > Daniel

[Intel-gfx] [PATCH 2/2] drm/i915: Only setup private tmpfs mount when needed and fix logging

2022-04-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin If i915 does not want to use huge pages there is a) no point in setting up the private mount and b) should former fail, it is misleading to log THP support is disabled in the caller, which does not even know if callee tried to enable it. Fix both by restructuring the flow in

[Intel-gfx] [PATCH 1/2] drm/i915: Enable THP on Icelake and beyond

2022-04-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We have a statement from HW designers that the GPU read regression when using 2M pages was fixed from Icelake onwards, which was also confirmed by bencharking Eero did last year: """ When IOMMU is disabled, enabling THP causes following perf changes on TGL-H (GT1): 10-1

Re: [Intel-gfx] [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Mauro Carvalho Chehab
HI Greg, Em Fri, 29 Apr 2022 10:30:33 +0200 Greg KH escreveu: > On Fri, Apr 29, 2022 at 09:07:57AM +0100, Mauro Carvalho Chehab wrote: > > Hi Daniel, > > > > Em Fri, 29 Apr 2022 09:54:10 +0200 > > Daniel Vetter escreveu: > > > > > On Fri, Apr 29, 2022 at 07:31:15AM +0100, Mauro Carvalho Che

Re: [Intel-gfx] [PATCH 0/1] Replace shmem memory region and object backend with TTM

2022-04-29 Thread Tvrtko Ursulin
On 27/04/2022 12:34, Adrian Larumbe wrote: This patch is an attempt at eliminating the old shmem memory region and GEM object backend, in favour of a TTM-based one that is able to manage objects placed on both system and local memory. Known issues: Many GPU hungs in machines of GEN <= 5. My a

Re: [Intel-gfx] [PATCH 1/1] drm/i915/guc: Convert ct buffer to iosys_map

2022-04-29 Thread Balasubramani Vivekanandan
On 28.04.2022 19:43, Siva Mullati wrote: > > On 14/04/22 17:41, Balasubramani Vivekanandan wrote: > > On 04.04.2022 15:01, Mullati Siva wrote: > >> From: Siva Mullati > >> > >> Convert CT commands and descriptors to use iosys_map rather > >> than plain pointer and save it in the intel_guc_ct_buff

[Intel-gfx] ✓ Fi.CI.IGT: success for Let userspace know when snd-hda-intel needs i915

2022-04-29 Thread Patchwork
== Series Details == Series: Let userspace know when snd-hda-intel needs i915 URL : https://patchwork.freedesktop.org/series/103315/ State : success == Summary == CI Bug Log - changes from CI_DRM_11550_full -> Patchwork_103315v1_full Summar

Re: [Intel-gfx] [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Greg KH
On Fri, Apr 29, 2022 at 09:07:57AM +0100, Mauro Carvalho Chehab wrote: > Hi Daniel, > > Em Fri, 29 Apr 2022 09:54:10 +0200 > Daniel Vetter escreveu: > > > On Fri, Apr 29, 2022 at 07:31:15AM +0100, Mauro Carvalho Chehab wrote: > > > Sometimes, device drivers are bound using indirect references, >

Re: [Intel-gfx] [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Mauro Carvalho Chehab
Hi Daniel, Em Fri, 29 Apr 2022 09:54:10 +0200 Daniel Vetter escreveu: > On Fri, Apr 29, 2022 at 07:31:15AM +0100, Mauro Carvalho Chehab wrote: > > Sometimes, device drivers are bound using indirect references, > > which is not visible when looking at /proc/modules or lsmod. > > > > Add a functi

Re: [Intel-gfx] [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Daniel Vetter
On Fri, Apr 29, 2022 at 07:31:15AM +0100, Mauro Carvalho Chehab wrote: > Sometimes, device drivers are bound using indirect references, > which is not visible when looking at /proc/modules or lsmod. > > Add a function to allow setting up module references for such > cases. > > Reviewed-by: Dan Wi

[Intel-gfx] ✓ Fi.CI.BAT: success for Let userspace know when snd-hda-intel needs i915

2022-04-29 Thread Patchwork
== Series Details == Series: Let userspace know when snd-hda-intel needs i915 URL : https://patchwork.freedesktop.org/series/103315/ State : success == Summary == CI Bug Log - changes from CI_DRM_11550 -> Patchwork_103315v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Let userspace know when snd-hda-intel needs i915

2022-04-29 Thread Patchwork
== Series Details == Series: Let userspace know when snd-hda-intel needs i915 URL : https://patchwork.freedesktop.org/series/103315/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.