[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: avoid concurrent writes to aux_inv (rev7)

2022-03-17 Thread Patchwork
== Series Details == Series: drm/i915: avoid concurrent writes to aux_inv (rev7) URL : https://patchwork.freedesktop.org/series/100772/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11380 -> Patchwork_22606 Summary ---

[Intel-gfx] [PATCH v12 01/13] drm/i915/guc: Update GuC ADS size for error capture lists

2022-03-17 Thread Alan Previn
Update GuC ADS size allocation to include space for the lists of error state capture register descriptors. Then, populate GuC ADS with the lists of registers we want GuC to report back to host on engine reset events. This list should include global, engine-class and engine-instance registers for e

[Intel-gfx] [PATCH v12 08/13] drm/i915/guc: Add capture region into intel_guc_log

2022-03-17 Thread Alan Previn
GuC log buffer regions for debug-log-events, crash-dumps and error-state-capture are all part of a single bo allocation that also includes the guc_log_buffer_state structures. Now that we support it, increase the size allocation for error-capture. Since the error-capture region is accessed at non-

[Intel-gfx] [PATCH v12 04/13] drm/i915/guc: Add DG2 registers for GuC error state capture.

2022-03-17 Thread Alan Previn
Add additional DG2 registers for GuC error state capture. Signed-off-by: Alan Previn Reviewed-by: Umesh Nerlige Ramappa --- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 80 ++- 1 file changed, 77 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc

[Intel-gfx] [PATCH v12 09/13] drm/i915/guc: Check sizing of guc_capture output

2022-03-17 Thread Alan Previn
Add intel_guc_capture_output_min_size_est function to provide a reasonable minimum size for error-capture region before allocating the shared buffer. Signed-off-by: Alan Previn Reviewed-by: Matthew Brost --- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 48 +++ .../gpu/drm/i91

[Intel-gfx] [PATCH v12 05/13] drm/i915/guc: Add Gen9 registers for GuC error state capture.

2022-03-17 Thread Alan Previn
Abstract out a Gen9 register list as the default for all other platforms we don't yet formally support GuC submission on. Signed-off-by: Alan Previn Reviewed-by: Umesh Nerlige Ramappa --- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 82 +-- 1 file changed, 59 insertions(+), 2

[Intel-gfx] [PATCH v12 07/13] drm/i915/guc: Update GuC-log relay function names

2022-03-17 Thread Alan Previn
For the sake of better code readibility, change previous relay logging function names with "capture_logs" to "copy_debug_logs" to differentiate from error capture functions that will use a different region of the same buffer. Signed-off-by: Alan Previn Reviewed-by: Matthew Brost --- drivers/gpu

[Intel-gfx] [PATCH v12 02/13] drm/i915/guc: Add XE_LP static registers for GuC error capture.

2022-03-17 Thread Alan Previn
Add device specific tables and register lists to cover different engines class types for GuC error state capture for XE_LP products. Signed-off-by: Alan Previn Reviewed-by: Umesh Nerlige Ramappa --- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 116 ++ drivers/gpu/drm/i915/gt/

[Intel-gfx] [PATCH v12 06/13] drm/i915/guc: Add GuC's error state capture output structures.

2022-03-17 Thread Alan Previn
Add GuC's error capture output structures and definitions as how they would appear in GuC log buffer's error capture subregion after an error state capture G2H event notification. Signed-off-by: Alan Previn Reviewed-by: Matthew Brost --- drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h | 47 ++

[Intel-gfx] [PATCH v12 00/13] Add GuC Error Capture Support

2022-03-17 Thread Alan Previn
This series: 1. Enables support of GuC to report error-state-capture using a list of MMIO registers the driver registers and GuC will dump, log and notify right before a GuC triggered engine-reset event. 2. Updates the ADS blob creation to register said lists of global, engi

[Intel-gfx] [PATCH v12 03/13] drm/i915/guc: Add XE_LP steered register lists support

2022-03-17 Thread Alan Previn
Add the ability for runtime allocation and freeing of steered register list extentions that depend on the detected HW config fuses. Signed-off-by: Alan Previn Reviewed-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h | 9 + .../gpu/drm/i915/gt/uc/intel_guc_capture.c

[Intel-gfx] [PATCH v12 10/13] drm/i915/guc: Extract GuC error capture lists on G2H notification.

2022-03-17 Thread Alan Previn
- Upon the G2H Notify-Err-Capture event, parse through the GuC Log Buffer (error-capture-subregion) and generate one or more capture-nodes. A single node represents a single "engine- instance-capture-dump" and contains at least 3 register lists: global, engine-class and engine-instance. An

[Intel-gfx] [PATCH v12 11/13] drm/i915/guc: Pre-allocate output nodes for extraction

2022-03-17 Thread Alan Previn
In the rare but possible scenario where we are in the midst of multiple GuC error-capture (and engine reset) events and the user also triggers a forced full GT reset or the internal watchdog triggers the same, intel_guc_submission_reset_prepare's call to flush_work(&guc->ct.requests.worker) can cau

[Intel-gfx] [PATCH v12 12/13] drm/i915/guc: Plumb GuC-capture into gpu_coredump

2022-03-17 Thread Alan Previn
Add a flags parameter through all of the coredump creation functions. Add a bitmask flag to indicate if the top level gpu_coredump event is triggered in response to a GuC context reset notification. Using that flag, ensure all coredump functions that read or print mmio-register values related to w

[Intel-gfx] [PATCH v12 13/13] drm/i915/guc: Print the GuC error capture output register list.

2022-03-17 Thread Alan Previn
Print the GuC captured error state register list (string names and values) when gpu_coredump_state printout is invoked via the i915 debugfs for flushing the gpu error-state that was captured prior. Since GuC could have reported multiple engine register dumps in a single notification event, parse t

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: avoid concurrent writes to aux_inv (rev6)

2022-03-17 Thread Patchwork
== Series Details == Series: drm/i915: avoid concurrent writes to aux_inv (rev6) URL : https://patchwork.freedesktop.org/series/100772/ State : success == Summary == CI Bug Log - changes from CI_DRM_11380 -> Patchwork_22605 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for Introduce multitile support

2022-03-17 Thread Patchwork
== Series Details == Series: Introduce multitile support URL : https://patchwork.freedesktop.org/series/101520/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11379_full -> Patchwork_22603_full Summary --- **FAILURE**

[Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

2022-03-17 Thread fei . yang
From: Fei Yang GPU hangs have been observed when multiple engines write to the same aux_inv register at the same time. To avoid this each engine should only invalidate its own auxiliary table. The function gen12_emit_flush_xcs() currently invalidate the auxiliary table for all engines because the

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: avoid concurrent writes to aux_inv (rev6)

2022-03-17 Thread Patchwork
== Series Details == Series: drm/i915: avoid concurrent writes to aux_inv (rev6) URL : https://patchwork.freedesktop.org/series/100772/ State : warning == Summary == $ dim checkpatch origin/drm-tip d9e840b8dd7a drm/i915: avoid concurrent writes to aux_inv -:81: CHECK:BRACES: braces {} should b

[Intel-gfx] ✓ Fi.CI.BAT: success for i915 writeback private framework (rev4)

2022-03-17 Thread Patchwork
== Series Details == Series: i915 writeback private framework (rev4) URL : https://patchwork.freedesktop.org/series/101425/ State : success == Summary == CI Bug Log - changes from CI_DRM_11380 -> Patchwork_22604 Summary --- **SUCCESS

[Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

2022-03-17 Thread fei . yang
From: Fei Yang GPU hangs have been observed when multiple engines write to the same aux_inv register at the same time. To avoid this each engine should only invalidate its own auxiliary table. The function gen12_emit_flush_xcs() currently invalidate the auxiliary table for all engines because the

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dg2: Add preemption changes for Wa_14015141709 (rev2)

2022-03-17 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add preemption changes for Wa_14015141709 (rev2) URL : https://patchwork.freedesktop.org/series/101023/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11379_full -> Patchwork_22602_full =

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915 writeback private framework (rev4)

2022-03-17 Thread Patchwork
== Series Details == Series: i915 writeback private framework (rev4) URL : https://patchwork.freedesktop.org/series/101425/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915 writeback private framework (rev4)

2022-03-17 Thread Patchwork
== Series Details == Series: i915 writeback private framework (rev4) URL : https://patchwork.freedesktop.org/series/101425/ State : warning == Summary == $ dim checkpatch origin/drm-tip 224406362f12 drm/i915: Creating writeback pipeline to bypass drm_writeback framework -:52: WARNING:FILE_PAT

[Intel-gfx] [RFC PATCH v2 3/3] drm/i915: Enabling WD Transcoder

2022-03-17 Thread Suraj Kandpal
Adding support for writeback transcoder to start capturing frames using interrupt mechanism Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_acpi.c | 1 + drivers/gpu/drm/i915/display/intel_display.c | 89 +- drive

[Intel-gfx] [RFC PATCH v2 2/3] drm/i915: Define WD trancoder for i915

2022-03-17 Thread Suraj Kandpal
Adding WD Types, WD transcoder to enum list and WD Transcoder offsets Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_display.h | 6 ++ drivers/gpu/drm/i915/display/intel_display_types.h | 1 + drivers/gpu/drm/i915/i915_reg.h| 2 ++ 3 files chang

[Intel-gfx] [RFC PATCH v2 1/3] drm/i915: Creating writeback pipeline to bypass drm_writeback framework

2022-03-17 Thread Suraj Kandpal
Changes to create a i915 private pipeline to enable the WD transcoder without relying on the current drm_writeback framework. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/Makefile | 1 + .../drm/i915/display/intel_display_types.h| 4 + .../gpu/drm/i915/display/in

[Intel-gfx] ✓ Fi.CI.BAT: success for Introduce multitile support

2022-03-17 Thread Patchwork
== Series Details == Series: Introduce multitile support URL : https://patchwork.freedesktop.org/series/101520/ State : success == Summary == CI Bug Log - changes from CI_DRM_11379 -> Patchwork_22603 Summary --- **SUCCESS** No reg

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dg2: Add preemption changes for Wa_14015141709 (rev2)

2022-03-17 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add preemption changes for Wa_14015141709 (rev2) URL : https://patchwork.freedesktop.org/series/101023/ State : success == Summary == CI Bug Log - changes from CI_DRM_11379 -> Patchwork_22602 Summa

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Introduce multitile support

2022-03-17 Thread Patchwork
== Series Details == Series: Introduce multitile support URL : https://patchwork.freedesktop.org/series/101520/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce multitile support

2022-03-17 Thread Patchwork
== Series Details == Series: Introduce multitile support URL : https://patchwork.freedesktop.org/series/101520/ State : warning == Summary == $ dim checkpatch origin/drm-tip c8d744572c07 drm/i915: Rename INTEL_REGION_LMEM with INTEL_REGION_LMEM_0 bccf33639b42 drm/i915/gt: add gt_is_root() help

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/bios: Rework BDB block handling (rev4)

2022-03-17 Thread Patchwork
== Series Details == Series: drm/i915/bios: Rework BDB block handling (rev4) URL : https://patchwork.freedesktop.org/series/101496/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11378_full -> Patchwork_22601_full Summary --

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dg2: Add preemption changes for Wa_14015141709 (rev2)

2022-03-17 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add preemption changes for Wa_14015141709 (rev2) URL : https://patchwork.freedesktop.org/series/101023/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dg2: Add preemption changes for Wa_14015141709 (rev2)

2022-03-17 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add preemption changes for Wa_14015141709 (rev2) URL : https://patchwork.freedesktop.org/series/101023/ State : warning == Summary == $ dim checkpatch origin/drm-tip 432adfb1abe5 drm/i915/dg2: Add preemption changes for Wa_14015141709 -:48: CHECK:MACR

[Intel-gfx] [PATCH v6 7/7] drm/i915/gt: Adding new sysfs frequency attributes

2022-03-17 Thread Andi Shyti
From: Sujaritha Sundaresan This patch adds the following new sysfs frequency attributes: - punit_req_freq_mhz - throttle_reason_status - throttle_reason_pl1 - throttle_reason_pl2 - throttle_reason_pl4 - throttle_reason_thermal - throttle_re

[Intel-gfx] ✓ Fi.CI.IGT: success for Add GuC Error Capture Support

2022-03-17 Thread Patchwork
== Series Details == Series: Add GuC Error Capture Support URL : https://patchwork.freedesktop.org/series/101503/ State : success == Summary == CI Bug Log - changes from CI_DRM_11378_full -> Patchwork_22598_full Summary --- **SUCCESS

[Intel-gfx] [PATCH v6 6/7] drm/i915/gt: Create per-tile RPS sysfs interfaces

2022-03-17 Thread Andi Shyti
Now tiles have their own sysfs interfaces under the gt/ directory. Because RPS is a property that can be configured on a tile basis, then each tile should have its own interface The new sysfs structure will have a similar layout for the 4 tile case: /sys/.../card0 ├── gt │   ├──

[Intel-gfx] [PATCH v6 5/7] drm/i915/gt: Create per-tile RC6 sysfs interface

2022-03-17 Thread Andi Shyti
Now tiles have their own sysfs interfaces under the gt/ directory. Because RC6 is a property that can be configured on a tile basis, then each tile should have its own interface The new sysfs structure will have a similar layout for the 4 tile case: /sys/.../card0 ├── gt │   ├──

[Intel-gfx] [PATCH v6 4/7] drm/i915/gt: create per-tile sysfs interface

2022-03-17 Thread Andi Shyti
Now that we have tiles we want each of them to have its own interface. A directory "gt/" is created under "cardN/" that will contain as many diroctories as the tiles. In the coming patches tile related interfaces will be added. For now the sysfs gt structure simply has an id interface related to t

[Intel-gfx] [PATCH v6 3/7] drm/i915: Prepare for multiple GTs

2022-03-17 Thread Andi Shyti
From: Tvrtko Ursulin On a multi-tile platform, each tile has its own registers + GGTT space, and BAR 0 is extended to cover all of them. Up to four GTs are supported in i915->gt[], with slot zero shadowing the existing i915->gt0 to enable source compatibility with legacy driver paths. A for_each

[Intel-gfx] [PATCH v6 2/7] drm/i915/gt: add gt_is_root() helper

2022-03-17 Thread Andi Shyti
The "gt_is_root(struct intel_gt *gt)" helper return true if the gt is the root gt, which means that its id is 0. Return false otherwise. Suggested-by: Michal Wajdeczko Signed-off-by: Andi Shyti Reviewed-by: Michal Wajdeczko Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/i915/gt/intel_gt.h | 5

[Intel-gfx] [PATCH v6 1/7] drm/i915: Rename INTEL_REGION_LMEM with INTEL_REGION_LMEM_0

2022-03-17 Thread Andi Shyti
With the upcoming multitile support each tile will have its own local memory. Mark the current LMEM with the suffix '0' to emphasise that it belongs to the root tile. Suggested-by: Michal Wajdeczko Signed-off-by: Andi Shyti Reviewed-by: Michal Wajdeczko Reviewed-by: Andrzej Hajda --- drivers/

[Intel-gfx] [PATCH v6 0/7] Introduce multitile support

2022-03-17 Thread Andi Shyti
Hi, This is the second series that prepares i915 to host multitile platforms. It introduces the for_each_gt() macro that loops over the tiles to perform per gt actions. This patch is a combination of two patches developed originally by Abdiel, who introduced some refactoring during probe, and the

[Intel-gfx] [PATCH CI] drm/i915/dg2: Add preemption changes for Wa_14015141709

2022-03-17 Thread Matt Roper
From: Akeem G Abodunrin Starting with DG2, preemption can no longer be controlled using userspace on a per-context basis. Instead, the hardware only allows us to enable or disable preemption in a global, system-wide basis. Also, we lose the ability to specify the preemption granularity (such as

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dmc: cleanups

2022-03-17 Thread Patchwork
== Series Details == Series: drm/i915/dmc: cleanups URL : https://patchwork.freedesktop.org/series/101499/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11378_full -> Patchwork_22597_full Summary --- **FAILURE** S

Re: [Intel-gfx] linux-next: manual merge of the drm tree with the drm-misc-fixes tree

2022-03-17 Thread Stephen Rothwell
Hi all, On Fri, 18 Mar 2022 11:55:44 +1100 Stephen Rothwell wrote: > > Today's linux-next merge of the drm tree got a conflict in: > > drivers/gpu/drm/bridge/Kconfig > > between commit: > > 3c3384050d68 ("drm: Don't make DRM_PANEL_BRIDGE dependent on > DRM_KMS_HELPERS") > > from the drm

[Intel-gfx] linux-next: manual merge of the drm tree with the drm-misc-fixes tree

2022-03-17 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/bridge/Kconfig between commit: 3c3384050d68 ("drm: Don't make DRM_PANEL_BRIDGE dependent on DRM_KMS_HELPERS") from the drm-misc-fixes tree and commit: 803abfd8dda5 ("drm: bridge: fix unmet dependency on

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bios: Rework BDB block handling (rev4)

2022-03-17 Thread Patchwork
== Series Details == Series: drm/i915/bios: Rework BDB block handling (rev4) URL : https://patchwork.freedesktop.org/series/101496/ State : success == Summary == CI Bug Log - changes from CI_DRM_11378 -> Patchwork_22601 Summary --- *

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/bios: Rework BDB block handling (rev4)

2022-03-17 Thread Patchwork
== Series Details == Series: drm/i915/bios: Rework BDB block handling (rev4) URL : https://patchwork.freedesktop.org/series/101496/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/bios: Rework BDB block handling (rev4)

2022-03-17 Thread Patchwork
== Series Details == Series: drm/i915/bios: Rework BDB block handling (rev4) URL : https://patchwork.freedesktop.org/series/101496/ State : warning == Summary == $ dim checkpatch origin/drm-tip 72f9ed8364ec drm/i915/bios: Extract struct lvds_lfp_data_ptr_table 8d0061ecd718 drm/i915/bios: Make

[Intel-gfx] [PATCH v2 08/11] drm/i915/bios: Generate LFP data table pointers if the VBT lacks them

2022-03-17 Thread Ville Syrjala
From: Ville Syrjälä Modern VBTs (seem at least on TGL with VBT version 240) no longer contain the LFP data table pointers block (42). We are expecting to have one in order to be able to parse the LFP data block (41), so let's make one up. Since the fp_timing table has variable size we must someh

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bios: Rework BDB block handling (rev3)

2022-03-17 Thread Patchwork
== Series Details == Series: drm/i915/bios: Rework BDB block handling (rev3) URL : https://patchwork.freedesktop.org/series/101496/ State : success == Summary == CI Bug Log - changes from CI_DRM_11378 -> Patchwork_22599 Summary --- *

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [v2,1/2] drm/i915/dg2: Add preemption changes for Wa_14015141709 (rev2)

2022-03-17 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/dg2: Add preemption changes for Wa_14015141709 (rev2) URL : https://patchwork.freedesktop.org/series/101070/ State : failure == Summary == Applying: drm/i915/dg2: Add preemption changes for Wa_14015141709 Applying: drm/i915/d

[Intel-gfx] ✓ Fi.CI.BAT: success for Add GuC Error Capture Support

2022-03-17 Thread Patchwork
== Series Details == Series: Add GuC Error Capture Support URL : https://patchwork.freedesktop.org/series/101503/ State : success == Summary == CI Bug Log - changes from CI_DRM_11378 -> Patchwork_22598 Summary --- **SUCCESS** No r

Re: [Intel-gfx] [PATCH 02/11] drm/i915/bios: Make copies of VBT data blocks

2022-03-17 Thread Ville Syrjälä
On Thu, Mar 17, 2022 at 09:02:46PM +0200, Jani Nikula wrote: > On Thu, 17 Mar 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Make a copy of each VB data block with a guaranteed minimum > > size. The extra (if any) will just be left zeroed. > > *VBT > > > > > This means we don't have

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/bios: Rework BDB block handling (rev3)

2022-03-17 Thread Patchwork
== Series Details == Series: drm/i915/bios: Rework BDB block handling (rev3) URL : https://patchwork.freedesktop.org/series/101496/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/bios: Rework BDB block handling (rev3)

2022-03-17 Thread Patchwork
== Series Details == Series: drm/i915/bios: Rework BDB block handling (rev3) URL : https://patchwork.freedesktop.org/series/101496/ State : warning == Summary == $ dim checkpatch origin/drm-tip f78f0208e580 drm/i915/bios: Extract struct lvds_lfp_data_ptr_table b9aaa74b14b4 drm/i915/bios: Make

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add GuC Error Capture Support

2022-03-17 Thread Patchwork
== Series Details == Series: Add GuC Error Capture Support URL : https://patchwork.freedesktop.org/series/101503/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add GuC Error Capture Support

2022-03-17 Thread Patchwork
== Series Details == Series: Add GuC Error Capture Support URL : https://patchwork.freedesktop.org/series/101503/ State : warning == Summary == $ dim checkpatch origin/drm-tip eaf2d6ffbe31 drm/i915/guc: Update GuC ADS size for error capture lists -:40: WARNING:FILE_PATH_CHANGES: added, moved o

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/sdvo: prefer __packed over __attribute__((packed))

2022-03-17 Thread Patchwork
== Series Details == Series: drm/i915/sdvo: prefer __packed over __attribute__((packed)) URL : https://patchwork.freedesktop.org/series/101497/ State : success == Summary == CI Bug Log - changes from CI_DRM_11376_full -> Patchwork_22596_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: cleanups

2022-03-17 Thread Patchwork
== Series Details == Series: drm/i915/dmc: cleanups URL : https://patchwork.freedesktop.org/series/101499/ State : success == Summary == CI Bug Log - changes from CI_DRM_11378 -> Patchwork_22597 Summary --- **SUCCESS** No regressi

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dmc: cleanups

2022-03-17 Thread Patchwork
== Series Details == Series: drm/i915/dmc: cleanups URL : https://patchwork.freedesktop.org/series/101499/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dmc: cleanups

2022-03-17 Thread Patchwork
== Series Details == Series: drm/i915/dmc: cleanups URL : https://patchwork.freedesktop.org/series/101499/ State : warning == Summary == $ dim checkpatch origin/drm-tip 148ae63a423d drm/i915/dmc: simplify intel_dmc_load_program() conditions f5b3417a7183 drm/i915/dmc: move assert_dmc_loaded() t

[Intel-gfx] [PATCH v2 03/11] drm/i915/bios: Use the copy of the LFP data table always

2022-03-17 Thread Ville Syrjala
From: Ville Syrjälä Currently get_lvds_fp_timing() still returns a pointer to the original data block rather than our copy. Let's convert the data pointer offsets to be relative to the data block rather than the whole BDB. With that we can make get_lvds_fp_timing() return a pointer to the copy.

[Intel-gfx] [PATCH v2 02/11] drm/i915/bios: Make copies of VBT data blocks

2022-03-17 Thread Ville Syrjala
From: Ville Syrjälä Make a copy of each VB data block with a guaranteed minimum size. The extra (if any) will just be left zeroed. This means we don't have to worry about going out of bounds when accessing any of the structure members. Otherwise that could easliy happen if we simply get the vers

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/bios: Rework BDB block handling

2022-03-17 Thread Patchwork
== Series Details == Series: drm/i915/bios: Rework BDB block handling URL : https://patchwork.freedesktop.org/series/101496/ State : success == Summary == CI Bug Log - changes from CI_DRM_11376_full -> Patchwork_22595_full Summary ---

Re: [Intel-gfx] [PATCH 03/11] drm/i915/bios: Use the copy of the LFP data table always

2022-03-17 Thread Ville Syrjälä
On Thu, Mar 17, 2022 at 10:04:13PM +0200, Ville Syrjälä wrote: > On Thu, Mar 17, 2022 at 09:10:37PM +0200, Jani Nikula wrote: > > On Thu, 17 Mar 2022, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Currently get_lvds_fp_timing() still returns a pointer to the original > > > data block

Re: [Intel-gfx] [PATCH 03/11] drm/i915/bios: Use the copy of the LFP data table always

2022-03-17 Thread Ville Syrjälä
On Thu, Mar 17, 2022 at 09:10:37PM +0200, Jani Nikula wrote: > On Thu, 17 Mar 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Currently get_lvds_fp_timing() still returns a pointer to the original > > data block rather than our copy. Let's convert the data pointer offsets > > to be rel

Re: [Intel-gfx] [PATCH 8/8] drm/i915/dmc: split out dmc registers to a separate file

2022-03-17 Thread Lucas De Marchi
On Thu, Mar 17, 2022 at 08:36:20PM +0200, Jani Nikula wrote: Clean up the massive i915_reg.h a bit with this isolated set of registers. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dmc.c | 1 + drivers/gpu/drm/i915/display/intel_dmc_regs.h | 31 +++ driv

Re: [Intel-gfx] [PATCH 7/8] drm/i915/dmc: hide DMC version macros

2022-03-17 Thread Lucas De Marchi
On Thu, Mar 17, 2022 at 08:36:19PM +0200, Jani Nikula wrote: The macros are now only needed within intel_dmc.c, so move them there. Signed-off-by: Jani Nikula Reviewed-by: Lucas De Marchi Lucas De Marchi

Re: [Intel-gfx] [PATCH 6/8] drm/i915/dmc: abstract GPU error state dump

2022-03-17 Thread Lucas De Marchi
On Thu, Mar 17, 2022 at 08:36:18PM +0200, Jani Nikula wrote: Only intel_dmc.c should be accessing dmc details directly. Signed-off-by: Jani Nikula Reviewed-by: Lucas De Marchi Lucas De Marchi

Re: [Intel-gfx] [PATCH 5/8] drm/i915/dmc: don't register DMC debugfs file if there's no DMC

2022-03-17 Thread Lucas De Marchi
On Thu, Mar 17, 2022 at 08:36:17PM +0200, Jani Nikula wrote: Register the DMC debugfs file only on platforms that support DMC. There's no point in having a no-op debugfs file. It seems this would not change much the behavior (fail on open vs fail on read). But the code in igt is suspicious:

Re: [Intel-gfx] [PATCH 4/8] drm/i915/dmc: fix i915_reg_t usage

2022-03-17 Thread Lucas De Marchi
On Thu, Mar 17, 2022 at 08:36:16PM +0200, Jani Nikula wrote: i915_reg_t is supposed to be a somewhat opaque data type, not to be looked inside. Signed-off-by: Jani Nikula Reviewed-by: Lucas De Marchi but maybe also already clean up the remaining one? $ git grep "i915_reg_t.*= *{ *}" drive

[Intel-gfx] ✓ Fi.CI.IGT: success for Add DP MST DSC support to i915

2022-03-17 Thread Patchwork
== Series Details == Series: Add DP MST DSC support to i915 URL : https://patchwork.freedesktop.org/series/101492/ State : success == Summary == CI Bug Log - changes from CI_DRM_11376_full -> Patchwork_22594_full Summary --- **SUCCES

Re: [Intel-gfx] [PATCH 3/8] drm/i915/dmc: move dmc debugfs to intel_dmc.c

2022-03-17 Thread Lucas De Marchi
On Thu, Mar 17, 2022 at 08:36:15PM +0200, Jani Nikula wrote: Continue localizing DMC register and data access to intel_dmc.c. Signed-off-by: Jani Nikula Reviewed-by: Lucas De Marchi Lucas De Marchi

Re: [Intel-gfx] [PATCH 2/8] drm/i915/dmc: move assert_dmc_loaded() to intel_dmc.c

2022-03-17 Thread Lucas De Marchi
On Thu, Mar 17, 2022 at 08:36:14PM +0200, Jani Nikula wrote: Start localizing DMC register and data access to intel_dmc.c. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_power.c | 12 drivers/gpu/drm/i915/display/intel_dmc.c | 11 +++ driv

Re: [Intel-gfx] [PATCH 1/8] drm/i915/dmc: simplify intel_dmc_load_program() conditions

2022-03-17 Thread Lucas De Marchi
On Thu, Mar 17, 2022 at 08:36:13PM +0200, Jani Nikula wrote: intel_dmc_load_program() is only ever called when intel_dmc_has_payload() is true. Move the condition within intel_dmc_load_program() to let it be called directly. Also note that intel_dmc_has_payload() will always return false when HA

Re: [Intel-gfx] [PATCH] drm/i915/display/: Refactor hsw_crtc_enable for bigjoiner cleanup

2022-03-17 Thread Jani Nikula
On Thu, 17 Mar 2022, "Navare, Manasi" wrote: > On Thu, Mar 17, 2022 at 11:28:03AM -0700, Navare, Manasi wrote: >> On Thu, Mar 17, 2022 at 05:35:43PM +0200, Jani Nikula wrote: >> > On Wed, 16 Mar 2022, "Navare, Manasi" wrote: >> > > On Wed, Mar 16, 2022 at 09:48:17AM +0200, Jani Nikula wrote: >> >

Re: [Intel-gfx] [PATCH] drm/i915/display/: Refactor hsw_crtc_enable for bigjoiner cleanup

2022-03-17 Thread Ville Syrjälä
On Thu, Mar 17, 2022 at 12:05:47PM -0700, Navare, Manasi wrote: > On Thu, Mar 17, 2022 at 08:52:52PM +0200, Ville Syrjälä wrote: > > On Tue, Mar 15, 2022 at 04:38:56PM -0700, Manasi Navare wrote: > > > This patch abstracts pieces of hsw_crtc_enable corresponding to different > > > Bspec enable sequ

Re: [Intel-gfx] [PATCH 03/11] drm/i915/bios: Use the copy of the LFP data table always

2022-03-17 Thread Jani Nikula
On Thu, 17 Mar 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently get_lvds_fp_timing() still returns a pointer to the original > data block rather than our copy. Let's convert the data pointer offsets > to be relative to the data block rather than the whole BDB. With that > we can mak

Re: [Intel-gfx] [PATCH] drm/i915/display/: Refactor hsw_crtc_enable for bigjoiner cleanup

2022-03-17 Thread Navare, Manasi
On Thu, Mar 17, 2022 at 08:52:52PM +0200, Ville Syrjälä wrote: > On Tue, Mar 15, 2022 at 04:38:56PM -0700, Manasi Navare wrote: > > This patch abstracts pieces of hsw_crtc_enable corresponding to different > > Bspec enable sequence steps into separate functions. > > This helps to call them in a spe

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/sdvo: prefer __packed over __attribute__((packed))

2022-03-17 Thread Patchwork
== Series Details == Series: drm/i915/sdvo: prefer __packed over __attribute__((packed)) URL : https://patchwork.freedesktop.org/series/101497/ State : success == Summary == CI Bug Log - changes from CI_DRM_11376 -> Patchwork_22596 Summary

Re: [Intel-gfx] [PATCH 02/11] drm/i915/bios: Make copies of VBT data blocks

2022-03-17 Thread Jani Nikula
On Thu, 17 Mar 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Make a copy of each VB data block with a guaranteed minimum > size. The extra (if any) will just be left zeroed. *VBT > > This means we don't have to worry about going out of bounds > when accessing any of the structure members

[Intel-gfx] [PATCH v11 11/13] drm/i915/guc: Pre-allocate output nodes for extraction

2022-03-17 Thread Alan Previn
In the rare but possible scenario where we are in the midst of multiple GuC error-capture (and engine reset) events and the user also triggers a forced full GT reset or the internal watchdog triggers the same, intel_guc_submission_reset_prepare's call to flush_work(&guc->ct.requests.worker) can cau

[Intel-gfx] [PATCH v11 09/13] drm/i915/guc: Check sizing of guc_capture output

2022-03-17 Thread Alan Previn
Add intel_guc_capture_output_min_size_est function to provide a reasonable minimum size for error-capture region before allocating the shared buffer. Signed-off-by: Alan Previn Reviewed-by: Matthew Brost --- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 48 +++ .../gpu/drm/i91

[Intel-gfx] [PATCH v11 06/13] drm/i915/guc: Add GuC's error state capture output structures.

2022-03-17 Thread Alan Previn
Add GuC's error capture output structures and definitions as how they would appear in GuC log buffer's error capture subregion after an error state capture G2H event notification. Signed-off-by: Alan Previn Reviewed-by: Matthew Brost --- drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h | 47 ++

[Intel-gfx] [PATCH v11 07/13] drm/i915/guc: Update GuC-log relay function names

2022-03-17 Thread Alan Previn
For the sake of better code readibility, change previous relay logging function names with "capture_logs" to "copy_debug_logs" to differentiate from error capture functions that will use a different region of the same buffer. Signed-off-by: Alan Previn Reviewed-by: Matthew Brost --- drivers/gpu

[Intel-gfx] [PATCH v11 12/13] drm/i915/guc: Plumb GuC-capture into gpu_coredump

2022-03-17 Thread Alan Previn
Add a flags parameter through all of the coredump creation functions. Add a bitmask flag to indicate if the top level gpu_coredump event is triggered in response to a GuC context reset notification. Using that flag, ensure all coredump functions that read or print mmio-register values related to w

[Intel-gfx] [PATCH v11 13/13] drm/i915/guc: Print the GuC error capture output register list.

2022-03-17 Thread Alan Previn
Print the GuC captured error state register list (string names and values) when gpu_coredump_state printout is invoked via the i915 debugfs for flushing the gpu error-state that was captured prior. Since GuC could have reported multiple engine register dumps in a single notification event, parse t

[Intel-gfx] [PATCH v11 10/13] drm/i915/guc: Extract GuC error capture lists on G2H notification.

2022-03-17 Thread Alan Previn
- Upon the G2H Notify-Err-Capture event, parse through the GuC Log Buffer (error-capture-subregion) and generate one or more capture-nodes. A single node represents a single "engine- instance-capture-dump" and contains at least 3 register lists: global, engine-class and engine-instance. An

[Intel-gfx] [PATCH v11 08/13] drm/i915/guc: Add capture region into intel_guc_log

2022-03-17 Thread Alan Previn
GuC log buffer regions for debug-log-events, crash-dumps and error-state-capture are all part of a single bo allocation that also includes the guc_log_buffer_state structures. Now that we support it, increase the size allocation for error-capture. Since the error-capture region is accessed at non-

[Intel-gfx] [PATCH v11 05/13] drm/i915/guc: Add Gen9 registers for GuC error state capture.

2022-03-17 Thread Alan Previn
Abstract out a Gen9 register list as the default for all other platforms we don't yet formally support GuC submission on. Signed-off-by: Alan Previn Reviewed-by: Umesh Nerlige Ramappa --- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 82 +-- 1 file changed, 59 insertions(+), 2

[Intel-gfx] [PATCH v11 01/13] drm/i915/guc: Update GuC ADS size for error capture lists

2022-03-17 Thread Alan Previn
Update GuC ADS size allocation to include space for the lists of error state capture register descriptors. Then, populate GuC ADS with the lists of registers we want GuC to report back to host on engine reset events. This list should include global, engine-class and engine-instance registers for e

[Intel-gfx] [PATCH v11 02/13] drm/i915/guc: Add XE_LP static registers for GuC error capture.

2022-03-17 Thread Alan Previn
Add device specific tables and register lists to cover different engines class types for GuC error state capture for XE_LP products. Signed-off-by: Alan Previn Reviewed-by: Umesh Nerlige Ramappa --- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 116 ++ drivers/gpu/drm/i915/gt/

[Intel-gfx] [PATCH v11 04/13] drm/i915/guc: Add DG2 registers for GuC error state capture.

2022-03-17 Thread Alan Previn
Add additional DG2 registers for GuC error state capture. Signed-off-by: Alan Previn Reviewed-by: Umesh Nerlige Ramappa --- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 80 ++- 1 file changed, 77 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc

[Intel-gfx] [PATCH v11 03/13] drm/i915/guc: Add XE_LP steered register lists support

2022-03-17 Thread Alan Previn
Add the ability for runtime allocation and freeing of steered register list extentions that depend on the detected HW config fuses. Signed-off-by: Alan Previn Reviewed-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h | 9 + .../gpu/drm/i915/gt/uc/intel_guc_capture.c

[Intel-gfx] [PATCH v11 00/13] Add GuC Error Capture Support

2022-03-17 Thread Alan Previn
This series: 1. Enables support of GuC to report error-state-capture using a list of MMIO registers the driver registers and GuC will dump, log and notify right before a GuC triggered engine-reset event. 2. Updates the ADS blob creation to register said lists of global, engi

Re: [Intel-gfx] [PATCH] drm/i915/display/: Refactor hsw_crtc_enable for bigjoiner cleanup

2022-03-17 Thread Ville Syrjälä
On Tue, Mar 15, 2022 at 04:38:56PM -0700, Manasi Navare wrote: > This patch abstracts pieces of hsw_crtc_enable corresponding to different > Bspec enable sequence steps into separate functions. > This helps to call them in a specific order for bigjoiner master/slave > in a cleaner fashion. > > Cc:

[Intel-gfx] [PATCH 8/8] drm/i915/dmc: split out dmc registers to a separate file

2022-03-17 Thread Jani Nikula
Clean up the massive i915_reg.h a bit with this isolated set of registers. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dmc.c | 1 + drivers/gpu/drm/i915/display/intel_dmc_regs.h | 31 +++ drivers/gpu/drm/i915/gvt/handlers.c | 1 + drivers/gp

[Intel-gfx] [PATCH 7/8] drm/i915/dmc: hide DMC version macros

2022-03-17 Thread Jani Nikula
The macros are now only needed within intel_dmc.c, so move them there. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dmc.c | 4 drivers/gpu/drm/i915/display/intel_dmc.h | 4 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/

  1   2   >