[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Use less in contexts steal guc id test (rev2)

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Use less in contexts steal guc id test (rev2) URL : https://patchwork.freedesktop.org/series/99179/ State : success == Summary == CI Bug Log - changes from CI_DRM_11120 -> Patchwork_22068 Sum

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Don't restart WL for every frequency step (rev2)

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Don't restart WL for every frequency step (rev2) URL : https://patchwork.freedesktop.org/series/99109/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11120_full -> Patchwork_22066_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dg2: Add Wa_18018781329 (rev4)

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add Wa_18018781329 (rev4) URL : https://patchwork.freedesktop.org/series/99128/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11120 -> Patchwork_22067 Summary --- **FAILURE*

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dg2: Add Wa_18018781329 (rev4)

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add Wa_18018781329 (rev4) URL : https://patchwork.freedesktop.org/series/99128/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dg2: Add Wa_18018781329 (rev4)

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add Wa_18018781329 (rev4) URL : https://patchwork.freedesktop.org/series/99128/ State : warning == Summary == $ dim checkpatch origin/drm-tip 68a2eaef0efa drm/i915/dg2: Add Wa_18018781329 -:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit de

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Don't restart WL for every frequency step (rev2)

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Don't restart WL for every frequency step (rev2) URL : https://patchwork.freedesktop.org/series/99109/ State : success == Summary == CI Bug Log - changes from CI_DRM_11120 -> Patchwork_22066

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Use less in contexts steal guc id test

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Use less in contexts steal guc id test URL : https://patchwork.freedesktop.org/series/99179/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11120 -> Patchwork_22065 Summary --

Re: [Intel-gfx] [PATCH] drm/i915/display: Move cdclk checks to atomic check

2022-01-21 Thread Matt Roper
On Tue, Jan 18, 2022 at 08:23:26PM +, Srivatsa, Anusha wrote: > > > > -Original Message- > > From: Jani Nikula > > Sent: Tuesday, December 21, 2021 1:03 AM > > To: Srivatsa, Anusha ; intel- > > g...@lists.freedesktop.org > > Cc: Syrjala, Ville > > Subject: Re: [Intel-gfx] [PATCH] dr

Re: [Intel-gfx] [PATCH] drm/i915/rpl-s: Add stepping info

2022-01-21 Thread Matt Roper
On Fri, Jan 21, 2022 at 11:30:23AM -0800, Anusha Srivatsa wrote: > Add stepping-substepping info in > accordance to BSpec changes. > > Bspec: 53655 > Signed-off-by: Anusha Srivatsa > --- > drivers/gpu/drm/i915/intel_step.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > >

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dg2: Add Wa_18018781329 (rev3)

2022-01-21 Thread Matt Roper
On Fri, Jan 21, 2022 at 04:35:12PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/dg2: Add Wa_18018781329 (rev3) > URL : https://patchwork.freedesktop.org/series/99128/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_8 -> Patchwork_22059 >

Re: [Intel-gfx] [PATCH] drm/i915: nuke local versions of WARN_ON/WARN_ON_ONCE

2022-01-21 Thread Lucas De Marchi
On Fri, Jan 21, 2022 at 03:29:57PM +0200, Jani Nikula wrote: In general, we should avoid redefining kernel macros like this. It can get confusing, and what gets used will depend on whether the header is included or not. Moreover, we should prefer drm_WARN_ON() and drm_WARN_ON_ONCE() anyway, which

[Intel-gfx] ✓ Fi.CI.IGT: success for Fix up request cancel

2022-01-21 Thread Patchwork
== Series Details == Series: Fix up request cancel URL : https://patchwork.freedesktop.org/series/99173/ State : success == Summary == CI Bug Log - changes from CI_DRM_8_full -> Patchwork_22063_full Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: drm device based logging conversions (rev2)

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915/display: drm device based logging conversions (rev2) URL : https://patchwork.freedesktop.org/series/99151/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8 -> Patchwork_22064 Summary

[Intel-gfx] [PATCH] drm/i915/selftests: Use less in contexts steal guc id test

2022-01-21 Thread Matthew Brost
Using more guc_ids in the stealing guc id test has no real benefit. Tearing down lots of contexts all at the same time takes a bit of time due to the H2G / G2H ping-pong with the GuC. On some slower platforms this can cause timeous when flushing the test as the GT isn't idle when this ping-pong is

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/rpl-s: Add stepping info

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915/rpl-s: Add stepping info URL : https://patchwork.freedesktop.org/series/99162/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8_full -> Patchwork_22061_full Summary --- **FAIL

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: drm device based logging conversions (rev2)

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915/display: drm device based logging conversions (rev2) URL : https://patchwork.freedesktop.org/series/99151/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: drm device based logging conversions (rev2)

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915/display: drm device based logging conversions (rev2) URL : https://patchwork.freedesktop.org/series/99151/ State : warning == Summary == $ dim checkpatch origin/drm-tip ef1acbbf5c73 drm/i915/snps: convert to drm device based logging a3babf263cdf drm/i915/p

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix errors when there is no free DSM

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915: Fix errors when there is no free DSM URL : https://patchwork.freedesktop.org/series/99161/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8_full -> Patchwork_22060_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for Fix up request cancel

2022-01-21 Thread Patchwork
== Series Details == Series: Fix up request cancel URL : https://patchwork.freedesktop.org/series/99173/ State : success == Summary == CI Bug Log - changes from CI_DRM_8 -> Patchwork_22063 Summary --- **SUCCESS** No regression

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fix up request cancel

2022-01-21 Thread Patchwork
== Series Details == Series: Fix up request cancel URL : https://patchwork.freedesktop.org/series/99173/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fix up request cancel

2022-01-21 Thread Patchwork
== Series Details == Series: Fix up request cancel URL : https://patchwork.freedesktop.org/series/99173/ State : warning == Summary == $ dim checkpatch origin/drm-tip 14373962443a drm/i915: Add request cancel low level trace point 5fee0be402d5 drm/i915/guc: Cancel requests immediately -:8: WAR

[Intel-gfx] ✗ Fi.CI.BAT: failure for discrete card 64K page support (rev2)

2022-01-21 Thread Patchwork
== Series Details == Series: discrete card 64K page support (rev2) URL : https://patchwork.freedesktop.org/series/99119/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8 -> Patchwork_22062 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for discrete card 64K page support (rev2)

2022-01-21 Thread Patchwork
== Series Details == Series: discrete card 64K page support (rev2) URL : https://patchwork.freedesktop.org/series/99119/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for discrete card 64K page support (rev2)

2022-01-21 Thread Patchwork
== Series Details == Series: discrete card 64K page support (rev2) URL : https://patchwork.freedesktop.org/series/99119/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9c4bfcca2ca8 drm/i915: add needs_compact_pt flag 5a250a5f13c2 drm/i915: enforce min GTT alignment for discrete

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/rpl-s: Add stepping info

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915/rpl-s: Add stepping info URL : https://patchwork.freedesktop.org/series/99162/ State : success == Summary == CI Bug Log - changes from CI_DRM_8 -> Patchwork_22061 Summary --- **SUCCESS** N

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Don't check CT descriptor status before CT write / read

2022-01-21 Thread Matthew Brost
On Fri, Jan 21, 2022 at 09:28:46AM +0200, Jani Nikula wrote: > On Thu, 20 Jan 2022, Matthew Brost wrote: > > Don't check CT descriptor status, unless CONFIG_DRM_I915_DEBUG_GUC is > > set, before CT write / read as this could result in a read across the > > PCIe bus thus adding latency to every CT

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/rpl-s: Add stepping info

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915/rpl-s: Add stepping info URL : https://patchwork.freedesktop.org/series/99162/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9ecaf578e456 drm/i915/rpl-s: Add stepping info -:33: CHECK:LINE_SPACING: Please don't use multiple blank lines #33:

[Intel-gfx] [PATCH 2/2] drm/i915/guc: Cancel requests immediately

2022-01-21 Thread Matthew Brost
Change the preemption timeout to the smallest possible value (1 us) when disabling scheduling to cancel a request and restore it after cancelation. This not only cancels the request as fast as possible, it fixes a bug where the preemption timeout is 0 which results in the schedule disable hanging f

[Intel-gfx] [PATCH 1/2] drm/i915: Add request cancel low level trace point

2022-01-21 Thread Matthew Brost
Add request cancel trace point guarded by CONFIG_DRM_I915_LOW_LEVEL_TRACEPOINT. Signed-off-by: Matthew Brost --- drivers/gpu/drm/i915/gt/intel_context.h | 1 + drivers/gpu/drm/i915/i915_trace.h | 10 ++ 2 files changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_

[Intel-gfx] [PATCH 0/2] Fix up request cancel

2022-01-21 Thread Matthew Brost
Fix request cancellation + add request cancel low level trace point. Signed-off-by: Matthew Brost Matthew Brost (2): drm/i915: Add request cancel low level trace point drm/i915/guc: Cancel requests immediately drivers/gpu/drm/i915/gt/intel_context.h | 1 + drivers/gpu/drm/i915/gt/in

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix errors when there is no free DSM

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915: Fix errors when there is no free DSM URL : https://patchwork.freedesktop.org/series/99161/ State : success == Summary == CI Bug Log - changes from CI_DRM_8 -> Patchwork_22060 Summary --- **W

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix errors when there is no free DSM

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915: Fix errors when there is no free DSM URL : https://patchwork.freedesktop.org/series/99161/ State : warning == Summary == $ dim checkpatch origin/drm-tip a3097f607fae drm/i915: Fix errors when there is no free DSM -:20: WARNING:COMMIT_LOG_LONG_LINE: Possib

Re: [Intel-gfx] [PATCH] drm/i915: Fix errors when there is no free DSM

2022-01-21 Thread Ville Syrjälä
On Fri, Jan 21, 2022 at 11:24:50AM -0800, José Roberto de Souza wrote: > Part of DSM(data stolen memory) is reserved for HW functions and GUC > and in some platform this reserved block takes the whole DSM leaving > no memory to allocated by i915_gem_object_create_stolen() and friends. > > In such

[Intel-gfx] [PATCH v4 4/5] drm/i915: add gtt misalignment test

2022-01-21 Thread Robert Beckett
add test to check handling of misaligned offsets and sizes v4: * remove spurious blank lines * explicitly cast intel_region_id to intel_memory_type in misaligned_pin Reported-by: kernel test robot Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c |

[Intel-gfx] [PATCH v4 3/5] drm/i915: support 64K GTT pages for discrete cards

2022-01-21 Thread Robert Beckett
From: Matthew Auld discrete cards optimise 64K GTT pages for local-memory, since everything should be allocated at 64K granularity. We say goodbye to sparse entries, and instead get a compact 256B page-table for 64K pages, which should be more cache friendly. 4K pages for local-memory are no long

[Intel-gfx] [PATCH v4 5/5] drm/i915/uapi: document behaviour for DG2 64K support

2022-01-21 Thread Robert Beckett
From: Matthew Auld On discrete platforms like DG2, we need to support a minimum page size of 64K when dealing with device local-memory. This is quite tricky for various reasons, so try to document the new implicit uapi for this. v3: fix typos and less emphasis v2: Fixed suggestions on formatting

[Intel-gfx] [PATCH v4 0/5] discrete card 64K page support

2022-01-21 Thread Robert Beckett
This series continues support for 64K pages for discrete cards. It supersedes the 64K patches from https://patchwork.freedesktop.org/series/95686/#rev4 Changes since that series: - set min alignment for DG2 to 2MB in i915_address_space_init - replace coloring with simpler 2MB VA alignment for lme

[Intel-gfx] [PATCH v4 2/5] drm/i915: enforce min GTT alignment for discrete cards

2022-01-21 Thread Robert Beckett
From: Matthew Auld For local-memory objects we need to align the GTT addresses to 64K, both for the ppgtt and ggtt. We need to support vm->min_alignment > 4K, depending on the vm itself and the type of object we are inserting. With this in mind update the GTT selftests to take this into account.

[Intel-gfx] [PATCH v4 1/5] drm/i915: add needs_compact_pt flag

2022-01-21 Thread Robert Beckett
From: Ramalingam C Add a new platform flag, needs_compact_pt, to mark the requirement of compact pt layout support for the ppGTT when using 64K GTT pages. With this flag has_64k_pages will only indicate requirement of 64K GTT page sizes or larger for device local memory access. Suggested-by: Ma

[Intel-gfx] [PATCH] drm/i915/rpl-s: Add stepping info

2022-01-21 Thread Anusha Srivatsa
Add stepping-substepping info in accordance to BSpec changes. Bspec: 53655 Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/intel_step.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_step.c b/drivers/gpu/drm/i915/intel_step.c i

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: nuke local versions of WARN_ON/WARN_ON_ONCE

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915: nuke local versions of WARN_ON/WARN_ON_ONCE URL : https://patchwork.freedesktop.org/series/99155/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8_full -> Patchwork_22058_full Summa

[Intel-gfx] [PATCH] drm/i915: Fix errors when there is no free DSM

2022-01-21 Thread José Roberto de Souza
Part of DSM(data stolen memory) is reserved for HW functions and GUC and in some platform this reserved block takes the whole DSM leaving no memory to allocated by i915_gem_object_create_stolen() and friends. In such cases i915_gem_init_stolen() was not calling drm_mm_init() and returning 0, causi

Re: [Intel-gfx] [PATCH 2/3] drm/i915/guc: Add work queue to trigger a GT reset

2022-01-21 Thread John Harrison
On 1/20/2022 20:31, Matthew Brost wrote: The G2H handler needs to be flushed during a GT reset but a G2H indicating engine reset failure can trigger a GT reset. Add a worker to trigger the GT rest when an engine reset failure is received to break this circular dependency. v2: (John Harrison)

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915: Reject bigjoiner if the pipe doesn't support it

2022-01-21 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Reject bigjoiner if the pipe doesn't support it URL : https://patchwork.freedesktop.org/series/99152/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8_full -> Patchwork_22057_full ===

Re: [Intel-gfx] [PATCH 1/3] drm: add writeback pointers to drm_connector

2022-01-21 Thread Abhinav Kumar
+ laurent on this Hi Suraj On 1/11/2022 2:17 AM, Kandpal, Suraj wrote: Changing drm_connector and drm_encoder feilds to pointers in drm_writeback_connector as the elements of struct drm_writeback_connector are: struct drm_writeback_connector { struct drm_connector base; struct d

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Clean up pre-skl primary plane registers

2022-01-21 Thread Souza, Jose
On Fri, 2022-01-21 at 13:30 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Use REG_BIT() & co. for the pre-skl primary plane registers. > Also give everything a consistent namespace. > > v2: s/DSP/DISP/ to avoid confusion (José) > Use DISP_WIDTH rather than DISP_POS_X for DSPSIZE (Jos

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: drm device based logging conversions

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915/display: drm device based logging conversions URL : https://patchwork.freedesktop.org/series/99151/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8_full -> Patchwork_22056_full Summ

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dg2: Add Wa_18018781329 (rev3)

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add Wa_18018781329 (rev3) URL : https://patchwork.freedesktop.org/series/99128/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8 -> Patchwork_22059 Summary --- **FAILURE*

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Reject bigjoiner if the pipe doesn't support it

2022-01-21 Thread Ville Syrjälä
On Fri, Jan 21, 2022 at 05:55:24PM +0200, Ville Syrjälä wrote: > On Fri, Jan 21, 2022 at 04:03:09PM +0200, Jani Nikula wrote: > > On Fri, 21 Jan 2022, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Check that our crtc can in fact be the bigjoiner master before > > > we let the modeset

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dg2: Add Wa_18018781329 (rev3)

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add Wa_18018781329 (rev3) URL : https://patchwork.freedesktop.org/series/99128/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dg2: Add Wa_18018781329 (rev3)

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add Wa_18018781329 (rev3) URL : https://patchwork.freedesktop.org/series/99128/ State : warning == Summary == $ dim checkpatch origin/drm-tip 66b0cf558d66 drm/i915/dg2: Add Wa_18018781329 -:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit de

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Futher optimize plane updates

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915: Futher optimize plane updates URL : https://patchwork.freedesktop.org/series/99149/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8_full -> Patchwork_22055_full Summary ---

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Reject bigjoiner if the pipe doesn't support it

2022-01-21 Thread Ville Syrjälä
On Fri, Jan 21, 2022 at 04:03:09PM +0200, Jani Nikula wrote: > On Fri, 21 Jan 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Check that our crtc can in fact be the bigjoiner master before > > we let the modeset proceed with bigjoiner enabled. > > > > Signed-off-by: Ville Syrjälä > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: nuke local versions of WARN_ON/WARN_ON_ONCE

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915: nuke local versions of WARN_ON/WARN_ON_ONCE URL : https://patchwork.freedesktop.org/series/99155/ State : success == Summary == CI Bug Log - changes from CI_DRM_8 -> Patchwork_22058 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: nuke local versions of WARN_ON/WARN_ON_ONCE

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915: nuke local versions of WARN_ON/WARN_ON_ONCE URL : https://patchwork.freedesktop.org/series/99155/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Reject bigjoiner if the pipe doesn't support it

2022-01-21 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Reject bigjoiner if the pipe doesn't support it URL : https://patchwork.freedesktop.org/series/99152/ State : success == Summary == CI Bug Log - changes from CI_DRM_8 -> Patchwork_22057 =

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use per-device debugs for bigjoiner stuff

2022-01-21 Thread Jani Nikula
On Fri, 21 Jan 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Specify which device we're talking about when spewing > bigjoiner debugs. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_display.c | 21 +++- > 1 file cha

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Simplify intel_dsc_source_support()

2022-01-21 Thread Jani Nikula
On Fri, 21 Jan 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > We can simplify the icl check in intel_dsc_source_support() > by noting that the only case when DSC is not supported is when > using transcoder A. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Reject bigjoiner if the pipe doesn't support it

2022-01-21 Thread Jani Nikula
On Fri, 21 Jan 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Check that our crtc can in fact be the bigjoiner master before > we let the modeset proceed with bigjoiner enabled. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_display.c | 16 >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: drm device based logging conversions

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915/display: drm device based logging conversions URL : https://patchwork.freedesktop.org/series/99151/ State : success == Summary == CI Bug Log - changes from CI_DRM_8 -> Patchwork_22056 Summary --

[Intel-gfx] [PATCH] drm/i915: nuke local versions of WARN_ON/WARN_ON_ONCE

2022-01-21 Thread Jani Nikula
In general, we should avoid redefining kernel macros like this. It can get confusing, and what gets used will depend on whether the header is included or not. Moreover, we should prefer drm_WARN_ON() and drm_WARN_ON_ONCE() anyway, which include the stringified error condition in the message. Signe

Re: [Intel-gfx] [GIT PULL] PCI fixes for v5.17

2022-01-21 Thread pr-tracker-bot
The pull request you sent on Thu, 20 Jan 2022 14:48:17 -0600: > git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git > tags/pci-v5.17-fixes-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/4141a5e694588897cbec955bc4a646075dc0afd7 Thank you! -- Deet-doot-do

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Futher optimize plane updates

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915: Futher optimize plane updates URL : https://patchwork.freedesktop.org/series/99149/ State : success == Summary == CI Bug Log - changes from CI_DRM_8 -> Patchwork_22055 Summary --- **SUCCESS*

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: drm device based logging conversions

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915/display: drm device based logging conversions URL : https://patchwork.freedesktop.org/series/99151/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: drm device based logging conversions

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915/display: drm device based logging conversions URL : https://patchwork.freedesktop.org/series/99151/ State : warning == Summary == $ dim checkpatch origin/drm-tip a43bb8c04dce drm/i915/snps: convert to drm device based logging 6813c31ef162 drm/i915/pps: con

[Intel-gfx] ✗ Fi.CI.IGT: failure for Async flip optimization for DG2 (rev4)

2022-01-21 Thread Patchwork
== Series Details == Series: Async flip optimization for DG2 (rev4) URL : https://patchwork.freedesktop.org/series/98981/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7_full -> Patchwork_22054_full Summary --- *

Re: [Intel-gfx] [PATCH 0/9] drm/i915/display: drm device based logging conversions

2022-01-21 Thread Ville Syrjälä
On Fri, Jan 21, 2022 at 03:00:29PM +0200, Jani Nikula wrote: > Purge some accumulated drm device based logging changes from my local > branches. > > Jani Nikula (9): > drm/i915/snps: convert to drm device based logging > drm/i915/pps: convert to drm device based logging > drm/i915/hotplug: c

[Intel-gfx] [PATCH 3/3] drm/i915: Use per-device debugs for bigjoiner stuff

2022-01-21 Thread Ville Syrjala
From: Ville Syrjälä Specify which device we're talking about when spewing bigjoiner debugs. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 21 +++- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel

[Intel-gfx] [PATCH 2/3] drm/i915: Simplify intel_dsc_source_support()

2022-01-21 Thread Ville Syrjala
From: Ville Syrjälä We can simplify the icl check in intel_dsc_source_support() by noting that the only case when DSC is not supported is when using transcoder A. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_vdsc.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions

[Intel-gfx] [PATCH 1/3] drm/i915: Reject bigjoiner if the pipe doesn't support it

2022-01-21 Thread Ville Syrjala
From: Ville Syrjälä Check that our crtc can in fact be the bigjoiner master before we let the modeset proceed with bigjoiner enabled. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/

[Intel-gfx] [PATCH 9/9] drm/i915/cdclk: convert to drm device based logging

2022-01-21 Thread Jani Nikula
Prefer drm device based logging. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c index c4b48b8

[Intel-gfx] [PATCH 8/9] drm/i915/cdclk: update intel_dump_cdclk_config() logging

2022-01-21 Thread Jani Nikula
Gather some intel_dump_cdclk_config() changes together to avoid extra churn: Rename to intel_cdclk_dump_config() to following naming conventions. Pass in i915. Use i915 for struct drm_device based logging. Switch to KMS drm debug class. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/g

[Intel-gfx] [PATCH 7/9] drm/i915/lspcon: convert to drm device based logging

2022-01-21 Thread Jani Nikula
Prefer drm device based logging. Do some related dev_priv->i915 and dp->intel_dp renames while at it. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_lspcon.c | 142 +++- 1 file changed, 76 insertions(+), 66 deletions(-) diff --git a/drivers/

[Intel-gfx] [PATCH 6/9] drm/i915/sprite: convert to drm device based logging

2022-01-21 Thread Jani Nikula
Prefer drm device based logging. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_sprite.c | 24 +++-- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/i

[Intel-gfx] [PATCH 5/9] drm/i915/plane: convert to drm device based logging and WARN

2022-01-21 Thread Jani Nikula
Prefer drm device based logging and WARN. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 5 +++-- drivers/gpu/drm/i915/display/skl_universal_plane.c | 10 ++ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/gp

[Intel-gfx] [PATCH 4/9] drm/i915/dp: convert to drm device based logging

2022-01-21 Thread Jani Nikula
Prefer drm device based logging. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp.c | 35 ++--- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel

[Intel-gfx] [PATCH 3/9] drm/i915/hotplug: convert to drm device based logging

2022-01-21 Thread Jani Nikula
Prefer drm device based logging. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_hotplug.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hotplug.c b/drivers/gpu/drm/i915/display/intel_ho

[Intel-gfx] [PATCH 2/9] drm/i915/pps: convert to drm device based logging

2022-01-21 Thread Jani Nikula
Prefer drm device based logging. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_pps.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_p

[Intel-gfx] [PATCH 1/9] drm/i915/snps: convert to drm device based logging

2022-01-21 Thread Jani Nikula
Prefer drm device based logging. Do some dev_priv->i915 conversions while at it. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_snps_phy.c | 29 ++- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/i915/display/

[Intel-gfx] [PATCH 0/9] drm/i915/display: drm device based logging conversions

2022-01-21 Thread Jani Nikula
Purge some accumulated drm device based logging changes from my local branches. Jani Nikula (9): drm/i915/snps: convert to drm device based logging drm/i915/pps: convert to drm device based logging drm/i915/hotplug: convert to drm device based logging drm/i915/dp: convert to drm device bas

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Futher optimize plane updates

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915: Futher optimize plane updates URL : https://patchwork.freedesktop.org/series/99149/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v9 3/6] drm: implement top-down allocation method

2022-01-21 Thread Matthew Auld
On 19/01/2022 11:37, Arunpravin wrote: Implemented a function which walk through the order list, compares the offset and returns the maximum offset block, this method is unpredictable in obtaining the high range address blocks which depends on allocation and deallocation. for instance, if driver

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Don't allocate extra ddb during async flip for DG2

2022-01-21 Thread Ville Syrjälä
On Fri, Jan 21, 2022 at 10:06:15AM +0200, Stanislav Lisovskiy wrote: > In terms of async flip optimization we don't to allocate > extra ddb space, so lets skip it. > > v2: - Extracted min ddb async flip check to separate function > (Ville Syrjälä) > - Used this function to prevent false

Re: [Intel-gfx] [PATCH v9 2/6] drm: improve drm_buddy_alloc function

2022-01-21 Thread Matthew Auld
On 19/01/2022 11:37, Arunpravin wrote: - Make drm_buddy_alloc a single function to handle range allocation and non-range allocation demands - Implemented a new function alloc_range() which allocates the requested power-of-two block comply with range limitations - Moved order computation a

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use wm0 only during async flips for DG2

2022-01-21 Thread Ville Syrjälä
On Fri, Jan 21, 2022 at 10:06:14AM +0200, Stanislav Lisovskiy wrote: > This optimization allows to achieve higher perfomance > during async flips. > For the first async flip we have to still temporarily > switch to sync flip, in order to reprogram plane > watermarks, so this requires taking into ac

Re: [Intel-gfx] [PATCH 6/7] drm: Document fdinfo format specification

2022-01-21 Thread Tvrtko Ursulin
On 20/01/2022 16:44, Rob Clark wrote: On Wed, Jan 19, 2022 at 7:09 AM Daniel Vetter wrote: On Thu, Jan 06, 2022 at 04:55:35PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Proposal to standardise the fdinfo text format as optionally output by DRM drivers. Idea is that a simple but, w

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Introduce do_async_flip flag to intel_plane_state

2022-01-21 Thread Ville Syrjälä
On Fri, Jan 21, 2022 at 10:06:13AM +0200, Stanislav Lisovskiy wrote: > There might be various logical contructs when we might want > to enable async flip, so lets calculate those and set this > flag, so that there is no need in long conditions in other > places. > > v2: - Set do_async_flip flag to

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Pass plane to watermark calculation functions

2022-01-21 Thread Ville Syrjälä
On Fri, Jan 21, 2022 at 10:06:12AM +0200, Stanislav Lisovskiy wrote: > Sometimes we might need to change the way we calculate > watermarks, based on which particular plane it is calculated > for. Thus it would be convenient to pass plane struct to those > functions. > > v2: Pass plane instead of p

[Intel-gfx] ✓ Fi.CI.BAT: success for Async flip optimization for DG2 (rev4)

2022-01-21 Thread Patchwork
== Series Details == Series: Async flip optimization for DG2 (rev4) URL : https://patchwork.freedesktop.org/series/98981/ State : success == Summary == CI Bug Log - changes from CI_DRM_7 -> Patchwork_22054 Summary --- **SUCCESS**

[Intel-gfx] [PATCH 6/6] drm/i915: Make pre-skl sprite plane registers unlocked

2022-01-21 Thread Ville Syrjala
From: Ville Syrjälä Drop the locks around sprite plane register writes. The lock isn't needed since each plane's register are neatly contained on their own cachelines. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sprite.c | 45 - 1 file changed, 45 de

[Intel-gfx] [PATCH 4/6] drm/i915: Make cursor plane registers unlocked

2022-01-21 Thread Ville Syrjala
From: Ville Syrjälä Drop the locks around cursor plane register writes. The lock isn't needed since each plane's register are neatly contained on their own cachelines. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_cursor.c | 10 -- 1 file changed, 10 deletions(-)

[Intel-gfx] [PATCH 5/6] drm/i915: Make most pre-skl primary plane registers unlocked

2022-01-21 Thread Ville Syrjala
From: Ville Syrjälä Drop the locks around most primary plane register writes. The lock isn't needed since each plane's register are neatly contained on their own cachelines. The one exception we have to make is DSPADDR/DSPSURF which is (ab)used to also trigger FBC nukes on pre-snb (since the har

[Intel-gfx] [PATCH 3/6] drm/i915: Make skl+ universal plane registers unlocked

2022-01-21 Thread Ville Syrjala
From: Ville Syrjälä Drop the locks around most universal plane register writes. The lock isn't needed since each plane's register are neatly contained on their own cachelines. Signed-off-by: Ville Syrjälä --- .../drm/i915/display/skl_universal_plane.c| 35 --- 1 file change

[Intel-gfx] [PATCH 2/6] drm/i915: Optimize icl+ universal plane programming

2022-01-21 Thread Ville Syrjala
From: Ville Syrjälä On icl+ all plane registers are armed by PLANE_SURF, so we can move almost everything over into the update_noarm() hook. The PLANE_CTL write has to stay in the icl_update_arm() hook though as it still exhibits the somewhat annoying self-arming behaviour when the plane transit

[Intel-gfx] [PATCH 1/6] drm/i915: Clean up pre-skl primary plane registers

2022-01-21 Thread Ville Syrjala
From: Ville Syrjälä Use REG_BIT() & co. for the pre-skl primary plane registers. Also give everything a consistent namespace. v2: s/DSP/DISP/ to avoid confusion (José) Use DISP_WIDTH rather than DISP_POS_X for DSPSIZE (José) Deal with gvt Cc: José Roberto de Souza Signed-off-by: Ville

[Intel-gfx] [PATCH 0/6] drm/i915: Futher optimize plane updates

2022-01-21 Thread Ville Syrjala
From: Ville Syrjälä Optimize icl+ plane updates by moving most register writes into the .update_noarm() hook. Also stop taking uncore.lock for plane register writes as well Ville Syrjälä (6): drm/i915: Clean up pre-skl primary plane registers drm/i915: Optimize icl+ universal plane programmi

Re: [Intel-gfx] [PATCH RESEND 7/7] drm/i915/mst: only ack the ESI we actually handled

2022-01-21 Thread Jani Nikula
On Thu, 20 Jan 2022, "Shankar, Uma" wrote: >> -Original Message- >> From: Nikula, Jani >> Sent: Thursday, January 20, 2022 4:32 PM >> To: Shankar, Uma ; intel-gfx@lists.freedesktop.org >> Subject: Re: [Intel-gfx] [PATCH RESEND 7/7] drm/i915/mst: only ack the ESI we >> actually handled >>

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Async flip optimization for DG2 (rev4)

2022-01-21 Thread Patchwork
== Series Details == Series: Async flip optimization for DG2 (rev4) URL : https://patchwork.freedesktop.org/series/98981/ State : warning == Summary == $ dim checkpatch origin/drm-tip a21feb89e84d drm/i915: Pass plane to watermark calculation functions 3328aa934fa7 drm/i915: Introduce do_async

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dg2: Add Wa_18018781329 (rev2)

2022-01-21 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add Wa_18018781329 (rev2) URL : https://patchwork.freedesktop.org/series/99128/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7 -> Patchwork_22053 Summary --- **FAILURE*

Re: [Intel-gfx] linux-next: build warning after merge of the drm-misc tree

2022-01-21 Thread Hans de Goede
Hi Stepen, On 1/20/22 04:18, Stephen Rothwell wrote: > Hi all, > > On Fri, 15 Oct 2021 20:54:22 +1100 Stephen Rothwell > wrote: >> >> After merging the drm-misc tree, today's linux-next build (htmldocs) >> produced this warning: >> >> Documentation/gpu/drm-kms-helpers:451: >> /home/sfr/next/ne

  1   2   >