[Intel-gfx] ✗ Fi.CI.IGT: failure for Start cleaning up register definitions (rev2)

2022-01-07 Thread Patchwork
== Series Details == Series: Start cleaning up register definitions (rev2) URL : https://patchwork.freedesktop.org/series/98575/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11056_full -> Patchwork_21945_full Summary -

[Intel-gfx] ✓ Fi.CI.BAT: success for Start cleaning up register definitions (rev2)

2022-01-07 Thread Patchwork
== Series Details == Series: Start cleaning up register definitions (rev2) URL : https://patchwork.freedesktop.org/series/98575/ State : success == Summary == CI Bug Log - changes from CI_DRM_11056 -> Patchwork_21945 Summary --- **SU

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Start cleaning up register definitions (rev2)

2022-01-07 Thread Patchwork
== Series Details == Series: Start cleaning up register definitions (rev2) URL : https://patchwork.freedesktop.org/series/98575/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Start cleaning up register definitions (rev2)

2022-01-07 Thread Patchwork
== Series Details == Series: Start cleaning up register definitions (rev2) URL : https://patchwork.freedesktop.org/series/98575/ State : warning == Summary == $ dim checkpatch origin/drm-tip bfe375c8c917 drm/i915: Use parameterized GPR register definitions everywhere -:21: ERROR:COMPLEX_MACRO:

[Intel-gfx] [PATCH v2 7/7] drm/i915: Move SNPS PHY registers to their own header

2022-01-07 Thread Matt Roper
These registers are only needed in a couple files and on specific platforms; let's keep them separate from the general register pool. Cc: Jani Nikula Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_snps_phy.c | 1 + .../drm/i915/display/intel_snps_phy_regs.h| 73 ++

[Intel-gfx] [PATCH v2 6/7] drm/i915/gt: Move engine registers to their own header

2022-01-07 Thread Matt Roper
Let's start breaking up and cleaning up the massive i915_reg.h file. We'll start by moving all registers that are defined in relation to an engine base to their own header. There are probably a bunch of other "engine registers" that we haven't moved yet (especially those that belong to the render

[Intel-gfx] [PATCH v2 5/7] drm/i915: Replace GFX_MODE_GEN7 with RING_MODE_GEN7

2022-01-07 Thread Matt Roper
It's preferable to use parameterized register macros where possible. Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 2 +- drivers/gpu/drm/i915/gvt/mmio_context.c | 4 ++-- drivers/gpu/drm/i915/i915_reg.h | 1 - 3 files changed, 3 insertions(+), 4 dele

[Intel-gfx] [PATCH v2 3/7] drm/i915: Parameterize ECOSKPD

2022-01-07 Thread Matt Roper
Combine the separate render and blitter register definitions into a single definition. We already know we have some workarounds on an upcoming platform that will need to update the ECOSKPD register for other engines too, so this helps pave the way for that. Cc: Jani Nikula Signed-off-by: Matt Ro

[Intel-gfx] [PATCH v2 1/7] drm/i915: Use parameterized GPR register definitions everywhere

2022-01-07 Thread Matt Roper
Since we have an engine-parameterized macro GEN8_RING_CS_GPR, let's use that in place of the HSW_CS_GPR and BCS_GPR register definitions. Cc: Jani Nikula Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_cmd_parser.c | 68 ++ drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH v2 0/7] Start cleaning up register definitions

2022-01-07 Thread Matt Roper
Let's start splitting up and cleaning up parts of i915_reg.h. Rather than starting with dead code removal as we did in v1, this time we'll switch a few macros to parameterized style, and then move a few types of registers (engine registers, SNPS PHY registers) off to their own header files. Cc: J

[Intel-gfx] [PATCH v2 4/7] drm/i915: Use RING_PSMI_CTL rather than per-engine macros

2022-01-07 Thread Matt Roper
We have a parameterized macro for RING_PSMI_CTL; let's use that instead of the per-engine definitions where possible. Cc: Jani Nikula Signed-off-by: Matt Roper --- .../gpu/drm/i915/gt/intel_ring_submission.c | 10 +- drivers/gpu/drm/i915/gt/intel_workarounds.c | 2 +- drivers/gpu/d

[Intel-gfx] [PATCH v2 2/7] drm/i915: Parameterize PWRCTX_MAXCNT

2022-01-07 Thread Matt Roper
Rather than having separate definitions for each engine, create a single parameterized macro that takes the engine base offset. This will also ensure we get to the proper offset if we ever need to use these registers on newer platforms (where the media engine offsets have changed). Cc: Jani Nikul

[Intel-gfx] ✗ Fi.CI.IGT: failure for Update to GuC version 69.0.3 (rev7)

2022-01-07 Thread Patchwork
== Series Details == Series: Update to GuC version 69.0.3 (rev7) URL : https://patchwork.freedesktop.org/series/98249/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11056_full -> Patchwork_21944_full Summary --- **FA

Re: [Intel-gfx] [PATCH v3 3/3] x86/quirks: Fix stolen detection with integrated + discrete GPU

2022-01-07 Thread Bjorn Helgaas
On Fri, Jan 07, 2022 at 01:05:16PM -0800, Lucas De Marchi wrote: > early_pci_scan_bus() does a depth-first traversal, possibly calling > the quirk functions for each device based on vendor, device and class > from early_qrk table. intel_graphics_quirks() however uses PCI_ANY_ID > and does additiona

Re: [Intel-gfx] [PATCH v3 1/3] x86/quirks: Replace QFLAG_APPLY_ONCE with static locals

2022-01-07 Thread Bjorn Helgaas
On Fri, Jan 07, 2022 at 01:05:14PM -0800, Lucas De Marchi wrote: > The flags are only used to mark a quirk to be called once and nothing > else. Also, that logic may not be appropriate if the quirk wants to > do additional filtering and set quirk ass applied by itself. s/ass applied/as applied/ >

[Intel-gfx] ✓ Fi.CI.BAT: success for Update to GuC version 69.0.3 (rev7)

2022-01-07 Thread Patchwork
== Series Details == Series: Update to GuC version 69.0.3 (rev7) URL : https://patchwork.freedesktop.org/series/98249/ State : success == Summary == CI Bug Log - changes from CI_DRM_11056 -> Patchwork_21944 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Update to GuC version 69.0.3 (rev7)

2022-01-07 Thread Patchwork
== Series Details == Series: Update to GuC version 69.0.3 (rev7) URL : https://patchwork.freedesktop.org/series/98249/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Update to GuC version 69.0.3 (rev7)

2022-01-07 Thread Patchwork
== Series Details == Series: Update to GuC version 69.0.3 (rev7) URL : https://patchwork.freedesktop.org/series/98249/ State : warning == Summary == $ dim checkpatch origin/drm-tip caf4361ec325 drm/i915/guc: Temporarily bump the GuC load timeout 9c480a8b25b9 drm/i915/guc: Update to GuC version

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v3,1/3] x86/quirks: Replace QFLAG_APPLY_ONCE with static locals

2022-01-07 Thread Patchwork
== Series Details == Series: series starting with [v3,1/3] x86/quirks: Replace QFLAG_APPLY_ONCE with static locals URL : https://patchwork.freedesktop.org/series/98622/ State : success == Summary == CI Bug Log - changes from CI_DRM_11054_full -> Patchwork_21943_full ==

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3,1/3] x86/quirks: Replace QFLAG_APPLY_ONCE with static locals

2022-01-07 Thread Patchwork
== Series Details == Series: series starting with [v3,1/3] x86/quirks: Replace QFLAG_APPLY_ONCE with static locals URL : https://patchwork.freedesktop.org/series/98622/ State : success == Summary == CI Bug Log - changes from CI_DRM_11054 -> Patchwork_21943

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix possible NULL pointer dereferences in i9xx_update_wm() (rev3)

2022-01-07 Thread Matt Roper
On Fri, Jan 07, 2022 at 07:25:02PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Fix possible NULL pointer dereferences in i9xx_update_wm() > (rev3) > URL : https://patchwork.freedesktop.org/series/98154/ > State : success > > == Summary == > > CI Bug Log - changes from

[Intel-gfx] [PATCH v3 3/3] x86/quirks: Fix stolen detection with integrated + discrete GPU

2022-01-07 Thread Lucas De Marchi
early_pci_scan_bus() does a depth-first traversal, possibly calling the quirk functions for each device based on vendor, device and class from early_qrk table. intel_graphics_quirks() however uses PCI_ANY_ID and does additional filtering in the quirk. If there is an Intel integrated + discrete GPU

[Intel-gfx] [PATCH v3 2/3] x86/quirks: Improve line wrap on quirk conditions

2022-01-07 Thread Lucas De Marchi
Remove extra parenthesis and wrap lines so it's easier to read what are the conditions being checked. The call to the hook also had an extra indentation: remove here to conform to coding style. Signed-off-by: Lucas De Marchi --- arch/x86/kernel/early-quirks.c | 14 ++ 1 file changed,

[Intel-gfx] [PATCH v3 1/3] x86/quirks: Replace QFLAG_APPLY_ONCE with static locals

2022-01-07 Thread Lucas De Marchi
The flags are only used to mark a quirk to be called once and nothing else. Also, that logic may not be appropriate if the quirk wants to do additional filtering and set quirk ass applied by itself. So replace the uses of QFLAG_APPLY_ONCE with static local variables in the few quirks that use this

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix possible NULL pointer dereferences in i9xx_update_wm() (rev3)

2022-01-07 Thread Patchwork
== Series Details == Series: drm/i915: Fix possible NULL pointer dereferences in i9xx_update_wm() (rev3) URL : https://patchwork.freedesktop.org/series/98154/ State : success == Summary == CI Bug Log - changes from CI_DRM_11027_full -> Patchwork_21892_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Asynchronous vma unbinding (rev6)

2022-01-07 Thread Patchwork
== Series Details == Series: drm/i915: Asynchronous vma unbinding (rev6) URL : https://patchwork.freedesktop.org/series/98055/ State : success == Summary == CI Bug Log - changes from CI_DRM_11053_full -> Patchwork_21942_full Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: clean up i915_drv.h, part 1

2022-01-07 Thread Patchwork
== Series Details == Series: drm/i915: clean up i915_drv.h, part 1 URL : https://patchwork.freedesktop.org/series/98608/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11053_full -> Patchwork_21941_full Summary --- **

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gvt: Make DRM_I915_GVT depend on X86

2022-01-07 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Make DRM_I915_GVT depend on X86 URL : https://patchwork.freedesktop.org/series/98598/ State : success == Summary == CI Bug Log - changes from CI_DRM_11053_full -> Patchwork_21940_full Summary -

Re: [Intel-gfx] [PATCH 3/3] drm/i915: split out vlv sideband registers from i915_reg.h

2022-01-07 Thread Matt Roper
On Fri, Jan 07, 2022 at 11:49:51AM +0200, Jani Nikula wrote: > Add a dedicated file vlv_sideband_reg.h for the VLV/CHV sideband > registers. The sideband registers macros are needed by the same files > that need vlv_sideband.h, so include the definitions from there. > > Cc: Matt Roper > Signed-of

Re: [Intel-gfx] [PATCH v3 2/6] drm/plane: Fix typo in format_mod_supported documentation

2022-01-07 Thread Simon Ser
On Friday, January 7th, 2022 at 18:26, José Expósito wrote: > Is there something that needs to improve in the other 4 patches? > Or just waiting on maintainers input? Yeah, these patches look good to me. Feel free to add my R-b. Maintainers for these drivers still need to review/ack/apply them

Re: [Intel-gfx] [PATCH 2/3] drm/i915: move VGA registers to intel_vga.c

2022-01-07 Thread Matt Roper
On Fri, Jan 07, 2022 at 11:49:50AM +0200, Jani Nikula wrote: > The only users of the VGA register macros are in intel_vga.c. Hide the > macros there. > > Cc: Matt Roper > Signed-off-by: Jani Nikula It looks like only 5 of the ~30 registers here are actually used. And I think those could just b

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915: split out PCI config space registers from i915_reg.h

2022-01-07 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: split out PCI config space registers from i915_reg.h URL : https://patchwork.freedesktop.org/series/98597/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11053_full -> Patchwork_21939_full ==

Re: [Intel-gfx] [PATCH 1/3] drm/i915: split out PCI config space registers from i915_reg.h

2022-01-07 Thread Matt Roper
On Fri, Jan 07, 2022 at 11:49:49AM +0200, Jani Nikula wrote: > The PCI config space registers don't really belong next to the MMIO > register definitions. > > Cc: Matt Roper > Signed-off-by: Jani Nikula > --- ... > diff --git a/drivers/gpu/drm/i915/intel_pci_config.h > b/drivers/gpu/drm/i915/in

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: Don't error on reset of banned context

2022-01-07 Thread Patchwork
== Series Details == Series: drm/i915/guc: Don't error on reset of banned context URL : https://patchwork.freedesktop.org/series/98580/ State : success == Summary == CI Bug Log - changes from CI_DRM_11053_full -> Patchwork_21937_full Summar

Re: [Intel-gfx] [RFC 7/7] drm/i915/guc: Print the GuC error capture output register list.

2022-01-07 Thread Teres Alexis, Alan Previn
On Fri, 2022-01-07 at 09:03 +, Tvrtko Ursulin wrote: > On 06/01/2022 18:33, Teres Alexis, Alan Previn wrote: > > On Thu, 2022-01-06 at 09:38 +, Tvrtko Ursulin wrote: > > > On 05/01/2022 17:30, Teres Alexis, Alan Previn wrote: > > > > On Tue, 2022-01-04 at 13:56 +, Tvrtko Ursulin wrote:

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Drop unused register definitions

2022-01-07 Thread Lucas De Marchi
On Fri, Jan 07, 2022 at 12:46:48PM +0200, Jani Nikula wrote: On Thu, 06 Jan 2022, Matt Roper wrote: A large percentage (nearly 25%) of the register and bit definitions in i915_reg.h are not used by the i915 driver and are effectively dead code. There are a few origins for these unused definiti

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix possible NULL pointer dereferences in i9xx_update_wm() (rev3)

2022-01-07 Thread Patchwork
== Series Details == Series: drm/i915: Fix possible NULL pointer dereferences in i9xx_update_wm() (rev3) URL : https://patchwork.freedesktop.org/series/98154/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11027_full -> Patchwork_21892_full

[Intel-gfx] ✓ Fi.CI.IGT: success for Start cleaning up register definitions

2022-01-07 Thread Patchwork
== Series Details == Series: Start cleaning up register definitions URL : https://patchwork.freedesktop.org/series/98575/ State : success == Summary == CI Bug Log - changes from CI_DRM_11052_full -> Patchwork_21935_full Summary --- *

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix possible NULL pointer dereferences in i9xx_update_wm() (rev3)

2022-01-07 Thread Patchwork
== Series Details == Series: drm/i915: Fix possible NULL pointer dereferences in i9xx_update_wm() (rev3) URL : https://patchwork.freedesktop.org/series/98154/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11027_full -> Patchwork_21892_full

Re: [Intel-gfx] [PATCH v6 1/6] drm: move the buddy allocator from i915 into common drm

2022-01-07 Thread Matthew Auld
On 26/12/2021 22:24, Arunpravin wrote: Move the base i915 buddy allocator code into drm - Move i915_buddy.h to include/drm - Move i915_buddy.c to drm root folder - Rename "i915" string with "drm" string wherever applicable - Rename "I915" string with "DRM" string wherever applicable - Fix header

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pxp: Hold RPM wakelock during PXP unbind (rev3)

2022-01-07 Thread Patchwork
== Series Details == Series: drm/i915/pxp: Hold RPM wakelock during PXP unbind (rev3) URL : https://patchwork.freedesktop.org/series/98245/ State : success == Summary == CI Bug Log - changes from CI_DRM_11052_full -> Patchwork_21934_full Su

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Asynchronous vma unbinding (rev6)

2022-01-07 Thread Patchwork
== Series Details == Series: drm/i915: Asynchronous vma unbinding (rev6) URL : https://patchwork.freedesktop.org/series/98055/ State : success == Summary == CI Bug Log - changes from CI_DRM_11053 -> Patchwork_21942 Summary --- **SUCC

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v3,1/4] drm/i915: don't call free_mmap_offset when purging

2022-01-07 Thread Patchwork
== Series Details == Series: series starting with [v3,1/4] drm/i915: don't call free_mmap_offset when purging URL : https://patchwork.freedesktop.org/series/98562/ State : success == Summary == CI Bug Log - changes from CI_DRM_11052_full -> Patchwork_21933_full ===

[Intel-gfx] ✓ Fi.CI.IGT: success for Per client GPU stats (rev6)

2022-01-07 Thread Patchwork
== Series Details == Series: Per client GPU stats (rev6) URL : https://patchwork.freedesktop.org/series/92574/ State : success == Summary == CI Bug Log - changes from CI_DRM_11052_full -> Patchwork_21932_full Summary --- **SUCCESS**

[Intel-gfx] [GIT PULL] GVT next changes for drm-intel-next-queued

2022-01-07 Thread Wang, Zhi A
Hi folks: Happy holidays! This pull mostly contains the code re-factors patches from Guenter Roeck and Rikard. Also a minor change from Zhenyu. Zhi The following changes since commit 3bfa7d40ce736ffbbfe07127061f54b359ee2b12:   drm/i915/dg2: Add support for new DG2-G11 revid 0x5 (2021-08-06 0

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Asynchronous vma unbinding (rev6)

2022-01-07 Thread Patchwork
== Series Details == Series: drm/i915: Asynchronous vma unbinding (rev6) URL : https://patchwork.freedesktop.org/series/98055/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Asynchronous vma unbinding (rev6)

2022-01-07 Thread Patchwork
== Series Details == Series: drm/i915: Asynchronous vma unbinding (rev6) URL : https://patchwork.freedesktop.org/series/98055/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1beab04c3727 drm/i915: Initial introduction of vma resources -:249: WARNING:FILE_PATH_CHANGES: added, mov

[Intel-gfx] [PATCH v6 6/6] drm/i915: Use struct vma_resource instead of struct vma_snapshot

2022-01-07 Thread Thomas Hellström
There is always a struct vma_resource guaranteed to be alive when we access a corresponding struct vma_snapshot. So ditch the latter and instead of allocating vma_snapshots, reference the already existning vma_resource. This requires a couple of extra members in struct vma_resource but that's a s

[Intel-gfx] [PATCH v6 5/6] drm/i915: Asynchronous migration selftest

2022-01-07 Thread Thomas Hellström
Add a selftest to exercise asynchronous migration and -unbining. Extend the gem_migrate selftest to perform the migrations while depending on a spinner and a bound vma set up on the migrated buffer object. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_object.c| 12 ++

[Intel-gfx] [PATCH v6 4/6] drm/i915: Use vma resources for async unbinding

2022-01-07 Thread Thomas Hellström
Implement async (non-blocking) unbinding by not syncing the vma before calling unbind on the vma_resource. Add the resulting unbind fence to the object's dma_resv from where it is picked up by the ttm migration code. Ideally these unbind fences should be coalesced with the migration blit fence to a

[Intel-gfx] [PATCH v6 3/6] drm/i915: Don't pin the object pages during pending vma binds

2022-01-07 Thread Thomas Hellström
A pin-count is already held by vma->pages so taking an additional pin during async binds is not necessary. When we introduce async unbinding we have other means of keeping the object pages alive. Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/i915_vma.c | 5

[Intel-gfx] [PATCH v6 2/6] drm/i915: Use the vma resource as argument for gtt binding / unbinding

2022-01-07 Thread Thomas Hellström
When introducing asynchronous unbinding, the vma itself may no longer be alive when the actual binding or unbinding takes place. Update the gtt i915_vma_ops accordingly to take a struct i915_vma_resource instead of a struct i915_vma for the bind_vma() and unbind_vma() ops. Similarly change the ins

[Intel-gfx] [PATCH v6 1/6] drm/i915: Initial introduction of vma resources

2022-01-07 Thread Thomas Hellström
Introduce vma resources, sort of similar to TTM resources, needed for asynchronous bind management. Initially we will use them to hold completion of unbinding when we capture data from a vma, but they will be used extensively in upcoming patches for asynchronous vma unbinding. v6: - Some document

[Intel-gfx] [PATCH v6 0/6] drm/i915: Asynchronous vma unbinding

2022-01-07 Thread Thomas Hellström
This patch series introduces infrastructure for asynchronous vma unbinding. The single enabled use-case is initially at buffer object migration where we otherwise sync when unbinding vmas before migration. This in theory allows us to pipeline any number of migrations, but in practice the number is

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Fix the PIPE_MISC 12 BPC PORT_OUTPUT for DG2

2022-01-07 Thread Patchwork
== Series Details == Series: drm/i915/display: Fix the PIPE_MISC 12 BPC PORT_OUTPUT for DG2 URL : https://patchwork.freedesktop.org/series/98551/ State : success == Summary == CI Bug Log - changes from CI_DRM_11052_full -> Patchwork_21931_full ==

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: clean up i915_drv.h, part 1

2022-01-07 Thread Patchwork
== Series Details == Series: drm/i915: clean up i915_drv.h, part 1 URL : https://patchwork.freedesktop.org/series/98608/ State : success == Summary == CI Bug Log - changes from CI_DRM_11053 -> Patchwork_21941 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/4] drm/i915: don't call free_mmap_offset when purging

2022-01-07 Thread Patchwork
== Series Details == Series: series starting with [v2,1/4] drm/i915: don't call free_mmap_offset when purging URL : https://patchwork.freedesktop.org/series/98548/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11052_full -> Patchwork_21930_full ===

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: clean up i915_drv.h, part 1

2022-01-07 Thread Patchwork
== Series Details == Series: drm/i915: clean up i915_drv.h, part 1 URL : https://patchwork.freedesktop.org/series/98608/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: clean up i915_drv.h, part 1

2022-01-07 Thread Patchwork
== Series Details == Series: drm/i915: clean up i915_drv.h, part 1 URL : https://patchwork.freedesktop.org/series/98608/ State : warning == Summary == $ dim checkpatch origin/drm-tip 60e75eead03f drm/i915: split out i915_getparam.h from i915_drv.h -:51: WARNING:FILE_PATH_CHANGES: added, moved

Re: [Intel-gfx] [PATCH 0/5] drm/i915: clean up i915_drv.h, part 1

2022-01-07 Thread Jani Nikula
On Fri, 07 Jan 2022, Jani Nikula wrote: > First five patches from [1], chopping it up a bit. Aarrgh. Today I learned, the hard way, that you can actually specify both files *and* rev-list to git send-email at the same time, and it'll send all. *facepalm*. Let's see how badly CI gets confused abo

Re: [Intel-gfx] [PATCH 03/21] drm/i915: split out i915_gem_evict.h from i915_drv.h

2022-01-07 Thread Jani Nikula
On Thu, 06 Jan 2022, Tvrtko Ursulin wrote: > On 05/01/2022 19:56, Jani Nikula wrote: >> We already have the i915_gem_evicti915.c file. > > There's a stray paste here and a few new headers got the 2021 copyright, > but other than that it all looks fine to me. For the series: Thanks, fixed. Some

[Intel-gfx] [PATCH 5/5] drm/i915: split out gem/i915_gem_tiling.h from i915_drv.h

2022-01-07 Thread Jani Nikula
We already have the gem/i915_gem_tiling.c file. Acked-by: Tvrtko Ursulin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 1 + drivers/gpu/drm/i915/gem/i915_gem_tiling.h | 18 ++ drivers/gpu/drm/i915/i915_drv.h| 5 - drivers/gpu/drm/i

[Intel-gfx] [PATCH 4/5] drm/i915: split out gem/i915_gem_userptr.h from i915_drv.h

2022-01-07 Thread Jani Nikula
We already have the gem/i915_gem_userptr.c file. Acked-by: Tvrtko Ursulin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 1 + drivers/gpu/drm/i915/gem/i915_gem_userptr.h | 14 ++ drivers/gpu/drm/i915/i915_drv.h | 2 -- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 3/5] drm/i915: split out i915_gem_evict.h from i915_drv.h

2022-01-07 Thread Jani Nikula
We already have the i915_gem_evict.c file. v2: Fixed commit message (Tvrtko) Acked-by: Tvrtko Ursulin Signed-off-by: Jani Nikula --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 1 + drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 1 + drivers/gpu/drm/i915/i915_drv.h | 11 --

[Intel-gfx] [PATCH 2/5] drm/i915: split out i915_cmd_parser.h from i915_drv.h

2022-01-07 Thread Jani Nikula
We already have the i915_cmd_parser.c file. Acked-by: Tvrtko Ursulin Signed-off-by: Jani Nikula --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 1 + drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- drivers/gpu/drm/i915/i915_cmd_parser.c| 1 + drivers/gpu/drm/i915/i915_cmd_pa

[Intel-gfx] [PATCH 1/5] drm/i915: split out i915_getparam.h from i915_drv.h

2022-01-07 Thread Jani Nikula
We already have the i915_getparam.c file. Acked-by: Tvrtko Ursulin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_driver.c | 1 + drivers/gpu/drm/i915/i915_drv.h | 4 drivers/gpu/drm/i915/i915_getparam.c | 1 + drivers/gpu/drm/i915/i915_getparam.h | 15 +++

[Intel-gfx] [PATCH 5/5] drm/i915: split out gem/i915_gem_tiling.h from i915_drv.h

2022-01-07 Thread Jani Nikula
We already have the gem/i915_gem_tiling.c file. Acked-by: Tvrtko Ursulin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 1 + drivers/gpu/drm/i915/gem/i915_gem_tiling.h | 18 ++ drivers/gpu/drm/i915/i915_drv.h| 5 - drivers/gpu/drm/i

[Intel-gfx] [PATCH 4/5] drm/i915: split out gem/i915_gem_userptr.h from i915_drv.h

2022-01-07 Thread Jani Nikula
We already have the gem/i915_gem_userptr.c file. Acked-by: Tvrtko Ursulin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 1 + drivers/gpu/drm/i915/gem/i915_gem_userptr.h | 14 ++ drivers/gpu/drm/i915/i915_drv.h | 2 -- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 3/5] drm/i915: split out i915_gem_evict.h from i915_drv.h

2022-01-07 Thread Jani Nikula
We already have the i915_gem_evict.c file. v2: Fixed commit message (Tvrtko) Acked-by: Tvrtko Ursulin Signed-off-by: Jani Nikula --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 1 + drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 1 + drivers/gpu/drm/i915/i915_drv.h | 11 --

[Intel-gfx] [PATCH 2/5] drm/i915: split out i915_cmd_parser.h from i915_drv.h

2022-01-07 Thread Jani Nikula
We already have the i915_cmd_parser.c file. Acked-by: Tvrtko Ursulin Signed-off-by: Jani Nikula --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 1 + drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- drivers/gpu/drm/i915/i915_cmd_parser.c| 1 + drivers/gpu/drm/i915/i915_cmd_pa

[Intel-gfx] [PATCH 1/5] drm/i915: split out i915_getparam.h from i915_drv.h

2022-01-07 Thread Jani Nikula
We already have the i915_getparam.c file. Acked-by: Tvrtko Ursulin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_driver.c | 1 + drivers/gpu/drm/i915/i915_drv.h | 4 drivers/gpu/drm/i915/i915_getparam.c | 1 + drivers/gpu/drm/i915/i915_getparam.h | 15 +++

[Intel-gfx] [PATCH 0/5] drm/i915: clean up i915_drv.h, part 1

2022-01-07 Thread Jani Nikula
First five patches from [1], chopping it up a bit. BR, Jani. [1] https://patchwork.freedesktop.org/series/98515/ Jani Nikula (5): drm/i915: split out i915_getparam.h from i915_drv.h drm/i915: split out i915_cmd_parser.h from i915_drv.h drm/i915: split out i915_gem_evict.h from i915_drv.h

Re: [Intel-gfx] [PATCH] drm/i915: Discard large BIOS framebuffers causing display corruption.

2022-01-07 Thread Jani Nikula
On Fri, 07 Jan 2022, Ashish Arora wrote: > From: Ashish Arora > > On certain 4k panels, the BIOS framebuffer is larger than what panel > requires causing display corruption. Introduce a check for the same. This is quite thin on details. Is there a bug report? Moreover, if this is what we want,

Re: [Intel-gfx] [PATCH 1/4] drm: add writeback pointers to drm_connector

2022-01-07 Thread Jani Nikula
On Thu, 06 Jan 2022, "Kandpal, Suraj" wrote: >> > Adding drm_connector and drm_encoder pointers in >> > drm_writeback_connector >> >> Why? > > The elements of struct drm_writeback_connector are > struct drm_writeback_connector { > Struct drm_connector base; > Struct drm_encoder encod

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] x86/quirks: Fix logic to apply quirk once

2022-01-07 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] x86/quirks: Fix logic to apply quirk once URL : https://patchwork.freedesktop.org/series/98523/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11051_full -> Patchwork_21929_full =

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: Make DRM_I915_GVT depend on X86

2022-01-07 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Make DRM_I915_GVT depend on X86 URL : https://patchwork.freedesktop.org/series/98598/ State : success == Summary == CI Bug Log - changes from CI_DRM_11053 -> Patchwork_21940 Summary --- **SU

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Make DRM_I915_GVT depend on X86

2022-01-07 Thread Jani Nikula
On Fri, 07 Jan 2022, Mullati Siva wrote: > From: Siva Mullati > > GVT is not supported on non-x86 platforms, So add > dependency of X86 on config parameter DRM_I915_GVT. Please add GVT list and maintainers for GVT changes. BR, Jani. > > Signed-off-by: Siva Mullati > --- > drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Drop unused register definitions

2022-01-07 Thread Jani Nikula
On Thu, 06 Jan 2022, Matt Roper wrote: > A large percentage (nearly 25%) of the register and bit definitions in > i915_reg.h are not used by the i915 driver and are effectively dead > code. There are a few origins for these unused definitions: > > * Registers only accessed by workarounds that we

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: split out PCI config space registers from i915_reg.h

2022-01-07 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: split out PCI config space registers from i915_reg.h URL : https://patchwork.freedesktop.org/series/98597/ State : success == Summary == CI Bug Log - changes from CI_DRM_11053 -> Patchwork_21939

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915: split out PCI config space registers from i915_reg.h

2022-01-07 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: split out PCI config space registers from i915_reg.h URL : https://patchwork.freedesktop.org/series/98597/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won'

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: split out PCI config space registers from i915_reg.h

2022-01-07 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: split out PCI config space registers from i915_reg.h URL : https://patchwork.freedesktop.org/series/98597/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0eec9f19cbae drm/i915: split out PCI config space register

Re: [Intel-gfx] [PATCH 0/1] Start cleaning up register definitions

2022-01-07 Thread Jani Nikula
On Fri, 07 Jan 2022, Jani Nikula wrote: > Another early step should be splitting out the non-MMIO macros, for > example the IOSF and PUNIT sideband stuff. They don't necessarily fall > to the below categories. Funny. I actually had a branch from a few months back splitting out PCI config space, V

[Intel-gfx] [PATCH] drm/i915/gvt: Make DRM_I915_GVT depend on X86

2022-01-07 Thread Mullati Siva
From: Siva Mullati GVT is not supported on non-x86 platforms, So add dependency of X86 on config parameter DRM_I915_GVT. Signed-off-by: Siva Mullati --- drivers/gpu/drm/i915/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig

[Intel-gfx] [PATCH 3/3] drm/i915: split out vlv sideband registers from i915_reg.h

2022-01-07 Thread Jani Nikula
Add a dedicated file vlv_sideband_reg.h for the VLV/CHV sideband registers. The sideband registers macros are needed by the same files that need vlv_sideband.h, so include the definitions from there. Cc: Matt Roper Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 171 ---

[Intel-gfx] [PATCH 2/3] drm/i915: move VGA registers to intel_vga.c

2022-01-07 Thread Jani Nikula
The only users of the VGA register macros are in intel_vga.c. Hide the macros there. Cc: Matt Roper Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_vga.c | 41 drivers/gpu/drm/i915/i915_reg.h | 41 2 files changed, 41

[Intel-gfx] [PATCH 1/3] drm/i915: split out PCI config space registers from i915_reg.h

2022-01-07 Thread Jani Nikula
The PCI config space registers don't really belong next to the MMIO register definitions. Cc: Matt Roper Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_backlight.c| 1 + drivers/gpu/drm/i915/display/intel_cdclk.c| 1 + drivers/gpu/drm/i915/display/intel_opregion.c | 1

Re: [Intel-gfx] [PATCH 0/1] Start cleaning up register definitions

2022-01-07 Thread Jani Nikula
On Thu, 06 Jan 2022, Matt Roper wrote: > Our i915_reg.h file has become a huge unwieldy mess over the years. A > lot of definitions don't follow any logical ordering, there's > unintentional duplication of registers under different names, the coding > style is very inconsistent, and there's tons

Re: [Intel-gfx] [RFC 7/7] drm/i915/guc: Print the GuC error capture output register list.

2022-01-07 Thread Tvrtko Ursulin
On 06/01/2022 18:33, Teres Alexis, Alan Previn wrote: On Thu, 2022-01-06 at 09:38 +, Tvrtko Ursulin wrote: On 05/01/2022 17:30, Teres Alexis, Alan Previn wrote: On Tue, 2022-01-04 at 13:56 +, Tvrtko Ursulin wrote: The flow of events are as below: 1. guc sends notification that an e

Re: [Intel-gfx] [PATCH v3 3/4] drm/i915/ttm: add unmap_virtual callback

2022-01-07 Thread Thomas Hellström
On 1/6/22 18:49, Matthew Auld wrote: Ensure we call ttm_bo_unmap_virtual when releasing the pages. Importantly this should now handle the ttm swapping case, and all other places that already call into i915_ttm_move_notify(). v2: fix up the selftest Fixes: cf3e3e86d779 ("drm/i915: Use ttm mmap

Re: [Intel-gfx] [PATCH v3 4/4] drm/i915/ttm: ensure we unmap when purging

2022-01-07 Thread Thomas Hellström
On 1/6/22 18:49, Matthew Auld wrote: Purging can happen during swapping out, or directly invoked with the madvise ioctl. In such cases this doesn't involve a ttm move, which skips umapping the object. v2(Thomas): - add ttm_truncate helper, and just call into i915_ttm_move_notify() to handle