[Intel-gfx] [PATCH] drm/i915/ttm: Fix error code in i915_ttm_eviction_valuable()

2021-11-21 Thread Dan Carpenter
This function returns a bool type so returning -EBUSY is equivalent to returning true. It should return false instead. Fixes: 7ae034590cea ("drm/i915/ttm: add tt shmem backend") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 de

Re: [Intel-gfx] [PATCH linux-next] drm/i915/request: Remove unused variables

2021-11-21 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-2028] url: https://github.com/0day-ci/linux/commits/cgel-zte-gmail-com/drm-i915-request-Remove-unused-variables/20211121-181441 base:5191249f880367a4cd675825cd721a8d78f26a45 config: x86_64

Re: [Intel-gfx] [PATCH linux-next] drm/i915/request: Remove unused variables

2021-11-21 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-2028] url: https://github.com/0day-ci/linux/commits/cgel-zte-gmail-com/drm-i915-request-Remove-unused-variables/20211121-181441 base:5191249f880367a4cd675825cd721a8d78f26a45 config: x86_64

Re: [Intel-gfx] [PATCH i-g-t 1/6] tests/api_intel_allocator: Fix build warning

2021-11-21 Thread Zbigniew Kempczyński
On Fri, Nov 19, 2021 at 12:59:40PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > .../tests/i915/api_intel_allocator.c: In function ‘basic_alloc’: > .../tests/i915/api_intel_allocator.c:158:25: warning: this ‘if’ clause does > not guard... [-Wmisleading-indentation] > 158 |

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/pxp: Trybot - run CI with PXP and MEI_PXP enabled

2021-11-21 Thread Patchwork
== Series Details == Series: drm/i915/pxp: Trybot - run CI with PXP and MEI_PXP enabled URL : https://patchwork.freedesktop.org/series/97145/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10909 -> Patchwork_21649 Summary --

[Intel-gfx] [PATCH] drm/i915/pxp: Trybot - run CI with PXP and MEI_PXP enabled

2021-11-21 Thread Tejas Upadhyay
Please do not merge this is trybot patch to run CI with PXP and MEI PXP enabled to get premegre results for https://patchwork.freedesktop.org/series/96658/#rev3 change. Signed-off-by: Tejas Upadhyay --- drivers/gpu/drm/i915/Kconfig.debug | 2 ++ drivers/gpu/drm/i915/gt/intel_gt_pm.c | 7

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove unused intel_gmbus_set_speed() function

2021-11-21 Thread Patchwork
== Series Details == Series: drm/i915: Remove unused intel_gmbus_set_speed() function URL : https://patchwork.freedesktop.org/series/97141/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10908_full -> Patchwork_21648_full Su

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove unused intel_gmbus_set_speed() function

2021-11-21 Thread Patchwork
== Series Details == Series: drm/i915: Remove unused intel_gmbus_set_speed() function URL : https://patchwork.freedesktop.org/series/97141/ State : success == Summary == CI Bug Log - changes from CI_DRM_10908 -> Patchwork_21648 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Remove unused intel_gmbus_set_speed() function

2021-11-21 Thread Patchwork
== Series Details == Series: drm/i915: Remove unused intel_gmbus_set_speed() function URL : https://patchwork.freedesktop.org/series/97141/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH] drm/i915: Remove unused intel_gmbus_set_speed() function

2021-11-21 Thread Hans de Goede
The intel_gmbus_set_speed() function is not used anywhere, remove it. Note drivers/gpu/drm/gma500 has its own copy called gma_intel_gmbus_set_speed() which is used, the intel_gmbus_set_speed() version in the i915 code is not used at all Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/disp

[Intel-gfx] ✗ Fi.CI.BAT: failure for More preparation for multi gt patches (rev2)

2021-11-21 Thread Patchwork
== Series Details == Series: More preparation for multi gt patches (rev2) URL : https://patchwork.freedesktop.org/series/97020/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10908 -> Patchwork_21647 Summary --- **FAI

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for More preparation for multi gt patches (rev2)

2021-11-21 Thread Patchwork
== Series Details == Series: More preparation for multi gt patches (rev2) URL : https://patchwork.freedesktop.org/series/97020/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH v2 2/2] drm/i915: Use to_root_gt() to refer to the root tile

2021-11-21 Thread Andi Shyti
Starting from a patch from Matt to_root_gt() returns the reference to the root tile in order to abstract the root tile from th callers. Being the root tile identified as tile '0', embed the id in the name so that i915->gt becomes i915->gt0. The renaming has been mostly done with the following com

[Intel-gfx] [PATCH v2 1/2] drm/i915: Store backpointer to GT in uncore

2021-11-21 Thread Andi Shyti
From: Michał Winiarski We now support a per-gt uncore, yet we're not able to infer which GT we're operating upon. Let's store a backpointer for now. Signed-off-by: Michał Winiarski Signed-off-by: Matt Roper Reviewed-by: Andi Shyti Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/i915_dri

[Intel-gfx] [PATCH v2 0/2] More preparation for multi gt patches

2021-11-21 Thread Andi Shyti
From: Andi Shyti Hi, the first of the two patches concludes the first stage of refactoring which makes the use of intel_gt on the different subsystem. It's taken from Matt's series and it has alread been reviewed. The patch has just been replaced before any multitile patches and I think it can b

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/backlight: Drop duplicate intel_panel_actually_set_backlight()

2021-11-21 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/backlight: Drop duplicate intel_panel_actually_set_backlight() URL : https://patchwork.freedesktop.org/series/97134/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10908_full -> Patchwork_21646_full =

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Rename gt to gt0

2021-11-21 Thread Andi Shyti
Hi Chris, > > --- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c > > +++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c > > @@ -817,7 +817,7 @@ intel_prepare_plane_fb(struct drm_plane *_plane, > > * maximum clocks following a vblank miss (see do_rps_boost()). > > */ > >

Re: [Intel-gfx] [PATCH linux-next] drm/i915/request: Remove unused variables

2021-11-21 Thread Christophe JAILLET
Le 21/11/2021 à 11:13, cgel@gmail.com a écrit : From: yong yiran The clang_analyzer complains as follows: drivers/gpu/drm/i915/i915_request.c:2119:2 warning: Value stored to 'x' is never read Reported-by: Zeal Robot Signed-off-by: yong yiran --- drivers/gpu/drm/i915/i915_request.c | 3

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/backlight: Drop duplicate intel_panel_actually_set_backlight()

2021-11-21 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/backlight: Drop duplicate intel_panel_actually_set_backlight() URL : https://patchwork.freedesktop.org/series/97134/ State : success == Summary == CI Bug Log - changes from CI_DRM_10908 -> Patchwork_21646 ===

[Intel-gfx] [PATCH 1/2] drm/i915/backlight: Drop duplicate intel_panel_actually_set_backlight()

2021-11-21 Thread Hans de Goede
After the recent refactoring of the backlight code the contents of intel_panel_actually_set_backlight() is exactly the same (minus a small wording difference in the drm_dbg_kms() as the contents if the more widely used intel_backlight_set_pwm_level() function. Drop the duplicate intel_panel_actual

[Intel-gfx] [PATCH 2/2] drm/i915/backlight: Make ext_pwm_disable_backlight() call intel_backlight_set_pwm_level()

2021-11-21 Thread Hans de Goede
At least the Bay Trail LPSS PWM controller used with DSI panels on many Bay Trail tablets seems to leave the PWM pin in whatever state it was (high or low) ATM that the PWM gets disabled. Combined with some panels not having a separate backlight-enable pin this leads to the backlight sometimes stay