[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc/slpc: Check GuC status before freq boost

2021-11-11 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: Check GuC status before freq boost URL : https://patchwork.freedesktop.org/series/96844/ State : success == Summary == CI Bug Log - changes from CI_DRM_10873 -> Patchwork_21570 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/execlists: Weak parallel submission support for execlists (rev2)

2021-11-11 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Weak parallel submission support for execlists (rev2) URL : https://patchwork.freedesktop.org/series/96088/ State : success == Summary == CI Bug Log - changes from CI_DRM_10872_full -> Patchwork_21564_full ==

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/guc/slpc: Check GuC status before freq boost

2021-11-11 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: Check GuC status before freq boost URL : https://patchwork.freedesktop.org/series/96844/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_fbc.c:635: warning: Excess function paramete

[Intel-gfx] [PATCH] drm/i915/guc/slpc: Check GuC status before freq boost

2021-11-11 Thread Vinay Belgaumkar
It's possible that i915 might get wedged between a boost and un-boost. Validate the i915-GuC connection before trying to send a H2G to change the min frequency. Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/4464 Cc: Ashutosh Dixit Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i9

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: Additional DG2 workarounds (rev2)

2021-11-11 Thread Patchwork
== Series Details == Series: i915: Additional DG2 workarounds (rev2) URL : https://patchwork.freedesktop.org/series/96824/ State : success == Summary == CI Bug Log - changes from CI_DRM_10873 -> Patchwork_21569 Summary --- **SUCCESS*

[Intel-gfx] ✗ Fi.CI.DOCS: warning for i915: Additional DG2 workarounds (rev2)

2021-11-11 Thread Patchwork
== Series Details == Series: i915: Additional DG2 workarounds (rev2) URL : https://patchwork.freedesktop.org/series/96824/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_fbc.c:635: warning: Excess function parameter 'i915' descr

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915: Additional DG2 workarounds (rev2)

2021-11-11 Thread Patchwork
== Series Details == Series: i915: Additional DG2 workarounds (rev2) URL : https://patchwork.freedesktop.org/series/96824/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH v2 3/4] drm/i915/dg2: Add Wa_16013000631

2021-11-11 Thread Matt Roper
From: Ramalingam C Invalidate IC cache through pipe control command as part of the ctx restore flow through indirect ctx pointer. v2: - Move pipe control from xcs indirect context to the rcs indirect context. We'll eventually need this on the CCS engines too, but support for those hasn't

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Increase the live_engine_busy_stats sample period

2021-11-11 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Increase the live_engine_busy_stats sample period URL : https://patchwork.freedesktop.org/series/96840/ State : success == Summary == CI Bug Log - changes from CI_DRM_10872 -> Patchwork_21568 Summa

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/pmu: Increase the live_engine_busy_stats sample period

2021-11-11 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Increase the live_engine_busy_stats sample period URL : https://patchwork.freedesktop.org/series/96840/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_fbc.c:635: warning: Excess function

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pmu: Increase the live_engine_busy_stats sample period

2021-11-11 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Increase the live_engine_busy_stats sample period URL : https://patchwork.freedesktop.org/series/96840/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7fca16cc17fe drm/i915/pmu: Increase the live_engine_busy_stats sample period -:49: CH

[Intel-gfx] [PATCH] drm/i915/pmu: Increase the live_engine_busy_stats sample period

2021-11-11 Thread Umesh Nerlige Ramappa
Irrespective of the backend for request submissions, busyness for an engine with an active context is calculated using: busyness = total + (current_time - context_switch_in_time) In execlists mode of operation, the context switch events are handled by the CPU. Context switch in/out time and curre

Re: [Intel-gfx] [PATCH] drm/i915: Use per device iommu check

2021-11-11 Thread Lu Baolu
On 11/11/21 11:18 PM, Tvrtko Ursulin wrote: On 10/11/2021 14:37, Robin Murphy wrote: On 2021-11-10 14:11, Tvrtko Ursulin wrote: On 10/11/2021 12:35, Lu Baolu wrote: On 2021/11/10 20:08, Tvrtko Ursulin wrote: On 10/11/2021 12:04, Lu Baolu wrote: On 2021/11/10 17:30, Tvrtko Ursulin wrote:

Re: [Intel-gfx] [PATCH] drm/i915: Use per device iommu check

2021-11-11 Thread Lu Baolu
On 11/11/21 11:06 PM, Tvrtko Ursulin wrote: On 10/11/2021 12:35, Lu Baolu wrote: On 2021/11/10 20:08, Tvrtko Ursulin wrote: On 10/11/2021 12:04, Lu Baolu wrote: On 2021/11/10 17:30, Tvrtko Ursulin wrote: On 10/11/2021 07:12, Lu Baolu wrote: Hi Tvrtko, On 2021/11/9 20:17, Tvrtko Ursulin w

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display/dsc: Clamp the max DSC input BPP to connector's max bpp

2021-11-11 Thread Patchwork
== Series Details == Series: drm/i915/display/dsc: Clamp the max DSC input BPP to connector's max bpp URL : https://patchwork.freedesktop.org/series/96832/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10872 -> Patchwork_21567 ==

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/display/dsc: Clamp the max DSC input BPP to connector's max bpp

2021-11-11 Thread Patchwork
== Series Details == Series: drm/i915/display/dsc: Clamp the max DSC input BPP to connector's max bpp URL : https://patchwork.freedesktop.org/series/96832/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_fbc.c:635: warning: Excess

[Intel-gfx] [PATCH] drm/i915/display/dsc: Clamp the max DSC input BPP to connector's max bpp

2021-11-11 Thread Manasi Navare
Pipe_bpp limits are decided by connectors max bpp as computed in compute_sink_pipe_bpp() before computing link and DSC config. Currently dsc_compute_config() sets the max input bpp only based on DSC Input BPPs supported and max bpc requested for the connector but does not clamp it based on connecto

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: Additional DG2 workarounds

2021-11-11 Thread Patchwork
== Series Details == Series: i915: Additional DG2 workarounds URL : https://patchwork.freedesktop.org/series/96824/ State : success == Summary == CI Bug Log - changes from CI_DRM_10872 -> Patchwork_21565 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.BUILD: failure for use DYNAMIC_DEBUG to implement DRM.debug & DRM.trace (rev3)

2021-11-11 Thread Patchwork
== Series Details == Series: use DYNAMIC_DEBUG to implement DRM.debug & DRM.trace (rev3) URL : https://patchwork.freedesktop.org/series/96327/ State : failure == Summary == Patch is empty. When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git

[Intel-gfx] ✗ Fi.CI.DOCS: warning for i915: Additional DG2 workarounds

2021-11-11 Thread Patchwork
== Series Details == Series: i915: Additional DG2 workarounds URL : https://patchwork.freedesktop.org/series/96824/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_fbc.c:635: warning: Excess function parameter 'i915' description

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915: Additional DG2 workarounds

2021-11-11 Thread Patchwork
== Series Details == Series: i915: Additional DG2 workarounds URL : https://patchwork.freedesktop.org/series/96824/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/gt/intel_

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Weak parallel submission support for execlists (rev2)

2021-11-11 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Weak parallel submission support for execlists (rev2) URL : https://patchwork.freedesktop.org/series/96088/ State : success == Summary == CI Bug Log - changes from CI_DRM_10872 -> Patchwork_21564

[Intel-gfx] [PATCH v10 09/10] dyndbg: create DEFINE_DYNAMIC_DEBUG_LOG|TRACE_GROUPS

2021-11-11 Thread Jim Cromie
With the recent addition of pr_debug to tracefs via +T flag, we now want to add drm.trace; like its model: drm.debug, it maps bits to pr_debug categories, but this one enables/disables writing to tracefs (iff CONFIG_TRACING). Do this by: 1. add flags to dyndbg_bitmap_param, holds "p" or "T" to wo

[Intel-gfx] [PATCH v10 10/10] drm: use DEFINE_DYNAMIC_DEBUG_TRACE_GROUPS in 3 places

2021-11-11 Thread Jim Cromie
add sysfs knobs to enable modules' pr_debug()s ---> tracefs Signed-off-by: Jim Cromie --- drivers/gpu/drm/amd/display/dc/core/dc_debug.c | 8 drivers/gpu/drm/drm_print.c| 13 ++--- drivers/gpu/drm/i915/intel_gvt.c | 15 --- 3 files

[Intel-gfx] [PATCH v10 08/10] dyndbg: add print-to-tracefs, selftest with it - RFC

2021-11-11 Thread Jim Cromie
Sean Paul proposed, in: https://patchwork.freedesktop.org/series/78133/ drm/trace: Mirror DRM debug logs to tracefs His patchset's objective is to be able to independently steer some of the drm.debug stream to an alternate tracing destination, by splitting drm_debug_enabled() into syslog & trace f

[Intel-gfx] [PATCH v10 07/10] drm_print: instrument drm_debug_enabled

2021-11-11 Thread Jim Cromie
Duplicate drm_debug_enabled() code into both "basic" and "dyndbg" ifdef branches. Then add a pr_debug("todo: ...") into the "dyndbg" branch. Then convert the "dyndbg" branch's code to a macro, so that the pr_debug() get its callsite info from the invoking function, instead of from drm_debug_enabl

[Intel-gfx] [PATCH v10 06/10] drm_print: add choice to use dynamic debug in drm-debug

2021-11-11 Thread Jim Cromie
drm's debug system writes 10 distinct categories of messages to syslog using a small API[1]: drm_dbg*(10 names), DRM_DEV_DEBUG*(3 names), DRM_DEBUG*(8 names). There are thousands of these callsites, each categorized in this systematized way. These callsites can be enabled at runtime by their cate

[Intel-gfx] [PATCH v10 05/10] i915/gvt: use dyndbg.BITGRPS for existing pr_debugs

2021-11-11 Thread Jim Cromie
The gvt component of this driver has ~120 pr_debugs with formats using one of 9 fixed string prefixes, which are quite similar to those enumerated in DRM debug categories. Following the interface model of drm.debug, add a parameter to map bits to these format prefixes. static struct dyndbg_bitdes

[Intel-gfx] [PATCH v10 04/10] i915/gvt: trim spaces from pr_debug "gvt: core:" prefixes

2021-11-11 Thread Jim Cromie
Taking embedded spaces out of existing prefixes makes them more easily searchable; simplifying the extra quoting needed otherwise: $> echo format "^gvt: core:" +p >control Dropping the internal spaces means any trailing space in a query will more clearly terminate the prefix being searched for.

[Intel-gfx] [PATCH v10 03/10] amdgpu: use dyndbg.BITGRPS to control existing pr_debugs

2021-11-11 Thread Jim Cromie
logger_types.h defines many DC_LOG_*() categorized debug wrappers. Most of these already use DRM debug API, so are controllable using drm.debug, but others use a bare pr_debug("$prefix: .."), with 1 of 13 different class-prefixes matching [:uppercase:] Use DEFINE_DYNAMIC_DEBUG_BITGRPS to create a

[Intel-gfx] [PATCH v10 02/10] drm: fix doc grammar

2021-11-11 Thread Jim Cromie
allocates and initializes ... Signed-off-by: Jim Cromie --- include/drm/drm_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h index 0cd95953cdf5..4b29261c4537 100644 --- a/include/drm/drm_drv.h +++ b/include/drm/drm_drv.h @@ -

[Intel-gfx] [PATCH v10 01/10] dyndbg: add DEFINE_DYNAMIC_DEBUG_BITGRPS macro and callbacks

2021-11-11 Thread Jim Cromie
DEFINE_DYNAMIC_DEBUG_BITGRPS(fsname, var, bitmap_desc, bitmap) allows users to create a drm.debug style (bitmap) sysfs interface, mapping each bit to a group of pr_debugs, matching on their formats. This works well when the formats systematically include a prefix string such as ERR|WARN|INFO, etc.

[Intel-gfx] [PATCH v10 00/10 RESEND] use DYNAMIC_DEBUG to implement DRM.debug & DRM.trace

2021-11-11 Thread Jim Cromie
Hi Jason, Greg, DRM-everyone, everyone, resend to add more people, after rebasing on master to pick up 306589856399 drm/print: Add deprecation notes to DRM_...() functions This patchset has 3 separate but related parts: 1. DEFINE_DYNAMIC_DEBUG_BITGRPS macro [patch 1/10] Declares DRM.debug st

Re: [Intel-gfx] [RFC v2 05/22] drm/i915/xelpd: Define Degamma Lut range struct for HDR planes

2021-11-11 Thread Shankar, Uma
> -Original Message- > From: Harry Wentland > Sent: Friday, November 12, 2021 2:41 AM > To: Shankar, Uma ; Ville Syrjälä > > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; > ppaala...@gmail.com; brian.star...@arm.com; sebast...@sebastianwick.net; > shashank.sha...

[Intel-gfx] [PATCH 2/4] drm/i915/dg2: Add Wa_16011777198

2021-11-11 Thread Matt Roper
Coarse power gating for render should not be enabled on some DG2 steppings. Bspec: 52698 Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_rc6.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i

[Intel-gfx] [PATCH 3/4] drm/i915/dg2: Add Wa_16013000631

2021-11-11 Thread Matt Roper
From: Ramalingam C Invalidate IC cache through pipe control command as part of the ctx restore flow through indirect ctx pointer Cc: Chris Wilson Signed-off-by: Ramalingam C Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_lrc.c | 5 + 1 file changed, 5 insertions(+) diff --g

[Intel-gfx] [PATCH 1/4] drm/i915/dg2: Add Wa_14010547955

2021-11-11 Thread Matt Roper
This workaround is documented a bit strangely in the bspec; it's listed as an A0 workaround, but the description clarifies that the workaround is implicitly handled by the hardware and what the driver really needs to do is program a chicken bit to reenable some internal behavior. Signed-off-by: Ma

[Intel-gfx] [PATCH 4/4] drm/i915/dg2: extend Wa_1409120013 to DG2

2021-11-11 Thread Matt Roper
From: Matt Atwood Extend existing workaround 1409120013 to DG2. Cc: José Roberto de Souza Signed-off-by: Matt Atwood Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/intel_pm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers

[Intel-gfx] [PATCH 0/4] i915: Additional DG2 workarounds

2021-11-11 Thread Matt Roper
We have a few more DG2 workarounds that weren't included in the initial batch. Matt Atwood (1): drm/i915/dg2: extend Wa_1409120013 to DG2 Matt Roper (2): drm/i915/dg2: Add Wa_14010547955 drm/i915/dg2: Add Wa_16011777198 Ramalingam C (1): drm/i915/dg2: Add Wa_16013000631 drivers/gpu/dr

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/execlists: Weak parallel submission support for execlists (rev2)

2021-11-11 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Weak parallel submission support for execlists (rev2) URL : https://patchwork.freedesktop.org/series/96088/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_fbc.c:635: warning: Exce

[Intel-gfx] [PATCH] drm/i915/execlists: Weak parallel submission support for execlists

2021-11-11 Thread Matthew Brost
A weak implementation of parallel submission (multi-bb execbuf IOCTL) for execlists. Doing as little as possible to support this interface for execlists - basically just passing submit fences between each request generated and virtual engines are not allowed. This is on par with what is there for t

Re: [Intel-gfx] [RFC v2 05/22] drm/i915/xelpd: Define Degamma Lut range struct for HDR planes

2021-11-11 Thread Shankar, Uma
> -Original Message- > From: Ville Syrjälä > Sent: Thursday, November 11, 2021 10:13 PM > To: Harry Wentland > Cc: Shankar, Uma ; intel-gfx@lists.freedesktop.org; > dri- > de...@lists.freedesktop.org; ppaala...@gmail.com; brian.star...@arm.com; > sebast...@sebastianwick.net; shashank.

Re: [Intel-gfx] [PATCH] drm/i915: Drop stealing of bits from i915_sw_fence function pointer

2021-11-11 Thread Teres Alexis, Alan Previn
Hey Matt, apologies for the delay, went thru all the code, LGTM. Reviewed-by: Alan Previn P.S. - As a side note, would be interesting to replay the original reason behind the overloading of the func ptr bits to begin with... to see what the initial intention was. ...alan On Wed, 2021-09-22 a

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for i915: Initial workarounds for Xe_HP SDV and DG2

2021-11-11 Thread Vudum, Lakshminarayana
spec@arb_gpu_shader_fp64@execution@built-in-functions@fs-abs-dvec3 test is not in CI bug log yet. So, I can address this failure and re-report the results. FYI @Latvala, Petri Lakshmi. -Original Message- From: Roper, Matthew D Sent: Thursday, November 11, 2021 11:14 AM To: intel-gfx@li

Re: [Intel-gfx] [PATCH 1/1] drm/i915/rpm: Enable runtime pm autosuspend by default

2021-11-11 Thread Vivi, Rodrigo
On Thu, 2021-11-11 at 14:42 +0200, Ville Syrjälä wrote: > On Wed, Nov 10, 2021 at 05:24:22PM -0500, Rodrigo Vivi wrote: > > On Wed, Nov 10, 2021 at 01:46:46PM +0200, Ville Syrjälä wrote: > > > On Wed, Nov 10, 2021 at 10:59:26AM +0530, Tilak Tangudu wrote: > > > > Enable runtime pm autosuspend by de

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for i915: Initial workarounds for Xe_HP SDV and DG2

2021-11-11 Thread Matt Roper
On Wed, Nov 03, 2021 at 02:16:42AM +, Patchwork wrote: > == Series Details == > > Series: i915: Initial workarounds for Xe_HP SDV and DG2 > URL : https://patchwork.freedesktop.org/series/96513/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_10830_full -> Patchwork

Re: [Intel-gfx] [PATCH] drm/i915/psr: Fix PSR2 handling of multiplanar format

2021-11-11 Thread Hogander, Jouni
Thank you for the clarification. Reviewed-by: Jouni Högander On Wed, 2021-11-10 at 18:16 +, Souza, Jose wrote: > On Wed, 2021-11-10 at 16:05 +, Hogander, Jouni wrote: > > On Tue, 2021-11-09 at 18:17 +, Souza, Jose wrote: > > > On Tue, 2021-11-09 at 10:31 +, Hogander, Jouni wrote:

Re: [Intel-gfx] [PATCH 1/3] drm/i915/xehpsdv: Add initial workarounds

2021-11-11 Thread Clint Taylor
Reviewed-by: Clint Taylor -Clint On 11/2/21 3:25 PM, Matt Roper wrote: From: Stuart Summers Add the initial set of workarounds for Xe_HP SDV. There are some additional workarounds specific to the compute engines that we're holding back for now. Those will be added later, after general com

Re: [Intel-gfx] [PATCH 3/3] drm/i915/dg2: Program recommended HW settings

2021-11-11 Thread Clint Taylor
Reviewed-by: Clint Taylor -Clint On 11/2/21 3:25 PM, Matt Roper wrote: The bspec's performance guide suggests programming specific values into a few registers for optimal performance. Although these aren't workarounds, it's easiest to handle them inside the GT workaround functions (which wil

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Skip error capture when wedged on init (rev3)

2021-11-11 Thread Patchwork
== Series Details == Series: drm/i915: Skip error capture when wedged on init (rev3) URL : https://patchwork.freedesktop.org/series/96718/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10869_full -> Patchwork_21562_full Sum

Re: [Intel-gfx] [PATCH] ALSA: hda: fix general protection fault in azx_runtime_idle

2021-11-11 Thread Kai Vehmanen
Hi, On Thu, 11 Nov 2021, Takashi Iwai wrote: > A potential problem with the current code is that it doesn't disable > the runtime PM at the release procedure. Could you try the patch > below? You can put WARN_ON(!chip) at azx_runtime_idle(), too, for > catching the invalid runtime call. [...] >

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Weak parallel submission support for execlists

2021-11-11 Thread Matthew Brost
On Mon, Nov 01, 2021 at 10:35:09AM +, Tvrtko Ursulin wrote: > > On 27/10/2021 21:10, Matthew Brost wrote: > > On Wed, Oct 27, 2021 at 01:04:49PM -0700, John Harrison wrote: > > > On 10/27/2021 12:17, Matthew Brost wrote: > > > > On Tue, Oct 26, 2021 at 02:58:00PM -0700, John Harrison wrote: >

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Fix synchronization of PMU callback with reset

2021-11-11 Thread Umesh Nerlige Ramappa
On Thu, Nov 11, 2021 at 02:37:43PM +, Tvrtko Ursulin wrote: On 04/11/2021 22:04, Umesh Nerlige Ramappa wrote: On Thu, Nov 04, 2021 at 05:37:37PM +, Tvrtko Ursulin wrote: On 03/11/2021 22:47, Umesh Nerlige Ramappa wrote: Since the PMU callback runs in irq context, it synchronizes with

Re: [Intel-gfx] [RFC v2 05/22] drm/i915/xelpd: Define Degamma Lut range struct for HDR planes

2021-11-11 Thread Ville Syrjälä
On Thu, Nov 11, 2021 at 10:17:17AM -0500, Harry Wentland wrote: > > > On 2021-09-06 17:38, Uma Shankar wrote: > > Define the structure with XE_LPD degamma lut ranges. HDR and SDR > > planes have different capabilities, implemented respective > > structure for the HDR planes. > > > > Signed-off-b

[Intel-gfx] ✗ Fi.CI.BAT: failure for ALSA: hda: fix general protection fault in azx_runtime_idle (rev2)

2021-11-11 Thread Patchwork
== Series Details == Series: ALSA: hda: fix general protection fault in azx_runtime_idle (rev2) URL : https://patchwork.freedesktop.org/series/96784/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10870 -> Patchwork_21563 Su

[Intel-gfx] ✗ Fi.CI.DOCS: warning for ALSA: hda: fix general protection fault in azx_runtime_idle (rev2)

2021-11-11 Thread Patchwork
== Series Details == Series: ALSA: hda: fix general protection fault in azx_runtime_idle (rev2) URL : https://patchwork.freedesktop.org/series/96784/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_fbc.c:635: warning: Excess funct

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for ALSA: hda: fix general protection fault in azx_runtime_idle (rev2)

2021-11-11 Thread Patchwork
== Series Details == Series: ALSA: hda: fix general protection fault in azx_runtime_idle (rev2) URL : https://patchwork.freedesktop.org/series/96784/ State : warning == Summary == $ dim checkpatch origin/drm-tip 791aebc9d846 ALSA: hda: fix general protection fault in azx_runtime_idle -:19: WAR

Re: [Intel-gfx] [PATCH] drm/i915: Use per device iommu check

2021-11-11 Thread Tvrtko Ursulin
On 10/11/2021 14:37, Robin Murphy wrote: On 2021-11-10 14:11, Tvrtko Ursulin wrote: On 10/11/2021 12:35, Lu Baolu wrote: On 2021/11/10 20:08, Tvrtko Ursulin wrote: On 10/11/2021 12:04, Lu Baolu wrote: On 2021/11/10 17:30, Tvrtko Ursulin wrote: On 10/11/2021 07:12, Lu Baolu wrote: Hi Tv

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915/driver: rename i915_drv.c to i915_driver.c

2021-11-11 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/driver: rename i915_drv.c to i915_driver.c URL : https://patchwork.freedesktop.org/series/96808/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10868_full -> Patchwork_21559_full =

Re: [Intel-gfx] [PATCH] drm/i915: Use per device iommu check

2021-11-11 Thread Tvrtko Ursulin
On 10/11/2021 12:35, Lu Baolu wrote: On 2021/11/10 20:08, Tvrtko Ursulin wrote: On 10/11/2021 12:04, Lu Baolu wrote: On 2021/11/10 17:30, Tvrtko Ursulin wrote: On 10/11/2021 07:12, Lu Baolu wrote: Hi Tvrtko, On 2021/11/9 20:17, Tvrtko Ursulin wrote: From: Tvrtko Ursulin On igfx + dgfx

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Fix synchronization of PMU callback with reset

2021-11-11 Thread Tvrtko Ursulin
On 04/11/2021 22:04, Umesh Nerlige Ramappa wrote: On Thu, Nov 04, 2021 at 05:37:37PM +, Tvrtko Ursulin wrote: On 03/11/2021 22:47, Umesh Nerlige Ramappa wrote: Since the PMU callback runs in irq context, it synchronizes with gt reset using the reset count. We could run into a case where

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Skip error capture when wedged on init (rev3)

2021-11-11 Thread Patchwork
== Series Details == Series: drm/i915: Skip error capture when wedged on init (rev3) URL : https://patchwork.freedesktop.org/series/96718/ State : success == Summary == CI Bug Log - changes from CI_DRM_10869 -> Patchwork_21562 Summary -

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/ttm: Async migration (rev2)

2021-11-11 Thread Patchwork
== Series Details == Series: drm/i915/ttm: Async migration (rev2) URL : https://patchwork.freedesktop.org/series/96798/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10869 -> Patchwork_21561 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH] drm/i915/selftests: print exact error code

2021-11-11 Thread Zeng, Oak
Ping. Can anyone help to review this small patch? Regards, Oak > -Original Message- > From: Intel-gfx On Behalf Of Oak > Zeng > Sent: October 21, 2021 7:04 PM > To: intel-gfx@lists.freedesktop.org > Cc: ch...@chris-wilson.co.uk > Subject: [Intel-gfx] [PATCH] drm/i915/selftests: print e

Re: [Intel-gfx] [PATCH] ALSA: hda: fix general protection fault in azx_runtime_idle

2021-11-11 Thread Takashi Iwai
On Wed, 10 Nov 2021 23:15:40 +0100, Kai Vehmanen wrote: > > Hey, > > On Wed, 10 Nov 2021, Takashi Iwai wrote: > > > On Wed, 10 Nov 2021 22:03:07 +0100, Kai Vehmanen wrote: > > > Fix a corner case between PCI device driver remove callback and > > > runtime PM idle callback. > [...] > > > Some non

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/ttm: Async migration (rev2)

2021-11-11 Thread Patchwork
== Series Details == Series: drm/i915/ttm: Async migration (rev2) URL : https://patchwork.freedesktop.org/series/96798/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/gt/in

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gt: Hold RPM wakelock during PXP suspend (rev2)

2021-11-11 Thread Patchwork
== Series Details == Series: drm/i915/gt: Hold RPM wakelock during PXP suspend (rev2) URL : https://patchwork.freedesktop.org/series/96658/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/com

[Intel-gfx] [PATCH v3] drm/i915: Skip error capture when wedged on init

2021-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Trying to capture uninitialised engines when we wedged on init ends in tears. Skip that together with uC capture, since failure to initialise the latter can actually be one of the reasons for wedging on init. v2: * Use i915_disable_error_state when wedging on init/fini. v3

[Intel-gfx] [PATCH v2 6/6] drm/i915/ttm: Update i915_gem_obj_copy_ttm() to be asynchronous

2021-11-11 Thread Thomas Hellström
Update the copy function i915_gem_obj_copy_ttm() to be asynchronous for future users and update the only current user to sync the objects as needed after this function. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 40 ++-- drivers/gpu/drm/i91

[Intel-gfx] [PATCH v2 5/6] drm/i915/ttm: Implement asynchronous TTM moves

2021-11-11 Thread Thomas Hellström
Don't wait sync while migrating, but rather make the GPU blit await the dependencies and add a moving fence to the object. This also enables asynchronous VRAM management in that on eviction, rather than waiting for the moving fence to expire before freeing VRAM, it is freed immediately and the fen

[Intel-gfx] [PATCH v2 4/6] drm/i915/ttm: Break refcounting loops at device region unref time

2021-11-11 Thread Thomas Hellström
There is an interesting refcounting loop: struct intel_memory_region has a struct ttm_resource_manager, ttm_resource_manager->move may hold a reference to i915_request, i915_request may hold a reference to intel_context, intel_context may hold a reference to drm_i915_gem_object, drm_i915_gem_object

[Intel-gfx] [PATCH v2 3/6] drm/i915/ttm: Move the i915_gem_obj_copy_ttm() function

2021-11-11 Thread Thomas Hellström
Move the i915_gem_obj_copy_ttm() function to i915_gem_ttm_move.h. This will help keep a number of functions static when introducing async moves. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 47 --- drivers/gpu/drm/i915/gem/i915_gem_ttm.h |

[Intel-gfx] [PATCH v2 1/6] drm/i915: Add functions to set/get moving fence

2021-11-11 Thread Thomas Hellström
From: Maarten Lankhorst We want to get rid of i915_vma tracking to simplify the code and lifetimes. Add a way to set/put the moving fence, in preparation for removing the tracking. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/gem/i915_gem_object.c | 37 ++ driv

[Intel-gfx] [PATCH v2 2/6] drm/i915: Add support for asynchronous moving fence waiting

2021-11-11 Thread Thomas Hellström
From: Maarten Lankhorst For now, we will only allow async migration when TTM is used, so the paths we care about are related to TTM. The mmap path is handled by having the fence in ttm_bo->moving, when pinning, the binding only becomes available after the moving fence is signaled, and pinning a

[Intel-gfx] [PATCH v2 0/6] drm/i915/ttm: Async migration

2021-11-11 Thread Thomas Hellström
This patch series deals with async migration and async vram management. It still leaves an important part out, which is async unbinding which will reduce latency further, at least when trying to migrate already active objects. Patches 1/6 and 2/6 deal with accessing and waiting for the TTM moving

[Intel-gfx] [PATCH V3] drm/i915/gt: Hold RPM wakelock during PXP suspend

2021-11-11 Thread Tejas Upadhyay
selftest --r live shows failure in suspend tests when RPM wakelock is not acquired during suspend. This changes addresses below error : <4> [154.177535] RPM wakelock ref not held during HW access <4> [154.177575] WARNING: CPU: 4 PID: 5772 at drivers/gpu/drm/i915/intel_runtime_pm.h:113 fwtable_writ

Re: [Intel-gfx] [PATCH 1/1] drm/i915/rpm: Enable runtime pm autosuspend by default

2021-11-11 Thread Ville Syrjälä
On Wed, Nov 10, 2021 at 05:24:22PM -0500, Rodrigo Vivi wrote: > On Wed, Nov 10, 2021 at 01:46:46PM +0200, Ville Syrjälä wrote: > > On Wed, Nov 10, 2021 at 10:59:26AM +0530, Tilak Tangudu wrote: > > > Enable runtime pm autosuspend by default for gen12 and > > > later versions. > > > > > > Signed-of

Re: [Intel-gfx] [PATCH 00/17] drm/i915/fbc: Prep work for multiple FBC instances

2021-11-11 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Friday, November 5, 2021 3:09 PM > To: Ville Syrjala ; > intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 00/17] drm/i915/fbc: Prep work for multiple > FBC > instances > > On Thu, 04 Nov 2021, Vil

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/driver: rename i915_drv.c to i915_driver.c

2021-11-11 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/driver: rename i915_drv.c to i915_driver.c URL : https://patchwork.freedesktop.org/series/96808/ State : success == Summary == CI Bug Log - changes from CI_DRM_10868 -> Patchwork_21559 ===

Re: [Intel-gfx] [PATCH 02/28] drm/i915: use new iterator in i915_gem_object_wait_reservation

2021-11-11 Thread Christian König
Am 01.11.21 um 10:41 schrieb Tvrtko Ursulin: On 28/10/2021 16:30, Daniel Vetter wrote: On Thu, Oct 28, 2021 at 10:41:38AM +0200, Christian König wrote: Am 21.10.21 um 13:13 schrieb Tvrtko Ursulin: On 21/10/2021 12:06, Maarten Lankhorst wrote: Op 21-10-2021 om 12:38 schreef Christian König:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/driver: rename i915_drv.c to i915_driver.c

2021-11-11 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/driver: rename i915_drv.c to i915_driver.c URL : https://patchwork.freedesktop.org/series/96808/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checke

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/driver: rename i915_drv.c to i915_driver.c

2021-11-11 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/driver: rename i915_drv.c to i915_driver.c URL : https://patchwork.freedesktop.org/series/96808/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8b1acff11ac8 drm/i915/driver: rename i915_drv.c to i915_driver.c -:27

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/ttm: Async migration

2021-11-11 Thread Patchwork
== Series Details == Series: drm/i915/ttm: Async migration URL : https://patchwork.freedesktop.org/series/96798/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10866_full -> Patchwork_21558_full Summary --- **FAILURE*

[Intel-gfx] [PATCH 2/3] drm/i915/driver: rename driver to i915_drm_driver

2021-11-11 Thread Jani Nikula
As a name, "driver" is too generic and short to be easily located in a file this size. Rename it to i915_drm_driver. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_driver.c b/d

[Intel-gfx] [PATCH 3/3] drm/i915/driver: add i915_driver_ prefix to functions

2021-11-11 Thread Jani Nikula
Add the i915_driver_ prefix to the switcheroo functions in i915_driver.[ch]. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_driver.c | 5 +++-- drivers/gpu/drm/i915/i915_driver.h | 4 ++-- drivers/gpu/drm/i915/i915_switcheroo.c | 4 ++-- 3 files changed, 7 insertions(+), 6 dele

[Intel-gfx] [PATCH 1/3] drm/i915/driver: rename i915_drv.c to i915_driver.c

2021-11-11 Thread Jani Nikula
This is more about trimming i915_drv.h than the renamed i915_driver.[ch]. Split out i915_driver.[ch] out of i915_drv.h as a feasible thing to do. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 2 +- .../drm/i915/{i915_drv.c => i915_driver.c}| 5 ++-- drivers

Re: [Intel-gfx] [PATCH v3] drm/i915/dsi: transmit brightness command in HS state

2021-11-11 Thread Jani Nikula
On Thu, 11 Nov 2021, "Tseng, William" wrote: > Noted. Thanks for your consideration, Jani. And pushed, thanks for the patch. BR, Jani. > > Regards > William > > -Original Message- > From: Jani Nikula > Sent: Wednesday, November 10, 2021 6:45 PM > To: Tseng, William ; intel-gfx@lists.

[Intel-gfx] [PULL] drm-misc-fixes

2021-11-11 Thread Thomas Zimmermann
Hi Dave and Daniel, here's this week's PR for drm-misc-fixes. I'm sending it as Maarten and Maxime are both on vacation this week. Best regards Thomas drm-misc-fixes-2021-11-11: * dma-buf: name_lock fixes * prime: Keep object ref during mmap * nouveau: Fix a refcount issue; Fix device removal

Re: [Intel-gfx] [RFC v2 02/22] drm: Add Enhanced Gamma and color lut range attributes

2021-11-11 Thread Pekka Paalanen
On Wed, 10 Nov 2021 10:17:59 -0500 Harry Wentland wrote: > On 2021-11-10 06:55, Ville Syrjälä wrote: > > On Wed, Nov 10, 2021 at 10:49:24AM +0200, Pekka Paalanen wrote: > >> On Wed, 10 Nov 2021 00:02:16 +0200 > >> Ville Syrjälä wrote: > >> > >>> On Tue, Nov 09, 2021 at 03:47:58PM -0500, Harr

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ttm: Async migration

2021-11-11 Thread Patchwork
== Series Details == Series: drm/i915/ttm: Async migration URL : https://patchwork.freedesktop.org/series/96798/ State : success == Summary == CI Bug Log - changes from CI_DRM_10866 -> Patchwork_21558 Summary --- **SUCCESS** No re