[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Introduce Intel PXP (rev8)

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915: Introduce Intel PXP (rev8) URL : https://patchwork.freedesktop.org/series/90503/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10605_full -> Patchwork_21096_full Summary --- **F

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Introduce Intel PXP (rev8)

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915: Introduce Intel PXP (rev8) URL : https://patchwork.freedesktop.org/series/90503/ State : success == Summary == CI Bug Log - changes from CI_DRM_10605 -> Patchwork_21096 Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/4] drm/i915: rename debugfs_gt files

2021-09-17 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: rename debugfs_gt files URL : https://patchwork.freedesktop.org/series/94827/ State : success == Summary == CI Bug Log - changes from CI_DRM_10605_full -> Patchwork_21095_full =

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Introduce Intel PXP (rev8)

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915: Introduce Intel PXP (rev8) URL : https://patchwork.freedesktop.org/series/90503/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./include/uapi/drm/i915_drm.h:1904: warning: This comment starts with '/**', but isn't a kernel-do

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Introduce Intel PXP (rev8)

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915: Introduce Intel PXP (rev8) URL : https://patchwork.freedesktop.org/series/90503/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/gt/in

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Introduce Intel PXP (rev8)

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915: Introduce Intel PXP (rev8) URL : https://patchwork.freedesktop.org/series/90503/ State : warning == Summary == $ dim checkpatch origin/drm-tip e27175183684 drm/i915/pxp: Define PXP component interface -:31: WARNING:FILE_PATH_CHANGES: added, moved or delet

Re: [Intel-gfx] [PATCH 14/19] drm/i915/oprom: Basic sanitization

2021-09-17 Thread Lucas De Marchi
On Mon, May 17, 2021 at 02:57:33PM +0300, Jani Nikula wrote: On Mon, 12 Apr 2021, Matthew Auld wrote: From: Anshuman Gupta Sanitize OPROM header, CPD signature and OPROM PCI version. OPROM_HEADER, EXPANSION_ROM_HEADER and OPROM_MEU_BLOB structures and PCI struct offsets are provided by GSC co

[Intel-gfx] [PATCH v10 13/17] drm/i915/pxp: Add plane decryption support

2021-09-17 Thread Alan Previn
From: Anshuman Gupta Add support to enable/disable PLANE_SURF Decryption Request bit. It requires only to enable plane decryption support when following condition met. 1. PXP session is enabled. 2. Buffer object is protected. v2: - Used gen fb obj user_flags instead gem_object_metadata. [Krishna

[Intel-gfx] [PATCH v10 14/17] drm/i915/pxp: black pixels on pxp disabled

2021-09-17 Thread Alan Previn
From: Anshuman Gupta When protected sufaces has flipped and pxp session is disabled, display black pixels by using plane color CTM correction. v2: - Display black pixels in async flip too. v3: - Removed the black pixels logic for async flip. [Ville] - Used plane state to force black pixels. [Vi

[Intel-gfx] [PATCH v10 02/17] mei: pxp: export pavp client to me client bus

2021-09-17 Thread Alan Previn
From: Vitaly Lubart Export PAVP client to work with i915 driver, for binding it uses kernel component framework. v2:drop debug prints, refactor match code to match mei_hdcp (Tomas) Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler Signed-off-by: Daniele Ceraolo Spurio Reviewed-by: Ro

[Intel-gfx] [PATCH v10 17/17] drm/i915/pxp: enable PXP for integrated Gen12

2021-09-17 Thread Alan Previn
From: Daniele Ceraolo Spurio Note that discrete cards can support PXP as well, but we haven't tested on those yet so keeping it disabled for now. Signed-off-by: Daniele Ceraolo Spurio Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_pci.c | 2 ++ 1 file changed, 2 insertions(+) diff -

[Intel-gfx] [PATCH v10 07/17] drm/i915/pxp: Create the arbitrary session after boot

2021-09-17 Thread Alan Previn
From: "Huang, Sean Z" Create the arbitrary session, with the fixed session id 0xf, after system boot, for the case that application allocates the protected buffer without establishing any protection session. Because the hardware requires at least one alive session for protected buffer creation. T

[Intel-gfx] [PATCH v10 10/17] drm/i915/pxp: interfaces for using protected objects

2021-09-17 Thread Alan Previn
From: Daniele Ceraolo Spurio This api allow user mode to create protected buffers and to mark contexts as making use of such objects. Only when using contexts marked in such a way is the execution guaranteed to work as expected. Contexts can only be marked as using protected content at creation

[Intel-gfx] [PATCH v10 09/17] drm/i915/pxp: Implement PXP irq handler

2021-09-17 Thread Alan Previn
From: "Huang, Sean Z" The HW will generate a teardown interrupt when session termination is required, which requires i915 to submit a terminating batch. Once the HW is done with the termination it will generate another interrupt, at which point it is safe to re-create the session. Since the term

[Intel-gfx] [PATCH v10 08/17] drm/i915/pxp: Implement arb session teardown

2021-09-17 Thread Alan Previn
From: "Huang, Sean Z" Teardown is triggered when the display topology changes and no long meets the secure playback requirement, and hardware trashes all the encryption keys for display. Additionally, we want to emit a teardown operation to make sure we're clean on boot and resume v2: emit in th

[Intel-gfx] [PATCH v10 15/17] drm/i915/pxp: add pxp debugfs

2021-09-17 Thread Alan Previn
From: Daniele Ceraolo Spurio 2 debugfs files, one to query the current status of the pxp session and one to trigger an invalidation for testing. v2: rename debugfs, fix date (Alan) Signed-off-by: Daniele Ceraolo Spurio Reviewed-by : Alan Previn Reviewed-by: Alan Previn --- drivers/gpu/drm/i

[Intel-gfx] [PATCH v10 16/17] drm/i915/pxp: add PXP documentation

2021-09-17 Thread Alan Previn
From: Daniele Ceraolo Spurio Now that all the pieces are in place we can add a description of how the feature works. Also modify the comments in struct intel_pxp into kerneldoc. v2: improve doc (Rodrigo) Signed-off-by: Daniele Ceraolo Spurio Cc: Daniel Vetter Cc: Rodrigo Vivi Reviewed-by: Ro

[Intel-gfx] [PATCH v10 11/17] drm/i915/pxp: start the arb session on demand

2021-09-17 Thread Alan Previn
From: Daniele Ceraolo Spurio Now that we can handle destruction and re-creation of the arb session, we can postpone the start of the session to the first submission that requires it, to avoid keeping it running with no user. Signed-off-by: Alan Previn Signed-off-by: Daniele Ceraolo Spurio Revi

[Intel-gfx] [PATCH v10 12/17] drm/i915/pxp: Enable PXP power management

2021-09-17 Thread Alan Previn
From: "Huang, Sean Z" During the power event S3+ sleep/resume, hardware will lose all the encryption keys for every hardware session, even though the session state might still be marked as alive after resume. Therefore, we should consider the session as dead on suspend and invalidate all the obje

[Intel-gfx] [PATCH v10 05/17] drm/i915/pxp: Implement funcs to create the TEE channel

2021-09-17 Thread Alan Previn
From: "Huang, Sean Z" Implement the funcs to create the TEE channel, so kernel can send the TEE commands directly to TEE for creating the arbitrary (default) session. v2: fix locking, don't pollute dev_priv (Chris) v3: wait for mei PXP component to be bound. v4: drop the wait, as the component

[Intel-gfx] [PATCH v10 06/17] drm/i915/pxp: set KCR reg init

2021-09-17 Thread Alan Previn
From: Daniele Ceraolo Spurio The setting is required by hardware to allow us doing further protection operation such as sending commands to GPU or TEE. The register needs to be re-programmed on resume, so for simplicitly we bundle the programming with the component binding, which is automatically

[Intel-gfx] [PATCH v10 03/17] drm/i915/pxp: define PXP device flag and kconfig

2021-09-17 Thread Alan Previn
From: Daniele Ceraolo Spurio Ahead of the PXP implementation, define the relevant define flag and kconfig option. v2: flip kconfig default to N. Some machines have IFWIs that do not support PXP, so we need it to be an opt-in until we add support to query the caps from the mei device. Signed-off

[Intel-gfx] [PATCH v10 00/17] drm/i915: Introduce Intel PXP

2021-09-17 Thread Alan Previn
PXP (Protected Xe Path) is an i915 component, available on GEN12 and newer platforms, that helps to establish the hardware protected session and manage the status of the alive software session, as well as its life cycle. changes from v9: - Patch #3 - change comments from "Gen12+" to "Gen12 and new

[Intel-gfx] [PATCH v10 04/17] drm/i915/pxp: allocate a vcs context for pxp usage

2021-09-17 Thread Alan Previn
From: Daniele Ceraolo Spurio The context is required to send the session termination commands to the VCS, which will be implemented in a follow-up patch. We can also use the presence of the context as a check of pxp initialization completion. v2: use perma-pinned context (Chris) v3: rename pinne

[Intel-gfx] [PATCH v10 01/17] drm/i915/pxp: Define PXP component interface

2021-09-17 Thread Alan Previn
From: Daniele Ceraolo Spurio This will be used for communication between the i915 driver and the mei one. Defining it in a stand-alone patch to avoid circualr dependedencies between the patches modifying the 2 drivers. Split out from an original patch from Huang, Sean Z v2: rename the componen

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/4] drm/i915: rename debugfs_gt files

2021-09-17 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: rename debugfs_gt files URL : https://patchwork.freedesktop.org/series/94827/ State : success == Summary == CI Bug Log - changes from CI_DRM_10605 -> Patchwork_21095 Summa

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/4] drm/i915: rename debugfs_gt files

2021-09-17 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: rename debugfs_gt files URL : https://patchwork.freedesktop.org/series/94827/ State : warning == Summary == $ dim checkpatch origin/drm-tip b981772f1a36 drm/i915: rename debugfs_gt files -:170: WARNING:FILE_PATH_CHANGES: adde

[Intel-gfx] [CI 1/4] drm/i915: rename debugfs_gt files

2021-09-17 Thread Lucas De Marchi
We shouldn't be using debugfs_ namespace for this functionality. Rename debugfs_gt.[ch] to intel_gt_debugfs.[ch] and then make functions, defines and structs follow suit. While at it and since we are renaming the header, sort the includes alphabetically. Signed-off-by: Lucas De Marchi Acked-by:

[Intel-gfx] [CI 3/4] drm/i915: rename debugfs_gt_pm files

2021-09-17 Thread Lucas De Marchi
We shouldn't be using debugfs_ namespace for this functionality. Rename debugfs_gt_pm.[ch] to intel_gt_pm_debugfs.[ch] and then make functions, defines and structs follow suit. Signed-off-by: Lucas De Marchi Acked-by: Jani Nikula Reviewed-by: Matt Roper --- drivers/gpu/drm/i915/Makefile

[Intel-gfx] [CI 4/4] drm/i915: deduplicate frequency dump on debugfs

2021-09-17 Thread Lucas De Marchi
Although commit 9dd4b065446a ("drm/i915/gt: Move pm debug files into a gt aware debugfs") says it was moving debug files to gt/, the i915_frequency_info file was left behind and its implementation copied into drivers/gpu/drm/i915/gt/debugfs_gt_pm.c. Over time we had several patches having to change

[Intel-gfx] [CI 2/4] drm/i915: rename debugfs_engines files

2021-09-17 Thread Lucas De Marchi
We shouldn't be using debugfs_ namespace for this functionality. Rename debugfs_engines.[ch] to intel_gt_engines_debugfs.[ch] and then make functions, defines and structs follow suit. Signed-off-by: Lucas De Marchi Acked-by: Jani Nikula Reviewed-by: Matt Roper --- drivers/gpu/drm/i915/Makefile

[Intel-gfx] ✗ Fi.CI.BAT: failure for Check SFC fusing on Xe_HP (rev3)

2021-09-17 Thread Patchwork
== Series Details == Series: Check SFC fusing on Xe_HP (rev3) URL : https://patchwork.freedesktop.org/series/94808/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10605 -> Patchwork_21094 Summary --- **FAILURE** Se

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: fix blank screen booting crashes (rev2)

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915: fix blank screen booting crashes (rev2) URL : https://patchwork.freedesktop.org/series/94822/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10605_full -> Patchwork_21092_full Summary -

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Check SFC fusing on Xe_HP (rev3)

2021-09-17 Thread Patchwork
== Series Details == Series: Check SFC fusing on Xe_HP (rev3) URL : https://patchwork.freedesktop.org/series/94808/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/gt/intel_

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Make wa list per-gt (rev2)

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915: Make wa list per-gt (rev2) URL : https://patchwork.freedesktop.org/series/94811/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10605_full -> Patchwork_21091_full Summary --- **F

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dg1: Read OPROM via SPI controller

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915/dg1: Read OPROM via SPI controller URL : https://patchwork.freedesktop.org/series/94826/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10605 -> Patchwork_21093 Summary --- **FAIL

Re: [Intel-gfx] 5.15-rc1 i915 blank screen booting on ThinkPads

2021-09-17 Thread Hugh Dickins
On Thu, 16 Sep 2021, Jani Nikula wrote: > On Thu, 16 Sep 2021, Tvrtko Ursulin wrote: > > On 16/09/2021 05:37, Hugh Dickins wrote: > >> Two Lenovo ThinkPads, old T420s (2011), newer X1 Carbon 5th gen (2017): > >> i915 working fine on both up to 5.14, but blank screens booting 5.15-rc1, > >> kernel

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dg1: Read OPROM via SPI controller

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915/dg1: Read OPROM via SPI controller URL : https://patchwork.freedesktop.org/series/94826/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4fda5dd183cb drm/i915/dg1: Read OPROM via SPI controller -:63: WARNING:OOM_MESSAGE: Possible unnecessary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: fix blank screen booting crashes (rev2)

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915: fix blank screen booting crashes (rev2) URL : https://patchwork.freedesktop.org/series/94822/ State : success == Summary == CI Bug Log - changes from CI_DRM_10605 -> Patchwork_21092 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for 5.15-rc1 i915 blank screen booting on ThinkPads

2021-09-17 Thread Patchwork
== Series Details == Series: 5.15-rc1 i915 blank screen booting on ThinkPads URL : https://patchwork.freedesktop.org/series/94820/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10605_full -> Patchwork_21089_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Make wa list per-gt (rev2)

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915: Make wa list per-gt (rev2) URL : https://patchwork.freedesktop.org/series/94811/ State : success == Summary == CI Bug Log - changes from CI_DRM_10605 -> Patchwork_21091 Summary --- **WARNING**

[Intel-gfx] ✗ Fi.CI.BAT: failure for Check SFC fusing on Xe_HP (rev2)

2021-09-17 Thread Patchwork
== Series Details == Series: Check SFC fusing on Xe_HP (rev2) URL : https://patchwork.freedesktop.org/series/94808/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10605 -> Patchwork_21090 Summary --- **FAILURE** Se

[Intel-gfx] [PATCH] drm/i915/dg1: Read OPROM via SPI controller

2021-09-17 Thread Lucas De Marchi
From: Clint Taylor Read OPROM SPI through MMIO and find VBT entry since we can't use OpRegion and PCI mapping may not work on some systems due to most BIOSes not leaving the Option ROM mapped. Cc: Ville Syrjälä Cc: Tomas Winkler Signed-off-by: Clint Taylor Signed-off-by: Lucas De Marchi Sign

[Intel-gfx] [PATCH] drm/i915: fix blank screen booting crashes

2021-09-17 Thread Matthew Brost
From: Hugh Dickins 5.15-rc1 crashes with blank screen when booting up on two ThinkPads using i915. Bisections converge convincingly, but arrive at different and surprising "culprits", none of them the actual culprit. netconsole (with init_netconsole() hacked to call i915_init() when logging has

[Intel-gfx] [PATCH] drm/i915: fix blank screen booting crashes

2021-09-17 Thread Matthew Brost
From: Hugh Dickins 5.15-rc1 crashes with blank screen when booting up on two ThinkPads using i915. Bisections converge convincingly, but arrive at different and surprising "culprits", none of them the actual culprit. netconsole (with init_netconsole() hacked to call i915_init() when logging has

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Add "intel_" as prefix in set_mocs_index() (rev3)

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915/gt: Add "intel_" as prefix in set_mocs_index() (rev3) URL : https://patchwork.freedesktop.org/series/94721/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10605_full -> Patchwork_21088_full ==

Re: [Intel-gfx] 5.15-rc1 i915 blank screen booting on ThinkPads

2021-09-17 Thread Matthew Brost
On Sat, Sep 18, 2021 at 01:52:48AM +0300, Jani Nikula wrote: > On Fri, 17 Sep 2021, Matthew Brost wrote: > > On Fri, Sep 17, 2021 at 02:26:48PM -0700, Hugh Dickins wrote: > >> On Thu, 16 Sep 2021, Jani Nikula wrote: > >> > On Thu, 16 Sep 2021, Tvrtko Ursulin > >> > wrote: > >> > > On 16/09/2021

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Check SFC fusing on Xe_HP (rev2)

2021-09-17 Thread Patchwork
== Series Details == Series: Check SFC fusing on Xe_HP (rev2) URL : https://patchwork.freedesktop.org/series/94808/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/gt/intel_

Re: [Intel-gfx] [PATCH 13/19] drm/i915/dg1: Read OPROM via SPI controller

2021-09-17 Thread Lucas De Marchi
On Mon, Apr 12, 2021 at 10:05:20AM +0100, Matthew Auld wrote: From: Clint Taylor Read OPROM SPI through MMIO and find VBT entry since we can't use OpRegion and PCI mapping may not work on some systems due to the BIOS not leaving the Option ROM mapped. I was surprised to see we still don't hav

Re: [Intel-gfx] [PATCH 15/15] doc: drm: remove TODO entry regarding DRM_MODSET_LOCK_ALL cleanup

2021-09-17 Thread Fernando Ramos
> Can we remove drm_modeset_lock_all[_ctx] now? If so, let's queue that up as > part > of the set. > drm_modeset_lock_all() and drm_modeset_unlock_all() can be removed (I'll do that on v2 of this patch series). drm_modset_lock_all_ctx() is a different story and there are still two places (one i

Re: [Intel-gfx] [PATCH 14/15] drm/amd: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-17 Thread Fernando Ramos
> > + struct drm_modeset_acquire_ctx ctx; > > int r; > > + int ret; > > Relocate ret with r please Done! > > - drm_modeset_unlock_all(dev); > > + DRM_MODESET_LOCK_ALL_END(dev, ctx, ret); > > You should check ret here Done! > > int r; > > + int ret; > > Relocate ret with r

Re: [Intel-gfx] [PATCH 12/15] drm/i915: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-17 Thread Fernando Ramos
> > int i; > > + int ret; > > Please move up with i Done! > > + DRM_MODESET_LOCK_ALL_END((&dev_priv->drm), ctx, ret); > > > > return 0; > > Return ret here Done! > > + struct drm_modeset_acquire_ctx ctx; > > int i; > > + int ret; > > Please move up with i Done! > >

Re: [Intel-gfx] 5.15-rc1 i915 blank screen booting on ThinkPads

2021-09-17 Thread Jani Nikula
On Fri, 17 Sep 2021, Matthew Brost wrote: > On Fri, Sep 17, 2021 at 02:26:48PM -0700, Hugh Dickins wrote: >> On Thu, 16 Sep 2021, Jani Nikula wrote: >> > On Thu, 16 Sep 2021, Tvrtko Ursulin wrote: >> > > On 16/09/2021 05:37, Hugh Dickins wrote: >> > >> Two Lenovo ThinkPads, old T420s (2011), newe

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915/display/dmc: Set DC_STATE_DEBUG_MASK_CORES after firmware load

2021-09-17 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display/dmc: Set DC_STATE_DEBUG_MASK_CORES after firmware load URL : https://patchwork.freedesktop.org/series/94819/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10605_full -> Patchwork_21087_full =

Re: [Intel-gfx] [PATCH 11/15] drm/msm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-17 Thread Fernando Ramos
> > int i, out_width; > > + int ret; > > Please put ret with i & out_width Done! > > - drm_modeset_unlock_all(crtc->dev); > > + DRM_MODESET_LOCK_ALL_END(crtc->dev, ctx, ret); > > > > return 0; > > Return ret here Done!

[Intel-gfx] ✓ Fi.CI.BAT: success for 5.15-rc1 i915 blank screen booting on ThinkPads

2021-09-17 Thread Patchwork
== Series Details == Series: 5.15-rc1 i915 blank screen booting on ThinkPads URL : https://patchwork.freedesktop.org/series/94820/ State : success == Summary == CI Bug Log - changes from CI_DRM_10605 -> Patchwork_21089 Summary --- **

Re: [Intel-gfx] [PATCH 09/15] drm/omapdrm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-17 Thread Fernando Ramos
> > - drm_modeset_unlock_all(fb->dev); > > + DRM_MODESET_LOCK_ALL_END(fb->dev, ctx, ret); > > > > return 0; > > Return ret here. Done!

Re: [Intel-gfx] [PATCH 06/15] drm/tegra: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-17 Thread Fernando Ramos
> > int err = 0; > > + int ret; > > You can use err here instead. Done!

Re: [Intel-gfx] [PATCH 08/15] drm/radeon: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-17 Thread Fernando Ramos
> > + struct drm_modeset_acquire_ctx ctx; > > int i, r; > > + int ret; > > Could you please tuck this up with i & r? Done! > > - drm_modeset_unlock_all(dev); > > + DRM_MODESET_LOCK_ALL_END(dev, ctx, ret); > > You should check ret here Would it be save to return at this point if th

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for 5.15-rc1 i915 blank screen booting on ThinkPads

2021-09-17 Thread Patchwork
== Series Details == Series: 5.15-rc1 i915 blank screen booting on ThinkPads URL : https://patchwork.freedesktop.org/series/94820/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0a23b1f1e8f8 5.15-rc1 i915 blank screen booting on ThinkPads -:7: WARNING:COMMIT_LOG_LONG_LINE: Possi

Re: [Intel-gfx] [PATCH 01/15] dmr: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-17 Thread Fernando Ramos
> > Could you please fix the subject, changing dmr to drm? > Ups! Sure, I'll fix that. Thanks for noticing. > > I think you can just reuse 'ret' instead of creating a new variable. That > ensures if the lock fails we return the error from the macros. > I didn't reuse "ret" because otherwise

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Add "intel_" as prefix in set_mocs_index() (rev3)

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915/gt: Add "intel_" as prefix in set_mocs_index() (rev3) URL : https://patchwork.freedesktop.org/series/94721/ State : success == Summary == CI Bug Log - changes from CI_DRM_10605 -> Patchwork_21088 Summar

Re: [Intel-gfx] [PATCH 00/15] drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers where possible

2021-09-17 Thread Fernando Ramos
On 21/09/17 05:24PM, Daniel Vetter wrote: > > Can we at least replace those with drm_modeset_lock_all_ctx and delete > drm_modeset_lock_all? That would be really nice goal to make sure these > don't spread further. I just checked and turns out no one else is using "drm_modeset_lock_all()" anymore.

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/display/dmc: Set DC_STATE_DEBUG_MASK_CORES after firmware load

2021-09-17 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display/dmc: Set DC_STATE_DEBUG_MASK_CORES after firmware load URL : https://patchwork.freedesktop.org/series/94819/ State : success == Summary == CI Bug Log - changes from CI_DRM_10605 -> Patchwork_21087 ===

Re: [Intel-gfx] 5.15-rc1 i915 blank screen booting on ThinkPads

2021-09-17 Thread Matthew Brost
On Fri, Sep 17, 2021 at 02:26:48PM -0700, Hugh Dickins wrote: > On Thu, 16 Sep 2021, Jani Nikula wrote: > > On Thu, 16 Sep 2021, Tvrtko Ursulin wrote: > > > On 16/09/2021 05:37, Hugh Dickins wrote: > > >> Two Lenovo ThinkPads, old T420s (2011), newer X1 Carbon 5th gen (2017): > > >> i915 working f

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915/display: Workaround cursor left overs with PSR2 selective fetch enabled

2021-09-17 Thread Souza, Jose
On Fri, 2021-09-17 at 20:49 +0300, Ville Syrjälä wrote: > On Fri, Sep 17, 2021 at 05:02:21PM +, Souza, Jose wrote: > > On Fri, 2021-09-17 at 16:04 +0300, Ville Syrjälä wrote: > > > On Thu, Sep 16, 2021 at 05:09:08PM +, Souza, Jose wrote: > > > > On Thu, 2021-09-16 at 16:17 +0300, Ville Syrj

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/display/dmc: Set DC_STATE_DEBUG_MASK_CORES after firmware load

2021-09-17 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display/dmc: Set DC_STATE_DEBUG_MASK_CORES after firmware load URL : https://patchwork.freedesktop.org/series/94819/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each co

Re: [Intel-gfx] [PATCH 1/3] drm/i915/display/dmc: Set DC_STATE_DEBUG_MASK_CORES after firmware load

2021-09-17 Thread Imre Deak
On Fri, Sep 17, 2021 at 01:52:39PM -0700, José Roberto de Souza wrote: > Specification asks for DC_STATE_DEBUG_MASK_CORES to be set for all > platforms that supports DMC, not only for geminilake and broxton. According to the spec it's only required for BXT and GLK, see Bspec 4234, 49193, 49194. T

Re: [Intel-gfx] [PATCH v2 13/13] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2021-09-17 Thread Sean Paul
On Thu, Sep 16, 2021 at 11:00:25PM -0700, Stephen Boyd wrote: > Quoting Sean Paul (2021-09-15 13:38:32) /snip > > diff --git a/drivers/gpu/drm/msm/dp/dp_debug.c > > b/drivers/gpu/drm/msm/dp/dp_debug.c > > index 2f6247e80e9d..de16fca8782a 100644 > > --- a/drivers/gpu/drm/msm/dp/dp_debug.c > > +++

[Intel-gfx] [PATCH 3/3] drm/i915/display: Match PSR2 selective fetch sequences with specification

2021-09-17 Thread José Roberto de Souza
We were not completely following the selective fetch programming sequence, here some things we were doing wrong: - not programming plane selective fetch a PSR2_MAN_TRK_CTL registers when doing a modeset - programming PSR2_MAN_TRK_CTL out of vblank With this changes the last remainig underrun found

[Intel-gfx] [PATCH 2/3] drm/i915/display: Wait PSR2 get out of deep sleep to update pipe

2021-09-17 Thread José Roberto de Souza
Alderlake-P was getting 'max time under evasion' messages when PSR2 was enabled, this is due PIPE_SCANLINE/PIPEDSL returning 0 over a period of time longer than VBLANK_EVASION_TIME_US. For PSR1 we had the same issue so intel_psr_wait_for_idle() was implemented to wait for PSR1 to get into idle sta

[Intel-gfx] [PATCH 1/3] drm/i915/display/dmc: Set DC_STATE_DEBUG_MASK_CORES after firmware load

2021-09-17 Thread José Roberto de Souza
Specification asks for DC_STATE_DEBUG_MASK_CORES to be set for all platforms that supports DMC, not only for geminilake and broxton. While at is also taking the oportunity to simply the code. BSpec: 7402 BSpec: 49436 Cc: Imre Deak Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- d

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/5] drm/i915/display/adlp: Fix PSR2_MAN_TRK_CTL_SU_REGION_END_ADDR calculation (rev5)

2021-09-17 Thread Souza, Jose
On Fri, 2021-09-17 at 04:29 +, Patchwork wrote: > Patch Details > Series: series starting with [v2,1/5] drm/i915/display/adlp: Fix > PSR2_MAN_TRK_CTL_SU_REGION_END_ADDR calculation (rev5) > URL: https://patchwork.freedesktop.org/series/94674/ > State:failure > Details: > h

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Make wa list per-gt

2021-09-17 Thread Matt Roper
On Fri, Sep 17, 2021 at 05:44:55PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Make wa list per-gt > URL : https://patchwork.freedesktop.org/series/94811/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_10604 -> Patchwork_21086 > ==

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915/display: Workaround cursor left overs with PSR2 selective fetch enabled

2021-09-17 Thread Ville Syrjälä
On Fri, Sep 17, 2021 at 05:02:21PM +, Souza, Jose wrote: > On Fri, 2021-09-17 at 16:04 +0300, Ville Syrjälä wrote: > > On Thu, Sep 16, 2021 at 05:09:08PM +, Souza, Jose wrote: > > > On Thu, 2021-09-16 at 16:17 +0300, Ville Syrjälä wrote: > > > > On Wed, Sep 15, 2021 at 06:18:35PM +, Sou

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Make wa list per-gt

2021-09-17 Thread Patchwork
== Series Details == Series: drm/i915: Make wa list per-gt URL : https://patchwork.freedesktop.org/series/94811/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10604 -> Patchwork_21086 Summary --- **FAILURE** Serio

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Check SFC fusing before recording/dumping SFC_DONE

2021-09-17 Thread Souza, Jose
On Fri, 2021-09-17 at 09:12 -0700, Matt Roper wrote: > On Xe_HP and beyond the SFC unit may be fused off, even if the > corresponding media engines are present. Check the SFC-specific fusing > before trying to dump the SFC_DONE instances. Reviewed-by: José Roberto de Souza > > Cc: José Roberto

Re: [Intel-gfx] [PATCH 1/2] drm/i915/xehp: Check new fuse bits for SFC availability

2021-09-17 Thread Souza, Jose
On Fri, 2021-09-17 at 09:12 -0700, Matt Roper wrote: > Xe_HP adds some new bits to the FUSE1 register to let us know whether a > given SFC unit is present. We should take this into account while > initializing SFC availability to our VCS and VECS engines. > > While we're at it, update the FUSE1 r

Re: [Intel-gfx] [PATCH v2 10/13] drm/msm/dpu: Remove encoder->enable() hack

2021-09-17 Thread Sean Paul
On Thu, Sep 16, 2021 at 08:53:50PM -0700, Stephen Boyd wrote: > Quoting Sean Paul (2021-09-15 13:38:29) > > From: Sean Paul > > > > encoder->commit() was being misused because there were some global > > resources which needed to be tweaked in encoder->enable() which were not > > accessible in dpu_

[Intel-gfx] [PATCH] drm/i915: Make wa list per-gt

2021-09-17 Thread Matt Roper
From: Venkata Sandeep Dhanalakota Support for multiple GT's within a single i915 device will be arriving soon. Since each GT may have its own fusing and require different workarounds, we need to make the GT workaround functions and multicast steering setup per-gt. Cc: Tvrtko Ursulin Cc: Daniel

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Add privacy-screen support

2021-09-17 Thread Ville Syrjälä
On Fri, Sep 17, 2021 at 06:42:04PM +0200, Hans de Goede wrote: > Hi, > > On 9/17/21 6:25 PM, Ville Syrjälä wrote: > > On Fri, Sep 17, 2021 at 04:37:14PM +0200, Hans de Goede wrote: > >> Hi, > >> > >> On 9/16/21 3:45 PM, Ville Syrjälä wrote: > >>> On Mon, Sep 06, 2021 at 09:35:19AM +0200, Hans de G

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915/display: Workaround cursor left overs with PSR2 selective fetch enabled

2021-09-17 Thread Souza, Jose
On Fri, 2021-09-17 at 16:04 +0300, Ville Syrjälä wrote: > On Thu, Sep 16, 2021 at 05:09:08PM +, Souza, Jose wrote: > > On Thu, 2021-09-16 at 16:17 +0300, Ville Syrjälä wrote: > > > On Wed, Sep 15, 2021 at 06:18:35PM +, Souza, Jose wrote: > > > > On Wed, 2021-09-15 at 17:58 +0300, Ville Syrj

Re: [Intel-gfx] [PATCH v3 00/13] drm/i915/dp: dp 2.0 enabling prep work

2021-09-17 Thread Maxime Ripard
On Fri, Sep 17, 2021 at 03:54:23PM +0300, Jani Nikula wrote: > On Thu, 09 Sep 2021, Jani Nikula wrote: > > v3 of https://patchwork.freedesktop.org/series/93800/ with minor tweaks > > and the already merged patches obviously dropped. > > > > Jani Nikula (13): > > drm/dp: add DP 2.0 UHBR link rate

[Intel-gfx] ✗ Fi.CI.BAT: failure for Check SFC fusing on Xe_HP

2021-09-17 Thread Patchwork
== Series Details == Series: Check SFC fusing on Xe_HP URL : https://patchwork.freedesktop.org/series/94808/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10604 -> Patchwork_21085 Summary --- **FAILURE** Serious u

Re: [Intel-gfx] [PATCH v2 0/9] Move vfio_ccw to the new mdev API

2021-09-17 Thread Jason Gunthorpe
On Fri, Sep 17, 2021 at 01:59:16PM +0200, Cornelia Huck wrote: > > ret = cio_cancel_halt_clear(sch, &iretry); > > - > > if (ret == -EIO) { > > pr_err("vfio_ccw: could not quiesce subchannel > > 0.%x.%04x!\n", > >sch->schid.ssi

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Add privacy-screen support

2021-09-17 Thread Hans de Goede
Hi, On 9/17/21 6:25 PM, Ville Syrjälä wrote: > On Fri, Sep 17, 2021 at 04:37:14PM +0200, Hans de Goede wrote: >> Hi, >> >> On 9/16/21 3:45 PM, Ville Syrjälä wrote: >>> On Mon, Sep 06, 2021 at 09:35:19AM +0200, Hans de Goede wrote: Add support for eDP panels with a built-in privacy screen usin

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Check SFC fusing on Xe_HP

2021-09-17 Thread Patchwork
== Series Details == Series: Check SFC fusing on Xe_HP URL : https://patchwork.freedesktop.org/series/94808/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/gt/intel_engine_

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Add privacy-screen support

2021-09-17 Thread Ville Syrjälä
On Fri, Sep 17, 2021 at 04:37:14PM +0200, Hans de Goede wrote: > Hi, > > On 9/16/21 3:45 PM, Ville Syrjälä wrote: > > On Mon, Sep 06, 2021 at 09:35:19AM +0200, Hans de Goede wrote: > >> Add support for eDP panels with a built-in privacy screen using the > >> new drm_privacy_screen class. > >> > >>

[Intel-gfx] [PATCH 0/2] Check SFC fusing on Xe_HP

2021-09-17 Thread Matt Roper
Xe_HP adds some new fuse bits to indicate whether an SFC unit is fused off. We should utilize these when initializing VD/VE SFC access and also when capturing/dumping SFC_DONE for the error state. Matt Roper (2): drm/i915/xehp: Check new fuse bits for SFC availability drm/i915: Check SFC fusi

[Intel-gfx] [PATCH 2/2] drm/i915: Check SFC fusing before recording/dumping SFC_DONE

2021-09-17 Thread Matt Roper
On Xe_HP and beyond the SFC unit may be fused off, even if the corresponding media engines are present. Check the SFC-specific fusing before trying to dump the SFC_DONE instances. Cc: José Roberto de Souza Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_gpu_error.c | 6 -- 1 file c

[Intel-gfx] [PATCH 1/2] drm/i915/xehp: Check new fuse bits for SFC availability

2021-09-17 Thread Matt Roper
Xe_HP adds some new bits to the FUSE1 register to let us know whether a given SFC unit is present. We should take this into account while initializing SFC availability to our VCS and VECS engines. While we're at it, update the FUSE1 register definition to use REG_GENMASK / REG_FIELD_GET notation.

[Intel-gfx] [PATCH 1/2] drm/i915/xehp: Check new fuse bits for SFC availability

2021-09-17 Thread Matt Roper
Xe_HP adds some new bits to the FUSE1 register to let us know whether a given SFC unit is present. We should take this into account while initializing SFC availability to our VCS and VECS engines. While we're at it, update the FUSE1 register definition to use REG_GENMASK / REG_FIELD_GET notation.

[Intel-gfx] [PATCH 2/2] drm/i915: Check SFC fusing before recording/dumping SFC_DONE

2021-09-17 Thread Matt Roper
On Xe_HP and beyond the SFC unit may be fused off, even if the corresponding media engines are present. Check the SFC-specific fusing before trying to dump the SFC_DONE instances. Cc: José Roberto de Souza Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_gpu_error.c | 6 -- 1 file c

[Intel-gfx] [PATCH 0/2] Check SFC fusing on Xe_HP

2021-09-17 Thread Matt Roper
Xe_HP adds some new fuse bits to indicate whether an SFC unit is fused off. We should utilize these when initializing VD/VE SFC access and also when capturing/dumping SFC_DONE for the error state. Matt Roper (2): drm/i915/xehp: Check new fuse bits for SFC availability drm/i915: Check SFC fusi

Re: [Intel-gfx] [PATCH 15/15] doc: drm: remove TODO entry regarding DRM_MODSET_LOCK_ALL cleanup

2021-09-17 Thread Sean Paul
On Thu, Sep 16, 2021 at 11:15:52PM +0200, Fernando Ramos wrote: > The previous commits do exactly what this entry in the TODO file asks > for, thus we can remove it now as it is no longer applicable. Thanks for doing this work! Can we remove drm_modeset_lock_all[_ctx] now? If so, let's queue that

Re: [Intel-gfx] [PATCH 14/15] drm/amd: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-17 Thread Sean Paul
On Thu, Sep 16, 2021 at 11:15:51PM +0200, Fernando Ramos wrote: > As requested in Documentation/gpu/todo.rst, replace driver calls to > drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and > DRM_MODESET_LOCK_ALL_END() > > Signed-off-by: Fernando Ramos > --- > drivers/gpu/drm/amd/amdgpu/a

Re: [Intel-gfx] [PATCH 13/15] drm/gma500: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-17 Thread Sean Paul
On Thu, Sep 16, 2021 at 11:15:50PM +0200, Fernando Ramos wrote: > As requested in Documentation/gpu/todo.rst, replace driver calls to > drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and > DRM_MODESET_LOCK_ALL_END() > > Signed-off-by: Fernando Ramos > --- > drivers/gpu/drm/gma500/psb_d

Re: [Intel-gfx] [PATCH 12/15] drm/i915: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-17 Thread Sean Paul
On Thu, Sep 16, 2021 at 11:15:49PM +0200, Fernando Ramos wrote: > As requested in Documentation/gpu/todo.rst, replace driver calls to > drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and > DRM_MODESET_LOCK_ALL_END() > > Signed-off-by: Fernando Ramos > --- > drivers/gpu/drm/i915/display

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [01/26] dma-buf: add dma_resv_for_each_fence_unlocked v2

2021-09-17 Thread Patchwork
== Series Details == Series: series starting with [01/26] dma-buf: add dma_resv_for_each_fence_unlocked v2 URL : https://patchwork.freedesktop.org/series/94805/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10604_full -> Patchwork_21084_full ==

Re: [Intel-gfx] [PATCH 11/15] drm/msm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-17 Thread Sean Paul
On Thu, Sep 16, 2021 at 11:15:48PM +0200, Fernando Ramos wrote: > As requested in Documentation/gpu/todo.rst, replace driver calls to > drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and > DRM_MODESET_LOCK_ALL_END() > > Signed-off-by: Fernando Ramos > --- > drivers/gpu/drm/msm/disp/dpu

  1   2   >