Thanks for the remind, indeed miss a lock. Patch is:
Reviewed-by: Qiang Yu
Regards,
Qiang
On Fri, Aug 13, 2021 at 3:28 AM Daniel Vetter wrote:
>
> On Thu, Aug 05, 2021 at 12:46:53PM +0200, Daniel Vetter wrote:
> > Nothing special going on here.
> >
> > Aside reviewing the code, it seems like dr
== Series Details ==
Series: series starting with [01/11] drm/i915: Release i915_gem_context from a
worker
URL : https://patchwork.freedesktop.org/series/93693/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10484_full -> Patchwork_20821_full
==
On 8/3/2021 6:23 PM, Matthew Brost wrote:
From: "Signed-off-by: John Harrison"
When GuC submission is enabled, GuC itself manages hang detection and
recovery. Therefore, any test that relies on being able to trigger an
engine reset in the driver will fail. Full GT resets can still be
trigger
On 8/3/2021 6:23 PM, Matthew Brost wrote:
The i915 currently has 2k visible priority levels which are currently
unique. This is changing to statically map these 2k levels into 3
buckets:
low: < 0
mid: 0
high: > 0
Update gem_exec_schedule to understand this. This entails updating
promotion te
== Series Details ==
Series: series starting with [01/11] drm/i915: Release i915_gem_context from a
worker
URL : https://patchwork.freedesktop.org/series/93693/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10484 -> Patchwork_20821
== Series Details ==
Series: series starting with [01/11] drm/i915: Release i915_gem_context from a
worker
URL : https://patchwork.freedesktop.org/series/93693/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked
== Series Details ==
Series: series starting with [01/11] drm/i915: Release i915_gem_context from a
worker
URL : https://patchwork.freedesktop.org/series/93693/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
3d5b2e6041c2 drm/i915: Release i915_gem_context from a worker
-:94: WA
== Series Details ==
Series: dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and use in DRM
URL : https://patchwork.freedesktop.org/series/93683/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10482_full -> Patchwork_20820_full
We don't need the absolute speed of rcu for this. And
i915_address_space in general dont need rcu protection anywhere else,
after we've made gem contexts and engines a lot more immutable.
Note that this semantically reverts
commit aabbe344dc3ca5f7d8263a02608ba6179e8a4499
Author: Chris Wilson
Dat
The comment added in
commit b81dde719439c8f09bb61e742ed95bfc4b33946b
Author: Chris Wilson
Date: Tue May 21 22:11:29 2019 +0100
drm/i915: Allow userspace to clone contexts on creation
and moved in
commit 27dbae8f36c1c25008b7885fc07c57054b7dfba3
Author: Chris Wilson
It's been invariant since
commit ccbc1b97948ab671335e950271e39766729736c3
Author: Jason Ekstrand
Date: Thu Jul 8 10:48:30 2021 -0500
drm/i915/gem: Don't allow changing the VM on running contexts (v4)
this just completes the deed. I've tried to split out prep work for
more
The full audit is quite a bit of work:
- i915_dpt has very simple lifetime (somehow we create a display pagetable vm
per object, so its _very_ simple, there's only ever a single vma in there),
and uses i915_vm_close(), which internally does a i915_vm_put(). No rcu.
Aside: wtf is i915_dpt do
Since
commit ccbc1b97948ab671335e950271e39766729736c3
Author: Jason Ekstrand
Date: Thu Jul 8 10:48:30 2021 -0500
drm/i915/gem: Don't allow changing the VM on running contexts (v4)
the gem_ctx->vm can't change anymore. Plus we always set the
intel_context->vm, so might as well use the help
Changing the vm from a finalized gem ctx is no longer possible, which
means we don't have to check for that anymore.
I was pondering whether to keep the check as a WARN_ON, but things go
boom real bad real fast if the vm of a vma is wrong. Plus we'd need to
also get the ggtt vm for !full-ppgtt pla
Consolidates the "which is the vm my execbuf runs in" code a bit. We
do some get/put which isn't really required, but all the other users
want the refcounting, and I figured doing a function just for this
getparam to avoid 2 atomis is a bit much.
Signed-off-by: Daniel Vetter
Cc: Jon Bloomfield
C
And use it anywhere we have open-coded checks for ctx->vm that really
only check for full ppgtt.
Plus for paranoia add a GEM_BUG_ON that checks it's really only set
when we have full ppgtt, just in case. gem_context->vm is different
since it's NULL in ggtt mode, unlike intel_context->vm or gt->vm,
The important part isn't so much that this does an rcu lookup - that's
more an implementation detail, which will also be removed.
The thing that makes this different from other functions is that it's
gettting you the vm that batchbuffers will run in for that gem
context, which is either a full ppg
gem context refcounting is another exercise in least locking design it
seems, where most things get destroyed upon context closure (which can
race with anything really). Only the actual memory allocation and the
locks survive while holding a reference.
This tripped up Jason when reimplementing the
The only reason for this really is the i915_gem_engines->fence
callback engines_notify(), which exists purely as a fairly funky
reference counting scheme for that. Otherwise all other callers are
from process context, and generally fairly benign locking context.
Unfortunately untangling that requi
== Series Details ==
Series: drm/i915, drm/ttm: Update the ttm_move_memcpy() interface (rev3)
URL : https://patchwork.freedesktop.org/series/91893/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10482_full -> Patchwork_20819_full
On Fri, Aug 13, 2021 at 10:54:25PM +0300, Jani Nikula wrote:
> On Fri, 13 Aug 2021, Jani Nikula wrote:
> > On Fri, 13 Aug 2021, Matt Roper wrote:
> >> On Fri, Aug 13, 2021 at 02:51:50PM +0300, Jani Nikula wrote:
> >>> We use encoder->get_buf_trans() in many places, for example
> >>> intel_ddi_dp_
On Fri, 13 Aug 2021, Jani Nikula wrote:
> On Fri, 13 Aug 2021, Matt Roper wrote:
>> On Fri, Aug 13, 2021 at 02:51:50PM +0300, Jani Nikula wrote:
>>> We use encoder->get_buf_trans() in many places, for example
>>> intel_ddi_dp_voltage_max(), and the hook was set to some old platform's
>>> function
== Series Details ==
Series: drm: update the ioctl handler
URL : https://patchwork.freedesktop.org/series/93677/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10482_full -> Patchwork_20818_full
Summary
---
**SUCCESS*
On Fri, 13 Aug 2021, Matt Roper wrote:
> On Fri, Aug 13, 2021 at 02:51:50PM +0300, Jani Nikula wrote:
>> We use encoder->get_buf_trans() in many places, for example
>> intel_ddi_dp_voltage_max(), and the hook was set to some old platform's
>> function for DG2 SNPS PHY. Convert SNPS PHY to use the
On Fri, 13 Aug 2021, Jani Nikula wrote:
> On Fri, 13 Aug 2021, Rodrigo Vivi wrote:
>> On Fri, Aug 13, 2021 at 02:56:10PM +0300, Jani Nikula wrote:
>>> Less is more, fewer lines to wonder about.
>>>
>>> Cc: Manasi Navare
>>> Signed-off-by: Jani Nikula
>>
>> Reviewed-by: Rodrigo Vivi
>
> Thanks
On Fri, 13 Aug 2021, "Sharma, Swati2" wrote:
> Please check CI results once; if regressions are unrelated please report.
> With those fixed.
>
> Reviewed-by:
> Swati Sharma
> Tested-by:
> Swati Sharma
Thanks, pushed. The CI failures are unrelated.
BR,
Jani.
>
> On 12-Aug-21 6:53 PM, Jani Niku
== Series Details ==
Series: drm/i915/dg2: DG2 intermediate DP source rates are different from CNL+
URL : https://patchwork.freedesktop.org/series/93675/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10482_full -> Patchwork_20817_full
==
On Fri, Aug 13, 2021 at 02:51:51PM +0300, Jani Nikula wrote:
> UHBR link rates use different tx equalization settings. Using this will
> require changes in the link training code too.
>
> Bspec: 53920
> Cc: Manasi Navare
> Cc: Matt Roper
> Signed-off-by: Jani Nikula
Matches the bspec values.
On Fri, Aug 13, 2021 at 02:51:50PM +0300, Jani Nikula wrote:
> We use encoder->get_buf_trans() in many places, for example
> intel_ddi_dp_voltage_max(), and the hook was set to some old platform's
> function for DG2 SNPS PHY. Convert SNPS PHY to use the same translation
> mechanisms as everything e
On Fri, Aug 13, 2021 at 02:51:49PM +0300, Jani Nikula wrote:
> Needed in the future.
>
> Cc: Manasi Navare
> Cc: Matt Roper
> Signed-off-by: Jani Nikula
Reviewed-by: Matt Roper
> ---
> drivers/gpu/drm/i915/display/intel_ddi.c | 19 ++-
> 1 file changed, 10 insertions(+), 9 d
== Series Details ==
Series: drm/i915/mst: use intel_de_rmw() to simplify VC payload alloc set/clear
URL : https://patchwork.freedesktop.org/series/93674/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10482_full -> Patchwork_20816_full
=
On Fri, Aug 13, 2021 at 9:44 AM Andy Shevchenko
wrote:
>
> On Fri, Aug 13, 2021 at 09:17:10AM -0600, Jim Cromie wrote:
> > Add a const void* data member to the struct, to allow attaching
> > private data that will be used soon by a setter method (via kp->data)
> > to perform more elaborate actions
== Series Details ==
Series: dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and use in DRM
URL : https://patchwork.freedesktop.org/series/93683/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10482 -> Patchwork_20820
Summary
--
== Series Details ==
Series: series starting with [1/3] drm/i915/dp: pass crtc_state to
intel_ddi_dp_level()
URL : https://patchwork.freedesktop.org/series/93673/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10482_full -> Patchwork_20815_full
== Series Details ==
Series: dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and use in DRM
URL : https://patchwork.freedesktop.org/series/93683/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
9735d1bd2f6a moduleparam: add data member to struct kernel_param
-:62: ERROR:MISSING_SIGN_
== Series Details ==
Series: drm/i915, drm/ttm: Update the ttm_move_memcpy() interface (rev3)
URL : https://patchwork.freedesktop.org/series/91893/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10482 -> Patchwork_20819
Summ
On Fri, Aug 13, 2021 at 06:51:05PM +0300, Andy Shevchenko wrote:
> On Fri, Aug 13, 2021 at 09:17:11AM -0600, Jim Cromie wrote:
> > +int param_set_dyndbg(const char *instr, const struct kernel_param *kp)
> > +{
> > + unsigned long inbits;
> > + int rc, i, chgct = 0, totct = 0;
> > + char query
== Series Details ==
Series: drm/i915/gt: Potential error pointer dereference in pinned_context()
URL : https://patchwork.freedesktop.org/series/93670/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10482_full -> Patchwork_20814_full
On Fri, Aug 13, 2021 at 09:17:11AM -0600, Jim Cromie wrote:
> DEFINE_DYNAMIC_DEBUG_CATEGORIES(name, var, bitmap_desc, @bit_descs)
> allows users to define a drm.debug style (bitmap) sysfs interface, and
> to specify the desired mapping from bits[0-N] to the format-prefix'd
> pr_debug()s to be contr
On Fri, Aug 13, 2021 at 04:54:50PM +0800, Desmond Cheong Zhi Xi wrote:
> Since the last user of drm_ioctl_permit was removed, and it's now only
> used in drm_ioctl.c, unexport the symbol.
>
> Reported-by: Daniel Vetter
> Signed-off-by: Desmond Cheong Zhi Xi
Applied to drm-misc-next for 5.16, th
== Series Details ==
Series: drm: update the ioctl handler
URL : https://patchwork.freedesktop.org/series/93677/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10482 -> Patchwork_20818
Summary
---
**SUCCESS**
No re
On Fri, Aug 13, 2021 at 04:54:49PM +0800, Desmond Cheong Zhi Xi wrote:
> In drm_client_modeset.c and drm_fb_helper.c,
> drm_master_internal_{acquire,release} are used to avoid races with DRM
> userspace. These functions hold onto drm_device.master_mutex while
> committing, and bail if there's alrea
On Fri, Aug 13, 2021 at 09:17:10AM -0600, Jim Cromie wrote:
> Add a const void* data member to the struct, to allow attaching
> private data that will be used soon by a setter method (via kp->data)
> to perform more elaborate actions.
>
> To attach the data at compile time, add new macros:
>
> mo
On 8/13/2021 7:42 AM, Daniel Vetter wrote:
On Fri, Aug 13, 2021 at 04:37:53PM +0200, Daniel Vetter wrote:
On Wed, Jul 28, 2021 at 07:01:01PM -0700, Daniele Ceraolo Spurio wrote:
This api allow user mode to create protected buffers and to mark
contexts as making use of such objects. Only when
== Series Details ==
Series: drm: update the ioctl handler
URL : https://patchwork.freedesktop.org/series/93677/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+drivers/gpu/drm/amd/amdgpu/../displ
Sean Paul seanp...@chromium.org proposed, in
https://patchwork.freedesktop.org/series/78133/
drm/trace: Mirror DRM debug logs to tracefs
That patchset's goal is to be able to duplicate the debug stream to a
tracing destination, by splitting drm_debug_enabled() into syslog &
trace flavors, and enab
There are blocks of DRM_DEBUG calls, consolidate their args into
single calls. With dynamic-debug in use, each callsite consumes 56
bytes of ro callsite data, and this patch removes about 65 calls, so
it saves ~3.5kb.
no functional changes.
Signed-off-by: Jim Cromie
---
drivers/gpu/drm/amd/amd
drm's debug system writes 10 distinct categories of messages to syslog
using a small API[1]: drm_dbg*(10 names), DRM_DEBUG*(8 names),
DRM_DEV_DEBUG*(3 names). There are thousands of these callsites, each
categorized by their authors.
These callsites can be enabled at runtime by their category, ea
logger_types.h defines many DC_LOG_*() categorized debug wrappers.
Most of these use DRM debug API, so are controllable using drm.debug,
but others use bare pr_debug("$prefix: .."), each with a different
class-prefix matching "^\[\w+\]:"
Use DEFINE_DYNAMIC_DEBUG_CATEGORIES to create a /sys debug_d
The gvt component of this driver has ~120 pr_debugs, in 9 categories
quite similar to those in DRM. Following the interface model of
drm.debug, add a parameter to map bits to these categorizations.
DEFINE_DYNAMIC_DEBUG_CATEGORIES(debug_gvt, __gvt_debug,
"dyndbg bitmap desc",
{ "gv
Taking embedded spaces out of existing prefixes makes them better
class-prefixes; simplifying the nested quoting needed otherwise:
$> echo "format '^gvt: core:' +p" >control
Dropping the internal spaces means any trailing space in a query will
more clearly terminate the prefix being searched fo
DEFINE_DYNAMIC_DEBUG_CATEGORIES(name, var, bitmap_desc, @bit_descs)
allows users to define a drm.debug style (bitmap) sysfs interface, and
to specify the desired mapping from bits[0-N] to the format-prefix'd
pr_debug()s to be controlled.
DEFINE_DYNAMIC_DEBUG_CATEGORIES(debug_gvt, __gvt_debug,
Add a const void* data member to the struct, to allow attaching
private data that will be used soon by a setter method (via kp->data)
to perform more elaborate actions.
To attach the data at compile time, add new macros:
module_param_cbd() derives from module_param_cb(), adding data param,
and la
s/prink/printk/ - no functional changes
Signed-off-by: Jim Cromie
---
include/drm/drm_print.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
index 9b66be54dd16..15a089a87c22 100644
--- a/include/drm/drm_print.h
+++ b/include/
On 8/13/2021 7:37 AM, Daniel Vetter wrote:
On Wed, Jul 28, 2021 at 07:01:01PM -0700, Daniele Ceraolo Spurio wrote:
This api allow user mode to create protected buffers and to mark
contexts as making use of such objects. Only when using contexts
marked in such a way is the execution guaranteed
hi Jason, Greg, Daniel, dri-everyone,
drm_debug_enabled() is called a lot (by drm-debug api) to do unlikely
bit-tests to selectively enable debug printing; this is a good job for
DYNAMIC_DEBUG, IFF it is built with JUMP_LABEL.
This patchset enables the use of dynamic-debug to avoid those
drm_deb
== Series Details ==
Series: drm/dp: add some defines and prep for DP 2.0
URL : https://patchwork.freedesktop.org/series/93668/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10482_full -> Patchwork_20813_full
Summary
--
== Series Details ==
Series: drm/i915/dg2: DG2 intermediate DP source rates are different from CNL+
URL : https://patchwork.freedesktop.org/series/93675/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10482 -> Patchwork_20817
On Fri, 13 Aug 2021, Rodrigo Vivi wrote:
> On Fri, Aug 13, 2021 at 02:56:10PM +0300, Jani Nikula wrote:
>> Less is more, fewer lines to wonder about.
>>
>> Cc: Manasi Navare
>> Signed-off-by: Jani Nikula
>
> Reviewed-by: Rodrigo Vivi
Thanks!
> although sometimes I get myself wondering we mig
The buffer object argument to ttm_move_memcpy was only used to
determine whether the destination memory should be cleared only
or whether we should copy data. Replace it with a "clear" bool, and
update the callers.
The intention here is to be able to use ttm_move_memcpy() async under
a dma-fence a
The ttm_move_memcpy() function was intended to be able to be used async
under a fence.
We are going to utilize that as a fallback if the gpu clearing blit fails
before we set up CPU- or GPU ptes to the memory region.
But to accomplish that the bo argument to ttm_move_memcpy() needs to be
replaced.
In order to make the code a bit more readable and to facilitate
async memcpy moves, reorganize the move code a little. Determine
at an early stage whether to copy or to clear.
v2:
- Don't set up the memcpy iterators unless we are actually going to memcpy.
Signed-off-by: Thomas Hellström
Reviewed
On Fri, Aug 13, 2021 at 04:37:53PM +0200, Daniel Vetter wrote:
> On Wed, Jul 28, 2021 at 07:01:01PM -0700, Daniele Ceraolo Spurio wrote:
> > This api allow user mode to create protected buffers and to mark
> > contexts as making use of such objects. Only when using contexts
> > marked in such a way
On Wed, Jul 28, 2021 at 07:01:01PM -0700, Daniele Ceraolo Spurio wrote:
> This api allow user mode to create protected buffers and to mark
> contexts as making use of such objects. Only when using contexts
> marked in such a way is the execution guaranteed to work as expected.
>
> Contexts can onl
On Wed, Jul 28, 2021 at 07:01:00PM -0700, Daniele Ceraolo Spurio wrote:
> From: "Huang, Sean Z"
>
> The HW will generate a teardown interrupt when session termination is
> required, which requires i915 to submit a terminating batch. Once the HW
> is done with the termination it will generate anot
On Fri, Aug 13, 2021 at 02:56:10PM +0300, Jani Nikula wrote:
> Less is more, fewer lines to wonder about.
>
> Cc: Manasi Navare
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
although sometimes I get myself wondering we might get in some
case where our check inside the rmw function, t
== Series Details ==
Series: drm/i915/mst: use intel_de_rmw() to simplify VC payload alloc set/clear
URL : https://patchwork.freedesktop.org/series/93674/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10482 -> Patchwork_20816
===
Hi,
Finally got around to it. This patchset implements some updates to the
drm ioctl handler that were first raised by Daniel Vetter in [1].
Namely:
- Flush concurrent processes that can change the modeset when
DRM masters are set/dropped or a lease is revoked
- Unexport drm_ioctl_permit()
Thoug
Deadline is at the end of this month. Do not forget to submit your XDC
2022 hosting proposal!
Sam
On Thu, 2021-07-29 at 21:01 +0200, Samuel Iglesias Gonsálvez wrote:
> Remember before enjoying your holiday that the deadline for XDC 2022
> proposals is *September 1st, 2021* :-)
>
> Feel free to s
Since the last user of drm_ioctl_permit was removed, and it's now only
used in drm_ioctl.c, unexport the symbol.
Reported-by: Daniel Vetter
Signed-off-by: Desmond Cheong Zhi Xi
---
drivers/gpu/drm/drm_ioctl.c | 15 +--
include/drm/drm_ioctl.h | 1 -
2 files changed, 1 insertion
In drm_client_modeset.c and drm_fb_helper.c,
drm_master_internal_{acquire,release} are used to avoid races with DRM
userspace. These functions hold onto drm_device.master_mutex while
committing, and bail if there's already a master.
However, ioctls can still race between themselves. A
time-of-chec
On 8/13/21 1:36 PM, Dan Carpenter wrote:
If the intel_engine_create_pinned_context() function returns an error
pointer, then dereferencing "ce" will Oops. Use "vm" instead of
"ce->vm".
Fixes: cf586021642d ("drm/i915/gt: Pipelined page migration")
Signed-off-by: Dan Carpenter
---
drivers/gp
On Mon, Aug 09, 2021 at 04:31:46PM +0300, Imre Deak wrote:
> Atm the EFI FB platform driver gets a runtime PM reference for the
> associated GFX PCI device during probing the EFI FB platform device and
> releases it only when the platform device gets unbound.
>
> When fbcon switches to the FB prov
Please check CI results once; if regressions are unrelated please report.
With those fixed.
Reviewed-by:
Swati Sharma
Tested-by:
Swati Sharma
On 12-Aug-21 6:53 PM, Jani Nikula wrote:
ADL-P supports stream splitter on pipe B in addition to pipe A. Update
the sanity check in intel_ddi_mso_get_c
== Series Details ==
Series: series starting with [1/3] drm/i915/dp: pass crtc_state to
intel_ddi_dp_level()
URL : https://patchwork.freedesktop.org/series/93673/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10482 -> Patchwork_20815
==
== Series Details ==
Series: series starting with [1/3] drm/i915/dp: pass crtc_state to
intel_ddi_dp_level()
URL : https://patchwork.freedesktop.org/series/93673/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be check
== Series Details ==
Series: series starting with [1/3] drm/i915/dp: pass crtc_state to
intel_ddi_dp_level()
URL : https://patchwork.freedesktop.org/series/93673/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
5fc36b81b2d1 drm/i915/dp: pass crtc_state to intel_ddi_dp_level()
e6
== Series Details ==
Series: drm/i915/gt: Potential error pointer dereference in pinned_context()
URL : https://patchwork.freedesktop.org/series/93670/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10482 -> Patchwork_20814
DG2 has 243000 but not 648000.
Bspec: 54034
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
b/drivers/gpu/drm/i915/display/intel_dp.c
index 75d4ebc66941..e21
Less is more, fewer lines to wonder about.
Cc: Manasi Navare
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp_mst.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c
b/drivers/gpu/drm/i915/display/intel_
== Series Details ==
Series: drm/dp: add some defines and prep for DP 2.0
URL : https://patchwork.freedesktop.org/series/93668/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10482 -> Patchwork_20813
Summary
---
**SUC
UHBR link rates use different tx equalization settings. Using this will
require changes in the link training code too.
Bspec: 53920
Cc: Manasi Navare
Cc: Matt Roper
Signed-off-by: Jani Nikula
---
.../drm/i915/display/intel_ddi_buf_trans.c| 29 ++-
1 file changed, 28 inserti
We use encoder->get_buf_trans() in many places, for example
intel_ddi_dp_voltage_max(), and the hook was set to some old platform's
function for DG2 SNPS PHY. Convert SNPS PHY to use the same translation
mechanisms as everything else.
Cc: Manasi Navare
Cc: Matt Roper
Signed-off-by: Jani Nikula
Needed in the future.
Cc: Manasi Navare
Cc: Matt Roper
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_ddi.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c
b/drivers/gpu/drm/i915/display/intel
If the intel_engine_create_pinned_context() function returns an error
pointer, then dereferencing "ce" will Oops. Use "vm" instead of
"ce->vm".
Fixes: cf586021642d ("drm/i915/gt: Pipelined page migration")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-
1 file c
Nathan has probably already sent fixes for these. Nathan, could you CC
kernel-janitors on static checker fixes? That way we wouldn't send so
many duplicate patches.
Uninitialized variable warnings are really frustrating. We disabled the
GCC warning for them because the new GCC is crap. So now
The DP 2.0 128b/132b channel coding uses TX FFE presets instead of
vswing and pre-emphasis.
Cc: Manasi Navare
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_dp_helper.c | 14 ++
include/drm/drm_dp_helper.h | 2 ++
2 files changed, 16 insertions(+)
diff --git a/drivers/gpu/
DP 2.0 brings some new DPCD addresses for PHY repeaters.
Cc: Manasi Navare
Signed-off-by: Jani Nikula
---
include/drm/drm_dp_helper.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 1d5b3dbb6e56..f3a61341011d 100644
--- a/i
Extend the use of extended receiver cap at 0x2200 to cover
MAIN_LINK_CHANNEL_CODING_CAP in 0x2206, in case an implementation hides
the DP 2.0 128b/132b channel encoding cap.
Cc: Manasi Navare
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_dp_helper.c | 2 +-
1 file changed, 1 insertion(+),
The bw code equals link_rate / 0.27 Gbps only for 8b/10b link
rates. Handle DP 2.0 UHBR rates as special cases, though this is not
pretty.
Cc: Manasi Navare
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_dp_helper.c | 26 ++
1 file changed, 22 insertions(+), 4 deleti
I'll probably want to merge these to drm-intel-next and drm-misc-next
via a topic branch.
Jani Nikula (4):
drm/dp: add DP 2.0 UHBR link rate and bw code conversions
drm/dp: use more of the extended receiver cap
drm/dp: add LTTPR DP 2.0 DPCD addresses
drm/dp: add helper for extracting adjus
> -Original Message-
> From: Deak, Imre
> Sent: Thursday, August 12, 2021 8:34 PM
> To: Manna, Animesh
> Cc: intel-gfx@lists.freedesktop.org; Atwood, Matthew S
> ; Shankar, Uma ;
> Ville Syrjälä ; Souza, Jose
> ; Nikula, Jani
> Subject: Re: [PATCH 1/5] drm/i915/dp: Fix eDP max rate fo
== Series Details ==
Series: Infoframe changes for DP-HDMI2.1 PCON (rev2)
URL : https://patchwork.freedesktop.org/series/85073/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10481_full -> Patchwork_20812_full
Summary
--
Op 12-08-2021 om 23:10 schreef Jason Ekstrand:
> On Thu, Aug 12, 2021 at 9:49 AM Daniel Vetter wrote:
>> On Thu, Aug 12, 2021 at 2:44 PM Maarten Lankhorst
>> wrote:
>>> DG1 has support for local memory, which requires the usage of the
>>> lmem placement extension for creating bo's, and memregion
== Series Details ==
Series: MIPI DSI driver enhancements (rev6)
URL : https://patchwork.freedesktop.org/series/92695/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10481_full -> Patchwork_20810_full
Summary
---
**SU
These are all valid warnings, please fix.
BR,
Jani,
On Thu, 12 Aug 2021, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/gt: Initialize unused MOCS entries to L3_WB
> URL : https://patchwork.freedesktop.org/series/93626/
> State : warning
>
> == Summary ==
>
> $ dim checkpatch
On Thu, 12 Aug 2021, Ayaz A Siddiqui wrote:
> From: Srinivasan Shanmugam
>
> Program CMD_CCTL to use a mocs entry for uncached access.
> This controls memory accesses by CS as it reads instructions
> from the ring and batch buffers.
>
> Signed-off-by: Srinivasan Shanmugam
> Signed-off-by: Ayaz A
On Wed, 28 Jul 2021, Daniele Ceraolo Spurio
wrote:
> This will be used for communication between the i915 driver and the mei
> one. Defining it in a stand-alone patch to avoid circualr dependedencies
> between the patches modifying the 2 drivers.
>
> Split out from an original patch from Huang,
== Series Details ==
Series: Infoframe changes for DP-HDMI2.1 PCON (rev2)
URL : https://patchwork.freedesktop.org/series/85073/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10481 -> Patchwork_20812
Summary
---
**SUC
On Thu, 12 Aug 2021, Swati Sharma wrote:
> drm_dp_dpcd_read/write already has debug error message.
> Drop redundant error messages which gives false
> status even if correct value is read in drm_dp_dpcd_read().
I guess the only problem is it gets harder to associate the preceding
low level error
1 - 100 of 111 matches
Mail list logo
