Re: [Intel-gfx] [PATCH] drm/i915: Disable bonding on gen12+ platforms

2021-08-06 Thread Matt Roper
On Fri, Aug 06, 2021 at 08:54:59PM +0200, Daniel Vetter wrote: > On Fri, Aug 6, 2021 at 8:25 PM John Harrison > wrote: > > On 7/28/2021 12:21, Matthew Brost wrote: > > > Disable bonding on gen12+ platforms aside from ones already supported by > > > the i915 - TGL, RKL, and ADL-S. > > > > > > Sign

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Release ctx->syncobj on final put, not on ctx close

2021-08-06 Thread Patchwork
== Series Details == Series: drm/i915: Release ctx->syncobj on final put, not on ctx close URL : https://patchwork.freedesktop.org/series/93470/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10457_full -> Patchwork_20784_full ===

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Only access SFC_DONE when media domain is not fused off

2021-08-06 Thread Patchwork
== Series Details == Series: drm/i915: Only access SFC_DONE when media domain is not fused off URL : https://patchwork.freedesktop.org/series/93468/ State : success == Summary == CI Bug Log - changes from CI_DRM_10457_full -> Patchwork_20782_full ===

[Intel-gfx] ✓ Fi.CI.IGT: success for Begin enabling Xe_HP SDV and DG2 platforms (rev10)

2021-08-06 Thread Patchwork
== Series Details == Series: Begin enabling Xe_HP SDV and DG2 platforms (rev10) URL : https://patchwork.freedesktop.org/series/92135/ State : success == Summary == CI Bug Log - changes from CI_DRM_10457_full -> Patchwork_20781_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Release ctx->syncobj on final put, not on ctx close

2021-08-06 Thread Patchwork
== Series Details == Series: drm/i915: Release ctx->syncobj on final put, not on ctx close URL : https://patchwork.freedesktop.org/series/93470/ State : success == Summary == CI Bug Log - changes from CI_DRM_10457 -> Patchwork_20784 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Release ctx->syncobj on final put, not on ctx close

2021-08-06 Thread Patchwork
== Series Details == Series: drm/i915: Release ctx->syncobj on final put, not on ctx close URL : https://patchwork.freedesktop.org/series/93470/ State : warning == Summary == $ dim checkpatch origin/drm-tip d1dd9f17231e drm/i915: Release ctx->syncobj on final put, not on ctx close -:17: ERROR:

[Intel-gfx] [PATCH] drm/i915: Release ctx->syncobj on final put, not on ctx close

2021-08-06 Thread Daniel Vetter
gem context refcounting is another exercise in least locking design it seems, where most things get destroyed upon context closure (which can race with anything really). Only the actual memory allocation and the locks survive while holding a reference. This tripped up Jason when reimplementing the

Re: [Intel-gfx] [PATCH] drm/i915: Fix syncmap memory leak

2021-08-06 Thread John Harrison
On 8/6/2021 11:29, Matthew Brost wrote: On Fri, Aug 06, 2021 at 11:23:06AM -0700, John Harrison wrote: On 7/30/2021 12:53, Matthew Brost wrote: A small race exists between intel_gt_retire_requests_timeout and intel_timeline_exit which could result in the syncmap not getting free'd. Rather than

[Intel-gfx] ✗ Fi.CI.IGT: failure for remove rcu support from i915_address_space (rev5)

2021-08-06 Thread Patchwork
== Series Details == Series: remove rcu support from i915_address_space (rev5) URL : https://patchwork.freedesktop.org/series/93314/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10451_full -> Patchwork_20777_full Summary -

Re: [Intel-gfx] [PATCH v5 02/20] drm/msm: Fix drm/sched point of no return rules

2021-08-06 Thread Rob Clark
On Fri, Aug 6, 2021 at 12:11 PM Daniel Vetter wrote: > > On Fri, Aug 6, 2021 at 8:57 PM Rob Clark wrote: > > > > On Fri, Aug 6, 2021 at 11:41 AM Daniel Vetter > > wrote: > > > > > > On Fri, Aug 6, 2021 at 7:15 PM Rob Clark wrote: > > > > > > > > On Fri, Aug 6, 2021 at 9:42 AM Daniel Vetter >

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Check if engine has heartbeat when closing a context

2021-08-06 Thread Daniel Vetter
Seen this fly by and figured I dropped a few thoughts in here. At the likely cost of looking a bit out of whack :-) On Fri, Aug 6, 2021 at 8:01 PM John Harrison wrote: > On 8/2/2021 02:40, Tvrtko Ursulin wrote: > > On 30/07/2021 19:13, John Harrison wrote: > >> On 7/30/2021 02:49, Tvrtko Ursulin

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Only access SFC_DONE when media domain is not fused off

2021-08-06 Thread Patchwork
== Series Details == Series: drm/i915: Only access SFC_DONE when media domain is not fused off URL : https://patchwork.freedesktop.org/series/93468/ State : success == Summary == CI Bug Log - changes from CI_DRM_10457 -> Patchwork_20782 Sum

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/sched dependency handling and implicit sync fixes (rev2)

2021-08-06 Thread Patchwork
== Series Details == Series: drm/sched dependency handling and implicit sync fixes (rev2) URL : https://patchwork.freedesktop.org/series/93415/ State : failure == Summary == Applying: drm/sched: Split drm_sched_job_init Applying: drm/msm: Fix drm/sched point of no return rules error: git diff

Re: [Intel-gfx] [PATCH v5 02/20] drm/msm: Fix drm/sched point of no return rules

2021-08-06 Thread Daniel Vetter
On Fri, Aug 6, 2021 at 8:57 PM Rob Clark wrote: > > On Fri, Aug 6, 2021 at 11:41 AM Daniel Vetter wrote: > > > > On Fri, Aug 6, 2021 at 7:15 PM Rob Clark wrote: > > > > > > On Fri, Aug 6, 2021 at 9:42 AM Daniel Vetter > > > wrote: > > > > > > > > On Fri, Aug 6, 2021 at 12:58 AM Rob Clark wrot

Re: [Intel-gfx] [PATCH v5 02/20] drm/msm: Fix drm/sched point of no return rules

2021-08-06 Thread Rob Clark
On Fri, Aug 6, 2021 at 11:41 AM Daniel Vetter wrote: > > On Fri, Aug 6, 2021 at 7:15 PM Rob Clark wrote: > > > > On Fri, Aug 6, 2021 at 9:42 AM Daniel Vetter wrote: > > > > > > On Fri, Aug 6, 2021 at 12:58 AM Rob Clark wrote: > > > > > > > > On Thu, Aug 5, 2021 at 3:47 AM Daniel Vetter > > >

Re: [Intel-gfx] [PATCH] drm/i915: Disable bonding on gen12+ platforms

2021-08-06 Thread Daniel Vetter
On Fri, Aug 6, 2021 at 8:25 PM John Harrison wrote: > On 7/28/2021 12:21, Matthew Brost wrote: > > Disable bonding on gen12+ platforms aside from ones already supported by > > the i915 - TGL, RKL, and ADL-S. > > > > Signed-off-by: Matthew Brost > > --- > > drivers/gpu/drm/i915/gem/i915_gem_cont

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Only access SFC_DONE when media domain is not fused off

2021-08-06 Thread Patchwork
== Series Details == Series: drm/i915: Only access SFC_DONE when media domain is not fused off URL : https://patchwork.freedesktop.org/series/93468/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0e9d9b7275f5 drm/i915: Only access SFC_DONE when media domain is not fused off -:15

Re: [Intel-gfx] [PATCH 4/4] drm/i915/guc: Enable GuC submission by default on DG1

2021-08-06 Thread John Harrison
On 8/2/2021 22:11, Matthew Brost wrote: Signed-off-by: Matthew Brost --- drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c b/drivers/gpu/drm/i915/gt/uc/intel_uc.c index da57d18d9f6b..fc2fc8d111d8 10

Re: [Intel-gfx] [PATCH 3/4] drm/i915/guc: Add DG1 GuC / HuC firmware defs

2021-08-06 Thread John Harrison
On 8/2/2021 22:11, Matthew Brost wrote: Signed-off-by: Matthew Brost --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c index f8cb00ffb506..a685d563df72 100644 --

Re: [Intel-gfx] [PATCH 2/4] drm/i915/guc: put all guc objects in lmem when available

2021-08-06 Thread John Harrison
On 8/2/2021 22:11, Matthew Brost wrote: From: Daniele Ceraolo Spurio The firmware binary has to be loaded from lmem and the recommendation is to put all other objects in there as well. Note that we don't fall back to system memory if the allocation in lmem fails because all objects are allocate

[Intel-gfx] ✓ Fi.CI.BAT: success for Begin enabling Xe_HP SDV and DG2 platforms (rev10)

2021-08-06 Thread Patchwork
== Series Details == Series: Begin enabling Xe_HP SDV and DG2 platforms (rev10) URL : https://patchwork.freedesktop.org/series/92135/ State : success == Summary == CI Bug Log - changes from CI_DRM_10457 -> Patchwork_20781 Summary ---

Re: [Intel-gfx] [PATCH v5 02/20] drm/msm: Fix drm/sched point of no return rules

2021-08-06 Thread Daniel Vetter
On Fri, Aug 6, 2021 at 7:15 PM Rob Clark wrote: > > On Fri, Aug 6, 2021 at 9:42 AM Daniel Vetter wrote: > > > > On Fri, Aug 6, 2021 at 12:58 AM Rob Clark wrote: > > > > > > On Thu, Aug 5, 2021 at 3:47 AM Daniel Vetter > > > wrote: > > > > > > > > Originally drm_sched_job_init was the point of

Re: [Intel-gfx] [PATCH] drm/i915: Fix syncmap memory leak

2021-08-06 Thread Matthew Brost
On Fri, Aug 06, 2021 at 11:23:06AM -0700, John Harrison wrote: > On 7/30/2021 12:53, Matthew Brost wrote: > > A small race exists between intel_gt_retire_requests_timeout and > > intel_timeline_exit which could result in the syncmap not getting > > free'd. Rather than work to hard to seal this race

Re: [Intel-gfx] [PATCH] drm/i915: Disable bonding on gen12+ platforms

2021-08-06 Thread John Harrison
On 7/28/2021 12:21, Matthew Brost wrote: Disable bonding on gen12+ platforms aside from ones already supported by the i915 - TGL, RKL, and ADL-S. Signed-off-by: Matthew Brost --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gp

Re: [Intel-gfx] [PATCH] drm/i915: Fix syncmap memory leak

2021-08-06 Thread John Harrison
On 7/30/2021 12:53, Matthew Brost wrote: A small race exists between intel_gt_retire_requests_timeout and intel_timeline_exit which could result in the syncmap not getting free'd. Rather than work to hard to seal this race, simply cleanup the free'd -> freed syncmap on fini. unreferenced obje

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Begin enabling Xe_HP SDV and DG2 platforms (rev10)

2021-08-06 Thread Patchwork
== Series Details == Series: Begin enabling Xe_HP SDV and DG2 platforms (rev10) URL : https://patchwork.freedesktop.org/series/92135/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Begin enabling Xe_HP SDV and DG2 platforms (rev10)

2021-08-06 Thread Patchwork
== Series Details == Series: Begin enabling Xe_HP SDV and DG2 platforms (rev10) URL : https://patchwork.freedesktop.org/series/92135/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0ebc963f011d drm/i915/xehp: Loop over all gslices for INSTDONE processing -:135: CHECK:MACRO_ARG_R

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Check if engine has heartbeat when closing a context

2021-08-06 Thread John Harrison
On 8/2/2021 02:40, Tvrtko Ursulin wrote: On 30/07/2021 19:13, John Harrison wrote: On 7/30/2021 02:49, Tvrtko Ursulin wrote: On 30/07/2021 01:13, John Harrison wrote: On 7/28/2021 17:34, Matthew Brost wrote: If an engine associated with a context does not have a heartbeat, ban it immediately.

[Intel-gfx] [PATCH] drm/i915: Only access SFC_DONE when media domain is not fused off

2021-08-06 Thread Matt Roper
The SFC_DONE register lives within the corresponding VD0/VD2/VD4/VD6 forcewake domain and is not accessible if the vdbox in that domain is fused off and the forcewake is not initialized. This mistake went unnoticed because until recently we were using the wrong register offset for the SFC_DONE reg

[Intel-gfx] [PATCH v5.1 4/9] drm/i915/xehpsdv: Add compute DSS type

2021-08-06 Thread Matt Roper
From: Stuart Summers Starting in XeHP, the concept of slice has been removed in favor of DSS (Dual-Subslice) masks for various workload types. These workloads have been divided into those enabled for geometry and those enabled for compute. i915 currently maintains a single set of S/SS/EU masks f

Re: [Intel-gfx] [PATCH v5 02/20] drm/msm: Fix drm/sched point of no return rules

2021-08-06 Thread Rob Clark
On Fri, Aug 6, 2021 at 9:42 AM Daniel Vetter wrote: > > On Fri, Aug 6, 2021 at 12:58 AM Rob Clark wrote: > > > > On Thu, Aug 5, 2021 at 3:47 AM Daniel Vetter wrote: > > > > > > Originally drm_sched_job_init was the point of no return, after which > > > drivers must submit a job. I've split that

Re: [Intel-gfx] [PATCH v5 02/20] drm/msm: Fix drm/sched point of no return rules

2021-08-06 Thread Daniel Vetter
On Fri, Aug 6, 2021 at 12:58 AM Rob Clark wrote: > > On Thu, Aug 5, 2021 at 3:47 AM Daniel Vetter wrote: > > > > Originally drm_sched_job_init was the point of no return, after which > > drivers must submit a job. I've split that up, which allows us to fix > > this issue pretty easily. > > > > On

Re: [Intel-gfx] [PATCH 0/4] Enable GuC submission by default on DG1

2021-08-06 Thread Intel
On 8/6/21 1:34 PM, Thomas Hellström (Intel) wrote: Hi, On 8/3/21 7:26 PM, Matthew Brost wrote: On Tue, Aug 03, 2021 at 02:15:13PM +0200, Daniel Vetter wrote: On Tue, Aug 3, 2021 at 6:53 AM Matthew Brost wrote: Minimum set of patches to enable GuC submission on DG1 and enable it by default

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gvt: Fix cached atomics setting for Windows VM (rev2)

2021-08-06 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Fix cached atomics setting for Windows VM (rev2) URL : https://patchwork.freedesktop.org/series/92809/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10454_full -> Patchwork_20779_full ==

Re: [Intel-gfx] [PATCH 0/4] Enable GuC submission by default on DG1

2021-08-06 Thread Intel
On 8/6/21 1:34 PM, Thomas Hellström (Intel) wrote: Hi, On 8/3/21 7:26 PM, Matthew Brost wrote: On Tue, Aug 03, 2021 at 02:15:13PM +0200, Daniel Vetter wrote: On Tue, Aug 3, 2021 at 6:53 AM Matthew Brost wrote: Minimum set of patches to enable GuC submission on DG1 and enable it by default

Re: [Intel-gfx] [PATCH 0/4] Enable GuC submission by default on DG1

2021-08-06 Thread Intel
Hi, On 8/3/21 7:26 PM, Matthew Brost wrote: On Tue, Aug 03, 2021 at 02:15:13PM +0200, Daniel Vetter wrote: On Tue, Aug 3, 2021 at 6:53 AM Matthew Brost wrote: Minimum set of patches to enable GuC submission on DG1 and enable it by default. A little difficult to test as IGTs do not work with

Re: [Intel-gfx] [PATCH] drm/i915: Be more gentle when exiting non-persistent contexts

2021-08-06 Thread Tvrtko Ursulin
On 05/08/2021 17:32, Matthew Brost wrote: On Thu, Aug 05, 2021 at 01:05:09PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin When a non-persistent context exits we currently mark it as banned in order to trigger fast termination of any outstanding GPU jobs it may have left running. In doi

Re: [Intel-gfx] [PULL] drm-intel-gt-next

2021-08-06 Thread Joonas Lahtinen
Quoting Joonas Lahtinen (2021-08-06 13:06:17) > Hi Dave & Daniel, > > Sorry for the big PR in advance. Had the summer vacations and did not > notice until tool late how many patches were in already before leaving. > > As requested, there is a lot of refactoring to increase the use of TTM > alloca

Re: [Intel-gfx] [PATCH i-g-t v3 03/11] lib/i915/gem_mman: add fixed mode to gem_mmap_offset__cpu

2021-08-06 Thread Maarten Lankhorst
Op 02-08-2021 om 08:29 schreef Dixit, Ashutosh: > On Fri, 30 Jul 2021 01:53:40 -0700, Matthew Auld wrote: >> On discrete we only support the new fixed mode. >> >> Signed-off-by: Matthew Auld >> Cc: Maarten Lankhorst >> Cc: Ashutosh Dixit >> Cc: Daniel Vetter >> Cc: Ramalingam C >> --- >> lib/

[Intel-gfx] [PULL] drm-intel-gt-next

2021-08-06 Thread Joonas Lahtinen
Hi Dave & Daniel, Sorry for the big PR in advance. Had the summer vacations and did not notice until tool late how many patches were in already before leaving. As requested, there is a lot of refactoring to increase the use of TTM allocator and prep for DRM scheduler. Note that at times the patch

Re: [Intel-gfx] [PATCH i-g-t v3 03/11] lib/i915/gem_mman: add fixed mode to gem_mmap_offset__cpu

2021-08-06 Thread Maarten Lankhorst
Op 02-08-2021 om 08:29 schreef Dixit, Ashutosh: > On Fri, 30 Jul 2021 01:53:40 -0700, Matthew Auld wrote: >> On discrete we only support the new fixed mode. >> >> Signed-off-by: Matthew Auld >> Cc: Maarten Lankhorst >> Cc: Ashutosh Dixit >> Cc: Daniel Vetter >> Cc: Ramalingam C >> --- >> lib/

[Intel-gfx] ✓ Fi.CI.IGT: success for Begin enabling Xe_HP SDV and DG2 platforms (rev9)

2021-08-06 Thread Patchwork
== Series Details == Series: Begin enabling Xe_HP SDV and DG2 platforms (rev9) URL : https://patchwork.freedesktop.org/series/92135/ State : success == Summary == CI Bug Log - changes from CI_DRM_10451_full -> Patchwork_20776_full Summary -