Re: [Intel-gfx] [PATCH v4 05/27] drm/armada: Don't set struct drm_device.irq_enabled

2021-06-27 Thread Thomas Zimmermann
Am 25.06.21 um 10:22 schrieb Thomas Zimmermann: The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in armada. Signed-off-by: Thomas Zimmermann R-b'ed by Laurent via IRC --- drivers/gpu/drm/armada/armada_drv.c | 2 -- 1 file changed,

[Intel-gfx] ✓ Fi.CI.IGT: success for CT changes required for GuC submission

2021-06-27 Thread Patchwork
== Series Details == Series: CT changes required for GuC submission URL : https://patchwork.freedesktop.org/series/91943/ State : success == Summary == CI Bug Log - changes from CI_DRM_10282_full -> Patchwork_20474_full Summary --- *

[Intel-gfx] ✓ Fi.CI.BAT: success for CT changes required for GuC submission

2021-06-27 Thread Patchwork
== Series Details == Series: CT changes required for GuC submission URL : https://patchwork.freedesktop.org/series/91943/ State : success == Summary == CI Bug Log - changes from CI_DRM_10282 -> Patchwork_20474 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for CT changes required for GuC submission

2021-06-27 Thread Patchwork
== Series Details == Series: CT changes required for GuC submission URL : https://patchwork.freedesktop.org/series/91943/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/dis

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for CT changes required for GuC submission

2021-06-27 Thread Patchwork
== Series Details == Series: CT changes required for GuC submission URL : https://patchwork.freedesktop.org/series/91943/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4de6bd659c01 drm/i915/guc: Relax CTB response timeout 9074da160af0 drm/i915/guc: Improve error message for uns

[Intel-gfx] [PATCH 2/7] drm/i915/guc: Improve error message for unsolicited CT response

2021-06-27 Thread Matthew Brost
Improve the error message when a unsolicited CT response is received by printing fence that couldn't be found, the last fence, and all requests with a response outstanding. Signed-off-by: Matthew Brost Reviewed-by: Michal Wajdeczko --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 10 +++---

[Intel-gfx] [PATCH 5/7] drm/i915/guc: Add stall timer to non blocking CTB send function

2021-06-27 Thread Matthew Brost
Implement a stall timer which fails H2G CTBs once a period of time with no forward progress is reached to prevent deadlock. v2: (Michal) - Improve error message in ct_deadlock() - Set broken when ct_deadlock() returns true - Return -EPIPE on ct_deadlock() Signed-off-by: John Harrison Sign

[Intel-gfx] [PATCH 4/7] drm/i915/guc: Add non blocking CTB send function

2021-06-27 Thread Matthew Brost
Add non blocking CTB send function, intel_guc_send_nb. GuC submission will send CTBs in the critical path and does not need to wait for these CTBs to complete before moving on, hence the need for this new function. The non-blocking CTB now must have a flow control mechanism to ensure the buffer is

[Intel-gfx] [PATCH 6/7] drm/i915/guc: Optimize CTB writes and reads

2021-06-27 Thread Matthew Brost
CTB writes are now in the path of command submission and should be optimized for performance. Rather than reading CTB descriptor values (e.g. head, tail) which could result in accesses across the PCIe bus, store shadow local copies and only read/write the descriptor values when absolutely necessary

[Intel-gfx] [PATCH 7/7] drm/i915/guc: Module load failure test for CT buffer creation

2021-06-27 Thread Matthew Brost
From: John Harrison Add several module failure load inject points in the CT buffer creation code path. Signed-off-by: John Harrison Signed-off-by: Matthew Brost Reviewed-by: Michal Wajdeczko --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 8 1 file changed, 8 insertions(+) diff --g

[Intel-gfx] [PATCH 3/7] drm/i915/guc: Increase size of CTB buffers

2021-06-27 Thread Matthew Brost
With the introduction of non-blocking CTBs more than one CTB can be in flight at a time. Increasing the size of the CTBs should reduce how often software hits the case where no space is available in the CTB buffer. Cc: John Harrison Signed-off-by: Matthew Brost Reviewed-by: Michal Wajdeczko ---

[Intel-gfx] [PATCH 1/7] drm/i915/guc: Relax CTB response timeout

2021-06-27 Thread Matthew Brost
In upcoming patch we will allow more CTB requests to be sent in parallel to the GuC for processing, so we shouldn't assume any more that GuC will always reply without 10ms. Use bigger value hardcoded value of 1s instead. v2: Add CONFIG_DRM_I915_GUC_CTB_TIMEOUT config option v3: (Daniel Vetter)

[Intel-gfx] [PATCH 0/7] CT changes required for GuC submission

2021-06-27 Thread Matthew Brost
As part of enabling GuC submission discussed in [1], [2], and [3] we need optimize and update the CT code as this is now in the critical path of submission. This series includes the patches to do that which is the first 7 patches from [3]. The patches should have addressed all the feedback in [3] a