Re: [Intel-gfx] [PATCH 0/3] Pipe DMC Prep patches

On Mon, 03 May 2021, Jani Nikula wrote: > On Wed, 28 Apr 2021, Anusha Srivatsa wrote: >> This series adds the prep work needed before the >> actual Pipe DMC implementation. > > When should we rename csr to dmc all over the place? To elaborate, I think it's pretty confusing that we use both CSR a

Re: [Intel-gfx] [PATCH] i915: Increase *_latency array size

On Tue, 04 May 2021, Andi Kleen wrote: > From: Andi Kleen > > Newer gcc prints the following warning: > > drivers/gpu/drm/i915/intel_pm.c:3057:9: warning: ‘intel_print_wm_latency’ > reading 16 bytes from a region of size 10 [-Wstringop-overread] > and some other related warnings in similar funct

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/2] drm/i915: Don't include intel_de.h from intel_display_types.h (rev2)

Re-reported. -Original Message- From: Ville Syrjälä Sent: Tuesday, May 4, 2021 1:16 AM To: intel-gfx@lists.freedesktop.org Cc: Vudum, Lakshminarayana Subject: Re: ✗ Fi.CI.BAT: failure for series starting with [v2,1/2] drm/i915: Don't include intel_de.h from intel_display_types.h (rev2)

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915: Don't include intel_de.h from intel_display_types.h (rev2)

== Series Details == Series: series starting with [v2,1/2] drm/i915: Don't include intel_de.h from intel_display_types.h (rev2) URL : https://patchwork.freedesktop.org/series/89698/ State : success == Summary == CI Bug Log - changes from CI_DRM_10039 -> Patchwork_20053 ===

[Intel-gfx] ✓ Fi.CI.IGT: success for i915: Increase *_latency array size

== Series Details == Series: i915: Increase *_latency array size URL : https://patchwork.freedesktop.org/series/89793/ State : success == Summary == CI Bug Log - changes from CI_DRM_10046_full -> Patchwork_20064_full Summary --- **SU

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: Increase *_latency array size

== Series Details == Series: i915: Increase *_latency array size URL : https://patchwork.freedesktop.org/series/89793/ State : success == Summary == CI Bug Log - changes from CI_DRM_10046 -> Patchwork_20064 Summary --- **SUCCESS**

[Intel-gfx] [PATCH] i915: Increase *_latency array size

From: Andi Kleen Newer gcc prints the following warning: drivers/gpu/drm/i915/intel_pm.c:3057:9: warning: ‘intel_print_wm_latency’ reading 16 bytes from a region of size 10 [-Wstringop-overread] and some other related warnings in similar functions. gcc has a point here. Some of the latency arr

Re: [Intel-gfx] [PATCH] drm/i915: drop the __i915_active_call pointer packing

On Tue, May 04, 2021 at 05:41:36PM +0100, Matthew Auld wrote: > We use some of the lower bits of the retire function pointer for > potential flags, which is quite thorny, since the caller needs to > remember to give the function the correct alignment with > __i915_active_call, otherwise we might in

Re: [Intel-gfx] [PATCH 23/27] drm/i915/gem: Don't allow changing the VM on running contexts

On Mon, May 03, 2021 at 10:57:44AM -0500, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand First, a bit of commit message please here. Second I accidentally went down the rabbit hole and ended up at try_qad_pin(). Your patch looks good, unfortunately my brain is complete mushroom soup now.

Re: [Intel-gfx] [PATCH 23/27] drm/i915/gem: Don't allow changing the VM on running contexts

> url: > https://github.com/0day-ci/linux/commits/Jason-Ekstrand/drm-i915-gem-ioctl-clean-ups-v5/20210504-000132 > base: git://anongit.freedesktop.org/drm-intel for-linux-next > config: i386-randconfig-s002-20210503 (attached as .config) > compiler: gcc-9 (Debian 9.

Re: [Intel-gfx] [PATCH 22/27] drm/i915/gem: Delay context creation

> https://github.com/0day-ci/linux/commits/Jason-Ekstrand/drm-i915-gem-ioctl-clean-ups-v5/20210504-000132 > base: git://anongit.freedesktop.org/drm-intel for-linux-next > config: i386-randconfig-r013-20210503 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce

Re: [Intel-gfx] [PATCH 22/27] drm/i915/gem: Delay context creation

On Mon, May 03, 2021 at 10:57:43AM -0500, Jason Ekstrand wrote: > The current context uAPI allows for two methods of setting context > parameters: SET_CONTEXT_PARAM and CONTEXT_CREATE_EXT_SETPARAM. The > former is allowed to be called at any time while the later happens as > part of GEM_CONTEXT_CR

Re: [Intel-gfx] [PATCH 19/27] drm/i915/gem: Use the proto-context to handle create parameters

On Mon, May 03, 2021 at 10:57:40AM -0500, Jason Ekstrand wrote: > This means that the proto-context needs to grow support for engine > configuration information as well as setparam logic. Fortunately, we'll > be deleting a lot of setparam logic on the primary context shortly so it > will hopefully

Re: [Intel-gfx] [PATCH 18/27] drm/i915/gem: Optionally set SSEU in intel_context_set_gem

On Mon, May 03, 2021 at 10:57:39AM -0500, Jason Ekstrand wrote: > For now this is a no-op because everyone passes in a null SSEU but it > lets us get some of the error handling and selftest refactoring plumbed > through. > > Signed-off-by: Jason Ekstrand it is a bit icky that intel_context_set_g

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: drop the __i915_active_call pointer packing

== Series Details == Series: drm/i915: drop the __i915_active_call pointer packing URL : https://patchwork.freedesktop.org/series/89783/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10045 -> Patchwork_20063 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: drop the __i915_active_call pointer packing

== Series Details == Series: drm/i915: drop the __i915_active_call pointer packing URL : https://patchwork.freedesktop.org/series/89783/ State : warning == Summary == $ dim checkpatch origin/drm-tip 332fdd121463 drm/i915: drop the __i915_active_call pointer packing -:18: ERROR:GIT_COMMIT_ID: P

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Use drm_mode_is_420_only() instead of open coding it

== Series Details == Series: drm: Use drm_mode_is_420_only() instead of open coding it URL : https://patchwork.freedesktop.org/series/89777/ State : success == Summary == CI Bug Log - changes from CI_DRM_10042_full -> Patchwork_20062_full S

[Intel-gfx] [PATCH] drm/i915: drop the __i915_active_call pointer packing

We use some of the lower bits of the retire function pointer for potential flags, which is quite thorny, since the caller needs to remember to give the function the correct alignment with __i915_active_call, otherwise we might incorrectly unpack the pointer and jump to some garbage address later. I

Re: [Intel-gfx] [PATCH 17/27] drm/i915/gem: Rework error handling in default_engines

On Mon, May 03, 2021 at 10:57:38AM -0500, Jason Ekstrand wrote: > Since free_engines works for partially constructed engine sets, we can > use the usual goto pattern. > > Signed-off-by: Jason Ekstrand I guess subsequent patches apply the same for the set_engines command and __free_engines disapp

Re: [Intel-gfx] [PATCH 16/27] drm/i915/gem: Add an intermediate proto_context struct

On Mon, May 03, 2021 at 10:57:37AM -0500, Jason Ekstrand wrote: > The current context uAPI allows for two methods of setting context > parameters: SET_CONTEXT_PARAM and CONTEXT_CREATE_EXT_SETPARAM. The > former is allowed to be called at any time while the later happens as > part of GEM_CONTEXT_CR

Re: [Intel-gfx] [PATCH 8/8] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

On Tue, 4 May 2021 at 15:58, Simon Ser wrote: > > Continuing on that idea to push for enabling the cap in more cases: do > we have a policy to require new drivers to always support modifiers? > > That would be nice, even if it's just about enabling LINEAR. Sounds perfectly reasonable IMHO. I thin

Re: [Intel-gfx] [PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification (v2)

Hi, On 5/4/21 5:10 PM, Heikki Krogerus wrote: >> +/** >> + * drm_connector_oob_hotplug_event - Report out-of-band hotplug event to >> connector >> + * @connector: connector to report the event on >> + * @data: data related to the event >> + * >> + * On some hardware a hotplug event notification m

Re: [Intel-gfx] [PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification

Hi, On 5/4/21 4:52 PM, Heikki Krogerus wrote: > On Mon, May 03, 2021 at 04:35:29PM +0200, Hans de Goede wrote: >> Hi, >> >> On 5/3/21 10:00 AM, Heikki Krogerus wrote: >>> Hi Hans, >>> >>> On Wed, Apr 28, 2021 at 11:52:52PM +0200, Hans de Goede wrote: +/** + * struct drm_connector_oob_hot

Re: [Intel-gfx] [PATCH 0/9] drm + usb-type-c: Add support for out-of-band hotplug notification (v2)

On Mon, May 03, 2021 at 05:46:38PM +0200, Hans de Goede wrote: > Hi All, > > Here is v2 of my work on making DP over Type-C work on devices where the > Type-C controller does not drive the HPD pin on the GPU, but instead > we need to forward HPD events from the Type-C controller to the DRM driver.

Re: [Intel-gfx] [PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification (v2)

> +/** > + * drm_connector_oob_hotplug_event - Report out-of-band hotplug event to > connector > + * @connector: connector to report the event on > + * @data: data related to the event > + * > + * On some hardware a hotplug event notification may come from outside the > display > + * driver / dev

Re: [Intel-gfx] [PATCH 8/8] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

Continuing on that idea to push for enabling the cap in more cases: do we have a policy to require new drivers to always support modifiers? That would be nice, even if it's just about enabling LINEAR. ___ Intel-gfx mailing list Intel-gfx@lists.freedeskto

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Associate ACPI connector nodes with connector entries

Hi Andy, > > +/* NOTE: The connector order must be final before this is called. */ > > +void intel_acpi_assign_connector_fwnodes(struct drm_i915_private *i915) > > +{ > > + struct drm_connector_list_iter conn_iter; > > + struct drm_device *drm_dev = &i915->drm; > > + struct devic

Re: [Intel-gfx] [PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification

On Mon, May 03, 2021 at 04:35:29PM +0200, Hans de Goede wrote: > Hi, > > On 5/3/21 10:00 AM, Heikki Krogerus wrote: > > Hi Hans, > > > > On Wed, Apr 28, 2021 at 11:52:52PM +0200, Hans de Goede wrote: > >> +/** > >> + * struct drm_connector_oob_hotplug_event_data: OOB hotplug event data > >> + * >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Use drm_mode_is_420_only() instead of open coding it

== Series Details == Series: drm: Use drm_mode_is_420_only() instead of open coding it URL : https://patchwork.freedesktop.org/series/89777/ State : success == Summary == CI Bug Log - changes from CI_DRM_10042 -> Patchwork_20062 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: DDI buf trans cleaup and fixes (rev3)

== Series Details == Series: drm/i915: DDI buf trans cleaup and fixes (rev3) URL : https://patchwork.freedesktop.org/series/89311/ State : success == Summary == CI Bug Log - changes from CI_DRM_10041_full -> Patchwork_20061_full Summary ---

Re: [Intel-gfx] [PATCH 8/8] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

Hi Daniel, Thanks for the extra clarification. On Tue, 27 Apr 2021 at 13:22, Daniel Vetter wrote: > > On Tue, Apr 27, 2021 at 12:32:19PM +0100, Emil Velikov wrote: > > Hi Daniel, > > > > On Tue, 27 Apr 2021 at 10:20, Daniel Vetter wrote: > > > > > @@ -360,6 +373,9 @@ static int __drm_universal_

Re: [Intel-gfx] [PATCH 00/17] drm/i915: DDI buf trans cleaup and fixes

On Wed, 21 Apr 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > The DDI buf trans functions keep turning into bad > spaghetti every time a new platform gets added. > Split the platforms up properly and turn the whole > thing into a vfunc to make it easier to manage > multiple platforms. One

Re: [Intel-gfx] [PATCH 8/8] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

On Tue, 27 Apr 2021 11:20:18 +0200 Daniel Vetter wrote: > It's very confusing for userspace to have to deal with inconsistencies > here, and some drivers screwed this up a bit. Most just ommitted the > format list when they meant to say that only linear modifier is > allowed, but some also meant

Re: [Intel-gfx] [PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification

On Mon, May 03, 2021 at 11:00:20AM +0300, Heikki Krogerus wrote: > Hi Hans, > > On Wed, Apr 28, 2021 at 11:52:52PM +0200, Hans de Goede wrote: > > +/** > > + * struct drm_connector_oob_hotplug_event_data: OOB hotplug event data > > + * > > + * Contains data about out-of-band hotplug events, signal

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: DDI buf trans cleaup and fixes (rev3)

== Series Details == Series: drm/i915: DDI buf trans cleaup and fixes (rev3) URL : https://patchwork.freedesktop.org/series/89311/ State : success == Summary == CI Bug Log - changes from CI_DRM_10041 -> Patchwork_20061 Summary --- **

Re: [Intel-gfx] REGRESSION with 5.12: Suspend not working on Toshiba notebook

On Mon, May 03, 2021 at 11:13:25AM +0300, Joonas Lahtinen wrote: Hello Joonas, ... > It's very possible that it can be i915 bug. What you can try is to > blacklist i915 module and operate the system with SSH and see if the > latest kernel still freezes? This is a good idea. I have disabled i915 in

Re: [Intel-gfx] [PATCH] drm: Use drm_mode_is_420_only() instead of open coding it

On Tue, 04 May 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > Replace the open coded drm_mode_is_420_only() with the real thing. > > No functional changes. > > Cc: Werner Sembach > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/drm_modes.c | 13 -

Re: [Intel-gfx] [PATCH 3/9] drm/connector: Add drm_connector_find_by_fwnode() function (v2)

On Tue, May 4, 2021 at 2:53 PM Hans de Goede wrote: > On 5/4/21 10:00 AM, Andy Shevchenko wrote: > > On Monday, May 3, 2021, Hans de Goede > > wrote: ... > > +struct drm_connector *drm_connector_find_by_fwnode(struct > > fwnode_handle *fwnode) > > +{ > >

Re: [Intel-gfx] [PATCH 2/2] drm/i915/audio: fix indentation, remove extra braces

On Tue, 04 May 2021, Ville Syrjälä wrote: > On Tue, May 04, 2021 at 11:14:01AM +0300, Jani Nikula wrote: >> Cleanup the code. No functional changes. >> >> Signed-off-by: Jani Nikula > > for the series > Reviewed-by: Ville Syrjälä Thanks, pushed. BR, Jani. -- Jani Nikula, Intel Open Source

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: DDI buf trans cleaup and fixes (rev3)

== Series Details == Series: drm/i915: DDI buf trans cleaup and fixes (rev3) URL : https://patchwork.freedesktop.org/series/89311/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: DDI buf trans cleaup and fixes (rev3)

== Series Details == Series: drm/i915: DDI buf trans cleaup and fixes (rev3) URL : https://patchwork.freedesktop.org/series/89311/ State : warning == Summary == $ dim checkpatch origin/drm-tip 41597e735d81 drm/i915: s/intel/hsw/ for hsw/bde/skl buf trans f12ad854bbba drm/i915: Introduce hsw_ge

Re: [Intel-gfx] [PATCH 3/9] drm/connector: Add drm_connector_find_by_fwnode() function (v2)

Hi, On 5/4/21 10:00 AM, Andy Shevchenko wrote: > > > On Monday, May 3, 2021, Hans de Goede > wrote: > > Add a function to find a connector based on a fwnode. > > This will be used by the new drm_connector_oob_hotplug_event() > function which is added by

Re: [Intel-gfx] [PATCH resend 2/2] drm/i915/display: Make vlv_find_free_pps() skip pipes which are in use for non DP purposes

On Wed, Mar 24, 2021 at 04:37:14PM +0200, Ville Syrjälä wrote: > On Wed, Mar 24, 2021 at 03:10:59PM +0100, Hans de Goede wrote: > > Hi, > > > > On 3/24/21 3:02 PM, Ville Syrjälä wrote: > > > On Tue, Mar 23, 2021 at 11:39:09AM +0100, Hans de Goede wrote: > > >> Hi, > > >> > > >> On 3/2/21 3:51 PM,

[Intel-gfx] [PATCH] drm: Use drm_mode_is_420_only() instead of open coding it

From: Ville Syrjälä Replace the open coded drm_mode_is_420_only() with the real thing. No functional changes. Cc: Werner Sembach Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_modes.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/drm_

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/audio: a few cleanups

== Series Details == Series: drm/i915/audio: a few cleanups URL : https://patchwork.freedesktop.org/series/89774/ State : success == Summary == CI Bug Log - changes from CI_DRM_10040_full -> Patchwork_20060_full Summary --- **SUCCESS

[Intel-gfx] [PATCH v2 17/17] drm/i915: Add the missing adls vswing tables

From: Ville Syrjälä adls is supposed to use special buf trans tables. Add what's missing. v2: Drop the RBR/HBR table since it's the same as for tgl Signed-off-by: Ville Syrjälä --- .../drm/i915/display/intel_ddi_buf_trans.c| 103 +- 1 file changed, 102 insertions(+), 1 del

[Intel-gfx] [PATCH v2 12/17] drm/i915: Fix dg1 buf trans tables

From: Ville Syrjälä For some reason the dg1 buf trans tables have been stuffed into icl_get_combo_buf_trans_edp() which doesn't even get called on dg1. Split them out into a proper dg1 specific function, and also make sure we use the proper buf trans tables for DP as well as eDP. v2: Add the hob

Re: [Intel-gfx] [PATCH 4/4] Use YCbCr420 as fallback when RGB fails

On Mon, May 03, 2021 at 08:21:48PM +0200, Werner Sembach wrote: > When encoder validation of a display mode fails, retry with less bandwidth > heavy YCbCr420 color mode, if available. This enables some HDMI 1.4 setups > to support 4k60Hz output, which previously failed silently. > > AMDGPU had nea

Re: [Intel-gfx] [PATCH 3/4] Restructure output format computation for better expandability

On Mon, May 03, 2021 at 08:21:47PM +0200, Werner Sembach wrote: > Couples the decission between RGB and YCbCr420 mode and the check if the port > clock can archive the required frequency. Other checks and configuration steps > that where previously done in between can also be done before or after.

Re: [Intel-gfx] [PATCH 2/4] Add missing check

On Mon, May 03, 2021 at 08:21:46PM +0200, Werner Sembach wrote: > Add a missing check that could potentially lead to an unarchivable mode being > validated. > > Signed-off-by: Werner Sembach > --- > > >From 54fa706f0a5f260a32af5d18b9622ceebb94c12e Mon Sep 17 00:00:00 2001 > From: Werner Sembach

Re: [Intel-gfx] [PATCH 15/27] drm/i915: Add gem/i915_gem_context.h to the docs

On Mon, May 03, 2021 at 10:57:36AM -0500, Jason Ekstrand wrote: > In order to prevent kernel doc warnings, also fill out docs for any > missing fields and fix those that forgot the "@". > > Signed-off-by: Jason Ekstrand > --- > Documentation/gpu/i915.rst| 2 + > .../gpu/drm/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/audio: a few cleanups

== Series Details == Series: drm/i915/audio: a few cleanups URL : https://patchwork.freedesktop.org/series/89774/ State : success == Summary == CI Bug Log - changes from CI_DRM_10040 -> Patchwork_20060 Summary --- **SUCCESS** No r

Re: [Intel-gfx] [PATCH 10/27] drm/i915/gem: Remove engine auto-magic with FENCE_SUBMIT

On Mon, May 03, 2021 at 10:57:31AM -0500, Jason Ekstrand wrote: > Even though FENCE_SUBMIT is only documented to wait until the request in > the in-fence starts instead of waiting until it completes, it has a bit > more magic than that. If FENCE_SUBMIT is used to submit something to a > balanced e

Re: [Intel-gfx] [PATCH 11/27] drm/i915/request: Remove the hook from await_execution

On Mon, May 03, 2021 at 10:57:32AM -0500, Jason Ekstrand wrote: > This was only ever used for FENCE_SUBMIT automatic engine selection > which was removed in the previous commit. > > Signed-off-by: Jason Ekstrand I really how this is now split up and much more decipherable what's going on. For th

Re: [Intel-gfx] [PATCH 06/27] drm/i915: Drop the CONTEXT_CLONE API

On Mon, May 03, 2021 at 10:57:27AM -0500, Jason Ekstrand wrote: > This API allows one context to grab bits out of another context upon > creation. It can be used as a short-cut for setparam(getparam()) for > things like I915_CONTEXT_PARAM_VM. However, it's never been used by any > real userspace.

Re: [Intel-gfx] [PATCH 2/2] drm/i915/audio: fix indentation, remove extra braces

On Tue, May 04, 2021 at 11:14:01AM +0300, Jani Nikula wrote: > Cleanup the code. No functional changes. > > Signed-off-by: Jani Nikula for the series Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_audio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: [Intel-gfx] [PATCH 03/27] drm/i915: Drop I915_CONTEXT_PARAM_NO_ZEROMAP

On Mon, May 03, 2021 at 10:57:24AM -0500, Jason Ekstrand wrote: > The idea behind this param is to support OpenCL drivers with relocations > because OpenCL reserves 0x0 for NULL and, if we placed memory there, it > would confuse CL kernels. It was originally sent out as part of a patch > series in

Re: [Intel-gfx] [PATCH 02/27] drm/i915: Stop storing the ring size in the ring pointer

On Mon, May 03, 2021 at 10:57:23AM -0500, Jason Ekstrand wrote: > Previously, we were storing the ring size in the ring pointer before it > was actually allocated. We would then guard setting the ring size on > checking for CONTEXT_ALLOC_BIT. This is error-prone at best and really > only saves us

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/2] drm/i915: Don't include intel_de.h from intel_display_types.h (rev2)

On Mon, May 03, 2021 at 07:54:55PM -, Patchwork wrote: > == Series Details == > > Series: series starting with [v2,1/2] drm/i915: Don't include intel_de.h from > intel_display_types.h (rev2) > URL : https://patchwork.freedesktop.org/series/89698/ > State : failure > > == Summary == > > CI

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Add a separate low-level helper for masked workarounds

On 01/05/2021 07:55, Lucas De Marchi wrote: On Thu, Apr 29, 2021 at 10:12:51AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin We distinguish masked registers from other workarounds by the mask (clr) being zero for the former. the difference is more on the fact that those calls used _MASK

[Intel-gfx] [PATCH 2/2] drm/i915/audio: fix indentation, remove extra braces

Cleanup the code. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_audio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c index 60083431228c..

[Intel-gfx] [PATCH 1/2] drm/i915/audio: simplify, don't mask out in all branches

Lift the masking outside of the if branches. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_audio.c | 23 -- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/

[Intel-gfx] [PATCH 0/2] drm/i915/audio: a few cleanups

Found these forgotten in a branch... Jani Nikula (2): drm/i915/audio: simplify, don't mask out in all branches drm/i915/audio: fix indentation, remove extra braces drivers/gpu/drm/i915/display/intel_audio.c | 27 -- 1 file changed, 10 insertions(+), 17 deletions(-) -- 2

Re: [Intel-gfx] [PATCH 3/9] drm/connector: Add drm_connector_find_by_fwnode() function (v2)

On Monday, May 3, 2021, Hans de Goede wrote: > Add a function to find a connector based on a fwnode. > > This will be used by the new drm_connector_oob_hotplug_event() > function which is added by the next patch in this patch-set. > > Changes in v2: > - Complete rewrite to use a global connector

Re: [Intel-gfx] [PATCH 2/9] drm/connector: Add a fwnode pointer to drm_connector and register with ACPI

On Monday, May 3, 2021, Hans de Goede wrote: > Add a fwnode pointer to struct drm_connector and register an acpi_bus_type > for the connectors with the ACPI subsystem (when CONFIG_ACPI is enabled). > > The adding of the fwnode pointer allows drivers to associate a fwnode > that represents a conne

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Associate ACPI connector nodes with connector entries

On Monday, May 3, 2021, Hans de Goede wrote: > From: Heikki Krogerus > > On Intel platforms we know that the ACPI connector device > node order will follow the order the driver (i915) decides. > The decision is made using the custom Intel ACPI OpRegion > (intel_opregion.c), though the driver doe

Re: [Intel-gfx] [Heads up to maintainers] Re: [PATCH v8 1/1] drm/drm_mst: Use Extended Base Receiver Capability DPCD space

On Mon, May 03, 2021 at 11:33:33AM +0300, Jani Nikula wrote: > On Fri, 30 Apr 2021, Jani Nikula wrote: > > On Thu, 29 Apr 2021, Lyude Paul wrote: > >> JFYI Jani and Ben: I will be pushing this patch to drm-misc-next sometime > >> today if there's no objections > > > > Thanks for the heads-up, I t

Re: [Intel-gfx] [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines

On Sat, May 01, 2021 at 10:17:46AM -0700, Matthew Brost wrote: > On Fri, Apr 30, 2021 at 12:11:07PM +0200, Daniel Vetter wrote: > > On Thu, Apr 29, 2021 at 09:03:48PM -0700, Matthew Brost wrote: > > > On Thu, Apr 29, 2021 at 02:14:19PM +0200, Daniel Vetter wrote: > > > > On Wed, Apr 28, 2021 at 01: