21. 4. 13. 오후 6:48에 Daniel Vetter 이(가) 쓴 글:
> Since
>
> commit 890880ddfdbe256083170866e49c87618b706ac7
> Author: Paul Kocialkowski
> Date: Fri Jan 4 09:56:10 2019 +0100
>
> drm: Auto-set allow_fb_modifiers when given modifiers at plane init
>
> this is done automatically as part of pla
whoops, will definitely fix this and respin tomorrow
On Mon, 2021-04-19 at 23:25 +, Patchwork wrote:
> Patch Details
> Series:drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers
> (rev6)URL:https://patchwork.freedesktop.org/series/87242/State:failure
> Details:https://intel-gfx-ci.0
Hi,
Here's one BDW regression fix for cmd parser rework in 5.12 on recent
Windows guest driver update. Sorry to be a bit late, hopefully can
still catch up.
Thanks!
---
The following changes since commit b6a37a93c9ac3900987c79b726d0bb3699d8db4e:
drm/i915: Fix invalid access to ACPI _DSM objec
On Tue, Apr 13, 2021 at 08:54:06AM +0200, Peter Zijlstra wrote:
> On Mon, Apr 12, 2021 at 01:05:09PM -0700, Kees Cook wrote:
> > On Mon, Apr 12, 2021 at 10:00:16AM +0200, Peter Zijlstra wrote:
> > > +struct vpr_data {
> > > + int (*fn)(pte_t pte, unsigned long addr, void *data);
> > > + void *data;
== Series Details ==
Series: drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers (rev6)
URL : https://patchwork.freedesktop.org/series/87242/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9983 -> Patchwork_19953
On Mon, Apr 19, 2021 at 06:55:05PM -0400, Lyude Paul wrote:
> When moving around drm_dp_aux_register() calls, it turned out we
> accidentally managed to cause issues with the Tegra driver due to the fact
> the Tegra driver would attempt to retrieve a reference to the AUX channel's
> i2c adapter - w
== Series Details ==
Series: drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers (rev6)
URL : https://patchwork.freedesktop.org/series/87242/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Funct
== Series Details ==
Series: drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers (rev6)
URL : https://patchwork.freedesktop.org/series/87242/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separate
== Series Details ==
Series: drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers (rev6)
URL : https://patchwork.freedesktop.org/series/87242/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
fffba1b63bf6 drm/amdgpu: Add error handling to
amdgpu_dm_initialize_dp_connect
And finally, convert all of the code in drm_dp_mst_topology.c over to using
drm_err() and drm_dbg*(). Note that this refactor would have been a lot
more complicated to have tried writing a coccinelle script for, so this
whole thing was done by hand.
v2:
* Fix line-wrapping in drm_dp_mst_atomic_che
Next step in the conversion, move everything in drm_dp_dual_mode_helper.c
over to using drm_err() and drm_dbg_kms(). This was done using the
following cocci script:
@@
expression list expr;
@@
(
- DRM_DEBUG_KMS(expr);
+ drm_dbg_kms(dev, expr);
|
- DRM_ERROR(expr);
+ drm_err(dev,
While this shouldn't really be something that happens all that often, since
we're going to be using the drm_dbg_* log helpers in DRM helpers it's
technically possible that a driver could use an AUX adapter before it's
been associated with it's respective drm_device. While drivers should take
care t
Another function to pass drm_device * down to so we can start using the
drm_dbg_*() in the DRM DP helpers.
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/drm_dp_dual_mode_helper.c | 5 +++--
include/drm/drm_dp_dual_mode_helper.h | 2 +-
2 files changed, 4 insertions(+), 3 deletions(-)
diff -
Since this is one of the few functions in drm_dp_mst_topology.c that
doesn't have any way of getting access to a drm_device, let's pass the
drm_dp_mst_topology_mgr down to this function so that it can use
drm_dbg_kms().
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/drm_dp_mst_topology.c |
Since we're about to be using drm_dbg_*() throughout the DP helpers, we'll
need to be able to access the DRM device in the dual mode DP helpers as
well. Note however that since drm_dp_dual_mode_detect() can be called with
DDC adapters that aren't part of a drm_dp_aux struct, we need to pass down
th
Now that we've added a back-pointer to drm_device to drm_dp_aux, made
drm_dp_aux available to any functions in drm_dp_helper.c which need to
print to the kernel log, and ensured all of our logging uses a consistent
format, let's do the final step of the conversion and actually move
everything over
So that we can start using drm_dbg_*() throughout the DRM DP helpers.
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/drm_dp_dual_mode_helper.c | 8 +---
drivers/gpu/drm/i915/display/intel_lspcon.c | 12 +++-
include/drm/drm_dp_dual_mode_helper.h | 4 ++--
3 files changed, 14
So that we can start using drm_dbg_*() for
drm_dp_link_train_channel_eq_delay() and
drm_dp_lttpr_link_train_channel_eq_delay().
Signed-off-by: Lyude Paul
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 2 +-
drivers/gpu/drm/drm_dp_helper.c
Another function that we'll need to pass a drm_device (and not drm_dp_aux)
down to so that we can move over to using drm_dbg_*().
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/drm_dp_dual_mode_helper.c | 3 ++-
drivers/gpu/drm/i915/display/intel_hdmi.c | 3 +--
include/drm/drm_dp_dual_mode_helpe
Another function we need to pass drm_device down to in order to start using
drm_dbg_*().
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/drm_dp_dual_mode_helper.c | 3 ++-
drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +-
include/drm/drm_dp_dual_mode_helper.h | 2 +-
3 files changed, 4 inserti
Since we're about to convert everything in drm_dp_helper.c over to using
drm_dbg_*(), let's also make our logging more consistent in drm_dp_helper.c
while we're at it to ensure that we always print the name of the AUX
channel in question.
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/drm_dp_help
So that we can start using drm_dbg_*() in
drm_dp_link_train_clock_recovery_delay().
Signed-off-by: Lyude Paul
Reviewed-by: Laurent Pinchart
Reviewed-by: Rodrigo Vivi
---
drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 2 +-
drivers/gpu/drm/drm_dp_helper.c | 3 ++-
The docs we had for drm_dp_aux_init() and drm_dp_aux_register() were mostly
correct, except for the fact that they made the assumption that all AUX
devices were grandchildren of their respective DRM devices. This is the
case for most normal GPUs, but is almost never the case with SoCs and
display b
This is something that we've wanted for a while now: the ability to
actually look up the respective drm_device for a given drm_dp_aux struct.
This will also allow us to transition over to using the drm_dbg_*() helpers
for debug message printing, as we'll finally have a drm_device to reference
for d
Since AUX adapters on nouveau have their respective DRM connectors as
parents, we need to make sure that we register then after their connectors.
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/nouveau/nouveau_connector.c | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
Just adds some missing calls to
drm_dp_aux_register()/drm_dp_aux_unregister() for when we attach/detach the
bridge.
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/br
When moving around drm_dp_aux_register() calls, it turned out we
accidentally managed to cause issues with the Tegra driver due to the fact
the Tegra driver would attempt to retrieve a reference to the AUX channel's
i2c adapter - which wouldn't be initialized until drm_dp_aux_register() is
called.
While working on moving i2c device registration into drm_dp_aux_init() - I
realized that in order to do so we need to make sure that drivers calling
drm_dp_aux_init() handle any errors it could possibly return. In the
process of doing that, I noticed that the majority of AMD's code for DP
connector
Since we're about to make it so that drm_dp_aux_init() can fail (and thus -
should have it's return value checked) - we should require that callers of
drm_dp_aux_register() also check it's return value since drm_dp_aux_init()
can be called from there.
Signed-off-by: Lyude Paul
---
include/drm/dr
Since it's been asked quite a few times on some of the various DP
related patch series I've submitted to use the new DRM printk helpers,
and it technically wasn't really trivial to do this before due to the
lack of a consistent way to find a drm_device for an AUX channel, this
patch series aims to
== Series Details ==
Series: drm/doc/rfc: i915 DG1 uAPI (rev3)
URL : https://patchwork.freedesktop.org/series/88958/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9982_full -> Patchwork_19952_full
Summary
---
**SUCCE
== Series Details ==
Series: drm/i915: set min brightness for aux backlight interface.
URL : https://patchwork.freedesktop.org/series/89233/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9981_full -> Patchwork_19951_full
Su
== Series Details ==
Series: drm/doc/rfc: i915 DG1 uAPI (rev3)
URL : https://patchwork.freedesktop.org/series/88958/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9982 -> Patchwork_19952
Summary
---
**SUCCESS**
No
== Series Details ==
Series: drm/i915: Fix "mitigations" parsing if i915 is builtin (rev3)
URL : https://patchwork.freedesktop.org/series/88998/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9981_full -> Patchwork_19949_full
== Series Details ==
Series: drm/doc/rfc: i915 DG1 uAPI (rev3)
URL : https://patchwork.freedesktop.org/series/88958/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter
or member 'ww' not de
== Series Details ==
Series: drm/doc/rfc: i915 DG1 uAPI (rev3)
URL : https://patchwork.freedesktop.org/series/88958/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
4a27b6a842d8 drm/doc/rfc: i915 DG1 uAPI
-:53: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does
MAI
Add an entry for the new uAPI needed for DG1. Also add the overall
upstream plan, including some notes for the TTM conversion.
v2(Daniel):
- include the overall upstreaming plan
- add a note for mmap, there are differences here for TTM vs i915
- bunch of other suggestions from Daniel
v3:
(D
== Series Details ==
Series: drm/i915: set min brightness for aux backlight interface.
URL : https://patchwork.freedesktop.org/series/89233/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9981 -> Patchwork_19951
Summary
== Series Details ==
Series: drm/i915: set min brightness for aux backlight interface.
URL : https://patchwork.freedesktop.org/series/89233/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function paramete
On Mon, Apr 19, 2021 at 7:02 AM Matthew Auld wrote:
>
> On 16/04/2021 17:38, Jason Ekstrand wrote:
> > On Thu, Apr 15, 2021 at 11:04 AM Matthew Auld
> > wrote:
> >>
> >> Add an entry for the new uAPI needed for DG1.
> >>
> >> v2(Daniel):
> >>- include the overall upstreaming plan
> >>- a
Min brightness level for aux backlight interface is always zero.
Driver should refer to VBT's setting to configure proper minimum
level just like PWM backlight interface.
Cc: Jani Nikula
Cc: Ville Syrjala
Cc: Lyude Paul
Cc: Cooper Chiou
Signed-off-by: Lee Shawn C
---
drivers/gpu/drm/i915/di
== Series Details ==
Series: drm/i915/gt: Fix a lockdep warning with interrupts enabled
URL : https://patchwork.freedesktop.org/series/89228/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9981 -> Patchwork_19950
Summary
---
On 19/04/2021 15:37, Matthew Auld wrote:
On 19/04/2021 15:07, Tvrtko Ursulin wrote:
On 19/04/2021 12:30, Matthew Auld wrote:
On 15/04/2021 12:05, Tvrtko Ursulin wrote:
On 15/04/2021 10:23, Matthew Auld wrote:
On Thu, 15 Apr 2021 at 09:21, Tvrtko Ursulin
wrote:
On 14/04/2021 17:20, Matt
== Series Details ==
Series: drm/i915/gt: Fix a lockdep warning with interrupts enabled
URL : https://patchwork.freedesktop.org/series/89228/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function paramet
On 19/04/2021 15:07, Tvrtko Ursulin wrote:
On 19/04/2021 12:30, Matthew Auld wrote:
On 15/04/2021 12:05, Tvrtko Ursulin wrote:
On 15/04/2021 10:23, Matthew Auld wrote:
On Thu, 15 Apr 2021 at 09:21, Tvrtko Ursulin
wrote:
On 14/04/2021 17:20, Matthew Auld wrote:
On Wed, 14 Apr 2021 at 16:
== Series Details ==
Series: drm/i915/gt: Fix a lockdep warning with interrupts enabled
URL : https://patchwork.freedesktop.org/series/89228/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
c33473f2884a drm/i915/gt: Fix a lockdep warning with interrupts enabled
-:6: WARNING:COMMI
== Series Details ==
Series: drm/i915: Fix "mitigations" parsing if i915 is builtin (rev3)
URL : https://patchwork.freedesktop.org/series/88998/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9981 -> Patchwork_19949
Summary
On 16/04/2021 15:25, Matthew Auld wrote:
On 14/04/2021 16:33, Tvrtko Ursulin wrote:
On 12/04/2021 10:05, Matthew Auld wrote:
From: Anusha Srivatsa
In the scenario where local memory is available, we have
rely on CPU access via lmem directly instead of aperture.
v2:
gmch is only relevant fo
On 16/04/2021 16:04, Matthew Auld wrote:
On 14/04/2021 16:01, Tvrtko Ursulin wrote:
On 12/04/2021 10:05, Matthew Auld wrote:
From: CQ Tang
Add "REGION_STOLEN" device info to dg1, create stolen memory
region from upper portion of local device memory, starting
from DSMBASE.
v2:
- s/drm_
On 19/04/2021 12:30, Matthew Auld wrote:
On 15/04/2021 12:05, Tvrtko Ursulin wrote:
On 15/04/2021 10:23, Matthew Auld wrote:
On Thu, 15 Apr 2021 at 09:21, Tvrtko Ursulin
wrote:
On 14/04/2021 17:20, Matthew Auld wrote:
On Wed, 14 Apr 2021 at 16:22, Tvrtko Ursulin
wrote:
On 12/04/2021
== Series Details ==
Series: drm/i915: Fix "mitigations" parsing if i915 is builtin (rev3)
URL : https://patchwork.freedesktop.org/series/88998/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function para
== Series Details ==
Series: drm/i915/display: Fix state mismatch in drm infoframe
URL : https://patchwork.freedesktop.org/series/89225/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9979_full -> Patchwork_19948_full
Summar
== Series Details ==
Series: series starting with [v2,1/4] drm/i915/uapi: fix kernel doc warnings
URL : https://patchwork.freedesktop.org/series/89223/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9979_full -> Patchwork_19947_full
=
On 4/15/21 7:12 PM, Tvrtko Ursulin wrote:
[Please note: This e-mail is from an EXTERNAL e-mail address]
Hi,
On 14/04/2021 15:48, Jun Miao wrote:
Don`t simple disable all the HD-irq, should race the region in the
intel_breadcrumbs_disarm_irq() only.
What is HD-irq, I am, not familiar with t
Don`t simplely disable local interrupt delivery of CPU hardware irq, should race
the region inside signal_irq_work, include
intel_breadcrumbs_disarm_irq/intel_breadcrumbs_arm_irq.
RT complains about might sleep inside signal_irq_work() because spin_lock will
be invoked after disabling interrupts.
On Wed, Apr 14, 2021 at 7:29 PM Hsin-Yi Wang wrote:
>
> cd5676db0574 ("misc: eeprom: at24: support pm_runtime control") disables
> regulator in runtime suspend. If runtime suspend is called before
> regulator disable, it will results in regulator unbalanced disabling.
>
> Signed-off-by: Hsin-Yi Wa
I met below error during boot with i915 builtin if pass
"i915.mitigations=off":
[0.015589] Booting kernel: `off' invalid for parameter `i915.mitigations'
The reason is slab subsystem isn't ready at that time, so kstrdup()
returns NULL. Fix this issue by using stack var instead of kstrdup().
F
== Series Details ==
Series: drm/i915/display: Fix state mismatch in drm infoframe
URL : https://patchwork.freedesktop.org/series/89225/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9979 -> Patchwork_19948
Summary
---
On 16/04/2021 17:38, Jason Ekstrand wrote:
On Thu, Apr 15, 2021 at 11:04 AM Matthew Auld wrote:
Add an entry for the new uAPI needed for DG1.
v2(Daniel):
- include the overall upstreaming plan
- add a note for mmap, there are differences here for TTM vs i915
- bunch of other suggesti
== Series Details ==
Series: drm/i915/display: Fix state mismatch in drm infoframe
URL : https://patchwork.freedesktop.org/series/89225/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter
o
== Series Details ==
Series: series starting with [v2,1/4] drm/i915/uapi: fix kernel doc warnings
URL : https://patchwork.freedesktop.org/series/89223/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9979 -> Patchwork_19947
S
On 15/04/2021 12:05, Tvrtko Ursulin wrote:
On 15/04/2021 10:23, Matthew Auld wrote:
On Thu, 15 Apr 2021 at 09:21, Tvrtko Ursulin
wrote:
On 14/04/2021 17:20, Matthew Auld wrote:
On Wed, 14 Apr 2021 at 16:22, Tvrtko Ursulin
wrote:
On 12/04/2021 10:05, Matthew Auld wrote:
From: Venkata S
While reading the SDP infoframe, we are getting filtered with
the encoder type INTEL_OUTPUT_DDI which causes the infoframe
mismatch. This patch will extend the support to read the SDP
infoframes for eDP.
[1025.606556] i915 :00:02.0: [drm] *ERROR* mismatch in drm infoframe
[1025.607865] i915 00
== Series Details ==
Series: series starting with [v2,1/4] drm/i915/uapi: fix kernel doc warnings
URL : https://patchwork.freedesktop.org/series/89223/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Functi
== Series Details ==
Series: series starting with [v2,1/4] drm/i915/uapi: fix kernel doc warnings
URL : https://patchwork.freedesktop.org/series/89223/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
442351569fc8 drm/i915/uapi: fix kernel doc warnings
274c77447a83 drm/doc: add se
Add a note about the two-step process.
v2(Tvrtko):
- Also document the other method of just passing in a buffer which is
large enough, which avoids two ioctl calls. Can make sense for
smaller query items.
v3: prefer kernel-doc references for structs and members
Suggested-by: Daniel Vett
Add some example usage for the extension chaining also, which is quite
nifty.
v2: (Daniel)
- clarify that the name is just some integer, also document that the
name space is not global
v3: prefer kernel-doc references for structs
Suggested-by: Daniel Vetter
Signed-off-by: Matthew Auld
Cc:
Add section for drm/i915 uAPI and pull in i915_drm.h.
Suggested-by: Daniel Vetter
Signed-off-by: Matthew Auld
Cc: Joonas Lahtinen
Cc: Jordan Justen
Cc: Daniel Vetter
Cc: Kenneth Graunke
Cc: Jason Ekstrand
Cc: Dave Airlie
Cc: dri-de...@lists.freedesktop.org
Cc: mesa-...@lists.freedesktop.or
Fix the cases where it is almost already valid kernel doc, for the
others just nerf the warnings for now.
Signed-off-by: Matthew Auld
Cc: Joonas Lahtinen
Cc: Jordan Justen
Cc: Daniel Vetter
Cc: Kenneth Graunke
Cc: Jason Ekstrand
Cc: Dave Airlie
Cc: dri-de...@lists.freedesktop.org
Cc: mesa-.
== Series Details ==
Series: drm/i915: Fix for BSW and BXT vt-d. (rev2)
URL : https://patchwork.freedesktop.org/series/88976/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9979 -> Patchwork_19946
Summary
---
**FAILUR
Hi Joonas and Rodrigo -
Here's the gen to ver conversion topic branch to be merged to both
drm-intel-next and drm-intel-gt-next.
Lots of Cc's for heads up.
BR,
Jani.
topic/intel-gen-to-ver-2021-04-19:
Gen to ver conversions across the driver
The main change is Lucas' series [1], with Ville'
== Series Details ==
Series: drm/i915: Fix for BSW and BXT vt-d. (rev2)
URL : https://patchwork.freedesktop.org/series/88976/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:104: warning: Function parameter
or member 'w
== Series Details ==
Series: drm/i915: Fix for BSW and BXT vt-d. (rev2)
URL : https://patchwork.freedesktop.org/series/88976/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e50df516bbfe drm/i915: Remove asynchronous vma binding
-:8: WARNING:REPEATED_WORD: Possible repeated word:
On 15/04/2021 13:41, jun.miao wrote:
On 4/15/21 7:12 PM, Tvrtko Ursulin wrote:
[Please note: This e-mail is from an EXTERNAL e-mail address]
Hi,
On 14/04/2021 15:48, Jun Miao wrote:
Don`t simple disable all the HD-irq, should race the region in the
intel_breadcrumbs_disarm_irq() only.
Wh
74 matches
Mail list logo