[Intel-gfx] ✓ Fi.CI.IGT: success for HDMI2.1 PCON Misc Fixes (rev3)

2021-03-08 Thread Patchwork
== Series Details == Series: HDMI2.1 PCON Misc Fixes (rev3) URL : https://patchwork.freedesktop.org/series/86677/ State : success == Summary == CI Bug Log - changes from CI_DRM_9841_full -> Patchwork_19769_full Summary --- **WARNING*

[Intel-gfx] ✓ Fi.CI.BAT: success for HDMI2.1 PCON Misc Fixes (rev3)

2021-03-08 Thread Patchwork
== Series Details == Series: HDMI2.1 PCON Misc Fixes (rev3) URL : https://patchwork.freedesktop.org/series/86677/ State : success == Summary == CI Bug Log - changes from CI_DRM_9841 -> Patchwork_19769 Summary --- **SUCCESS** No re

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for HDMI2.1 PCON Misc Fixes (rev3)

2021-03-08 Thread Patchwork
== Series Details == Series: HDMI2.1 PCON Misc Fixes (rev3) URL : https://patchwork.freedesktop.org/series/86677/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +./drivers/gpu/drm/amd/amdgpu/../

[Intel-gfx] [PATCH v3 3/3] drm/i915/display: Configure HDMI2.1 Pcon for FRL only if Src-Ctl mode is available

2021-03-08 Thread Ankit Nautiyal
Currently we see only the MAX FRL BW from PCON before going for FRL. Also add the check if source control mode is supported by the PCON, before starting configuring PCON for FRL training. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 3 ++- 1 file changed, 2 inserti

[Intel-gfx] [PATCH v3 2/3] drm/i915/display: Remove FRL related code from disable DP sequence for older platforms

2021-03-08 Thread Ankit Nautiyal
Remove code for resetting frl related members from intel_disable_dp, as this is not applicable for older platforms. Signed-off-by: Ankit Nautiyal Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/disp

[Intel-gfx] [PATCH v3 1/3] drm/dp_helper: Define options for FRL training for HDMI2.1 PCON

2021-03-08 Thread Ankit Nautiyal
Currently the FRL training mode (Concurrent, Sequential) and training type (Normal, Extended) are not defined properly and are passed as bool values in drm_helpers for pcon configuration for FRL training. This patch: -Add register masks for Sequential and Normal FRL training options. -Fixes the dr

[Intel-gfx] [PATCH v3 0/3] HDMI2.1 PCON Misc Fixes

2021-03-08 Thread Ankit Nautiyal
Patch1: Tweaks the drm_helpers for PCON configuration. Patch2: Removes unwanted code not applicable for older platforms. Patch3: Fixes condition for starting FRL link training. rev3: Patch-1 from rev2 [Read PCON DSC ENC caps only for DPCD rev >= 1.4] is dropped as it mixes DPCD and DP revisions.

Re: [Intel-gfx] [PATCH 1/3] i915/display/intel_dp: Read PCON DSC ENC caps only for DPCD rev >= 1.4

2021-03-08 Thread Nautiyal, Ankit K
As I realized, this patch is mixing DPCD rev and DP version, need an appropriate check instead. As for the gitlab issue https://gitlab.freedesktop.org/drm/intel/-/issues/2868 this seems to be not due to a DPCD register not defined for an older sink. The DPCD read in that case should have bee

Re: [Intel-gfx] [PATCH 05/12] drm/i915/bios: create fake child devices on missing VBT

2021-03-08 Thread Lucas De Marchi
On Wed, Feb 17, 2021 at 07:03:35PM +0200, Jani Nikula wrote: Instead of initialing data directly in ddi_port_info array, create fake child devices for default outputs when the VBT is missing. This makes further unification of output handling easier. This will make intel_bios_is_port_present() re

Re: [Intel-gfx] [PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-08 Thread Navare, Manasi
On Thu, Mar 04, 2021 at 10:42:23AM +0200, Pekka Paalanen wrote: > On Wed, 3 Mar 2021 12:44:33 -0800 > "Navare, Manasi" wrote: > > > On Wed, Mar 03, 2021 at 10:47:44AM +0200, Pekka Paalanen wrote: > > > On Tue, 2 Mar 2021 12:41:32 -0800 > > > Manasi Navare wrote: > > > > > > > In case of a mo

Re: [Intel-gfx] [PATCH v3 2/8] drm/i915: split out stepping info to a new file

2021-03-08 Thread Lucas De Marchi
On Mon, Mar 08, 2021 at 03:56:39PM +0200, Jani Nikula wrote: gt/intel_workarounds.c is decidedly the wrong place for handling stepping info. Add new intel_step.[ch] for the data, and move the stepping arrays there. No functional changes. v2: Rename stepping->step Signed-off-by: Jani Nikula

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: refactor KBL/TGL/ADLS stepping scheme (rev2)

2021-03-08 Thread Patchwork
== Series Details == Series: drm/i915: refactor KBL/TGL/ADLS stepping scheme (rev2) URL : https://patchwork.freedesktop.org/series/87323/ State : success == Summary == CI Bug Log - changes from CI_DRM_9840_full -> Patchwork_19768_full Summa

[Intel-gfx] 2021 X.Org Foundation Membership renewal ENDS on THURSDAY Mar 11

2021-03-08 Thread Harry Wentland
The nomination period for the 2021 X.Org Foundation Board of Directors Election closed yesterday and the election is rapidly approaching. We currently only see membership renewals for 59 people. If you have not renewed your membership please do so by Thursday, Mar 11 at https://members.x.org.

Re: [Intel-gfx] [PATCH v2 13/16] drm/i915/pxp: User interface for Protected buffer

2021-03-08 Thread Daniele Ceraolo Spurio
On 3/8/2021 1:01 PM, Lionel Landwerlin wrote: On 08/03/2021 22:40, Rodrigo Vivi wrote: On Wed, Mar 03, 2021 at 05:24:34PM -0800, Daniele Ceraolo Spurio wrote: On 3/3/2021 4:10 PM, Daniele Ceraolo Spurio wrote: On 3/3/2021 3:42 PM, Lionel Landwerlin wrote: On 04/03/2021 01:25, Daniele Cera

Re: [Intel-gfx] [PATCH v2 13/16] drm/i915/pxp: User interface for Protected buffer

2021-03-08 Thread Lionel Landwerlin
On 08/03/2021 22:40, Rodrigo Vivi wrote: On Wed, Mar 03, 2021 at 05:24:34PM -0800, Daniele Ceraolo Spurio wrote: On 3/3/2021 4:10 PM, Daniele Ceraolo Spurio wrote: On 3/3/2021 3:42 PM, Lionel Landwerlin wrote: On 04/03/2021 01:25, Daniele Ceraolo Spurio wrote: On 3/3/2021 3:16 PM, Lionel L

[Intel-gfx] ✓ Fi.CI.IGT: success for gpu: drm: i915: fix error return code of igt_buddy_alloc_smoke()

2021-03-08 Thread Patchwork
== Series Details == Series: gpu: drm: i915: fix error return code of igt_buddy_alloc_smoke() URL : https://patchwork.freedesktop.org/series/87766/ State : success == Summary == CI Bug Log - changes from CI_DRM_9839_full -> Patchwork_19767_full =

Re: [Intel-gfx] [PATCH v2 13/16] drm/i915/pxp: User interface for Protected buffer

2021-03-08 Thread Rodrigo Vivi
On Wed, Mar 03, 2021 at 05:24:34PM -0800, Daniele Ceraolo Spurio wrote: > > > On 3/3/2021 4:10 PM, Daniele Ceraolo Spurio wrote: > > > > > > On 3/3/2021 3:42 PM, Lionel Landwerlin wrote: > > > On 04/03/2021 01:25, Daniele Ceraolo Spurio wrote: > > > > > > > > > > > > On 3/3/2021 3:16 PM, Lion

Re: [Intel-gfx] [PATCH 1/4] drm/i915/gen12: Add recommended hardware tuning value

2021-03-08 Thread Lucas De Marchi
On Tue, Mar 02, 2021 at 07:14:07PM -0800, Matt Roper wrote: On Tue, Mar 02, 2021 at 05:07:25PM -0800, Lucas De Marchi wrote: From: Caz Yokoyama Follow Bspec 31870 to set recommended tuning values for certain GT register. These values aren't workarounds per-se, but it's best to handle them in

Re: [Intel-gfx] [PATCH v2 09/16] drm/i915/pxp: Implement PXP irq handler

2021-03-08 Thread Daniele Ceraolo Spurio
On 3/3/2021 1:18 PM, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2021-03-01 19:31:53) From: "Huang, Sean Z" The HW will generate a teardown interrupt when session termination is required, which requires i915 to submit a terminating batch. Once the HW is done with the termination it

Re: [Intel-gfx] [PATCH v2 11/16] drm/i915/pxp: interface for creation of protected contexts

2021-03-08 Thread Daniele Ceraolo Spurio
On 3/3/2021 3:16 PM, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2021-03-01 19:31:55) Usage of protected objects, coming in a follow-up patch, will be restricted to protected contexts. Contexts can only be marked as protected at creation time and they must be both bannable and not rec

Re: [Intel-gfx] [PATCH v3] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9

2021-03-08 Thread Chiou, Cooper
I've tested on GLK, KBL, CFL Intel NUC devices and got the following performance results, there is no performance regression per my testing. Patch: [v5] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 Test suite: phoronix-test-suite.supertuxkart.1024x768.Fullscreen.Ultim

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: refactor KBL/TGL/ADLS stepping scheme (rev2)

2021-03-08 Thread Patchwork
== Series Details == Series: drm/i915: refactor KBL/TGL/ADLS stepping scheme (rev2) URL : https://patchwork.freedesktop.org/series/87323/ State : success == Summary == CI Bug Log - changes from CI_DRM_9840 -> Patchwork_19768 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: refactor KBL/TGL/ADLS stepping scheme (rev2)

2021-03-08 Thread Patchwork
== Series Details == Series: drm/i915: refactor KBL/TGL/ADLS stepping scheme (rev2) URL : https://patchwork.freedesktop.org/series/87323/ State : warning == Summary == $ dim checkpatch origin/drm-tip c52f0ea75128 drm/i915: remove unused ADLS_REVID_* macros 1d23fa9cb274 drm/i915: split out step

[Intel-gfx] ✓ Fi.CI.BAT: success for gpu: drm: i915: fix error return code of igt_buddy_alloc_smoke()

2021-03-08 Thread Patchwork
== Series Details == Series: gpu: drm: i915: fix error return code of igt_buddy_alloc_smoke() URL : https://patchwork.freedesktop.org/series/87766/ State : success == Summary == CI Bug Log - changes from CI_DRM_9839 -> Patchwork_19767 Summa

[Intel-gfx] [PATCH v3 8/8] drm/i915: rename i915_rev_steppings->intel_step_info

2021-03-08 Thread Jani Nikula
Matter of taste. Match the prefix for everything else related to steppings. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_device_info.h | 2 +- drivers/gpu/drm/i915/intel_step.c| 12 ++-- drivers/gpu/drm/i915/intel_step.h| 2 +- 3 file

[Intel-gfx] [PATCH v3 7/8] drm/i915: rename disp_stepping->display_step and gt_stepping->gt_step

2021-03-08 Thread Jani Nikula
Matter of taste. Step matches the enums. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 4 +-- drivers/gpu/drm/i915/intel_step.c | 48 +++ drivers/gpu/drm/i915/intel_step.h | 4 +-- 3 files changed, 28 insertions(+), 28 deletions(-) diff --git a

[Intel-gfx] [PATCH v3 6/8] drm/i915: rename DISP_STEPPING->DISPLAY_STEP and GT_STEPPING->GT_STEP

2021-03-08 Thread Jani Nikula
Matter of taste. STEP matches the enums. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- drivers/gpu/drm/i915/display/intel_psr.c | 4 ++-- drivers/gpu/drm/i915/display/skl_universal_plane.c | 2 +- drivers/gpu/drm/i915/gt/intel_workarounds.

[Intel-gfx] [PATCH v3 5/8] drm/i915: switch TGL and ADL to the new stepping scheme

2021-03-08 Thread Jani Nikula
This changes the way revids not present in the array are handled: - For gaps in the array, the next present revid is used. - For revids beyond the array, the new STEP_FUTURE is used instead of the last revid in the array. In both cases, we'll get debug logging of what's going on. v2: Rename s

[Intel-gfx] [PATCH v3 4/8] drm/i915: switch KBL to the new stepping scheme

2021-03-08 Thread Jani Nikula
Add new symbolic names for revision ids, and convert KBL revids to use them via the new stepping check macros. This also fixes theoretical out of bounds access to kbl_revids array. v2: Rename stepping->step Signed-off-by: Jani Nikula --- The initialization sounds like an early part of intel_d

[Intel-gfx] [PATCH v3 3/8] drm/i915: add new helpers for accessing stepping info

2021-03-08 Thread Jani Nikula
Add new runtime info field for stepping. Add new helpers for accessing them. As we'll be switching platforms over to the new scheme incrementally, check for non-initialized steppings. In case a platform does not have separate display and gt steppings, it's okay to use a common shorthand. However,

[Intel-gfx] [PATCH v3 2/8] drm/i915: split out stepping info to a new file

2021-03-08 Thread Jani Nikula
gt/intel_workarounds.c is decidedly the wrong place for handling stepping info. Add new intel_step.[ch] for the data, and move the stepping arrays there. No functional changes. v2: Rename stepping->step Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 1 + drivers/g

[Intel-gfx] [PATCH v3 1/8] drm/i915: remove unused ADLS_REVID_* macros

2021-03-08 Thread Jani Nikula
It's the adls_revid_step_tbl array indexes that matter. Reviewed-by: Lucas De Marchi Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 1d45d7492d10..2f51

[Intel-gfx] [PATCH v3 0/8] drm/i915: refactor KBL/TGL/ADLS stepping scheme

2021-03-08 Thread Jani Nikula
v3 of [1], mostly with just stepping->step renames BR, Jani. [1] https://patchwork.freedesktop.org/series/87323/ Jani Nikula (8): drm/i915: remove unused ADLS_REVID_* macros drm/i915: split out stepping info to a new file drm/i915: add new helpers for accessing stepping info drm/i915:

[Intel-gfx] ✗ Fi.CI.BAT: failure for gpu: drm: i915: fix error return code of igt_threaded_blt()

2021-03-08 Thread Patchwork
== Series Details == Series: gpu: drm: i915: fix error return code of igt_threaded_blt() URL : https://patchwork.freedesktop.org/series/87765/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9838 -> Patchwork_19766 Summary --

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Extend icl_sanitize_encoder_pll_mapping() to all DDI platforms

2021-03-08 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, February 24, 2021 4:42 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 6/6] drm/i915: Extend > icl_sanitize_encoder_pll_mapping() to all DDI platforms > > From: Ville Syrjälä >

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Add encoder->is_clock_enabled()

2021-03-08 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, February 24, 2021 4:42 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 5/6] drm/i915: Add encoder->is_clock_enabled() > > From: Ville Syrjälä > > Support reading out the current

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Move DDI clock readout to encoder->get_config()

2021-03-08 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, February 24, 2021 4:42 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 4/6] drm/i915: Move DDI clock readout to > encoder->get_config() > > From: Ville Syrjälä > > Move the *_ge

[Intel-gfx] [PATCH] gpu: drm: i915: fix error return code of igt_buddy_alloc_smoke()

2021-03-08 Thread Jia-Ju Bai
When i915_random_order() returns NULL to order, no error return code of igt_buddy_alloc_smoke() is assigned. To fix this bug, err is assigned with -EINVAL in this case. Fixes: 1fe3818d17c9 ("drm/i915/selftests: try to rein in alloc_smoke") Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- d

Re: [Intel-gfx] [PATCH] gpu: drm: i915: fix error return code of igt_buddy_alloc_smoke()

2021-03-08 Thread Jia-Ju Bai
On 2021/3/8 17:18, Chris Wilson wrote: Quoting Jia-Ju Bai (2021-03-08 08:59:52) When i915_random_order() returns NULL to order, no error return code of igt_buddy_alloc_smoke() is assigned. To fix this bug, err is assigned with -EINVAL in this case. It would not be EINVAL since that is used f

[Intel-gfx] [PATCH] gpu: drm: i915: fix error return code of igt_threaded_blt()

2021-03-08 Thread Jia-Ju Bai
When kcalloc() returns NULL to tsk or thread, no error code of igt_threaded_blt() is returned. To fix this bug, -ENOMEM is returned as error code. Fixes: 0e99f939f08f ("drm/i915/selftests/blt: add some kthreads into the mix") Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/gpu/dr

Re: [Intel-gfx] [PATCH v2 2/6] drm/i915: Do intel_dpll_readout_hw_state() after encoder readout

2021-03-08 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Thursday, February 25, 2021 6:12 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2 2/6] drm/i915: Do > intel_dpll_readout_hw_state() after encoder readout > > From: Ville Syrjälä > > The

Re: [Intel-gfx] [PATCH] gpu: drm: i915: fix error return code of igt_buddy_alloc_smoke()

2021-03-08 Thread Chris Wilson
Quoting Jia-Ju Bai (2021-03-08 08:59:52) > When i915_random_order() returns NULL to order, no error return code of > igt_buddy_alloc_smoke() is assigned. > To fix this bug, err is assigned with -EINVAL in this case. It would not be EINVAL since that is used for a reference failure, but in this cas

Re: [Intel-gfx] [PATCH] gpu: drm: i915: fix error return code of igt_threaded_blt()

2021-03-08 Thread Chris Wilson
Quoting Jia-Ju Bai (2021-03-08 09:07:22) > When kcalloc() returns NULL to tsk or thread, no error code of > igt_threaded_blt() is returned. > To fix this bug, -ENOMEM is returned as error code. Because we decided to skip the test if it could not be run due to insufficient memory, as opposed to an