Re: [Intel-gfx] [PULL] drm-misc-fixes

2021-02-24 Thread Thomas Zimmermann
Hi Am 25.02.21 um 02:55 schrieb Dave Airlie: On Wed, 24 Feb 2021 at 20:27, Thomas Zimmermann wrote: Hi Dave and Daniel, here's this week's PR for drm-misc-fixes. One of the patches is a memory leak; the rest is for hardware issues. This is based on 5.11 and I'm not currently in the market

Re: [Intel-gfx] [PULL] drm-misc-fixes

2021-02-24 Thread Dave Airlie
On Wed, 24 Feb 2021 at 20:27, Thomas Zimmermann wrote: > > Hi Dave and Daniel, > > here's this week's PR for drm-misc-fixes. One of the patches is a memory > leak; the rest is for hardware issues. > This is based on 5.11 and I'm not currently in the market for a backmege now before rc1 so can you

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Verify dma_addr in gen8_ggtt_pte_encode

2021-02-24 Thread Patchwork
== Series Details == Series: drm/i915: Verify dma_addr in gen8_ggtt_pte_encode URL : https://patchwork.freedesktop.org/series/87352/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9798_full -> Patchwork_19727_full Summary --

Re: [Intel-gfx] [PATCH 15/30] drm/dp: Add backpointer to drm_device in drm_dp_aux

2021-02-24 Thread Lyude Paul
On Sun, 2021-02-21 at 20:21 +0200, Laurent Pinchart wrote: > Hi Lyude, > > Thank you for the patch. > > On Fri, Feb 19, 2021 at 04:53:11PM -0500, Lyude Paul wrote: > > This is something that we've wanted for a while now: the ability to > > actually look up the respective drm_device for a given dr

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Promote ptrdiff() to i915_utils.h

2021-02-24 Thread Patchwork
== Series Details == Series: drm/i915: Promote ptrdiff() to i915_utils.h URL : https://patchwork.freedesktop.org/series/87348/ State : success == Summary == CI Bug Log - changes from CI_DRM_9798_full -> Patchwork_19725_full Summary ---

[Intel-gfx] udldrmfb: causes WARN in i915 on X60 (x86-32)

2021-02-24 Thread Pavel Machek
Hi! This is in -next, but I get same behaviour on 5.11; and no, udl does not work, but monitor is detected: pavel@amd:~/g/tui/crashled$ xrandr Screen 0: minimum 320 x 200, current 1024 x 768, maximum 4096 x 4096 LVDS1 connected 1024x768+0+0 (normal left inverted right x axis y axis) 246mm x 185

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Verify dma_addr in gen8_ggtt_pte_encode

2021-02-24 Thread Patchwork
== Series Details == Series: drm/i915: Verify dma_addr in gen8_ggtt_pte_encode URL : https://patchwork.freedesktop.org/series/87352/ State : success == Summary == CI Bug Log - changes from CI_DRM_9798 -> Patchwork_19727 Summary --- *

Re: [Intel-gfx] [PATCH] drm/i915/guc: Keep strict GuC ABI definitions separate

2021-02-24 Thread Michał Winiarski
Quoting Michal Wajdeczko (2021-02-20 13:44:43) > Our fwif.h file is now mix of strict firmware ABI definitions and > set of our helpers. In anticipation of upcoming changes to the GuC > interface try to keep them separate in smaller maintainable files. > > Signed-off-by: Michal Wajdeczko > Cc: Da

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Verify dma_addr in gen8_ggtt_pte_encode

2021-02-24 Thread Patchwork
== Series Details == Series: drm/i915: Verify dma_addr in gen8_ggtt_pte_encode URL : https://patchwork.freedesktop.org/series/87352/ State : warning == Summary == $ dim checkpatch origin/drm-tip 201369a1d91f drm/i915: Verify dma_addr in gen8_ggtt_pte_encode -:9: WARNING:COMMIT_LOG_LONG_LINE: P

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Move DDI clock readout to encoder->get_config()

2021-02-24 Thread Patchwork
== Series Details == Series: drm/i915: Move DDI clock readout to encoder->get_config() URL : https://patchwork.freedesktop.org/series/87351/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9798 -> Patchwork_19726 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Move DDI clock readout to encoder->get_config()

2021-02-24 Thread Patchwork
== Series Details == Series: drm/i915: Move DDI clock readout to encoder->get_config() URL : https://patchwork.freedesktop.org/series/87351/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drive

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Promote ptrdiff() to i915_utils.h

2021-02-24 Thread Patchwork
== Series Details == Series: drm/i915: Promote ptrdiff() to i915_utils.h URL : https://patchwork.freedesktop.org/series/87348/ State : success == Summary == CI Bug Log - changes from CI_DRM_9798 -> Patchwork_19725 Summary --- **SUCCE

Re: [Intel-gfx] [PATCH 01/30] drm/dp: Rewrap kdocs for struct drm_dp_aux

2021-02-24 Thread Lyude Paul
On Fri, 2021-02-19 at 15:42 -0800, Randy Dunlap wrote: > On 2/19/21 1:52 PM, Lyude Paul wrote: > > Since we're about to be adding some more fields and update this > > documentation, let's rewrap it to the new column limit of 100 beforehand. > > No actual doc or functional changes are made here. > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl+: Sanitize the DDI LANES/IO and AUX power domain names

2021-02-24 Thread Patchwork
== Series Details == Series: drm/i915/tgl+: Sanitize the DDI LANES/IO and AUX power domain names URL : https://patchwork.freedesktop.org/series/87299/ State : success == Summary == CI Bug Log - changes from CI_DRM_9795_full -> Patchwork_19717_full ==

[Intel-gfx] [PATCH] drm/i915: Verify dma_addr in gen8_ggtt_pte_encode

2021-02-24 Thread Piorkowski, Piotr
From: Piotr Piórkowski Until now, the gen8_ggtt_pte_encode function, responsible for the preparation of GGTT PTE, has not verified in any way whether the address given as the parameter is correct. By adding a GGTT address mask, we can easily verify that dma_addr will not fit in the PTE field. Whi

[Intel-gfx] [PATCH 6/6] drm/i915: Extend icl_sanitize_encoder_pll_mapping() to all DDI platforms

2021-02-24 Thread Ville Syrjala
From: Ville Syrjälä Now that all the encoder clock stuff is uniformly abstracted for all hsw+ platforms, let's extend icl_sanitize_encoder_pll_mapping() to cover all of them. Not sure there is a particular benefit in doing so, but less special cases always makes me happy. Signed-off-by: Ville S

[Intel-gfx] [PATCH 5/6] drm/i915: Add encoder->is_clock_enabled()

2021-02-24 Thread Ville Syrjala
From: Ville Syrjälä Support reading out the current state of the DDI clock. Not sure we really want this. Seems a bit excessive just to restore the debug print to icl_sanitize_encoder_pll_mapping()? But maybe there's more use for it? Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/displ

[Intel-gfx] [PATCH 4/6] drm/i915: Move DDI clock readout to encoder->get_config()

2021-02-24 Thread Ville Syrjala
From: Ville Syrjälä Move the *_get_ddi_pll() stuff into the encodet->get_config() hook. There it neatly sits next to the matching .{enable,disable}_clock() functions. In order to avoid excessive boilerplate I changed the behaviour such that all platforms now do the readout via crtc_state->port_d

[Intel-gfx] [PATCH 1/6] drm/i915: Call primary encoder's .get_config() from MST .get_config()

2021-02-24 Thread Ville Syrjala
From: Ville Syrjälä Stop assuming intel_ddi_get_config() is all we need from the primary encoder, and instead call it via the .get_config() vfunc. This will allow customized .get_config() for the primary, which I plan to use to handle the differences in the clock readout between various platforms

[Intel-gfx] [PATCH 3/6] drm/i915: Use pipes instead crtc indices in PLL state tracking

2021-02-24 Thread Ville Syrjala
From: Ville Syrjälä All the other places we have use pipes instead of crtc indices when tracking resource usage. Life is easier when we do it the same way always, so switch the dpll mgr to using pipes as well. Looks like it was actually mixing these up in some cases so it would not even have work

[Intel-gfx] [PATCH 2/6] drm/i915: Do intel_dpll_readout_hw_state() after encoder readout

2021-02-24 Thread Ville Syrjala
From: Ville Syrjälä The clock readout for DDI encoders needs to moved into the encoders. To that end intel_dpll_readout_hw_state() needs to happen after the encoder readout as otherwise it can't correctly populate the PLL crtc_mask/active_mask bitmasks. Signed-off-by: Ville Syrjälä --- drivers

[Intel-gfx] [PATCH 0/6] drm/i915: Move DDI clock readout to encoder->get_config()

2021-02-24 Thread Ville Syrjala
From: Ville Syrjälä The DDI clock readout has no business being in hsw_get_pipe_config(). Let's move it where it belongs, that is encoder->get_config(). Ville Syrjälä (6): drm/i915: Call primary encoder's .get_config() from MST .get_config() drm/i915: Do intel_dpll_readout_hw_state() after e

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/tgl+: Sanitize the DDI LANES/IO and AUX power domain names

2021-02-24 Thread Imre Deak
On Mon, Feb 22, 2021 at 10:55:17PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/tgl+: Sanitize the DDI LANES/IO and AUX power domain names > URL : https://patchwork.freedesktop.org/series/87299/ > State : failure Thanks for the review pushed to -din. The failure is unrel

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hdcp: Fix null pointer dereference of connector->encoder

2021-02-24 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Fix null pointer dereference of connector->encoder URL : https://patchwork.freedesktop.org/series/87328/ State : success == Summary == CI Bug Log - changes from CI_DRM_9798_full -> Patchwork_19724_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: refactor KBL/TGL/ADLS stepping scheme

2021-02-24 Thread Patchwork
== Series Details == Series: drm/i915: refactor KBL/TGL/ADLS stepping scheme URL : https://patchwork.freedesktop.org/series/87323/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9798_full -> Patchwork_19723_full Summary

Re: [Intel-gfx] [PATCH] drm/i915: Promote ptrdiff() to i915_utils.h

2021-02-24 Thread Tvrtko Ursulin
On 24/02/2021 10:35, Michal Wajdeczko wrote: Generic helpers should be placed in i915_utils.h. Signed-off-by: Michal Wajdeczko Cc: Tvrtko Ursulin Cc: Chris Wilson Cc: Matthew Brost --- drivers/gpu/drm/i915/i915_utils.h | 5 + drivers/gpu/drm/i915/i915_vma.h | 5 - 2 files cha

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdcp: Fix null pointer dereference of connector->encoder

2021-02-24 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Fix null pointer dereference of connector->encoder URL : https://patchwork.freedesktop.org/series/87328/ State : success == Summary == CI Bug Log - changes from CI_DRM_9798 -> Patchwork_19724 Summ

[Intel-gfx] [PATCH] drm/i915: Promote ptrdiff() to i915_utils.h

2021-02-24 Thread Michal Wajdeczko
Generic helpers should be placed in i915_utils.h. Signed-off-by: Michal Wajdeczko Cc: Tvrtko Ursulin Cc: Chris Wilson Cc: Matthew Brost --- drivers/gpu/drm/i915/i915_utils.h | 5 + drivers/gpu/drm/i915/i915_vma.h | 5 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/

[Intel-gfx] [PULL] drm-misc-fixes

2021-02-24 Thread Thomas Zimmermann
Hi Dave and Daniel, here's this week's PR for drm-misc-fixes. One of the patches is a memory leak; the rest is for hardware issues. Best regards Thomas drm-misc-fixes-2021-02-24: * drm/panel: kd35t133: Work with non-continuous DSI clock * drm/rockchip: Require YTR modifier for AFBC * drm/ttm:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: refactor KBL/TGL/ADLS stepping scheme

2021-02-24 Thread Patchwork
== Series Details == Series: drm/i915: refactor KBL/TGL/ADLS stepping scheme URL : https://patchwork.freedesktop.org/series/87323/ State : success == Summary == CI Bug Log - changes from CI_DRM_9798 -> Patchwork_19723 Summary --- **S

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: refactor KBL/TGL/ADLS stepping scheme

2021-02-24 Thread Patchwork
== Series Details == Series: drm/i915: refactor KBL/TGL/ADLS stepping scheme URL : https://patchwork.freedesktop.org/series/87323/ State : warning == Summary == $ dim checkpatch origin/drm-tip c850cee093c5 drm/i915: remove unused ADLS_REVID_* macros 6679d541fc02 drm/i915: split out stepping in

Re: [Intel-gfx] [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-24 Thread Daniel Vetter
On Wed, Feb 24, 2021 at 10:16 AM Thomas Hellström (Intel) wrote: > > > On 2/24/21 9:45 AM, Daniel Vetter wrote: > > On Wed, Feb 24, 2021 at 8:46 AM Thomas Hellström (Intel) > > wrote: > >> > >> On 2/23/21 11:59 AM, Daniel Vetter wrote: > >>> tldr; DMA buffers aren't normal memory, expecting that

Re: [Intel-gfx] [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-24 Thread Intel
On 2/24/21 9:45 AM, Daniel Vetter wrote: On Wed, Feb 24, 2021 at 8:46 AM Thomas Hellström (Intel) wrote: On 2/23/21 11:59 AM, Daniel Vetter wrote: tldr; DMA buffers aren't normal memory, expecting that you can use them like that (like calling get_user_pages works, or that they're accounting

Re: [Intel-gfx] [PATCH v2 6/7] drm/i915: rename DISP_STEPPING->DISPLAY_STEP and GT_STEPPING->GT_STEP

2021-02-24 Thread Jani Nikula
On Tue, 23 Feb 2021, Lucas De Marchi wrote: > On Tue, Feb 23, 2021 at 05:35:11PM +0200, Jani Nikula wrote: >>Matter of taste. STEP matches the enums. >> >>Signed-off-by: Jani Nikula >>--- >> drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- >> drivers/gpu/drm/i915/display/intel_psr.c

Re: [Intel-gfx] [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-24 Thread Daniel Vetter
On Wed, Feb 24, 2021 at 8:46 AM Thomas Hellström (Intel) wrote: > > > On 2/23/21 11:59 AM, Daniel Vetter wrote: > > tldr; DMA buffers aren't normal memory, expecting that you can use > > them like that (like calling get_user_pages works, or that they're > > accounting like any other normal memory)