[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915: Wrap all access to i915_vma.node.start|size (rev2)

2021-02-15 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Wrap all access to i915_vma.node.start|size (rev2) URL : https://patchwork.freedesktop.org/series/87102/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9777_full -> Patchwork_19683_full =

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Wrap all access to i915_vma.node.start|size (rev2)

2021-02-15 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Wrap all access to i915_vma.node.start|size (rev2) URL : https://patchwork.freedesktop.org/series/87102/ State : success == Summary == CI Bug Log - changes from CI_DRM_9777 -> Patchwork_19683 ===

[Intel-gfx] [PATCH] drm/i915: Introduce guard pages to i915_vma

2021-02-15 Thread Chris Wilson
Introduce the concept of padding the i915_vma with guard pages before and aft. The major consequence is that all ordinary uses of i915_vma must use i915_vma_offset/i915_vma_size and not i915_vma.node.start/size directly, as the drm_mm_node will include the guard pages that surround our object. The

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftest: Fix an error code in mock_context_barrier()

2021-02-15 Thread Patchwork
== Series Details == Series: drm/i915/selftest: Fix an error code in mock_context_barrier() URL : https://patchwork.freedesktop.org/series/87103/ State : success == Summary == CI Bug Log - changes from CI_DRM_9777_full -> Patchwork_19682_full ===

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Introduce guard pages to i915_vma

2021-02-15 Thread Chris Wilson
Quoting Matthew Auld (2021-02-15 19:31:39) > On Mon, 15 Feb 2021 at 18:15, Chris Wilson wrote: > > > > Quoting Matthew Auld (2021-02-15 18:04:08) > > > On Mon, 15 Feb 2021 at 15:56, Chris Wilson > > > wrote: > > > > > > > > Introduce the concept of padding the i915_vma with guard pages before >

Re: [Intel-gfx] [RFC v3 10/10] drm/dp: Extract i915's eDP backlight code into DRM helpers

2021-02-15 Thread Lyude Paul
On Mon, 2021-02-15 at 19:34 +0100, Thomas Zimmermann wrote: > Hi > > Am 09.02.21 um 00:03 schrieb Lyude Paul: > > > > > > > +   } else { > > > > +   buf[0] = level; > > > > +   } > > > > + > > > > +   ret = drm_dp_dpcd_write(aux, DP_EDP_BACKLIGHT_BRIGHTNESS_MSB, > > > > bu

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: Wrap all access to i915_vma.node.start|size

2021-02-15 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Wrap all access to i915_vma.node.start|size URL : https://patchwork.freedesktop.org/series/87102/ State : success == Summary == CI Bug Log - changes from CI_DRM_9777_full -> Patchwork_19681_full

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Introduce guard pages to i915_vma

2021-02-15 Thread Matthew Auld
On Mon, 15 Feb 2021 at 18:15, Chris Wilson wrote: > > Quoting Matthew Auld (2021-02-15 18:04:08) > > On Mon, 15 Feb 2021 at 15:56, Chris Wilson wrote: > > > > > > Introduce the concept of padding the i915_vma with guard pages before > > > and aft. The major consequence is that all ordinary uses o

Re: [Intel-gfx] [RFC v3 10/10] drm/dp: Extract i915's eDP backlight code into DRM helpers

2021-02-15 Thread Thomas Zimmermann
Hi Am 09.02.21 um 00:03 schrieb Lyude Paul: +   } else { +   buf[0] = level; +   } + +   ret = drm_dp_dpcd_write(aux, DP_EDP_BACKLIGHT_BRIGHTNESS_MSB, buf, sizeof(buf)); +   if (ret != sizeof(buf)) { +   DRM_ERROR("%s: Failed to write aux backlight level

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v1,1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-15 Thread Patchwork
== Series Details == Series: series starting with [v1,1/3] string: Consolidate yesno() helpers under string.h hood URL : https://patchwork.freedesktop.org/series/87096/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9776_full -> Patchwork_19680_full ===

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Introduce guard pages to i915_vma

2021-02-15 Thread Chris Wilson
Quoting Matthew Auld (2021-02-15 18:04:08) > On Mon, 15 Feb 2021 at 15:56, Chris Wilson wrote: > > > > Introduce the concept of padding the i915_vma with guard pages before > > and aft. The major consequence is that all ordinary uses of i915_vma > > must use i915_vma_offset/i915_vma_size and not i

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftest: Fix an error code in mock_context_barrier()

2021-02-15 Thread Patchwork
== Series Details == Series: drm/i915/selftest: Fix an error code in mock_context_barrier() URL : https://patchwork.freedesktop.org/series/87103/ State : success == Summary == CI Bug Log - changes from CI_DRM_9777 -> Patchwork_19682 Summary

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Refine VT-d scanout workaround

2021-02-15 Thread Matthew Auld
On Mon, 15 Feb 2021 at 15:56, Chris Wilson wrote: > > VT-d may cause overfetch of the scanout PTE, both before and after the > vma (depending on the scanout orientation). bspec recommends that we > provide a tile-row in either directions, and suggests using 160 PTE, > warning that the accesses wil

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Introduce guard pages to i915_vma

2021-02-15 Thread Matthew Auld
On Mon, 15 Feb 2021 at 15:56, Chris Wilson wrote: > > Introduce the concept of padding the i915_vma with guard pages before > and aft. The major consequence is that all ordinary uses of i915_vma > must use i915_vma_offset/i915_vma_size and not i915_vma.node.start/size > directly, as the drm_mm_nod

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Wrap all access to i915_vma.node.start|size

2021-02-15 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Wrap all access to i915_vma.node.start|size URL : https://patchwork.freedesktop.org/series/87102/ State : success == Summary == CI Bug Log - changes from CI_DRM_9777 -> Patchwork_19681 ==

Re: [Intel-gfx] [PATCH] drm/i915/selftest: Fix an error code in mock_context_barrier()

2021-02-15 Thread Chris Wilson
Quoting Dan Carpenter (2021-02-15 15:58:27) > If the igt_request_alloc() call fails then this should return a > negative error code, but currently it returns success. > > Fixes: 85fddf0b0027 ("drm/i915: Introduce a context barrier callback") > Signed-off-by: Dan Carpenter Reviewed-by: Chris Wils

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v1,1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-15 Thread Patchwork
== Series Details == Series: series starting with [v1,1/3] string: Consolidate yesno() helpers under string.h hood URL : https://patchwork.freedesktop.org/series/87096/ State : success == Summary == CI Bug Log - changes from CI_DRM_9776 -> Patchwork_19680 =

Re: [Intel-gfx] [PATCH 1/3] drm/i915/display: move vbt check to intel_ddi_init()

2021-02-15 Thread Lucas De Marchi
On Mon, Feb 15, 2021 at 12:35:50PM +0200, Jani Nikula wrote: On Sat, 13 Feb 2021, Lucas De Marchi wrote: On intel_ddi_init() we already check VBT if the port supports HDMI/DP and bail out otherwise. Instad of checking if a single port is present using VBT in intel_display.c, move the stronger c

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v1,1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-15 Thread Patchwork
== Series Details == Series: series starting with [v1,1/3] string: Consolidate yesno() helpers under string.h hood URL : https://patchwork.freedesktop.org/series/87096/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1160da278ef5 string: Consolidate yesno() helpers under string.

[Intel-gfx] [PATCH] drm/i915/selftest: Fix an error code in mock_context_barrier()

2021-02-15 Thread Dan Carpenter
If the igt_request_alloc() call fails then this should return a negative error code, but currently it returns success. Fixes: 85fddf0b0027 ("drm/i915: Introduce a context barrier callback") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 1 + 1 file chang

Re: [Intel-gfx] [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-15 Thread Andy Shevchenko
On Mon, Feb 15, 2021 at 04:37:50PM +0200, Jani Nikula wrote: > On Mon, 15 Feb 2021, Andy Shevchenko > wrote: > > We have already few similar implementation and a lot of code that can > > benefit > > of the yesno() helper. Consolidate yesno() helpers under string.h hood. > > Good luck. I gave u

[Intel-gfx] [PATCH 3/3] drm/i915: Refine VT-d scanout workaround

2021-02-15 Thread Chris Wilson
VT-d may cause overfetch of the scanout PTE, both before and after the vma (depending on the scanout orientation). bspec recommends that we provide a tile-row in either directions, and suggests using 160 PTE, warning that the accesses will wrap around the ends of the GGTT. Currently, we fill the en

[Intel-gfx] [PATCH 1/3] drm/i915: Wrap all access to i915_vma.node.start|size

2021-02-15 Thread Chris Wilson
We already wrap i915_vma.node.start for use with the GGTT, as there we can perform additional sanity checks that the node belongs to the GGTT and fits within the 32b registers. In the next couple of patches, we will introduce guard pages around the objects _inside_ the drm_mm_node allocation. That

[Intel-gfx] [PATCH 2/3] drm/i915: Introduce guard pages to i915_vma

2021-02-15 Thread Chris Wilson
Introduce the concept of padding the i915_vma with guard pages before and aft. The major consequence is that all ordinary uses of i915_vma must use i915_vma_offset/i915_vma_size and not i915_vma.node.start/size directly, as the drm_mm_node will include the guard pages that surround our object. The

[Intel-gfx] [PATCH 5.10 013/104] drm/dp_mst: Dont report ports connected if nothing is attached to them

2021-02-15 Thread Greg Kroah-Hartman
From: Imre Deak commit 873e5bb9fbd99e4a26c448b5c7af942a6d7aa60d upstream. Reporting a port as connected if nothing is attached to them leads to any i2c transactions on this port trying to use an uninitialized i2c adapter, fix this. Let's account for this case even if branch devices have no good

Re: [Intel-gfx] [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-15 Thread Andy Shevchenko
+Cc: Sakari and printk people On Mon, Feb 15, 2021 at 4:28 PM Christian König wrote: > Am 15.02.21 um 15:21 schrieb Andy Shevchenko: > > We have already few similar implementation and a lot of code that can > > benefit > > of the yesno() helper. Consolidate yesno() helpers under string.h hood.

Re: [Intel-gfx] [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-15 Thread Jani Nikula
On Mon, 15 Feb 2021, Andy Shevchenko wrote: > We have already few similar implementation and a lot of code that can benefit > of the yesno() helper. Consolidate yesno() helpers under string.h hood. Good luck. I gave up after just four versions. [1] Acked-by: Jani Nikula BR, Jani. [1] http:

Re: [Intel-gfx] [5.10.y regression] i915 clear-residuals mitigation is causing gfx issues

2021-02-15 Thread Greg Kroah-Hartman
On Sun, Feb 14, 2021 at 05:00:44PM +0100, Hans de Goede wrote: > Hi, > > On 2/11/21 1:26 PM, Hans de Goede wrote: > > Hi, > > > > On 2/11/21 11:49 AM, Chris Wilson wrote: > >> Quoting Hans de Goede (2021-02-11 10:36:13) > >>> Hi, > >>> > >>> On 2/10/21 1:48 PM, Chris Wilson wrote: > Quoting

Re: [Intel-gfx] [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-15 Thread Christian König
Am 15.02.21 um 15:21 schrieb Andy Shevchenko: We have already few similar implementation and a lot of code that can benefit of the yesno() helper. Consolidate yesno() helpers under string.h hood. Signed-off-by: Andy Shevchenko Looks like a good idea to me, feel free to add an Acked-by: Chris

[Intel-gfx] [PATCH v1 2/3] string: Move onoff() helper under string.h hood

2021-02-15 Thread Andy Shevchenko
We have already an implementation and a lot of code that can benefit of the onoff() helper. Move it under string.h hood. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/i915/i915_utils.h | 5 - include/linux/string.h| 5 + 2 files changed, 5 insertions(+), 5 deletions(-)

[Intel-gfx] [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-15 Thread Andy Shevchenko
We have already few similar implementation and a lot of code that can benefit of the yesno() helper. Consolidate yesno() helpers under string.h hood. Signed-off-by: Andy Shevchenko --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c| 6 +- drivers/gpu/drm/i915/i915_utils.h

[Intel-gfx] [PATCH v1 3/3] string: Move enableddisabled() helper under string.h hood

2021-02-15 Thread Andy Shevchenko
We have already an implementation and a lot of code that can benefit of the enableddisabled() helper. Move it under string.h hood. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/i915/i915_utils.h | 5 - include/linux/string.h| 5 + 2 files changed, 5 insertions(+), 5 dele

Re: [Intel-gfx] [PATCH] drm/i915/gem: Add a check for object size for corner cases

2021-02-15 Thread Chris Wilson
Quoting Ram Moon, AnandX (2021-02-15 12:29:17) > Hi Chris, > > -Original Message- > From: dri-devel On Behalf Of Chris > Wilson > Sent: Wednesday, February 10, 2021 4:15 PM > To: Ram Moon, AnandX ; Jani Nikula > ; Auld, Matthew ; > Surendrakumar Upadhyay, TejaskumarX > ; Ursulin, Tvrt

Re: [Intel-gfx] [PATCH] drm/i915/gem: Add a check for object size for corner cases

2021-02-15 Thread Ram Moon, AnandX
Hi Chris, -Original Message- From: dri-devel On Behalf Of Chris Wilson Sent: Wednesday, February 10, 2021 4:15 PM To: Ram Moon, AnandX ; Jani Nikula ; Auld, Matthew ; Surendrakumar Upadhyay, TejaskumarX ; Ursulin, Tvrtko ; dri-de...@lists.freedesktop.org; intel-gfx@lists.freedesktop

Re: [Intel-gfx] [PATCH 1/3] drm/i915/display: move vbt check to intel_ddi_init()

2021-02-15 Thread Jani Nikula
On Sat, 13 Feb 2021, Lucas De Marchi wrote: > On intel_ddi_init() we already check VBT if the port supports HDMI/DP > and bail out otherwise. Instad of checking if a single port is present > using VBT in intel_display.c, move the stronger check to > intel_ddi_init() and return early in case it's n

Re: [Intel-gfx] linux-next: build warning after merge of the pm tree

2021-02-15 Thread Andy Shevchenko
+Cc: Patrik (JFYI). On Mon, Feb 15, 2021 at 12:23 PM Andy Shevchenko wrote: > > On Mon, Feb 15, 2021 at 2:45 AM Stephen Rothwell > wrote: > > > > Hi all, > > > > After merging the pm tree, today's linux-next build (x86_64 allmodconfig) > > produced this warning: > > > > In file included from dr

Re: [Intel-gfx] linux-next: build warning after merge of the pm tree

2021-02-15 Thread Andy Shevchenko
On Mon, Feb 15, 2021 at 2:45 AM Stephen Rothwell wrote: > > Hi all, > > After merging the pm tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > In file included from drivers/gpu/drm/gma500/mdfld_output.c:28: > arch/x86/include/asm/intel_scu_ipc.h:23:12: warning: 'str

Re: [Intel-gfx] [PATCH] kernel: Expose SYS_kcmp by default

2021-02-15 Thread Lucas Stach
Am Samstag, dem 13.02.2021 um 18:40 +0100 schrieb Pavel Machek: > Hi! > > > Userspace has discovered the functionality offered by SYS_kcmp and has > > started to depend upon it. In particular, Mesa uses SYS_kcmp for > > os_same_file_description() in order to identify when two fd (e.g. device > > o

Re: [Intel-gfx] [PATCH v3] kcmp: Support selection of SYS_kcmp without CHECKPOINT_RESTORE

2021-02-15 Thread Thomas Zimmermann
Hi Am 05.02.21 um 23:00 schrieb Chris Wilson: Userspace has discovered the functionality offered by SYS_kcmp and has started to depend upon it. In particular, Mesa uses SYS_kcmp for os_same_file_description() in order to identify when two fd (e.g. device or dmabuf) point to the same struct file.