[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev2)

2021-02-08 Thread Patchwork
== Series Details == Series: drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev2) URL : https://patchwork.freedesktop.org/series/81764/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9747 -> Patchwork_19638

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev2)

2021-02-08 Thread Patchwork
== Series Details == Series: drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev2) URL : https://patchwork.freedesktop.org/series/81764/ State : warning == Summary == $ dim checkpatch origin/drm-tip 785109fdc964 drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmi

Re: [Intel-gfx] [PATCH] drm/i915/debugfs: HDCP capability enc NULL check

2021-02-08 Thread Gupta, Anshuman
> -Original Message- > From: Gupta, Anshuman > Sent: Friday, February 5, 2021 5:43 PM > To: Deak, Imre > Cc: intel-gfx@lists.freedesktop.org > Subject: RE: [Intel-gfx] [PATCH] drm/i915/debugfs: HDCP capability enc NULL > check > > > > > -Original Message- > > From: Imre Deak

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev6)

2021-02-08 Thread Patchwork
== Series Details == Series: drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev6) URL : https://patchwork.freedesktop.org/series/84754/ State : success == Summary == CI Bug Log - changes from CI_DRM_9747_full -> Patchwork_19636_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915: Disallow plane x+w>stride on ilk+ with X-tiling

2021-02-08 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Disallow plane x+w>stride on ilk+ with X-tiling URL : https://patchwork.freedesktop.org/series/86882/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9747 -> Patchwork_19637 ==

Re: [Intel-gfx] [FYI PATCH] i915: kvmgt: the KVM mmu_lock is now an rwlock

2021-02-08 Thread kernel test robot
Hi Paolo, I love your patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on linux/master drm-tip/drm-tip linus/master v5.11-rc6 next-20210125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patc

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: Disallow plane x+w>stride on ilk+ with X-tiling

2021-02-08 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Disallow plane x+w>stride on ilk+ with X-tiling URL : https://patchwork.freedesktop.org/series/86882/ State : warning == Summary == $ dim checkpatch origin/drm-tip d3049184b718 drm/i915: Disallow plane x+w>stride on ilk+ with X

[Intel-gfx] [PATCH 3/3] drm/i915: Warn when releasing a frontbuffer while in use

2021-02-08 Thread Ville Syrjala
From: Ville Syrjälä Let's scream if we are about to release a frontbuffer which is still in use. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_frontbuffer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_frontbuffer.c b/drivers/g

[Intel-gfx] [PATCH 2/3] drm/i915: Fix overlay frontbuffer tracking

2021-02-08 Thread Ville Syrjala
From: Ville Syrjälä We don't have a persistent fb holding a reference to the frontbuffer object, so every time we do the get+put we throw the frontbuffer object immediately away. And so the next time around we get a pristine frontbuffer object with bits==0 even for the old vma. This confuses the

[Intel-gfx] [PATCH 1/3] drm/i915: Disallow plane x+w>stride on ilk+ with X-tiling

2021-02-08 Thread Ville Syrjala
From: Ville Syrjälä ilk+ planes get notably unhappy when the plane x+w exceeds the stride. This wasn't a problem previously because we always aligned SURF to the closest tile boundary so the x offset never got particularly large. But now with async flips we have to align to 256KiB instead and thu

Re: [Intel-gfx] [PATCH] drm/i915/gvt/kvmgt: Fix the build failure in kvmgt.

2021-02-08 Thread Zhenyu Wang
On 2021.02.09 02:52:10 +0800, Yu Zhang wrote: > Previously, commit 531810caa9f4 ("KVM: x86/mmu: Use > an rwlock for the x86 MMU") replaced KVM's mmu_lock > with type rwlock_t. This will cause a build failure > in kvmgt, which uses the same lock when trying to add/ > remove some GFNs to/from the pag

Re: [Intel-gfx] [FYI PATCH] i915: kvmgt: the KVM mmu_lock is now an rwlock

2021-02-08 Thread Zhenyu Wang
On 2021.02.08 06:34:37 -0500, Paolo Bonzini wrote: > Adjust the KVMGT page tracking callbacks. > > Cc: Zhenyu Wang > Cc: Zhi Wang > Cc: intel-gvt-...@lists.freedesktop.org > Cc: intel-gfx@lists.freedesktop.org > Signed-off-by: Paolo Bonzini > --- Thanks for that! Acked-by: Zhenyu Wang > dr

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: rework gem_create flow for upcoming extensions

2021-02-08 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: rework gem_create flow for upcoming extensions URL : https://patchwork.freedesktop.org/series/86866/ State : success == Summary == CI Bug Log - changes from CI_DRM_9747_full -> Patchwork_19635_full =

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] i915/perf: Store a mask of valid OA formats for a platform

2021-02-08 Thread Patchwork
== Series Details == Series: series starting with [1/3] i915/perf: Store a mask of valid OA formats for a platform URL : https://patchwork.freedesktop.org/series/86865/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9747_full -> Patchwork_19634_full ===

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev6)

2021-02-08 Thread Patchwork
== Series Details == Series: drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev6) URL : https://patchwork.freedesktop.org/series/84754/ State : success == Summary == CI Bug Log - changes from CI_DRM_9747 -> Patchwork_19636 ==

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev6)

2021-02-08 Thread Patchwork
== Series Details == Series: drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev6) URL : https://patchwork.freedesktop.org/series/84754/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev6)

2021-02-08 Thread Patchwork
== Series Details == Series: drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev6) URL : https://patchwork.freedesktop.org/series/84754/ State : warning == Summary == $ dim checkpatch origin/drm-tip 745f01c7a14e drm/nouveau/kms/nv40-/backlight: Assign prop type once -:7

[Intel-gfx] [RFC v4 11/11] drm/nouveau/kms/nv50-: Add basic DPCD backlight support for nouveau

2021-02-08 Thread Lyude Paul
This adds support for controlling panel backlights over eDP using VESA's standard backlight control interface. Luckily, Nvidia was cool enough to never come up with their own proprietary backlight control interface (at least, not any that I or the laptop manufacturers I've talked to are aware of),

[Intel-gfx] [RFC v4 10/11] drm/dp: Extract i915's eDP backlight code into DRM helpers

2021-02-08 Thread Lyude Paul
Since we're about to implement eDP backlight support in nouveau using the standard protocol from VESA, we might as well just take the code that's already written for this and move it into a set of shared DRM helpers. Note that these helpers are intended to handle DPCD related backlight control bit

[Intel-gfx] [RFC v4 09/11] drm/i915/dpcd_bl: Print return codes for VESA backlight failures

2021-02-08 Thread Lyude Paul
Also, stop printing the DPCD register that failed, and just describe it instead. Saves us from having to look up each register offset when reading through kernel logs (plus, DPCD dumping with drm.debug |= 0x100 will give us that anyway). Signed-off-by: Lyude Paul --- .../drm/i915/display/intel_d

[Intel-gfx] [RFC v4 05/11] drm/i915/dpcd_bl: Cleanup intel_dp_aux_vesa_enable_backlight() a bit

2021-02-08 Thread Lyude Paul
Get rid of the extraneous switch case in here, and just open code edp_backlight_mode as we only ever use it once. v4: * Check that backlight mode is DP_EDP_BACKLIGHT_CONTROL_MODE_DPCD, not DP_EDP_BACKLIGHT_CONTROL_MODE_MASK - imirkin Signed-off-by: Lyude Paul --- .../gpu/drm/i915/display/inte

[Intel-gfx] [RFC v4 08/11] drm/i915/dpcd_bl: Return early in vesa_calc_max_backlight if we can't read PWMGEN_BIT_COUNT

2021-02-08 Thread Lyude Paul
If we can't read DP_EDP_PWMGEN_BIT_COUNT in intel_dp_aux_vesa_calc_max_backlight() but do have a valid PWM frequency defined in the VBT, we'll keep going in the function until we inevitably fail on reading DP_EDP_PWMGEN_BIT_COUNT_CAP_MIN. There's not much point in doing this, so just return early.

[Intel-gfx] [RFC v4 03/11] drm/i915/dpcd_bl: Remove redundant AUX backlight frequency calculations

2021-02-08 Thread Lyude Paul
Noticed this while moving all of the VESA backlight code in i915 over to DRM helpers: it would appear that we calculate the frequency value we want to write to DP_EDP_BACKLIGHT_FREQ_SET twice even though this value never actually changes during runtime. So, let's simplify things by just caching thi

[Intel-gfx] [RFC v4 07/11] drm/i915/dpcd_bl: Move VESA backlight enabling code closer together

2021-02-08 Thread Lyude Paul
No functional changes, just move set_vesa_backlight_enable() closer to it's only caller: intel_dp_aux_vesa_enable_backlight(). Signed-off-by: Lyude Paul Reviewed-by: Rodrigo Vivi --- .../drm/i915/display/intel_dp_aux_backlight.c | 54 +-- 1 file changed, 27 insertions(+), 27 del

[Intel-gfx] [RFC v4 06/11] drm/i915/dpcd_bl: Cache some backlight capabilities in intel_panel.backlight

2021-02-08 Thread Lyude Paul
Since we're about to be moving this code into shared DRM helpers, we might as well start to cache certain backlight capabilities that can be determined from the EDP DPCD, and are likely to be relevant to the majority of drivers using said helpers. The main purpose of this is just to prevent every d

[Intel-gfx] [RFC v4 04/11] drm/i915/dpcd_bl: Handle drm_dpcd_read/write() return values correctly

2021-02-08 Thread Lyude Paul
This is kind of an annoying aspect of DRM's DP helpers: drm_dp_dpcd_readb/writeb() return the size of bytes read/written on success, thus we want to check against that instead of checking if the return value is less than 0. I'll probably be fixing this in the near future once I start doing DP work

[Intel-gfx] [RFC v4 02/11] drm/nouveau/kms: Don't probe eDP connectors more then once

2021-02-08 Thread Lyude Paul
eDP doesn't do hotplugging, so there's no reason for us to reprobe it (unless a connection status change is being forced, of course). Signed-off-by: Lyude Paul Cc: Jani Nikula Cc: Dave Airlie Cc: greg.depo...@gmail.com --- drivers/gpu/drm/nouveau/nouveau_connector.c | 6 ++ 1 file changed,

[Intel-gfx] [RFC v4 00/11] drm: Extract DPCD backlight helpers from i915, add support in nouveau

2021-02-08 Thread Lyude Paul
This series: * Cleans up i915's DPCD backlight code a little bit * Extracts i915's DPCD backlight code into a set of shared DRM helpers * Starts using those helpers in nouveau to add support to nouveau for DPCD backlight control v2 series-wide changes: * Rebase v3 series-wide changes: * Split up

[Intel-gfx] [RFC v4 01/11] drm/nouveau/kms/nv40-/backlight: Assign prop type once

2021-02-08 Thread Lyude Paul
Signed-off-by: Lyude Paul Cc: Jani Nikula Cc: Dave Airlie Cc: greg.depo...@gmail.com --- drivers/gpu/drm/nouveau/nouveau_backlight.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/drivers/gpu/drm/nouveau/nouveau_backlight.c

Re: [Intel-gfx] [5.10.y regression] i915 clear-residuals mitigation is causing gfx issues

2021-02-08 Thread Chris Wilson
Quoting Hans de Goede (2021-02-08 20:38:58) > Hi All, > > We (Fedora) have been receiving reports from multiple users about gfx issues > / glitches > stating with 5.10.9. All reporters are users of Ivy Bridge / Haswell iGPUs > and all > reporters report that adding i915.mitigations=off to the cm

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/4] drm/i915: Create stolen memory region from local memory

2021-02-08 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Create stolen memory region from local memory URL : https://patchwork.freedesktop.org/series/86861/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9747_full -> Patchwork_19633_full ==

Re: [Intel-gfx] [RFC v3 10/10] drm/dp: Extract i915's eDP backlight code into DRM helpers

2021-02-08 Thread Lyude Paul
On Mon, 2021-02-08 at 09:46 +0100, Thomas Zimmermann wrote: > Hi > > Am 06.02.21 um 00:45 schrieb Lyude Paul: > > Since we're about to implement eDP backlight support in nouveau using the > > standard protocol from VESA, we might as well just take the code that's > > already written for this and m

Re: [Intel-gfx] [RFC v3 00/10] drm: Extract DPCD backlight helpers from i915, add support in nouveau

2021-02-08 Thread Lyude Paul
thanks for the review comments everyone! I'm going through them now but realized I should probably point out that I somehow sent this patch series and did not realize I did so in the middle of a rebase, and as such completely forgot the parts here that actually started using these helpers in nouvea

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove unused debug functions

2021-02-08 Thread Patchwork
== Series Details == Series: drm/i915: Remove unused debug functions URL : https://patchwork.freedesktop.org/series/86859/ State : success == Summary == CI Bug Log - changes from CI_DRM_9747_full -> Patchwork_19632_full Summary --- *

Re: [Intel-gfx] [PATCH 30/31] drm/i915: Support secure dispatch on gen6/gen7

2021-02-08 Thread Chris Wilson
Quoting Dave Airlie (2021-02-08 20:55:19) > On Mon, 8 Feb 2021 at 20:53, Chris Wilson wrote: > > > > Re-enable secure dispatch for gen6/gen7, primarily to workaround the > > command parser and overly zealous command validation on Haswell. For > > example this prevents making accurate measurements

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/tgl+: Make sure TypeC FIA is powered up when initializing it

2021-02-08 Thread Patchwork
== Series Details == Series: drm/i915/tgl+: Make sure TypeC FIA is powered up when initializing it URL : https://patchwork.freedesktop.org/series/86858/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9747_full -> Patchwork_19631_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Allow the module to load even if live selftests fail

2021-02-08 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Allow the module to load even if live selftests fail URL : https://patchwork.freedesktop.org/series/86851/ State : success == Summary == CI Bug Log - changes from CI_DRM_9747_full -> Patchwork_19630_full =

[Intel-gfx] ✗ Fi.CI.IGT: failure for i915: kvmgt: the KVM mmu_lock is now an rwlock

2021-02-08 Thread Patchwork
== Series Details == Series: i915: kvmgt: the KVM mmu_lock is now an rwlock URL : https://patchwork.freedesktop.org/series/86847/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9747_full -> Patchwork_19629_full Summary -

Re: [Intel-gfx] [PATCH] drm/i915/rkl: Remove require_force_probe protection

2021-02-08 Thread Rodrigo Vivi
On Wed, Feb 03, 2021 at 11:43:13AM +, Chris Wilson wrote: > Quoting Tejas Upadhyay (2020-11-30 12:48:55) > > Removing force probe protection from RKL platform. Did > > not observe warnings, errors, flickering or any visual > > defects while doing ordinary tasks like browsing and > > editing doc

Re: [Intel-gfx] [PATCH v3] kcmp: Support selection of SYS_kcmp without CHECKPOINT_RESTORE

2021-02-08 Thread Kees Cook
On Fri, Feb 05, 2021 at 10:00:12PM +, Chris Wilson wrote: > Userspace has discovered the functionality offered by SYS_kcmp and has > started to depend upon it. In particular, Mesa uses SYS_kcmp for > os_same_file_description() in order to identify when two fd (e.g. device > or dmabuf) point to

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gvt/kvmgt: Fix the build failure in kvmgt.

2021-02-08 Thread Patchwork
== Series Details == Series: drm/i915/gvt/kvmgt: Fix the build failure in kvmgt. URL : https://patchwork.freedesktop.org/series/86845/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9747_full -> Patchwork_19628_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: rework gem_create flow for upcoming extensions

2021-02-08 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: rework gem_create flow for upcoming extensions URL : https://patchwork.freedesktop.org/series/86866/ State : success == Summary == CI Bug Log - changes from CI_DRM_9747 -> Patchwork_19635 ===

Re: [Intel-gfx] [PATCH 30/31] drm/i915: Support secure dispatch on gen6/gen7

2021-02-08 Thread Dave Airlie
On Mon, 8 Feb 2021 at 20:53, Chris Wilson wrote: > > Re-enable secure dispatch for gen6/gen7, primarily to workaround the > command parser and overly zealous command validation on Haswell. For > example this prevents making accurate measurements using a journal for > store results from the GPU wit

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: rework gem_create flow for upcoming extensions

2021-02-08 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: rework gem_create flow for upcoming extensions URL : https://patchwork.freedesktop.org/series/86866/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2da1a8f2c4e3 drm/i915: rework gem_create flow for upcoming exten

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] i915/perf: Store a mask of valid OA formats for a platform

2021-02-08 Thread Patchwork
== Series Details == Series: series starting with [1/3] i915/perf: Store a mask of valid OA formats for a platform URL : https://patchwork.freedesktop.org/series/86865/ State : success == Summary == CI Bug Log - changes from CI_DRM_9747 -> Patchwork_19634 =

Re: [Intel-gfx] [RFC 08/14] drm/i915/pxp: Implement arb session teardown

2021-02-08 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2021-02-08 19:43:23) > > > On 2/6/2021 4:59 AM, Chris Wilson wrote: > > Is there any reason at all to use the batch and not just emit directly > > into the ring? The command sequence is short. And you probably want to > > disable arbitration. > > Future proofing -

[Intel-gfx] [5.10.y regression] i915 clear-residuals mitigation is causing gfx issues

2021-02-08 Thread Hans de Goede
Hi All, We (Fedora) have been receiving reports from multiple users about gfx issues / glitches stating with 5.10.9. All reporters are users of Ivy Bridge / Haswell iGPUs and all reporters report that adding i915.mitigations=off to the cmdline fixes things, see: https://bugzilla.redhat.com/sho

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] i915/perf: Store a mask of valid OA formats for a platform

2021-02-08 Thread Patchwork
== Series Details == Series: series starting with [1/3] i915/perf: Store a mask of valid OA formats for a platform URL : https://patchwork.freedesktop.org/series/86865/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be

Re: [Intel-gfx] [CI 6/6] drm/i915/gem: Drop lru bumping on display unpinning

2021-02-08 Thread Dave Airlie
On Wed, 20 Jan 2021 at 07:43, Chris Wilson wrote: > > Simplify the frontbuffer unpin by removing the lock requirement. The LRU > bumping was primarily to protect the GTT from being evicted and from > frontbuffers being eagerly shrunk. Now we protect frontbuffers from the > shrinker, and we avoid a

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Create stolen memory region from local memory

2021-02-08 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Create stolen memory region from local memory URL : https://patchwork.freedesktop.org/series/86861/ State : success == Summary == CI Bug Log - changes from CI_DRM_9747 -> Patchwork_19633

Re: [Intel-gfx] [RFC 08/14] drm/i915/pxp: Implement arb session teardown

2021-02-08 Thread Daniele Ceraolo Spurio
On 2/6/2021 4:59 AM, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2021-02-06 02:09:19) From: "Huang, Sean Z" Teardown is triggered when the display topology changes and no long meets the secure playback requirement, and hardware trashes all the encryption keys for display. Additional

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915: Create stolen memory region from local memory

2021-02-08 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Create stolen memory region from local memory URL : https://patchwork.freedesktop.org/series/86861/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be ch

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: Create stolen memory region from local memory

2021-02-08 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Create stolen memory region from local memory URL : https://patchwork.freedesktop.org/series/86861/ State : warning == Summary == $ dim checkpatch origin/drm-tip 016b7066311e drm/i915: Create stolen memory region from local mem

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove unused debug functions

2021-02-08 Thread Patchwork
== Series Details == Series: drm/i915: Remove unused debug functions URL : https://patchwork.freedesktop.org/series/86859/ State : success == Summary == CI Bug Log - changes from CI_DRM_9747 -> Patchwork_19632 Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl+: Make sure TypeC FIA is powered up when initializing it

2021-02-08 Thread Patchwork
== Series Details == Series: drm/i915/tgl+: Make sure TypeC FIA is powered up when initializing it URL : https://patchwork.freedesktop.org/series/86858/ State : success == Summary == CI Bug Log - changes from CI_DRM_9747 -> Patchwork_19631

Re: [Intel-gfx] [RFC 04/14] drm/i915/pxp: allocate a vcs context for pxp usage

2021-02-08 Thread Daniele Ceraolo Spurio
On 2/6/2021 4:49 AM, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2021-02-06 02:09:15) The context is required to send the session termination commands to the VCS, which will be implemented in a follow-up patch. We can also use the presence of the context as a check of pxp initializati

Re: [Intel-gfx] [RFC 10/14] drm/i915/pxp: Enable PXP power management

2021-02-08 Thread Daniele Ceraolo Spurio
On 2/6/2021 5:08 AM, Chris Wilson wrote: Quoting Chris Wilson (2021-02-06 13:06:05) Quoting Daniele Ceraolo Spurio (2021-02-06 02:09:21) + if (!ret) { + ret = wait_for(!pxp->termination_in_progress, 10); This only works by chance. The compiler doesn't even have to reload

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Allow the module to load even if live selftests fail

2021-02-08 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Allow the module to load even if live selftests fail URL : https://patchwork.freedesktop.org/series/86851/ State : success == Summary == CI Bug Log - changes from CI_DRM_9747 -> Patchwork_19630 ===

Re: [Intel-gfx] [RFC 12/14] drm/i915/pxp: User interface for Protected buffer

2021-02-08 Thread Daniele Ceraolo Spurio
On 2/6/2021 4:25 AM, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2021-02-06 02:09:23) From: Bommu Krishnaiah This api allow user mode to create Protected buffer and context creation. Only contexts created with the flag set are allowed to operate on protected buffers. We only allow

Re: [Intel-gfx] [PATCH] drm/vblank: Avoid storing a timestamp for the same frame twice

2021-02-08 Thread Ville Syrjälä
On Mon, Feb 08, 2021 at 06:43:53PM +0100, Daniel Vetter wrote: > On Mon, Feb 8, 2021 at 5:58 PM Ville Syrjälä > wrote: > > > > On Mon, Feb 08, 2021 at 10:56:36AM +0100, Daniel Vetter wrote: > > > On Fri, Feb 05, 2021 at 11:19:19PM +0200, Ville Syrjälä wrote: > > > > On Fri, Feb 05, 2021 at 06:24:0

[Intel-gfx] [PATCH stable-5.10 2/2] drm/i915: Skip vswing programming for TBT

2021-02-08 Thread Ville Syrjala
From: Ville Syrjälä commit eaf5bfe37db871031232d2bf2535b6ca92afbad8 upstream. In thunderbolt mode the PHY is owned by the thunderbolt controller. We are not supposed to touch it. So skip the vswing programming as well (we already skipped the other steps not applicable to TBT). Touching this stu

[Intel-gfx] [PATCH stable-5.10 1/2] drm/i915: Fix ICL MG PHY vswing handling

2021-02-08 Thread Ville Syrjala
From: Ville Syrjälä commit a2a5f5628e5494ca9353f761f7fe783dfa82fb9a upstream. The MH PHY vswing table does have all the entries these days. Get rid of the old hacks in the code which claim otherwise. This hack was totally bogus anyway. The correct way to handle the lack of those two entries wou

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: kvmgt: the KVM mmu_lock is now an rwlock

2021-02-08 Thread Patchwork
== Series Details == Series: i915: kvmgt: the KVM mmu_lock is now an rwlock URL : https://patchwork.freedesktop.org/series/86847/ State : success == Summary == CI Bug Log - changes from CI_DRM_9747 -> Patchwork_19629 Summary --- **SU

Re: [Intel-gfx] [PATCH] drm/vblank: Avoid storing a timestamp for the same frame twice

2021-02-08 Thread Daniel Vetter
On Mon, Feb 8, 2021 at 5:58 PM Ville Syrjälä wrote: > > On Mon, Feb 08, 2021 at 10:56:36AM +0100, Daniel Vetter wrote: > > On Fri, Feb 05, 2021 at 11:19:19PM +0200, Ville Syrjälä wrote: > > > On Fri, Feb 05, 2021 at 06:24:08PM +0200, Ville Syrjälä wrote: > > > > On Fri, Feb 05, 2021 at 04:46:27PM

[Intel-gfx] [PATCH 2/2] drm/i915/uapi: introduce drm_i915_gem_create_ext

2021-02-08 Thread Matthew Auld
Same old gem_create but with now with extensions support. This is needed to support various upcoming usecases. v2:(Chris) - Use separate ioctl number for gem_create_ext, instead of hijacking the existing gem_create ioctl, otherwise we run into the issue with being unable to detect

[Intel-gfx] [PATCH 1/2] drm/i915: rework gem_create flow for upcoming extensions

2021-02-08 Thread Matthew Auld
With the upcoming gem_create_ext we want to be able create a "vanilla" object upfront and pass that directly to the extensions, before actually initialising the object. Functionally this should be the same expect we now feed the object into the lower-level region specific init_object. Signed-off-b

[Intel-gfx] [PATCH 1/3] i915/perf: Store a mask of valid OA formats for a platform

2021-02-08 Thread Umesh Nerlige Ramappa
Validity of an OA format is checked by using a sparse array of formats per gen. Instead maintain a mask of supported formats for a platform in the perf object. v2: Use set_bit and test_bit style for the format_mask (Chris) Signed-off-by: Umesh Nerlige Ramappa Reviewed-by: Lionel Landwerlin ---

[Intel-gfx] [PATCH 3/3] i915/perf: Add additional OA formats for gen12

2021-02-08 Thread Umesh Nerlige Ramappa
Gen12 supports additional OA formats as compared to what was added earlier. Include the additional OA formats. Signed-off-by: Umesh Nerlige Ramappa Reviewed-by: Lionel Landwerlin --- drivers/gpu/drm/i915/i915_perf.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/dr

[Intel-gfx] [PATCH 2/3] i915/perf: Move OA formats to single array

2021-02-08 Thread Umesh Nerlige Ramappa
Variations in OA formats in the different gens has led to creation of several sparse arrays to store the formats. Move oa formats into a single array and format_mask to check for platform specific oa formats. Signed-off-by: Umesh Nerlige Ramappa Reviewed-by: Lionel Landwerlin --- drivers/gpu/d

Re: [Intel-gfx] [RFC 05/14] drm/i915/pxp: set KCR reg init during the boot time

2021-02-08 Thread Rodrigo Vivi
On Fri, Feb 05, 2021 at 06:09:16PM -0800, Daniele Ceraolo Spurio wrote: > Set the KCR init during the boot time, which is required by hardware, > to allow us doing further protection operation such as sending commands > to GPU or TEE. > > Signed-off-by: Huang, Sean Z > Signed-off-by: Daniele Cera

Re: [Intel-gfx] [PATCH] drm/vblank: Avoid storing a timestamp for the same frame twice

2021-02-08 Thread Ville Syrjälä
On Mon, Feb 08, 2021 at 10:56:36AM +0100, Daniel Vetter wrote: > On Fri, Feb 05, 2021 at 11:19:19PM +0200, Ville Syrjälä wrote: > > On Fri, Feb 05, 2021 at 06:24:08PM +0200, Ville Syrjälä wrote: > > > On Fri, Feb 05, 2021 at 04:46:27PM +0100, Daniel Vetter wrote: > > > > On Thu, Feb 04, 2021 at 05:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt/kvmgt: Fix the build failure in kvmgt.

2021-02-08 Thread Patchwork
== Series Details == Series: drm/i915/gvt/kvmgt: Fix the build failure in kvmgt. URL : https://patchwork.freedesktop.org/series/86845/ State : success == Summary == CI Bug Log - changes from CI_DRM_9747 -> Patchwork_19628 Summary ---

[Intel-gfx] [PATCH 3/4] drm/i915/stolen: enforce the min_page_size contract

2021-02-08 Thread Matthew Auld
From: CQ Tang Since stolen can now be device local-memory underneath, we should try to enforce any min_page_size restrictions when allocating pages. Signed-off-by: CQ Tang Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 12 +--- 1 file changed, 9 insertion

[Intel-gfx] [PATCH 4/4] drm/i915/stolen: pass the allocation flags

2021-02-08 Thread Matthew Auld
From: CQ Tang Stolen memory is always allocated as physically contiguous pages, mark the object flags as such. Signed-off-by: CQ Tang Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drive

[Intel-gfx] [PATCH 2/4] drm/i915/stolen: treat stolen local as normal local memory

2021-02-08 Thread Matthew Auld
Underneath it's the same stuff, so things like the PTE_LM bits for the GTT should just keep working as-is. Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_lmem.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_lmem.c b/

[Intel-gfx] [PATCH 1/4] drm/i915: Create stolen memory region from local memory

2021-02-08 Thread Matthew Auld
From: CQ Tang Add "REGION_STOLEN" device info to dg1, create stolen memory region from upper portion of local device memory, starting from DSMBASE. v2: - s/drm_info/drm_dbg; userspace likely doesn't care about stolen. - mem->type is only setup after the region probe, so setting the name

Re: [Intel-gfx] [PATCH 09/31] drm/i915: Replace priolist rbtree with a skiplist

2021-02-08 Thread Chris Wilson
Quoting Tvrtko Ursulin (2021-02-08 15:23:17) > > On 08/02/2021 10:52, Chris Wilson wrote: > > static struct list_head * > > lookup_priolist(struct i915_sched *se, int prio) > > { > > - struct i915_priolist *p; > > - struct rb_node **parent, *rb; > > - bool first = true; > > +

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt/kvmgt: Fix the build failure in kvmgt.

2021-02-08 Thread Patchwork
== Series Details == Series: drm/i915/gvt/kvmgt: Fix the build failure in kvmgt. URL : https://patchwork.freedesktop.org/series/86845/ State : warning == Summary == $ dim checkpatch origin/drm-tip a0e31f3d4bbc drm/i915/gvt/kvmgt: Fix the build failure in kvmgt. -:6: WARNING:UNKNOWN_COMMIT_ID:

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/31] drm/i915/gt: Ratelimit heartbeat completion probing

2021-02-08 Thread Patchwork
== Series Details == Series: series starting with [01/31] drm/i915/gt: Ratelimit heartbeat completion probing URL : https://patchwork.freedesktop.org/series/86841/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9747 -> Patchwork_19626 ==

Re: [Intel-gfx] [PATCH 10/31] drm/i915: Fair low-latency scheduling

2021-02-08 Thread Chris Wilson
Quoting Tvrtko Ursulin (2021-02-08 16:03:03) > > On 08/02/2021 15:29, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2021-02-08 14:56:31) > >> On 08/02/2021 10:52, Chris Wilson wrote: > >>> +static bool need_preempt(const struct intel_engine_cs *engine, > >>> const struct

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix HAS_LSPCON macro for platforms between GEN9 and GEN10 (rev2)

2021-02-08 Thread Patchwork
== Series Details == Series: drm/i915: Fix HAS_LSPCON macro for platforms between GEN9 and GEN10 (rev2) URL : https://patchwork.freedesktop.org/series/86842/ State : failure == Summary == Applying: drm/i915: Fix HAS_LSPCON macro for platforms between GEN9 and GEN10 Using index info to reconst

Re: [Intel-gfx] [PATCH 10/31] drm/i915: Fair low-latency scheduling

2021-02-08 Thread Tvrtko Ursulin
On 08/02/2021 15:29, Chris Wilson wrote: Quoting Tvrtko Ursulin (2021-02-08 14:56:31) On 08/02/2021 10:52, Chris Wilson wrote: +static bool need_preempt(const struct intel_engine_cs *engine, const struct i915_request *rq) { const struct i915_sched *se = &engi

[Intel-gfx] [PATCH] drm/i915: Remove unused debug functions

2021-02-08 Thread Chris Wilson
Remove or hide unused debug functions from clang, or else it moans. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_sw_fence.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_sw_fence.c b/drivers/gpu/drm/i915/i915_sw_fence.c index

Re: [Intel-gfx] [PATCH] drm/i915/tgl+: Make sure TypeC FIA is powered up when initializing it

2021-02-08 Thread Souza, Jose
On Mon, 2021-02-08 at 17:43 +0200, Imre Deak wrote: > The TypeC FIA can be powered down if the TC-COLD power state is allowed, > so block the TC-COLD state when initializing the FIA. > > Note that this isn't needed on ICL where the FIA is never modular and > which has no generic way to block TC-CO

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/31] drm/i915/gt: Ratelimit heartbeat completion probing

2021-02-08 Thread Patchwork
== Series Details == Series: series starting with [01/31] drm/i915/gt: Ratelimit heartbeat completion probing URL : https://patchwork.freedesktop.org/series/86841/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be chec

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/31] drm/i915/gt: Ratelimit heartbeat completion probing

2021-02-08 Thread Patchwork
== Series Details == Series: series starting with [01/31] drm/i915/gt: Ratelimit heartbeat completion probing URL : https://patchwork.freedesktop.org/series/86841/ State : warning == Summary == $ dim checkpatch origin/drm-tip 206aa3c9677c drm/i915/gt: Ratelimit heartbeat completion probing 24

[Intel-gfx] [PATCH] drm/i915/tgl+: Make sure TypeC FIA is powered up when initializing it

2021-02-08 Thread Imre Deak
The TypeC FIA can be powered down if the TC-COLD power state is allowed, so block the TC-COLD state when initializing the FIA. Note that this isn't needed on ICL where the FIA is never modular and which has no generic way to block TC-COLD (except for platforms with a legacy TypeC port and on those

Re: [Intel-gfx] [PATCH 10/31] drm/i915: Fair low-latency scheduling

2021-02-08 Thread Chris Wilson
Quoting Tvrtko Ursulin (2021-02-08 14:56:31) > On 08/02/2021 10:52, Chris Wilson wrote: > > +static bool need_preempt(const struct intel_engine_cs *engine, > >const struct i915_request *rq) > > { > > const struct i915_sched *se = &engine->sched; > > - int last_pr

Re: [Intel-gfx] [PATCH 09/31] drm/i915: Replace priolist rbtree with a skiplist

2021-02-08 Thread Tvrtko Ursulin
On 08/02/2021 10:52, Chris Wilson wrote: Replace the priolist rbtree with a skiplist. The crucial difference is that walking and removing the first element of a skiplist is O(1), but O(lgN) for an rbtree, as we need to rebalance on remove. This is a hindrance for submission latency as it occurs

Re: [Intel-gfx] [PATCH 09/31] drm/i915: Replace priolist rbtree with a skiplist

2021-02-08 Thread Tvrtko Ursulin
On 08/02/2021 12:46, Chris Wilson wrote: Quoting Tvrtko Ursulin (2021-02-08 12:29:14) On 08/02/2021 10:52, Chris Wilson wrote: +static void remove_from_priolist(struct i915_sched *se, + struct i915_request *rq, + struct list_head *lis

Re: [Intel-gfx] [PATCH 10/31] drm/i915: Fair low-latency scheduling

2021-02-08 Thread Tvrtko Ursulin
On 08/02/2021 10:52, Chris Wilson wrote: The first "scheduler" was a topographical sorting of requests into priority order. The execution order was deterministic, the earliest submitted, highest priority request would be executed first. Priority inheritance ensured that inversions were kept at

Re: [Intel-gfx] [PATCH] kernel: Expose SYS_kcmp by default

2021-02-08 Thread Michel Dänzer
On 2021-02-08 2:34 p.m., Daniel Vetter wrote: On Mon, Feb 8, 2021 at 12:49 PM Michel Dänzer wrote: On 2021-02-05 9:53 p.m., Daniel Vetter wrote: On Fri, Feb 5, 2021 at 7:37 PM Kees Cook wrote: On Fri, Feb 05, 2021 at 04:37:52PM +, Chris Wilson wrote: Userspace has discovered the funct

Re: [Intel-gfx] [PATCH] kernel: Expose SYS_kcmp by default

2021-02-08 Thread Daniel Vetter
On Mon, Feb 8, 2021 at 12:49 PM Michel Dänzer wrote: > > On 2021-02-05 9:53 p.m., Daniel Vetter wrote: > > On Fri, Feb 5, 2021 at 7:37 PM Kees Cook wrote: > >> > >> On Fri, Feb 05, 2021 at 04:37:52PM +, Chris Wilson wrote: > >>> Userspace has discovered the functionality offered by SYS_kcmp a

Re: [Intel-gfx] [PATCH] drm/i915/vbt: update DP max link rate table

2021-02-08 Thread Lee, Shawn C
On Fri, Feb 05, 2021, at 8:26 p.m, Ville Syrjälä wrote: >On Mon, Feb 01, 2021 at 11:02:28PM +0800, Lee Shawn C wrote: >> According to Bspec #20124, max link rate table for DP was updated at >> BDB version 230. Max link rate can support upto UHBR. >> >> After migrate to BDB v230, the definition fo

Re: [Intel-gfx] [RFC 03/14] drm/i915/pxp: define PXP device flag and kconfig

2021-02-08 Thread Rodrigo Vivi
On Fri, Feb 05, 2021 at 06:09:14PM -0800, Daniele Ceraolo Spurio wrote: > Ahead of the PXP implementation, define the relevant define flag and > kconfig option. > > Signed-off-by: Daniele Ceraolo Spurio Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/Kconfig | 11 ++

Re: [Intel-gfx] [RFC 02/14] mei: pxp: export pavp client to me client bus

2021-02-08 Thread Rodrigo Vivi
On Fri, Feb 05, 2021 at 06:09:13PM -0800, Daniele Ceraolo Spurio wrote: > From: Vitaly Lubart > > Export PAVP client to work with i915_cp driver, s/i915_cp driver/i915's pxp iirc i915_cp was an experiment to have the pxp as a separated MFD driver. > for binding it uses kernel component framewo

Re: [Intel-gfx] [PATCH] kernel: Expose SYS_kcmp by default

2021-02-08 Thread Michel Dänzer
On 2021-02-08 12:49 p.m., Michel Dänzer wrote: On 2021-02-05 9:53 p.m., Daniel Vetter wrote: On Fri, Feb 5, 2021 at 7:37 PM Kees Cook wrote: On Fri, Feb 05, 2021 at 04:37:52PM +, Chris Wilson wrote: Userspace has discovered the functionality offered by SYS_kcmp and has started to depend

Re: [Intel-gfx] [PATCH 09/31] drm/i915: Replace priolist rbtree with a skiplist

2021-02-08 Thread Chris Wilson
Quoting Tvrtko Ursulin (2021-02-08 12:29:14) > > On 08/02/2021 10:52, Chris Wilson wrote: > > +static void remove_from_priolist(struct i915_sched *se, > > + struct i915_request *rq, > > + struct list_head *list, > > +

[Intel-gfx] linux-next: build warning after merge of the drm-misc tree

2021-02-08 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced this warning: include/drm/gpu_scheduler.h:304: warning: Function parameter or member '_score' not described in 'drm_gpu_scheduler' Introduced by commit f2f12eb9c32b ("drm/scheduler: provide scheduler score

Re: [Intel-gfx] [PATCH 09/31] drm/i915: Replace priolist rbtree with a skiplist

2021-02-08 Thread Tvrtko Ursulin
On 08/02/2021 10:52, Chris Wilson wrote: Replace the priolist rbtree with a skiplist. The crucial difference is that walking and removing the first element of a skiplist is O(1), but O(lgN) for an rbtree, as we need to rebalance on remove. This is a hindrance for submission latency as it occurs

  1   2   >