[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [01/13] drm/i915/display: move needs_modeset to an inline in header

2020-12-17 Thread Patchwork
== Series Details == Series: series starting with [01/13] drm/i915/display: move needs_modeset to an inline in header URL : https://patchwork.freedesktop.org/series/85059/ State : failure == Summary == Applying: drm/i915/display: move needs_modeset to an inline in header Applying: drm/i915/di

[Intel-gfx] [PATCH 13/13] drm/i915: move is_ccs_modifier to an inline

2020-12-17 Thread Dave Airlie
From: Dave Airlie There is no need for this to be out of line. Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/display/intel_display.c | 8 drivers/gpu/drm/i915/display/intel_display.h | 1 - drivers/gpu/drm/i915/display/intel_display_types.h | 8 3 files chan

[Intel-gfx] [PATCH 11/13] drm/i915: move pipe update code into crtc.

2020-12-17 Thread Dave Airlie
From: Dave Airlie Daniel suggested this should move here. Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_crtc.c | 230 drivers/gpu/drm/i915/display/intel_sprite.c | 228 --- 2 file

[Intel-gfx] [PATCH 12/13] drm/i915: split fb scalable checks into g4x and skl versions

2020-12-17 Thread Dave Airlie
From: Dave Airlie This just cleans these up a bit. Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sprite.c| 7 +++ drivers/gpu/drm/i915/display/skl_universal_plane.c | 4 ++-- 2 files changed, 5 insertions(+

[Intel-gfx] [PATCH 08/13] drm/i915: split fdi code out from intel_display.c

2020-12-17 Thread Dave Airlie
From: Dave Airlie This just refactors out the fdi code to a separate file. Signed-off-by: Dave Airlie [Jani: cleaned up intel_fdi.h a bit.] Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_display.c | 685 +--

[Intel-gfx] [PATCH 07/13] drm/i915: refactor pll code out into intel_dpll.c

2020-12-17 Thread Dave Airlie
From: Dave Airlie This pulls a large chunk of the pll calculation code out of intel_display.c to a new file. One function makes sense to be an inline, otherwise this is pretty much a straight copy cover. Also all the remaining hooks for g45 and older end up the same now. Signed-off-by: Dave Air

[Intel-gfx] [PATCH 09/13] drm/i915: migrate hsw fdi code to new file.

2020-12-17 Thread Dave Airlie
From: Dave Airlie Daniel asked for this, but it's a bit messy and I'm not sure how best to clean it up yet. Signed-off-by: Dave Airlie [Jani: also moved fdi buf trans to intel_fdi.c.] Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_crt.c | 1 + drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH 01/13] drm/i915/display: move needs_modeset to an inline in header

2020-12-17 Thread Dave Airlie
From: Dave Airlie This function is going to be used in a later change, so clean it up first before moving it. Reviewed-by: Ville Syrjälä Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 78 +-- .../drm/i915/display/inte

[Intel-gfx] [PATCH 05/13] drm/i915: refactor i915 plane code into separate file.

2020-12-17 Thread Dave Airlie
From: Dave Airlie Ville suggested this as a good idea, let's move this before moving the crtc code. Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/Makefile| 3 +- drivers/gpu/drm/i915/display/i9xx_plane.c| 704 +++ drivers/gpu/drm/i915/display/i9xx_pl

[Intel-gfx] [PATCH 06/13] drm/i915: refactor some crtc code out of intel display. (v2)

2020-12-17 Thread Dave Airlie
From: Dave Airlie There may be more crtc code that can be pulled out, but this is a good start. v2: move plane before this. Signed-off-by: Dave Airlie [Jani: cleaned up intel_crtc.h a bit.] Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i

[Intel-gfx] [PATCH 03/13] drm/i915/display: fix misused comma

2020-12-17 Thread Dave Airlie
From: Dave Airlie There is no need for a comma use here. Reviewed-by: Ville Syrjälä Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_

[Intel-gfx] [PATCH 02/13] drm/i915/display: move to_intel_frontbuffer to header

2020-12-17 Thread Dave Airlie
From: Dave Airlie This will be used for some refactoring in other files, so move it first. Signed-off-by: Dave Airlie Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 6 -- drivers/gpu/drm/i915/display/intel_display_types.h |

[Intel-gfx] [PATCH 04/13] drm/i915: refactor cursor code out of i915_display.c

2020-12-17 Thread Dave Airlie
From: Dave Airlie This file is a monster, let's start simple, the cursor plane code seems pretty standalone, and splits out easily enough. Reviewed-by: Ville Syrjälä Signed-off-by: Dave Airlie [Jani: cleaned up intel_cursor.h a bit.] Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefi

[Intel-gfx] [RFC v5] refactor intel display a bit more.

2020-12-17 Thread Dave Airlie
Thanks Jani for cleaning up the last bits, I started from your patches and changed things around a little. This move the i915 plane code to i9xx_plane.[ch] The later skl plane now moves to skl_universal_plane.[ch] I think I've also taken Ville's suggestsion on board for that file, and I've use --

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/rkl: Add DP vswing programming tables

2020-12-17 Thread Patchwork
== Series Details == Series: drm/i915/rkl: Add DP vswing programming tables URL : https://patchwork.freedesktop.org/series/85056/ State : success == Summary == CI Bug Log - changes from CI_DRM_9502_full -> Patchwork_19172_full Summary -

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/rkl: Add DP vswing programming tables

2020-12-17 Thread Patchwork
== Series Details == Series: drm/i915/rkl: Add DP vswing programming tables URL : https://patchwork.freedesktop.org/series/85056/ State : success == Summary == CI Bug Log - changes from CI_DRM_9502 -> Patchwork_19172 Summary --- **SU

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/rkl: Add DP vswing programming tables

2020-12-17 Thread Patchwork
== Series Details == Series: drm/i915/rkl: Add DP vswing programming tables URL : https://patchwork.freedesktop.org/series/85056/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5ff7f751e77d drm/i915/rkl: Add DP vswing programming tables -:73: WARNING:UNNECESSARY_ELSE: else is no

[Intel-gfx] [PATCH] drm/i915/rkl: Add DP vswing programming tables

2020-12-17 Thread Matt Roper
The bspec has been updated with new vswing programming for RKL DP. No data is provided for HDMI or eDP, so for now we'll continue to assume that those are the same as TGL. Bspec: 49291 Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_ddi.c | 42 ++-- 1 file c

Re: [Intel-gfx] [PATCH 1/2] i915/perf: Move gen specific OA formats to single array

2020-12-17 Thread Umesh Nerlige Ramappa
On Wed, Dec 16, 2020 at 09:25:35AM +, Tvrtko Ursulin wrote: On 15/12/2020 21:49, Umesh Nerlige Ramappa wrote: Variations in OA formats in the different gens has led to creation of several sparse arrays to store the formats. Move oa formats into a single array and add the supported range of

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/tgl: Fix REVID macros for TGL to fetch correct stepping

2020-12-17 Thread Lucas De Marchi
Both patches applied. Thanks! Jani, maybe now you can rebase your patch to get rid of the extern ? Lucas De Marchi On Wed, Dec 02, 2020 at 11:23:58PM -0800, Aditya Swarup wrote: Fix TGL REVID macros to fetch correct display/gt stepping based on SOC rev id from INTEL_REVID() macro. Previously,

Re: [Intel-gfx] [PATCH 1/2] i915/perf: Move gen specific OA formats to single array

2020-12-17 Thread Umesh Nerlige Ramappa
On Wed, Dec 16, 2020 at 10:30:24AM +0200, Lionel Landwerlin wrote: On 15/12/2020 23:49, Umesh Nerlige Ramappa wrote: Variations in OA formats in the different gens has led to creation of several sparse arrays to store the formats. Move oa formats into a single array and add the supported range

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Introduce Intel PXP component - Mesa single session (rev12)

2020-12-17 Thread Patchwork
== Series Details == Series: Introduce Intel PXP component - Mesa single session (rev12) URL : https://patchwork.freedesktop.org/series/84620/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated

[Intel-gfx] [RFC-v12 06/13] drm/i915/pxp: Enable PXP irq worker and callback stub

2020-12-17 Thread Huang, Sean Z
Create the irq worker that serves as callback handler, those callback stubs should be called while the hardware key teardown occurs. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/gt/intel_gt_irq.c | 4 + drivers/gpu/drm/i915/i915_reg.h | 3 +- drivers/gpu/drm/i915/

[Intel-gfx] [RFC-v12 11/13] drm/i915/uapi: introduce drm_i915_gem_create_ext

2020-12-17 Thread Huang, Sean Z
From: Bommu Krishnaiah Same old gem_create but with now with extensions support. This is needed to support various upcoming usecases. For now we use the extensions mechanism to support PAVP. Signed-off-by: Bommu Krishnaiah Signed-off-by: Matthew Auld Cc: Joonas Lahtinen joonas.lahti...@linux.i

[Intel-gfx] [RFC-v12 01/13] drm/i915/pxp: Introduce Intel PXP component

2020-12-17 Thread Huang, Sean Z
PXP (Protected Xe Path) is an i915 componment, available on GEN12+, that helps to establish the hardware protected session and manage the status of the alive software session, as well as its life cycle. This patch series is to allow the kernel space to create and manage a single hardware session (

[Intel-gfx] [RFC-v12 13/13] drm/i915/pxp: Add plane decryption support

2020-12-17 Thread Huang, Sean Z
From: Anshuman Gupta Add support to enable/disable PLANE_SURF Decryption Request bit. It requires only to enable plane decryption support when following condition met. 1. PAVP session is enabled. 2. Buffer object is protected. v2: - Rebased to libva_cp-drm-tip_tgl_cp tree. - Used gen fb obj user

[Intel-gfx] [RFC-v12 03/13] drm/i915/pxp: Implement funcs to create the TEE channel

2020-12-17 Thread Huang, Sean Z
Implement the funcs to create the TEE channel, so kernel can send the TEE commands directly to TEE for creating the arbitrary (defualt) session. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 3 +- drivers/gpu/drm/i915/i915_drv.c | 1 + drivers/gpu/drm/i

[Intel-gfx] [RFC-v12 12/13] drm/i915/pxp: User interface for Protected buffer

2020-12-17 Thread Huang, Sean Z
From: Bommu Krishnaiah This api allow user mode to create Protected buffer and context creation. Signed-off-by: Bommu Krishnaiah Cc: Telukuntla Sreedhar Cc: Kondapally Kalyan Cc: Gupta Anshuman Cc: Huang Sean Z --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 15 ++-- drivers/gp

[Intel-gfx] [RFC-v12 07/13] drm/i915/pxp: Destroy arb session upon teardown

2020-12-17 Thread Huang, Sean Z
Teardown is triggered when the display topology changes and no long meets the secure playback requirement, and hardware trashes all the encryption keys for display. So as a result, PXP should handle such case and terminate the type0 sessions, which including arb session Signed-off-by: Huang, Sean

[Intel-gfx] [RFC-v12 05/13] drm/i915/pxp: Func to send hardware session termination

2020-12-17 Thread Huang, Sean Z
Implement the functions to allow PXP to send a GPU command, in order to terminate the hardware session, so hardware can recycle this session slot for the next usage. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/pxp/intel_pxp_cmd.c | 159

[Intel-gfx] [RFC-v12 00/13] Introduce Intel PXP component - Mesa single session

2020-12-17 Thread Huang, Sean Z
PXP (Protected Xe Path) is an i915 component, available on GEN12+ that helps to establish the hardware protected session and manage the status of the alive software session, as well as its life cycle. This patch series is to allow the kernel space to create and manage a single hardware session (a.

[Intel-gfx] [RFC-v12 10/13] mei: pxp: export pavp client to me client bus

2020-12-17 Thread Huang, Sean Z
From: Vitaly Lubart Export PAVP client to work with i915_cp driver, for binding it uses kernel component framework. Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler --- drivers/misc/mei/Kconfig | 2 + drivers/misc/mei/Makefile | 1 + drivers/misc/mei/pxp/Kconfig | 1

[Intel-gfx] [RFC-v12 08/13] drm/i915/pxp: Enable PXP power management

2020-12-17 Thread Huang, Sean Z
During the power event S3+ sleep/resume, hardware will lose all the encryption keys for every hardware session, even though the software session state was marked as alive after resume. So to handle such case, PXP should terminate all the hardware sessions and cleanup all the software states after t

[Intel-gfx] [RFC-v12 09/13] drm/i915/pxp: Expose session state for display protection flip

2020-12-17 Thread Huang, Sean Z
Implement the intel_pxp_gem_object_status() to allow i915 display querying the current PXP session state. In the design, display should not perform protection flip on the protected buffers if there is no PXP session alive. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 9

[Intel-gfx] [RFC-v12 04/13] drm/i915/pxp: Create the arbitrary session after boot

2020-12-17 Thread Huang, Sean Z
Create the arbitrary session, with the fixed session id 0xf, after system boot, for the case that application allocates the protected buffer without establishing any protection session. Because the hardware requires at least one alive session for protected buffer creation. This arbitrary session n

[Intel-gfx] [RFC-v12 02/13] drm/i915/pxp: set KCR reg init during the boot time

2020-12-17 Thread Huang, Sean Z
Set the KCR init during the boot time, which is required by hardware, to allow us doing further protection operation such as sending commands to GPU or TEE. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/g

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v7,1/5] drm: Add function to convert rect in 16.16 fixed format to regular format

2020-12-17 Thread Patchwork
== Series Details == Series: series starting with [v7,1/5] drm: Add function to convert rect in 16.16 fixed format to regular format URL : https://patchwork.freedesktop.org/series/85049/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9500 -> Patchwork_19169 ===

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Introduce Intel PXP component - Mesa single session (rev11)

2020-12-17 Thread Patchwork
== Series Details == Series: Introduce Intel PXP component - Mesa single session (rev11) URL : https://patchwork.freedesktop.org/series/84620/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v7,1/5] drm: Add function to convert rect in 16.16 fixed format to regular format

2020-12-17 Thread Patchwork
== Series Details == Series: series starting with [v7,1/5] drm: Add function to convert rect in 16.16 fixed format to regular format URL : https://patchwork.freedesktop.org/series/85049/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, ea

[Intel-gfx] [RFC-v11 13/13] drm/i915/pxp: Add plane decryption support

2020-12-17 Thread Huang, Sean Z
From: Anshuman Gupta Add support to enable/disable PLANE_SURF Decryption Request bit. It requires only to enable plane decryption support when following condition met. 1. PAVP session is enabled. 2. Buffer object is protected. v2: - Rebased to libva_cp-drm-tip_tgl_cp tree. - Used gen fb obj user

[Intel-gfx] [RFC-v11 02/13] drm/i915/pxp: set KCR reg init during the boot time

2020-12-17 Thread Huang, Sean Z
Set the KCR init during the boot time, which is required by hardware, to allow us doing further protection operation such as sending commands to GPU or TEE. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/g

[Intel-gfx] [RFC-v11 08/13] drm/i915/pxp: Enable PXP power management

2020-12-17 Thread Huang, Sean Z
During the power event S3+ sleep/resume, hardware will lose all the encryption keys for every hardware session, even though the software session state was marked as alive after resume. So to handle such case, PXP should terminate all the hardware sessions and cleanup all the software states after t

[Intel-gfx] [RFC-v11 07/13] drm/i915/pxp: Destroy arb session upon teardown

2020-12-17 Thread Huang, Sean Z
Teardown is triggered when the display topology changes and no long meets the secure playback requirement, and hardware trashes all the encryption keys for display. So as a result, PXP should handle such case and terminate the type0 sessions, which including arb session Signed-off-by: Huang, Sean

[Intel-gfx] [RFC-v11 11/13] drm/i915/uapi: introduce drm_i915_gem_create_ext

2020-12-17 Thread Huang, Sean Z
From: Bommu Krishnaiah Same old gem_create but with now with extensions support. This is needed to support various upcoming usecases. For now we use the extensions mechanism to support PAVP. Signed-off-by: Bommu Krishnaiah Signed-off-by: Matthew Auld Cc: Joonas Lahtinen joonas.lahti...@linux.i

[Intel-gfx] [RFC-v11 06/13] drm/i915/pxp: Enable PXP irq worker and callback stub

2020-12-17 Thread Huang, Sean Z
Create the irq worker that serves as callback handler, those callback stubs should be called while the hardware key teardown occurs. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/gt/intel_gt_irq.c | 4 + drivers/gpu/drm/i915/i915_reg.h | 3 +- drivers/gpu/drm/i915/

[Intel-gfx] [RFC-v11 05/13] drm/i915/pxp: Func to send hardware session termination

2020-12-17 Thread Huang, Sean Z
Implement the functions to allow PXP to send a GPU command, in order to terminate the hardware session, so hardware can recycle this session slot for the next usage. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/pxp/intel_pxp_cmd.c | 159

[Intel-gfx] [RFC-v11 04/13] drm/i915/pxp: Create the arbitrary session after boot

2020-12-17 Thread Huang, Sean Z
Create the arbitrary session, with the fixed session id 0xf, after system boot, for the case that application allocates the protected buffer without establishing any protection session. Because the hardware requires at least one alive session for protected buffer creation. This arbitrary session n

[Intel-gfx] [RFC-v11 12/13] drm/i915/pxp: User interface for Protected buffer

2020-12-17 Thread Huang, Sean Z
From: Bommu Krishnaiah This api allow user mode to create Protected buffer and context creation. Signed-off-by: Bommu Krishnaiah Cc: Telukuntla Sreedhar Cc: Kondapally Kalyan Cc: Gupta Anshuman Cc: Huang Sean Z --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 15 ++-- drivers/gp

[Intel-gfx] [RFC-v11 03/13] drm/i915/pxp: Implement funcs to create the TEE channel

2020-12-17 Thread Huang, Sean Z
Implement the funcs to create the TEE channel, so kernel can send the TEE commands directly to TEE for creating the arbitrary (defualt) session. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 3 +- drivers/gpu/drm/i915/i915_drv.c | 1 + drivers/gpu/drm/i

[Intel-gfx] [RFC-v11 10/13] mei: pxp: export pavp client to me client bus

2020-12-17 Thread Huang, Sean Z
From: Vitaly Lubart Export PAVP client to work with i915_cp driver, for binding it uses kernel component framework. Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler --- drivers/misc/mei/Kconfig | 2 + drivers/misc/mei/Makefile | 1 + drivers/misc/mei/pxp/Kconfig | 1

[Intel-gfx] [RFC-v11 09/13] drm/i915/pxp: Expose session state for display protection flip

2020-12-17 Thread Huang, Sean Z
Implement the intel_pxp_gem_object_status() to allow i915 display querying the current PXP session state. In the design, display should not perform protection flip on the protected buffers if there is no PXP session alive. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 9

[Intel-gfx] [RFC-v11 00/13] Introduce Intel PXP component - Mesa single session

2020-12-17 Thread Huang, Sean Z
PXP (Protected Xe Path) is an i915 componment, available on GEN12+ that helps to establish the hardware protected session and manage the status of the alive software session, as well as its life cycle. This patch series is to allow the kernel space to create and manage a single hardware session (a

[Intel-gfx] [RFC-v11 01/13] drm/i915/pxp: Introduce Intel PXP component

2020-12-17 Thread Huang, Sean Z
PXP (Protected Xe Path) is an i915 componment, available on GEN12+, that helps to establish the hardware protected session and manage the status of the alive software session, as well as its life cycle. This patch series is to allow the kernel space to create and manage a single hardware session (

Re: [Intel-gfx] [PATCH v3 0/9] drm/i915: Add support for Intel's eDP backlight controls

2020-12-17 Thread Lyude Paul
Poke, can we please get some reviews on this? It's been over a week. On Fri, 2020-12-04 at 17:35 -0500, Lyude Paul wrote: > A while ago we ran into issues while trying to enable the eDP backlight > control interface as defined by VESA, in order to make the DPCD > backlight controls on newer laptop

[Intel-gfx] [PATCH v7 4/5] drm/i915/display/psr: Program plane's calculated offset to plane SF register

2020-12-17 Thread José Roberto de Souza
It programs Plane's calculated x, y, offset to Plane SF register. It does the calculation of x and y offsets using skl_calc_main_surface_offset(). v3: Update commit message Cc: Gwan-gyeong Mun Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza Reviewed-by: Gwan-gyeong Mun Tested-by: Gwan-

[Intel-gfx] [PATCH v7 5/5] HAX/DO_NOT_MERGE_IT: drm/i915/display: Enable PSR2 selective fetch for testing

2020-12-17 Thread José Roberto de Souza
Enabling it to check if it causes regressions in CI but the feature is still not ready to be enabled by default. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/d

[Intel-gfx] [PATCH v7 2/5] drm/i915/display/psr: Use plane damage clips to calculate damaged area

2020-12-17 Thread José Roberto de Souza
Now using plane damage clips property to calcualte the damaged area. Selective fetch only supports one region to be fetched so software needs to calculate a bounding box around all damage clips. Now that we are not complete fetching each plane, there is another loop needed as all the plane areas t

[Intel-gfx] [PATCH v7 3/5] drm/i915/display: Split and export main surface calculation from skl_check_main_surface()

2020-12-17 Thread José Roberto de Souza
The calculation the offsets of the main surface will be needed by PSR2 selective fetch code so here splitting and exporting it. No functional changes were done here. v3: Rebased Cc: Gwan-gyeong Mun Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza Reviewed-by: Gwan-gyeong Mun Tested-by:

[Intel-gfx] [PATCH v7 1/5] drm: Add function to convert rect in 16.16 fixed format to regular format

2020-12-17 Thread José Roberto de Souza
Much more clear to read one function call than four lines doing this conversion. v7: - function renamed - calculating width and height before truncate - inlined Cc: Ville Syrjälä Cc: dri-de...@lists.freedesktop.org Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- include/drm/drm_r

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dg1: Update voltage swing tables for DP (rev2)

2020-12-17 Thread Patchwork
== Series Details == Series: drm/i915/dg1: Update voltage swing tables for DP (rev2) URL : https://patchwork.freedesktop.org/series/84611/ State : success == Summary == CI Bug Log - changes from CI_DRM_9498_full -> Patchwork_19168_full Summ

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dg1: Update voltage swing tables for DP (rev2)

2020-12-17 Thread Patchwork
== Series Details == Series: drm/i915/dg1: Update voltage swing tables for DP (rev2) URL : https://patchwork.freedesktop.org/series/84611/ State : success == Summary == CI Bug Log - changes from CI_DRM_9498 -> Patchwork_19168 Summary --

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dg1: Update voltage swing tables for DP (rev2)

2020-12-17 Thread Patchwork
== Series Details == Series: drm/i915/dg1: Update voltage swing tables for DP (rev2) URL : https://patchwork.freedesktop.org/series/84611/ State : warning == Summary == $ dim checkpatch origin/drm-tip 22d6489958ce drm/i915/dg1: Update voltage swing tables for DP -:9: WARNING:COMMIT_LOG_LONG_LI

Re: [Intel-gfx] [PATCH] drm/i915/dg1: Update voltage swing tables for DP

2020-12-17 Thread Dhanavanthri, Swathi
The table includes both hbr2 and hbr3, so it can be renamed to reflect both. -Original Message- From: Intel-gfx On Behalf Of Lucas De Marchi Sent: Saturday, December 05, 2020 1:25 AM To: intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] [PATCH] drm/i915/dg1: Update voltage swing table

Re: [Intel-gfx] [PATCH] drm/i915/gt: Drain the breadcrumbs just once

2020-12-17 Thread Matthew Brost
On Thu, Dec 17, 2020 at 09:15:24AM +, Chris Wilson wrote: > Matthew Brost pointed out that the while-loop on a shared breadcrumb was > inherently fraught with danger as it competed with the other users of > the breadcrumbs. However, in order to completely drain the re-arming irq > worker, the w

Re: [Intel-gfx] [PATCH i-g-t v2] i915/perf_pmu: Exercise I915_PMU_SOFTWARE_GT_AWAKE_TIME

2020-12-17 Thread Tvrtko Ursulin
On 17/12/2020 17:45, Chris Wilson wrote: Measure the sample gt-awake time while each engine and every engine is busy. They should all report the same duration, the elapsed runtime of the batch. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- include/drm-uapi/i915_drm.h | 3 ++- lib/ig

[Intel-gfx] [PATCH i-g-t v2] i915/perf_pmu: Exercise I915_PMU_SOFTWARE_GT_AWAKE_TIME

2020-12-17 Thread Chris Wilson
Measure the sample gt-awake time while each engine and every engine is busy. They should all report the same duration, the elapsed runtime of the batch. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- include/drm-uapi/i915_drm.h | 3 ++- lib/igt_dummyload.c | 10 + lib/igt_d

Re: [Intel-gfx] [PATCH i-g-t] i915/perf_pmu: Exercise I915_PMU_SOFTWARE_GT_AWAKE_TIME

2020-12-17 Thread Tvrtko Ursulin
On 17/12/2020 17:39, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-12-17 17:33:05) On 17/12/2020 17:26, Chris Wilson wrote: Measure the sample gt-awake time while each engine and every engine is busy. They should all report the same duration, the elapsed runtime of the batch. Signed-off-

Re: [Intel-gfx] [PATCH i-g-t] i915/perf_pmu: Exercise I915_PMU_SOFTWARE_GT_AWAKE_TIME

2020-12-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-12-17 17:33:05) > > On 17/12/2020 17:26, Chris Wilson wrote: > > Measure the sample gt-awake time while each engine and every engine is > > busy. They should all report the same duration, the elapsed runtime of > > the batch. > > > > Signed-off-by: Chris Wilson > > C

Re: [Intel-gfx] [PATCH i-g-t] i915/perf_pmu: Exercise I915_PMU_SOFTWARE_GT_AWAKE_TIME

2020-12-17 Thread Tvrtko Ursulin
On 17/12/2020 17:26, Chris Wilson wrote: Measure the sample gt-awake time while each engine and every engine is busy. They should all report the same duration, the elapsed runtime of the batch. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- include/drm-uapi/i915_drm.h | 3 ++- tests/

[Intel-gfx] [PATCH i-g-t] i915/perf_pmu: Exercise I915_PMU_SOFTWARE_GT_AWAKE_TIME

2020-12-17 Thread Chris Wilson
Measure the sample gt-awake time while each engine and every engine is busy. They should all report the same duration, the elapsed runtime of the batch. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- include/drm-uapi/i915_drm.h | 3 ++- tests/i915/perf_pmu.c | 42

Re: [Intel-gfx] [PATCH v6 2/5] drm/i915/display/psr: Use plane damage clips to calculate damaged area

2020-12-17 Thread Mun, Gwan-gyeong
On Thu, 2020-12-17 at 05:34 -0800, Souza, Jose wrote: > On Thu, 2020-12-17 at 11:51 +, Mun, Gwan-gyeong wrote: > > On Wed, 2020-12-16 at 06:40 -0800, Souza, Jose wrote: > > > On Wed, 2020-12-16 at 14:10 +, Mun, Gwan-gyeong wrote: > > > > On Wed, 2020-12-16 at 05:17 -0800, Souza, Jose wrote:

Re: [Intel-gfx] [PATCH v6 2/5] drm/i915/display/psr: Use plane damage clips to calculate damaged area

2020-12-17 Thread Souza, Jose
On Thu, 2020-12-17 at 11:51 +, Mun, Gwan-gyeong wrote: > On Wed, 2020-12-16 at 06:40 -0800, Souza, Jose wrote: > > On Wed, 2020-12-16 at 14:10 +, Mun, Gwan-gyeong wrote: > > > On Wed, 2020-12-16 at 05:17 -0800, Souza, Jose wrote: > > > > On Wed, 2020-12-16 at 10:29 +, Mun, Gwan-gyeong w

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Drain the breadcrumbs just once

2020-12-17 Thread Patchwork
== Series Details == Series: drm/i915/gt: Drain the breadcrumbs just once URL : https://patchwork.freedesktop.org/series/85037/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9496_full -> Patchwork_19167_full Summary ---

Re: [Intel-gfx] [PATCH v7 2/5] drm/i915/display/psr: Use plane damage clips to calculate damaged area

2020-12-17 Thread Mun, Gwan-gyeong
On Wed, 2020-12-16 at 09:48 -0800, José Roberto de Souza wrote: > Now using plane damage clips property to calcualte the damaged area. > Selective fetch only supports one region to be fetched so software > needs to calculate a bounding box around all damage clips. > > Now that we are not complete

Re: [Intel-gfx] [PATCH v6 2/5] drm/i915/display/psr: Use plane damage clips to calculate damaged area

2020-12-17 Thread Mun, Gwan-gyeong
On Wed, 2020-12-16 at 06:40 -0800, Souza, Jose wrote: > On Wed, 2020-12-16 at 14:10 +, Mun, Gwan-gyeong wrote: > > On Wed, 2020-12-16 at 05:17 -0800, Souza, Jose wrote: > > > On Wed, 2020-12-16 at 10:29 +, Mun, Gwan-gyeong wrote: > > > > On Tue, 2020-12-15 at 05:14 -0800, Souza, Jose wrote:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Drain the breadcrumbs just once

2020-12-17 Thread Patchwork
== Series Details == Series: drm/i915/gt: Drain the breadcrumbs just once URL : https://patchwork.freedesktop.org/series/85037/ State : success == Summary == CI Bug Log - changes from CI_DRM_9496 -> Patchwork_19167 Summary --- **SUCC

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/perf_pmu: Replace init/read-other with a plea

2020-12-17 Thread Tvrtko Ursulin
On 16/12/2020 16:54, Chris Wilson wrote: We cannot assume we know how many PMU there are exactly, so pick -1ULL to represent all invalid metrics. Similarly, we have to rely on explicit testing for each PMU to prove their existence and correct functioning. Signed-off-by: Chris Wilson Cc: Tvrtk

[Intel-gfx] [PATCH i-g-t 3/3] intel_gpu_top: Fix interactive mode on serial console

2020-12-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin TIOCGWINSZ returns zero columns and rows on serial so lets assume 80x24. Signed-off-by: Tvrtko Ursulin --- tools/intel_gpu_top.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c index d1149eb8e14d..72ad7cbe9a8c 100644 -

[Intel-gfx] [PATCH i-g-t 2/3] intel_gpu_top: Aggregate engine busyness per class

2020-12-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Similarly to how top(1) handles SMP, we can default to showing engines of a same class as a single bar graph entry. To achieve this a little bit of hackery is employed. PMU sampling is left as is and only at the presentation layer we create a fake set of engines, one for eac

[Intel-gfx] [PATCH i-g-t 1/3] intel_gpu_top: Support exiting the tool by pressing 'q'

2020-12-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Analoguous to top(1) we can enable the user to exit from the tool by pressing 'q' on the console. v2: * Fix sleep period with closed stdin. (Chris) Signed-off-by: Tvrtko Ursulin --- man/intel_gpu_top.rst | 6 tools/intel_gpu_top.c | 80 +

[Intel-gfx] [PULL] drm-misc-next

2020-12-17 Thread Maarten Lankhorst
drm-misc-next-2020-12-17: drm-misc-next for v5.12: UAPI Changes: - Not necessarily one, but we document that userspace needs to force probe connectors. Cross-subsystem Changes: - Require FB_ATY_CT for aty on sparc64. - video: Fix documentation, and a few compiler warnings. - Add devicetree bindi

[Intel-gfx] [PATCH] drm/i915/gt: Drain the breadcrumbs just once

2020-12-17 Thread Chris Wilson
Matthew Brost pointed out that the while-loop on a shared breadcrumb was inherently fraught with danger as it competed with the other users of the breadcrumbs. However, in order to completely drain the re-arming irq worker, the while-loop is a necessity, despite my optimism that we could force canc

Re: [Intel-gfx] [PATCH v2 i-g-t 1/2] intel_gpu_top: Support exiting the tool by pressing 'q'

2020-12-17 Thread Chris Wilson
Quoting Chris Wilson (2020-12-16 15:57:53) > Quoting Tvrtko Ursulin (2020-12-16 15:54:20) > > From: Tvrtko Ursulin > > > > Analoguous to top(1) we can enable the user to exit from the tool by > > pressing 'q' on the console. > > > > v2: > > * Fix sleep period with closed stdin. (Chris) > > > >