[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/2] drm/i915/gt: Replace direct submit with direct call to tasklet

2020-11-30 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/gt: Replace direct submit with direct call to tasklet URL : https://patchwork.freedesktop.org/series/84433/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit w

[Intel-gfx] [CI 2/2] drm/i915/gt: ce->inflight updates are now serialised

2020-11-30 Thread Chris Wilson
Since schedule-in and schedule-out are now both always under the tasklet bitlock, we can reduce the individual atomic operations to simple instructions and worry less. This notably eliminates the race observed with intel_context_inflight in __engine_unpark(). Closes: https://gitlab.freedesktop.or

[Intel-gfx] [CI 1/2] drm/i915/gt: Replace direct submit with direct call to tasklet

2020-11-30 Thread Chris Wilson
Rather than having special case code for opportunistically calling process_csb() and performing a direct submit while holding the engine spinlock for submitting the request, simply call the tasklet directly. This allows us to retain the direct submission path, including the CS draining to allow fas

Re: [Intel-gfx] [PATCH] Revert "drm/i915: re-order if/else ladder for hpd_irq_setup"

2020-11-30 Thread Lucas De Marchi
On Mon, Nov 30, 2020 at 07:46:39PM +0200, Ville Syrjälä wrote: On Mon, Nov 30, 2020 at 09:31:04AM -0800, Lucas De Marchi wrote: On Mon, Nov 30, 2020 at 04:19:54PM +0200, Ville Syrjälä wrote: >On Fri, Nov 27, 2020 at 08:52:29PM -0800, Lucas De Marchi wrote: >> On Fri, Nov 27, 2020 at 02:57:48PM +

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add the missing wakeref tracking for display power references

2020-11-30 Thread Patchwork
== Series Details == Series: drm/i915: Add the missing wakeref tracking for display power references URL : https://patchwork.freedesktop.org/series/84418/ State : success == Summary == CI Bug Log - changes from CI_DRM_9411 -> Patchwork_19020

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add the missing wakeref tracking for display power references

2020-11-30 Thread Patchwork
== Series Details == Series: drm/i915: Add the missing wakeref tracking for display power references URL : https://patchwork.freedesktop.org/series/84418/ State : warning == Summary == $ dim checkpatch origin/drm-tip 166a87e7d161 drm/i915: Use CRTC index consistently during getting/putting CRT

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: refactor panel backlight control functions. (rev2)

2020-11-30 Thread Patchwork
== Series Details == Series: drm/i915: refactor panel backlight control functions. (rev2) URL : https://patchwork.freedesktop.org/series/84282/ State : success == Summary == CI Bug Log - changes from CI_DRM_9411 -> Patchwork_19019 Summary -

Re: [Intel-gfx] [RFC v2 3/8] drm/i915: Keep track of pwm-related backlight hooks separately

2020-11-30 Thread Lyude Paul
On Thu, 2020-11-26 at 13:57 +0200, Jani Nikula wrote: > On Thu, 26 Nov 2020, Dave Airlie wrote: > > On Thu, 17 Sept 2020 at 03:19, Lyude Paul wrote: > > > > > > Currently, every different type of backlight hook that i915 supports is > > > pretty straight forward - you have a backlight, probably

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable HDR on MCA LSPCON based Gen9 devices (rev15)

2020-11-30 Thread Patchwork
== Series Details == Series: Enable HDR on MCA LSPCON based Gen9 devices (rev15) URL : https://patchwork.freedesktop.org/series/68081/ State : success == Summary == CI Bug Log - changes from CI_DRM_9410 -> Patchwork_19018 Summary ---

Re: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color

2020-11-30 Thread Chery, Nanley G
> -Original Message- > From: Imre Deak > Sent: Friday, November 27, 2020 10:06 AM > To: Daniel Vetter ; Chery, Nanley G > > Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani ; > Daniel > Vetter ; Rafael Antognolli > ; Kondapally, Kalyan > ; Pandiyan, Dhinakaran > ; dri-de...@lists.fre

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable HDR on MCA LSPCON based Gen9 devices (rev15)

2020-11-30 Thread Patchwork
== Series Details == Series: Enable HDR on MCA LSPCON based Gen9 devices (rev15) URL : https://patchwork.freedesktop.org/series/68081/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable HDR on MCA LSPCON based Gen9 devices (rev15)

2020-11-30 Thread Patchwork
== Series Details == Series: Enable HDR on MCA LSPCON based Gen9 devices (rev15) URL : https://patchwork.freedesktop.org/series/68081/ State : warning == Summary == $ dim checkpatch origin/drm-tip de078fd83295 drm/i915/display: Add HDR Capability detection for LSPCON 8a7c6f1ebb7f drm/i915/disp

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/selftest: also consider non-contiguous objects

2020-11-30 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftest: also consider non-contiguous objects URL : https://patchwork.freedesktop.org/series/84409/ State : success == Summary == CI Bug Log - changes from CI_DRM_9410 -> Patchwork_19017

Re: [Intel-gfx] [PATCH 4/9] drm/i915/ddi: Track power reference taken for encoder DDI IO use

2020-11-30 Thread Imre Deak
On Tue, Dec 01, 2020 at 12:07:21AM +0200, Imre Deak wrote: > On Mon, Nov 30, 2020 at 10:00:33PM +, Chris Wilson wrote: > > Quoting Imre Deak (2020-11-30 21:21:55) > > > Add wakeref tracking for the DDI encoders' DDI_IO display power domain > > > references. > > > > > > Cc: Chris Wilson > > >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/selftest: also consider non-contiguous objects

2020-11-30 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftest: also consider non-contiguous objects URL : https://patchwork.freedesktop.org/series/84409/ State : warning == Summary == $ dim checkpatch origin/drm-tip f3f2229082f8 drm/i915/selftest: assert we get 2M GTT pages -:11:

Re: [Intel-gfx] [RFC v2 3/8] drm/i915: Keep track of pwm-related backlight hooks separately

2020-11-30 Thread Lyude Paul
On Thu, 2020-11-26 at 11:03 +1000, Dave Airlie wrote: > On Thu, 17 Sept 2020 at 03:19, Lyude Paul wrote: > > > > Currently, every different type of backlight hook that i915 supports is > > pretty straight forward - you have a backlight, probably through PWM > > (but maybe DPCD), with a single set

Re: [Intel-gfx] [RFC v2 1/8] drm/i915/dp: Program source OUI on eDP panels

2020-11-30 Thread Lyude Paul
On Thu, 2020-11-26 at 12:51 +0200, Jani Nikula wrote: > On Wed, 16 Sep 2020, Lyude Paul wrote: > > Since we're about to start adding support for Intel's magic HDR > > backlight interface over DPCD, we need to ensure we're properly > > programming this field so that Intel specific sink services are

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Track logically enabled planes for hw state

2020-11-30 Thread Navare, Manasi
On Tue, Nov 24, 2020 at 10:11:53PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently crtc_state->uapi.plane_mask only tracks logically > enabled planes on the uapi level. For bigjoiner purposes > we want to do the same for the hw state. Let's follow the > pattern established by acti

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Add intel_atomic_add_affected_planes()

2020-11-30 Thread Navare, Manasi
On Tue, Nov 24, 2020 at 10:11:54PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > drm_atomic_add_affected_planes() only considers planes which > are logically enabled in the uapi state. For bigjoiner we need > to consider planes logically enabled in the hw state. Add a > helper for that. >

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Call kill_bigjoiner_slave() earlier

2020-11-30 Thread Navare, Manasi
On Tue, Nov 24, 2020 at 10:11:56PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Let's do the kill_bigjoiner_slave() thing from > intel_bigjoiner_add_affected_crtcs() since it's related to > what we do there. This cleans up the logic in the > compute_config() loop a bit. > > Signed-off-b

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Make intel_display_power_put_unchecked() an internal-only function

2020-11-30 Thread Imre Deak
On Mon, Nov 30, 2020 at 10:07:01PM +, Chris Wilson wrote: > Quoting Imre Deak (2020-11-30 21:22:00) > > All the display power domain references are wakeref tracked now, so we > > can mark intel_display_power_put_unchecked() as an internal function > > (for suppressing wakeref tracking in non-de

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Properly flag modesets for all bigjoiner pipes

2020-11-30 Thread Navare, Manasi
On Tue, Nov 24, 2020 at 10:11:55PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > If either of the bigjoiner pipes needs a modeset then we need > a modeset on both pipes. Make it so. > > v2: Split out the kill_bigjoiner_slave() change (Manasi) > Add affected connectors/planes > > Sig

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/lmem: Limit block size to 4G (rev3)

2020-11-30 Thread Patchwork
== Series Details == Series: drm/i915/lmem: Limit block size to 4G (rev3) URL : https://patchwork.freedesktop.org/series/84405/ State : success == Summary == CI Bug Log - changes from CI_DRM_9409 -> Patchwork_19016 Summary --- **SUCC

Re: [Intel-gfx] [PATCH 4/9] drm/i915/ddi: Track power reference taken for encoder DDI IO use

2020-11-30 Thread Imre Deak
On Mon, Nov 30, 2020 at 10:00:33PM +, Chris Wilson wrote: > Quoting Imre Deak (2020-11-30 21:21:55) > > Add wakeref tracking for the DDI encoders' DDI_IO display power domain > > references. > > > > Cc: Chris Wilson > > Signed-off-by: Imre Deak > > --- > > drivers/gpu/drm/i915/display/intel

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Make intel_display_power_put_unchecked() an internal-only function

2020-11-30 Thread Chris Wilson
Quoting Imre Deak (2020-11-30 21:22:00) > All the display power domain references are wakeref tracked now, so we > can mark intel_display_power_put_unchecked() as an internal function > (for suppressing wakeref tracking in non-debug builds). > > Cc: Chris Wilson > Signed-off-by: Imre Deak Ok, a

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Rename power_domains.wakeref to init_wakeref

2020-11-30 Thread Chris Wilson
Quoting Imre Deak (2020-11-30 21:21:58) > Rename power_domains.wakeref to power_domains.init_wakeref to make the > use of this reference clearer. The next patch adds tracking for another > power reference user of the power_domains functionality. > > While at it add a missing zero wakeref assert wh

Re: [Intel-gfx] [PATCH 4/9] drm/i915/ddi: Track power reference taken for encoder DDI IO use

2020-11-30 Thread Chris Wilson
Quoting Imre Deak (2020-11-30 21:21:55) > Add wakeref tracking for the DDI encoders' DDI_IO display power domain > references. > > Cc: Chris Wilson > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 38 --- > .../drm/i915/display/intel_display_typ

Re: [Intel-gfx] [PATCH 3/9] drm/i915: Track power references taken for enabled CRTCs

2020-11-30 Thread Chris Wilson
Quoting Imre Deak (2020-11-30 21:21:54) > Add wakeref tracking for display power domain references taken for > enabled CRTCs. > > Cc: Chris Wilson > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/i915/display/intel_display.c | 38 --- > .../drm/i915/display/intel_display_type

Re: [Intel-gfx] [PATCH 1/9] drm/i915: Use CRTC index consistently during getting/putting CRTC power domains

2020-11-30 Thread Chris Wilson
Quoting Imre Deak (2020-11-30 21:21:52) > The for_each_oldnew_intel_crtc_in_state() iterator index does match > crtc->pipe, but using the same thing as array index when getting and > putting CRTC power domains makes things clearer. > > Cc: Chris Wilson > Signed-off-by: Imre Deak crtc->pipe appe

Re: [Intel-gfx] [PATCH 2/9] drm/i915: Factor out helpers to get/put a set of tracked power domains

2020-11-30 Thread Chris Wilson
Quoting Imre Deak (2020-11-30 21:21:53) > Factor out helper functions to get/put a set of power domains that are > tracked using their wakeref handles. The same is needed by the next > patch adding tracking for enabled CRTC power domains. > > Cc: Chris Wilson > Signed-off-by: Imre Deak Reviewed

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/5] drm/i915/gt: Add an insert_entry for gen8_ppgtt

2020-11-30 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/gt: Add an insert_entry for gen8_ppgtt URL : https://patchwork.freedesktop.org/series/84406/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9409 -> Patchwork_19015

[Intel-gfx] [PATCH 8/9] drm/i915: Track power reference taken to disable power well functionality

2020-11-30 Thread Imre Deak
Add wakeref tracking for the display power domain reference taken to keep the display power well functionality disabled. Cc: Chris Wilson Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_display_power.c | 13 + drivers/gpu/drm/i915/display/intel_display_power.h | 1 +

[Intel-gfx] [PATCH 7/9] drm/i915: Rename power_domains.wakeref to init_wakeref

2020-11-30 Thread Imre Deak
Rename power_domains.wakeref to power_domains.init_wakeref to make the use of this reference clearer. The next patch adds tracking for another power reference user of the power_domains functionality. While at it add a missing zero wakeref assert when setting the wakeref. Cc: Chris Wilson Signed-

[Intel-gfx] [PATCH 5/9] drm/i915/ddi: Track power reference taken for encoder main lane AUX use

2020-11-30 Thread Imre Deak
Add wakeref tracking for the DDI encoders' main lane AUX display power domain references. Cc: Chris Wilson Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_ddi.c | 23 --- .../drm/i915/display/intel_display_types.h| 1 + 2 files changed, 16 insertions(+)

[Intel-gfx] [PATCH 2/9] drm/i915: Factor out helpers to get/put a set of tracked power domains

2020-11-30 Thread Imre Deak
Factor out helper functions to get/put a set of power domains that are tracked using their wakeref handles. The same is needed by the next patch adding tracking for enabled CRTC power domains. Cc: Chris Wilson Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_display.c | 62 +

[Intel-gfx] [PATCH 4/9] drm/i915/ddi: Track power reference taken for encoder DDI IO use

2020-11-30 Thread Imre Deak
Add wakeref tracking for the DDI encoders' DDI_IO display power domain references. Cc: Chris Wilson Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_ddi.c | 38 --- .../drm/i915/display/intel_display_types.h| 1 + 2 files changed, 25 insertions(+), 14 de

[Intel-gfx] [PATCH 1/9] drm/i915: Use CRTC index consistently during getting/putting CRTC power domains

2020-11-30 Thread Imre Deak
The for_each_oldnew_intel_crtc_in_state() iterator index does match crtc->pipe, but using the same thing as array index when getting and putting CRTC power domains makes things clearer. Cc: Chris Wilson Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- 1 file c

[Intel-gfx] [PATCH 9/9] drm/i915: Make intel_display_power_put_unchecked() an internal-only function

2020-11-30 Thread Imre Deak
All the display power domain references are wakeref tracked now, so we can mark intel_display_power_put_unchecked() as an internal function (for suppressing wakeref tracking in non-debug builds). Cc: Chris Wilson Signed-off-by: Imre Deak --- .../drm/i915/display/intel_display_power.c| 40 ++

[Intel-gfx] [PATCH 6/9] drm/i915: Track power reference taken for eDP VDD

2020-11-30 Thread Imre Deak
Add wakeref tracking for the eDP encoders' AUX display power domain references taken while the panel's VDD is enabled. Cc: Chris Wilson Signed-off-by: Imre Deak --- .../gpu/drm/i915/display/intel_display_types.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c| 18 -- 2 f

[Intel-gfx] [PATCH 0/9] drm/i915: Add the missing wakeref tracking for display power references

2020-11-30 Thread Imre Deak
Add wakeref tracking for display power domain references where this was still missing. Cc: Chris Wilson Imre Deak (9): drm/i915: Make atomic commit get/put power domains symmetric drm/i915: Factor out helpers to get/put a set of tracked power domains drm/i915: Track power references taken

[Intel-gfx] [PATCH 3/9] drm/i915: Track power references taken for enabled CRTCs

2020-11-30 Thread Imre Deak
Add wakeref tracking for display power domain references taken for enabled CRTCs. Cc: Chris Wilson Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_display.c | 38 --- .../drm/i915/display/intel_display_types.h| 2 +- 2 files changed, 17 insertions(+), 23 de

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/5] drm/i915/gt: Add an insert_entry for gen8_ppgtt

2020-11-30 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/gt: Add an insert_entry for gen8_ppgtt URL : https://patchwork.freedesktop.org/series/84406/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked se

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915/gt: Add an insert_entry for gen8_ppgtt

2020-11-30 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/gt: Add an insert_entry for gen8_ppgtt URL : https://patchwork.freedesktop.org/series/84406/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1c46e6988161 drm/i915/gt: Add an insert_entry for gen8_ppgtt 9faed65cd732

[Intel-gfx] [PATCH] drm/i915: refactor panel backlight control functions. (v2)

2020-11-30 Thread Dave Airlie
From: Dave Airlie This moves the functions into static const instead of having funcs and data in the same struct. It leaves the power callback alone, as it is used in a different manner. v2: leave power callback alone (Jani) Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie --- .../drm/i9

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/psr: Calculate selective fetch plane registers

2020-11-30 Thread Patchwork
== Series Details == Series: drm/i915/display/psr: Calculate selective fetch plane registers URL : https://patchwork.freedesktop.org/series/84404/ State : success == Summary == CI Bug Log - changes from CI_DRM_9409 -> Patchwork_19014 Summar

Re: [Intel-gfx] [PATCH 14/15] drm/vmwgfx: Remove references to struct drm_device.pdev

2020-11-30 Thread Zack Rusin
> On Nov 24, 2020, at 06:38, Thomas Zimmermann wrote: > > Using struct drm_device.pdev is deprecated. Convert vmwgfx to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Roland Scheidegger > --- > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c | 8

Re: [Intel-gfx] [v13 08/15] drm/i915/display: Enable colorspace programming for LSPCON devices

2020-11-30 Thread Shankar, Uma
> -Original Message- > From: Ville Syrjälä > Sent: Tuesday, December 1, 2020 1:21 AM > To: Shankar, Uma > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [v13 08/15] drm/i915/display: Enable colorspace programming for > LSPCON devices > > On Fri, Nov 27, 2020 at 07:58:20PM +0530, U

[Intel-gfx] [v14 15/15] drm/i915/display: [NOT FOR MERGE] Reduce blanking to support 4k60@10bpp for LSPCON

2020-11-30 Thread Uma Shankar
Blanking needs to be reduced to incorporate DP and HDMI timing/link bandwidth limitations for CEA modes (4k@60 at 10 bpp). DP can drive 17.28Gbs while 4k modes (VIC97 etc) at 10 bpp required 17.8 Gbps. This will cause mode to blank out. Reduced Htotal by shortening the back porch and front porch wi

[Intel-gfx] [v14 12/15] drm/i915/display: Implement infoframes readback for LSPCON

2020-11-30 Thread Uma Shankar
Implemented Infoframes enabled readback for LSPCON devices. This will help align the implementation with state readback infrastructure. v2: Added proper bitmask of enabled infoframes as per Ville's recommendation. v3: Added pcon specific infoframe types instead of using the HSW one's, as recommen

[Intel-gfx] [v14 13/15] drm/i915/display: Implement DRM infoframe read for LSPCON

2020-11-30 Thread Uma Shankar
Implement Read back of HDR metadata infoframes i.e Dynamic Range and Mastering Infoframe for LSPCON devices. v2: Added proper bitmask of enabled infoframes as per Ville's recommendation. v3: Dropped a redundant wrapper as per Ville's comment. v4: Dropped a redundant print, added Ville's RB. Sig

[Intel-gfx] [v14 14/15] drm/i915/lspcon: Do not send DRM infoframes to non-HDMI sinks

2020-11-30 Thread Uma Shankar
Non-HDMI sinks shouldn't be sent Dynamic Range and Mastering infoframes. Check for that when using LSPCON. v2: Addressed Ville's review comment. Signed-off-by: Uma Shankar Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 6 +- 1 file changed, 5 insertions(+), 1 del

[Intel-gfx] [v14 11/15] drm/i915/lspcon: Create separate infoframe_enabled helper

2020-11-30 Thread Uma Shankar
Lspcon has Infoframes as well as DIP for HDR metadata(DRM Infoframe). Create a separate mechanism for lspcon compared to HDMI in order to address the same and ensure future scalability. v2: Streamlined this as per Ville's suggestions, making sure that HDMI infoframe versions are directly returned

[Intel-gfx] [v14 08/15] drm/i915/display: Enable colorspace programming for LSPCON devices

2020-11-30 Thread Uma Shankar
Enable HDMI Colorspace for LSPCON based devices. Sending Colorimetry data for HDR using AVI infoframe. LSPCON firmware expects this and though SOC drives DP, for HDMI panel AVI infoframe is sent to the LSPCON device which transfers the same to HDMI sink. v2: Dropped state managed in drm core as pe

[Intel-gfx] [v14 07/15] drm/i915: Split intel_attach_colorspace_property() into HDMI vs. DP variants

2020-11-30 Thread Uma Shankar
From: Ville Syrjälä With LSPCON we use the AVI infoframe to convey the colorimetry information (as opposed to DP MSA/SDP), so the property we expose should match the values we can stuff into the infoframe. Ie. we must use the HDMI variant of the property, even though we drive LSPCON in PCON mode.

[Intel-gfx] [v14 10/15] drm/i915/display: Enable HDR for Parade based lspcon

2020-11-30 Thread Uma Shankar
Enable HDR for LSPCON based on Parade along with MCA. v2: Added a helper for status reg as suggested by Ville. v3: Removed a redundant variable, added Ville's RB. Signed-off-by: Uma Shankar Signed-off-by: Vipin Anand Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_lspcon.c

[Intel-gfx] [v14 06/15] drm/i915/display: Attach content type property for LSPCON

2020-11-30 Thread Uma Shankar
Content type is supported on HDMI sink devices. Attached the property for the same for LSPCON based devices. v2: Added the content type programming when we are attaching the property to connector, as suggested by Ville. v3: Need to attach content type on intel_dp_add_properties as creating of new

[Intel-gfx] [v14 09/15] drm/i915/display: Nuke bogus lspcon check

2020-11-30 Thread Uma Shankar
Dropped a irrelevant lspcon check from intel_hdmi_add_properties function. Suggested-by: Ville Syrjälä Signed-off-by: Uma Shankar Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_hdmi.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/gpu

[Intel-gfx] [v14 05/15] drm/i915/display: Add a WARN for invalid output range and format

2020-11-30 Thread Uma Shankar
Add a WARN to rule out an invalid output range and format combination. This is to align the lspcon code with compute_avi_infoframes. Signed-off-by: Uma Shankar Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_lspcon.c | 4 1 file changed, 4 insertions(+) diff --git a/driv

[Intel-gfx] [v14 04/15] drm/i915/display: Fixes quantization range for YCbCr output

2020-11-30 Thread Uma Shankar
This patch fixes the quantization range for YCbCr output on Lspcon based devices. v2: Re-phrased the description and added Ville's Rb. Signed-off-by: Uma Shankar Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_lspcon.c | 17 +++-- 1 file changed, 11 insertions(+),

[Intel-gfx] [v14 03/15] drm/i915/display: Attach HDR property for capable Gen9 devices

2020-11-30 Thread Uma Shankar
Attach HDR property for Gen9 devices with MCA LSPCON chips. v2: Cleaned HDR property attachment logic based on capability as per Jani Nikula's suggestion. v3: Fixed the HDR property attachment logic as per the new changes by Kai-Feng to align with lspcon detection failure on some devices. v4: Ad

[Intel-gfx] [v14 01/15] drm/i915/display: Add HDR Capability detection for LSPCON

2020-11-30 Thread Uma Shankar
LSPCON firmware exposes HDR capability through LPCON_CAPABILITIES DPCD register. LSPCON implementations capable of supporting HDR set HDR_CAPABILITY bit in LSPCON_CAPABILITIES to 1. This patch reads the same, detects the HDR capability and adds this to intel_lspcon struct. v2: Addressed Jani Nikul

[Intel-gfx] [v14 02/15] drm/i915/display: Enable HDR on gen9 devices with MCA Lspcon

2020-11-30 Thread Uma Shankar
Gen9 hardware supports HDMI2.0 through LSPCON chips. Extending HDR support for MCA LSPCON based GEN9 devices. SOC will drive LSPCON as DP and send HDR metadata as standard DP SDP packets. LSPCON will be set to operate in PCON mode, will receive the metadata and create Dynamic Range and Mastering I

[Intel-gfx] [v14 00/15] Enable HDR on MCA LSPCON based Gen9 devices

2020-11-30 Thread Uma Shankar
Gen9 hardware supports HDMI2.0 through LSPCON chips. Extending HDR support for MCA and Parade LSPCON based GEN9 devices. SOC will drive LSPCON as DP and send HDR metadata as standard DP SDP packets. LSPCON will be set to operate in PCON mode, will receive the metadata and create Dynamic Range and

Re: [Intel-gfx] [PATCH] drm/i915/perf: also include Gen11 in OATAILPTR workaround

2020-11-30 Thread Umesh Nerlige Ramappa
On Thu, Nov 26, 2020 at 12:51:55PM +0200, Lionel Landwerlin wrote: CI shows this workaround is also needed on Gen11. Signed-off-by: Lionel Landwerlin Considering this failed on gen11, this is Reviewed-by: Umesh Nerlige Ramappa Thanks, Umesh Fixes: 059a0beb486344 ("drm/i915/perf: workaro

Re: [Intel-gfx] [v13 08/15] drm/i915/display: Enable colorspace programming for LSPCON devices

2020-11-30 Thread Ville Syrjälä
On Fri, Nov 27, 2020 at 07:58:20PM +0530, Uma Shankar wrote: > Enable HDMI Colorspace for LSPCON based devices. Sending Colorimetry > data for HDR using AVI infoframe. LSPCON firmware expects this and though > SOC drives DP, for HDMI panel AVI infoframe is sent to the LSPCON device > which transfer

Re: [Intel-gfx] linux firmware PR for i915 GuC v49.0.1

2020-11-30 Thread John Harrison
On 11/30/2020 11:09, Josh Boyer wrote: On Mon, Nov 30, 2020 at 1:49 PM John Harrison wrote: On 11/30/2020 06:26, Josh Boyer wrote: On Tue, Nov 24, 2020 at 8:42 PM wrote: Hi Josh, Kyle, Ben, Kindly add the below i915 changes to linux-firmware.git: The following changes since commit b362fd4

Re: [Intel-gfx] linux firmware PR for i915 GuC v49.0.1

2020-11-30 Thread Josh Boyer
On Mon, Nov 30, 2020 at 1:49 PM John Harrison wrote: > > On 11/30/2020 06:26, Josh Boyer wrote: > > On Tue, Nov 24, 2020 at 8:42 PM wrote: > >> Hi Josh, Kyle, Ben, > >> > >> Kindly add the below i915 changes to linux-firmware.git: > >> > >> > >> The following changes since commit > >> b362fd4cb8

Re: [Intel-gfx] linux firmware PR for i915 GuC v49.0.1

2020-11-30 Thread John Harrison
On 11/30/2020 06:26, Josh Boyer wrote: On Tue, Nov 24, 2020 at 8:42 PM wrote: Hi Josh, Kyle, Ben, Kindly add the below i915 changes to linux-firmware.git: The following changes since commit b362fd4cb8963ad75517dbcf424974f65a29a60e: Mellanox: Add new mlxsw_spectrum firmware xx.2008.2018 (

Re: [Intel-gfx] [PATCH] Revert "drm/i915: re-order if/else ladder for hpd_irq_setup"

2020-11-30 Thread Ville Syrjälä
On Mon, Nov 30, 2020 at 09:31:04AM -0800, Lucas De Marchi wrote: > On Mon, Nov 30, 2020 at 04:19:54PM +0200, Ville Syrjälä wrote: > >On Fri, Nov 27, 2020 at 08:52:29PM -0800, Lucas De Marchi wrote: > >> On Fri, Nov 27, 2020 at 02:57:48PM +, Chris Wilson wrote: > >> >We now use ilk_hpd_irq_setup

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/rkl: Remove require_force_probe protection

2020-11-30 Thread Patchwork
== Series Details == Series: drm/i915/rkl: Remove require_force_probe protection URL : https://patchwork.freedesktop.org/series/84403/ State : success == Summary == CI Bug Log - changes from CI_DRM_9405 -> Patchwork_19013 Summary ---

Re: [Intel-gfx] [RFC PATCH 124/162] drm/i915/lmem: allocate HWSP in lmem

2020-11-30 Thread Chris Wilson
Quoting Matthew Auld (2020-11-30 17:17:16) > On 27/11/2020 13:55, Chris Wilson wrote: > > Quoting Matthew Auld (2020-11-27 12:06:40) > >> From: Michel Thierry > > > > Rationale goes here. > > > > Is this wise? HWSP is very frequently read by the CPU, and expected to > > be cached on the CPU. > >

Re: [Intel-gfx] [PATCH] Revert "drm/i915: re-order if/else ladder for hpd_irq_setup"

2020-11-30 Thread Lucas De Marchi
On Mon, Nov 30, 2020 at 04:19:54PM +0200, Ville Syrjälä wrote: On Fri, Nov 27, 2020 at 08:52:29PM -0800, Lucas De Marchi wrote: On Fri, Nov 27, 2020 at 02:57:48PM +, Chris Wilson wrote: >We now use ilk_hpd_irq_setup for all GMCH platforms that do not have >hotplug. These are early gen3 and g

Re: [Intel-gfx] [RFC PATCH 124/162] drm/i915/lmem: allocate HWSP in lmem

2020-11-30 Thread Matthew Auld
On 27/11/2020 13:55, Chris Wilson wrote: Quoting Matthew Auld (2020-11-27 12:06:40) From: Michel Thierry Rationale goes here. Is this wise? HWSP is very frequently read by the CPU, and expected to be cached on the CPU. What do the performance profiles indicate? Do you have a recommendatio

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3,01/10] drm/i915/debugfs: remove RPS autotuning details from i915_rps_boost_info

2020-11-30 Thread Patchwork
== Series Details == Series: series starting with [v3,01/10] drm/i915/debugfs: remove RPS autotuning details from i915_rps_boost_info URL : https://patchwork.freedesktop.org/series/84398/ State : success == Summary == CI Bug Log - changes from CI_DRM_9405 -> Patchwork_19012 ==

Re: [Intel-gfx] [RFC 4/4] drm/i915/gt: Pipelined page migration

2020-11-30 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-11-30 16:26:44) > > On 30/11/2020 16:21, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-11-30 16:07:44) > >> > >> On 30/11/2020 13:39, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2020-11-30 13:12:55) > On 28/11/2020 18:40, Chris Wilson wrote: > > I

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,01/10] drm/i915/debugfs: remove RPS autotuning details from i915_rps_boost_info

2020-11-30 Thread Patchwork
== Series Details == Series: series starting with [v3,01/10] drm/i915/debugfs: remove RPS autotuning details from i915_rps_boost_info URL : https://patchwork.freedesktop.org/series/84398/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2ee541f7b576 drm/i915/debugfs: remove RPS a

Re: [Intel-gfx] [RFC 2/2] drm/i915/display: Protect pipe_update against dc3co exit

2020-11-30 Thread Anshuman Gupta
On 2020-11-30 at 17:28:32 +0200, Imre Deak wrote: > On Mon, Nov 30, 2020 at 02:46:46PM +0530, Anshuman Gupta wrote: > > At usual case DC3CO exit happen automatically by DMC f/w whenever > > PSR2 clears idle. This happens smoothly by DMC f/w to work with flips. > > But there are certain scenario whe

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: avoid useless use of inline

2020-11-30 Thread Patchwork
== Series Details == Series: drm/i915/gvt: avoid useless use of inline URL : https://patchwork.freedesktop.org/series/84397/ State : success == Summary == CI Bug Log - changes from CI_DRM_9405 -> Patchwork_19011 Summary --- **SUCCESS

Re: [Intel-gfx] [RFC 4/4] drm/i915/gt: Pipelined page migration

2020-11-30 Thread Tvrtko Ursulin
On 30/11/2020 16:21, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-11-30 16:07:44) On 30/11/2020 13:39, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-11-30 13:12:55) On 28/11/2020 18:40, Chris Wilson wrote: If we pipeline the PTE updates and then do the copy of those pages within a si

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_request_retire: Switch from random blitter loads to dummy

2020-11-30 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-11-30 16:20:18) > > On 30/11/2020 10:36, Chris Wilson wrote: > > Use the spinners to provide exactly the right amount of background > > busyness. > > > > Signed-off-by: Chris Wilson > > Cc: Tvrtko Ursulin > > --- > > lib/igt_dummyload.c | 23 ++--- > >

Re: [Intel-gfx] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-30 Thread Miguel Ojeda
On Wed, Nov 25, 2020 at 11:44 PM Edward Cree wrote: > > To make the intent clear, you have to first be certain that you > understand the intent; otherwise by adding either a break or a > fallthrough to suppress the warning you are just destroying the > information that "the intent of this code

Re: [Intel-gfx] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-30 Thread Edward Cree
On 25/11/2020 00:32, Miguel Ojeda wrote: > I have said *authoring* lines of *this* kind takes a minute per line. > Specifically: lines fixing the fallthrough warning mechanically and > repeatedly where the compiler tells you to, and doing so full-time for > a month. > It is useful since it makes i

Re: [Intel-gfx] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-30 Thread Miguel Ojeda
On Thu, Nov 26, 2020 at 4:28 PM Geert Uytterhoeven wrote: > > The maintainer is not necessarily the owner/author of the code, and > thus may not know the intent of the code. Agreed, I was not blaming maintainers -- just trying to point out that the problem is there :-) In those cases, it is stil

Re: [Intel-gfx] [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-30 Thread Finn Thain
On Wed, 25 Nov 2020, Nick Desaulniers wrote: > So developers and distributions using Clang can't have > -Wimplicit-fallthrough enabled because GCC is less strict (which has > been shown in this thread to lead to bugs)? We'd like to have nice > things too, you know. > Apparently the GCC devel

Re: [Intel-gfx] [PATCH] drm/ttm: don't set page->mapping

2020-11-30 Thread Christoph Hellwig
On Wed, Nov 25, 2020 at 07:57:20PM -0400, Jason Gunthorpe wrote: > annotate is OK, I used that for a long time.. > > My main gripe was it didn't setup the to/cc until after the annotate > editor closes. I put the To/Cc into the cover letter text file. _

Re: [Intel-gfx] [PATCH] drm/ttm: don't set page->mapping

2020-11-30 Thread Christoph Hellwig
On Wed, Nov 25, 2020 at 02:06:06PM -0400, Jason Gunthorpe wrote: > It uses a empty 'cover-letter' commit and automatically transforms it > into exactly the right stuff. Keeps track of everything you send in > git, and there is a little tool to auto-run git range-diff to help > build change logs.. >

Re: [Intel-gfx] [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-30 Thread Finn Thain
On Wed, 25 Nov 2020, Nick Desaulniers wrote: > On Wed, Nov 25, 2020 at 1:33 PM Finn Thain wrote: > > > > Or do you think that a codebase can somehow satisfy multiple checkers > > and their divergent interpretations of the language spec? > > Have we found any cases yet that are divergent? I d

Re: [Intel-gfx] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-30 Thread Edward Cree
On 24/11/2020 21:25, Kees Cook wrote: > I still think this isn't right -- it's a case statement that runs off > the end without an explicit flow control determination. Proves too much — for instance case foo: case bar: thing; break; doesn't require a fallthrough; after cas

Re: [Intel-gfx] [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-30 Thread Finn Thain
On Wed, 25 Nov 2020, Nick Desaulniers wrote: > On Wed, Nov 25, 2020 at 1:33 PM Finn Thain > wrote: > > > > Or do you think that a codebase can somehow satisfy multiple checkers > > and their divergent interpretations of the language spec? > > Have we found any cases yet that are divergent? I d

Re: [Intel-gfx] [RFC 4/4] drm/i915/gt: Pipelined page migration

2020-11-30 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-11-30 16:07:44) > > On 30/11/2020 13:39, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-11-30 13:12:55) > >> On 28/11/2020 18:40, Chris Wilson wrote: > >>> If we pipeline the PTE updates and then do the copy of those pages > >>> within a single unpreemptible comm

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_request_retire: Switch from random blitter loads to dummy

2020-11-30 Thread Tvrtko Ursulin
On 30/11/2020 10:36, Chris Wilson wrote: Use the spinners to provide exactly the right amount of background busyness. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- lib/igt_dummyload.c | 23 ++--- lib/igt_dummyload.h | 1 + tests/i915/gem_request_retire.c |

Re: [Intel-gfx] [PATCH] drm/i915: refactor panel backlight control functions.

2020-11-30 Thread Jani Nikula
On Thu, 26 Nov 2020, Dave Airlie wrote: > From: Dave Airlie > > This moves the functions into static const instead of having > funcs and data in the same struct. > > The only problem is the power callback gets overridden in the > eDP code so deal with that, might be worth seeing if that can be >

Re: [Intel-gfx] [RFC 4/4] drm/i915/gt: Pipelined page migration

2020-11-30 Thread Tvrtko Ursulin
On 30/11/2020 13:39, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-11-30 13:12:55) On 28/11/2020 18:40, Chris Wilson wrote: If we pipeline the PTE updates and then do the copy of those pages within a single unpreemptible command packet, we can submit the copies and leave them to be schedule

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [RFC,1/4] drm/i915/gt: Add an insert_entry for gen8_ppgtt

2020-11-30 Thread Patchwork
== Series Details == Series: series starting with [RFC,1/4] drm/i915/gt: Add an insert_entry for gen8_ppgtt URL : https://patchwork.freedesktop.org/series/84376/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9405 -> Patchwork_19009

Re: [Intel-gfx] [PATCH V2] drm/i915/jsl: Disable cursor clock gating in HDR mode

2020-11-30 Thread Surendrakumar Upadhyay, TejaskumarX
> -Original Message- > From: Souza, Jose > Sent: 03 November 2020 05:32 > To: Surendrakumar Upadhyay, TejaskumarX > ; intel- > g...@lists.freedesktop.org > Cc: Pandey, Hariom > Subject: Re: [PATCH V2] drm/i915/jsl: Disable cursor clock gating in HDR > mode > > On Mon, 2020-11-02 at 13

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Display glitches fixes

2020-11-30 Thread Patchwork
== Series Details == Series: Display glitches fixes URL : https://patchwork.freedesktop.org/series/84394/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/compile.h CC [M] drivers/gpu/drm/

[Intel-gfx] [ANNOUNCE] upcoming mandated dim upgrade due to drm-intel branch change

2020-11-30 Thread Jani Nikula
TL;DR: - On 2020-12-05, drm-intel-next-queued will be decommissioned - drm-intel committers need to start using drm-intel-next instead - Everyone needs to upgrade dim *after* the change Full story: For historical reasons, we've had separate drm-intel-next-queued ("dinq") and drm-intel-next ("d

Re: [Intel-gfx] [RFC 2/2] drm/i915/display: Protect pipe_update against dc3co exit

2020-11-30 Thread Imre Deak
On Mon, Nov 30, 2020 at 02:46:46PM +0530, Anshuman Gupta wrote: > At usual case DC3CO exit happen automatically by DMC f/w whenever > PSR2 clears idle. This happens smoothly by DMC f/w to work with flips. > But there are certain scenario where DC3CO Disallowed by driver > asynchronous with flips.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [RFC,1/4] drm/i915/gt: Add an insert_entry for gen8_ppgtt

2020-11-30 Thread Patchwork
== Series Details == Series: series starting with [RFC,1/4] drm/i915/gt: Add an insert_entry for gen8_ppgtt URL : https://patchwork.freedesktop.org/series/84376/ State : warning == Summary == $ dim checkpatch origin/drm-tip cfaf43ff6b76 drm/i915/gt: Add an insert_entry for gen8_ppgtt bca7cfcb

Re: [Intel-gfx] [PATCH 2/2] drm/i915/selftest: assert we get 2M GTT pages

2020-11-30 Thread Chris Wilson
Quoting Matthew Auld (2020-11-30 14:18:09) > For the LMEM case if we have suitable alignment and 2M physical pages we > should always get 2M GTT pages within the constraints of the hugepages > selftest. If we don't then something might be wrong in our construction > of the backing pages. > > Refer

  1   2   >