[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Add max plane width for NV12 AUX plane for Gen10+ platforms

2020-09-11 Thread Patchwork
== Series Details == Series: drm/i915/display: Add max plane width for NV12 AUX plane for Gen10+ platforms URL : https://patchwork.freedesktop.org/series/81609/ State : success == Summary == CI Bug Log - changes from CI_DRM_9003_full -> Patchwork_18485_full ===

[Intel-gfx] ✗ Fi.CI.BAT: failure for Convert the intel iommu driver to the dma-iommu api (rev2)

2020-09-11 Thread Patchwork
== Series Details == Series: Convert the intel iommu driver to the dma-iommu api (rev2) URL : https://patchwork.freedesktop.org/series/71260/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9003 -> Patchwork_18487 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent

2020-09-11 Thread Dhanavanthri, Swathi
It is in the if statement: if (IS_ROCKETLAKE(i915) || IS_TIGERLAKE(i915)) { -Original Message- From: Rodrigo Vivi Sent: Friday, September 11, 2020 6:10 PM To: Dhanavanthri, Swathi Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915/tgl, rkl: Make Wa_1606700617

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Convert the intel iommu driver to the dma-iommu api (rev2)

2020-09-11 Thread Patchwork
== Series Details == Series: Convert the intel iommu driver to the dma-iommu api (rev2) URL : https://patchwork.freedesktop.org/series/71260/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +driv

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Convert the intel iommu driver to the dma-iommu api (rev2)

2020-09-11 Thread Patchwork
== Series Details == Series: Convert the intel iommu driver to the dma-iommu api (rev2) URL : https://patchwork.freedesktop.org/series/71260/ State : warning == Summary == $ dim checkpatch origin/drm-tip fd87dbc34e1f iommu: Handle freelists when using deferred flushing in iommu drivers 97922d

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Add max plane width for NV12 AUX plane for Gen10+ platforms

2020-09-11 Thread Patchwork
== Series Details == Series: drm/i915/display: Add max plane width for NV12 AUX plane for Gen10+ platforms URL : https://patchwork.freedesktop.org/series/81609/ State : success == Summary == CI Bug Log - changes from CI_DRM_9003 -> Patchwork_18485 =

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Return head pages from find_*_entry (rev2)

2020-09-11 Thread Patchwork
== Series Details == Series: Return head pages from find_*_entry (rev2) URL : https://patchwork.freedesktop.org/series/81557/ State : failure == Summary == Applying: mm: Factor find_get_incore_page out of mincore_page Applying: mm: Use find_get_incore_page in memcontrol Applying: mm: Optimise

[Intel-gfx] [PATCH v3 4/6] iommu: Add quirk for Intel graphic devices in map_sg

2020-09-11 Thread Lu Baolu
Combining the sg segments exposes a bug in the Intel i915 driver which causes visual artifacts and the screen to freeze. This is most likely because of how the i915 handles the returned list. It probably doesn't respect the returned value specifying the number of elements in the list and instead de

[Intel-gfx] [PATCH v3 6/6] iommu/vt-d: Cleanup after converting to dma-iommu ops

2020-09-11 Thread Lu Baolu
Some cleanups after converting the driver to use dma-iommu ops. - Remove nobounce option; - Cleanup and simplify the path in domain mapping. Signed-off-by: Lu Baolu --- .../admin-guide/kernel-parameters.txt | 5 -- drivers/iommu/intel/iommu.c | 90 ++-

[Intel-gfx] [PATCH v3 2/6] iommu: Add iommu_dma_free_cpu_cached_iovas()

2020-09-11 Thread Lu Baolu
From: Tom Murphy Add a iommu_dma_free_cpu_cached_iovas function to allow drivers which use the dma-iommu ops to free cached cpu iovas. Signed-off-by: Tom Murphy Signed-off-by: Lu Baolu --- drivers/iommu/dma-iommu.c | 9 + include/linux/dma-iommu.h | 8 2 files changed, 17 ins

[Intel-gfx] [PATCH v3 5/6] iommu/vt-d: Convert intel iommu driver to the iommu ops

2020-09-11 Thread Lu Baolu
From: Tom Murphy Convert the intel iommu driver to the dma-iommu api. Remove the iova handling and reserve region code from the intel iommu driver. Signed-off-by: Tom Murphy Signed-off-by: Lu Baolu --- drivers/iommu/intel/Kconfig | 1 + drivers/iommu/intel/iommu.c | 742 ++--

[Intel-gfx] [PATCH v3 0/6] Convert the intel iommu driver to the dma-iommu api

2020-09-11 Thread Lu Baolu
Tom Murphy has almost done all the work. His latest patch series was posted here. https://lore.kernel.org/linux-iommu/20200903201839.7327-1-murph...@tcd.ie/ Thanks a lot! This series is a follow-up with below changes: 1. Add a quirk for the i915 driver issue described in Tom's cover letter. 2.

[Intel-gfx] [PATCH v3 3/6] iommu: Allow the dma-iommu api to use bounce buffers

2020-09-11 Thread Lu Baolu
From: Tom Murphy Allow the dma-iommu api to use bounce buffers for untrusted devices. This is a copy of the intel bounce buffer code. Signed-off-by: Tom Murphy Co-developed-by: Lu Baolu Signed-off-by: Lu Baolu --- drivers/iommu/dma-iommu.c | 163 +++--- 1 file

[Intel-gfx] [PATCH v3 1/6] iommu: Handle freelists when using deferred flushing in iommu drivers

2020-09-11 Thread Lu Baolu
From: Tom Murphy Allow the iommu_unmap_fast to return newly freed page table pages and pass the freelist to queue_iova in the dma-iommu ops path. This is useful for iommu drivers (in this case the intel iommu driver) which need to wait for the ioTLB to be flushed before newly free/unmapped page

Re: [Intel-gfx] [PATCH v2 7/8] mm/shmem: Return head page from find_lock_entry

2020-09-11 Thread Matthew Wilcox
On Thu, Sep 10, 2020 at 07:33:17PM +0100, Matthew Wilcox (Oracle) wrote: > Convert shmem_getpage_gfp() (the only remaining caller of > find_lock_entry()) to cope with a head page being returned instead of > the subpage for the index. This version was buggy. Apparently I was too focused on running

Re: [Intel-gfx] [PATCH V2 5/5] DO NOT MERGE: iommu: disable list appending in dma-iommu

2020-09-11 Thread Lu Baolu
On 2020/9/9 15:06, Christoph Hellwig wrote: On Wed, Sep 09, 2020 at 09:43:09AM +0800, Lu Baolu wrote: + /* +* The Intel graphic device driver is used to assume that the returned +* sg list is not combound. This blocks the efforts of converting the This adds pointless over

[Intel-gfx] [PATCH] drm/i915/display: Add max plane width for NV12 AUX plane for Gen10+ platforms

2020-09-11 Thread Aditya Swarup
Gen 10+ and Gen11+ platforms specify different max plane width for planar formats. Add max plane width for GLK and ICL based on BSpec: 7666 Cc: Matt Roper Cc: Ville Syrjälä Cc: Imre Deak Signed-off-by: Aditya Swarup --- drivers/gpu/drm/i915/display/intel_display.c | 7 +++ 1 file changed,

Re: [Intel-gfx] [10/12] drm/i915: Introduce HPD_PORT_TC

2020-09-11 Thread Souza, Jose
On Wed, 2020-07-01 at 00:55 +0300, Ville Syrjala wrote: > From: Ville Syrjälä < > ville.syrj...@linux.intel.com > > > > Make a clean split between hpd pins for DDI vs. TC. This matches > how the actual hardware is split. > > And with this we move the DDI/PHY->HPD pin mapping into the encoder > in

Re: [Intel-gfx] [PATCH] drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent

2020-09-11 Thread Rodrigo Vivi
On Fri, Sep 11, 2020 at 03:11:58PM -0700, Swathi Dhanavanthri wrote: > This workaround applies to all TGL and RKL steppings. > > Signed-off-by: Swathi Dhanavanthri > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent

2020-09-11 Thread Patchwork
== Series Details == Series: drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent URL : https://patchwork.freedesktop.org/series/81608/ State : success == Summary == CI Bug Log - changes from CI_DRM_9002_full -> Patchwork_18484_full

Re: [Intel-gfx] [PULL] gvt-next

2020-09-11 Thread Rodrigo Vivi
On Thu, Sep 10, 2020 at 01:37:20PM +0800, Zhenyu Wang wrote: > > Hi, > > As we split pull request for 5.10 this time, here's gvt-next pull > for 5.10. For gvt ww lock fix, Zhi would send another pull based > on gem-next. > > This includes current command access flag cleanup for > handlers which

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent

2020-09-11 Thread Patchwork
== Series Details == Series: drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent URL : https://patchwork.freedesktop.org/series/81608/ State : success == Summary == CI Bug Log - changes from CI_DRM_9002 -> Patchwork_18484 Summary --

[Intel-gfx] [PATCH] drm/i915/tgl, rkl: Make Wa_1606700617/22010271021 permanent

2020-09-11 Thread Swathi Dhanavanthri
This workaround applies to all TGL and RKL steppings. Signed-off-by: Swathi Dhanavanthri --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workaro

Re: [Intel-gfx] [CI] drm/i915/selftests: Downgrade severity of CS/SRM frequency scaling tests

2020-09-11 Thread Rodrigo Vivi
On Thu, Jul 23, 2020 at 04:38:05PM +0100, Chris Wilson wrote: > Gracefully skip over the failures in the frequency scaling for the > moment, the results are under review. We need to clock gate media sampler to be able to scale the frequency without getting throttled. Reference: https://gitlab.fre

Re: [Intel-gfx] [PATCH] drm/i915/selftests: test the correct variable in igt_gem_ww_ctx()

2020-09-11 Thread Andi Shyti
Hi Dan, > There is a copy and paste error here. The "obj" should be "obj2". The > current code could result in an Oops. > > Fixes: 80f0b679d6f0 ("drm/i915: Add an implementation for i915_gem_ww_ctx > locking, v2.") > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/i915/selftests/i915_ge

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use fb->format->is_yuv for the g4x+ sprite RGB vs. YUV check

2020-09-11 Thread Jani Nikula
On Thu, 06 Feb 2020, Ville Syrjala wrote: > From: Ville Syrjälä > > g4x+ sprites have an extra cdclk limitation listed for RGB formats. > For some random reason I chose to use cpp>=4 as the check for that. > While that does actually work let's deobfuscate it by checking > for !is_yuv instead. I s

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix g4x+ sprite dotclock limit for upscaling

2020-09-11 Thread Jani Nikula
On Thu, 06 Feb 2020, Ville Syrjala wrote: > From: Ville Syrjälä > > Even if we're not doing downscaling we should account for > some of the extra dotclock limitations for g4x+ sprites. In > particular we must never exceed the 90% rule, and with RGB > that limits actually drops to 80%. > > So inst

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/fbc: disable FBC on Nightfury board (rev2)

2020-09-11 Thread Patchwork
== Series Details == Series: drm/i915/fbc: disable FBC on Nightfury board (rev2) URL : https://patchwork.freedesktop.org/series/81087/ State : success == Summary == CI Bug Log - changes from CI_DRM_9001_full -> Patchwork_18483_full Summary

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Nuke CACHE_MODE_0 save/restore

2020-09-11 Thread Jani Nikula
On Tue, 08 Sep 2020, Ville Syrjala wrote: > From: Ville Syrjälä > > The CACHE_MODE_0 save/restore was added without explanation in > commit 1f84e550a870 ("drm/i915 more registers for S3 (DSPCLK_GATE_D, > CACHE_MODE_0, MI_ARB_STATE)"). If there are any bits we care about > those should be set expl

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Nuke MI_ARB_STATE save/restore

2020-09-11 Thread Jani Nikula
On Tue, 08 Sep 2020, Ville Syrjala wrote: > From: Ville Syrjälä > > Originally added in commit 1f84e550a870 ("drm/i915 more registers for > S3 (DSPCLK_GATE_D, CACHE_MODE_0, MI_ARB_STATE)") to fix some underruns. > I suspect that was due to the trickle feed settings getting clobbered > during susp

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Nuke the magic FBC_CONTROL save/restore

2020-09-11 Thread Jani Nikula
On Tue, 08 Sep 2020, Ville Syrjala wrote: > From: Ville Syrjälä > > The FBC_CONTROL save restore is there just to preserve the > compression interval setting. Since commit a68ce21ba0c4 > ("drm/i915/fbc: Store the fbc1 compression interval in the params") > we've been explicitly setting the interv

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Kill unused savePCH_PORT_HOTPLUG

2020-09-11 Thread Jani Nikula
On Tue, 08 Sep 2020, Ville Syrjala wrote: > From: Ville Syrjälä > > We don't save/restore PCH_PORT_HOTPLUG so no point in reseving > space for the value. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_drv.h | 1 - > 1 file changed, 1 deletion(-) >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: test the correct variable in igt_gem_ww_ctx()

2020-09-11 Thread Patchwork
== Series Details == Series: drm/i915/selftests: test the correct variable in igt_gem_ww_ctx() URL : https://patchwork.freedesktop.org/series/81584/ State : success == Summary == CI Bug Log - changes from CI_DRM_9000_full -> Patchwork_18482_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fbc: disable FBC on Nightfury board (rev2)

2020-09-11 Thread Patchwork
== Series Details == Series: drm/i915/fbc: disable FBC on Nightfury board (rev2) URL : https://patchwork.freedesktop.org/series/81087/ State : success == Summary == CI Bug Log - changes from CI_DRM_9001 -> Patchwork_18483 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/fbc: disable FBC on Nightfury board

2020-09-11 Thread Ville Syrjälä
On Thu, Aug 27, 2020 at 01:51:29PM +0800, Lee Shawn C wrote: > Customer report random display flicker issue on Nightfury board. > And we found this problem might be caused by VT-d and FBC are > both enabled. According to sighting report, it recommend to turn > drm/i915/fbc: disable FBC on Nightfury

Re: [Intel-gfx] [PATCH i-g-t v6 23/24] tests/core_hotunplug: Un-blocklist *bind* subtests

2020-09-11 Thread Petri Latvala
On Fri, Sep 11, 2020 at 02:00:11PM +0200, Janusz Krzysztofik wrote: > Hi Petri, > > On Fri, 2020-09-11 at 14:51 +0300, Petri Latvala wrote: > > On Fri, Sep 11, 2020 at 12:30:38PM +0200, Janusz Krzysztofik wrote: > > > Subject: [PATCH i-g-t v6 23/24] tests/core_hotunplug: Un-blocklist *bind* > > >

Re: [Intel-gfx] [PATCH i-g-t v6 21/24] tests/core_hotunplug: HSW/BDW audio issue workaround

2020-09-11 Thread Petri Latvala
On Fri, Sep 11, 2020 at 03:15:43PM +0200, Janusz Krzysztofik wrote: > Hi Petri, > > On Fri, 2020-09-11 at 15:22 +0300, Petri Latvala wrote: > > On Fri, Sep 11, 2020 at 12:30:36PM +0200, Janusz Krzysztofik wrote: > > > Unbinding the i915 driver on some Haswell and Broadwell platforms with > > > Aza

[Intel-gfx] [PATCH v2] drm/i915/fbc: disable FBC on Nightfury board

2020-09-11 Thread Lee Shawn C
Customer report random display flicker issue on Nightfury board. And we found this problem might be caused by VT-d and FBC are both enabled. According to sighting report, it recommend to turn FBC off to workaround this kind of issue. This change refer to DMI BOARD_VENDOR and BOARD_NAME information

Re: [Intel-gfx] [PATCH i-g-t v6 21/24] tests/core_hotunplug: HSW/BDW audio issue workaround

2020-09-11 Thread Janusz Krzysztofik
Hi Petri, On Fri, 2020-09-11 at 15:22 +0300, Petri Latvala wrote: > On Fri, Sep 11, 2020 at 12:30:36PM +0200, Janusz Krzysztofik wrote: > > Unbinding the i915 driver on some Haswell and Broadwell platforms with > > Azalia audio results in a kernel WARNING on "i915 raw-wakerefs=1 > > wakelocks=1 on

Re: [Intel-gfx] [PATCH] drm/i915/selftests: test the correct variable in igt_gem_ww_ctx()

2020-09-11 Thread Tvrtko Ursulin
On 11/09/2020 12:34, Dan Carpenter wrote: There is a copy and paste error here. The "obj" should be "obj2". The current code could result in an Oops. Fixes: 80f0b679d6f0 ("drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: test the correct variable in igt_gem_ww_ctx()

2020-09-11 Thread Patchwork
== Series Details == Series: drm/i915/selftests: test the correct variable in igt_gem_ww_ctx() URL : https://patchwork.freedesktop.org/series/81584/ State : success == Summary == CI Bug Log - changes from CI_DRM_9000 -> Patchwork_18482 Summ

Re: [Intel-gfx] [PATCH i-g-t v6 21/24] tests/core_hotunplug: HSW/BDW audio issue workaround

2020-09-11 Thread Petri Latvala
On Fri, Sep 11, 2020 at 12:30:36PM +0200, Janusz Krzysztofik wrote: > Unbinding the i915 driver on some Haswell and Broadwell platforms with > Azalia audio results in a kernel WARNING on "i915 raw-wakerefs=1 > wakelocks=1 on cleanup". The issue can be worked around by manually > enabling runtime p

Re: [Intel-gfx] dg1 flag for userspace to allocate contig resources

2020-09-11 Thread Ville Syrjälä
On Fri, Sep 11, 2020 at 03:27:07PM +0300, Joonas Lahtinen wrote: > + Jani and Ville > > Quoting Matthew Auld (2020-09-11 11:56:56) > > On 11/09/2020 06:42, Dave Airlie wrote: > > > I've just been looking at the current DG1 uapi, and I can't see any > > > flag to allow userspace to upfront say it w

Re: [Intel-gfx] dg1 flag for userspace to allocate contig resources

2020-09-11 Thread Joonas Lahtinen
+ Jani and Ville Quoting Matthew Auld (2020-09-11 11:56:56) > On 11/09/2020 06:42, Dave Airlie wrote: > > I've just been looking at the current DG1 uapi, and I can't see any > > flag to allow userspace to upfront say it was a contiguous vram BO. > > > > I think you'd really want this for scanout,

Re: [Intel-gfx] [PATCH i-g-t v6 24/24] tests/core_hotunplug: Add unbind-rebind subtest to BAT scope

2020-09-11 Thread Janusz Krzysztofik
On Fri, 2020-09-11 at 14:52 +0300, Petri Latvala wrote: > On Fri, Sep 11, 2020 at 12:30:39PM +0200, Janusz Krzysztofik wrote: > > Subject: [PATCH i-g-t v6 24/24] tests/core_hotunplug: Add unbind-rebind > > subtest to BAT scope > > Same here, prefix with intel-ci > Sure. Thanks, Janusz ___

Re: [Intel-gfx] [PATCH i-g-t v6 23/24] tests/core_hotunplug: Un-blocklist *bind* subtests

2020-09-11 Thread Janusz Krzysztofik
Hi Petri, On Fri, 2020-09-11 at 14:51 +0300, Petri Latvala wrote: > On Fri, Sep 11, 2020 at 12:30:38PM +0200, Janusz Krzysztofik wrote: > > Subject: [PATCH i-g-t v6 23/24] tests/core_hotunplug: Un-blocklist *bind* > > subtests > > Change to > > intel-ci: Un-blocklist *bind* subtests of core_hot

Re: [Intel-gfx] [PATCH i-g-t v6 24/24] tests/core_hotunplug: Add unbind-rebind subtest to BAT scope

2020-09-11 Thread Petri Latvala
On Fri, Sep 11, 2020 at 12:30:39PM +0200, Janusz Krzysztofik wrote: > Subject: [PATCH i-g-t v6 24/24] tests/core_hotunplug: Add unbind-rebind > subtest to BAT scope Same here, prefix with intel-ci -- Petri Latvala ___ Intel-gfx mailing list Intel-gfx

Re: [Intel-gfx] [PATCH i-g-t v6 23/24] tests/core_hotunplug: Un-blocklist *bind* subtests

2020-09-11 Thread Petri Latvala
On Fri, Sep 11, 2020 at 12:30:38PM +0200, Janusz Krzysztofik wrote: > Subject: [PATCH i-g-t v6 23/24] tests/core_hotunplug: Un-blocklist *bind* > subtests Change to intel-ci: Un-blocklist *bind* subtests of core_hotunplug -- Petri Latvala ___ Intel-

[Intel-gfx] [bug report] drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.

2020-09-11 Thread Dan Carpenter
Hello Maarten Lankhorst, This is a semi-automatic email about new static checker warnings. The patch 80f0b679d6f0: "drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2." from Aug 19, 2020, leads to the following Smatch complaint: drivers/gpu/drm/i915/gem/i915_gem_object.h:130 __i

[Intel-gfx] [PATCH] drm/i915/selftests: test the correct variable in igt_gem_ww_ctx()

2020-09-11 Thread Dan Carpenter
There is a copy and paste error here. The "obj" should be "obj2". The current code could result in an Oops. Fixes: 80f0b679d6f0 ("drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/i915/selftests/i915_gem.c | 4 ++-- 1 file chan

Re: [Intel-gfx] [PATCH 1/3] drm/i915: disable all display features when no display

2020-09-11 Thread Jani Nikula
On Thu, 10 Sep 2020, Ville Syrjälä wrote: > On Thu, Sep 10, 2020 at 12:52:25PM +0300, Jani Nikula wrote: >> Disable all display feature flags when there are no pipes i.e. there is >> no display. This should help with not having to additionally check for >> HAS_DISPLAY() when a feature flag check w

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix an error code i915_gem_object_copy_blt() (rev2)

2020-09-11 Thread Patchwork
== Series Details == Series: drm/i915: Fix an error code i915_gem_object_copy_blt() (rev2) URL : https://patchwork.freedesktop.org/series/81545/ State : success == Summary == CI Bug Log - changes from CI_DRM_8996_full -> Patchwork_18481_full

[Intel-gfx] [PATCH i-g-t v6 19/24] tests/core_hotunplug: Add 'lateclose before restore' variants

2020-09-11 Thread Janusz Krzysztofik
If a GPU gets wedged during driver rebind or device re-plug for some reason, current hotunbind/hotunplug test variants may time out before lateclose phase, resulting in incomplete CI reports. Add new test variants which close the device before restoring it. Also rename old variants to more adequa

[Intel-gfx] [PATCH i-g-t v6 17/24] tests/core_hotunplug: Also check health of render device node

2020-09-11 Thread Janusz Krzysztofik
Failures of subsequent tests accessing the render device node have been observed on CI after late close of a hot rebound device. Extend our health check over the render node to detect that condition and start our recovery phase with unbinding the driver from the device found faulty. Also, check h

[Intel-gfx] [PATCH i-g-t v6 16/24] tests/core_hotunplug: Explicitly ignore unused return values

2020-09-11 Thread Janusz Krzysztofik
Some return values are not useful and can be ignored. Wrap those cases inside igt_ignore_warn(), not only to make sure compilers are happy but also to clearly document our decisions. Signed-off-by: Janusz Krzysztofik Reviewed-by: Michał Winiarski --- tests/core_hotunplug.c | 6 +++--- 1 file c

[Intel-gfx] [PATCH i-g-t v6 23/24] tests/core_hotunplug: Un-blocklist *bind* subtests

2020-09-11 Thread Janusz Krzysztofik
Subtests which don't remove the device, only unbind the driver from it, seem relatively safe and harmless for CI. Remove them from the CI blocklist. Signed-off-by: Janusz Krzysztofik --- tests/intel-ci/blacklist.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/intel

[Intel-gfx] [PATCH i-g-t v6 22/24] tests/core_hotunplug: Duplicate debug messages in dmesg

2020-09-11 Thread Janusz Krzysztofik
The purpose of debug messages displayed by the test is to make identification of a subtest phase that fails more easy. Since issues exhibited by the test are mostly reported to dmesg, print those debug messages to /dev/kmsg as well. v2: Rebase on upstream. v3: Refresh. v4: Refresh. v5: Refresh.

[Intel-gfx] [PATCH i-g-t v6 14/24] tests/core_hotunplug: Process return values of sysfs operations

2020-09-11 Thread Janusz Krzysztofik
Return values of driver bind/unbind / device remove/recover sysfs operations are now ignored. Assert their correctness. v2: Add trailing newlines missing from igt_assert messages. Signed-off-by: Janusz Krzysztofik Reviewed-by: Michał Winiarski --- tests/core_hotunplug.c | 14 ++ 1

[Intel-gfx] [PATCH i-g-t v6 18/24] tests/core_hotunplug: More thorough i915 healthcheck and recovery

2020-09-11 Thread Janusz Krzysztofik
The test now assumes the i915 driver is able to identify potential hardware or driver issues while rebinding to a device and indicate them by marking the GPU wedged. Should that assumption occur wrong, the health check phase of the test would happily succeed while potentially leaving the device in

[Intel-gfx] [PATCH i-g-t v6 20/24] tests/core_hotunplug: Check health both before and after late close

2020-09-11 Thread Janusz Krzysztofik
In hot rebind / hot replug subtests, device health is now checked only at the end of the subtest, after late close. If something fails, we may be not able to identify the failing phase of the subtest easily. Run health checks also before late closing the device, right after hot rebind / replug.

[Intel-gfx] [PATCH i-g-t v6 24/24] tests/core_hotunplug: Add unbind-rebind subtest to BAT scope

2020-09-11 Thread Janusz Krzysztofik
Unbinding and rebinding the driver to a device scenario is a subset of unloading and reloading the module and should give equally correct results. Signed-off-by: Janusz Krzysztofik --- tests/intel-ci/fast-feedback.testlist | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/intel-ci/fast-f

[Intel-gfx] [PATCH i-g-t v6 21/24] tests/core_hotunplug: HSW/BDW audio issue workaround

2020-09-11 Thread Janusz Krzysztofik
Unbinding the i915 driver on some Haswell and Broadwell platforms with Azalia audio results in a kernel WARNING on "i915 raw-wakerefs=1 wakelocks=1 on cleanup". The issue can be worked around by manually enabling runtime power management for the conflicting audio adapter. Use that method but also

[Intel-gfx] [PATCH i-g-t v6 06/24] tests/core_hotunplug: Maintain a single data structure instance

2020-09-11 Thread Janusz Krzysztofik
The following changes to the test are planned: - avoid global variables if possible, - prepare invariant data only once per test run, - skip subsequent subtests after device close errors, - allow subtests to fail on errors and try to recover from those failures in follow up igt dixture sections i

[Intel-gfx] [PATCH i-g-t v6 08/24] tests/core_hotunplug: Handle device close errors

2020-09-11 Thread Janusz Krzysztofik
The test now ignores device close errors. Those errors are believed to have no influence on device health so there is no need to process them the same way as we mostly do on errors, i.e., notify CI about a problem via igt_abort. However, those errors may indicate issues with the test itself. Mor

[Intel-gfx] [PATCH i-g-t v6 15/24] tests/core_hotunplug: Assert expected device presence/absence

2020-09-11 Thread Janusz Krzysztofik
Don't rely on successful write to sysfs control files, assert existence / non-existence of a respective device sysfs node as well. Signed-off-by: Janusz Krzysztofik Reviewed-by: Michał Winiarski --- tests/core_hotunplug.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/tests

[Intel-gfx] [PATCH i-g-t v6 10/24] tests/core_hotunplug: Skip selectively on sysfs close errors

2020-09-11 Thread Janusz Krzysztofik
Since we no longer open a device DRM sysfs node, only a PCI one, driver unbind operations are no longer affected by missed or unsuccessful sysfs file close attempts. Skip only affected subtests if that happens. v2: Rebase only. v3: Refresh. v4: Refresh. Signed-off-by: Janusz Krzysztofik Reviewe

[Intel-gfx] [PATCH i-g-t v6 09/24] tests/core_hotunplug: Prepare invariant data once per test run

2020-09-11 Thread Janusz Krzysztofik
Each subtest now calls a prepare() helper which opens a couple of files required by that subtest. Those files are then closed after use, either directly from the subtest body, or indirectly from inside one of helper functions called during the subtest execution. That approach not only makes life

[Intel-gfx] [PATCH i-g-t v6 02/24] tests/core_hotunplug: Constify dev_bus_addr string

2020-09-11 Thread Janusz Krzysztofik
Device bus address structure field is always initialized with a pointer to a substring of the device sysfs path and never used for its modification. Declare it as a constant string. Signed-off-by: Janusz Krzysztofik Reviewed-by: Michał Winiarski --- tests/core_hotunplug.c | 2 +- 1 file change

[Intel-gfx] [PATCH i-g-t v6 05/24] tests/core_hotunplug: Assert successful device filter application

2020-09-11 Thread Janusz Krzysztofik
Return value of igt_device_filter_add() representing a number of successfully installed device filters is now ignored. Fail if not 1. Signed-off-by: Janusz Krzysztofik Reviewed-by: Michał Winiarski --- tests/core_hotunplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t

[Intel-gfx] [PATCH i-g-t v6 04/24] tests/core_hotunplug: Consolidate duplicated debug messages

2020-09-11 Thread Janusz Krzysztofik
Some debug messages which designate specific test operations, or their greater parts at least, sound always the same, no matter which subtest they are called from. Emit them, possibly updated with subtest specified modifiers, from inside respective helpers instead of duplicating them in subtest bo

[Intel-gfx] [PATCH i-g-t v6 03/24] tests/core_hotunplug: Clean up device open error handling

2020-09-11 Thread Janusz Krzysztofik
We don't use drm_driver_open() since in case of an i915 device it keeps an extra file descriptor of the exercised device open for exit handler use, while we would like to be able to close the device completely before running certain test operations. Instead, we call __drm_driver_open() and handle

[Intel-gfx] [PATCH i-g-t v6 12/24] tests/core_hotunplug: Fail subtests on device close errors

2020-09-11 Thread Janusz Krzysztofik
Since health checks are now run from follow-up fixture sections, it is safe to fail subtests without the need to abort the test execution. Do that on device close errors instead of just emitting warnings. v2: Rebase only. v3: Refresh. v4: Refresh. Signed-off-by: Janusz Krzysztofik Reviewed-by:

[Intel-gfx] [PATCH i-g-t v6 13/24] tests/core_hotunplug: Let the driver time out essential sysfs operations

2020-09-11 Thread Janusz Krzysztofik
The test now arms a timer before performing each driver unbind / rebind or device unplug / bus rescan sysfs operation. Then in case of issues we may prevent the driver from showing us if and how it can handle them. Don't arm the timer before sysfs operations which are essential for a subtest. v2

[Intel-gfx] [PATCH i-g-t v6 11/24] tests/core_hotunplug: Recover from subtest failures

2020-09-11 Thread Janusz Krzysztofik
Subtests now forcibly call or request igt_abort on failures in order to avoid silently leaving an exercised device in an unusable state. However, a failure inside a subtest doesn't always mean the device is no longer working correctly and reboot is needed. On the other hand, if a subtest just fail

[Intel-gfx] [PATCH i-g-t v6 07/24] tests/core_hotunplug: Pass errors via a data structure field

2020-09-11 Thread Janusz Krzysztofik
A pointer to fatal error messages can be passed around via hotunplug structure, no need to declare it as global. v2: Rebase only. v3: Refresh. Signed-off-by: Janusz Krzysztofik Reviewed-by: Michał Winiarski --- tests/core_hotunplug.c | 96 +- 1 file chan

[Intel-gfx] [PATCH i-g-t v6 01/24] tests/core_hotunplug: Use igt_assert_fd()

2020-09-11 Thread Janusz Krzysztofik
There is a new library helper that asserts validity of open file descriptors. Use it instead of open coding. Signed-off-by: Janusz Krzysztofik Reviewed-by: Michał Winiarski --- tests/core_hotunplug.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/core_hotu

[Intel-gfx] [PATCH i-g-t v6 00/24] tests/core_hotunplug: Fixes and enhancements

2020-09-11 Thread Janusz Krzysztofik
Clean up the test code, add some new basic subtests, then unblock unbind test variants. No incompletes / aborts nor subsequently run test issues have been reported by Trybot. The hotrebind-lateclose subtest fails on a so far unidentified driver sysfs issue but the device is fully recovered and le

Re: [Intel-gfx] [PATCH 08/24] drm/i915/selftests: align more to real device lifetimes

2020-09-11 Thread Matthew Auld
On Fri, 4 Sep 2020 at 15:40, Daniel Vetter wrote: > > The big change is device_add so that device_del can auto-cleanup > devres resources. This allows us to use devm_drm_dev_alloc, which > removes the last user of drm_dev_init. > > v2: Rebased > > v3: use devres_open/release_group so we can use de

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix an error code i915_gem_object_copy_blt() (rev2)

2020-09-11 Thread Patchwork
== Series Details == Series: drm/i915: Fix an error code i915_gem_object_copy_blt() (rev2) URL : https://patchwork.freedesktop.org/series/81545/ State : success == Summary == CI Bug Log - changes from CI_DRM_8996 -> Patchwork_18481 Summary

Re: [Intel-gfx] [PATCH 08/24] drm/i915/selftests: align more to real device lifetimes

2020-09-11 Thread Maarten Lankhorst
Op 04-09-2020 om 16:39 schreef Daniel Vetter: > The big change is device_add so that device_del can auto-cleanup > devres resources. This allows us to use devm_drm_dev_alloc, which > removes the last user of drm_dev_init. > > v2: Rebased > > v3: use devres_open/release_group so we can use devm with

Re: [Intel-gfx] dg1 flag for userspace to allocate contig resources

2020-09-11 Thread Matthew Auld
On 11/09/2020 06:42, Dave Airlie wrote: I've just been looking at the current DG1 uapi, and I can't see any flag to allow userspace to upfront say it was a contiguous vram BO. I think you'd really want this for scanout, since otherwise you'll have to migrate any non-contig to contig when it tran

Re: [Intel-gfx] [PATCH 3/9] drm/i915: Make GEM contexts track DRM clients

2020-09-11 Thread Tvrtko Ursulin
On 11/09/2020 07:44, Lucas De Marchi wrote: On Fri, Sep 04, 2020 at 01:59:28PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin If we make GEM contexts keep a reference to i915_drm_client for the whole of their lifetime, we can consolidate the current task pid and name usage by getting it fr

Re: [Intel-gfx] [PATCH] drm/xlnx: Use devm_drm_dev_alloc

2020-09-11 Thread Daniel Vetter
On Tue, Sep 08, 2020 at 12:16:00PM -0700, Hyun Kwon wrote: > Hi Daniel, > > On Mon, Sep 07, 2020 at 01:22:25AM -0700, Daniel Vetter wrote: > > Gets rid of drmm_add_final_kfree, which I want to unexport so that it > > stops confusion people about this transitional state of rolling drm > > managed m

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Fix DMA mapped scatterlist lookup

2020-09-11 Thread Tvrtko Ursulin
On 10/09/2020 14:31, Tom Murphy wrote: > This patch series fixes the issue I was having. I tested it with my > patch set ("[PATCH V2 0/5] Convert the intel iommu driver to the > dma-iommu api") applied, excluding the last patch in that series which > disables the coalescing. > > So once your pat

[Intel-gfx] [PATCH v2] drm/i915: Fix an error code i915_gem_object_copy_blt()

2020-09-11 Thread Dan Carpenter
This code should use "vma[1]" instead of "vma". The "vma" variable is a valid pointer. Fixes: 6b05030496f7 ("drm/i915: Convert i915_gem_object/client_blt.c to use ww locking as well, v2.") Signed-off-by: Dan Carpenter Reviewed-by: Mika Kuoppala --- v2: Fix confusing typo in the commit message