[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pll: Centralize PLL_ENABLE register lookup

== Series Details == Series: drm/i915/pll: Centralize PLL_ENABLE register lookup URL : https://patchwork.freedesktop.org/series/81150/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8938_full -> Patchwork_18421_full Summary

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state (rev2)

@Souza, Jose Thanks for filing the bug. I have done all necessary changes in CI bug log. All good with the patch series now. Lakshmi. -Original Message- From: Souza, Jose Sent: Friday, August 28, 2020 6:02 PM To: natechancel...@gmail.com; intel-gfx@lists.freedesktop.org; Vudum, Lakshmi

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state (rev2)

== Series Details == Series: drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state (rev2) URL : https://patchwork.freedesktop.org/series/79536/ State : success == Summary == CI Bug Log - changes from CI_DRM_8938_full -> Patchwork_18420_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state (rev2)

== Series Details == Series: drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state (rev2) URL : https://patchwork.freedesktop.org/series/79536/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8938_full -> Patchwork_18420_full

Re: [Intel-gfx] [PATCH] drm/i915/display: fix uninitialized variable

Just merged the first patch that fixed this issue, thanks anyways. 2034c2129bc4a91d471815d4dc7a2a69eaa5338d - drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state On Tue, 2020-08-25 at 16:20 -0700, t...@redhat.com wrote: > From: Tom Rix < > t...@redhat.com > > >

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state (rev2)

On Fri, 2020-08-28 at 22:41 +, Patchwork wrote: > Patch Details > Series: drm/i915/display: Ensure that ret is always initialized in > icl_combo_phy_verify_state (rev2) > URL: https://patchwork.freedesktop.org/series/79536/ > State:failure > Details: > https://intel-gfx-ci

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pll: Centralize PLL_ENABLE register lookup

== Series Details == Series: drm/i915/pll: Centralize PLL_ENABLE register lookup URL : https://patchwork.freedesktop.org/series/81150/ State : success == Summary == CI Bug Log - changes from CI_DRM_8938 -> Patchwork_18421 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state (rev2)

== Series Details == Series: drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state (rev2) URL : https://patchwork.freedesktop.org/series/79536/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8938_full -> Patchwork_18420_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pll: Centralize PLL_ENABLE register lookup

== Series Details == Series: drm/i915/pll: Centralize PLL_ENABLE register lookup URL : https://patchwork.freedesktop.org/series/81150/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9b03add535d5 drm/i915/pll: Centralize PLL_ENABLE register lookup -:26: CHECK:BRACES: Blank lines

[Intel-gfx] [PATCH] drm/i915/pll: Centralize PLL_ENABLE register lookup

We currenty check for platform at multiple parts in the driver to grab the correct PLL. Let us begin to centralize it through a helper function. Suggested-by: Matt Roper Cc: Matt Roper Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 27 --- 1

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state (rev2)

== Series Details == Series: drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state (rev2) URL : https://patchwork.freedesktop.org/series/79536/ State : success == Summary == CI Bug Log - changes from CI_DRM_8938 -> Patchwork_18420 ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state (rev2)

== Series Details == Series: drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state (rev2) URL : https://patchwork.freedesktop.org/series/79536/ State : warning == Summary == $ dim checkpatch origin/drm-tip a5e1e06edb8e drm/i915/display: Ensure that ret is alway

[Intel-gfx] [PATCH CI] drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state

From: Nathan Chancellor Clang warns: drivers/gpu/drm/i915/display/intel_combo_phy.c:268:3: warning: variable 'ret' is uninitialized when used here [-Wuninitialized] ret &= check_phy_reg(dev_priv, phy, ICL_PORT_TX_DW8_LN0(phy), ^~~ drivers/gpu/drm/i915/display/inte

Re: [Intel-gfx] [PATCH] drm/i915: break TGL pci-ids in GT 1 & 2

On Fri, 28 Aug 2020 06:31:25 -0700, Lionel Landwerlin wrote: > > I'll need this in IGT to identify the different kind of GTs and apply > the right performance query configuration. Reviewed-by: Ashutosh Dixit > Signed-off-by: Lionel Landwerlin > --- > include/drm/i915_pciids.h | 14 ++--

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v3,1/3] drm/i915/display/tgl: Use TGL DP tables for eDP ports without low power support (rev2)

On Thu, 2020-08-27 at 04:54 +, Patchwork wrote: > Patch Details > Series: series starting with [v3,1/3] drm/i915/display/tgl: Use TGL DP > tables for eDP ports without low power support (rev2) > URL: https://patchwork.freedesktop.org/series/81083/ > State:failure > Details:

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/tgl: Fix stepping WA matching (rev3)

On Fri, 2020-08-28 at 02:24 +, Patchwork wrote: > Patch Details > Series: drm/i915/tgl: Fix stepping WA matching (rev3) > URL: https://patchwork.freedesktop.org/series/80820/ > State:failure > Details: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18417/index.html >

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: break TGL pci-ids in GT 1 & 2

== Series Details == Series: drm/i915: break TGL pci-ids in GT 1 & 2 URL : https://patchwork.freedesktop.org/series/81144/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8937_full -> Patchwork_18419_full Summary --- *

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: break TGL pci-ids in GT 1 & 2

== Series Details == Series: drm/i915: break TGL pci-ids in GT 1 & 2 URL : https://patchwork.freedesktop.org/series/81144/ State : success == Summary == CI Bug Log - changes from CI_DRM_8937 -> Patchwork_18419 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 06/39] drm/i915/gt: Wait for CSB entries on Tigerlake

Chris Wilson writes: > On Tigerlake, we are seeing a repeat of commit d8f505311717 ("drm/i915/icl: > Forcibly evict stale csb entries") where, presumably, due to a missing > Global Observation Point synchronisation, the write pointer of the CSB > ringbuffer is updated _prior_ to the contents of t

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: break TGL pci-ids in GT 1 & 2

== Series Details == Series: drm/i915: break TGL pci-ids in GT 1 & 2 URL : https://patchwork.freedesktop.org/series/81144/ State : warning == Summary == $ dim checkpatch origin/drm-tip 367b86db54b4 drm/i915: break TGL pci-ids in GT 1 & 2 -:20: ERROR:COMPLEX_MACRO: Macros with complex values sh

[Intel-gfx] [PATCH] drm/i915: break TGL pci-ids in GT 1 & 2

I'll need this in IGT to identify the different kind of GTs and apply the right performance query configuration. Signed-off-by: Lionel Landwerlin --- include/drm/i915_pciids.h | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/include/drm/i915_pciids.h b/include/

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for tests/core_hotunplug: Fixes and enhancements (rev5)

On Fri, 2020-08-28 at 11:53 +, Patchwork wrote: > Patch Details > Series: tests/core_hotunplug: Fixes and enhancements (rev5) > URL: https://patchwork.freedesktop.org/series/79671/ > State:failure > Details: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4914/index.html > CI

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] lib: Use unsigned gen for forward compatible tests

On Mon, Aug 10, 2020 at 09:56:34AM +0100, Chris Wilson wrote: > Quoting Petri Latvala (2020-08-10 09:22:42) > > On Mon, Aug 10, 2020 at 10:09:46AM +0200, Zbigniew Kempczyński wrote: > > > On Thu, Aug 06, 2020 at 03:45:29PM +0100, Chris Wilson wrote: > > > > Unknown, so future, gen are marked as -1

[Intel-gfx] [PATCH i-g-t v5 13/21] tests/core_hotunplug: Let the driver time out essential sysfs operations

The test now arms a timer before performing each driver unbind / rebind or device unplug / bus rescan sysfs operation. Then in case of issues we may prevent the driver from showing us if and how it can handle them. Don't arm the timer before sysfs operations which are essential for a subtest. v2

[Intel-gfx] [PATCH i-g-t v5 19/21] tests/core_hotunplug: Duplicate debug messages in dmesg

The purpose of debug messages displayed by the test is to make identification of a subtest phase that fails more easy. Since issues exhibited by the test are mostly reported to dmesg, print those debug messages to /dev/kmsg as well. v2: Rebase on upstream. v3: Refresh. v4: Refresh. Signed-off-by

[Intel-gfx] [PATCH i-g-t v5 16/21] tests/core_hotunplug: Explicitly ignore unused return values

Some return values are not useful and can be ignored. Wrap those cases inside igt_ignore_warn(), not only to make sure compilers are happy but also to clearly document our decisions. Signed-off-by: Janusz Krzysztofik Reviewed-by: Michał Winiarski --- tests/core_hotunplug.c | 6 +++--- 1 file c

[Intel-gfx] [PATCH i-g-t v5 09/21] tests/core_hotunplug: Prepare invariant data once per test run

Each subtest now calls a prepare() helper which opens a couple of files required by that subtest. Those files are then closed after use, either directly from the subtest body, or indirectly from inside one of helper functions called during the subtest execution. That approach not only makes life

[Intel-gfx] [PATCH i-g-t v5 18/21] tests/core_hotunplug: Add 'lateclose before restore' variants

If a GPU gets wedged during driver rebind or device re-plug for some reason, current hotunbind/hotunplug test variants may time out before lateclose phase, resulting in incomplete CI reports. Add new test variants which close the device before restoring it. Also rename old variants to more adequa

[Intel-gfx] [PATCH i-g-t v5 20/21] tests/core_hotunplug: HSW audio issue workaround

Unbinding the i915 driver on some Haswell platforms with Azalia audio results in a kernel WARNING on "i915 raw-wakerefs=1 wakelocks=1 on cleanup". The issue can be worked around by manually enabling runtime power management for the conflicting audio adapter. Use that method but also display a war

[Intel-gfx] [PATCH i-g-t v5 03/21] tests/core_hotunplug: Clean up device open error handling

We don't use drm_driver_open() since in case of an i915 device it keeps an extra file descriptor of the exercised device open for exit handler use, while we would like to be able to close the device completely before running certain test operations. Instead, we call __drm_driver_open() and handle

[Intel-gfx] [PATCH i-g-t v5 21/21] tests/core_hotunplug: Un-blocklist *bind* subtests

Subtests which don't remove the device, only unbind the driver from it, seem relatively safe and harmless for CI. Remove them from the CI blocklist. Signed-off-by: Janusz Krzysztofik --- tests/intel-ci/blacklist.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/intel

[Intel-gfx] [PATCH i-g-t v5 17/21] tests/core_hotunplug: More thorough i915 healthcheck and recovery

The test now assumes the i915 driver is able to identify potential hardware or driver issues while rebinding to a device and indicate them by marking the GPU wedged. Should that assumption occur wrong, the health check phase of the test would happily succeed while potentially leaving the device in

[Intel-gfx] [PATCH i-g-t v5 12/21] tests/core_hotunplug: Fail subtests on device close errors

Since health checks are now run from follow-up fixture sections, it is safe to fail subtests without the need to abort the test execution. Do that on device close errors instead of just emitting warnings. v2: Rebase only. v3: Refresh. v4: Refresh. Signed-off-by: Janusz Krzysztofik Reviewed-by:

[Intel-gfx] [PATCH i-g-t v5 07/21] tests/core_hotunplug: Pass errors via a data structure field

A pointer to fatal error messages can be passed around via hotunplug structure, no need to declare it as global. v2: Rebase only. v3: Refresh. Signed-off-by: Janusz Krzysztofik Reviewed-by: Michał Winiarski --- tests/core_hotunplug.c | 96 +- 1 file chan

[Intel-gfx] [PATCH i-g-t v5 15/21] tests/core_hotunplug: Assert expected device presence/absence

Don't rely on successful write to sysfs control files, assert existence / non-existence of a respective device sysfs node as well. Signed-off-by: Janusz Krzysztofik Reviewed-by: Michał Winiarski --- tests/core_hotunplug.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/tests

[Intel-gfx] [PATCH i-g-t v5 10/21] tests/core_hotunplug: Skip selectively on sysfs close errors

Since we no longer open a device DRM sysfs node, only a PCI one, driver unbind operations are no longer affected by missed or unsuccessful sysfs file close attempts. Skip only affected subtests if that happens. v2: Rebase only. v3: Refresh. v4: Refresh. Signed-off-by: Janusz Krzysztofik Reviewe

[Intel-gfx] [PATCH i-g-t v5 11/21] tests/core_hotunplug: Recover from subtest failures

Subtests now forcibly call or request igt_abort on failures in order to avoid silently leaving an exercised device in an unusable state. However, a failure inside a subtest doesn't always mean the device is no longer working correctly and reboot is needed. On the other hand, if a subtest just fail

[Intel-gfx] [PATCH i-g-t v5 06/21] tests/core_hotunplug: Maintain a single data structure instance

The following changes to the test are planned: - avoid global variables if possible, - prepare invariant data only once per test run, - skip subsequent subtests after device close errors, - allow subtests to fail on errors and try to recover from those failures in follow up igt dixture sections i

[Intel-gfx] [PATCH i-g-t v5 14/21] tests/core_hotunplug: Process return values of sysfs operations

Return values of driver bind/unbind / device remove/recover sysfs operations are now ignored. Assert their correctness. v2: Add trailing newlines missing from igt_assert messages. Signed-off-by: Janusz Krzysztofik Reviewed-by: Michał Winiarski --- tests/core_hotunplug.c | 14 ++ 1

[Intel-gfx] [PATCH i-g-t v5 00/21] tests/core_hotunplug: Fixes and enhancements

Clean up the test code, add some new basic subtests, then unblock unbind test variants. No incompletes / aborts have been reported by Trybot this time. Series changelog: v2: New patch "Un-blocklist *bind* subtests added. v3: Patch "Follow failed subtests with healthcheck" renamed to "Recover

[Intel-gfx] [PATCH i-g-t v5 08/21] tests/core_hotunplug: Handle device close errors

The test now ignores device close errors. Those errors are believed to have no influence on device health so there is no need to process them the same way as we mostly do on errors, i.e., notify CI about a problem via igt_abort. However, those errors may indicate issues with the test itself. Mor

[Intel-gfx] [PATCH i-g-t v5 01/21] tests/core_hotunplug: Use igt_assert_fd()

There is a new library helper that asserts validity of open file descriptors. Use it instead of open coding. Signed-off-by: Janusz Krzysztofik Reviewed-by: Michał Winiarski --- tests/core_hotunplug.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/core_hotu

[Intel-gfx] [PATCH i-g-t v5 05/21] tests/core_hotunplug: Assert successful device filter application

Return value of igt_device_filter_add() representing a number of successfully installed device filters is now ignored. Fail if not 1. Signed-off-by: Janusz Krzysztofik Reviewed-by: Michał Winiarski --- tests/core_hotunplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t

[Intel-gfx] [PATCH i-g-t v5 04/21] tests/core_hotunplug: Consolidate duplicated debug messages

Some debug messages which designate specific test operations, or their greater parts at least, sound always the same, no matter which subtest they are called from. Emit them, possibly updated with subtest specified modifiers, from inside respective helpers instead of duplicating them in subtest bo

[Intel-gfx] [PATCH i-g-t v5 02/21] tests/core_hotunplug: Constify dev_bus_addr string

Device bus address structure field is always initialized with a pointer to a substring of the device sysfs path and never used for its modification. Declare it as a constant string. Signed-off-by: Janusz Krzysztofik Reviewed-by: Michał Winiarski --- tests/core_hotunplug.c | 2 +- 1 file change

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/opregion: add support for mailbox #5 EDID

== Series Details == Series: series starting with [1/2] drm/i915/opregion: add support for mailbox #5 EDID URL : https://patchwork.freedesktop.org/series/81121/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8937 -> Patchwork_18418 =