On 8/14/2020 5:36 PM, Chang, Bruce wrote:
@@ -2498,9 +2498,22 @@ invalidate_csb_entries(const u64 *first,
const u64 *last)
*/
static inline bool gen12_csb_parse(const u64 *csb)
{
- u64 entry = READ_ONCE(*csb);
- bool ctx_away_valid = GEN12_CSB_CTX_VALID(upper_32_bits(entry));
On Thu, Aug 13, 2020 at 01:00:28PM -0700, José Roberto de Souza wrote:
> Fixes around DC5, DC6 and DC3CO in those new firmwares.
>
> Signed-off-by: José Roberto de Souza
Reviewed-by: Matt Roper
for both patches in this series.
Matt
> ---
> drivers/gpu/drm/i915/display/intel_csr.c | 8 -
== Series Details ==
Series: PR for new i915 firmware files
URL : https://patchwork.freedesktop.org/series/80637/
State : failure
== Summary ==
Applying: PR for new i915 firmware files
error: sha1 information is lacking or useless (WHENCE).
error: could not build fake ancestor
hint: Use 'git a
The following changes since commit c331aa9c49ce507d4e5a9a4f2f19115db8e15536:
amdgpu: update vega20 firmware for 20.30 (2020-08-07 08:16:21 -0400)
are available in the Git repository at:
git://anongit.freedesktop.org/drm/drm-firmware i915-firmware-updates-08-2020
for you to fetch changes up
== Series Details ==
Series: series starting with [1/2] drm/i915: Update TGL and RKL DMC firmware
versions (rev2)
URL : https://patchwork.freedesktop.org/series/80610/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8882_full -> Patchwork_18360_full
@@ -2498,9 +2498,22 @@ invalidate_csb_entries(const u64 *first, const u64 *last)
*/
static inline bool gen12_csb_parse(const u64 *csb)
{
- u64 entry = READ_ONCE(*csb);
- bool ctx_away_valid = GEN12_CSB_CTX_VALID(upper_32_bits(entry));
- bool new_queue =
+ bool ctx_away
== Series Details ==
Series: series starting with [1/2] drm/i915: Update TGL and RKL DMC firmware
versions (rev2)
URL : https://patchwork.freedesktop.org/series/80610/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8882 -> Patchwork_18360
==
== Series Details ==
Series: PR for new firmwares v3
URL : https://patchwork.freedesktop.org/series/80635/
State : failure
== Summary ==
Applying: PR for new firmwares v3
error: sha1 information is lacking or useless (WHENCE).
error: could not build fake ancestor
hint: Use 'git am --show-curre
The following changes since commit c331aa9c49ce507d4e5a9a4f2f19115db8e15536:
amdgpu: update vega20 firmware for 20.30 (2020-08-07 08:16:21 -0400)
are available in the Git repository at:
git://anongit.freedesktop.org/drm/drm-firmware i915-firmware-updates-08-2020
for you to fetch changes up
Quoting Chris Wilson (2020-08-14 20:41:32)
> Quoting Mika Kuoppala (2020-08-14 19:41:14)
> > Chris Wilson writes:
> > > - entry = READ_ONCE(*csb);
> > > - if (unlikely(entry == -1)) {
> > > - preempt_disable();
> > > - if (wait_for_atomic_us((entry = READ_ONCE(*csb)
On Fri, Aug 14, 2020 at 5:38 AM Daniel Vetter wrote:
>
> This fell off in the conversion in
>
> commit 9bcaa3fe58ab7559e71df798bcff6e0795158695
> Author: Michal Orzel
> Date: Tue Apr 28 19:10:04 2020 +0200
>
> drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_*
> helpers
>
Quoting Mika Kuoppala (2020-08-14 19:29:03)
> Chris Wilson writes:
>
> > A CSB entry is 64b, and it is simpler for us to treat it as an array of
> > 64b entries than as an array of pairs of 32b entries.
> >
> > Signed-off-by: Chris Wilson
> > Cc: Mika Kuoppala
> > ---
> > drivers/gpu/drm/i915/
Quoting Mika Kuoppala (2020-08-14 19:41:14)
> Chris Wilson writes:
>
> > Since we expect to inline the csb_parse() routines, the w/a for the
> > stale CSB data on Tigerlake will be pulled into process_csb(), and so we
> > might as well simply reuse the logic for all, and so will hopefully
> > avo
Chris Wilson writes:
> Since we expect to inline the csb_parse() routines, the w/a for the
> stale CSB data on Tigerlake will be pulled into process_csb(), and so we
> might as well simply reuse the logic for all, and so will hopefully
> avoid any strange behaviour on Icelake that was not covered
Quoting Chang, Bruce (2020-08-14 19:07:53)
> On 8/14/2020 8:57 AM, Chris Wilson wrote:
> > On Tigerlake, we are seeing a repeat of commit d8f505311717 ("drm/i915/icl:
> > Forcibly evict stale csb entries") where, presumably, due to a missing
> > Global Observation Point synchronisation, the write p
Chris Wilson writes:
> A CSB entry is 64b, and it is simpler for us to treat it as an array of
> 64b entries than as an array of pairs of 32b entries.
>
> Signed-off-by: Chris Wilson
> Cc: Mika Kuoppala
> ---
> drivers/gpu/drm/i915/gt/intel_engine_types.h | 2 +-
> drivers/gpu/drm/i915/gt/int
On 8/14/2020 8:57 AM, Chris Wilson wrote:
Since we expect to inline the csb_parse() routines, the w/a for the
stale CSB data on Tigerlake will be pulled into process_csb(), and so we
might as well simply reuse the logic for all, and so will hopefully
avoid any strange behaviour on Icelake that wa
On 8/14/2020 8:57 AM, Chris Wilson wrote:
On Tigerlake, we are seeing a repeat of commit d8f505311717 ("drm/i915/icl:
Forcibly evict stale csb entries") where, presumably, due to a missing
Global Observation Point synchronisation, the write pointer of the CSB
ringbuffer is updated _prior_ to the
== Series Details ==
Series: series starting with [1/3] drm/i915/gt: Widen CSB pointer to u64 for
the parsers
URL : https://patchwork.freedesktop.org/series/80627/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8882_full -> Patchwork_18358_full
== Series Details ==
Series: series starting with [1/3] drm/i915/gt: Widen CSB pointer to u64 for
the parsers
URL : https://patchwork.freedesktop.org/series/80627/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8882 -> Patchwork_18358
==
== Series Details ==
Series: series starting with [1/3] drm/i915/gt: Widen CSB pointer to u64 for
the parsers
URL : https://patchwork.freedesktop.org/series/80627/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be chec
== Series Details ==
Series: series starting with [1/3] drm/i915/gt: Widen CSB pointer to u64 for
the parsers
URL : https://patchwork.freedesktop.org/series/80627/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
1c6a740de44a drm/i915/gt: Widen CSB pointer to u64 for the parsers
A CSB entry is 64b, and it is simpler for us to treat it as an array of
64b entries than as an array of pairs of 32b entries.
Signed-off-by: Chris Wilson
Cc: Mika Kuoppala
---
drivers/gpu/drm/i915/gt/intel_engine_types.h | 2 +-
drivers/gpu/drm/i915/gt/intel_lrc.c | 33 ++-
Since we expect to inline the csb_parse() routines, the w/a for the
stale CSB data on Tigerlake will be pulled into process_csb(), and so we
might as well simply reuse the logic for all, and so will hopefully
avoid any strange behaviour on Icelake that was not covered by our
previous w/a.
Referenc
On Tigerlake, we are seeing a repeat of commit d8f505311717 ("drm/i915/icl:
Forcibly evict stale csb entries") where, presumably, due to a missing
Global Observation Point synchronisation, the write pointer of the CSB
ringbuffer is updated _prior_ to the contents of the ringbuffer. That is
we see t
On 2020-08-14 at 08:19:50 +0530, Nischal Varide wrote:
> ---
> drivers/gpu/drm/i915/display/intel_combo_phy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c
> b/drivers/gpu/drm/i915/display/intel_combo_phy.c
> index eccaa79
> -Original Message-
> From: Intel-gfx On Behalf Of Nischal
> Varide
> Sent: Friday, August 14, 2020 8:20 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: Varide, Nischal
> Subject: [Intel-gfx] [PATCH 1/8] Critical KlockWork Error - Fixes -
> intel_cdclk.c -
> Possible NullPointerDerefe
> -Original Message-
> From: Intel-gfx On Behalf Of
> Patchwork
> Sent: Friday, August 14, 2020 3:44 PM
> To: Varide, Nischal
> Cc: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with
> [1/8]
> Critical KlockWork Error - Fixes -
== Series Details ==
Series: drm/modeset-lock: Take the modeset BKL for legacy drivers
URL : https://patchwork.freedesktop.org/series/80620/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8882_full -> Patchwork_18356_full
Su
== Series Details ==
Series: series starting with [1/8] Critical KlockWork Error - Fixes -
intel_cdclk.c - Possible NullPointerDereference1
URL : https://patchwork.freedesktop.org/series/80622/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8882 -> Patchwork_18357
== Series Details ==
Series: series starting with [1/8] Critical KlockWork Error - Fixes -
intel_cdclk.c - Possible NullPointerDereference1
URL : https://patchwork.freedesktop.org/series/80622/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
b5bd9c17f5da Critical KlockWork Error
== Series Details ==
Series: series starting with [1/8] Critical KlockWork Error - Fixes -
intel_cdclk.c - Possible NullPointerDereference1
URL : https://patchwork.freedesktop.org/series/80622/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode u
== Series Details ==
Series: drm/modeset-lock: Take the modeset BKL for legacy drivers
URL : https://patchwork.freedesktop.org/series/80620/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8882 -> Patchwork_18356
Summary
== Series Details ==
Series: drm/modeset-lock: Take the modeset BKL for legacy drivers
URL : https://patchwork.freedesktop.org/series/80620/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
4be15a75c756 drm/modeset-lock: Take the modeset BKL for legacy drivers
-:8: ERROR:GIT_COMMI
---
drivers/gpu/drm/i915/display/intel_combo_phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c
b/drivers/gpu/drm/i915/display/intel_combo_phy.c
index eccaa79cb4a9..6e721b8ed611 100644
--- a/drivers/gpu/drm/i915/display/intel_c
---
drivers/gpu/drm/i915/display/intel_atomic.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_atomic.c
b/drivers/gpu/drm/i915/display/intel_atomic.c
index 630f49b7aa01..49ca65b207df 100644
--- a/drivers/gpu/drm/i915/display/intel_atomic.c
+++ b/drivers/g
---
drivers/gpu/drm/i915/display/intel_tv.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_tv.c
b/drivers/gpu/drm/i915/display/intel_tv.c
index 777032d9697b..862ea94ffdae 100644
--- a/drivers/gpu/drm/i915/display/intel_tv.c
+++
---
drivers/gpu/drm/i915/display/intel_cdclk.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c
b/drivers/gpu/drm/i915/display/intel_cdclk.c
index 9d6cacbdb691..1cd0ab5b36d2 100644
--- a/drivers/gpu/drm/i915/display/
---
drivers/gpu/drm/i915/display/intel_display_power.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c
b/drivers/gpu/drm/i915/display/intel_display_power.c
index 7946c6af4b1e..9530f6e0b10c 100644
--- a/drivers/gpu/drm/i915/display/intel_di
---
drivers/gpu/drm/i915/display/intel_display.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c
b/drivers/gpu/drm/i915/display/intel_display.c
index 2ddabf92adde..30d189094e97 100644
--- a/drivers/gpu/drm/i915/display/intel_d
---
drivers/gpu/drm/i915/display/intel_sdvo.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c
b/drivers/gpu/drm/i915/display/intel_sdvo.c
index 2da4388e1540..279b2be958bb 100644
--- a/drivers/gpu/drm/i915/display/intel_sdvo.c
+++ b/drivers/gpu/drm/
---
drivers/gpu/drm/i915/display/intel_fbdev.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c
b/drivers/gpu/drm/i915/display/intel_fbdev.c
index bd39eb6a21b8..ec4f82559fc1 100644
--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
This fell off in the conversion in
commit 9bcaa3fe58ab7559e71df798bcff6e0795158695
Author: Michal Orzel
Date: Tue Apr 28 19:10:04 2020 +0200
drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* helpers
but it's caught by the drm_warn_on_modeset_not_all_locked() that the
le
43 matches
Mail list logo
