Re: [Intel-gfx] [PATCH v13 00/11] Convert PWM period and duty cycle to u64

2020-04-23 Thread Lee Jones
On Tue, 21 Apr 2020, Guru Das Srinagesh wrote: > [REQUEST] > > Would it be possible for the patches that have already received Acked-by's in > this series to be accepted and applied to the tree? I lost an Acked-by (in > intel-panel.c) because it had a merge conflict with a new change that came in

Re: [Intel-gfx] [PATCH v13 00/11] Convert PWM period and duty cycle to u64

2020-04-23 Thread Lee Jones
On Thu, 23 Apr 2020, Guru Das Srinagesh wrote: > On Thu, Apr 23, 2020 at 12:48:57PM +0100, Lee Jones wrote: > > What's the merge plan for this set? > > I'm not sure what you mean. My assumption is that first all the patches > need to get an Acked-by and only then will the series get applied by >

Re: [Intel-gfx] [PATCH v13 00/11] Convert PWM period and duty cycle to u64

2020-04-23 Thread Lee Jones
On Thu, 23 Apr 2020, Guru Das Srinagesh wrote: > On Thu, Apr 23, 2020 at 12:48:57PM +0100, Lee Jones wrote: > > What's the merge plan for this set? > > I'm not sure what you mean. My assumption is that first all the patches > need to get an Acked-by and only then will the series get applied by >

Re: [Intel-gfx] [PATCH v13 01/11] drm/i915: Use 64-bit division macro

2020-04-23 Thread Jani Nikula
On Tue, 21 Apr 2020, Guru Das Srinagesh wrote: > Since the PWM framework is switching struct pwm_state.duty_cycle's > datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL > to handle a 64-bit dividend. > > To: Jani Nikula > Cc: Joonas Lahtinen > Cc: David Airlie > Cc: Daniel V

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add engine scratch register to live_lrc_fixed

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915: Add engine scratch register to live_lrc_fixed URL : https://patchwork.freedesktop.org/series/76415/ State : success == Summary == CI Bug Log - changes from CI_DRM_8357_full -> Patchwork_17450_full Summ

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add engine scratch register to live_lrc_fixed

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915: Add engine scratch register to live_lrc_fixed URL : https://patchwork.freedesktop.org/series/76415/ State : success == Summary == CI Bug Log - changes from CI_DRM_8357 -> Patchwork_17450 Summary --

[Intel-gfx] [PATCH i-g-t v8 4/4] kms_writeback: Add writeback-check-output

2020-04-23 Thread Rodrigo Siqueira
From: Brian Starkey Add a test which makes commits using the writeback connector, and checks the output buffer hash to make sure it is/isn't written as appropriate. Changes since V7 (Maxime Ripard): * Make fb_fill cross-platform Changes since v6 (Simon Ser): * Add a descriptive error message if

[Intel-gfx] [PATCH i-g-t v8 2/4] kms_writeback: Add initial writeback tests

2020-04-23 Thread Rodrigo Siqueira
From: Brian Starkey Add tests for the WRITEBACK_PIXEL_FORMATS, WRITEBACK_OUT_FENCE_PTR and WRITEBACK_FB_ID properties on writeback connectors, ensuring their behaviour is correct. Changes since V7 (Maxime Ripard and Petri Latvala): * Utilizes `to_user_pointer` to avoid cast compilation error on

[Intel-gfx] [PATCH i-g-t v8 3/4] lib: Add function to hash a framebuffer

2020-04-23 Thread Rodrigo Siqueira
From: Brian Starkey To use writeback buffers as a CRC source, we need to be able to hash them. Implement a simple FVA-1a hashing routine for this purpose. Doing a bytewise hash on the framebuffer directly can be very slow if the memory is noncached. By making a copy of each line in the FB first

[Intel-gfx] [PATCH i-g-t v8 1/4] lib/igt_kms: Add writeback support

2020-04-23 Thread Rodrigo Siqueira
From: Brian Starkey Add support in igt_kms for writeback connectors, with the ability to attach framebuffers. v5: Rebase and add DRM_CLIENT_CAP_WRITEBACK_CONNECTORS before drmModeGetResources() Signed-off-by: Brian Starkey [rebased and updated to the latest igt style] Signed-off-by: Liviu Duda

[Intel-gfx] [PATCH i-g-t v8 0/4] Add support for testing writeback connectors

2020-04-23 Thread Rodrigo Siqueira
Hi, A couple of months ago, I updated and re-submitted a patchset made by Brian Starkey and Liviu Dudau for adding a writeback connectors test to IGT. It is important to highlight that DRM already have writeback connectors support, which is a way to expose in DRM the hardware functionality from di

[Intel-gfx] [PATCH] drm/i915: Add engine scratch register to live_lrc_fixed

2020-04-23 Thread Chris Wilson
From: Mika Kuoppala General purpose registers are per engine and in a fixed location. Add to live_lrc_fixed. Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_lrc.c| 12 drivers/gpu/drm/i915/gt/selftest_lrc.c

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Add context batchbuffers registers to live_lrc_fixed (rev4)

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Add context batchbuffers registers to live_lrc_fixed (rev4) URL : https://patchwork.freedesktop.org/series/76407/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8354 -> Patchwork_17449 ===

[Intel-gfx] [PATCH] drm/i915/selftests: Add context batchbuffers registers to live_lrc_fixed

2020-04-23 Thread Chris Wilson
From: Mika Kuoppala Add per ctx bb and indirect ctx bb register locations to live_lrc_fixed for verification. Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_lrc.c | 128 ++-- drivers/gpu/drm/i915/gt

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Add context batchbuffers registers to live_lrc_fixed (rev3)

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Add context batchbuffers registers to live_lrc_fixed (rev3) URL : https://patchwork.freedesktop.org/series/76407/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8354 -> Patchwork_17448 ===

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/edid: Fix off-by-one in DispID DTD pixel clock

2020-04-23 Thread Patchwork
== Series Details == Series: drm/edid: Fix off-by-one in DispID DTD pixel clock URL : https://patchwork.freedesktop.org/series/76399/ State : success == Summary == CI Bug Log - changes from CI_DRM_8352_full -> Patchwork_17442_full Summary -

Re: [Intel-gfx] [PATCH v13 00/11] Convert PWM period and duty cycle to u64

2020-04-23 Thread Guru Das Srinagesh
On Thu, Apr 23, 2020 at 12:48:57PM +0100, Lee Jones wrote: > What's the merge plan for this set? I'm not sure what you mean. My assumption is that first all the patches need to get an Acked-by and only then will the series get applied by Thierry... Could Thierry or Uwe weigh in on this point pleas

[Intel-gfx] [PATCH] drm/i915/selftests: Add context batchbuffers registers to live_lrc_fixed

2020-04-23 Thread Chris Wilson
From: Mika Kuoppala Add per ctx bb and indirect ctx bb register locations to live_lrc_fixed for verification. Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_lrc.c | 128 ++-- drivers/gpu/drm/i915/gt

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid: Fix off-by-one in DispID DTD pixel clock

2020-04-23 Thread Patchwork
== Series Details == Series: drm/edid: Fix off-by-one in DispID DTD pixel clock URL : https://patchwork.freedesktop.org/series/76399/ State : success == Summary == CI Bug Log - changes from CI_DRM_8352 -> Patchwork_17442 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Add context batchbuffers registers to live_lrc_fixed (rev2)

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Add context batchbuffers registers to live_lrc_fixed (rev2) URL : https://patchwork.freedesktop.org/series/76407/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8354 -> Patchwork_17447 ===

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/icl+: Prevent using non-TypeC AUX channels on TypeC ports

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915/icl+: Prevent using non-TypeC AUX channels on TypeC ports URL : https://patchwork.freedesktop.org/series/76405/ State : success == Summary == CI Bug Log - changes from CI_DRM_8354_full -> Patchwork_17444_full ===

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Add request throughput measurement to perf

2020-04-23 Thread Andi Shyti
Hi Chris, > > > +static int s_many(void *arg) > > > +{ > > > + struct perf_series *ps = arg; > > > > why do we need to go through void... all functions are taking a > > perf_series structure. > > The kthread API defines the function pointer as int (*fn)(void *arg); In the parallel tes, not

[Intel-gfx] [PATCH] drm/i915/selftests: Add context batchbuffers registers to live_lrc_fixed

2020-04-23 Thread Chris Wilson
From: Mika Kuoppala Add per ctx bb and indirect ctx bb register locations to live_lrc_fixed for verification. Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_lrc.c | 110 drivers/gpu/drm/i915/gt

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Add context batchbuffers registers to live_lrc_fixed

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Add context batchbuffers registers to live_lrc_fixed URL : https://patchwork.freedesktop.org/series/76407/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8354 -> Patchwork_17446 ===

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/6] drm/i915: Add engine scratch register to live_lrc_fixed

2020-04-23 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Add engine scratch register to live_lrc_fixed URL : https://patchwork.freedesktop.org/series/76406/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8354 -> Patchwork_17445

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/6] drm/i915: Add engine scratch register to live_lrc_fixed

2020-04-23 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Add engine scratch register to live_lrc_fixed URL : https://patchwork.freedesktop.org/series/76406/ State : warning == Summary == $ dim checkpatch origin/drm-tip 56bad9b0154e drm/i915: Add engine scratch register to live_lrc_fi

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl+: Prevent using non-TypeC AUX channels on TypeC ports

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915/icl+: Prevent using non-TypeC AUX channels on TypeC ports URL : https://patchwork.freedesktop.org/series/76405/ State : success == Summary == CI Bug Log - changes from CI_DRM_8354 -> Patchwork_17444 Sum

[Intel-gfx] [PULL] drm-intel-fixes

2020-04-23 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2020-04-23: - Tigerlake Workaround - disabling media recompression (Matt) - Fix RPS interrupts for right GPU frequency (Chris) - HDCP fix prime check (Oliver) - Tigerlake Thunderbolt power well fix (Matt) - Tigerlake DP link training fixes (Jose) - Do

Re: [Intel-gfx] [PATCH v3 3/6] drm/i915: Use drm_rect to store the pfit window pos/size

2020-04-23 Thread Manasi Navare
On Thu, Apr 23, 2020 at 06:38:46PM +0300, Ville Syrjälä wrote: > On Wed, Apr 22, 2020 at 12:20:06PM -0700, Manasi Navare wrote: > > On Wed, Apr 22, 2020 at 07:19:14PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Make things a bit more abstract by replacing the pch_pfit.pos/si

Re: [Intel-gfx] [PATCH] drm/edid: Fix off-by-one in DispID DTD pixel clock

2020-04-23 Thread Manasi Navare
On Thu, Apr 23, 2020 at 06:17:43PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > The DispID DTD pixel clock is documented as: > "00 00 00 h → FF FF FF h | Pixel clock ÷ 10,000 0.01 → 167,772.16 Mega Pixels > per Sec" > Which seems to imply that we to add one to the raw value. > > Realit

[Intel-gfx] [PATCH 2/6] drm/i915: Add context batchbuffers to live_lrc_fixed

2020-04-23 Thread Mika Kuoppala
Add per ctx bb and indirect ctx bb to a live_lrc_fixed. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_lrc.c | 14 +- drivers/gpu/drm/i915/gt/intel_lrc_reg.h | 14 ++ drivers/gpu/drm/i915/gt/selftest_lrc.c | 15 +++ 3 files changed, 30 ins

[Intel-gfx] [PATCH] drm/i915/selftests: Add context batchbuffers registers to live_lrc_fixed

2020-04-23 Thread Chris Wilson
From: Mika Kuoppala Add per ctx bb and indirect ctx bb register locations to live_lrc_fixed for verification. Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_lrc.c | 110 drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH 5/6] drm/i915: Add live selftests for indirect ctx batchbuffers

2020-04-23 Thread Mika Kuoppala
Indirect ctx batchbuffers are a hw feature of which batch can be run, by hardware, during context restoration stage. Driver can setup a batchbuffer and also an offset into the context image. When context image is marshalled from memory to registers, and when the offset from the start of context reg

[Intel-gfx] [PATCH 3/6] drm/i915: Make define for lrc state offset

2020-04-23 Thread Mika Kuoppala
More often than not, we need a byte offset into lrc register state from the start of the hw state. Make it so. Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_context_sseu.c | 3 +-- drivers/gpu/drm/i915/gt/intel_lrc.c | 8 drivers/gp

[Intel-gfx] [PATCH 1/6] drm/i915: Add engine scratch register to live_lrc_fixed

2020-04-23 Thread Mika Kuoppala
General purpose registers are per engine and in a fixed location. Add to live_lrc_fixed. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_lrc_reg.h | 1 + drivers/gpu/drm/i915/gt/selftest_lrc.c | 5 + 2 files changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel

[Intel-gfx] [PATCH 4/6] drm/i915: Add per ctx batchbuffer wa for timestamp

2020-04-23 Thread Mika Kuoppala
Restoration of a previous timestamp can collide with updating the timestamp, causing a value corruption. Combat this issue by using indirect ctx bb to modify the context image during restoring process. We can preload value into scratch register. From which we then do the actual write with LRR. LR

[Intel-gfx] [PATCH 6/6] drm/i915: Use indirect ctx bb to mend CMD_BUF_CCTL

2020-04-23 Thread Mika Kuoppala
Use indirect ctx bb to load cmd buffer control value from context image to avoid corruption. v2: add to lrc layout (Chris) v3: end to a cacheline (Chris) Testcase: igt/i915_selftest/gt_lrc Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_lrc.c | 99 - d

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Verify context isolation (rev5)

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Verify context isolation (rev5) URL : https://patchwork.freedesktop.org/series/76339/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8353_full -> Patchwork_17443_full Summary

[Intel-gfx] [PATCH] drm/i915/icl+: Prevent using non-TypeC AUX channels on TypeC ports

2020-04-23 Thread Imre Deak
Using an AUX channel which by default belongs to a non-TypeC PHY won't work on a TypeC PHY, since - as a side-effect besides providing an AUX channel - the AUX channel power well affects power manangement specific to the TypeC subsystem. Using a TypeC AUX channel on a non-TypeC PHY would probably a

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Verify context isolation (rev5)

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Verify context isolation (rev5) URL : https://patchwork.freedesktop.org/series/76339/ State : success == Summary == CI Bug Log - changes from CI_DRM_8353 -> Patchwork_17443 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Show per-engine default property values in sysfs

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915: Show per-engine default property values in sysfs URL : https://patchwork.freedesktop.org/series/76396/ State : success == Summary == CI Bug Log - changes from CI_DRM_8352_full -> Patchwork_17441_full S

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Verify context isolation (rev5)

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Verify context isolation (rev5) URL : https://patchwork.freedesktop.org/series/76339/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0b8abccda505 drm/i915/selftests: Verify context isolation -:345: WARNING:LINE_SPACING: Missing a

Re: [Intel-gfx] [CI 2/2] drm/i915/gt: Warn more clearly if the context state is still pinned

2020-04-23 Thread Tvrtko Ursulin
On 23/04/2020 16:17, Chris Wilson wrote: Quoting Chris Wilson (2020-04-23 16:16:09) Quoting Tvrtko Ursulin (2020-04-23 15:47:58) On 23/04/2020 09:59, Chris Wilson wrote: When recording the default context state, we submit an ordinary context and then steal the context image for our defaults

[Intel-gfx] [PULL] drm-misc-fixes

2020-04-23 Thread Maxime Ripard
Hi, Here is this week (and the first) drm-misc-fixes PR. Maxime drm-misc-fixes-2020-04-23: A few resources-related fixes (tidss, dp_mst, scheduler), probe fixes and DT bindings adjustments. The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f3136: Linux 5.7-rc1 (2020-04-12

Re: [Intel-gfx] [PATCH hmm 0/5] Adjust hmm_range_fault() API

2020-04-23 Thread Ralph Campbell
On 4/21/20 5:21 PM, Jason Gunthorpe wrote: From: Jason Gunthorpe The API is a bit complicated for the uses we actually have, and disucssions for simplifying have come up a number of times. This small series removes the customizable pfn format and simplifies the return code of hmm_range_fault

Re: [Intel-gfx] [PATCH v13 00/11] Convert PWM period and duty cycle to u64

2020-04-23 Thread Guru Das Srinagesh
On Wed, Apr 22, 2020 at 09:49:34AM +0100, Daniel Thompson wrote: > On Tue, Apr 21, 2020 at 07:57:12PM -0700, Guru Das Srinagesh wrote: > > [REQUEST] > > > > Would it be possible for the patches that have already received Acked-by's > > in > > this series to be accepted and applied to the tree? I

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/edid: Fix off-by-one in DispID DTD pixel clock

2020-04-23 Thread Patchwork
== Series Details == Series: drm/edid: Fix off-by-one in DispID DTD pixel clock URL : https://patchwork.freedesktop.org/series/76399/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8352 -> Patchwork_17442 Summary ---

[Intel-gfx] [PATCH] drm/i915/selftests: Verify context isolation

2020-04-23 Thread Chris Wilson
No unprivileged context should ever be allowed to modify logical state that is visible to another; there should be no backchannels available or control leakage for malicious actors. This test tries to write to a set of random registers using non-privileged instructions (ala userspace). It should o

Re: [Intel-gfx] [PATCH v3 3/6] drm/i915: Use drm_rect to store the pfit window pos/size

2020-04-23 Thread Ville Syrjälä
On Wed, Apr 22, 2020 at 12:20:06PM -0700, Manasi Navare wrote: > On Wed, Apr 22, 2020 at 07:19:14PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Make things a bit more abstract by replacing the pch_pfit.pos/size > > raw register values with a drm_rect. Makes it slighly more conveni

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: Fix off-by-one in DispID DTD pixel clock

2020-04-23 Thread Patchwork
== Series Details == Series: drm/edid: Fix off-by-one in DispID DTD pixel clock URL : https://patchwork.freedesktop.org/series/76399/ State : warning == Summary == $ dim checkpatch origin/drm-tip 72984b49da56 drm/edid: Fix off-by-one in DispID DTD pixel clock -:10: WARNING:COMMIT_LOG_LONG_LINE

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Show per-engine default property values in sysfs

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915: Show per-engine default property values in sysfs URL : https://patchwork.freedesktop.org/series/76396/ State : success == Summary == CI Bug Log - changes from CI_DRM_8352 -> Patchwork_17441 Summary ---

[Intel-gfx] [PATCH] drm/edid: Fix off-by-one in DispID DTD pixel clock

2020-04-23 Thread Ville Syrjala
From: Ville Syrjälä The DispID DTD pixel clock is documented as: "00 00 00 h → FF FF FF h | Pixel clock ÷ 10,000 0.01 → 167,772.16 Mega Pixels per Sec" Which seems to imply that we to add one to the raw value. Reality seems to agree as there are tiled displays in the wild which currently show a

Re: [Intel-gfx] [CI 2/2] drm/i915/gt: Warn more clearly if the context state is still pinned

2020-04-23 Thread Chris Wilson
Quoting Chris Wilson (2020-04-23 16:16:09) > Quoting Tvrtko Ursulin (2020-04-23 15:47:58) > > > > On 23/04/2020 09:59, Chris Wilson wrote: > > > When recording the default context state, we submit an ordinary context > > > and then steal the context image for our defaults. To be able to steal > >

Re: [Intel-gfx] [CI 2/2] drm/i915/gt: Warn more clearly if the context state is still pinned

2020-04-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-04-23 15:47:58) > > On 23/04/2020 09:59, Chris Wilson wrote: > > When recording the default context state, we submit an ordinary context > > and then steal the context image for our defaults. To be able to steal > > the state, we must have total ownership of the contex

Re: [Intel-gfx] [PATCH] drm/i915: Mark up racy read of rq->engine

2020-04-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-04-23 15:53:44) > > On 23/04/2020 12:58, Chris Wilson wrote: > > diff --git a/drivers/gpu/drm/i915/i915_request.c > > b/drivers/gpu/drm/i915/i915_request.c > > index 22635bbabf06..e9fd20242438 100644 > > --- a/drivers/gpu/drm/i915/i915_request.c > > +++ b/drivers/gpu/

Re: [Intel-gfx] [PATCH] drm/i915/gt: Carefully order virtual_submission_tasklet

2020-04-23 Thread Tvrtko Ursulin
On 23/04/2020 12:53, Chris Wilson wrote: During the virtual engine's submission tasklet, we take the request and insert into the submission queue on each of our siblings. This seems quite simply, and so no problems with ordering. However, the sibling execlists' submission tasklets may run concu

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Add request throughput measurement to perf

2020-04-23 Thread Chris Wilson
Quoting Andi Shyti (2020-04-23 15:18:47) > Hi Chris, > > > > > +static int s_many(void *arg) > > > > +{ > > > > + struct perf_series *ps = arg; > > > > > > why do we need to go through void... all functions are taking a > > > perf_series structure. > > > > The kthread API defines the functio

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Show per-engine default property values in sysfs

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915: Show per-engine default property values in sysfs URL : https://patchwork.freedesktop.org/series/76396/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6074c77973f3 drm/i915: Show per-engine default property values in sysfs -:124: CHECK:PAREN

Re: [Intel-gfx] [PATCH] drm/i915: Mark up racy read of rq->engine

2020-04-23 Thread Tvrtko Ursulin
On 23/04/2020 12:58, Chris Wilson wrote: As the i915_request.engine may be updated by a virtual engine to either point to the virtual engine or the real physical engine on submission, we have to be wary that the engine pointer may change. [ 213.317076] BUG: KCSAN: data-race in execlists_deque

Re: [Intel-gfx] [CI 2/2] drm/i915/gt: Warn more clearly if the context state is still pinned

2020-04-23 Thread Tvrtko Ursulin
On 23/04/2020 09:59, Chris Wilson wrote: When recording the default context state, we submit an ordinary context and then steal the context image for our defaults. To be able to steal the state, we must have total ownership of the context. During CI we want to make this error extremely obvious,

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Carefully order virtual_submission_tasklet

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915/gt: Carefully order virtual_submission_tasklet URL : https://patchwork.freedesktop.org/series/76391/ State : success == Summary == CI Bug Log - changes from CI_DRM_8352_full -> Patchwork_17438_full Summ

Re: [Intel-gfx] [CI 1/2] drm/i915/gt: Check carefully for an idle engine in wait-for-idle

2020-04-23 Thread Tvrtko Ursulin
On 23/04/2020 09:59, Chris Wilson wrote: intel_gt_wait_for_idle() tries to wait until all the outstanding requests are retired and the GPU is idle. As a side effect of retiring requests, we may submit more work to flush any pm barriers, and so the wait-for-idle tries to flush the background pm

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Add per ctx batchbuffer wa for timestamp

2020-04-23 Thread kbuild test robot
Hi Mika, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip v5.7-rc2 next-20200423] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also

[Intel-gfx] [PATCH] drm/i915: Show per-engine default property values in sysfs

2020-04-23 Thread Chris Wilson
Why? /sys/class/drm/card0/engine/rcs0/ ├── capabilities ├── class ├── .defaults │   ├── heartbeat_interval_ms │   ├── max_busywait_duration_ns │   ├── preempt_timeout_ms │   ├── stop_timeout_ms │   └── timeslice_duration_ms ├── heartbeat_interval_ms ├── instance ├── known_capabilities ├── max_busy

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Verify context isolation (rev4)

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Verify context isolation (rev4) URL : https://patchwork.freedesktop.org/series/76339/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8352 -> Patchwork_17440 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Verify context isolation (rev4)

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Verify context isolation (rev4) URL : https://patchwork.freedesktop.org/series/76339/ State : warning == Summary == $ dim checkpatch origin/drm-tip bfe16faeae8a drm/i915/selftests: Verify context isolation -:342: WARNING:LINE_SPACING: Missing a

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Mark up racy read of rq->engine

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915: Mark up racy read of rq->engine URL : https://patchwork.freedesktop.org/series/76392/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8352 -> Patchwork_17439 Summary --- **FAILURE

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/2] drm/i915/gt: Check carefully for an idle engine in wait-for-idle

2020-04-23 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/gt: Check carefully for an idle engine in wait-for-idle URL : https://patchwork.freedesktop.org/series/76384/ State : success == Summary == CI Bug Log - changes from CI_DRM_8351_full -> Patchwork_17436_full ==

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Carefully order virtual_submission_tasklet

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915/gt: Carefully order virtual_submission_tasklet URL : https://patchwork.freedesktop.org/series/76391/ State : success == Summary == CI Bug Log - changes from CI_DRM_8352 -> Patchwork_17438 Summary --

Re: [Intel-gfx] [PATCH] drm/i915/gt: Prefer soft-rc6 over RPS DOWN_TIMEOUT

2020-04-23 Thread kbuild test robot
Hi Chris, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip next-20200423] [cannot apply to v5.7-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system

[Intel-gfx] [PATCH] drm/i915/selftests: Verify context isolation

2020-04-23 Thread Chris Wilson
No unprivileged context should ever be allowed to modify logical state that is visible to another; there should be no backchannels available or control leakage for malicious actors. This test tries to write to a set of random registers using non-privileged instructions (ala userspace). It should o

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Verify context isolation (rev3)

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Verify context isolation (rev3) URL : https://patchwork.freedesktop.org/series/76339/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8351 -> Patchwork_17437 Summary ---

Re: [Intel-gfx] [PATCH v7 i-g-t 4/4] kms_writeback: Add writeback-check-output

2020-04-23 Thread Rodrigo Siqueira
On 04/22, Maxime Ripard wrote: > Hi! > > On Tue, Apr 21, 2020 at 05:07:05PM -0400, Rodrigo Siqueira wrote: > > On 04/15, Maxime Ripard wrote: > > > On Mon, Oct 21, 2019 at 10:00:39PM -0300, Brian Starkey wrote: > > > > Add a test which makes commits using the writeback connector, and > > > > check

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Verify context isolation (rev3)

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Verify context isolation (rev3) URL : https://patchwork.freedesktop.org/series/76339/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8351 -> Patchwork_17437 Summary ---

[Intel-gfx] [PATCH] drm/i915: Mark up racy read of rq->engine

2020-04-23 Thread Chris Wilson
As the i915_request.engine may be updated by a virtual engine to either point to the virtual engine or the real physical engine on submission, we have to be wary that the engine pointer may change. [ 213.317076] BUG: KCSAN: data-race in execlists_dequeue [i915] / i915_request_wait [i915] [ 213.

[Intel-gfx] [PATCH] drm/i915/gt: Carefully order virtual_submission_tasklet

2020-04-23 Thread Chris Wilson
During the virtual engine's submission tasklet, we take the request and insert into the submission queue on each of our siblings. This seems quite simply, and so no problems with ordering. However, the sibling execlists' submission tasklets may run concurrently with the virtual engine's tasklet, su

Re: [Intel-gfx] [PATCH v13 00/11] Convert PWM period and duty cycle to u64

2020-04-23 Thread Lee Jones
On Tue, 21 Apr 2020, Guru Das Srinagesh wrote: > [REQUEST] > > Would it be possible for the patches that have already received Acked-by's in > this series to be accepted and applied to the tree? I lost an Acked-by (in > intel-panel.c) because it had a merge conflict with a new change that came in

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/icl: Fix timeout handling during TypeC AUX power well enabling

2020-04-23 Thread Imre Deak
On Wed, Apr 22, 2020 at 05:55:58PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/icl: Fix timeout handling during TypeC AUX power well > enabling > URL : https://patchwork.freedesktop.org/series/76336/ > State : success Pushed, thanks for the review. > > == Summary == >

[Intel-gfx] ✓ Fi.CI.IGT: success for SAGV support for Gen12+ (rev27)

2020-04-23 Thread Patchwork
== Series Details == Series: SAGV support for Gen12+ (rev27) URL : https://patchwork.freedesktop.org/series/75129/ State : success == Summary == CI Bug Log - changes from CI_DRM_8350_full -> Patchwork_17434_full Summary --- **SUCCESS

Re: [Intel-gfx] [PATCH 2/2] drm/i915/hdmi: Add missing sequence

2020-04-23 Thread Imre Deak
On Wed, Apr 22, 2020 at 12:40:02PM -0700, José Roberto de Souza wrote: > It was missing the step 7.b - "If not type-C static connection, > configure PORT_CL_DW10 Static Power Down to power up all lanes of the > DDI". > > BSpec: 53339 > BSpec: 49191 > Signed-off-by: José Roberto de Souza > --- >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Verify context isolation (rev3)

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Verify context isolation (rev3) URL : https://patchwork.freedesktop.org/series/76339/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7d2826951e5a drm/i915/selftests: Verify context isolation -:319: WARNING:LINE_SPACING: Missing a

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915/gt: Check carefully for an idle engine in wait-for-idle

2020-04-23 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/gt: Check carefully for an idle engine in wait-for-idle URL : https://patchwork.freedesktop.org/series/76384/ State : success == Summary == CI Bug Log - changes from CI_DRM_8351 -> Patchwork_17436

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Add live selftests for indirect ctx batchbuffers

2020-04-23 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2020-04-21 14:16:31) >> Indirect ctx batchbuffers are a hw feature of which >> batch can be run, by hardware, during context restoration stage. >> Driver can setup a batchbuffer and also an offset into the >> context image. When context image is marsh

Re: [Intel-gfx] [PATCH 1/2] drm/i915/hdmi: Get digital_port only once in intel_ddi_pre_enable_hdmi()

2020-04-23 Thread Imre Deak
On Wed, Apr 22, 2020 at 12:40:01PM -0700, José Roberto de Souza wrote: > Getting it only once also removing intel_hdmi that is used only once > and can be easily accessed by dig_port->hdmi. > > Signed-off-by: José Roberto de Souza Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/display/in

[Intel-gfx] ✗ Fi.CI.BAT: failure for pci/msi: Stop warning for MSI enabling failure

2020-04-23 Thread Patchwork
== Series Details == Series: pci/msi: Stop warning for MSI enabling failure URL : https://patchwork.freedesktop.org/series/76382/ State : failure == Summary == Applying: pci/msi: Stop warning for MSI enabling failure Using index info to reconstruct a base tree... M drivers/pci/msi.c Fall

[Intel-gfx] [CI] drm/i915/selftests: Verify context isolation

2020-04-23 Thread Chris Wilson
No unprivileged context should ever be allowed to modify state that is visible to another; there should be no backchannels available or control leakage for malicious actors. This test tries to write to a set of random registers using non-privileged instructions (ala userspace). It should only be a

Re: [Intel-gfx] [i-g-t] dumb_buffer@clear_create triggers OOM since 0b0eaa353

2020-04-23 Thread Chris Wilson
Quoting Li Zhijian (2020-04-23 10:38:38) > Hi guys > > 0Day noticed that dumb_buffer@clear_create triggers OOM  since commit: > 0b0eaa353 ("tests/dumb_buffer: Try to compute the largest possible dumb > buffer") So VM_FAULT_OOM -> pagefault_out_of_memory() But a failed allocation for 2G out of

[Intel-gfx] [i-g-t] dumb_buffer@clear_create triggers OOM since 0b0eaa353

2020-04-23 Thread Li Zhijian
Hi guys 0Day noticed that dumb_buffer@clear_create triggers OOM  since commit: 0b0eaa353 ("tests/dumb_buffer: Try to compute the largest possible dumb buffer") our platform is - CPU: Intel(R) Xeon(R) CPU D-1541 @ 2.10GHz - memory: 48G - kernel: v5.5, v5.6, v5.7-rc2 i tried to add some debug

[Intel-gfx] ✓ Fi.CI.BAT: success for SAGV support for Gen12+ (rev27)

2020-04-23 Thread Patchwork
== Series Details == Series: SAGV support for Gen12+ (rev27) URL : https://patchwork.freedesktop.org/series/75129/ State : success == Summary == CI Bug Log - changes from CI_DRM_8350 -> Patchwork_17434 Summary --- **SUCCESS** No r

Re: [Intel-gfx] [PATCH v13 00/11] Convert PWM period and duty cycle to u64

2020-04-23 Thread Daniel Thompson
On Wed, Apr 22, 2020 at 04:37:55PM -0700, Guru Das Srinagesh wrote: > On Wed, Apr 22, 2020 at 09:49:34AM +0100, Daniel Thompson wrote: > > On Tue, Apr 21, 2020 at 07:57:12PM -0700, Guru Das Srinagesh wrote: > > > [REQUEST] > > > > > > Would it be possible for the patches that have already received

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for SAGV support for Gen12+ (rev27)

2020-04-23 Thread Patchwork
== Series Details == Series: SAGV support for Gen12+ (rev27) URL : https://patchwork.freedesktop.org/series/75129/ State : warning == Summary == $ dim checkpatch origin/drm-tip f963df93cc7d drm/i915: Introduce skl_plane_wm_level accessor. 75ab029a2591 drm/i915: Use bw state for per crtc SAGV e

[Intel-gfx] [CI 1/2] drm/i915/gt: Check carefully for an idle engine in wait-for-idle

2020-04-23 Thread Chris Wilson
intel_gt_wait_for_idle() tries to wait until all the outstanding requests are retired and the GPU is idle. As a side effect of retiring requests, we may submit more work to flush any pm barriers, and so the wait-for-idle tries to flush the background pm work and catch the new requests. However, if

[Intel-gfx] [CI 2/2] drm/i915/gt: Warn more clearly if the context state is still pinned

2020-04-23 Thread Chris Wilson
When recording the default context state, we submit an ordinary context and then steal the context image for our defaults. To be able to steal the state, we must have total ownership of the context. During CI we want to make this error extremely obvious, as otherwise we will fail the user's module

[Intel-gfx] [PATCH] pci/msi: Stop warning for MSI enabling failure

2020-04-23 Thread Chris Wilson
If the MSI is already enabled, trying to enable it again results in an -EINVAL and on the first attempt a WARN. That WARN causes our CI to abort the run [on each first attempt to suspend]: <4> [463.142025] WARNING: CPU: 0 PID: 2225 at drivers/pci/msi.c:1074 __pci_enable_msi_range+0x3cb/0x420 <4>

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Check carefully for an idle engine in wait-for-idle

2020-04-23 Thread Patchwork
== Series Details == Series: drm/i915/gt: Check carefully for an idle engine in wait-for-idle URL : https://patchwork.freedesktop.org/series/76362/ State : success == Summary == CI Bug Log - changes from CI_DRM_8350_full -> Patchwork_17433_full =

[Intel-gfx] [PATCH v26 5/9] drm/i915: Add TGL+ SAGV support

2020-04-23 Thread Stanislav Lisovskiy
Starting from TGL we need to have a separate wm0 values for SAGV and non-SAGV which affects how calculations are done. v2: Remove long lines v3: Removed COLOR_PLANE enum references v4, v5: Fixed rebase conflict Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c

[Intel-gfx] [PATCH v26 8/9] drm/i915: Restrict qgv points which don't have enough bandwidth.

2020-04-23 Thread Stanislav Lisovskiy
According to BSpec 53998, we should try to restrict qgv points, which can't provide enough bandwidth for desired display configuration. Currently we are just comparing against all of those and take minimum(worst case). v2: Fixed wrong PCode reply mask, removed hardcoded values. v3: Forbid si

[Intel-gfx] [PATCH v26 7/9] drm/i915: Rename bw_state to new_bw_state

2020-04-23 Thread Stanislav Lisovskiy
That is a preparation patch before next one where we introduce old_bw_state and a bunch of other changes as well. In a review comment it was suggested to split out at least that renaming into a separate patch, what is done here. v2: Removed spurious space Reviewed-by: Ville Syrjälä Signed-off-by

[Intel-gfx] [PATCH v26 1/9] drm/i915: Introduce skl_plane_wm_level accessor.

2020-04-23 Thread Stanislav Lisovskiy
For future Gen12 SAGV implementation we need to seemlessly alter wm levels calculated, depending on whether we are allowed to enable SAGV or not. So this accessor will give additional flexibility to do that. Currently this accessor is still simply working as "pass-through" function. This will be

[Intel-gfx] [PATCH v26 2/9] drm/i915: Use bw state for per crtc SAGV evaluation

2020-04-23 Thread Stanislav Lisovskiy
Future platforms require per-crtc SAGV evaluation and serializing global state when those are changed from different commits. v2: - Add has_sagv check to intel_crtc_can_enable_sagv so that it sets bit in reject mask. - Use bw_state in intel_pre/post_plane_enable_sagv instead of ato

  1   2   >