Re: [Intel-gfx] [PATCH] drm/i915/gt: Check carefully for an idle engine in wait-for-idle

2020-04-22 Thread Chris Wilson
Quoting Chris Wilson (2020-04-23 07:29:05) > intel_gt_wait_for_idle() tries to wait until all the outstanding requests > are retired and the GPU is idle. As a side effect of retiring requests, > we may submit more work to flush any pm barriers, and so the > wait-for-idle tries to flush the backgrou

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Add request throughput measurement to perf

2020-04-22 Thread Chris Wilson
Quoting Andi Shyti (2020-04-22 23:45:29) > Hi Chris, > > [...] > > > +static int s_many(void *arg) > > +{ > > + struct perf_series *ps = arg; > > why do we need to go through void... all functions are taking a > perf_series structure. The kthread API defines the function pointer as int (*fn

[Intel-gfx] [PATCH] drm/i915/gt: Check carefully for an idle engine in wait-for-idle

2020-04-22 Thread Chris Wilson
intel_gt_wait_for_idle() tries to wait until all the outstanding requests are retired and the GPU is idle. As a side effect of retiring requests, we may submit more work to flush any pm barriers, and so the wait-for-idle tries to flush the background pm work and catch the new requests. However, if

[Intel-gfx] [PATCH] drm/i915/gt: Check carefully for an idle engine in wait-for-idle

2020-04-22 Thread Chris Wilson
intel_gt_wait_for_idle() tries to wait until all the outstanding requests are retired and the GPU is idle. As a side effect of retiring requests, we may submit more work to flush any pm barriers, and so the wait-for-idle tries to flush the background pm work and catch the new requests. However, if

Re: [Intel-gfx] [PATCH hmm 5/5] mm/hmm: remove the customizable pfn format from hmm_range_fault

2020-04-22 Thread Christoph Hellwig
On Wed, Apr 22, 2020 at 09:39:11AM -0300, Jason Gunthorpe wrote: > > Nice callchain from hell.. Unfortunately such "code listings" tend to > > get out of date very quickly, so I'm not sure it is worth keeping in > > the code. What would be really worthile is consolidating the two > > different se

Re: [Intel-gfx] [CI 2/2] drm/i915/gt: Use the RPM config register to determine clk frequencies

2020-04-22 Thread kbuild test robot
Hi Chris, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20200422] [cannot apply to drm-intel/for-linux-next drm-tip/drm-tip v5.7-rc2 v5.7-rc1 v5.6 v5.7-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with the drm-misc-fixes tree

2020-04-22 Thread Stephen Rothwell
Hi all, On Tue, 21 Apr 2020 09:10:25 +0300 Tomi Valkeinen wrote: > > On 21/04/2020 04:52, Stephen Rothwell wrote: > > > > Today's linux-next merge of the drm-misc tree got a conflict in:he drm-misc > > tree with the drm-misc-fixes tree > > > >drivers/gpu/drm/tidss/tidss_encoder.c > > > >

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/hdmi: Get digital_port only once in intel_ddi_pre_enable_hdmi() (rev2)

2020-04-22 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/hdmi: Get digital_port only once in intel_ddi_pre_enable_hdmi() (rev2) URL : https://patchwork.freedesktop.org/series/76350/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8350_full -> Patchwork_17432_full ==

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Only close vma we open

2020-04-22 Thread Patchwork
== Series Details == Series: drm/i915: Only close vma we open URL : https://patchwork.freedesktop.org/series/76349/ State : success == Summary == CI Bug Log - changes from CI_DRM_8350_full -> Patchwork_17429_full Summary --- **WARNIN

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Add request throughput measurement to perf

2020-04-22 Thread Andi Shyti
Hi Chris, [...] > +static int s_many(void *arg) > +{ > + struct perf_series *ps = arg; why do we need to go through void... all functions are taking a perf_series structure. > + IGT_TIMEOUT(end_time); > + unsigned int idx = 0; > + [...] > + for (idx = 0; idx < nengines

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/5] drm/i915: Make define for lrc state offset (rev4)

2020-04-22 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Make define for lrc state offset (rev4) URL : https://patchwork.freedesktop.org/series/76262/ State : success == Summary == CI Bug Log - changes from CI_DRM_8350_full -> Patchwork_17427_full

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v3,1/6] drm/i915: Fix skl+ non-scaled pfit modes

2020-04-22 Thread Patchwork
== Series Details == Series: series starting with [v3,1/6] drm/i915: Fix skl+ non-scaled pfit modes URL : https://patchwork.freedesktop.org/series/76346/ State : success == Summary == CI Bug Log - changes from CI_DRM_8350_full -> Patchwork_17426_full ===

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/hdmi: Get digital_port only once in intel_ddi_pre_enable_hdmi() (rev2)

2020-04-22 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/hdmi: Get digital_port only once in intel_ddi_pre_enable_hdmi() (rev2) URL : https://patchwork.freedesktop.org/series/76350/ State : success == Summary == CI Bug Log - changes from CI_DRM_8350 -> Patchwork_17432

Re: [Intel-gfx] [PATCH v3 6/6] drm/i915: Have pfit calculations return an error code

2020-04-22 Thread Manasi Navare
On Wed, Apr 22, 2020 at 07:19:17PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Change intel_{gmch,pch}_panel_fitting() to return a normal > error vs. success int. We'll need this later to validate that > the margin properties aren't misconfigured. > > Signed-off-by: Ville Syrjälä Yes

Re: [Intel-gfx] [PATCH v3 5/6] drm/i915: Pass connector state to pfit calculations

2020-04-22 Thread Manasi Navare
On Wed, Apr 22, 2020 at 07:19:16PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Pass the entire connector state to intel_{gmch,pch}_panel_fitting(). > For now we just need to get at .scaling_mode but in the future we'll > want access to the margin properties as well. > > v2: Deal with i

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Warn more clearly if the context state is still pinned

2020-04-22 Thread Patchwork
== Series Details == Series: drm/i915/gt: Warn more clearly if the context state is still pinned URL : https://patchwork.freedesktop.org/series/76351/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8350 -> Patchwork_17431 Su

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/hdmi: Get digital_port only once in intel_ddi_pre_enable_hdmi()

2020-04-22 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/hdmi: Get digital_port only once in intel_ddi_pre_enable_hdmi() URL : https://patchwork.freedesktop.org/series/76350/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8350 -> Patchwork_17430 ===

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Only close vma we open

2020-04-22 Thread Patchwork
== Series Details == Series: drm/i915: Only close vma we open URL : https://patchwork.freedesktop.org/series/76349/ State : success == Summary == CI Bug Log - changes from CI_DRM_8350 -> Patchwork_17429 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH v2 7/9] PM: sleep: core: Rename DPM_FLAG_NEVER_SKIP

2020-04-22 Thread Alex Deucher
On Sat, Apr 18, 2020 at 1:11 PM Rafael J. Wysocki wrote: > > From: "Rafael J. Wysocki" > > Rename DPM_FLAG_NEVER_SKIP to DPM_FLAG_NO_DIRECT_COMPLETE which > matches its purpose more closely. > > No functional impact. > > Signed-off-by: Rafael J. Wysocki > Acked-by: Bjorn Helgaas # for PCI parts

[Intel-gfx] [PATCH] drm/i915/gt: Warn more clearly if the context state is still pinned

2020-04-22 Thread Chris Wilson
When recording the default context state, we submit an ordinary context and then steal the context image for our defaults. To be able to steal the state, we must have total ownership of the context. During CI we want to make this error extremely obvious, as otherwise we will fail the user's module

[Intel-gfx] ✗ Fi.CI.BAT: failure for Introduce CAP_PERFMON to secure system performance monitoring and observability (rev18)

2020-04-22 Thread Patchwork
== Series Details == Series: Introduce CAP_PERFMON to secure system performance monitoring and observability (rev18) URL : https://patchwork.freedesktop.org/series/72273/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8350 -> Patchwork_17428 ===

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Split ctx timestamp selftest into two

2020-04-22 Thread Chris Wilson
Quoting Mika Kuoppala (2020-04-21 15:29:32) > We use different workarounds for render engine than > for other engines. Split the selftest according to these > types so that we get error rates per workaround. > > Signed-off-by: Mika Kuoppala ~o~ If you think it's useful, Reviewed-by: Chris Wilso

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Use indirect ctx bb to mend CMD_BUF_CCTL

2020-04-22 Thread Chris Wilson
Quoting Mika Kuoppala (2020-04-21 14:16:32) > @@ -3290,7 +3355,7 @@ gen12_setup_timestamp_ctx_wa(struct intel_context *ce) > > fn = gen12_emit_timestamp_wa_lrm; > if (ce->engine->class == RENDER_CLASS) > - fn = gen12_emit_timestamp_wa_lrr; > + fn = gen1

[Intel-gfx] [PATCH 2/2] drm/i915/hdmi: Add missing sequence

2020-04-22 Thread José Roberto de Souza
It was missing the step 7.b - "If not type-C static connection, configure PORT_CL_DW10 Static Power Down to power up all lanes of the DDI". BSpec: 53339 BSpec: 49191 Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_ddi.c | 10 ++ 1 file changed, 10 insertions(+

[Intel-gfx] [PATCH 1/2] drm/i915/hdmi: Get digital_port only once in intel_ddi_pre_enable_hdmi()

2020-04-22 Thread José Roberto de Souza
Getting it only once also removing intel_hdmi that is used only once and can be easily accessed by dig_port->hdmi. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_ddi.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Add live selftests for indirect ctx batchbuffers

2020-04-22 Thread Chris Wilson
Quoting Mika Kuoppala (2020-04-21 14:16:31) > Indirect ctx batchbuffers are a hw feature of which > batch can be run, by hardware, during context restoration stage. > Driver can setup a batchbuffer and also an offset into the > context image. When context image is marshalled from > memory to regist

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Add per ctx batchbuffer wa for timestamp

2020-04-22 Thread Chris Wilson
Quoting Mika Kuoppala (2020-04-21 14:16:30) > Restoration of a previous timestamp can collide > with updating the timestamp, causing a value corruption. > > Combat this issue by using indirect ctx bb to > modify the context image during restoring process. > > For render engine, we can preload val

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/execlists: Drop request-before-CS assertion

2020-04-22 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Drop request-before-CS assertion URL : https://patchwork.freedesktop.org/series/76340/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8348_full -> Patchwork_17423_full Summary

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Make define for lrc state offset

2020-04-22 Thread Chris Wilson
Quoting Mika Kuoppala (2020-04-21 14:16:29) > More often than not, we need a byte offset into lrc > register state from the start of the hw state. Make it so. > > Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson -Chris ___ Intel-gfx mailing list

Re: [Intel-gfx] [PATCH v3 4/6] drm/i915: s/pipe_config/crtc_state/ in pfit functions

2020-04-22 Thread Manasi Navare
On Wed, Apr 22, 2020 at 07:19:15PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Follow the new naming convention and call the crtc state > "crtc_state", and while at it drop the redundant crtc argument. > > Signed-off-by: Ville Syrjälä Reviewed-by: Manasi Navare Manasi > --- > dri

Re: [Intel-gfx] [PATCH v3 3/6] drm/i915: Use drm_rect to store the pfit window pos/size

2020-04-22 Thread Manasi Navare
On Wed, Apr 22, 2020 at 07:19:14PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Make things a bit more abstract by replacing the pch_pfit.pos/size > raw register values with a drm_rect. Makes it slighly more convenient > to eg. compute the scaling factors. > > v2: Use drm_rect_init() >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce CAP_PERFMON to secure system performance monitoring and observability (rev18)

2020-04-22 Thread Patchwork
== Series Details == Series: Introduce CAP_PERFMON to secure system performance monitoring and observability (rev18) URL : https://patchwork.freedesktop.org/series/72273/ State : warning == Summary == $ dim checkpatch origin/drm-tip f036c99151ab capabilities: Introduce CAP_PERFMON to kernel a

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Make define for lrc state offset (rev4)

2020-04-22 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Make define for lrc state offset (rev4) URL : https://patchwork.freedesktop.org/series/76262/ State : success == Summary == CI Bug Log - changes from CI_DRM_8350 -> Patchwork_17427 ==

[Intel-gfx] [PATCH] drm/i915: Only close vma we open

2020-04-22 Thread Chris Wilson
The history of i915_vma_close() is confusing, as is its use. As the lifetime of the i915_vma is currently bounded by the object it is attached to, we needed a means of identify when a vma was no longer in use by userspace (via the user's fd). This is further complicated by that only ppgtt vma shoul

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915: Make define for lrc state offset (rev4)

2020-04-22 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Make define for lrc state offset (rev4) URL : https://patchwork.freedesktop.org/series/76262/ State : warning == Summary == $ dim checkpatch origin/drm-tip c89bc59fae80 drm/i915: Make define for lrc state offset 47e9e54a1306 dr

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3,1/6] drm/i915: Fix skl+ non-scaled pfit modes

2020-04-22 Thread Patchwork
== Series Details == Series: series starting with [v3,1/6] drm/i915: Fix skl+ non-scaled pfit modes URL : https://patchwork.freedesktop.org/series/76346/ State : success == Summary == CI Bug Log - changes from CI_DRM_8350 -> Patchwork_17426

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/6] drm/i915: Fix skl+ non-scaled pfit modes

2020-04-22 Thread Patchwork
== Series Details == Series: series starting with [v3,1/6] drm/i915: Fix skl+ non-scaled pfit modes URL : https://patchwork.freedesktop.org/series/76346/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9faaa25c52d4 drm/i915: Fix skl+ non-scaled pfit modes a744ba6aef89 drm/i915: F

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915/gt: Prefer soft-rc6 over RPS DOWN_TIMEOUT (rev2)

2020-04-22 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/gt: Prefer soft-rc6 over RPS DOWN_TIMEOUT (rev2) URL : https://patchwork.freedesktop.org/series/76283/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8350 -> Patchwork_17425 ==

Re: [Intel-gfx] [PATCH v7 i-g-t 4/4] kms_writeback: Add writeback-check-output

2020-04-22 Thread Maxime Ripard
Hi! On Tue, Apr 21, 2020 at 05:07:05PM -0400, Rodrigo Siqueira wrote: > On 04/15, Maxime Ripard wrote: > > On Mon, Oct 21, 2019 at 10:00:39PM -0300, Brian Starkey wrote: > > > Add a test which makes commits using the writeback connector, and > > > checks the output buffer hash to make sure it is/i

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/icl: Fix timeout handling during TypeC AUX power well enabling

2020-04-22 Thread Patchwork
== Series Details == Series: drm/i915/icl: Fix timeout handling during TypeC AUX power well enabling URL : https://patchwork.freedesktop.org/series/76336/ State : success == Summary == CI Bug Log - changes from CI_DRM_8348_full -> Patchwork_17421_full ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/gt: Prefer soft-rc6 over RPS DOWN_TIMEOUT (rev2)

2020-04-22 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/gt: Prefer soft-rc6 over RPS DOWN_TIMEOUT (rev2) URL : https://patchwork.freedesktop.org/series/76283/ State : warning == Summary == $ dim checkpatch origin/drm-tip 110e7737c6ac drm/i915/gt: Prefer soft-rc6 over RPS DOWN_TIMEOUT

Re: [Intel-gfx] [PATCH hmm 5/5] mm/hmm: remove the customizable pfn format from hmm_range_fault

2020-04-22 Thread Felix Kuehling
[+Philip Yang] Am 2020-04-21 um 8:21 p.m. schrieb Jason Gunthorpe: > From: Jason Gunthorpe > > Presumably the intent here was that hmm_range_fault() could put the data > into some HW specific format and thus avoid some work. However, nothing > actually does that, and it isn't clear how anything a

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Verify context isolation (rev2)

2020-04-22 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Verify context isolation (rev2) URL : https://patchwork.freedesktop.org/series/76339/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8350 -> Patchwork_17424 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Verify context isolation (rev2)

2020-04-22 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Verify context isolation (rev2) URL : https://patchwork.freedesktop.org/series/76339/ State : warning == Summary == $ dim checkpatch origin/drm-tip 91ac23bb4db2 drm/i915/selftests: Verify context isolation -:298: WARNING:LINE_SPACING: Missing a

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Apply Wa_1406680159 as a clk_gating workaround

2020-04-22 Thread Chris Wilson
Quoting Radhakrishna Sripada (2020-04-22 13:30:37) > The workaround is moved from render engine context to intel_pm > clk gating functions like the previous platforms. Why? > Closes: https://gitlab.freedesktop.org/drm/intel/issues/1222 Oh so you mean so that you don't actually have to test anyth

[Intel-gfx] ✓ Fi.CI.IGT: success for Apply Wa_1406680159 as a clk_gating workaround

2020-04-22 Thread Patchwork
== Series Details == Series: Apply Wa_1406680159 as a clk_gating workaround URL : https://patchwork.freedesktop.org/series/76334/ State : success == Summary == CI Bug Log - changes from CI_DRM_8348_full -> Patchwork_17420_full Summary -

[Intel-gfx] [tip: perf/core] drivers/oprofile: Open access for CAP_PERFMON privileged process

2020-04-22 Thread tip-bot2 for Alexey Budankov
The following commit has been merged into the perf/core branch of tip: Commit-ID: ab76878bb720cbd35a05ae868387f4373a58c949 Gitweb: https://git.kernel.org/tip/ab76878bb720cbd35a05ae868387f4373a58c949 Author:Alexey Budankov AuthorDate:Thu, 02 Apr 2020 11:53:07 +03:00 Committ

[Intel-gfx] [PATCH v13 00/11] Convert PWM period and duty cycle to u64

2020-04-22 Thread Guru Das Srinagesh
[REQUEST] Would it be possible for the patches that have already received Acked-by's in this series to be accepted and applied to the tree? I lost an Acked-by (in intel-panel.c) because it had a merge conflict with a new change that came in after I rebased to tip. I wasn't sure earlier about accep

[Intel-gfx] [tip: perf/core] doc/admin-guide: update kernel.rst with CAP_PERFMON information

2020-04-22 Thread tip-bot2 for Alexey Budankov
The following commit has been merged into the perf/core branch of tip: Commit-ID: 025b16f81dd7f51f29d0109399d669438c63b6ce Gitweb: https://git.kernel.org/tip/025b16f81dd7f51f29d0109399d669438c63b6ce Author:Alexey Budankov AuthorDate:Thu, 02 Apr 2020 11:54:39 +03:00 Committ

[Intel-gfx] [PATCH v13 01/11] drm/i915: Use 64-bit division macro

2020-04-22 Thread Guru Das Srinagesh
Since the PWM framework is switching struct pwm_state.duty_cycle's datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL to handle a 64-bit dividend. To: Jani Nikula Cc: Joonas Lahtinen Cc: David Airlie Cc: Daniel Vetter Cc: Chris Wilson Cc: "Ville Syrjälä" Cc: intel-gfx@lis

[Intel-gfx] [tip: perf/core] drivers/perf: Open access for CAP_PERFMON privileged process

2020-04-22 Thread tip-bot2 for Alexey Budankov
The following commit has been merged into the perf/core branch of tip: Commit-ID: cea7d0d4a59b4efd0e1fe067130b4c06ab4d412f Gitweb: https://git.kernel.org/tip/cea7d0d4a59b4efd0e1fe067130b4c06ab4d412f Author:Alexey Budankov AuthorDate:Thu, 02 Apr 2020 11:51:21 +03:00 Committ

[Intel-gfx] [tip: perf/core] powerpc/perf: open access for CAP_PERFMON privileged process

2020-04-22 Thread tip-bot2 for Alexey Budankov
The following commit has been merged into the perf/core branch of tip: Commit-ID: ff46758313e688fca7d762b3e6ead32843999511 Gitweb: https://git.kernel.org/tip/ff46758313e688fca7d762b3e6ead32843999511 Author:Alexey Budankov AuthorDate:Thu, 02 Apr 2020 11:49:36 +03:00 Committ

[Intel-gfx] [tip: perf/core] doc/admin-guide: Update perf-security.rst with CAP_PERFMON information

2020-04-22 Thread tip-bot2 for Alexey Budankov
The following commit has been merged into the perf/core branch of tip: Commit-ID: 902a8dcc5ba6c5dc3332e8806b01be2f0f7ef2e4 Gitweb: https://git.kernel.org/tip/902a8dcc5ba6c5dc3332e8806b01be2f0f7ef2e4 Author:Alexey Budankov AuthorDate:Thu, 02 Apr 2020 11:54:01 +03:00 Committ

[Intel-gfx] [tip: perf/core] capabilities: Introduce CAP_PERFMON to kernel and user space

2020-04-22 Thread tip-bot2 for Alexey Budankov
The following commit has been merged into the perf/core branch of tip: Commit-ID: 980737282232b752bb14dab96d77665c15889c36 Gitweb: https://git.kernel.org/tip/980737282232b752bb14dab96d77665c15889c36 Author:Alexey Budankov AuthorDate:Thu, 02 Apr 2020 11:45:31 +03:00 Committ

[Intel-gfx] [tip: perf/core] perf/core: Open access to the core for CAP_PERFMON privileged process

2020-04-22 Thread tip-bot2 for Alexey Budankov
The following commit has been merged into the perf/core branch of tip: Commit-ID: 18aa18566218d4a46d940049b835314d2b071cc2 Gitweb: https://git.kernel.org/tip/18aa18566218d4a46d940049b835314d2b071cc2 Author:Alexey Budankov AuthorDate:Thu, 02 Apr 2020 11:46:24 +03:00 Committ

[Intel-gfx] [tip: perf/core] parisc/perf: open access for CAP_PERFMON privileged process

2020-04-22 Thread tip-bot2 for Alexey Budankov
The following commit has been merged into the perf/core branch of tip: Commit-ID: cf91baf3f7f39a0cd29072e21ed0e4bb1ab3b382 Gitweb: https://git.kernel.org/tip/cf91baf3f7f39a0cd29072e21ed0e4bb1ab3b382 Author:Alexey Budankov AuthorDate:Thu, 02 Apr 2020 11:50:15 +03:00 Committ

[Intel-gfx] [tip: perf/core] perf tools: Support CAP_PERFMON capability

2020-04-22 Thread tip-bot2 for Alexey Budankov
The following commit has been merged into the perf/core branch of tip: Commit-ID: 6b3e0e2e04615df128b2d38fa1dd1fcb84f2504c Gitweb: https://git.kernel.org/tip/6b3e0e2e04615df128b2d38fa1dd1fcb84f2504c Author:Alexey Budankov AuthorDate:Thu, 02 Apr 2020 11:47:35 +03:00 Committ

[Intel-gfx] [tip: perf/core] perf/core: open access to probes for CAP_PERFMON privileged process

2020-04-22 Thread tip-bot2 for Alexey Budankov
The following commit has been merged into the perf/core branch of tip: Commit-ID: c9e0924e5c2b59365f9c0d43ff8722e79ecf4088 Gitweb: https://git.kernel.org/tip/c9e0924e5c2b59365f9c0d43ff8722e79ecf4088 Author:Alexey Budankov AuthorDate:Thu, 02 Apr 2020 11:47:01 +03:00 Committ

[Intel-gfx] [tip: perf/core] trace/bpf_trace: Open access for CAP_PERFMON privileged process

2020-04-22 Thread tip-bot2 for Alexey Budankov
The following commit has been merged into the perf/core branch of tip: Commit-ID: 031258da05956646c5606023ab0abe10a7e68ea1 Gitweb: https://git.kernel.org/tip/031258da05956646c5606023ab0abe10a7e68ea1 Author:Alexey Budankov AuthorDate:Thu, 02 Apr 2020 11:48:54 +03:00 Committ

[Intel-gfx] [tip: perf/core] drm/i915/perf: Open access for CAP_PERFMON privileged process

2020-04-22 Thread tip-bot2 for Alexey Budankov
The following commit has been merged into the perf/core branch of tip: Commit-ID: 4e3d3456b78fa5a70e65de0d7c5309b814281ae3 Gitweb: https://git.kernel.org/tip/4e3d3456b78fa5a70e65de0d7c5309b814281ae3 Author:Alexey Budankov AuthorDate:Thu, 02 Apr 2020 11:48:15 +03:00 Committ

Re: [Intel-gfx] [PATCH v25 2/8] drm/i915: Use bw state for per crtc SAGV evaluation

2020-04-22 Thread Ville Syrjälä
On Wed, Apr 22, 2020 at 10:50:22AM +0300, Lisovskiy, Stanislav wrote: > On Tue, Apr 21, 2020 at 07:00:38PM +0300, Ville Syrjälä wrote: > > On Mon, Apr 20, 2020 at 02:14:10PM +0300, Stanislav Lisovskiy wrote: > > > Future platforms require per-crtc SAGV evaluation > > > and serializing global state

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v5,1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD

2020-04-22 Thread Patchwork
== Series Details == Series: series starting with [v5,1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD URL : https://patchwork.freedesktop.org/series/76328/ State : success == Summary == CI Bug Log - changes from CI_DRM_8348_full -> Patchwork_17419_full

[Intel-gfx] [PATCH v3 2/6] drm/i915: Flatten a bunch of the pfit functions

2020-04-22 Thread Ville Syrjala
From: Ville Syrjälä Most of the pfit functions are of the form: func() { if (pfit_enabled) { ... } } Flip the pfit_enabled check around to flatten the functions. And while we're touching all this let's do the usual s/pipe_config/crtc_state/ replacement. Reviewe

[Intel-gfx] [PATCH v3 4/6] drm/i915: s/pipe_config/crtc_state/ in pfit functions

2020-04-22 Thread Ville Syrjala
From: Ville Syrjälä Follow the new naming convention and call the crtc state "crtc_state", and while at it drop the redundant crtc argument. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/icl_dsi.c | 3 +- drivers/gpu/drm/i915/display/intel_dp.c| 8 +- drivers/gpu/drm/

[Intel-gfx] [PATCH v3 1/6] drm/i915: Fix skl+ non-scaled pfit modes

2020-04-22 Thread Ville Syrjala
From: Ville Syrjälä Fix skl_update_scaler_crtc() to deal with different scaling modes correctly. The current implementation assumes DRM_MODE_SCALE_FULLSCREEN. Fortunately we don't expose any border properties currently so the code does actually end up doing the right thing (assigning a scaler for

[Intel-gfx] [PATCH v3 3/6] drm/i915: Use drm_rect to store the pfit window pos/size

2020-04-22 Thread Ville Syrjala
From: Ville Syrjälä Make things a bit more abstract by replacing the pch_pfit.pos/size raw register values with a drm_rect. Makes it slighly more convenient to eg. compute the scaling factors. v2: Use drm_rect_init() Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.

[Intel-gfx] [PATCH v3 6/6] drm/i915: Have pfit calculations return an error code

2020-04-22 Thread Ville Syrjala
From: Ville Syrjälä Change intel_{gmch,pch}_panel_fitting() to return a normal error vs. success int. We'll need this later to validate that the margin properties aren't misconfigured. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/icl_dsi.c | 10 +++--- drivers/gpu/drm/

[Intel-gfx] [PATCH v3 5/6] drm/i915: Pass connector state to pfit calculations

2020-04-22 Thread Ville Syrjala
From: Ville Syrjälä Pass the entire connector state to intel_{gmch,pch}_panel_fitting(). For now we just need to get at .scaling_mode but in the future we'll want access to the margin properties as well. v2: Deal with intel_dp_ycbcr420_config() Signed-off-by: Ville Syrjälä --- drivers/gpu/drm

[Intel-gfx] [PATCH] drm/i915/selftests: Verify context isolation

2020-04-22 Thread Chris Wilson
No unprivileged context should ever be allowed to modify state that is visible to another; there should be no backchannels available or control leakage for malicious actors. This test tries to write to a set of random registers using non-privileged instructions (ala userspace). It should only be a

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Drop request-before-CS assertion

2020-04-22 Thread Mika Kuoppala
Chris Wilson writes: > When we migrated to execlists, one of the conditions we wanted to test > for was whether the breadcrumb seqno was being written before the > breadcumb interrupt was delivered. This was following on from issues > observed on previous generations which were not so strong orde

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Drop request-before-CS assertion

2020-04-22 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Drop request-before-CS assertion URL : https://patchwork.freedesktop.org/series/76340/ State : success == Summary == CI Bug Log - changes from CI_DRM_8348 -> Patchwork_17423 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/icl: Fix timeout handling during TypeC AUX power well enabling

2020-04-22 Thread Souza, Jose
On Wed, 2020-04-22 at 15:34 +0300, Imre Deak wrote: > Fix the check for when an AUX power well enabling timeout is expected > on > a legacy TypeC port. > > Fixes: 89e01caac641 ("drm/i915: Use single set of AUX powerwell ops > for gen11+") Reviewed-by: José Roberto de Souza > Cc: Matt Roper > C

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/execlists: Drop request-before-CS assertion

2020-04-22 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Drop request-before-CS assertion URL : https://patchwork.freedesktop.org/series/76340/ State : warning == Summary == $ dim checkpatch origin/drm-tip ab29e29e07bc drm/i915/execlists: Drop request-before-CS assertion -:11: WARNING:TYPO_SPELLING: '

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Verify context isolation

2020-04-22 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Verify context isolation URL : https://patchwork.freedesktop.org/series/76339/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8348 -> Patchwork_17422 Summary --- **FAIL

[Intel-gfx] ✓ Fi.CI.IGT: success for perf/core: Only copy-to-user after completely unlocking all locks, v3.

2020-04-22 Thread Patchwork
== Series Details == Series: perf/core: Only copy-to-user after completely unlocking all locks, v3. URL : https://patchwork.freedesktop.org/series/76325/ State : success == Summary == CI Bug Log - changes from CI_DRM_8348_full -> Patchwork_17418_full ===

Re: [Intel-gfx] [PATCH] RFC drm/i915/gem: Allow creation of contexts with an 'empty' VM

2020-04-22 Thread Tvrtko Ursulin
On 21/04/2020 17:41, Chris Wilson wrote: Normally when we create a new context, and a new ppGTT to go with it, we point all the unused pages in the ppGTT to a 'safe' scratch page. Any inadvertent access outside of the declared user's area will result in a read/write to scratch instead. However,

[Intel-gfx] [PATCH] drm/i915/execlists: Drop request-before-CS assertion

2020-04-22 Thread Chris Wilson
When we migrated to execlists, one of the conditions we wanted to test for was whether the breadcrumb seqno was being written before the breadcumb interrupt was delivered. This was following on from issues observed on previous generations which were not so strong ordered. With the removal of the mi

Re: [Intel-gfx] [PATCH v2] drm/i915/selftests: Try to detect rollback during batchbuffer preemption

2020-04-22 Thread Mika Kuoppala
Chris Wilson writes: > Since batch buffers dominant execution time, most preemption requests > should naturally occur during execution of a batch buffer. We wish to > verify that should a preemption occur within a batch buffer, when we > come to restart that batch buffer, it occurs at the interru

Re: [Intel-gfx] [PATCH] drm/i915/gem: Hold obj->vma.lock over for_each_ggtt_vma()

2020-04-22 Thread Tvrtko Ursulin
On 22/04/2020 08:20, Chris Wilson wrote: While the ggtt vma are protected by their object lifetime, the list continues until it hits a non-ggtt vma, and that vma is not protected and may be freed as we inspect it. Hence, we require the obj->vma.lock to protect the list as we iterate. An exampl

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Verify context isolation

2020-04-22 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Verify context isolation URL : https://patchwork.freedesktop.org/series/76339/ State : warning == Summary == $ dim checkpatch origin/drm-tip e6764a40a77b drm/i915/selftests: Verify context isolation -:275: WARNING:LINE_SPACING: Missing a blank l

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: Fix timeout handling during TypeC AUX power well enabling

2020-04-22 Thread Patchwork
== Series Details == Series: drm/i915/icl: Fix timeout handling during TypeC AUX power well enabling URL : https://patchwork.freedesktop.org/series/76336/ State : success == Summary == CI Bug Log - changes from CI_DRM_8348 -> Patchwork_17421

[Intel-gfx] [PATCH] drm/i915/selftests: Verify context isolation

2020-04-22 Thread Chris Wilson
No unprivileged context should ever be allowed to modify state that is visible to another; there should be no backchannels available or control leakage for malicious actors. This test tries to write to a set of random registers using non-privileged instructions (ala userspace). It should only be a

[Intel-gfx] ✓ Fi.CI.BAT: success for Apply Wa_1406680159 as a clk_gating workaround

2020-04-22 Thread Patchwork
== Series Details == Series: Apply Wa_1406680159 as a clk_gating workaround URL : https://patchwork.freedesktop.org/series/76334/ State : success == Summary == CI Bug Log - changes from CI_DRM_8348 -> Patchwork_17420 Summary --- **SU

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Try to detect rollback during batchbuffer preemption (rev2)

2020-04-22 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Try to detect rollback during batchbuffer preemption (rev2) URL : https://patchwork.freedesktop.org/series/76279/ State : success == Summary == CI Bug Log - changes from CI_DRM_8348_full -> Patchwork_17417_full =

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v5,1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD

2020-04-22 Thread Patchwork
== Series Details == Series: series starting with [v5,1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD URL : https://patchwork.freedesktop.org/series/76328/ State : success == Summary == CI Bug Log - changes from CI_DRM_8348 -> Patchwork_17419 ==

[Intel-gfx] [PATCH] drm/i915/icl: Fix timeout handling during TypeC AUX power well enabling

2020-04-22 Thread Imre Deak
Fix the check for when an AUX power well enabling timeout is expected on a legacy TypeC port. Fixes: 89e01caac641 ("drm/i915: Use single set of AUX powerwell ops for gen11+") Cc: Matt Roper Cc: José Roberto de Souza Signed-off-by: Imre Deak --- .../drm/i915/display/intel_display_power.c| 7

[Intel-gfx] [PATCH 1/1] drm/i915: Apply Wa_1406680159 as a clk_gating workaround

2020-04-22 Thread Radhakrishna Sripada
The workaround is moved from render engine context to intel_pm clk gating functions like the previous platforms. Closes: https://gitlab.freedesktop.org/drm/intel/issues/1222 Fixes: fb899dd8ea9c ("drm/i915: Apply Wa_1406680159:icl,ehl as an engine workaround") Cc: Matt Atwood Cc: Matt Roper Sign

[Intel-gfx] [PATCH 0/1] Apply Wa_1406680159 as a clk_gating workaround

2020-04-22 Thread Radhakrishna Sripada
This is a one patch series that moves the WA from RCS WA's list to clock gating WA's in intel_pm.c Test-with: 20200228104340.2895082-2-ch...@chris-wilson.co.uk Radhakrishna Sripada (1): drm/i915: Apply Wa_1406680159 as a clk_gating workaround drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v5,1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD

2020-04-22 Thread Patchwork
== Series Details == Series: series starting with [v5,1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD URL : https://patchwork.freedesktop.org/series/76328/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1e772a99285c drm/dp: DRM DP helper for reading Ignore MSA from

[Intel-gfx] ✓ Fi.CI.BAT: success for perf/core: Only copy-to-user after completely unlocking all locks, v3.

2020-04-22 Thread Patchwork
== Series Details == Series: perf/core: Only copy-to-user after completely unlocking all locks, v3. URL : https://patchwork.freedesktop.org/series/76325/ State : success == Summary == CI Bug Log - changes from CI_DRM_8348 -> Patchwork_17418

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for perf/core: Only copy-to-user after completely unlocking all locks, v3.

2020-04-22 Thread Patchwork
== Series Details == Series: perf/core: Only copy-to-user after completely unlocking all locks, v3. URL : https://patchwork.freedesktop.org/series/76325/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1eec2217d858 perf/core: Only copy-to-user after completely unlocking all locks

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Try to detect rollback during batchbuffer preemption (rev2)

2020-04-22 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Try to detect rollback during batchbuffer preemption (rev2) URL : https://patchwork.freedesktop.org/series/76279/ State : success == Summary == CI Bug Log - changes from CI_DRM_8348 -> Patchwork_17417 ===

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Disable heartbeat around RPS interrupt testing

2020-04-22 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Disable heartbeat around RPS interrupt testing URL : https://patchwork.freedesktop.org/series/76312/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8347_full -> Patchwork_17415_full ===

[Intel-gfx] [v5, 1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD

2020-04-22 Thread bhanuprakash . modem
From: Manasi Navare From: Manasi Navare DP sink device sets the Ignore MSA bit in its DP_DOWNSTREAM_PORT_COUNT register to indicate its ability to ignore the MSA video timing parameters and its ability to support seamless video timing change over a range of timing exposed by DisplayID and EDID.

[Intel-gfx] [v5, 2/3] drm/i915/dp: Attach and set drm connector VRR property

2020-04-22 Thread bhanuprakash . modem
From: Aditya Swarup From: Aditya Swarup This function sets the VRR property for connector based on the platform support, EDID monitor range and DP sink DPCD capability of outputing video without msa timing information. v4: * Rebase (Mansi) v3: * intel_dp_is_vrr_capable can be used for debugfs,

[Intel-gfx] [v5, 3/3] drm/i915/dp: Expose connector VRR info via debugfs

2020-04-22 Thread bhanuprakash . modem
From: Bhanuprakash Modem [Why] It's useful to know the min and max vrr range for IGT testing. [How] Expose the min and max vfreq for the connector via a debugfs file on the connector, "vrr_range". Example usage: cat /sys/kernel/debug/dri/0/DP-1/vrr_range v4: * Rebase (Bhanu) * Remove "Vrr_capa

[Intel-gfx] [PATCH] perf/core: Only copy-to-user after completely unlocking all locks, v3.

2020-04-22 Thread Maarten Lankhorst
We inadvertently create a dependency on mmap_sem with a whole chain. This breaks any user who wants to take a lock and call rcu_barrier(), while also taking that lock inside mmap_sem: <4> [604.892532] == <4> [604.892534] WARNING: possible circul

[Intel-gfx] [PATCH i-g-t 1/2] i915/gem_exec_balancer: Kick tasklets harder

2020-04-22 Thread Chris Wilson
Tasklet scheduling can unfortunately be quite predicated. Where we are only caring about workload distribution and not initial execution latency (see kick_kthreads), make that kick more precise. Signed-off-by: Chris Wilson --- lib/igt_debugfs.h | 7 +++ tests/i915/gem_exec_bala

[Intel-gfx] [PATCH i-g-t 2/2] i915/gem_ctx_persistence: Give the CPU scheduler a kick on timeouts

2020-04-22 Thread Chris Wilson
We have allowed the CPU 2s to process the hang and cleanup; but clearly this is not always enough. Let's just give the CPU one last kick before declaring that we have an issue, to try and be sure that we have a bug to fix before worrying. References: https://gitlab.freedesktop.org/drm/intel/issues

Re: ✗ Fi.CI.BAT: failure for drm/i915/gt: Warn more clearly if we the context state is still pinned

2020-04-22 Thread Chris Wilson
Quoting Patchwork (2020-04-22 11:03:39) > Possible regressions > > * igt@i915_module_load@reload: > - fi-ivb-3770:[PASS][1] -> [INCOMPLETE][2] >[1]: > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8347/fi-ivb-3770/igt@i915_module_l...@reload.html >[2]: > https:/

  1   2   >