[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Force the state compute phase once to enable PSR (rev4)

2020-01-06 Thread Patchwork
== Series Details == Series: drm/i915/display: Force the state compute phase once to enable PSR (rev4) URL : https://patchwork.freedesktop.org/series/7/ State : success == Summary == CI Bug Log - changes from CI_DRM_7688_full -> Patchwork_16006_full ===

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Use external dependency loop for port sync

2020-01-06 Thread Patchwork
== Series Details == Series: drm/i915/display: Use external dependency loop for port sync URL : https://patchwork.freedesktop.org/series/71660/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7688_full -> Patchwork_16005_full

[Intel-gfx] [drm-intel:drm-intel-next-queued 20/20] drivers/gpu/drm/i915/gt/intel_lrc.c:4613 intel_execlists_create_virtual() warn: assigning (-2) to unsigned variable 've->base.uabi_instance'

2020-01-06 Thread Dan Carpenter
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued head: f75fc37b5e70b75f21550410f88e2379648120e2 commit: f75fc37b5e70b75f21550410f88e2379648120e2 [20/20] drm/i915/gt: Mark up virtual engine uabi_instance If you fix the issue, kindly add following tag Reported-by: kbuild test

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/gt: Always reset the timeslice after a context switch (rev2)

2020-01-06 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Always reset the timeslice after a context switch (rev2) URL : https://patchwork.freedesktop.org/series/71655/ State : success == Summary == CI Bug Log - changes from CI_DRM_7687_full -> Patchwork_16004_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gtt: split up i915_gem_gtt

2020-01-06 Thread Patchwork
== Series Details == Series: drm/i915/gtt: split up i915_gem_gtt URL : https://patchwork.freedesktop.org/series/71678/ State : success == Summary == CI Bug Log - changes from CI_DRM_7690 -> Patchwork_16010 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gtt: split up i915_gem_gtt

2020-01-06 Thread Patchwork
== Series Details == Series: drm/i915/gtt: split up i915_gem_gtt URL : https://patchwork.freedesktop.org/series/71678/ State : warning == Summary == $ dim checkpatch origin/drm-tip f96decd69a0e drm/i915/gtt: split up i915_gem_gtt -:67: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s)

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Replace vma parking with a clock aging algorithm

2020-01-06 Thread Patchwork
== Series Details == Series: drm/i915: Replace vma parking with a clock aging algorithm URL : https://patchwork.freedesktop.org/series/71677/ State : success == Summary == CI Bug Log - changes from CI_DRM_7690 -> Patchwork_16009 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Replace vma parking with a clock aging algorithm

2020-01-06 Thread Patchwork
== Series Details == Series: drm/i915: Replace vma parking with a clock aging algorithm URL : https://patchwork.freedesktop.org/series/71677/ State : warning == Summary == $ dim checkpatch origin/drm-tip 824985e34233 drm/i915: Replace vma parking with a clock aging algorithm -:272: CHECK:UNCOM

Re: [Intel-gfx] [PATCH v3 1/9] drm/amd/display: Align macro name as per DP spec

2020-01-06 Thread Alex Deucher
On Fri, Jan 3, 2020 at 6:53 PM Manasi Navare wrote: > > Harry, Jani - Since this also updates the AMD driver file, should this be > merged through > AMD tree and then backmerged to drm-misc ? Take it through whatever tree is easiest for you. Alex > > Manasi > > On Mon, Dec 30, 2019 at 09:45:15

[Intel-gfx] [PATCH] drm/i915: Replace vma parking with a clock aging algorithm

2020-01-06 Thread Chris Wilson
We cache the user's vma for a brief period of time after they close them so that if they are immediately reopened we avoid having to unbind and rebind them. This happens quite frequently for display servers which only keep a client's frame open for as long as they are copying from it, and so they o

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Use common priotree lists for virtual engine

2020-01-06 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Use common priotree lists for virtual engine URL : https://patchwork.freedesktop.org/series/71676/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7690 -> Patchwork_16008 =

Re: [Intel-gfx] [PATCH] drm/i915/display: Use external dependency loop for port sync

2020-01-06 Thread Manasi Navare
On Mon, Jan 06, 2020 at 06:28:23AM -0800, José Roberto de Souza wrote: > This loop was added directly to intel_atomic_check() to be used by > all other features that have external pipe dependencies, so using it > and removing intel_atomic_check_synced_crtcs(). > > After this changes is_trans_port_

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Use common priotree lists for virtual engine

2020-01-06 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Use common priotree lists for virtual engine URL : https://patchwork.freedesktop.org/series/71676/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4810a3ae500b drm/i915: Use common priotree lists for virtual engin

[Intel-gfx] [PATCH 1/2] drm/i915: Use common priotree lists for virtual engine

2020-01-06 Thread Chris Wilson
Since commit 422d7df4f090 ("drm/i915: Replace engine->timeline with a plain list"), we used the default embedded priotree slot for the virtual engine request queue, which means we can also use the same solitary slot with the scheduler. However, the priolist is expected to be guarded by the engine->

[Intel-gfx] [PATCH 2/2] drm/i915/gt: Allow temporary suspension of inflight requests

2020-01-06 Thread Chris Wilson
In order to support out-of-line error capture, we need to remove the active request from HW and put it to one side while a worker compresses and stores all the details associated with that request. (As that compression may take an arbitrary user-controlled amount of time, we want to let the engine

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Mark up virtual engine uabi_instance

2020-01-06 Thread Patchwork
== Series Details == Series: drm/i915/gt: Mark up virtual engine uabi_instance URL : https://patchwork.freedesktop.org/series/71657/ State : success == Summary == CI Bug Log - changes from CI_DRM_7684_full -> Patchwork_16003_full Summary --

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/6] drm/i915/selftests: Fixup sparse __user annotation on local var

2020-01-06 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915/selftests: Fixup sparse __user annotation on local var URL : https://patchwork.freedesktop.org/series/71656/ State : success == Summary == CI Bug Log - changes from CI_DRM_7684_full -> Patchwork_16002_full ===

[Intel-gfx] Help merging 2 patches into drm-intel (and/or drm-misc)

2020-01-06 Thread Hans de Goede
Hi Jani, I need your help merging this series, as it touches files in both drm-intel and drm-misc: https://patchwork.freedesktop.org/series/71637/ The first patch touches some i915 files, and applies cleanly to both dinq and drm-misc-next. The second patch relies on the first patch as well as

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Force the state compute phase once to enable PSR (rev4)

2020-01-06 Thread Patchwork
== Series Details == Series: drm/i915/display: Force the state compute phase once to enable PSR (rev4) URL : https://patchwork.freedesktop.org/series/7/ State : success == Summary == CI Bug Log - changes from CI_DRM_7688 -> Patchwork_16006 =

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Convert WARN* to use device-specific variants

2020-01-06 Thread Patchwork
== Series Details == Series: drm/i915: Convert WARN* to use device-specific variants URL : https://patchwork.freedesktop.org/series/71668/ State : failure == Summary == Applying: treewide: device: add condition support to dev_WARN Applying: drm/i915/i915_utils: add dev_WARN_ON and dev_WARN_ON_

Re: [Intel-gfx] [RFC 4/7] drm/i915: Make WARN* device specific where drm_device ptr available

2020-01-06 Thread Sam Ravnborg
Hi Pankaj. On Mon, Jan 06, 2020 at 10:53:23PM +0530, Pankaj Bharadiya wrote: > Device specific WARN* calls include device information in the > backtrace, so we know what device the warnings originate from. > > Covert all the calls of WARN* with device specific dev_WARN* > variants in functions wh

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Use external dependency loop for port sync

2020-01-06 Thread Patchwork
== Series Details == Series: drm/i915/display: Use external dependency loop for port sync URL : https://patchwork.freedesktop.org/series/71660/ State : success == Summary == CI Bug Log - changes from CI_DRM_7688 -> Patchwork_16005 Summary -

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Yield the timeslice if waiting on a semaphore

2020-01-06 Thread Patchwork
== Series Details == Series: drm/i915/gt: Yield the timeslice if waiting on a semaphore URL : https://patchwork.freedesktop.org/series/71654/ State : success == Summary == CI Bug Log - changes from CI_DRM_7683_full -> Patchwork_16000_full S

[Intel-gfx] [RFC 4/7] drm/i915: Make WARN* device specific where drm_device ptr available

2020-01-06 Thread Pankaj Bharadiya
Device specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific dev_WARN* variants in functions where drm_device struct pointer is readily available. The conversion was done automatical

[Intel-gfx] [RFC 7/7] drm/i915: Make WARN* device specific for various cases.

2020-01-06 Thread Pankaj Bharadiya
Device specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific dev_WARN* variants in functions where any one of intel_pm, intel_encoder, i915_perf_stream or intel_crtc_state struct poin

[Intel-gfx] [RFC 1/7] treewide: device: add condition support to dev_WARN

2020-01-06 Thread Pankaj Bharadiya
dev_WARN does not support conditional warning unlike WARN. Add condition support to dev_WARN (file: include/linux/device.h) to make it work like WARN and modify all existing callers to use it. This is quite useful where we want to replace existing WARN with dev_WARN. Following cocci script is us

[Intel-gfx] [RFC 3/7] drm/i915: add helper functions to get device ptr

2020-01-06 Thread Pankaj Bharadiya
We will need struct device pointer to pass it to dev_WARN* calls. Add helper functions to exract device pointer from various structs. Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/display/intel_display_types.h | 14 ++ drivers/gpu/drm/i915/gvt/gvt.h |

[Intel-gfx] [RFC 6/7] drm/i915: Make WARN* device specific where dev_priv can be extracted.

2020-01-06 Thread Pankaj Bharadiya
Device specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific dev_WARN* variants in functions where first function argument is a struct pointer and has drm_i915_private struct pointer

[Intel-gfx] [RFC 2/7] drm/i915/i915_utils: add dev_WARN_ON and dev_WARN_ON_ONCE macros

2020-01-06 Thread Pankaj Bharadiya
It's quite useful to print the device name on the stack dump caused by WARN_ON*. Introduce dev_WARN_ON and dev_WARN_ON_ONCE macros for the same. Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/i915_utils.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [RFC 0/7] drm/i915: Convert WARN* to use device-specific variants

2020-01-06 Thread Pankaj Bharadiya
Device specific dev_WARN and dev_WARN_ONCE macros available in kernel include device information in the backtrace, so we know what device the warnings originate from. Knowing the device specific information in the backtrace would be helpful in development all around. This patch series aims to con

Re: [Intel-gfx] [PATCH v2 2/2] drm/connector: Hookup the new drm_cmdline_mode panel_orientation member (v2)

2020-01-06 Thread Rodrigo Vivi
On Sun, Jan 05, 2020 at 04:51:20PM +0100, Hans de Goede wrote: > If the new video=... panel_orientation option is set for a connector, honor > it and setup a matching "panel orientation" property on the connector. > > Changes in v2: > -Improve DRM_INFO message to make it clear that the panel_orien

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gt: Always reset the timeslice after a context switch (rev2)

2020-01-06 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Always reset the timeslice after a context switch (rev2) URL : https://patchwork.freedesktop.org/series/71655/ State : success == Summary == CI Bug Log - changes from CI_DRM_7687 -> Patchwork_16004 ==

Re: [Intel-gfx] [alsa-devel] USB Type-C monitor flashes once when play a video file after unplug and re-plug the monitor

2020-01-06 Thread Lucien_Kao
Hi Takashi We verified on Ubuntu 19.10 with kernel 5.4.0.0-050400-generic (please refer to attachment), the result is positive which symptom doesn't happen anymore once I played music or video sound output through Dell S2718D Type-C monitor. It seems had some fix in latest kernel. Thanks. --

Re: [Intel-gfx] [PATCH v2] drm/i915: Limit audio CDCLK>=2*BCLK constraint back to GLK only

2020-01-06 Thread Matt Roper
On Fri, Jan 03, 2020 at 05:28:24PM +0200, Kai Vehmanen wrote: > Hi, > > On Thu, 2 Jan 2020, Rodrigo Vivi wrote: > > > On Tue, Dec 31, 2019 at 04:00:07PM +0200, Kai Vehmanen wrote: > >> Revert changes done in commit f6ec9483091f ("drm/i915: extend audio > >> CDCLK>=2*BCLK constraint to more platfo

Re: [Intel-gfx] [PATCH 7/7] drm/i915/tgl: Gen-12 display can decompress surfaces compressed by the media engine

2020-01-06 Thread Radhakrishna Sripada
On Wed, Jan 01, 2020 at 01:37:56AM +0200, Imre Deak wrote: > From: Dhinakaran Pandiyan > > Detect the modifier corresponding to media compression to enable > display decompression for YUV and xRGB packed formats. A new modifier is > added so that the driver can distinguish between media and rende

[Intel-gfx] [PATCH v3] drm/i915/display: Force the state compute phase once to enable PSR

2020-01-06 Thread José Roberto de Souza
Recent improvements in the state tracking in i915 caused PSR to not be enabled when reusing firmware/BIOS modeset, this is due to all initial commits returning ealier in intel_atomic_check() as needs_modeset() is always false. To fix that here forcing the state compute phase in CRTC that is drivin

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Mark up virtual engine uabi_instance

2020-01-06 Thread Patchwork
== Series Details == Series: drm/i915/gt: Mark up virtual engine uabi_instance URL : https://patchwork.freedesktop.org/series/71657/ State : success == Summary == CI Bug Log - changes from CI_DRM_7684 -> Patchwork_16003 Summary --- *

Re: [Intel-gfx] [PATCH] drm/i915/dp/mst : Get clock rate from sink's available PBN

2020-01-06 Thread kbuild test robot
Hi Lee, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v5.5-rc5 next-20200106] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '-

Re: [Intel-gfx] [PATCH] drm/i915/gt: Mark up virtual engine uabi_instance

2020-01-06 Thread Tvrtko Ursulin
On 06/01/2020 12:39, Chris Wilson wrote: Be sure to initialise the uabi_instance on the virtual engine to the special invalid value, just in case we ever peek at it from the uAPI. Reported-by: Tvrtko Ursulin Fixes: 750e76b4f9f6 ("drm/i915/gt: Move the [class][inst] lookup for engines onto th

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/6] drm/i915/selftests: Fixup sparse __user annotation on local var

2020-01-06 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915/selftests: Fixup sparse __user annotation on local var URL : https://patchwork.freedesktop.org/series/71656/ State : success == Summary == CI Bug Log - changes from CI_DRM_7684 -> Patchwork_16002 =

[Intel-gfx] [PATCH] drm/i915/display: Use external dependency loop for port sync

2020-01-06 Thread José Roberto de Souza
This loop was added directly to intel_atomic_check() to be used by all other features that have external pipe dependencies, so using it and removing intel_atomic_check_synced_crtcs(). After this changes is_trans_port_sync_master() it not used anywhere, so removing it. Cc: Ville Syrjälä Cc: Matt

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/6] drm/i915/selftests: Fixup sparse __user annotation on local var

2020-01-06 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915/selftests: Fixup sparse __user annotation on local var URL : https://patchwork.freedesktop.org/series/71656/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915/selftests: Fixup s

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/6] drm/i915/selftests: Fixup sparse __user annotation on local var

2020-01-06 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915/selftests: Fixup sparse __user annotation on local var URL : https://patchwork.freedesktop.org/series/71656/ State : warning == Summary == $ dim checkpatch origin/drm-tip 49a394caf3df drm/i915/selftests: Fixup sparse __user a

[Intel-gfx] [PATCH v2] drm/i915/gt: Yield the timeslice if waiting on a semaphore

2020-01-06 Thread Chris Wilson
If we find ourselves waiting on a MI_SEMAPHORE_WAIT, either within the user batch or in our own preamble, the engine raises a GT_WAIT_ON_SEMAPHORE interrupt. We can unmask that interrupt and so respond to a semaphore wait by yielding the timeslice, if we have another context to yield to! The only

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gt: Always reset the timeslice after a context switch

2020-01-06 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Always reset the timeslice after a context switch URL : https://patchwork.freedesktop.org/series/71655/ State : success == Summary == CI Bug Log - changes from CI_DRM_7683 -> Patchwork_16001 =

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/8] drm/i915/selftests: Fixup sparse __user annotation on local var

2020-01-06 Thread Patchwork
== Series Details == Series: series starting with [1/8] drm/i915/selftests: Fixup sparse __user annotation on local var URL : https://patchwork.freedesktop.org/series/71648/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7680_full -> Patchwork_15999_full ==

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Yield the timeslice if waiting on a semaphore

2020-01-06 Thread Patchwork
== Series Details == Series: drm/i915/gt: Yield the timeslice if waiting on a semaphore URL : https://patchwork.freedesktop.org/series/71654/ State : success == Summary == CI Bug Log - changes from CI_DRM_7683 -> Patchwork_16000 Summary ---

[Intel-gfx] [PATCH] drm/i915/gt: Mark up virtual engine uabi_instance

2020-01-06 Thread Chris Wilson
Be sure to initialise the uabi_instance on the virtual engine to the special invalid value, just in case we ever peek at it from the uAPI. Reported-by: Tvrtko Ursulin Fixes: 750e76b4f9f6 ("drm/i915/gt: Move the [class][inst] lookup for engines onto the GT") Signed-off-by: Chris Wilson Cc: Tvrtk

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: Yield the timeslice if waiting on a semaphore

2020-01-06 Thread Chris Wilson
Quoting Chris Wilson (2020-01-06 11:21:26) > If we find ourselves waiting on a MI_SEMAPHORE_WAIT, either within the > user batch or in our own preamble, the engine raises a > GT_WAIT_ON_SEMAPHORE interrupt. We can unmask that interrupt and so > respond to a semaphore wait by yielding the timeslice

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dp/mst : Get clock rate from sink's available PBN

2020-01-06 Thread Patchwork
== Series Details == Series: drm/i915/dp/mst : Get clock rate from sink's available PBN URL : https://patchwork.freedesktop.org/series/71647/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7680_full -> Patchwork_15998_full S

[Intel-gfx] [CI 2/6] drm/i915/selftests: Impose a timeout for request submission

2020-01-06 Thread Chris Wilson
Avoid spinning indefinitely waiting for the request to be submitted, and instead apply a timeout. A secondary benefit is that the error message will show which suspect is blocked. Signed-off-by: Chris Wilson Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 26

[Intel-gfx] [CI 6/6] drm/i915/gt: Use memset_p to clear the ports

2020-01-06 Thread Chris Wilson
Put memset_p to use to clear the array of pointers used for tracking the ELSP. Signed-off-by: Chris Wilson Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/gt/intel_lrc.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_lr

[Intel-gfx] [CI 1/6] drm/i915/selftests: Fixup sparse __user annotation on local var

2020-01-06 Thread Chris Wilson
The local var does not need the __user as it exists on the kernel stack and not a pointer into the __user address space. drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:989:9: warning: dereference of noderef expression drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:990:13: warning: derefer

[Intel-gfx] [CI 4/6] drm/i915/gt: Convert the final GEM_TRACE to GT_TRACE and co

2020-01-06 Thread Chris Wilson
Convert the few remaining GEM_TRACE() used for debugging over to the appropriate GT_TRACE or RQ_TRACE. References: 639f2f24895f ("drm/i915: Introduce new macros for tracing") Signed-off-by: Chris Wilson Cc: Venkata Sandeep Dhanalakota Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/gt/

[Intel-gfx] [CI 3/6] drm/i915: Merge i915_request.flags with i915_request.fence.flags

2020-01-06 Thread Chris Wilson
As we already have a flags field buried within i915_request, reuse it! Signed-off-by: Chris Wilson Reviewed-by: Maarten Lankhorst --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 2 +- .../gpu/drm/i915/gt/intel_engine_heartbeat.c | 2 +- drivers/gpu/drm/i915/gt/intel_lrc.c | 4

[Intel-gfx] [CI 5/6] drm/i915/gt: Drop mutex serialisation between context pin/unpin

2020-01-06 Thread Chris Wilson
The last remaining reason for serialising the pin/unpin of the intel_context is to ensure that our preallocated wakerefs are not consumed too early (i.e. the unpin of the previous phase does not emit the idle barriers for this phase before we even submit). All of the other operations within the con

Re: [Intel-gfx] [PATCH 7/8] drm/i915/gt: Drop mutex serialisation between context pin/unpin

2020-01-06 Thread Maarten Lankhorst
Op 06-01-2020 om 11:22 schreef Chris Wilson: > The last remaining reason for serialising the pin/unpin of the > intel_context is to ensure that our preallocated wakerefs are not > consumed too early (i.e. the unpin of the previous phase does not emit > the idle barriers for this phase before we eve

[Intel-gfx] [PATCH 2/2] drm/i915/gt: Yield the timeslice if waiting on a semaphore

2020-01-06 Thread Chris Wilson
If we find ourselves waiting on a MI_SEMAPHORE_WAIT, either within the user batch or in our own preamble, the engine raises a GT_WAIT_ON_SEMAPHORE interrupt. We can unmask that interrupt and so respond to a semaphore wait by yielding the timeslice (if we have another process to yield to!) The only

[Intel-gfx] [PATCH 1/2] drm/i915/gt: Always reset the timeslice after a context switch

2020-01-06 Thread Chris Wilson
Currently, we reset the timer after a pre-eemption event. This has the side-effect that the timeslice runs into the second context after the first is completed. To be more fair, we want to reset the clock after promotion as well. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/dr

[Intel-gfx] [PATCH] drm/i915/gt: Yield the timeslice if waiting on a semaphore

2020-01-06 Thread Chris Wilson
If we find ourselves waiting on a MI_SEMAPHORE_WAIT, either within the user batch or in our own preamble, the engine raises a GT_WAIT_ON_SEMAPHORE interrupt. We can unmask that interrupt and so respond to a semaphore wait by yielding the timeslice (if we have another process to yield to!) The only

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/8] drm/i915/selftests: Fixup sparse __user annotation on local var

2020-01-06 Thread Patchwork
== Series Details == Series: series starting with [1/8] drm/i915/selftests: Fixup sparse __user annotation on local var URL : https://patchwork.freedesktop.org/series/71648/ State : success == Summary == CI Bug Log - changes from CI_DRM_7680 -> Patchwork_15999

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/8] drm/i915/selftests: Fixup sparse __user annotation on local var

2020-01-06 Thread Patchwork
== Series Details == Series: series starting with [1/8] drm/i915/selftests: Fixup sparse __user annotation on local var URL : https://patchwork.freedesktop.org/series/71648/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915/selftests: Fixup spar

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/i915/selftests: Fixup sparse __user annotation on local var

2020-01-06 Thread Patchwork
== Series Details == Series: series starting with [1/8] drm/i915/selftests: Fixup sparse __user annotation on local var URL : https://patchwork.freedesktop.org/series/71648/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2b51023a3737 drm/i915/selftests: Fixup sparse __user anno

[Intel-gfx] [PATCH 7/8] drm/i915/gt: Drop mutex serialisation between context pin/unpin

2020-01-06 Thread Chris Wilson
The last remaining reason for serialising the pin/unpin of the intel_context is to ensure that our preallocated wakerefs are not consumed too early (i.e. the unpin of the previous phase does not emit the idle barriers for this phase before we even submit). All of the other operations within the con

[Intel-gfx] [PATCH 4/8] drm/i915: Merge i915_request.flags with i915_request.fence.flags

2020-01-06 Thread Chris Wilson
As we already have a flags field buried within i915_request, reuse it! Signed-off-by: Chris Wilson --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 2 +- .../gpu/drm/i915/gt/intel_engine_heartbeat.c | 2 +- drivers/gpu/drm/i915/gt/intel_lrc.c | 4 +- drivers/gpu/drm/i915/gt/inte

[Intel-gfx] [PATCH 3/8] drm/i915/gt: Convert the final GEM_TRACE to GT_TRACE and co

2020-01-06 Thread Chris Wilson
Convert the few remaining GEM_TRACE() used for debugging over to the appropriate GT_TRACE or RQ_TRACE. References: 639f2f24895f ("drm/i915: Introduce new macros for tracing") Signed-off-by: Chris Wilson Cc: Venkata Sandeep Dhanalakota --- drivers/gpu/drm/i915/gt/intel_context.c | 2 ++ drivers

[Intel-gfx] [PATCH 2/8] drm/i915/selftests: Impose a timeout for request submission

2020-01-06 Thread Chris Wilson
Avoid spinning indefinitely waiting for the request to be submitted, and instead apply a timeout. A secondary benefit is that the error message will show which suspect is blocked. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 26 +- 1 file chang

[Intel-gfx] [PATCH 5/8] drm/i915: Replace vma parking with a clock aging algorithm

2020-01-06 Thread Chris Wilson
We cache the user's vma for a brief period of time after they close them so that if they are immediately reopened we avoid having to unbind and rebind them. This happens quite frequently for display servers which only keep a client's frame open for as long as they are copying from it, and so they o

[Intel-gfx] [PATCH 8/8] drm/i915/gt: Use memset_p to clear the ports

2020-01-06 Thread Chris Wilson
Put memset_p to use to set the array of pointers used for tracking the ELSP. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_lrc.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/inte

[Intel-gfx] [PATCH 6/8] drm/i915: Only retire requests when eviction is allowed to blocked

2020-01-06 Thread Chris Wilson
We want to keep the PIN_NONBLOCK search quick, avoiding evicting recently active nodes. To that end, skip performing the more laborious retirement prior to beginning the fast search. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_evict.c | 6 -- 1 file changed, 4 insertions(+)

[Intel-gfx] [PATCH 1/8] drm/i915/selftests: Fixup sparse __user annotation on local var

2020-01-06 Thread Chris Wilson
The local var does not need the __user as it exists on the kernel stack and not a pointer into the __user address space. drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:989:9: warning: dereference of noderef expression drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:990:13: warning: derefer

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp/mst : Get clock rate from sink's available PBN

2020-01-06 Thread Patchwork
== Series Details == Series: drm/i915/dp/mst : Get clock rate from sink's available PBN URL : https://patchwork.freedesktop.org/series/71647/ State : success == Summary == CI Bug Log - changes from CI_DRM_7680 -> Patchwork_15998 Summary ---

[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915/dp/mst : Get clock rate from sink's available PBN

2020-01-06 Thread Patchwork
== Series Details == Series: drm/i915/dp/mst : Get clock rate from sink's available PBN URL : https://patchwork.freedesktop.org/series/71647/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel: a

Re: [Intel-gfx] [PATCH v3 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation

2020-01-06 Thread Manna, Animesh
On 04-01-2020 05:18, Manasi Navare wrote: On Thu, Jan 02, 2020 at 03:56:09PM +0530, Manna, Animesh wrote: On 02-01-2020 14:48, Jani Nikula wrote: On Mon, 30 Dec 2019, Animesh Manna wrote: vswing/pre-emphasis adjustment calculation is needed in processing of auto phy compliance request other t

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp/mst : Get clock rate from sink's available PBN

2020-01-06 Thread Patchwork
== Series Details == Series: drm/i915/dp/mst : Get clock rate from sink's available PBN URL : https://patchwork.freedesktop.org/series/71647/ State : warning == Summary == $ dim checkpatch origin/drm-tip aead470c8162 drm/i915/dp/mst : Get clock rate from sink's available PBN -:48: WARNING:LONG

[Intel-gfx] [PATCH] drm/i915/dp/mst : Get clock rate from sink's available PBN

2020-01-06 Thread Lee Shawn C
Driver report physcial bandwidth for max dot clock rate. It would caused compatibility issue sometimes when physical bandwidth exceed MST hub output ability. For example, here is a MST hub with HDMI 1.4 and DP 1.2 output. And source have DP 1.2 output capability. Connect a HDMI 2.0 display then so

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Fix inconsistent IS_ERR and PTR_ERR

2020-01-06 Thread Patchwork
== Series Details == Series: drm/i915/display: Fix inconsistent IS_ERR and PTR_ERR URL : https://patchwork.freedesktop.org/series/71642/ State : success == Summary == CI Bug Log - changes from CI_DRM_7680_full -> Patchwork_15997_full Summar

Re: [Intel-gfx] [PATCH v3] drm/i915: Re-init lspcon after HPD if lspcon probe failed

2020-01-06 Thread Kai-Heng Feng
Hi Jani, > On Dec 24, 2019, at 16:42, Kai-Heng Feng wrote: > > On HP 800 G4 DM, if HDMI cable isn't plugged before boot, the HDMI port > becomes useless and never responds to cable hotplugging: > [3.031904] [drm:lspcon_init [i915]] *ERROR* Failed to probe lspcon > [3.031945] [drm:intel_d