[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: update rawclk also on resume (rev2)

2019-10-31 Thread Patchwork
== Series Details == Series: drm/i915: update rawclk also on resume (rev2) URL : https://patchwork.freedesktop.org/series/68817/ State : failure == Summary == Applying: drm/i915: update rawclk also on resume Using index info to reconstruct a base tree... M drivers/gpu/drm/i915/display/in

[Intel-gfx] [PATCH v2] drm/i915: update rawclk also on resume

2019-10-31 Thread Lee Shawn C
Since CNP it's possible for rawclk to have two different values, 19.2 and 24 MHz. If the value indicated by SFUSE_STRAP register is different from the power on default for PCH_RAWCLK_FREQ, we'll end up having a mismatch between the rawclk hardware and software states after suspend/resume. On previo

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Add two spaces before the SKL_DFSM registers

2019-10-31 Thread Ramalingam C
On 2019-10-25 at 17:13:19 -0700, José Roberto de Souza wrote: > The next patches are going to touch this registers so here already > fixing it for older registers and make it consistent with most of > the other registers in this file. > > Cc: Ramalingam C > Signed-off-by: José Roberto de Souza >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission (rev3)

2019-10-31 Thread Patchwork
== Series Details == Series: drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission (rev3) URL : https://patchwork.freedesktop.org/series/68685/ State : success == Summary == CI Bug Log - changes from CI_DRM_7227_full -> Patchwork_15079_full =

Re: [Intel-gfx] [PATCH] drm/i915: update rawclk also on resume

2019-10-31 Thread Lee, Shawn C
On Thu, Oct 31, 2019, Ville Syrjala wrote: >On Thu, Oct 31, 2019 at 01:14:07PM +0200, Jani Nikula wrote: >> Since CNP it's possible for rawclk to have two different values, 19.2 >> and 24 MHz. If the value indicated by SFUSE_STRAP register is >> different from the power on default for PCH_RAWCLK

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [01/11] drm/i915: Split detaching and removing the vma

2019-10-31 Thread Patchwork
== Series Details == Series: series starting with [01/11] drm/i915: Split detaching and removing the vma URL : https://patchwork.freedesktop.org/series/68788/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7226_full -> Patchwork_15078_full =

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/psr: Share the computation of idle frames

2019-10-31 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/psr: Share the computation of idle frames URL : https://patchwork.freedesktop.org/series/68844/ State : success == Summary == CI Bug Log - changes from CI_DRM_7234 -> Patchwork_15097 =

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Split detaching and removing the vma

2019-10-31 Thread Patchwork
== Series Details == Series: drm/i915: Split detaching and removing the vma URL : https://patchwork.freedesktop.org/series/68787/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7226_full -> Patchwork_15077_full Summary -

Re: [Intel-gfx] [PATCH 0/5] tgl: MST support

2019-10-31 Thread Souza, Jose
I plan to debug MST with this patches next week but I guess at least the 4 first patches can be merged. The 5th too if someone else reviews it, the selection of the master transcoder was tested by me and Lucas and the problem in not in any of this patches. On Tue, 2019-10-29 at 18:24 -0700, Lucas

Re: [Intel-gfx] [PATCH 4/5] drm/i915: avoid reading DP_TP_CTL twice

2019-10-31 Thread Souza, Jose
On Tue, 2019-10-29 at 18:24 -0700, Lucas De Marchi wrote: > Just avoid the additional read in case DP_TP_CTL is enabled: > read it once and save the value. Reviewed-by: José Roberto de Souza > > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 33 -

Re: [Intel-gfx] [PATCH 3/5] drm/i915/tgl: do not enable transcoder clock twice on MST

2019-10-31 Thread Souza, Jose
On Tue, 2019-10-29 at 18:24 -0700, Lucas De Marchi wrote: > For MST on Tiger Lake there are different moments when we need to > configure the transcoder clock select. For the first link this is in > step > 7.a of the spec, before training the link. For additional streams > this > should be done as

Re: [Intel-gfx] [PATCH 2/5] drm/i915: add wrappers to get intel connector state

2019-10-31 Thread Souza, Jose
On Tue, 2019-10-29 at 18:24 -0700, Lucas De Marchi wrote: > Wrap drm_atomic_get_old_connector_state so we can get the > intel_digital_connector_state and make it easier to migrate to intel > types. Reviewed-by: José Roberto de Souza > > Signed-off-by: Lucas De Marchi > --- > .../gpu/drm/i915/

[Intel-gfx] [PATCH 2/3] drm/i915/dc3co: Check for DC3C0 exit state instead of sleep

2019-10-31 Thread José Roberto de Souza
DC3C0 could have already exit so no need to always sleep, so lets read the register with the state. Cc: Imre Deak Cc: Anshuman Gupta Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[Intel-gfx] [PATCH 3/3] drm/i915/dc3co: Avoid full modeset when EXITLINE needs to be changed

2019-10-31 Thread José Roberto de Souza
A recent change in BSpec allow us to change EXTLINE while transcoder is enabled so this allow us to change it even when doing the first fastset after taking over previous hardware state set by BIOS. BIOS don't enable PSR, so if sink supports PSR it will be enabled on the first fastset, so moving th

[Intel-gfx] [PATCH 1/3] drm/i915/psr: Share the computation of idle frames

2019-10-31 Thread José Roberto de Souza
Both activate functions and the dc3co disable function were doing the same thing, so better move to a function and share. Also while at it adding a WARN_ON to catch invalid values. Cc: Anshuman Gupta Cc: Imre Deak Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Spin on all engines simultaneously (rev3)

2019-10-31 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Spin on all engines simultaneously (rev3) URL : https://patchwork.freedesktop.org/series/68836/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7234 -> Patchwork_15096 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/fbdev: Fallback to non tiled mode if all tiles not present

2019-10-31 Thread Patchwork
== Series Details == Series: drm/fbdev: Fallback to non tiled mode if all tiles not present URL : https://patchwork.freedesktop.org/series/68838/ State : success == Summary == CI Bug Log - changes from CI_DRM_7234 -> Patchwork_15095 Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Preload LUTs if the hw isn't currently using them

2019-10-31 Thread Patchwork
== Series Details == Series: drm/i915: Preload LUTs if the hw isn't currently using them URL : https://patchwork.freedesktop.org/series/68785/ State : success == Summary == CI Bug Log - changes from CI_DRM_7226_full -> Patchwork_15076_full

[Intel-gfx] [CI] drm/i915/selftests: Spin on all engines simultaneously

2019-10-31 Thread Chris Wilson
Vanshidhar Konda asked for the simplest test "to verify that the kernel can submit and hardware can execute batch buffers on all the command streamers in parallel." We have a number of tests in userspace that submit load to each engine and verify that it is present, but strictly we have no selftest

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/fbdev: Fallback to non tiled mode if all tiles not present

2019-10-31 Thread Patchwork
== Series Details == Series: drm/fbdev: Fallback to non tiled mode if all tiles not present URL : https://patchwork.freedesktop.org/series/68838/ State : warning == Summary == $ dim checkpatch origin/drm-tip 64383a27c565 drm/fbdev: Fallback to non tiled mode if all tiles not present -:62: ERRO

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Spin on all engines simultaneously (rev2)

2019-10-31 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Spin on all engines simultaneously (rev2) URL : https://patchwork.freedesktop.org/series/68836/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7234 -> Patchwork_15094 Summary

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Spin on all engines simultaneously

2019-10-31 Thread Vanshidhar Konda
On Thu, Oct 31, 2019 at 09:23:36PM +, Chris Wilson wrote: Vanshidhar Konda asked for the simplest test "to verify that the kernel can submit and hardware can execute batch buffers on all the command streamers in parallel." We have a number of tests in userspace that submit load to each engine

[Intel-gfx] [PATCH] drm/fbdev: Fallback to non tiled mode if all tiles not present

2019-10-31 Thread Manasi Navare
In case of tiled displays, if we hotplug just one connector, fbcon currently just selects the preferred mode and if it is tiled mode then that becomes a problem if rest of the tiles are not present. So in the fbdev driver on hotplug when we probe the client modeset, we we dont find all the connecto

[Intel-gfx] [PATCH] drm/i915/selftests: Spin on all engines simultaneously

2019-10-31 Thread Chris Wilson
Vanshidhar Konda asked for the simplest test "to verify that the kernel can submit and hardware can execute batch buffers on all the command streamers in parallel." We have a number of tests in userspace that submit load to each engine and verify that it is present, but strictly we have no selftest

[Intel-gfx] [PATCH] drm/i915/selftests: Spin on all engines simultaneously

2019-10-31 Thread Chris Wilson
Vanshidhar Konda asked for the simplest test "to verify that the kernel can submit and hardware can execute batch buffers on all the command streamers in parallel." We have a number of tests in userspace that submit load to each engine and verify that it is present, but strictly we have no selftest

Re: [Intel-gfx] [RESEND PATCH] drm/dp: Increase link status size

2019-10-31 Thread Lyude Paul
Whoops, replied to the wrong one Reviewed-by: Lyude Paul On Tue, 2019-10-29 at 15:03 +0100, Thierry Reding wrote: > From: Thierry Reding > > The current link status contains bytes 0x202 through 0x207, but we also > want to make sure to include the DP_ADJUST_REQUEST_POST_CURSOR2 (0x20c) > so tha

Re: [Intel-gfx] [PATCH] drm/i915/lmem: add the fake lmem region

2019-10-31 Thread Chris Wilson
Quoting Arkadiusz Hiler (2019-10-31 12:40:35) > On Wed, Oct 30, 2019 at 10:22:37PM +, Matthew Auld wrote: > > On Tue, 29 Oct 2019 at 16:51, Matthew Auld wrote: > > > > > > Intended for upstream testing so that we can still exercise the LMEM > > > plumbing and !i915_ggtt_has_aperture paths. Smo

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/lmem: add the fake lmem region (rev2)

2019-10-31 Thread Patchwork
== Series Details == Series: drm/i915/lmem: add the fake lmem region (rev2) URL : https://patchwork.freedesktop.org/series/68733/ State : success == Summary == CI Bug Log - changes from CI_DRM_7226_full -> Patchwork_15075_full Summary -

[Intel-gfx] [PULL] drm-misc-next

2019-10-31 Thread Sean Paul
Hi Dave & Daniel, Here's the last -misc-next pull request for 5.5. Lots of refactoring going on this week which results in a negative diffstat. Only thing to highlight is the dma-buf heap introduction and revert, which you are already aware of, so hopefully no other surprises here. drm-misc-next-

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Replace rcu_swap_protected() with rcu_replace_pointer()

2019-10-31 Thread Patchwork
== Series Details == Series: drm/i915: Replace rcu_swap_protected() with rcu_replace_pointer() URL : https://patchwork.freedesktop.org/series/68833/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/gen

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Expose more formats

2019-10-31 Thread Patchwork
== Series Details == Series: drm/i915: Expose more formats URL : https://patchwork.freedesktop.org/series/68832/ State : success == Summary == CI Bug Log - changes from CI_DRM_7233 -> Patchwork_15092 Summary --- **SUCCESS** No reg

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Skip MCHBAR queries on dgfx

2019-10-31 Thread Patchwork
== Series Details == Series: drm/i915: Skip MCHBAR queries on dgfx URL : https://patchwork.freedesktop.org/series/68829/ State : success == Summary == CI Bug Log - changes from CI_DRM_7233 -> Patchwork_15091 Summary --- **SUCCESS**

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp: Do not switch aux to TBT mode for non-TC ports (rev2)

2019-10-31 Thread Souza, Jose
On Thu, 2019-10-31 at 05:38 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/dp: Do not switch aux to TBT mode for non-TC ports > (rev2) > URL : https://patchwork.freedesktop.org/series/68691/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_7221_full

Re: [Intel-gfx] [PATCH v2] kernel-doc: rename the kernel-doc directive 'functions' to 'identifiers'

2019-10-31 Thread Changbin Du
On Tue, Oct 29, 2019 at 02:00:27AM -0600, Jonathan Corbet wrote: > On Tue, 29 Oct 2019 08:31:22 +0800 > Changbin Du wrote: > > > Here python is different from C. Both empty string and None are False in > > python. > > Note such condition is common in python. > > Treating both as a False value i

[Intel-gfx] [tip: core/rcu] drm/i915: Replace rcu_swap_protected() with rcu_replace_pointer()

2019-10-31 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 1feace5d6a4a1acf44dde2bfb5c36cc0b1cf559c Gitweb: https://git.kernel.org/tip/1feace5d6a4a1acf44dde2bfb5c36cc0b1cf559c Author:Paul E. McKenney AuthorDate:Mon, 23 Sep 2019 15:22:15 -07:00 Committ

[Intel-gfx] [PULL] drm-intel-fixes

2019-10-31 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2019-10-31: - Fix PCH reference clock for FDI on HSW/BDW which was causing users blank screen - Small documentation fix for TGL display PLLs Thanks, Rodrigo. The following changes since commit d6d5df1db6e9d7f8f76d2911707f7d5877251b02: Linux 5.4-

Re: [Intel-gfx] [RFC PATCH i-g-t v4 4/4] tests/gem_ctx_shared: Align objects using minimum GTT alignment

2019-10-31 Thread Vanshidhar Konda
On Thu, Oct 31, 2019 at 04:28:57PM +0100, Janusz Krzysztofik wrote: exec-shared-gtt-* subtests use hardcoded values for object size and softpin offset, based on 4kB GTT alignment assumption. That may result in those subtests failing when run on future backing stores with possibly larger minimum

Re: [Intel-gfx] [RFC PATCH i-g-t v4 1/4] tests/gem_exec_reloc: Don't filter out invalid addresses

2019-10-31 Thread Vanshidhar Konda
May be this patch can just be merged with the other patch in this series that changes gem_exec_reloc. Vanshi On Thu, Oct 31, 2019 at 04:28:54PM +0100, Janusz Krzysztofik wrote: Commit a355b2d6eb42 ("igt/gem_exec_reloc: Filter out unavailable addresses for !ppgtt") introduced filtering of addres

Re: [Intel-gfx] [RFC PATCH i-g-t v4 2/4] lib: Add minimum GTT alignment helper

2019-10-31 Thread Vanshidhar Konda
On Thu, Oct 31, 2019 at 04:28:55PM +0100, Janusz Krzysztofik wrote: Some tests assume 4kB offset alignment while using softpin. That assumption may be wrong on future GEM backends with possibly larger minimum page sizes. As a result, those tests may either fail on softpin at offsets which are i

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Perform some basic cycle counting of MI ops (rev2)

2019-10-31 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Perform some basic cycle counting of MI ops (rev2) URL : https://patchwork.freedesktop.org/series/68824/ State : success == Summary == CI Bug Log - changes from CI_DRM_7231 -> Patchwork_15090

[Intel-gfx] [PATCH 3/7] drm/i915: Add missing 10bpc formats for pipe B sprites on CHV

2019-10-31 Thread Ville Syrjala
From: Ville Syrjälä CHV pipe B sprites gained support for the 10bpc X/ARGB pixel formats. On VLV and CHV pipe A/C these are only supported by the primary plane. Add the require bits to expose the new formats. v2: Reorder the formats for consistency Signed-off-by: Ville Syrjälä Reviewed-by: Uma

[Intel-gfx] [PATCH 6/7] drm/i915: Sort format arrays consistently

2019-10-31 Thread Ville Syrjala
From: Ville Syrjälä Let's try to keep the pixel format arrays somewhat sorted: 1. RGB before YUV 2. smaller bpp before larger bpp 3. X before A 4. RGB before BGR Signed-off-by: Ville Syrjälä Reviewed-by: Juha-Pekka Heikkila Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_disp

[Intel-gfx] [PATCH 5/7] drm/i915: Add 10bpc formats with alpha for icl+

2019-10-31 Thread Ville Syrjala
From: Ville Syrjälä ICL+ again supports alpha blending with 10bpc pixel formats. Expose them. v2: Add all the stuff I missed earlier! Signed-off-by: Ville Syrjälä Reviewed-by: Juha-Pekka Heikkila Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_display.c | 19 +++-

[Intel-gfx] [PATCH 2/7] drm/i915: Expose alpha formats on VLV/CHV primary planes

2019-10-31 Thread Ville Syrjala
From: Ville Syrjälä Currently we expose VLV/CHV alpha blending only on the sprite planes, but the primary planes can do it as well. Let's flip it on. v2: Rebase due to fp16 landing Signed-off-by: Ville Syrjälä Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_display.c | 62 +++

[Intel-gfx] [PATCH 0/7] drm/i915: Expose more formats

2019-10-31 Thread Ville Syrjala
From: Ville Syrjälä Same series as before but fp16 caused a bunch of rebasing. I also dropped the ckey stuff for now. It's probably time to write actual tests for that stuff. Everything here is reviewed already. Ville Syrjälä (7): drm/i915: Expose 10:10:10 XRGB formats on SNB-BDW sprites d

[Intel-gfx] [PATCH 4/7] drm/i915: Expose C8 on VLV/CHV sprite planes

2019-10-31 Thread Ville Syrjala
From: Ville Syrjälä VLV/CHV sprite planes also support the C8 format. Let's expose that. Signed-off-by: Ville Syrjälä Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_sprite.c | 6 ++ drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 7 insertions(+) diff

[Intel-gfx] [PATCH 7/7] drm/i915: Eliminate redundancy in intel_primary_plane_create()

2019-10-31 Thread Ville Syrjala
From: Ville Syrjälä Lots of redundant assignments inside intel_primary_plane_create(). Get rid of them. v2: Rebase due to fp16 landing Signed-off-by: Ville Syrjälä Reviewed-by: Juha-Pekka Heikkila Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_display.c | 60 +++

[Intel-gfx] [PATCH 1/7] drm/i915: Expose 10:10:10 XRGB formats on SNB-BDW sprites

2019-10-31 Thread Ville Syrjala
From: Ville Syrjälä SNB-BDW support 10:10:10 formats on the sprite planes. Let's expose them. v2: Rebase due to fp16 landing Signed-off-by: Ville Syrjälä Reviewed-by: Juha-Pekka Heikkila Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_sprite.c | 16 1 file c

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: drop guc shared area

2019-10-31 Thread Matthew Brost
On Wed, Oct 30, 2019 at 06:30:40PM -0700, Daniele Ceraolo Spurio wrote: Recent GuC doesn't require the shared area. We still have one user in i915 (engine reset via guc) because we haven't updated the command to match the current guc submission flow [1]. Since the flow in guc is about to change a

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,01/12] drm/i915: Handle a few more cases for crtc hw/uapi split, v3.

2019-10-31 Thread Patchwork
== Series Details == Series: series starting with [CI,01/12] drm/i915: Handle a few more cases for crtc hw/uapi split, v3. URL : https://patchwork.freedesktop.org/series/68775/ State : success == Summary == CI Bug Log - changes from CI_DRM_7224_full -> Patchwork_15074_full ===

Re: [Intel-gfx] [PATCH 1/2] drm/i915: drop lrc header page

2019-10-31 Thread Matthew Brost
On Wed, Oct 30, 2019 at 06:30:39PM -0700, Daniele Ceraolo Spurio wrote: Recent GuC binaries (including all the ones we're currently using) don't require this shared area anymore, having moved the relevant entries into the stage pool instead. i915 itself doesn't write anything into it either, so w

Re: [Intel-gfx] [igt-dev] [RFC PATCH i-g-t v3] tests/gem_exec_reloc: Don't filter out invalid addresses

2019-10-31 Thread Vanshidhar Konda
On Thu, Oct 31, 2019 at 08:40:58AM +0100, Janusz Krzysztofik wrote: On Wednesday, October 30, 2019 10:19:43 PM CET Vanshidhar Konda wrote: On Wed, Oct 30, 2019 at 06:15:35PM +0100, Janusz Krzysztofik wrote: >Commit a355b2d6eb42 ("igt/gem_exec_reloc: Filter out unavailable >addresses for !ppgtt")

Re: [Intel-gfx] [PATCH] drm/i915: Skip MCHBAR queries on dgfx

2019-10-31 Thread Ville Syrjälä
On Thu, Oct 31, 2019 at 08:11:24AM -0700, Stuart Summers wrote: > dgfx does not map the MCHBAR MMIO into the GFX device BAR. > Skip this sequence when running on dgfx. > > Signed-off-by: Stuart Summers Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/i915_drv.c | 2 +- > 1 file changed

[Intel-gfx] [RFC PATCH i-g-t v4 0/4] Calculate softpin offsets from minimum GTT alignment

2019-10-31 Thread Janusz Krzysztofik
Some tests assume 4kB page size while using softpin. That assumption may be wrong on future GEM backends with possibly larger minimum page sizes. As a result, those tests may either fail on softpin at offsets which are incorrectly aligned, may silently skip such incorrectly aligned addresses assu

[Intel-gfx] [RFC PATCH i-g-t v4 2/4] lib: Add minimum GTT alignment helper

2019-10-31 Thread Janusz Krzysztofik
Some tests assume 4kB offset alignment while using softpin. That assumption may be wrong on future GEM backends with possibly larger minimum page sizes. As a result, those tests may either fail on softpin at offsets which are incorrectly aligned, may silently skip such incorrectly aligned address

[Intel-gfx] [RFC PATCH i-g-t v4 1/4] tests/gem_exec_reloc: Don't filter out invalid addresses

2019-10-31 Thread Janusz Krzysztofik
Commit a355b2d6eb42 ("igt/gem_exec_reloc: Filter out unavailable addresses for !ppgtt") introduced filtering of addresses possibly occupied by other users of shared GTT. Unfortunately, that filtering doesn't distinguish between actually occupied addresses and otherwise invalid softpin offsets. As

[Intel-gfx] [RFC PATCH i-g-t v4 4/4] tests/gem_ctx_shared: Align objects using minimum GTT alignment

2019-10-31 Thread Janusz Krzysztofik
exec-shared-gtt-* subtests use hardcoded values for object size and softpin offset, based on 4kB GTT alignment assumption. That may result in those subtests failing when run on future backing stores with possibly larger minimum page sizes. Replace hardcoded constants with values calculated from m

[Intel-gfx] [RFC PATCH i-g-t v4 3/4] tests/gem_exec_reloc: Calculate offsets from minimum GTT alignment

2019-10-31 Thread Janusz Krzysztofik
The basic-range subtest assumes 4kB GTT alignment while calculating softpin offsets. On future backends with possibly larger minimum page sizes the test will fail as a half of calculated offsets to be tested will be incorrectly aligned. Replace hardcoded constants corresponding to the assumed 4kB

[Intel-gfx] [PATCH] drm/i915: Skip MCHBAR queries on dgfx

2019-10-31 Thread Stuart Summers
dgfx does not map the MCHBAR MMIO into the GFX device BAR. Skip this sequence when running on dgfx. Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/i915_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_dr

Re: [Intel-gfx] [PATCH 07/12] drm/i915: Add aliases for uapi and hw to plane_state

2019-10-31 Thread Ville Syrjälä
On Thu, Oct 31, 2019 at 12:26:05PM +0100, Maarten Lankhorst wrote: > Prepare to split up hw and uapi machinally, by adding a uapi and > hw alias. We will remove the base in a bit. This is a split from the > original uapi/hw patch, which did it all in one go. > > Signed-off-by: Maarten Lankhorst >

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Verify context register state before execution

2019-10-31 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2019-10-31 14:32:05) >> Chris Wilson writes: >> >> > Check that the context's ring register state still matches our >> > expectations prior to execution. >> > >> > Signed-off-by: Chris Wilson >> > Cc: Mika Kuoppala >> > --- >> > drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH 02/12] drm/i915: Add aliases for uapi and hw to crtc_state

2019-10-31 Thread Ville Syrjälä
On Thu, Oct 31, 2019 at 12:26:00PM +0100, Maarten Lankhorst wrote: > Prepare to split up hw and uapi machinally, by adding a uapi and > hw alias. We will remove the base in a bit. This is a split from the > original uapi/hw patch, which did it all in one go. > > Signed-off-by: Maarten Lankhorst

Re: [Intel-gfx] [PATCH 09/12] drm/i915: Perform automated conversions for plane uapi/hw split, base -> hw.

2019-10-31 Thread Ville Syrjälä
On Thu, Oct 31, 2019 at 12:26:07PM +0100, Maarten Lankhorst wrote: > Split up plane_state->base to hw. This is done using the following patch: > > @@ > struct intel_plane_state *T; > identifier x =~ > "^(crtc|fb|alpha|pixel_blend_mode|rotation|color_encoding|color_range)$"; > @@ > -T->base.x > +T

[Intel-gfx] [PATCH v2] drm/i915/selftests: Perform some basic cycle counting of MI ops

2019-10-31 Thread Chris Wilson
Some basic information that is useful to know, such as how many cycles is a MI_NOOP. Signed-off-by: Chris Wilson Cc: Anna Karas Cc: Tvrtko Ursulin --- Having remember to ask for a fixed frequency! --- drivers/gpu/drm/i915/gt/selftest_engine_cs.c | 339 +- .../drm/i915/selftest

Re: [Intel-gfx] [PATCH 06/12] drm/i915: Complete crtc hw/uapi split, v6.

2019-10-31 Thread Ville Syrjälä
On Thu, Oct 31, 2019 at 12:26:04PM +0100, Maarten Lankhorst wrote: > Now that we separated everything into uapi and hw, it's > time to make the split definitive. Remove the union and > make a copy of the hw state on modeset and fastset. > > Color blobs are copied in crtc atomic_check(), right > be

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Verify context register state before execution

2019-10-31 Thread Chris Wilson
Quoting Mika Kuoppala (2019-10-31 14:32:05) > Chris Wilson writes: > > > Check that the context's ring register state still matches our > > expectations prior to execution. > > > > Signed-off-by: Chris Wilson > > Cc: Mika Kuoppala > > --- > > drivers/gpu/drm/i915/gt/intel_lrc.c | 73 ++

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Pretty print the i915_active

2019-10-31 Thread Mika Kuoppala
Chris Wilson writes: > If the idle_pulse fails to flush the i915_active, dump the tree to see > if that has any clues. > > Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala > --- > .../drm/i915/gt/selftest_engine_heartbeat.c | 4 ++ > drivers/gpu/drm/i915/i915_active.h|

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Pretty print the i915_active

2019-10-31 Thread Chris Wilson
Quoting Chris Wilson (2019-10-31 14:18:56) > My memory says, and my assumption in this code, is that the > the iterator is safe against insertions -- we won't get horribly lost if > the tree is rebalanced as we walk. Actually, the iterator is not perfect across rebalances. It won't matter here in

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Verify context register state before execution

2019-10-31 Thread Mika Kuoppala
Chris Wilson writes: > Check that the context's ring register state still matches our > expectations prior to execution. > > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/intel_lrc.c | 73 - > drivers/gpu/drm/i915/gt/intel_lrc_reg.h

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/12] drm/i915: Handle a few more cases for crtc hw/uapi split, v3.

2019-10-31 Thread Patchwork
== Series Details == Series: series starting with [01/12] drm/i915: Handle a few more cases for crtc hw/uapi split, v3. URL : https://patchwork.freedesktop.org/series/68818/ State : success == Summary == CI Bug Log - changes from CI_DRM_7228 -> Patchwork_15089

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Pretty print the i915_active

2019-10-31 Thread Chris Wilson
Quoting Mika Kuoppala (2019-10-31 14:11:58) > Chris Wilson writes: > > > If the idle_pulse fails to flush the i915_active, dump the tree to see > > if that has any clues. > > > > Signed-off-by: Chris Wilson > > --- > > .../drm/i915/gt/selftest_engine_heartbeat.c | 4 ++ > > drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Pretty print the i915_active

2019-10-31 Thread Mika Kuoppala
Chris Wilson writes: > If the idle_pulse fails to flush the i915_active, dump the tree to see > if that has any clues. > > Signed-off-by: Chris Wilson > --- > .../drm/i915/gt/selftest_engine_heartbeat.c | 4 ++ > drivers/gpu/drm/i915/i915_active.h| 2 + > drivers/gpu/drm/i915/se

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/12] drm/i915: Handle a few more cases for crtc hw/uapi split, v3.

2019-10-31 Thread Patchwork
== Series Details == Series: series starting with [01/12] drm/i915: Handle a few more cases for crtc hw/uapi split, v3. URL : https://patchwork.freedesktop.org/series/68818/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9b2cc20d8bdd drm/i915: Handle a few more cases for crtc h

[Intel-gfx] [PATCH] drm/i915/selftests: Perform some basic cycle counting of MI ops

2019-10-31 Thread Chris Wilson
Some basic information that is useful to know, such as how many cycles is a MI_NOOP. Signed-off-by: Chris Wilson Cc: Anna Karas Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/selftest_engine_cs.c | 324 +- .../drm/i915/selftests/i915_live_selftests.h | 1 + 2 files changed,

Re: [Intel-gfx] [PATCH] drm/i915: update rawclk also on resume

2019-10-31 Thread Ville Syrjälä
On Thu, Oct 31, 2019 at 01:14:07PM +0200, Jani Nikula wrote: > Since CNP it's possible for rawclk to have two different values, 19.2 > and 24 MHz. If the value indicated by SFUSE_STRAP register is different > from the power on default for PCH_RAWCLK_FREQ, we'll end up having a > mismatch between th

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: update rawclk also on resume

2019-10-31 Thread Patchwork
== Series Details == Series: drm/i915: update rawclk also on resume URL : https://patchwork.freedesktop.org/series/68817/ State : success == Summary == CI Bug Log - changes from CI_DRM_7228 -> Patchwork_15088 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 01/11] drm/i915: Split detaching and removing the vma

2019-10-31 Thread Matthew Auld
On Wed, 30 Oct 2019 at 19:22, Chris Wilson wrote: > > In order to keep the assert_bind_count() valid, we need to hold the vma > page reference until after we drop the bind count. However, we must also > keep the drm_mm_remove_node() as the last action of i915_vma_unbind() so > that it serialises w

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Plump dev_priv all the way to icl_{hdr, sdr_y}_plane_mask()

2019-10-31 Thread Ruhl, Michael J
Minor nit. s/Plump/Plumb/ M >-Original Message- >From: Intel-gfx On Behalf Of Ville >Syrjala >Sent: Thursday, October 31, 2019 6:59 AM >To: intel-gfx@lists.freedesktop.org >Subject: [Intel-gfx] [PATCH 4/4] drm/i915: Plump dev_priv all the way to >icl_{hdr, sdr_y}_plane_mask() > >From:

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Assert that the idle_pulse is sent

2019-10-31 Thread Mika Kuoppala
Chris Wilson writes: > When checking the heartbeat pulse, we expect it to have been sent by the > time we have slept. We can verify this by checking the engine serial > number to see if that matches the predicted pulse serial. It will always > be true if, and only if, the pulse was sent by itself

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Simplfy LVDS crtc_mask setup

2019-10-31 Thread Juha-Pekka Heikkila
From this set patches 2,5,6 look all ok to me. Reviewed-by: Juha-Pekka Heikkila On 2.10.2019 19.25, Ville Syrjala wrote: From: Ville Syrjälä We don't need to special case PCH vs. gen4 when setting up the LVDS crtc_mask. Just claim pipes A|B|C work and intel_encoder_possible_crtcs() will drop

Re: [Intel-gfx] [PATCH] drm/i915/lmem: add the fake lmem region

2019-10-31 Thread Arkadiusz Hiler
On Wed, Oct 30, 2019 at 10:22:37PM +, Matthew Auld wrote: > On Tue, 29 Oct 2019 at 16:51, Matthew Auld wrote: > > > > Intended for upstream testing so that we can still exercise the LMEM > > plumbing and !i915_ggtt_has_aperture paths. Smoke tested on Skull Canyon > > device. This works by allo

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915: Drop GEM context as a direct link from i915_request (rev2)

2019-10-31 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Drop GEM context as a direct link from i915_request (rev2) URL : https://patchwork.freedesktop.org/series/68769/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7223_full -> Patchwork_15073_full =

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Drop inspection of execbuf flags during evict

2019-10-31 Thread Patchwork
== Series Details == Series: drm/i915: Drop inspection of execbuf flags during evict URL : https://patchwork.freedesktop.org/series/68816/ State : success == Summary == CI Bug Log - changes from CI_DRM_7228 -> Patchwork_15087 Summary --

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/5] drm/i915/gt: Always track callers to intel_rps_mark_interactive()

2019-10-31 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/gt: Always track callers to intel_rps_mark_interactive() URL : https://patchwork.freedesktop.org/series/68770/ State : success == Summary == CI Bug Log - changes from CI_DRM_7223_full -> Patchwork_15072_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Always track callers to intel_rps_mark_interactive() (rev2)

2019-10-31 Thread Patchwork
== Series Details == Series: drm/i915/gt: Always track callers to intel_rps_mark_interactive() (rev2) URL : https://patchwork.freedesktop.org/series/68764/ State : success == Summary == CI Bug Log - changes from CI_DRM_7223_full -> Patchwork_15071_full =

Re: [Intel-gfx] [CI 08/12] drm/i915: Perform manual conversions for plane uapi/hw split, v2.

2019-10-31 Thread Maarten Lankhorst
Op 31-10-2019 om 11:30 schreef Ville Syrjälä: > On Thu, Oct 31, 2019 at 10:15:41AM +0100, Maarten Lankhorst wrote: >> Op 30-10-2019 om 17:19 schreef Ville Syrjälä: >>> On Wed, Oct 30, 2019 at 03:26:53PM +0100, Maarten Lankhorst wrote: get_crtc_from_states() is called before plane_state is copi

[Intel-gfx] [PATCH 04/12] drm/i915: Perform automated conversions for crtc uapi/hw split, base -> hw.

2019-10-31 Thread Maarten Lankhorst
Split up crtc_state->base to hw where appropriate. This is done using the following patch: @@ struct intel_crtc_state *T; identifier x =~ "^(active|enable|degamma_lut|gamma_lut|ctm|mode|adjusted_mode)$"; @@ -T->base.x +T->hw.x @@ struct drm_crtc_state *T; identifier x =~ "^(active|enable|degam

[Intel-gfx] [PATCH 09/12] drm/i915: Perform automated conversions for plane uapi/hw split, base -> hw.

2019-10-31 Thread Maarten Lankhorst
Split up plane_state->base to hw. This is done using the following patch: @@ struct intel_plane_state *T; identifier x =~ "^(crtc|fb|alpha|pixel_blend_mode|rotation|color_encoding|color_range)$"; @@ -T->base.x +T->hw.x Signed-off-by: Maarten Lankhorst Reviewed-by: Ville Syrjälä --- drivers/gp

[Intel-gfx] [PATCH 10/12] drm/i915: Perform automated conversions for plane uapi/hw split, base -> uapi.

2019-10-31 Thread Maarten Lankhorst
Split up plane_state->base to uapi. This is done using the following patch, ran after the previous commit that splits out any hw references: @@ struct intel_plane_state *T; identifier x; @@ -T->base.x +T->uapi.x @@ struct intel_plane_state *T; @@ -T->base +T->uapi Signed-off-by: Maarten Lankhors

[Intel-gfx] [PATCH 03/12] drm/i915: Perform manual conversions for crtc uapi/hw split, v2.

2019-10-31 Thread Maarten Lankhorst
intel_get_load_detect_pipe() needs to set uapi active, uapi enable is set by the call to drm_atomic_set_mode_for_crtc(), so we can remove it. intel_pipe_config_compare() needs to look at hw state, but I didn't change spatch to look at it. It's easy enough to do manually. intel_atomic_check() defi

[Intel-gfx] [PATCH 02/12] drm/i915: Add aliases for uapi and hw to crtc_state

2019-10-31 Thread Maarten Lankhorst
Prepare to split up hw and uapi machinally, by adding a uapi and hw alias. We will remove the base in a bit. This is a split from the original uapi/hw patch, which did it all in one go. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_atomic.c | 8 -- drivers/gpu/dr

[Intel-gfx] [PATCH 07/12] drm/i915: Add aliases for uapi and hw to plane_state

2019-10-31 Thread Maarten Lankhorst
Prepare to split up hw and uapi machinally, by adding a uapi and hw alias. We will remove the base in a bit. This is a split from the original uapi/hw patch, which did it all in one go. Signed-off-by: Maarten Lankhorst --- .../gpu/drm/i915/display/intel_atomic_plane.c| 16 .

[Intel-gfx] [PATCH 12/12] drm/i915: Remove special case slave handling during hw programming, v3.

2019-10-31 Thread Maarten Lankhorst
Now that we split plane_state which I didn't want to do yet, we can program the slave plane without requiring the master plane. This is useful for programming bigjoiner slave planes as well. We will no longer need the master's plane_state. Changes since v1: - set src/dst rectangles after copy_uap

[Intel-gfx] [PATCH 11/12] drm/i915: Complete plane hw and uapi split, v2.

2019-10-31 Thread Maarten Lankhorst
Splitting plane state is easier than splitting crtc_state, before plane check we copy the drm properties to hw so we can do the same in bigjoiner later on. We copy the state after we did all the modeset handling, but fortunately i915 seems to be split correctly and nothing during modeset looks at

[Intel-gfx] [PATCH 06/12] drm/i915: Complete crtc hw/uapi split, v6.

2019-10-31 Thread Maarten Lankhorst
Now that we separated everything into uapi and hw, it's time to make the split definitive. Remove the union and make a copy of the hw state on modeset and fastset. Color blobs are copied in crtc atomic_check(), right before color management is checked. Changes since v1: - Copy all blobs immediate

[Intel-gfx] [PATCH 01/12] drm/i915: Handle a few more cases for crtc hw/uapi split, v3.

2019-10-31 Thread Maarten Lankhorst
We are still looking at drm_crtc_state in a few places, convert those to use intel_crtc_state instead. Changes since v1: - Move to before uapi/hw split. - Add hunks for intel_pm.c as well. Changes since v2: - Incorporate Ville's feedback. Signed-off-by: Maarten Lankhorst Reviewed-by: Matt Roper

[Intel-gfx] [PATCH 08/12] drm/i915: Perform manual conversions for plane uapi/hw split, v2.

2019-10-31 Thread Maarten Lankhorst
get_crtc_from_states() is called before plane_state is copied to uapi, so use the uapi state there. intel_legacy_cursor_update() could probably get away with looking at the hw state, but for clarity always look at the uapi state. Changes since v1: - Convert entirety of intel_legacy_cursor_update

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/4] drm/i915: s/icl_is_nv12_y_plane/icl_is_sdr_y_plane/

2019-10-31 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: s/icl_is_nv12_y_plane/icl_is_sdr_y_plane/ URL : https://patchwork.freedesktop.org/series/68815/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK

[Intel-gfx] [PATCH] drm/i915: update rawclk also on resume

2019-10-31 Thread Jani Nikula
Since CNP it's possible for rawclk to have two different values, 19.2 and 24 MHz. If the value indicated by SFUSE_STRAP register is different from the power on default for PCH_RAWCLK_FREQ, we'll end up having a mismatch between the rawclk hardware and software states after suspend/resume. On previo

[Intel-gfx] [PATCH] drm/i915: Drop inspection of execbuf flags during evict

2019-10-31 Thread Chris Wilson
With the goal of removing the serialisation from around execbuf, we will no longer have the privilege of there being a single execbuf in flight at any time and so will only be able to inspect the user's flags within the carefully controlled execbuf context. i915_gem_evict_for_node() is the only use

  1   2   >