Re: [Intel-gfx] [PATCH 2/5] drm/i915/display: Handle fused off HDCP

2019-10-23 Thread Ramalingam C
On 2019-10-24 at 00:24:00 +0530, Souza, Jose wrote: > On Wed, 2019-10-23 at 19:07 +0530, Ramalingam C wrote: > > On 2019-10-18 at 17:41:21 -0700, José Roberto de Souza wrote: > > > HDCP could be fused off, so not all GEN9+ platforms will support > > > it. > > Here HDCP stands for HDCP1.4, so please

Re: [Intel-gfx] [PATCH 5/5] drm/i915/display/cnl+: Handle fused off DSC

2019-10-23 Thread Ramalingam C
On 2019-10-18 at 17:41:24 -0700, José Roberto de Souza wrote: > DSC could be fused off, so not all GEN10+ platforms will support it. > > Cc: Manasi Navare > Cc: Martin Peres > Signed-off-by: José Roberto de Souza Looks good to me. Reviewed-by: Ramalingam C > --- > drivers/gpu/drm/i915/displa

Re: [Intel-gfx] [PATCH] drm/i915/display/psr: Print in debugfs if PSR is not enabled because of sink

2019-10-23 Thread Ramalingam C
On 2019-10-23 at 14:49:32 -0700, José Roberto de Souza wrote: > Right now if sink reported any PSR error or if it fails to > acknowledge the PSR wakeup it sets a flag and do not attempt to > enable PSR anymore. That is the safest approach to avoid repetitive > glitches and allowed us to have PSR en

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/tgl: whitelist PS_(DEPTH|INVOCATION)_COUNT

2019-10-23 Thread Chris Wilson
Quoting Tapani Pälli (2019-10-24 07:39:50) > > > On 10/24/19 12:49 AM, Chris Wilson wrote: > > Quoting Patchwork (2019-10-23 22:20:49) > >>* igt@i915_selftest@live_workarounds: > >> - {fi-tgl-u}: [PASS][3] -> [DMESG-FAIL][4] > >> [3]: > >> https://intel-gfx-ci.01.org/tree/dr

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/tgl: whitelist PS_(DEPTH|INVOCATION)_COUNT

2019-10-23 Thread Tapani Pälli
On 10/24/19 12:49 AM, Chris Wilson wrote: Quoting Patchwork (2019-10-23 22:20:49) * igt@i915_selftest@live_workarounds: - {fi-tgl-u}: [PASS][3] -> [DMESG-FAIL][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/fi-tgl-u/igt@i915_selftest@live_workarounds.html

Re: [Intel-gfx] [CI 1/5] drm/i915/gt: Try to more gracefully quiesce the system before resets

2019-10-23 Thread Ramalingam C
On 2019-10-24 at 07:14:56 +0100, Chris Wilson wrote: > Quoting Ramalingam C (2019-10-24 02:32:01) > > On 2019-10-23 at 14:31:04 +0100, Chris Wilson wrote: > > > If we are doing a normal GPU reset triggered after detecting a long > > > period of stalled work, we can take our time and allow the engin

Re: [Intel-gfx] [CI 1/5] drm/i915/gt: Try to more gracefully quiesce the system before resets

2019-10-23 Thread Chris Wilson
Quoting Ramalingam C (2019-10-24 02:32:01) > On 2019-10-23 at 14:31:04 +0100, Chris Wilson wrote: > > If we are doing a normal GPU reset triggered after detecting a long > > period of stalled work, we can take our time and allow the engines to > > quiesce. Since we've stopped submission to the engi

[Intel-gfx] ✓ Fi.CI.IGT: success for Refactor Gen11+ SAGV support (rev3)

2019-10-23 Thread Patchwork
== Series Details == Series: Refactor Gen11+ SAGV support (rev3) URL : https://patchwork.freedesktop.org/series/68028/ State : success == Summary == CI Bug Log - changes from CI_DRM_7159_full -> Patchwork_14944_full Summary --- **SUC

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Try to more gracefully quiesce the system before resets

2019-10-23 Thread Patchwork
== Series Details == Series: drm/i915/gt: Try to more gracefully quiesce the system before resets URL : https://patchwork.freedesktop.org/series/68445/ State : success == Summary == CI Bug Log - changes from CI_DRM_7159_full -> Patchwork_14943_full =

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2019-10-23 Thread Patchwork
== Series Details == Series: drm/dp: Add function to parse EDID descriptors for adaptive sync limits URL : https://patchwork.freedesktop.org/series/68488/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7167 -> Patchwork_14959

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Flush any i915_active callback work as well

2019-10-23 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Flush any i915_active callback work as well URL : https://patchwork.freedesktop.org/series/68487/ State : success == Summary == CI Bug Log - changes from CI_DRM_7167 -> Patchwork_14958 Summar

Re: [Intel-gfx] [PATCH V5 4/6] mdev: introduce virtio device and its device ops

2019-10-23 Thread Jason Wang
On 2019/10/24 上午5:57, Alex Williamson wrote: On Wed, 23 Oct 2019 21:07:50 +0800 Jason Wang wrote: This patch implements basic support for mdev driver that supports virtio transport for kernel virtio driver. Signed-off-by: Jason Wang --- drivers/vfio/mdev/mdev_core.c| 20 driver

Re: [Intel-gfx] [PATCH V5 2/6] modpost: add support for mdev class id

2019-10-23 Thread Jason Wang
On 2019/10/24 上午5:42, Alex Williamson wrote: On Wed, 23 Oct 2019 21:07:48 +0800 Jason Wang wrote: Add support to parse mdev class id table. Reviewed-by: Parav Pandit Signed-off-by: Jason Wang --- drivers/vfio/mdev/vfio_mdev.c | 2 ++ scripts/mod/devicetable-offsets.c | 3 +++ scr

Re: [Intel-gfx] [PATCH V5 1/6] mdev: class id support

2019-10-23 Thread Jason Wang
On 2019/10/24 上午5:42, Alex Williamson wrote: On Wed, 23 Oct 2019 21:07:47 +0800 Jason Wang wrote: Mdev bus only supports vfio driver right now, so it doesn't implement match method. But in the future, we may add drivers other than vfio, the first driver could be virtio-mdev. This means we nee

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Flush interrupts before disabling tasklets

2019-10-23 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Flush interrupts before disabling tasklets URL : https://patchwork.freedesktop.org/series/68486/ State : success == Summary == CI Bug Log - changes from CI_DRM_7167 -> Patchwork_14957 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/psr: Print in debugfs if PSR is not enabled because of sink

2019-10-23 Thread Patchwork
== Series Details == Series: drm/i915/display/psr: Print in debugfs if PSR is not enabled because of sink URL : https://patchwork.freedesktop.org/series/68482/ State : success == Summary == CI Bug Log - changes from CI_DRM_7167 -> Patchwork_14955 ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Flush interrupts before disabling tasklets

2019-10-23 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Flush interrupts before disabling tasklets URL : https://patchwork.freedesktop.org/series/68486/ State : warning == Summary == $ dim checkpatch origin/drm-tip d179199a3774 drm/i915/selftests: Flush interrupts before disabling tasklets -:10: WARN

[Intel-gfx] ✗ Fi.CI.BUILD: failure for string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers (rev2)

2019-10-23 Thread Patchwork
== Series Details == Series: string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers (rev2) URL : https://patchwork.freedesktop.org/series/68461/ State : failure == Summary == Applying: string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers error: sha1 info

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix PCH reference clock for FDI on HSW/BDW (rev2)

2019-10-23 Thread Patchwork
== Series Details == Series: drm/i915: Fix PCH reference clock for FDI on HSW/BDW (rev2) URL : https://patchwork.freedesktop.org/series/68411/ State : success == Summary == CI Bug Log - changes from CI_DRM_7167 -> Patchwork_14953 Summary --

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm: Add support for integrated privacy screens

2019-10-23 Thread Patchwork
== Series Details == Series: drm: Add support for integrated privacy screens URL : https://patchwork.freedesktop.org/series/68472/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/compile.h K

Re: [Intel-gfx] [CI 1/5] drm/i915/gt: Try to more gracefully quiesce the system before resets

2019-10-23 Thread Ramalingam C
On 2019-10-23 at 14:31:04 +0100, Chris Wilson wrote: > If we are doing a normal GPU reset triggered after detecting a long > period of stalled work, we can take our time and allow the engines to > quiesce. Since we've stopped submission to the engine, and if we wait > long enough an innocent contex

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/property: Enforce more lifetime rules

2019-10-23 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/property: Enforce more lifetime rules URL : https://patchwork.freedesktop.org/series/68467/ State : success == Summary == CI Bug Log - changes from CI_DRM_7167 -> Patchwork_14952 S

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: register vga switcheroo later, unregister earlier (rev2)

2019-10-23 Thread Patchwork
== Series Details == Series: drm/i915: register vga switcheroo later, unregister earlier (rev2) URL : https://patchwork.freedesktop.org/series/67644/ State : success == Summary == CI Bug Log - changes from CI_DRM_7167 -> Patchwork_14951 Sum

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/property: Enforce more lifetime rules

2019-10-23 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/property: Enforce more lifetime rules URL : https://patchwork.freedesktop.org/series/68467/ State : warning == Summary == $ dim checkpatch origin/drm-tip 33ce34335c16 drm/property: Enforce more lifetime rules -:40: CHECK:LINE_SPACING:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Making loglevel of PSR2/SU logs same.

2019-10-23 Thread Patchwork
== Series Details == Series: drm/i915: Making loglevel of PSR2/SU logs same. URL : https://patchwork.freedesktop.org/series/68439/ State : success == Summary == CI Bug Log - changes from CI_DRM_7155_full -> Patchwork_14940_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for mdev based hardware virtio offloading support (rev6)

2019-10-23 Thread Patchwork
== Series Details == Series: mdev based hardware virtio offloading support (rev6) URL : https://patchwork.freedesktop.org/series/66989/ State : success == Summary == CI Bug Log - changes from CI_DRM_7167 -> Patchwork_14949 Summary ---

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [CI,1/5] drm/i915/gt: Try to more gracefully quiesce the system before resets

2019-10-23 Thread Patchwork
== Series Details == Series: series starting with [CI,1/5] drm/i915/gt: Try to more gracefully quiesce the system before resets URL : https://patchwork.freedesktop.org/series/68463/ State : failure == Summary == Applying: drm/i915/gt: Try to more gracefully quiesce the system before resets Us

Re: [Intel-gfx] [PATCH v5 09/10] drm/framebuffer/tgl: Format modifier for Intel Gen 12 render compression with Clear Color

2019-10-23 Thread Chery, Nanley G
Hi RK, > -Original Message- > From: Sripada, Radhakrishna > Sent: Tuesday, October 22, 2019 5:09 PM > To: intel-gfx@lists.freedesktop.org > Cc: Sripada, Radhakrishna ; Ville Syrjala > ; Pandiyan, Dhinakaran > ; Kondapally, Kalyan > ; Antognolli, Rafael > ; Chery, Nanley G > Subject:

[Intel-gfx] [PATCH] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2019-10-23 Thread Manasi Navare
Adaptive Sync is a VESA feature so add a DRM core helper to parse the EDID's detailed descritors to obtain the adaptive sync monitor range. Store this info as part fo drm_display_info so it can be used across all drivers. This part of the code is stripped out of amdgpu's function amdgpu_dm_update_f

[Intel-gfx] [PATCH] drm/i915/selftests: Flush any i915_active callback work as well

2019-10-23 Thread Chris Wilson
Make trebly sure that all possible callbacks and their delayed brethren are complete before asserting that the i915_active should be idle after flushing all barriers. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c | 1 + 1 file changed, 1 insertion(+) diff -

Re: [Intel-gfx] [PATCH v4] string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers

2019-10-23 Thread Joe Perches
On Wed, 2019-10-23 at 15:56 -0700, Andrew Morton wrote: > And doing this will cause additional savings: calling a single-arg > out-of-line function generates less .text than calling yesno(). I get no change in size at all with any of extern static __always_inline with either of boo

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for mdev based hardware virtio offloading support (rev6)

2019-10-23 Thread Patchwork
== Series Details == Series: mdev based hardware virtio offloading support (rev6) URL : https://patchwork.freedesktop.org/series/66989/ State : warning == Summary == $ dim checkpatch origin/drm-tip dbcc3602f990 mdev: class id support cdfeed47be7f modpost: add support for mdev class id d18fa8d0

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/dmabuf: Implement pwrite() callback

2019-10-23 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/dmabuf: Implement pwrite() callback URL : https://patchwork.freedesktop.org/series/68428/ State : success == Summary == CI Bug Log - changes from CI_DRM_7155_full -> Patchwork_14939_full ==

Re: [Intel-gfx] [CI 4/4] drm/i915/gem: Cancel contexts when hangchecking is disabled

2019-10-23 Thread Chris Wilson
Quoting Kumar Valsan, Prathap (2019-10-24 00:26:06) > On Wed, Oct 23, 2019 at 01:21:51PM +0100, Chris Wilson wrote: > > + > > + /* > > + * If the user has disabled hangchecking, we can not be sure that > > + * the batches will ever complete after the context is closed, > > + * ke

[Intel-gfx] [PATCH] drm/i915/selftests: Flush interrupts before disabling tasklets

2019-10-23 Thread Chris Wilson
When setting up the system to perform the atomic reset, we need to serialise with any ongoing interrupt tasklet or else: <0> [472.951428] i915_sel-44420d..1 466527056us : __i915_request_submit: rcs0 fence 11659:2, current 0 <0> [472.951554] i915_sel-44420d..1 466527059us : __execlists_su

Re: [Intel-gfx] [CI 4/4] drm/i915/gem: Cancel contexts when hangchecking is disabled

2019-10-23 Thread Kumar Valsan, Prathap
On Wed, Oct 23, 2019 at 01:21:51PM +0100, Chris Wilson wrote: > Normally, we rely on our hangcheck to prevent persistent batches from > hogging the GPU. However, if the user disables hangcheck, this mechanism > breaks down. Despite our insistence that this is unsafe, the users are > equally insiste

[Intel-gfx] [PATCH 2/8] drm/i915: Put future HW and their uAPIs under STAGING & BROKEN

2019-10-23 Thread Chris Wilson
We would like some freedom to break the user API/ABI for future HW but yet still expose the driver for upstream development on that HW. Currently, we have the i915.force_probe module parameter to avoid binding to HW while the driver is under development, but that is still a little too soft with res

[Intel-gfx] [PATCH 4/8] drm/i915/gt: Expose engine->mmio_base via sysfs

2019-10-23 Thread Chris Wilson
Use the per-engine sysfs directory to let userspace discover the mmio_base of each engine. Prior to recent generations, the user accessible registers on each engine are at a fixed offset relative to each engine -- but require absolute addressing. As the absolute address depends on the actual physic

[Intel-gfx] [PATCH 8/8] drm/i915/gt: Expose heartbeat interval via sysfs

2019-10-23 Thread Chris Wilson
We monitor the health of the system via periodic heartbeat pulses. The pulses also provide the opportunity to perform garbage collection. However, we interpret an incomplete pulse (a missed heartbeat) as an indication that the system is no longer responsive, i.e. hung, and perform an engine or full

[Intel-gfx] [PATCH 5/8] drm/i915/gt: Expose timeslice duration to sysfs

2019-10-23 Thread Chris Wilson
Execlists uses a scheduling quantum (a timeslice) to alternate execution between ready-to-run contexts of equal priority. This ensures that all users (though only if they of equal importance) have the opportunity to run and prevents livelocks where contexts may have implicit ordering due to userspa

[Intel-gfx] [PATCH 6/8] drm/i915/gt: Expose reset stop timeout via sysfs

2019-10-23 Thread Chris Wilson
When we allow ourselves to sleep before a GPU reset after disabling submission, even for a few milliseconds, gives an innocent context the opportunity to clear the GPU before the reset occurs. However, how long to sleep depends on the typical non-preemptible duration (a similar problem to determini

[Intel-gfx] [PATCH 3/8] drm/i915/gt: Expose engine properties via sysfs

2019-10-23 Thread Chris Wilson
Preliminary stub to add engines underneath /sys/class/drm/cardN/, so that we can expose properties on each engine to the sysadmin. To start with we have basic analogues of the i915_query ioctl so that we can pretty print engine discovery from the shell, and flesh out the directory structure. Later

[Intel-gfx] [PATCH 1/8] drm/i915/gem: Make context persistence optional

2019-10-23 Thread Chris Wilson
Our existing behaviour is to allow contexts and their GPU requests to persist past the point of closure until the requests are complete. This allows clients to operate in a 'fire-and-forget' manner where they can setup a rendering pipeline and hand it over to the display server and immediately exit

[Intel-gfx] [PATCH 7/8] drm/i915/gt: Expose preempt reset timeout via sysfs

2019-10-23 Thread Chris Wilson
After initialising a preemption request, we give the current resident a small amount of time to vacate the GPU. The preemption request is for a higher priority context and should be immediate to maintain high quality of service (and avoid priority inversion). However, the preemption granularity of

Re: [Intel-gfx] [PATCH v4] string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers

2019-10-23 Thread Andrew Morton
On Wed, 23 Oct 2019 16:13:08 +0300 Jani Nikula wrote: > The kernel has plenty of ternary operators to choose between constant > strings, such as condition ? "yes" : "no", as well as value == 1 ? "" : > "s": > > $ git grep '? "yes" : "no"' | wc -l > 258 > $ git grep '? "on" : "off"' | wc -l > 204

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/3] drm/i915/guc: Enable guc logging on guc log relay write

2019-10-23 Thread Daniele Ceraolo Spurio
On 10/23/19 8:14 AM, Patchwork wrote: == Series Details == Series: series starting with [CI,1/3] drm/i915/guc: Enable guc logging on guc log relay write URL : https://patchwork.freedesktop.org/series/68406/ State : success == Summary == CI Bug Log - changes from CI_DRM_7155_full -> Patchw

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs

2019-10-23 Thread Chegondi, Harish
Hi, Even though I tried to link this patch with it's first version by specifying --in-reply-to=, it wasn't successful. So here is the link to the first version of the patch and the discussion. https://patchwork.freedesktop.org/patch/305153/?series=60697&rev=1 The first version of this patch has

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/4] drm/i915/gt: Try to more gracefully quiesce the system before resets

2019-10-23 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915/gt: Try to more gracefully quiesce the system before resets URL : https://patchwork.freedesktop.org/series/68457/ State : success == Summary == CI Bug Log - changes from CI_DRM_7165 -> Patchwork_14948

Re: [Intel-gfx] [PATCH V5 4/6] mdev: introduce virtio device and its device ops

2019-10-23 Thread Alex Williamson
On Wed, 23 Oct 2019 21:07:50 +0800 Jason Wang wrote: > This patch implements basic support for mdev driver that supports > virtio transport for kernel virtio driver. > > Signed-off-by: Jason Wang > --- > drivers/vfio/mdev/mdev_core.c| 20 > drivers/vfio/mdev/mdev_private.h | 2 + >

Re: [Intel-gfx] [PATCH V5 1/6] mdev: class id support

2019-10-23 Thread Parav Pandit
> -Original Message- > From: Jason Wang > Sent: Wednesday, October 23, 2019 8:08 AM > To: k...@vger.kernel.org; linux-s...@vger.kernel.org; linux- > ker...@vger.kernel.org; dri-de...@lists.freedesktop.org; intel- > g...@lists.freedesktop.org; intel-gvt-...@lists.freedesktop.org; > kwankh

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/tgl: whitelist PS_(DEPTH|INVOCATION)_COUNT

2019-10-23 Thread Chris Wilson
Quoting Patchwork (2019-10-23 22:20:49) > * igt@i915_selftest@live_workarounds: > - {fi-tgl-u}: [PASS][3] -> [DMESG-FAIL][4] >[3]: > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7165/fi-tgl-u/igt@i915_selftest@live_workarounds.html >[4]: > https://intel-gfx-ci.01.org/tree

[Intel-gfx] [PATCH] drm/i915/display/psr: Print in debugfs if PSR is not enabled because of sink

2019-10-23 Thread José Roberto de Souza
Right now if sink reported any PSR error or if it fails to acknowledge the PSR wakeup it sets a flag and do not attempt to enable PSR anymore. That is the safest approach to avoid repetitive glitches and allowed us to have PSR enabled by default. But from time to time even good PSR panels have a P

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/4] drm/i915/gt: Try to more gracefully quiesce the system before resets

2019-10-23 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915/gt: Try to more gracefully quiesce the system before resets URL : https://patchwork.freedesktop.org/series/68457/ State : warning == Summary == $ dim checkpatch origin/drm-tip 139aa7679696 drm/i915/gt: Try to more gracefully

Re: [Intel-gfx] [PATCH V5 2/6] modpost: add support for mdev class id

2019-10-23 Thread Alex Williamson
On Wed, 23 Oct 2019 21:07:48 +0800 Jason Wang wrote: > Add support to parse mdev class id table. > > Reviewed-by: Parav Pandit > Signed-off-by: Jason Wang > --- > drivers/vfio/mdev/vfio_mdev.c | 2 ++ > scripts/mod/devicetable-offsets.c | 3 +++ > scripts/mod/file2alias.c | 10

Re: [Intel-gfx] [PATCH V5 1/6] mdev: class id support

2019-10-23 Thread Alex Williamson
On Wed, 23 Oct 2019 21:07:47 +0800 Jason Wang wrote: > Mdev bus only supports vfio driver right now, so it doesn't implement > match method. But in the future, we may add drivers other than vfio, > the first driver could be virtio-mdev. This means we need to add > device class id support in bus m

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/tgl: whitelist PS_(DEPTH|INVOCATION)_COUNT

2019-10-23 Thread Patchwork
== Series Details == Series: drm/i915/tgl: whitelist PS_(DEPTH|INVOCATION)_COUNT URL : https://patchwork.freedesktop.org/series/68455/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7165 -> Patchwork_14947 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for adding gamma state checker for icl+ platforms (rev6)

2019-10-23 Thread Patchwork
== Series Details == Series: adding gamma state checker for icl+ platforms (rev6) URL : https://patchwork.freedesktop.org/series/66811/ State : success == Summary == CI Bug Log - changes from CI_DRM_7128_full -> Patchwork_14880_full Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl: whitelist PS_(DEPTH|INVOCATION)_COUNT

2019-10-23 Thread Patchwork
== Series Details == Series: drm/i915/tgl: whitelist PS_(DEPTH|INVOCATION)_COUNT URL : https://patchwork.freedesktop.org/series/68455/ State : warning == Summary == $ dim checkpatch origin/drm-tip aaf5cc0a4c3b drm/i915/tgl: whitelist PS_(DEPTH|INVOCATION)_COUNT -:9: ERROR:GIT_COMMIT_ID: Please

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Add coverage of mocs registers

2019-10-23 Thread Kumar Valsan, Prathap
On Tue, Oct 22, 2019 at 12:57:05PM +0100, Chris Wilson wrote: > Probe the mocs registers for new contexts and across GPU resets. Similar > to intel_workarounds, we have tables of what register values we expect > to see, so verify that user contexts are affected by them. In the > future, we should a

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/simple-kms: Standardize arguments for callbacks

2019-10-23 Thread Patchwork
== Series Details == Series: drm/simple-kms: Standardize arguments for callbacks URL : https://patchwork.freedesktop.org/series/68452/ State : success == Summary == CI Bug Log - changes from CI_DRM_7163 -> Patchwork_14946 Summary ---

Re: [Intel-gfx] [PATCH 1/5] drm/i915/display: Handle fused off display correctly

2019-10-23 Thread Souza, Jose
On Wed, 2019-10-23 at 16:23 +0300, Jani Nikula wrote: > On Wed, 23 Oct 2019, Ramalingam C wrote: > > On 2019-10-18 at 17:41:20 -0700, José Roberto de Souza wrote: > > > If all pipes are fused off it means that display is disabled, > > > similar > > > like we handle for GEN 7 and 8 right above but

Re: [Intel-gfx] [PATCH] drm/i915/tgl: whitelist PS_(DEPTH|INVOCATION)_COUNT

2019-10-23 Thread Lionel Landwerlin
On 23/10/2019 19:12, Mika Kuoppala wrote: Tapani Pälli writes: As with commit 3fe0107e45ab, this change fixes multiple tests that are using the invocation counts. Documentation doesn't list the workaround for TGL but applying it fixes the tests. Signed-off-by: Tapani Pälli --- drivers/gpu/

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add new CNL PCH ID seen on a CML platform

2019-10-23 Thread Imre Deak
On Tue, Oct 22, 2019 at 07:09:47PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Add new CNL PCH ID seen on a CML platform > URL : https://patchwork.freedesktop.org/series/68375/ > State : success Thanks for the review, pushed to -dinq. > > == Summary == > > CI Bug Log

Re: [Intel-gfx] [PATCH 2/5] drm/i915/display: Handle fused off HDCP

2019-10-23 Thread Souza, Jose
On Wed, 2019-10-23 at 19:07 +0530, Ramalingam C wrote: > On 2019-10-18 at 17:41:21 -0700, José Roberto de Souza wrote: > > HDCP could be fused off, so not all GEN9+ platforms will support > > it. > Here HDCP stands for HDCP1.4, so please call it so. Okay, will update the commit description with th

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/simple-kms: Standardize arguments for callbacks

2019-10-23 Thread Patchwork
== Series Details == Series: drm/simple-kms: Standardize arguments for callbacks URL : https://patchwork.freedesktop.org/series/68452/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2d7d097edac5 drm/simple-kms: Standardize arguments for callbacks -:15: WARNING:BAD_SIGN_OFF: 'Ack

Re: [Intel-gfx] [PATCH] drm/i915/bios: add compression parameter block definition

2019-10-23 Thread Manasi Navare
On Tue, Oct 22, 2019 at 05:03:00PM +0300, Jani Nikula wrote: > Add definition for block 56, the compression parameters. > Would this be used on DP connectors for DSC as well? Manasi > Cc: Vandita Kulkarni > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 50

Re: [Intel-gfx] [PATCH 5/5] drm/i915/display/cnl+: Handle fused off DSC

2019-10-23 Thread Manasi Navare
On Fri, Oct 18, 2019 at 05:41:24PM -0700, José Roberto de Souza wrote: > DSC could be fused off, so not all GEN10+ platforms will support it. > > Cc: Manasi Navare > Cc: Martin Peres > Signed-off-by: José Roberto de Souza Reviewed-by: Manasi Navare Manasi > --- > drivers/gpu/drm/i915/displ

[Intel-gfx] ✓ Fi.CI.BAT: success for Extract rps and guc

2019-10-23 Thread Patchwork
== Series Details == Series: Extract rps and guc URL : https://patchwork.freedesktop.org/series/68449/ State : success == Summary == CI Bug Log - changes from CI_DRM_7162 -> Patchwork_14945 Summary --- **SUCCESS** No regressions f

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Extract rps and guc

2019-10-23 Thread Patchwork
== Series Details == Series: Extract rps and guc URL : https://patchwork.freedesktop.org/series/68449/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0ebf20b3737a drm/i915: Extract GT render power state management -:279: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s)

Re: [Intel-gfx] [PATCH] drm/i915: Making loglevel of PSR2/SU logs same.

2019-10-23 Thread Souza, Jose
On Wed, 2019-10-23 at 13:55 +0530, kamal...@intel.com wrote: > From: "Ap Kamal" > > 'Link CRC error' will now have same error level as > other PSR2 errors like 'RFB storage error' and > 'VSC SDP uncorrectable error'. Yeah this should also be a debug message. Will push it as soon as we get a shar

[Intel-gfx] ✓ Fi.CI.IGT: success for Clear Color Support for TGL Render Decompression (rev7)

2019-10-23 Thread Patchwork
== Series Details == Series: Clear Color Support for TGL Render Decompression (rev7) URL : https://patchwork.freedesktop.org/series/66814/ State : success == Summary == CI Bug Log - changes from CI_DRM_7155_full -> Patchwork_14937_full Summ

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Release ctx->engine_mutex after iteration

2019-10-23 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Release ctx->engine_mutex after iteration URL : https://patchwork.freedesktop.org/series/68420/ State : success == Summary == CI Bug Log - changes from CI_DRM_7155_full -> Patchwork_14936_full

[Intel-gfx] [PATCH] drm: Add support for integrated privacy screens

2019-10-23 Thread Rajat Jain
Certain laptops now come with panels that have integrated privacy screens on them. This patch adds support for such panels by adding a privacy-screen property to the drm_connector for the panel, that the userspace can then use to control and check the status. The idea was discussed here: https://l

Re: [Intel-gfx] [PATCH i-g-t v2] tests/kms_content_protection: check i915 and generic debugfs name for HDCP caps

2019-10-23 Thread Harry Wentland
On 2019-10-21 3:42 p.m., Bhawanpreet Lakha wrote: > The content protection tests only start if this debugfs entry exists. > Since the name is specific to intel driver these tests cannot be used with > other drivers. So we should check generic debugfs name also > > v2: Check i915_* if device is i91

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: pfit/scaler rework prep stuff

2019-10-23 Thread Patchwork
== Series Details == Series: drm/i915: pfit/scaler rework prep stuff URL : https://patchwork.freedesktop.org/series/68409/ State : success == Summary == CI Bug Log - changes from CI_DRM_7155_full -> Patchwork_14934_full Summary --- *

Re: [Intel-gfx] [PATCH] drm/i915/tgl: whitelist PS_(DEPTH|INVOCATION)_COUNT

2019-10-23 Thread Mika Kuoppala
Tapani Pälli writes: > As with commit 3fe0107e45ab, this change fixes multiple tests that are > using the invocation counts. Documentation doesn't list the workaround > for TGL but applying it fixes the tests. > > Signed-off-by: Tapani Pälli > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c |

Re: [Intel-gfx] [RFC PATCH v2 1/3] tests/gem_exec_reloc: Don't filter out addresses on full PPGTT

2019-10-23 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-10-23 16:29:15) > Commit a355b2d6eb42 ("igt/gem_exec_reloc: Filter out unavailable > addresses for !ppgtt") introduced filtering of addresses possibly > occupied by other users of shared GTT. Unfortunately, that filtering > is unconditional, no matter if running on

Re: [Intel-gfx] [PATCH] drm/simple-kms: Standardize arguments for callbacks

2019-10-23 Thread Linus Walleij
On Wed, Oct 23, 2019 at 12:13 PM Daniel Vetter wrote: > Passing the wrong type feels icky, everywhere else we use the pipe as > the first parameter. Spotted while discussing patches with Thomas > Zimmermann. > > v2: Make xen compile correctly > > Acked-By: Thomas Zimmermann (v1) > Cc: Thomas Zim

Re: [Intel-gfx] [PATCH 10/10] drm/i915: Flush idle barriers when waiting

2019-10-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-10-14 14:08:12) > > On 11/10/2019 16:11, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-10-11 15:56:35) > >> > >> On 10/10/2019 08:14, Chris Wilson wrote: > >>> If we do find ourselves with an idle barrier inside our active while > >>> waiting, attempt to flush i

[Intel-gfx] [RFC PATCH v2 1/3] tests/gem_exec_reloc: Don't filter out addresses on full PPGTT

2019-10-23 Thread Janusz Krzysztofik
Commit a355b2d6eb42 ("igt/gem_exec_reloc: Filter out unavailable addresses for !ppgtt") introduced filtering of addresses possibly occupied by other users of shared GTT. Unfortunately, that filtering is unconditional, no matter if running on old shared GTT or not. When running on full (non-aliasi

[Intel-gfx] [RFC PATCH v2 3/3] tests/gem_exec_reloc: Detect minimum batch size

2019-10-23 Thread Janusz Krzysztofik
The basic-range subtest have been already taught to calculate softpin offsets from minimum batch size, however it still uses a hardcoded value of 4kB. On future backends with possibly bigger minimum batch sizes this subtest will fail as buffer objects may overlap. Detect minimum batch size instea

[Intel-gfx] [RFC PATCH v2 2/3] tests/gem_exec_reloc: Calculate softpin offsets from batch size

2019-10-23 Thread Janusz Krzysztofik
From: Janusz Krzysztofik The basic-range subtest assumes 4kB minimum batch size. On future backends with possibly bigger minimum batch sizes this subtest will fail as buffer objects may overlap on softpin. To avoid object overlapping, softpin offsets need to be calculated with actual minimum ba

Re: [Intel-gfx] [PATCH i-g-t v2] tests/kms_content_protection: check i915 and generic debugfs name for HDCP caps

2019-10-23 Thread Ramalingam C
On 2019-10-21 at 15:42:59 -0400, Bhawanpreet Lakha wrote: > The content protection tests only start if this debugfs entry exists. > Since the name is specific to intel driver these tests cannot be used with > other drivers. So we should check generic debugfs name also > > v2: Check i915_* if devic

[Intel-gfx] ✓ Fi.CI.BAT: success for Refactor Gen11+ SAGV support (rev3)

2019-10-23 Thread Patchwork
== Series Details == Series: Refactor Gen11+ SAGV support (rev3) URL : https://patchwork.freedesktop.org/series/68028/ State : success == Summary == CI Bug Log - changes from CI_DRM_7159 -> Patchwork_14944 Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/3] drm/i915/guc: Enable guc logging on guc log relay write

2019-10-23 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/guc: Enable guc logging on guc log relay write URL : https://patchwork.freedesktop.org/series/68406/ State : success == Summary == CI Bug Log - changes from CI_DRM_7155_full -> Patchwork_14932_full ===

Re: [Intel-gfx] [PATCH 08/14] drm/i915: Complete crtc hw/uapi split, v2.

2019-10-23 Thread Maarten Lankhorst
Op 22-10-2019 om 20:32 schreef Ville Syrjälä: > On Thu, Oct 17, 2019 at 03:20:59PM +0200, Maarten Lankhorst wrote: >> Now that we separated everything into uapi and hw, it's >> time to make the split definitive. Remove the union and >> make a copy of the hw state on modeset and fastset. >> >> Color

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Refactor Gen11+ SAGV support (rev3)

2019-10-23 Thread Patchwork
== Series Details == Series: Refactor Gen11+ SAGV support (rev3) URL : https://patchwork.freedesktop.org/series/68028/ State : warning == Summary == $ dim checkpatch origin/drm-tip ffa7a93754dd drm/i915: Refactor intel_can_enable_sagv -:94: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match o

[Intel-gfx] [PATCH 2/2] drm/todo: Add entry to remove load/unload hooks

2019-10-23 Thread Daniel Vetter
They're midlayer, broken, and because of the old gunk, we can't fix them. For examples see the various checks in drm_mode_object.c against dev->registered, which cannot be enforced if the driver still uses the load hook. Unfortunately our biggest driver still uses load/unload, so this would be rea

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Refactor Gen11+ SAGV support (rev3)

2019-10-23 Thread Patchwork
== Series Details == Series: Refactor Gen11+ SAGV support (rev3) URL : https://patchwork.freedesktop.org/series/68028/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915: Refactor intel_can_enable_sagv +drivers/gpu/drm/i915/intel_pm.c:3754:6: warn

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Try to more gracefully quiesce the system before resets

2019-10-23 Thread Patchwork
== Series Details == Series: drm/i915/gt: Try to more gracefully quiesce the system before resets URL : https://patchwork.freedesktop.org/series/68445/ State : success == Summary == CI Bug Log - changes from CI_DRM_7159 -> Patchwork_14943 S

[Intel-gfx] [PATCH 1/2] drm/property: Enforce more lifetime rules

2019-10-23 Thread Daniel Vetter
Properties can't be attached after registering, userspace would get confused (no one bothers to reprobe really). - Add kerneldoc - Enforce this with some checks. This needs a somewhat ugly check since connectors can be added later on, but we still need to attach all properties before they go p

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Try to more gracefully quiesce the system before resets

2019-10-23 Thread Patchwork
== Series Details == Series: drm/i915/gt: Try to more gracefully quiesce the system before resets URL : https://patchwork.freedesktop.org/series/68445/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2e59d4f9691e drm/i915/gt: Try to more gracefully quiesce the system before rese

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/bios: add compression parameter block definition

2019-10-23 Thread Patchwork
== Series Details == Series: drm/i915/bios: add compression parameter block definition URL : https://patchwork.freedesktop.org/series/68396/ State : success == Summary == CI Bug Log - changes from CI_DRM_7155_full -> Patchwork_14928_full Su

Re: [Intel-gfx] [PATCH 3/5] drm/i915/display: Check if FBC is fused off

2019-10-23 Thread Ramalingam C
On 2019-10-18 at 17:41:22 -0700, José Roberto de Souza wrote: > Check if FBC is fused off and handle it. > > Cc: Ville Syrjälä > Cc: Martin Peres > Signed-off-by: José Roberto de Souza > --- > drivers/gpu/drm/i915/i915_reg.h | 1 + > drivers/gpu/drm/i915/intel_device_info.c | 3 +++ >

Re: [Intel-gfx] [PATCH 1/5] drm/i915/display: Handle fused off display correctly

2019-10-23 Thread Ramalingam C
On 2019-10-18 at 17:41:20 -0700, José Roberto de Souza wrote: > If all pipes are fused off it means that display is disabled, similar > like we handle for GEN 7 and 8 right above but for GEN9+ spec says > that hardware will override the pipe output to a solid color, so > some display is there and m

Re: [Intel-gfx] [PATCH 2/5] drm/i915/display: Handle fused off HDCP

2019-10-23 Thread Ramalingam C
On 2019-10-18 at 17:41:21 -0700, José Roberto de Souza wrote: > HDCP could be fused off, so not all GEN9+ platforms will support it. Here HDCP stands for HDCP1.4, so please call it so. > > Cc: Ville Syrjälä > Cc: Martin Peres > Reviewed-by: Ville Syrjälä > Signed-off-by: José Roberto de Souza

[Intel-gfx] [PATCH v3 5/7] drm/i915/selftests: extend coverage to include LMEM huge-pages

2019-10-23 Thread Matthew Auld
Add LMEM objects to list of backends we test for huge-GTT-pages. Signed-off-by: Matthew Auld Reviewed-by: Chris Wilson --- .../gpu/drm/i915/gem/selftests/huge_pages.c | 121 +- 1 file changed, 120 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/selftests/hu

[Intel-gfx] [PATCH v3 7/7] drm/i915/selftests: add sanity selftest for huge-GTT-pages

2019-10-23 Thread Matthew Auld
Now that for all the relevant backends we do randomised testing, we need to make sure we still sanity check the obvious cases that might blow up, such that introducing a temporary regression is less likely. Also rather than do this for every backend, just limit to our two memory types: system and

[Intel-gfx] [PATCH v3 6/7] drm/i915/selftests: prefer random sizes for the huge-GTT-page smoke tests

2019-10-23 Thread Matthew Auld
Ditch the dubious static list of sizes to enumerate, in favour of choosing a random size within the limits of each backing store. With repeated CI runs this should give us a wider range of object sizes, and in turn more page-size combinations, while using less machine time. Signed-off-by: Matthew

[Intel-gfx] [PATCH v3 2/7] drm/i915: setup io-mapping for LMEM

2019-10-23 Thread Matthew Auld
From: Abdiel Janulgue Signed-off-by: Abdiel Janulgue Cc: Matthew Auld Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/intel_region_lmem.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_region_lmem.c b/drivers/gpu/dr

  1   2   >