Re: [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Fix Kconfig indentation

2019-10-07 Thread Jani Nikula
On Mon, 07 Oct 2019, Patchwork wrote: > == Series Details == > > Series: drm/i915: Fix Kconfig indentation > URL : https://patchwork.freedesktop.org/series/67707/ > State : failure > > == Summary == > > Applying: drm/i915: Fix Kconfig indentation > Using index info to reconstruct a base tree...

Re: [Intel-gfx] [PATCH TRIVIAL v2] gpu: Fix Kconfig indentation

2019-10-07 Thread Jani Nikula
On Mon, 07 Oct 2019, Krzysztof Kozlowski wrote: > On Mon, 7 Oct 2019 at 18:09, Alex Deucher wrote: >> >> On Mon, Oct 7, 2019 at 7:39 AM Jani Nikula >> wrote: >> > >> > On Fri, 04 Oct 2019, Krzysztof Kozlowski wrote: >> > > drivers/gpu/drm/i915/Kconfig | 12 +- >> > > drivers/gpu/

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2019-10-07 Thread Stephen Rothwell
Hi all, On Tue, 8 Oct 2019 10:30:45 +1100 Stephen Rothwell wrote: > > Hi all, > > After merging the drm-misc tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > Sorry, forgot to include the error messages. But they shuld be clear from the fix ... -- Cheers, Stephen Ro

Re: [Intel-gfx] [RFC PATCH] iommu/vt-d: Fix IOMMU field not populated on device hot re-plug

2019-10-07 Thread Lu Baolu
Hi, On 10/1/19 11:01 PM, Janusz Krzysztofik wrote: Hi Baolu, On Tuesday, September 3, 2019 9:41:23 AM CEST Janusz Krzysztofik wrote: Hi Baolu, On Tuesday, September 3, 2019 3:29:40 AM CEST Lu Baolu wrote: Hi Janusz, On 9/2/19 4:37 PM, Janusz Krzysztofik wrote: I am not saying that keeping

[Intel-gfx] ✗ Fi.CI.BUILD: failure for linux-next: build failure after merge of the drm-misc tree

2019-10-07 Thread Patchwork
== Series Details == Series: linux-next: build failure after merge of the drm-misc tree URL : https://patchwork.freedesktop.org/series/67718/ State : failure == Summary == Applying: linux-next: build failure after merge of the drm-misc tree error: sha1 information is lacking or useless (drive

[Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2019-10-07 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) failed like this: Caused by commit 10d8f308ba3e ("cec: add cec_adapter to cec_notifier_cec_adap_unregister()") interacting with commit 7e86efa2ff03 ("media: cec-gpio: add notifier support") form the v

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/tgl: Read SAGV block time from PCODE

2019-10-07 Thread James Ausmus
On Mon, Oct 07, 2019 at 01:15:24PM +0300, Ville Syrjälä wrote: > On Fri, Oct 04, 2019 at 02:51:34PM -0700, James Ausmus wrote: > > On Fri, Oct 04, 2019 at 01:55:46PM -0700, Lucas De Marchi wrote: > > > On Fri, Sep 27, 2019 at 03:24:27PM -0700, James Ausmus wrote: > > > >Starting from TGL, we now ne

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm/i915/perf: Wean ourselves off dev_priv

2019-10-07 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/perf: Wean ourselves off dev_priv URL : https://patchwork.freedesktop.org/series/67713/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7027 -> Patchwork_14696 ===

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915/perf: Wean ourselves off dev_priv

2019-10-07 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/perf: Wean ourselves off dev_priv URL : https://patchwork.freedesktop.org/series/67713/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4e4728d59e05 drm/i915/perf: Wean ourselves off dev_priv -:416: WARNING:AVOID

Re: [Intel-gfx] [PATCH v8 1/4] drm/panel: Add helper for reading DT rotation

2019-10-07 Thread dbasehore .
On Mon, Oct 7, 2019 at 9:38 AM Sean Paul wrote: > > On Wed, Sep 25, 2019 at 03:58:30PM -0700, Derek Basehore wrote: > > This adds a helper function for reading the rotation (panel > > orientation) from the device tree. > > > > Signed-off-by: Derek Basehore > > Reviewed-by: Sam Ravnborg > > The p

Re: [Intel-gfx] [v8, 2/4] drm/panel: set display info in panel attach

2019-10-07 Thread dbasehore .
On Mon, Oct 7, 2019 at 9:44 AM Sean Paul wrote: > > On Mon, Sep 30, 2019 at 04:14:54PM -0700, dbasehore . wrote: > > On Sat, Sep 28, 2019 at 10:23 PM james qian wang (Arm Technology > > China) wrote: > > > > > > On Wed, Sep 25, 2019 at 03:58:31PM -0700, Derek Basehore wrote: > > > > Devicetree sy

Re: [Intel-gfx] [PATCH] drm/i915: make array hw_engine_mask static, makes object smaller

2019-10-07 Thread Chris Wilson
Quoting Chris Wilson (2019-10-07 17:22:52) > Quoting Colin King (2019-10-07 16:41:51) > > From: Colin Ian King > > > > Don't populate the array hw_engine_mask on the stack but instead make it > > static. Makes the object code smaller by 316 bytes. > > > > Before: > >textdata bss

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: make array hw_engine_mask static, makes object smaller

2019-10-07 Thread Patchwork
== Series Details == Series: drm/i915: make array hw_engine_mask static, makes object smaller URL : https://patchwork.freedesktop.org/series/67694/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7024_full -> Patchwork_14692_full =

[Intel-gfx] [CI 1/2] drm/i915/perf: Wean ourselves off dev_priv

2019-10-07 Thread Chris Wilson
Use the local uncore accessors for the GT rather than using the [not-so] magic global dev_priv mmio routines. In the process, we also teach the perf stream to use backpointers to the i915_perf rather than digging it out of dev_priv. v2: Rebase onto i915_perf_types.h Signed-off-by: Chris Wilson C

[Intel-gfx] [CI 2/2] drm/i915/perf: Set the exclusive stream under perf->lock

2019-10-07 Thread Chris Wilson
The BKL struct_mutex is no more, the only serialisation we required for setting the exclusive stream is already managed by ce->pin_mutex in gen8_configure_all_contexts(). As such, we can manipulate i915_perf.exclusive_stream underneath our own (already held) perf->lock. Signed-off-by: Chris Wilson

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/2] drm/i915/perf: Wean ourselves off dev_priv

2019-10-07 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/perf: Wean ourselves off dev_priv URL : https://patchwork.freedesktop.org/series/67689/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7024_full -> Patchwork_14690_full =

Re: [Intel-gfx] [PATCH 02/11] drm/i915: switch i915_driver_probe() to use i915 local variable

2019-10-07 Thread Chris Wilson
Quoting Jani Nikula (2019-10-07 16:09:27) > Prefer i915 over dev_priv where possible. No functional changes. > > Signed-off-by: Jani Nikula Reviewed-by: Chris Wilson -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freede

Re: [Intel-gfx] [PATCH v3 1/1] drm/i915/ehl: Add sysfs interface to control class-of-service

2019-10-07 Thread Chris Wilson
Quoting Prathap Kumar Valsan (2019-10-07 17:52:09) > To provide shared last-level-cache isolation to cpu workloads running > concurrently with gpu workloads, the gpu allocation of cache lines needs > to be restricted to certain ways. Currently GPU hardware supports four > class-of-service(CLOS) lev

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET

2019-10-07 Thread Chris Wilson
Quoting Chris Wilson (2019-10-07 21:16:29) > Quoting Bloomfield, Jon (2019-10-07 17:55:16) > > > -Original Message- > > > From: Intel-gfx On Behalf Of > > > Abdiel > > > Janulgue > > > Sent: Monday, October 7, 2019 2:19 AM > > > To: intel-gfx@lists.freedesktop.org > > > Cc: Auld, Matthew

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET

2019-10-07 Thread Chris Wilson
Quoting Bloomfield, Jon (2019-10-07 17:55:16) > > -Original Message- > > From: Intel-gfx On Behalf Of > > Abdiel > > Janulgue > > Sent: Monday, October 7, 2019 2:19 AM > > To: intel-gfx@lists.freedesktop.org > > Cc: Auld, Matthew > > Subject: [Intel-gfx] [PATCH v2 3/5] drm/i915: Introduc

Re: [Intel-gfx] Fixes which failed clean cherry-pick to drm-intel-fixes

2019-10-07 Thread Chris Wilson
Quoting Rodrigo Vivi (2019-10-07 18:54:35) > Hi Chris, > > 4 of your fixes failed the clean cherry-pick of drm-intel-fixes. > > b647c7df01b7 ("drm/i915: Fixup preempt-to-busy vs resubmission of a virtual > request") > cb2377a919bb ("drm/i915: Fixup preempt-to-busy vs reset of a virtual request")

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] lib/i915: Bump conservative threshold for ring size

2019-10-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-10-07 17:56:20) > > On 07/10/2019 09:27, Chris Wilson wrote: > > We are still hitting the occasional stall upon submission, so be extra > > caution and leave one more spare. > > > > Signed-off-by: Chris Wilson > > --- > > lib/i915/gem_ring.c | 4 ++-- > > 1 file c

Re: [Intel-gfx] [PATCH 06/24] drm/i915: Remove begin/finish_crtc_commit, v4.

2019-10-07 Thread Matt Roper
On Fri, Oct 04, 2019 at 01:34:56PM +0200, Maarten Lankhorst wrote: > This can all be done from the intel_update_crtc function. Split out the > pipe update into a separate function, just like is done for the planes. > Pull in all the changes done during fastset as well. It makes no sense > for it to

Re: [Intel-gfx] [PATCH 03/24] drm/i915: Introduce and use intel_atomic_crtc_state_for_each_plane_state.

2019-10-07 Thread Matt Roper
On Fri, Oct 04, 2019 at 01:34:53PM +0200, Maarten Lankhorst wrote: > Instead of looking at drm_plane_state, look at intel_plane_state directly. > > This will allow us to make the watermarks bigjoiner aware, when we make it > work for bigjoiner slave pipes as well. > > Signed-off-by: Maarten Lankh

Re: [Intel-gfx] [PATCH 05/24] drm/i915: Use intel_plane_state in prepare and cleanup plane_fb

2019-10-07 Thread Matt Roper
On Fri, Oct 04, 2019 at 01:34:55PM +0200, Maarten Lankhorst wrote: > We need to look at the hw fb in the plane split, so replace all the places > that use drm_plane_state with intel_plane_state. > > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/i915/display/intel_display.c | 28 ++

Re: [Intel-gfx] [PATCH 04/24] drm/i915: Remove cursor use of properties for coordinates

2019-10-07 Thread Matt Roper
On Fri, Oct 04, 2019 at 01:34:54PM +0200, Maarten Lankhorst wrote: > We have a src and dect rectangle, use it instead of relying on > the core drm properties. > > This removes the special case in the watermark code for cursor w/h. > > Signed-off-by: Maarten Lankhorst I think you should make it

Re: [Intel-gfx] [PATCH 02/24] drm/i915: Fix for_each_intel_plane_mask definition

2019-10-07 Thread Matt Roper
On Fri, Oct 04, 2019 at 01:34:52PM +0200, Maarten Lankhorst wrote: > Using for_each_intel_plane_mask() fails because of an extra bracket, > remove the bracket so we can use it in the next commit. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/display

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Fix Kconfig indentation

2019-10-07 Thread Patchwork
== Series Details == Series: drm/i915: Fix Kconfig indentation URL : https://patchwork.freedesktop.org/series/67707/ State : failure == Summary == Applying: drm/i915: Fix Kconfig indentation Using index info to reconstruct a base tree... M drivers/gpu/drm/i915/Kconfig.debug Falling back

[Intel-gfx] ✗ Fi.CI.IGT: failure for DC3CO Support for TGL test with DC3CO IGT (rev2)

2019-10-07 Thread Patchwork
== Series Details == Series: DC3CO Support for TGL test with DC3CO IGT (rev2) URL : https://patchwork.freedesktop.org/series/67525/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7021_full -> Patchwork_14686_full Summary ---

[Intel-gfx] [PATCH v3] drm/i915: Fix Kconfig indentation

2019-10-07 Thread Krzysztof Kozlowski
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- Changes since v2: 1. Split AMD and i915 to separate patches. --- drivers/gpu/drm/i915/Kconfig | 12 +-- d

Re: [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Add Sphinx-compatible references to struct fields

2019-10-07 Thread Jonathan Neuschäfer
On Mon, Oct 07, 2019 at 02:36:30PM +0300, Jani Nikula wrote: > On Fri, 04 Oct 2019, Jonathan Neuschäfer wrote: [...] > > I'm not sure what's wrong here. The patch applies cleanly to v5.4-rc1 > > and linux-next. Maybe patchwork is applying it to an older base? > > On the contrary, to a much newer

Re: [Intel-gfx] [PATCH TRIVIAL v2] gpu: Fix Kconfig indentation

2019-10-07 Thread Krzysztof Kozlowski
On Mon, 7 Oct 2019 at 18:09, Alex Deucher wrote: > > On Mon, Oct 7, 2019 at 7:39 AM Jani Nikula > wrote: > > > > On Fri, 04 Oct 2019, Krzysztof Kozlowski wrote: > > > drivers/gpu/drm/i915/Kconfig | 12 +- > > > drivers/gpu/drm/i915/Kconfig.debug | 144 +++

[Intel-gfx] Fixes which failed clean cherry-pick to drm-intel-fixes

2019-10-07 Thread Rodrigo Vivi
Hi Chris, 4 of your fixes failed the clean cherry-pick of drm-intel-fixes. b647c7df01b7 ("drm/i915: Fixup preempt-to-busy vs resubmission of a virtual request") cb2377a919bb ("drm/i915: Fixup preempt-to-busy vs reset of a virtual request") a4311745bba9 ("drm/i915/userptr: Never allow userptr int

Re: [Intel-gfx] [PATCH] drm/i915: customize DPCD brightness control for specific panel

2019-10-07 Thread Adam Jackson
On Mon, 2019-10-07 at 12:08 +0300, Jani Nikula wrote: > The problem with the EDID quirks is that exposing the quirks sticks out > like a sore thumb. Thus far all of it has been contained in drm_edid.c > and they affect how the EDID gets parsed, for all drivers. Obviously > this could be changed, b

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/vbt: Child device size remains unchanged through VBT 229

2019-10-07 Thread Matt Roper
On Thu, Oct 03, 2019 at 09:00:20AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/vbt: Child device size remains unchanged through VBT 229 > URL : https://patchwork.freedesktop.org/series/67510/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_6992_

[Intel-gfx] ✗ Fi.CI.BAT: failure for Add sysfs interface to control class-of-service

2019-10-07 Thread Patchwork
== Series Details == Series: Add sysfs interface to control class-of-service URL : https://patchwork.freedesktop.org/series/67700/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7024 -> Patchwork_14694 Summary --- **F

Re: [Intel-gfx] [PATCH 04/12] drm/i915/gt: Treat a busy timeline as 'active' while waiting

2019-10-07 Thread Tvrtko Ursulin
On 06/10/2019 17:49, Chris Wilson wrote: If we cannot claim the timeline->mutex while preparing for a wait on it, we have to skip the timeline. In doing so, treat it as active so that under a intel_gt_wait_for_idle() loop, we repeat the wait after scheduling away. Signed-off-by: Chris Wilson C

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_softpin: Replace constant loop with timeout

2019-10-07 Thread Tvrtko Ursulin
On 05/10/2019 09:15, Chris Wilson wrote: Rather than do a fixed amount of work that takes *forever*, run for a fixed amount of time. Signed-off-by: Chris Wilson --- tests/i915/gem_softpin.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/i915/gem_softpin.c b/

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/3] i915/gem_eio: Retighten timeouts for forced reset

2019-10-07 Thread Tvrtko Ursulin
On 05/10/2019 11:55, Chris Wilson wrote: The forced-reset itself should be immediate; it's just the wait after the health check where we appear to have issues! Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- tests/i915/gem_eio.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/atomic-helper: Extract drm_atomic_helper_calc_timestamping_constants()

2019-10-07 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/atomic-helper: Extract drm_atomic_helper_calc_timestamping_constants() URL : https://patchwork.freedesktop.org/series/67681/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7023_full -> Patchwork_14687_full ===

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] lib/i915: Bump conservative threshold for ring size

2019-10-07 Thread Tvrtko Ursulin
On 07/10/2019 09:27, Chris Wilson wrote: We are still hitting the occasional stall upon submission, so be extra caution and leave one more spare. Signed-off-by: Chris Wilson --- lib/i915/gem_ring.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/i915/gem_ring.c b

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET

2019-10-07 Thread Bloomfield, Jon
> -Original Message- > From: Intel-gfx On Behalf Of Abdiel > Janulgue > Sent: Monday, October 7, 2019 2:19 AM > To: intel-gfx@lists.freedesktop.org > Cc: Auld, Matthew > Subject: [Intel-gfx] [PATCH v2 3/5] drm/i915: Introduce > DRM_I915_GEM_MMAP_OFFSET > > This is really just an alias of

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_userptr: Be defensive when testing userptr capabilities

2019-10-07 Thread Tvrtko Ursulin
On 07/10/2019 08:37, Chris Wilson wrote: Not every device naturally supports snooping and userptr, so be prepared for the initial probe to fail. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111910 Signed-off-by: Chris Wilson --- tests/i915/gem_userptr_blits.c | 7 +-- 1 file c

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add sysfs interface to control class-of-service

2019-10-07 Thread Patchwork
== Series Details == Series: Add sysfs interface to control class-of-service URL : https://patchwork.freedesktop.org/series/67700/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915/ehl: Add sysfs interface to control class-of-service +drivers/gpu

Re: [Intel-gfx] [PATCH v8 4/4] drm/mtk: add panel orientation property

2019-10-07 Thread Sean Paul
On Wed, Sep 25, 2019 at 03:58:33PM -0700, Derek Basehore wrote: > This inits the panel orientation property for the mediatek dsi driver > if the panel orientation (connector.display_info.panel_orientation) is > not DRM_MODE_PANEL_ORIENTATION_UNKNOWN. > > Signed-off-by: Derek Basehore > Acked-by:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Prefer local path to runtime powermanagement

2019-10-07 Thread Patchwork
== Series Details == Series: drm/i915/gt: Prefer local path to runtime powermanagement URL : https://patchwork.freedesktop.org/series/67696/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7024 -> Patchwork_14693 Summary

Re: [Intel-gfx] [PATCH v8 3/4] drm/connector: Split out orientation quirk detection

2019-10-07 Thread Sean Paul
On Wed, Sep 25, 2019 at 03:58:32PM -0700, Derek Basehore wrote: > Not every platform needs quirk detection for panel orientation, so > split the drm_connector_init_panel_orientation_property into two > functions. One for platforms without the need for quirks, and the > other for platforms that need

Re: [Intel-gfx] [v8, 2/4] drm/panel: set display info in panel attach

2019-10-07 Thread Sean Paul
On Mon, Sep 30, 2019 at 04:14:54PM -0700, dbasehore . wrote: > On Sat, Sep 28, 2019 at 10:23 PM james qian wang (Arm Technology > China) wrote: > > > > On Wed, Sep 25, 2019 at 03:58:31PM -0700, Derek Basehore wrote: > > > Devicetree systems can set panel orientation via a panel binding, but > > >

Re: [Intel-gfx] [PATCH v8 1/4] drm/panel: Add helper for reading DT rotation

2019-10-07 Thread Sean Paul
On Wed, Sep 25, 2019 at 03:58:30PM -0700, Derek Basehore wrote: > This adds a helper function for reading the rotation (panel > orientation) from the device tree. > > Signed-off-by: Derek Basehore > Reviewed-by: Sam Ravnborg The patch LGTM, but I don't see it used anywhere later in the patch? I

[Intel-gfx] [PATCH v3 0/1] Add sysfs interface to control class-of-service

2019-10-07 Thread Prathap Kumar Valsan
For GEN11 MOCS are part of context register state. This means updating CLOS also needs to update the context state of active contexts. v3: Rebase v2: Updated the interface to use two sysfs files(Joonas) - Gen12 PCode interface is not ready yet to read the way mask. So removed TGL support

[Intel-gfx] [PATCH v3 1/1] drm/i915/ehl: Add sysfs interface to control class-of-service

2019-10-07 Thread Prathap Kumar Valsan
To provide shared last-level-cache isolation to cpu workloads running concurrently with gpu workloads, the gpu allocation of cache lines needs to be restricted to certain ways. Currently GPU hardware supports four class-of-service(CLOS) levels and there is an associated way-mask for each CLOS. Each

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: make array hw_engine_mask static, makes object smaller

2019-10-07 Thread Patchwork
== Series Details == Series: drm/i915: make array hw_engine_mask static, makes object smaller URL : https://patchwork.freedesktop.org/series/67694/ State : success == Summary == CI Bug Log - changes from CI_DRM_7024 -> Patchwork_14692 Summa

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gt: Prefer local path to runtime powermanagement

2019-10-07 Thread Patchwork
== Series Details == Series: drm/i915/gt: Prefer local path to runtime powermanagement URL : https://patchwork.freedesktop.org/series/67696/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915/gt: Prefer local path to runtime powermanagement -O:dri

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: modeset probe/remove cleanup

2019-10-07 Thread Patchwork
== Series Details == Series: drm/i915: modeset probe/remove cleanup URL : https://patchwork.freedesktop.org/series/67691/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7024 -> Patchwork_14691 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH] drm/i915: make array hw_engine_mask static, makes object smaller

2019-10-07 Thread Chris Wilson
Quoting Colin King (2019-10-07 16:41:51) > From: Colin Ian King > > Don't populate the array hw_engine_mask on the stack but instead make it > static. Makes the object code smaller by 316 bytes. > > Before: >textdata bss dec hex filename > 340044388 320 387129

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Appease lockdep

2019-10-07 Thread Tvrtko Ursulin
On 04/10/2019 21:31, Chris Wilson wrote: Disable irqs around updating the context image to keep lockdep happy: <4>[ 673.483340] WARNING: possible irq lock inversion dependency detected <4>[ 673.483342] 5.4.0-rc1-CI-Trybot_5118+ #1 Tainted: G U <4>[ 673.483342] ---

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Fix annotation for decoupling virtual request

2019-10-07 Thread Tvrtko Ursulin
On 04/10/2019 20:47, Chris Wilson wrote: As we may signal a request and take the engine->active.lock within the signaler, the engine submission paths have to use a nested annotation on their requests -- but we guarantee that we can never submit on the same engine as the signaling fence. <4>[ 7

Re: [Intel-gfx] [PATCH TRIVIAL v2] gpu: Fix Kconfig indentation

2019-10-07 Thread Alex Deucher
On Mon, Oct 7, 2019 at 7:39 AM Jani Nikula wrote: > > On Fri, 04 Oct 2019, Krzysztof Kozlowski wrote: > > drivers/gpu/drm/i915/Kconfig | 12 +- > > drivers/gpu/drm/i915/Kconfig.debug | 144 +++ > > Please split these out to a separate patch. Can't speak for

Re: [Intel-gfx] [PATCH] drm/i915/gt: Prefer local path to runtime powermanagement

2019-10-07 Thread Tvrtko Ursulin
On 07/10/2019 16:45, Chris Wilson wrote: Avoid going to the base i915 device when we already have a path from gt to the runtime powermanagement interface. The benefit is that it looks a bit more self-consistent to always be acquiring the gt->uncore->rpm for use with the gt->uncore. Signed-off-b

[Intel-gfx] [PATCH] drm/i915/gt: Prefer local path to runtime powermanagement

2019-10-07 Thread Chris Wilson
Avoid going to the base i915 device when we already have a path from gt to the runtime powermanagement interface. The benefit is that it looks a bit more self-consistent to always be acquiring the gt->uncore->rpm for use with the gt->uncore. Signed-off-by: Chris Wilson Cc: Daniele Ceraolo Spurio

[Intel-gfx] [PATCH] drm/i915: make array hw_engine_mask static, makes object smaller

2019-10-07 Thread Colin King
From: Colin Ian King Don't populate the array hw_engine_mask on the stack but instead make it static. Makes the object code smaller by 316 bytes. Before: textdata bss dec hex filename 340044388 320 387129738 gpu/drm/i915/gt/intel_reset.o After: textdata

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: modeset probe/remove cleanup

2019-10-07 Thread Patchwork
== Series Details == Series: drm/i915: modeset probe/remove cleanup URL : https://patchwork.freedesktop.org/series/67691/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4f485ace7f46 drm/i915: register vga switcheroo later, unregister earlier 4cea63d24b5c drm/i915: switch i915_dr

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915/perf: Wean ourselves off dev_priv

2019-10-07 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/perf: Wean ourselves off dev_priv URL : https://patchwork.freedesktop.org/series/67689/ State : success == Summary == CI Bug Log - changes from CI_DRM_7024 -> Patchwork_14690 ===

Re: [Intel-gfx] [PATCH 11/11] drm/i915: remove the now redundant i915_driver_modeset_* call layer

2019-10-07 Thread Chris Wilson
Quoting Jani Nikula (2019-10-07 16:09:36) > The i915_driver_modeset_*() functions have become irrelevant, and the > extra layer can be removed. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_drv.c | 76 + > 1 file changed, 19 insertions(+), 57 de

[Intel-gfx] ✓ Fi.CI.BAT: success for DC3CO Support for TGL test with DC3CO IGT (rev2)

2019-10-07 Thread Patchwork
== Series Details == Series: DC3CO Support for TGL test with DC3CO IGT (rev2) URL : https://patchwork.freedesktop.org/series/67525/ State : success == Summary == CI Bug Log - changes from CI_DRM_7021 -> Patchwork_14686 Summary --- **

[Intel-gfx] [PATCH 11/11] drm/i915: remove the now redundant i915_driver_modeset_* call layer

2019-10-07 Thread Jani Nikula
The i915_driver_modeset_*() functions have become irrelevant, and the extra layer can be removed. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.c | 76 + 1 file changed, 19 insertions(+), 57 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c

[Intel-gfx] [PATCH 08/11] drm/i915: split intel_modeset_init() pre/post gem init

2019-10-07 Thread Jani Nikula
Turn current intel_modeset_init() to a pre-gem init function, and add a new intel_modeset_init() function and move all post-gem modeset init there, in the correct layer. Again, apart from possible failure paths, no functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i

[Intel-gfx] [PATCH 07/11] drm/i915: split intel_modeset_init() to pre/post irq install

2019-10-07 Thread Jani Nikula
Split inte_modeset_init() to parts before and after irq install, to facilitate further cleanup. The error paths are a mess, otherwise no functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 17 + drivers/gpu/drm/i915/display/intel_disp

[Intel-gfx] [PATCH 10/11] drm/i915: move modeset probe failures down to intel_display.c

2019-10-07 Thread Jani Nikula
Makes more sense, facilitates further cleanup. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 6 ++ drivers/gpu/drm/i915/i915_drv.c | 6 -- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_displa

[Intel-gfx] [PATCH 05/11] drm/i915: split i915_driver_modeset_remove() to pre/post irq uninstall

2019-10-07 Thread Jani Nikula
Push irq uninstall further up, by splitting i915_driver_modeset_remove() to two, the part with working irqs before irq uninstall, and the part after irq uninstall. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.c | 11 +-- 1 file changed, 9 insertions

[Intel-gfx] [PATCH 03/11] drm/i915: keep power domains init/remove calls at the same level

2019-10-07 Thread Jani Nikula
Move intel_power_domains_init_hw() call one level higher, to be on the same level as all the other intel_power_domains_*() calls in the probe/remove paths. This also moves the power domain hw init earlier in the sequence, along with the dependent intel_update_rawclk() call. As far as I can tell th

[Intel-gfx] [PATCH 09/11] drm/i915: move more display related probe/remove stuff to display

2019-10-07 Thread Jani Nikula
With the intel_display_* prove/remove functions clarified, we can continue with moving more related calls to the right layer: - drm_vblank_init() - intel_bios_init() and intel_bios_driver_remove() - intel_vga_register() and intel_vga_unregister() - intel_csr_ucode_init() and intel_csr_ucode_fini()

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915/perf: Wean ourselves off dev_priv

2019-10-07 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/perf: Wean ourselves off dev_priv URL : https://patchwork.freedesktop.org/series/67689/ State : warning == Summary == $ dim checkpatch origin/drm-tip c449e123f41b drm/i915/perf: Wean ourselves off dev_priv -:415: WARNING:AVOID

[Intel-gfx] [PATCH 06/11] drm/i915: split i915_driver_modeset_probe() to pre/post irq install

2019-10-07 Thread Jani Nikula
Pair the irq install and uninstall in the same layer. There are no functional changes in the happy day scenario. The cleanup paths are currently a mess though. Note that modeset probe pre-irq + post-irq install are matched by modeset driver remove pre-irq + post-irq uninstall, together, but not in

[Intel-gfx] [PATCH 04/11] drm/i915: split intel_modeset_driver_remove() to pre/post irq uninstall

2019-10-07 Thread Jani Nikula
Split intel_modeset_driver_remove() to two, the part with working irqs before irq uninstall, and the part after irq uninstall. Move irq_unintall() closer to the layer it belongs. The error path in i915_driver_modeset_probe() looks obviously weird after this, but remains as good or broken as it eve

[Intel-gfx] [PATCH 02/11] drm/i915: switch i915_driver_probe() to use i915 local variable

2019-10-07 Thread Jani Nikula
Prefer i915 over dev_priv where possible. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.c | 42 - 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.

[Intel-gfx] [PATCH 01/11] drm/i915: register vga switcheroo later, unregister earlier

2019-10-07 Thread Jani Nikula
Move vga switcheroo and dsm handler register later in i915_driver_register(), and unregister in i915_driver_unregister(). The dsm handler unregister is a nop, and is only added for completeness. My unsubstantiated suspicion is that the vga switcheroo state change would not work as early as we regi

[Intel-gfx] [PATCH 00/11] drm/i915: modeset probe/remove cleanup

2019-10-07 Thread Jani Nikula
Another attempt at trying to cleanup the probe/remove wrt display. TL;DR: It's a mess. I'm trying to chop up the intel_modeset_*() functions in intel_display.c to smaller pieces, and eventually remove the extra i915_driver_modeset_*() layer from i915_drv.c. The intermediate steps aren't the prett

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/perf: Set the exclusive stream under perf->lock

2019-10-07 Thread Patchwork
== Series Details == Series: drm/i915/perf: Set the exclusive stream under perf->lock URL : https://patchwork.freedesktop.org/series/67687/ State : failure == Summary == Applying: drm/i915/perf: Set the exclusive stream under perf->lock error: sha1 information is lacking or useless (drivers/g

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/perf: Wean ourselves off dev_priv

2019-10-07 Thread Patchwork
== Series Details == Series: drm/i915/perf: Wean ourselves off dev_priv URL : https://patchwork.freedesktop.org/series/67686/ State : failure == Summary == Applying: drm/i915/perf: Wean ourselves off dev_priv error: sha1 information is lacking or useless (drivers/gpu/drm/i915/i915_drv.h). erro

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/atomic-helper: Extract drm_atomic_helper_calc_timestamping_constants()

2019-10-07 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/atomic-helper: Extract drm_atomic_helper_calc_timestamping_constants() URL : https://patchwork.freedesktop.org/series/67681/ State : success == Summary == CI Bug Log - changes from CI_DRM_7023 -> Patchwork_14687 =

Re: [Intel-gfx] [PULL] drm-misc-fixes

2019-10-07 Thread Daniel Vetter
On Thu, Oct 3, 2019 at 9:26 AM Maxime Ripard wrote: > > Hi, > > On Wed, Oct 02, 2019 at 10:06:04PM +0200, Maxime Ripard wrote: > > Hi Dave, Daniel, > > > > I hope that you enjoy XDC if you could make it this year :) > > > > Here's the first round of fixes for drm-misc > > > > Maxime > > > > drm-mi

[Intel-gfx] [CI 1/2] drm/i915/perf: Wean ourselves off dev_priv

2019-10-07 Thread Chris Wilson
Use the local uncore accessors for the GT rather than using the [not-so] magic global dev_priv mmio routines. In the process, we also teach the perf stream to use backpointers to the i915_perf rather than digging it out of dev_priv. v2: Rebase onto i915_perf_types.h Signed-off-by: Chris Wilson C

[Intel-gfx] [CI 2/2] drm/i915/perf: Set the exclusive stream under perf->lock

2019-10-07 Thread Chris Wilson
The BKL struct_mutex is no more, the only serialisation we required for setting the exclusive stream is already managed by ce->pin_mutex in gen8_configure_all_contexts(). As such, we can manipulate i915_perf.exclusive_stream underneath our own perf->lock. Signed-off-by: Chris Wilson Cc: Umesh Ner

Re: [Intel-gfx] [PATCH] drm/i915/perf: Set the exclusive stream under perf->lock

2019-10-07 Thread Lionel Landwerlin
On 07/10/2019 16:38, Chris Wilson wrote: The BKL struct_mutex is no more, the only serialisation we required for setting the exclusive stream is already managed by ce->pin_mutex in gen8_configure_all_contexts(). As such, we can manipulate i915_perf.exclusive_stream underneath our own perf->lock.

Re: [Intel-gfx] [PATCH] drm/i915/perf: Wean ourselves off dev_priv

2019-10-07 Thread Lionel Landwerlin
On 07/10/2019 16:36, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-10-07 14:33:02) On 07/10/2019 16:03, Chris Wilson wrote: Use the local uncore accessors for the GT rather than using the [not-so] magic global dev_priv mmio routines. In the process, we also teach the perf stream to use ba

[Intel-gfx] [PULL] drm-intel-next

2019-10-07 Thread Joonas Lahtinen
6fe7864acc33f0c62bd9d866b722: drm/i915: Update DRIVER_DATE to 20191007 (2019-10-07 15:24:47 +0300) UAPI Changes: - Never allow userptr into the mappable GGTT (Chris) No existing users. Avoid anyone from even trying to spare a d

[Intel-gfx] [PATCH] drm/i915/perf: Set the exclusive stream under perf->lock

2019-10-07 Thread Chris Wilson
The BKL struct_mutex is no more, the only serialisation we required for setting the exclusive stream is already managed by ce->pin_mutex in gen8_configure_all_contexts(). As such, we can manipulate i915_perf.exclusive_stream underneath our own perf->lock. Signed-off-by: Chris Wilson Cc: Umesh Ner

Re: [Intel-gfx] [PATCH] drm/i915/perf: Wean ourselves off dev_priv

2019-10-07 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-10-07 14:33:02) > On 07/10/2019 16:03, Chris Wilson wrote: > > Use the local uncore accessors for the GT rather than using the [not-so] > > magic global dev_priv mmio routines. In the process, we also teach the > > perf stream to use backpointers to the i915_perf rat

Re: [Intel-gfx] [PATCH] drm/i915/perf: Wean ourselves off dev_priv

2019-10-07 Thread Lionel Landwerlin
On 07/10/2019 16:03, Chris Wilson wrote: Use the local uncore accessors for the GT rather than using the [not-so] magic global dev_priv mmio routines. In the process, we also teach the perf stream to use backpointers to the i915_perf rather than digging it out of dev_priv. Signed-off-by: Chris W

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for DC3CO Support for TGL test with DC3CO IGT (rev2)

2019-10-07 Thread Vudum, Lakshminarayana
Anshuman, I have addressed below failures and updated filters for Bug 111872 . Lakshmi. -Original Message- From: Gupta, Anshuman Sent: Monday, October 7, 2019 2:02 PM To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana Cc: Deak, Imre Subject: Re: ✗ Fi.CI.BAT: failure for DC3CO

[Intel-gfx] [PATCH] drm/i915/perf: Wean ourselves off dev_priv

2019-10-07 Thread Chris Wilson
Use the local uncore accessors for the GT rather than using the [not-so] magic global dev_priv mmio routines. In the process, we also teach the perf stream to use backpointers to the i915_perf rather than digging it out of dev_priv. Signed-off-by: Chris Wilson Cc: Umesh Nerlige Ramappa Cc: Lione

Re: [Intel-gfx] [PATCH 03/12] drm/i915/gt: Restore dropped 'interruptible' flag

2019-10-07 Thread Tvrtko Ursulin
On 06/10/2019 17:49, Chris Wilson wrote: Lost in the rebasing was Tvrtko's reminder that we need to keep an uninterruptible wait around for the Ironlake VT-d w/a Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_gt_requests.c | 2 +- 1 file changed, 1 inserti

[Intel-gfx] [PATCH 2/3] drm/atomic-helper: Remove the timestamping constant update from drm_atomic_helper_update_legacy_modeset_state()

2019-10-07 Thread Ville Syrjala
From: Ville Syrjälä The timestamping constants have nothing to do with any legacy state so should not be updated from drm_atomic_helper_update_legacy_modeset_state(). Let's make everyone call drm_atomic_helper_calc_timestamping_constants() directly instead of relying on drm_atomic_helper_update_

[Intel-gfx] [PATCH 3/3] drm/i915: Refactor timestamping constants update

2019-10-07 Thread Ville Syrjala
From: Ville Syrjälä Once we do the hw vs. uapi split we can no longer use drm_atomic_helper_calc_timestamping_constants() as it'll consult the uapi state instead of the hw state. So let's just update the vblank timestamping constants whenever we update the scanline offset. We use both to convert

[Intel-gfx] [PATCH 1/3] drm/atomic-helper: Extract drm_atomic_helper_calc_timestamping_constants()

2019-10-07 Thread Ville Syrjala
From: Ville Syrjälä Put the vblank timestamping constants update loop into its own function. It has no business living inside drm_atomic_helper_update_legacy_modeset_state() so we'll be wanting to move it out entirely. As a first step we'll still call it from drm_atomic_helper_update_legacy_modes

Re: [Intel-gfx] [PATCH TRIVIAL v2] gpu: Fix Kconfig indentation

2019-10-07 Thread Jani Nikula
On Fri, 04 Oct 2019, Krzysztof Kozlowski wrote: > drivers/gpu/drm/i915/Kconfig | 12 +- > drivers/gpu/drm/i915/Kconfig.debug | 144 +++ Please split these out to a separate patch. Can't speak for others, but the patch looks like it'll be conflicts galore and

Re: [Intel-gfx] [PATCH 3/3] drm/i915/huc: improve documentation

2019-10-07 Thread Anna Karas
Hello Daniele, On Fri, Sep 27, 2019 at 02:42:43PM -0700, Daniele Ceraolo Spurio wrote: > Better explain the usage of the microcontroller and what i915 is > responsible of. While at it, fix the documentation for the auth > function, which doesn't do any pinning anymore. > > Signed-off-by: Daniele

Re: [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Add Sphinx-compatible references to struct fields

2019-10-07 Thread Jani Nikula
On Fri, 04 Oct 2019, Jonathan Neuschäfer wrote: > On Thu, Oct 03, 2019 at 06:45:56PM -, Patchwork wrote: >> == Series Details == >> >> Series: drm/i915: Add Sphinx-compatible references to struct fields >> URL : https://patchwork.freedesktop.org/series/67550/ >> State : failure >> >> == Su

Re: [Intel-gfx] [PATCH] drm/i915/vbt: Child device size remains unchanged through VBT 229

2019-10-07 Thread Jani Nikula
On Wed, 02 Oct 2019, Matt Roper wrote: > The latest documented version of the VBT is 229, but no further data has > been added to the child device definition in block 2. Update the child > device version test to eliminate the "Expected child device config size > for VBT version XXX not known; ass

  1   2   >